[PATCH 0/4] Touchscreen performance related fixes

2014-10-27 Thread Vignesh R
: Remove udelay in interrupt handler Vignesh R (2): arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter .../bindings/input/touchscreen/ti-tsc-adc.txt | 13 +++ arch/arm/boot/dts/am335x-evm.dts

[PATCH 4/4] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter

2014-10-27 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0xB000(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++- 1 file

[PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-10-27 Thread Vignesh R
disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need not be saved in reg_se_cache for clearing these steps at a later stage. Signed-off-by: Brad Griffis bgrif...@ti.com [vigne...@ti.com: Ported patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R

[PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-10-27 Thread Vignesh R
bgrif...@ti.com [vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com --- drivers/iio/adc/ti_am335x_adc.c | 2 +- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++- 2 files changed, 25 insertions(+), 19 deletions

[PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc

2014-10-27 Thread Vignesh R
. Signed-off-by: Vignesh R vigne...@ti.com --- .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt| 13 + arch/arm/boot/dts/am335x-evm.dts| 1 + 2 files changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc

[PATCH 0/3] Add support for ADC on am437x-gp and am43x-epos-evm

2014-10-31 Thread Vignesh R
are now available on am43xx. Vignesh R (3): arm: mach-omap2: omap_hwmod_33xx_43xx_ipblock_data: Move am33xx_l4_hs_hwmod to ipblock_data arm: mach-omap2: omap_hwmod_43xx_data: add hwmod support for tscadc on am43x-evm arm: boot: dts: am4372: add tscadc DT entries for am437x-evm

[PATCH 2/3] arm: mach-omap2: omap_hwmod_43xx_data: add hwmod support for tscadc on am43x-evm

2014-10-31 Thread Vignesh R
. Signed-off-by: Vignesh R vigne...@ti.com --- .../mach-omap2/omap_hwmod_33xx_43xx_common_data.h | 1 + .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 64 ++ arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 49 - arch/arm/mach-omap2

[PATCH 3/3] arm: boot: dts: am4372: add tscadc DT entries for am437x-evm and am43x-epos-evm

2014-10-31 Thread Vignesh R
This patch adds tscadc DT entries for am437x-gp-evm and am43x-epos-evm. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am4372.dtsi| 20 arch/arm/boot/dts/am437x-gp-evm.dts | 8 arch/arm/boot/dts/am43x-epos-evm.dts | 8 3 files

[PATCH 1/3] arm: mach-omap2: omap_hwmod_33xx_43xx_ipblock_data: Move am33xx_l4_hs_hwmod to ipblock_data

2014-10-31 Thread Vignesh R
-by: Vignesh R vigne...@ti.com --- arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h | 1 + arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 15 +++ arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 15 --- 3 files changed, 16 insertions(+), 15 deletions

Re: [PATCH v2 2/3] ARM: OMAP2+: hwmod: AM335x/AM43x: add hwmod support for tscadc on am43x-evm

2014-11-20 Thread Vignesh R
On 11/20/2014 12:39 PM, Paul Walmsley wrote: On Tue, 4 Nov 2014, Vignesh R wrote: This patch adds hwmod support for tscadc to work on am43xx-evm. The am33xx hwmod structures of tscadc has been moved to ipblock_data so that it can be reused in am43xx. The clock domain names are separately set

[PATCH v3 1/2] ARM: OMAP2+: hwmod: AM43x: add hwmod support for ADC on AM43xx

2014-11-21 Thread Vignesh R
This patch adds hwmod support for ADC on AM43xx. Since clockdomain and offsets of adc_tsc are different from AM33xx, ADC data has been directly added to AM43xx hwmod file. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 39

Re: [PATCH v2 2/3] ARM: OMAP2+: hwmod: AM335x/AM43x: add hwmod support for tscadc on am43x-evm

2014-11-21 Thread Vignesh R
On Friday 21 November 2014 10:56 AM, Paul Walmsley wrote: On Fri, 21 Nov 2014, Vignesh R wrote: On 11/20/2014 12:39 PM, Paul Walmsley wrote: On Tue, 4 Nov 2014, Vignesh R wrote: This patch adds hwmod support for tscadc to work on am43xx-evm. The am33xx hwmod structures of tscadc has been

[PATCH v3 0/2] Add support for ADC on am437x-gp and am43x-epos-evm

2014-11-21 Thread Vignesh R
structures betweem AM33xx and AM43xx. v2: Removed phy addresses in hwmod. Using DT instead. Removed unused ti,am4372 compatible string. Use macro to set clk domain name. Fixed subject format of all patches Vignesh R (2): ARM: OMAP2+: hwmod: AM43x: add hwmod support for ADC on AM43xx ARM: dts: AM43xx

[PATCH v3 2/2] ARM: dts: AM43xx: add tscadc DT entries for am437x-evm and am43x-epos-evm

2014-11-21 Thread Vignesh R
This patch adds tscadc DT entries for am437x-gp-evm and am43x-epos-evm. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am4372.dtsi| 20 arch/arm/boot/dts/am437x-gp-evm.dts | 8 arch/arm/boot/dts/am43x-epos-evm.dts | 8 3 files

Re: [PATCH v4 0/6] Touchscreen performance related fixes

2014-11-24 Thread Vignesh R
On Monday 24 November 2014 05:21 PM, Sebastian Andrzej Siewior wrote: * Vignesh R | 2014-11-14 10:37:25 [+0530]: This series of patches fix TSC defects related to lag in touchscreen performance and cursor jump at touch release. The lag was result of udelay in TSC interrupt handler. Cursor

Re: [PATCH 3/5] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-10 Thread Vignesh R
On Monday 10 November 2014 02:56 PM, Lee Jones wrote: On Mon, 10 Nov 2014, Lee Jones wrote: On Fri, 07 Nov 2014, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-10 Thread Vignesh R
On Friday 07 November 2014 01:30 PM, Richard Cochran wrote: On Fri, Nov 07, 2014 at 11:04:05AM +0530, Vignesh R wrote: Currently, there is too much noise in the TSC hardware that is being removed by delta filtering. The so called filter was only programmed because the fifo entries were

[PATCH v3 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering

2014-11-11 Thread Vignesh R
is more sensible than delta filering. Median filtering is applied only if number of readouts is greater than 3 else just average of co-ordinate readouts is reported. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 91 +-- 1 file

[PATCH v3 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter

2014-11-11 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0xB000(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++- 1 file

[PATCH v3 0/6] Touchscreen performance related fixes

2014-11-11 Thread Vignesh R
comments. v2: - Addressed comments by Hartmut Knaack - patch 2 was split into two as per Lee Jones comment Brad Griffis (2): input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R (4): mfd

[PATCH v3 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-11 Thread Vignesh R
of the config steps except for the charge step. Previously charge step was 1 ADC clock cycle and hence it was ignored. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/mfd/ti_am335x_tscadc.c | 7 +-- include/linux/mfd/ti_am335x_tscadc.h | 1 + 2 files changed, 6 insertions(+), 2 deletions

[PATCH v3 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for tsc

2014-11-11 Thread Vignesh R
. Signed-off-by: Vignesh R vigne...@ti.com --- .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 15 +++ arch/arm/boot/dts/am335x-evm.dts | 1 + 2 files changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc

[PATCH v3 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-11 Thread Vignesh R
[vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com Acked-by: Lee Jones lee.jo...@linaro.org --- drivers/input/touchscreen/ti_am335x_tsc.c | 56 --- include/linux/mfd/ti_am335x_tscadc.h | 3 +- 2 files changed, 24

[PATCH v3 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-11 Thread Vignesh R
bgrif...@ti.com [vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com Acked-by: Jonathan Cameron ji...@kernel.org --- drivers/iio/adc/ti_am335x_adc.c | 5 ++-- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++- 2

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-13 Thread Vignesh R
was able to fix this issue. Will post version 4 shortly. Regards Vignesh Without the patches the touchscreen works fine during the iio test. Thanks, Hannes 2014-11-06 8:42 GMT+01:00 Vignesh R vigne...@ti.com: On Monday 03 November 2014 11:39 PM, Richard Cochran wrote: On Mon, Oct 27

Re: [PATCH v2 0/3] Add support for ADC on am437x-gp and am43x-epos-evm

2014-11-13 Thread Vignesh R
On Tuesday 04 November 2014 04:45 PM, Vignesh R wrote: This series of patches enable ADC on am437x-gp-evm and am43x-epos-evm. The ADC clock hwmod data of am33xx has been moved to commom place so that both am43xx and am33xx can reuse them. tscadc DT node has been adided to am437x-gp and am43x

[PATCH v4 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-13 Thread Vignesh R
bgrif...@ti.com [vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com Acked-by: Jonathan Cameron ji...@kernel.org --- drivers/iio/adc/ti_am335x_adc.c | 5 ++-- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++- 2

[PATCH v4 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering

2014-11-13 Thread Vignesh R
is more sensible than delta filering. Median filtering is applied only if number of readouts is greater than 3 else just average of co-ordinate readouts is reported. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 91 +-- 1 file

[PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-13 Thread Vignesh R
of the config steps except for the charge step. Previously charge step was 1 ADC clock cycle and hence it was ignored. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/mfd/ti_am335x_tscadc.c | 7 +-- include/linux/mfd/ti_am335x_tscadc.h | 1 + 2 files changed, 6 insertions(+), 2 deletions

[PATCH v4 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2014-11-13 Thread Vignesh R
false pen-up events. Hence, charge delay has been made a DT parameter. Signed-off-by: Vignesh R vigne...@ti.com --- v4: - Set charge delay to 0x400 as default. Most devices function normally at this value .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 15 +++ arch

[PATCH v4 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter

2014-11-13 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0x400(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++- 1 file

[PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-13 Thread Vignesh R
[vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com --- v4: - check for PEN_IRQ bit in ADCFSM to avoid false-pen when ADC and TSC are used together. - Set charge delay to 0x400 as default. Most devices function normally at this value

[PATCH v4 0/6] Touchscreen performance related fixes

2014-11-13 Thread Vignesh R
comments. v2: - Addressed comments by Hartmut Knaack - patch 2 was split into two as per Lee Jones comment Brad Griffis (2): input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R (4): mfd

[PATCH v5 0/6] Touchscreen performance related fixes

2014-12-23 Thread Vignesh R
by Hartmut Knaack - patch 2 was split into two as per Lee Jones comment Brad Griffis (2): input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R (4): mfd: ti_am335x_tscadc: Remove unwanted

[PATCH v5 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2014-12-23 Thread Vignesh R
false pen-up events. Hence, charge delay has been made a DT parameter. Signed-off-by: Vignesh R vigne...@ti.com --- v4: - Set charge delay to 0x400 as default. Most devices function normally at this value .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 15 +++ arch/arm

[PATCH v5 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-12-23 Thread Vignesh R
bgrif...@ti.com [vigne...@ti.com: Ported the patch from v3.12 to v3.19rc1] Signed-off-by: Vignesh R vigne...@ti.com Acked-by: Jonathan Cameron ji...@kernel.org --- drivers/iio/adc/ti_am335x_adc.c | 5 ++-- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++- 2

[PATCH v5 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-12-23 Thread Vignesh R
of the config steps except for the charge step. Previously charge step was 1 ADC clock cycle and hence it was ignored. TSC steps are always disabled at the end of each conversion cycle, hence there is no need to explicitly disable TSC steps by writing 0 to REG_SE. Signed-off-by: Vignesh R vigne...@ti.com

[PATCH v5 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering

2014-12-23 Thread Vignesh R
is more sensible than delta filering. Median filtering is applied only if number of readouts is greater than 3 else just average of co-ordinate readouts is reported. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 91 +-- 1 file

[PATCH v5 5/6] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter

2014-12-23 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0x400(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R vigne...@ti.com --- v5: - print out a warning when ti,charge-delay is not specified

[PATCH v5 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-12-23 Thread Vignesh R
[vigne...@ti.com: Ported the patch from v3.12 to v3.19rc1] Signed-off-by: Vignesh R vigne...@ti.com --- v5: - enable TSC steps only on EOS interrup v4: - check for PEN_IRQ bit in ADCFSM to avoid false-pen when ADC and TSC are used together. - Set charge delay to 0x400 as default. Most

Re: [PATCH v4 0/6] Touchscreen performance related fixes

2014-11-26 Thread Vignesh R
On Monday 24 November 2014 06:05 PM, Sebastian Andrzej Siewior wrote: On 11/24/2014 01:16 PM, Vignesh R wrote: I have tried running both IIO and TSC at the same time. But I have never seen WARN_ON() even after running for close to 30 min. Can you send me the exact script, so

Re: [PATCH v4 0/6] Touchscreen performance related fixes

2014-12-12 Thread Vignesh R
On Friday 12 December 2014 02:10 AM, Sebastian Andrzej Siewior wrote: On 12/11/2014 09:34 PM, Nicolae Rosia wrote: Hello, Hi, Any updates on this series? I don't see it applied in [1] or [2]. I manage to freeze am335x-evm with those patches and I think Vignesh is looking into this.

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-06 Thread Vignesh R
On Thursday 06 November 2014 07:49 PM, Richard Cochran wrote: On Mon, Oct 27, 2014 at 04:38:28PM +0530, Vignesh R wrote: ... @@ -209,6 +214,7 @@ static void titsc_read_coordinates(struct titsc *ts_dev, unsigned int read, diff; unsigned int i, channel; unsigned int creads

Re: [PATCH 2/4] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-06 Thread Vignesh R
On Monday 03 November 2014 08:35 PM, Lee Jones wrote: On Mon, 27 Oct 2014, Vignesh R wrote: From: Brad Griffis bgrif...@ti.com TSC interrupt handler had udelay to avoid reporting of false pen-up interrupt to user space. This patch implements workaround suggesting in Advisory 1.0.31

Re: [PATCH 3/4] arm: boot: dts: am335x-evm: Make charge delay a DT parameter for tsc

2014-11-06 Thread Vignesh R
On Saturday 01 November 2014 02:39 AM, Hartmut Knaack wrote: Vignesh R schrieb am 27.10.2014 12:08: The charge delay value is by default 0xB000. But it can be set to lower values on some boards as long as false pen-ups are avoided. Lowering the value increases the sampling rate (though

Re: [PATCH 1/4] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-06 Thread Vignesh R
On Saturday 01 November 2014 02:33 AM, Hartmut Knaack wrote: Vignesh R schrieb am 27.10.2014 12:08: From: Brad Griffis bgrif...@ti.com This patch makes the initial changes required to workaround TSC-false pen-up interrupts. It is required to implement these changes in order to remove

[PATCH 1/5] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2014-11-06 Thread Vignesh R
bgrif...@ti.com [vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com --- drivers/iio/adc/ti_am335x_adc.c | 5 ++-- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++- 2 files changed, 26 insertions(+), 21

[PATCH v2 0/5] Touchscreen performance related fixes

2014-11-06 Thread Vignesh R
: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R (3): mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save ARM: dts: AM335x: Make charge delay a DT parameter for tsc input: touchscreen

[PATCH 4/5] ARM: dts: AM335x: Make charge delay a DT parameter for tsc

2014-11-06 Thread Vignesh R
. Signed-off-by: Vignesh R vigne...@ti.com --- .../devicetree/bindings/input/touchscreen/ti-tsc-adc.txt | 15 +++ arch/arm/boot/dts/am335x-evm.dts | 1 + 2 files changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti-tsc

[PATCH 2/5] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-06 Thread Vignesh R
[vigne...@ti.com: Ported the patch from v3.12 to v3.18rc2] Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 56 --- include/linux/mfd/ti_am335x_tscadc.h | 3 +- 2 files changed, 24 insertions(+), 35 deletions(-) diff --git

[PATCH 3/5] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-06 Thread Vignesh R
of the config steps except for the charge step. Previously charge step was 1 ADC clock cycle and hence it was ignored. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/mfd/ti_am335x_tscadc.c | 7 +-- include/linux/mfd/ti_am335x_tscadc.h | 1 + 2 files changed, 6 insertions(+), 2 deletions

[PATCH 5/5] input: touchscreen: ti_am335x_tsc: Use charge delay DT parameter

2014-11-06 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0xB000(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 8 +++- 1 file

Re: [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-16 Thread Vignesh R
On Sunday 16 November 2014 12:57 AM, Richard Cochran wrote: On Fri, Nov 14, 2014 at 10:37:27AM +0530, Vignesh R wrote: From: Brad Griffis bgrif...@ti.com TSC interrupt handler had udelay to avoid reporting of false pen-up interrupt to user space. This patch implements workaround suggesting

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-17 Thread Vignesh R
Hi, On Thursday 13 November 2014 05:53 PM, Vignesh R wrote: Hi, On Wednesday 12 November 2014 06:30 PM, Johannes Pointner wrote: Hello Vignesh, I tried your patch version 3 on a customized board and had some behavior I couldn't explain. If I only use the touchscreen it works fine

Re: [PATCH v4 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2014-11-17 Thread Vignesh R
On Monday 17 November 2014 01:53 PM, Richard Cochran wrote: On Mon, Nov 17, 2014 at 09:57:05AM +0530, Vignesh R wrote: My patches are based on v3.18rc2. I tested my patches on am335x-evm using tslib. No beaglebone + cape testing? Please explain touch is broken? What is the behaviour

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-17 Thread Vignesh R
On Tuesday 04 November 2014 06:07 PM, Sebastian Andrzej Siewior wrote: On 11/04/2014 12:44 PM, Vignesh R wrote: I ran following commands $ evtest /dev/input/touchscreen0 (with heavy item on touchscreen) and $ cat /sys/bus/iio/devices/iio\:device0/scan_elements/in_voltage4_en

[PATCH 1/2] phy: phy-ti-pipe3: fix inconsistent enumeration of PCIe gen2 cards

2014-12-16 Thread Vignesh R
enumerate consistently. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/phy/phy-omap-control.c | 7 +++ drivers/phy/phy-ti-pipe3.c | 10 ++ include/linux/phy/omap_control_phy.h | 6 +++--- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/phy

[PATCH 2/2] ARM: dts: DRA7X: drop id property in pcie_phy

2014-12-16 Thread Vignesh R
Since phyid is no longer used by pcie driver, this field can be dropped from the DT. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/dra7.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 63bf99be1762

[PATCH 0/2] PCIe related fixes for DRA7xx

2014-12-16 Thread Vignesh R
This patch fix inconsistent enumeration of PCIe gen2 cards on DRA7xx boards. Tested this patch series, after applying some out of the tree patches for resetting PCIe. Vignesh R (2): phy: phy-ti-pipe3: fix inconsistent enumeration of PCIe gen2 cards ARM: dts: DRA7X: drop id property

Re: [PATCH 2/3] arm: mach-omap2: omap_hwmod_43xx_data: add hwmod support for tscadc on am43x-evm

2014-11-04 Thread Vignesh R
On Friday 31 October 2014 07:14 PM, Nishanth Menon wrote: On 13:16-20141031, Vignesh R wrote: This patch adds hwmod support for tscadc to work on am43xx-evm. The am33xx hwmod structures of tscadc has been moved to ipblock_data so that it can be reused in am43xx. The clock domain names

[PATCH v2 1/3] ARM: OMAP2+: hwmod: AM335x/AM43x: Move am33xx_l4_hs_hwmod to ipblock_data

2014-11-04 Thread Vignesh R
-by: Vignesh R vigne...@ti.com --- arch/arm/mach-omap2/omap_hwmod_33xx_43xx_common_data.h | 1 + arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 15 +++ arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 15 --- 3 files changed, 16 insertions(+), 15 deletions

[PATCH v2 3/3] ARM: dts: AM43xx: add tscadc DT entries for am437x-evm and am43x-epos-evm

2014-11-04 Thread Vignesh R
This patch adds tscadc DT entries for am437x-gp-evm and am43x-epos-evm. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am4372.dtsi| 20 arch/arm/boot/dts/am437x-gp-evm.dts | 8 arch/arm/boot/dts/am43x-epos-evm.dts | 8 3 files

Re: [PATCH 3/3] arm: boot: dts: am4372: add tscadc DT entries for am437x-evm and am43x-epos-evm

2014-11-04 Thread Vignesh R
On Friday 31 October 2014 07:16 PM, Nishanth Menon wrote: On 13:16-20141031, Vignesh R wrote: This patch adds tscadc DT entries for am437x-gp-evm and am43x-epos-evm. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am4372.dtsi| 20 arch/arm/boot

[PATCH v2 0/3] Add support for ADC on am437x-gp and am43x-epos-evm

2014-11-04 Thread Vignesh R
are now available on am43xx. Changelog: v2: Removed phy addresses in hwmod. Using DT instead. Removed unused ti,am4372 compatible string. Use macro to set clk domain name. Fixed subject format of all patches Vignesh R (3): ARM: OMAP2+: hwmod: AM335x/AM43x: Move am33xx_l4_hs_hwmod to ipblock_data

[PATCH v2 2/3] ARM: OMAP2+: hwmod: AM335x/AM43x: add hwmod support for tscadc on am43x-evm

2014-11-04 Thread Vignesh R
. Signed-off-by: Vignesh R vigne...@ti.com --- .../mach-omap2/omap_hwmod_33xx_43xx_common_data.h | 1 + .../mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c | 56 ++ arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 49 --- arch/arm/mach-omap2

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-04 Thread Vignesh R
On Monday 03 November 2014 05:47 PM, Sebastian Andrzej Siewior wrote: On 10/27/2014 08:02 PM, Griffis, Brad wrote: On 10/27/2014 12:34 PM, Sebastian Andrzej Siewior wrote: Do we really need #3 (and then #4)? Given the complexity we have already, is there any benefit by decreasing this

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-05 Thread Vignesh R
On Tuesday 04 November 2014 06:07 PM, Sebastian Andrzej Siewior wrote: On 11/04/2014 12:44 PM, Vignesh R wrote: I ran following commands $ evtest /dev/input/touchscreen0 (with heavy item on touchscreen) and $ cat /sys/bus/iio/devices/iio\:device0/scan_elements/in_voltage4_en

Re: [PATCH 0/4] Touchscreen performance related fixes

2014-11-05 Thread Vignesh R
On Monday 03 November 2014 11:39 PM, Richard Cochran wrote: On Mon, Oct 27, 2014 at 04:38:27PM +0530, Vignesh R wrote: This series of patches fix TSC defects related to lag in touchscreen performance and cursor jump at touch release. The lag was result of udelay in TSC interrupt handler

Re: [PATCH v4 0/6] Touchscreen performance related fixes

2014-12-01 Thread Vignesh R
Hi Sebastian, On Monday 24 November 2014 05:21 PM, Sebastian Andrzej Siewior wrote: * Vignesh R | 2014-11-14 10:37:25 [+0530]: This series of patches fix TSC defects related to lag in touchscreen performance and cursor jump at touch release. The lag was result of udelay in TSC interrupt

Re: [PATCH v4 0/6] Touchscreen performance related fixes

2014-12-01 Thread Vignesh R
Hi, On Monday 01 December 2014 03:29 PM, Sebastian Andrzej Siewior wrote: On 12/01/2014 10:53 AM, Vignesh R wrote: Hi Sebastian, Hi Vignesh, I fixed the issue that was triggering the WARN_ON(). I think it would be better if you tested these patches, before I posted them on the mainline

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-02-04 Thread Vignesh R
On Wednesday 21 January 2015 03:44 PM, Vignesh R wrote: On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote: On Tue, 20 Jan 2015, R, Vignesh wrote: On 1/20/2015 5:23 PM, Lee Jones wrote: On Wed, 07 Jan 2015, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-01-21 Thread Vignesh R
On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote: On Tue, 20 Jan 2015, R, Vignesh wrote: On 1/20/2015 5:23 PM, Lee Jones wrote: On Wed, 07 Jan 2015, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC

[PATCH v6 1/6] input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps

2015-01-06 Thread Vignesh R
bgrif...@ti.com [vigne...@ti.com: Ported the patch from v3.12 to v3.19rc1] Signed-off-by: Vignesh R vigne...@ti.com Acked-by: Jonathan Cameron ji...@kernel.org --- drivers/iio/adc/ti_am335x_adc.c | 5 ++-- drivers/input/touchscreen/ti_am335x_tsc.c | 42 ++- 2

[PATCH v6 4/6] input: touchscreen: ti_am335x_tsc: Read charge delay from DT

2015-01-06 Thread Vignesh R
This patch reads charge delay from tsc DT node and writes to REG_CHARGEDELAY register. If the charge delay is not specified in DT then default value of 0x400(CHARGEDLY_OPENDLY) is used. Signed-off-by: Vignesh R vigne...@ti.com --- v6: - Move Documentation from DT patch to driver code. v5

[PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2015-01-06 Thread Vignesh R
[vigne...@ti.com: Ported the patch from v3.12 to v3.19rc1] Signed-off-by: Vignesh R vigne...@ti.com --- v5: - enable TSC steps only on EOS interrup v4: - check for PEN_IRQ bit in ADCFSM to avoid false-pen when ADC and TSC are used together. - Set charge delay to 0x400 as default. Most devices

[PATCH v6 6/6] input: touchscreen: ti_am335x_tsc: Replace delta filtering with median filtering

2015-01-06 Thread Vignesh R
is more sensible than delta filering. Median filtering is applied only if number of readouts is greater than 3 else just average of co-ordinate readouts is reported. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 92 +-- 1 file

[PATCH v6 5/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2015-01-06 Thread Vignesh R
false pen-up events. Hence, charge delay has been made a DT parameter. Signed-off-by: Vignesh R vigne...@ti.com Acked-by: Tony Lindgren t...@atomide.com --- arch/arm/boot/dts/am335x-evm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts

[PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-01-06 Thread Vignesh R
of the config steps except for the charge step. Previously charge step was 1 ADC clock cycle and hence it was ignored. TSC steps are always disabled at the end of each conversion cycle, hence there is no need to explicitly disable TSC steps by writing 0 to REG_SE. Signed-off-by: Vignesh R vigne...@ti.com

[PATCH v6 0/6] Touchscreen performance related fixes

2015-01-06 Thread Vignesh R
: - Addressed comments by Hartmut Knaack - patch 2 was split into two as per Lee Jones comment Brad Griffis (2): input: touchscreen: ti_am335x_tsc Interchange touchscreen and ADC steps input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler Vignesh R (4): mfd

Re: [PATCH v5 4/6] ARM: dts: AM335x: Make charge delay a DT parameter for TSC

2015-01-06 Thread Vignesh R
On Friday 02 January 2015 10:39 PM, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [141223 23:07]: The charge delay value is by default 0x400. But it can be set to lower values on some boards, as long as false pen-ups are avoided. Lowering the value increases the sampling rate (though

[PATCH 0/2] fix ehrpwm tbclk data on am33xx and am43xx

2015-02-09 Thread Vignesh R
data to reflect the right clk source. Tested on beaglebone and am437x-gp-evm. Vignesh R (2): ARM: dts: am33xx-clocks: Fix ehrpwm tbclk data on am33xx ARM: dts: am43xx-clocks: Fix ehrpwm tbclk data on am43xx arch/arm/boot/dts/am33xx-clocks.dtsi | 6 +++--- arch/arm/boot/dts/am43xx

[PATCH 1/2] ARM: dts: am33xx-clocks: Fix ehrpwm tbclk data on am33xx

2015-02-09 Thread Vignesh R
-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am33xx-clocks.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/am33xx-clocks.dtsi b/arch/arm/boot/dts/am33xx-clocks.dtsi index 712edce7d6fb..071b56aa0c7e 100644 --- a/arch/arm/boot/dts/am33xx-clocks.dtsi

[PATCH 2/2] ARM: dts: am43xx-clocks: Fix ehrpwm tbclk data on am43xx

2015-02-09 Thread Vignesh R
-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am43xx-clocks.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi index c7dc9dab93a4..cfb49686ab6a 100644 --- a/arch/arm/boot/dts/am43xx

Re: [PATCH v2 2/3] w1: masters: omap_hdq: Add support for 1-wire mode

2015-03-18 Thread Vignesh R
Gentle Ping On Monday 02 March 2015 04:19 PM, Vignesh R wrote: This patches makes following changes to omap_hdq driver - Enable 1-wire mode. - Implement w1_triplet callback to facilitate search rom procedure and auto detection of 1-wire slaves. - Proper enabling and disabling

Re: [PATCH v2 2/3] w1: masters: omap_hdq: Add support for 1-wire mode

2015-03-19 Thread Vignesh R
Gentle Ping On Monday 02 March 2015 04:19 PM, Vignesh R wrote: This patches makes following changes to omap_hdq driver - Enable 1-wire mode. - Implement w1_triplet callback to facilitate search rom procedure and auto detection of 1-wire slaves. - Proper enabling and disabling

[PATCH 0/2] iio: ti_am335x_adc: Add optional DT properties for tscadc

2015-03-31 Thread Vignesh R
and averaging helps to achieve higher sampling rates, while increasing this parameters provides greater accuracy. Hence, this patch provides DT properties to set the initial values for delays and number of averages per sample. User space control via sysfs can be added later. Vignesh R (2): iio: adc

[PATCH 2/2] iio: adc: ti_am335x_adc: make sample delay, open delay, averaging DT parameters

2015-03-31 Thread Vignesh R
in balancing speed vs accuracy. Signed-off-by: Vignesh R vigne...@ti.com --- .../bindings/input/touchscreen/ti-tsc-adc.txt | 24 ++ drivers/iio/adc/ti_am335x_adc.c| 54 +++--- 2 files changed, 72 insertions(+), 6 deletions(-) diff --git a/Documentation

[PATCH 1/2] iio: adc: ti_am335x_adc: refactor DT parsing into a function

2015-03-31 Thread Vignesh R
Refactor DT parsing into a separate function from probe() to help addition of more DT parameters later. No functional changes. Signed-off-by: Vignesh R vigne...@ti.com --- drivers/iio/adc/ti_am335x_adc.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff

[PATCH v2 2/3] w1: masters: omap_hdq: Add support for 1-wire mode

2015-03-02 Thread Vignesh R
remains unchanged. Signed-off-by: Vignesh R vigne...@ti.com --- Change log: v2: * Change compatible to ti,am4372-hdq as Arnd suggested. Documentation/devicetree/bindings/w1/omap-hdq.txt | 7 +- Documentation/w1/masters/omap-hdq | 6 + drivers/w1/masters/omap_hdq.c

[PATCH v2 3/3] ARM: dts: AM4372: update hdq compatible property

2015-03-02 Thread Vignesh R
This patch updates hdq node compatible property to ti,am4372-hdq. Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 1943fc333e7c

[PATCH v2 1/3] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W

2015-03-02 Thread Vignesh R
From: Poddar, Sourav sourav.pod...@ti.com These adds hwmod data for hdq/1w driver on AM43xx. Signed-off-by: Vignesh R vigne...@ti.com --- Change log: v2: * Add SYSC_HAS_AUTOIDLE flag. arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 36 ++ arch/arm/mach-omap2

[PATCH v2 0/3] Add support for HDQ-1W on AM43XX

2015-03-02 Thread Vignesh R
and automatically load slave drivers is added for 1-wire mode. I have tested this on am437x-gp-evm using DS18B20 as 1-wire slave. Poddar, Sourav (1): ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W Vignesh R (2): w1: masters: omap_hdq: Add support for 1-wire mode ARM: dts: AM4372: update hdq

[PATCH 0/2] Add support for HDQ-1W on AM43XX

2015-02-27 Thread Vignesh R
and automatically load slave drivers is added for 1-wire mode. I have tested this on am437x-gp-evm using DS18B20 as 1-wire slave. Poddar, Sourav (1): ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W Vignesh R (1): w1: masters: omap_hdq: Add support for 1-wire mode Documentation/devicetree

[PATCH 1/2] ARM: OMAP2: hwmod: AM43XX: Add hwmod support for HDQ-1W

2015-02-27 Thread Vignesh R
From: Poddar, Sourav sourav.pod...@ti.com This patch adds hwmod data for hdq/1w driver on AM43xx. Signed-off-by: Sourav Poddar sourav.pod...@ti.com [vigne...@ti.com: Ported patch to v4.0-rc1] Signed-off-by: Vignesh R vigne...@ti.com --- arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 36

[PATCH 2/2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-02-27 Thread Vignesh R
remains unchanged. Signed-off-by: Vignesh R vigne...@ti.com --- Documentation/devicetree/bindings/w1/omap-hdq.txt | 7 +- Documentation/w1/masters/omap-hdq | 6 + drivers/w1/masters/omap_hdq.c | 209 ++ 3 files changed, 188 insertions(+), 34

Re: [PATCH 2/2] w1: masters: omap_hdq: Add support for 1-wire mode

2015-02-27 Thread Vignesh R
Hi, On Friday 27 February 2015 03:25 PM, Arnd Bergmann wrote: On Friday 27 February 2015 14:54:17 Vignesh R wrote: +- compatible : should be ti,omap3-1w or ti,am43xx-hdq Do not use wildcards in the compatible string, use real part numbers if you don't know the actual name of the device

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-02-24 Thread Vignesh R
Hi, On Thursday 05 February 2015 11:51 AM, Vignesh R wrote: On Wednesday 21 January 2015 03:44 PM, Vignesh R wrote: On Tuesday 20 January 2015 09:34 PM, Lee Jones wrote: On Tue, 20 Jan 2015, R, Vignesh wrote: On 1/20/2015 5:23 PM, Lee Jones wrote: On Wed, 07 Jan 2015, Vignesh R wrote

Re: [PATCH v6 2/6] input: touchscreen: ti_am335x_tsc: Remove udelay in interrupt handler

2015-01-29 Thread Vignesh R
On Wednesday 07 January 2015 11:19 AM, Vignesh R wrote: From: Brad Griffis bgrif...@ti.com TSC interrupt handler had udelay to avoid reporting of false pen-up interrupt to user space. This patch implements workaround suggesting in Advisory 1.0.31 of silicon errata for am335x, thus

Re: [PATCH 0/2] iio: ti_am335x_adc: Add optional DT properties for tscadc

2015-04-14 Thread Vignesh R
Hi Hannes, On Tuesday 14 April 2015 04:46 PM, Hannes Petermaier wrote: Hi Vignesh, did you recognize my last email ? whats your opinion around that = Apologies... best regards, Hannes - Forwarded by Hannes Petermaier/Eggelsberg/AT/BR on 14.04.2015 13:14 - Hannes

Re: [PATCH 0/2] iio: ti_am335x_adc: Add optional DT properties for tscadc

2015-04-14 Thread Vignesh R
Hi Hannes, On Tuesday 14 April 2015 04:46 PM, Hannes Petermaier wrote: Hi Vignesh, did you recognize my last email ? whats your opinion around that = best regards, Hannes - Forwarded by Hannes Petermaier/Eggelsberg/AT/BR on 14.04.2015 13:14 - Hannes

  1   2   3   4   5   6   7   8   9   10   >