On 10/05/15 13:57, Greg KH wrote:
On Mon, Oct 05, 2015 at 01:48:39PM +0300, Vlad Zolotarov wrote:
On 10/05/15 10:56, Greg KH wrote:
On Mon, Oct 05, 2015 at 10:41:39AM +0300, Vlad Zolotarov wrote:
+struct msix_info {
+ int num_irqs;
+ struct msix_entry *table;
+ struct
On 10/05/15 14:47, Avi Kivity wrote:
On 10/05/2015 02:41 PM, Vlad Zolotarov wrote:
On 10/05/15 13:57, Greg KH wrote:
On Mon, Oct 05, 2015 at 01:48:39PM +0300, Vlad Zolotarov wrote:
On 10/05/15 10:56, Greg KH wrote:
On Mon, Oct 05, 2015 at 10:41:39AM +0300, Vlad Zolotarov wrote:
+struct
On 10/06/15 01:49, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 01:09:55AM +0300, Vladislav Zolotarov wrote:
How about instead of trying to invent the wheel just go and attack the problem
directly just like i've proposed already a few times in the last days: instead
of limiting the UIO li
, while I absolutely agree with u in regard to the fact that we have a
security/memory corruption threat in the current in-tree uio_pci_generic
- the solution u propose should be a matter of a separate patch and is
obviously orthogonal to this series.
thanks,
vlad
--
To unsubscribe fro
On 10/05/15 22:50, Michael S. Tsirkin wrote:
On Sun, Oct 04, 2015 at 11:43:15PM +0300, Vlad Zolotarov wrote:
This series add support for MSI and MSI-X interrupts to uio_pci_generic driver.
Currently uio_pci_generic supports only legacy INT#x interrupts source. However
there are situations
On 10/06/15 17:30, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 11:37:59AM +0300, Vlad Zolotarov wrote:
Bus mastering is easily enabled from the user space (taken from DPDK code):
static int
pci_uio_set_bus_master(int dev_fd)
{
uint16_t reg;
int ret;
ret = pread
On 10/06/15 17:38, Michael S. Tsirkin wrote:
On Mon, Oct 05, 2015 at 01:20:11PM +0300, Avi Kivity wrote:
On 10/05/2015 12:49 PM, Greg KH wrote:
On Mon, Oct 05, 2015 at 11:28:03AM +0300, Avi Kivity wrote:
Of course it has to be documented, but this just follows vfio.
Eventfd is a natural eno
On 10/06/15 16:58, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 11:23:11AM +0300, Vlad Zolotarov wrote:
Michael, how this or any other related patch is related to the problem u r
describing?
The above ability is there for years and if memory serves me
well it was u who wrote
On 10/06/15 17:56, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 05:43:50PM +0300, Vlad Zolotarov wrote:
The only "like VFIO" behavior we implement here is binding the MSI-X
interrupt notification to eventfd descriptor.
There will be more if you add some basic memory protectio
On 10/06/15 18:19, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 05:30:31PM +0300, Gleb Natapov wrote:
On Tue, Oct 06, 2015 at 05:19:22PM +0300, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 11:33:56AM +0300, Vlad Zolotarov wrote:
the solution u propose should be a matter of a
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio_pci_generic.c | 89 +++
1 file changed, 89 insertions(+)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index d0b508b..2c6e2b1 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b
uio_pci_generic example in uio-howto.tmpl.
New in v3:
- Add __iomem qualifier to temp buffer receiving ioremap value.
New in v2:
- Added #include to uio_pci_generic.c
Vlad Zolotarov (4):
uio: add ioctl support
uio_pci_generic: properly initialize PCI bars mappings towards UIO
uio_pci_g
Change the chapters related to uio_pci_generic that refer interrupt mode.
Add the relevant explanation regarding MSI and MSI-X interrupt modes
support.
Signed-off-by: Vlad Zolotarov
---
New in v4:
- Update uio_pci_generic example in uio-howto.tmpl
---
Documentation/DocBook/uio-howto.tmpl
for devices for which the original
uio_pci_generic had worked before (i.e. INT#x will be used by default).
Signed-off-by: Vlad Zolotarov
---
New in v4:
- Use portable __u32 and __s32 types from asm/types.h for
defining uio_pci_generic_irq_set fields.
- Use proper _IO macros for defining
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 8196581..714b0e5 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -704,6
On 10/06/15 18:13, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 05:40:23PM +0300, Vlad Zolotarov wrote:
I'm guessing it doesn't enable MSI though, does it?
Again, enabling MSI is a matter of a trivial patch configuring device
registers on the device BAR.
No, not really.
Su
On 10/06/15 18:00, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 05:49:21PM +0300, Vlad Zolotarov wrote:
and read/write the config space.
This means that a single userspace bug is enough to corrupt kernel
memory.
Could u, pls., provide and example of this simple bug? Because it&#
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio_pci_generic.c | 89 +++
1 file changed, 89 insertions(+)
diff --git a/drivers/uio/uio_pci_generic.c b/drivers/uio/uio_pci_generic.c
index d0b508b..2c6e2b1 100644
--- a/drivers/uio/uio_pci_generic.c
+++ b
for devices for which the original
uio_pci_generic had worked before (i.e. INT#x will be used by default).
Signed-off-by: Vlad Zolotarov
---
New in v4:
- Use portable __u32 and __s32 types from asm/types.h for
defining uio_pci_generic_irq_set fields.
- Use proper _IO macros for defining
Change the chapters related to uio_pci_generic that refer interrupt mode.
Add the relevant explanation regarding MSI and MSI-X interrupt modes
support.
Signed-off-by: Vlad Zolotarov
---
New in v4:
- Update uio_pci_generic example in uio-howto.tmpl
---
Documentation/DocBook/uio-howto.tmpl
).
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 8196581..714b0e5 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -704,6
setting into a separate patch.
- Update uio_pci_generic example in uio-howto.tmpl.
New in v3:
- Add __iomem qualifier to temp buffer receiving ioremap value.
New in v2:
- Added #include to uio_pci_generic.c
Vlad Zolotarov (4):
uio: add ioctl support
uio_pci_generic: properly
On 10/06/15 21:27, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 08:17:35PM +0300, Vlad Zolotarov wrote:
This series add support for MSI and MSI-X interrupts to uio_pci_generic driver.
Currently uio_pci_generic demands INT#x interrupts source be available. However
there are devices that
On 10/06/15 23:35, Vlad Zolotarov wrote:
On 10/06/15 21:27, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 08:17:35PM +0300, Vlad Zolotarov wrote:
This series add support for MSI and MSI-X interrupts to
uio_pci_generic driver.
Currently uio_pci_generic demands INT#x interrupts source
On 10/06/15 21:51, Alex Williamson wrote:
On Tue, 2015-10-06 at 18:23 +0300, Avi Kivity wrote:
On 10/06/2015 05:56 PM, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 05:43:50PM +0300, Vlad Zolotarov wrote:
The only "like VFIO" behavior we implement here is binding the MSI-X
On 10/07/15 00:58, Stephen Hemminger wrote:
Go ahead and submit a seperate taint bit for UIO as a patch.
This patch already does this.
thanks,
vlad
On Tue, Oct 6, 2015 at 10:41 PM, Alex Williamson
mailto:alex.william...@redhat.com>> wrote:
On Tue, 2015-10-06 at 22:32
On 10/07/15 09:53, Avi Kivity wrote:
On 10/07/2015 12:58 AM, Stephen Hemminger wrote:
Go ahead and submit a seperate taint bit for UIO as a patch.
Taint should only be applied if bus mastering is enabled (to avoid
annoying the users of the original uio use case)
Pls., note that this seri
On 10/07/15 11:00, Vlad Zolotarov wrote:
On 10/07/15 09:53, Avi Kivity wrote:
On 10/07/2015 12:58 AM, Stephen Hemminger wrote:
Go ahead and submit a seperate taint bit for UIO as a patch.
Taint should only be applied if bus mastering is enabled (to avoid
annoying the users of the
On 10/07/15 00:33, Stephen Hemminger wrote:
On Tue, 6 Oct 2015 20:17:36 +0300
Vlad Zolotarov wrote:
Add the ability for underlying device drivers to register the ioctl
commands. This is useful when some interaction with the user space
beyond sysfs capabilities is required, e.g. query the
On 10/07/15 11:17, Vlad Zolotarov wrote:
On 10/07/15 00:33, Stephen Hemminger wrote:
On Tue, 6 Oct 2015 20:17:36 +0300
Vlad Zolotarov wrote:
Add the ability for underlying device drivers to register the ioctl
commands. This is useful when some interaction with the user space
beyond
On 10/07/15 01:51, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 11:35:27PM +0300, Vlad Zolotarov wrote:
On 10/06/15 21:27, Michael S. Tsirkin wrote:
On Tue, Oct 06, 2015 at 08:17:35PM +0300, Vlad Zolotarov wrote:
This series add support for MSI and MSI-X interrupts to uio_pci_generic
On 10/07/15 11:46, Greg KH wrote:
On Tue, Oct 06, 2015 at 08:17:36PM +0300, Vlad Zolotarov wrote:
Add the ability for underlying device drivers to register the ioctl
commands. This is useful when some interaction with the user space
beyond sysfs capabilities is required, e.g. query the
On 10/07/15 13:42, Michael S. Tsirkin wrote:
On Wed, Oct 07, 2015 at 11:38:12AM +0300, Vlad Zolotarov wrote:
So, as u may see everything that could be addressed have been addressed
Yea. Wrt upstream you've chosen a wrong approach, it creates issues that
can't be addressed.
I
On 10/07/15 16:44, Vlad Zolotarov wrote:
On 10/07/15 13:42, Michael S. Tsirkin wrote:
On Wed, Oct 07, 2015 at 11:38:12AM +0300, Vlad Zolotarov wrote:
So, as u may see everything that could be addressed have been addressed
Yea. Wrt upstream you've chosen a wrong approach, it creates i
On 10/07/15 20:21, Greg KH wrote:
On Wed, Oct 07, 2015 at 11:55:01AM +0300, Vlad Zolotarov wrote:
On 10/07/15 11:46, Greg KH wrote:
On Tue, Oct 06, 2015 at 08:17:36PM +0300, Vlad Zolotarov wrote:
Add the ability for underlying device drivers to register the ioctl
commands. This is useful
On 10/07/15 21:05, Stephen Hemminger wrote:
Thinking more of a custom filesystem like configfs
Why would configfs be better?
I imagine the final files layout as follows: uioY device that would have
enabled MSI-X would have a separate uio/uioY/msix/irqZ for each IRQ[Z]
MSI-X vector.
And t
On 08/27/2015 10:42 PM, Jason Wang wrote:
>
>
> On 08/27/2015 06:43 PM, Michael S. Tsirkin wrote:
>> On Wed, Aug 26, 2015 at 01:45:30PM +0800, Jason Wang wrote:
>>>
>>> On 08/26/2015 12:32 AM, Vlad Yasevich wrote:
>>>> On 08/25/2015 07:30 AM, J
Change the chapters related to uio_pci_generic that refer interrupt mode.
Add the relevant explanation regarding MSI and MSI-X interrupt modes
support.
Signed-off-by: Vlad Zolotarov
---
Documentation/DocBook/uio-howto.tmpl | 29 ++---
1 file changed, 26 insertions(+), 3
by default).
Vlad Zolotarov (3):
uio: add ioctl support
uio_pci_generic: add MSI/MSI-X support
Documentation: update uio-howto
Documentation/DocBook/uio-howto.tmpl | 29 ++-
drivers/uio/uio.c| 15 ++
drivers/uio/uio_pci_generic.c
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 8196581..714b0e5 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -704,6
ry the maximum number of IRQs.
- UIO_PCI_GENERIC_IRQ_SET: bind the IRQ to eventfd (similar to vfio).
- Add mappings to all bars (memory and portio): some devices have
registers related to MSI/MSI-X handling outside BAR0.
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio_pci_generic.c
mment... ;)
thanks,
vlad
On 10/02/15 04:39, Alexander Duyck wrote:
On 10/01/2015 05:04 PM, Stephen Hemminger wrote:
On Thu, 1 Oct 2015 16:43:23 -0700
Alexander Duyck wrote:
Yes, but in the case of something like a VF it is going to just make a
bigger mess of things since INTx doesn't
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 8196581..714b0e5 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -704,6
Change the chapters related to uio_pci_generic that refer interrupt mode.
Add the relevant explanation regarding MSI and MSI-X interrupt modes
support.
Signed-off-by: Vlad Zolotarov
---
Documentation/DocBook/uio-howto.tmpl | 29 ++---
1 file changed, 26 insertions(+), 3
be used by default).
New in v2:
- Added #include to uio_pci_generic.c
Vlad Zolotarov (3):
uio: add ioctl support
uio_pci_generic: add MSI/MSI-X support
Documentation: update uio-howto
Documentation/DocBook/uio-howto.tmpl | 29 ++-
drivers/uio/uio.c| 15 ++
d
ry the maximum number of IRQs.
- UIO_PCI_GENERIC_IRQ_SET: bind the IRQ to eventfd (similar to vfio).
- Add mappings to all bars (memory and portio): some devices have
registers related to MSI/MSI-X handling outside BAR0.
Signed-off-by: Vlad Zolotarov
---
New in v2:
- Added #inclu
be used by default).
New in v3:
- Add __iomem qualifier to temp buffer receiving ioremap value.
New in v2:
- Added #include to uio_pci_generic.c
Vlad Zolotarov (3):
uio: add ioctl support
uio_pci_generic: add MSI/MSI-X support
Documentation: update uio-howto
Documentation/DocBook/uio-
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 8196581..714b0e5 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -704,6
Change the chapters related to uio_pci_generic that refer interrupt mode.
Add the relevant explanation regarding MSI and MSI-X interrupt modes
support.
Signed-off-by: Vlad Zolotarov
---
Documentation/DocBook/uio-howto.tmpl | 29 ++---
1 file changed, 26 insertions(+), 3
ry the maximum number of IRQs.
- UIO_PCI_GENERIC_IRQ_SET: bind the IRQ to eventfd (similar to vfio).
- Add mappings to all bars (memory and portio): some devices have
registers related to MSI/MSI-X handling outside BAR0.
Signed-off-by: Vlad Zolotarov
---
New in v3:
- Add __iomem qualif
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index 8196581..714b0e5 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -704,6
ry the maximum number of IRQs.
- UIO_PCI_GENERIC_IRQ_SET: bind the IRQ to eventfd (similar to vfio).
- Add mappings to all bars (memory and portio): some devices have
registers related to MSI/MSI-X handling outside BAR0.
Signed-off-by: Vlad Zolotarov
---
New in v3:
- Add __iomem qualif
Change the chapters related to uio_pci_generic that refer interrupt mode.
Add the relevant explanation regarding MSI and MSI-X interrupt modes
support.
Signed-off-by: Vlad Zolotarov
---
Documentation/DocBook/uio-howto.tmpl | 29 ++---
1 file changed, 26 insertions(+), 3
be used by default).
New in v3:
- Add __iomem qualifier to temp buffer receiving ioremap value.
New in v2:
- Added #include to uio_pci_generic.c
Vlad Zolotarov (3):
uio: add ioctl support
uio_pci_generic: add MSI/MSI-X support
Documentation: update uio-howto
Documentation/DocBook/uio-
This is the same v3 but with the correct email address of Greg. In the
first iteration the first letter of the email was missing... ;)
On 10/04/15 23:43, Vlad Zolotarov wrote:
This series add support for MSI and MSI-X interrupts to uio_pci_generic driver.
Currently uio_pci_generic supports
On 10/04/15 22:03, Greg KH wrote:
On Sun, Oct 04, 2015 at 07:49:35PM +0300, Vlad Zolotarov wrote:
FYI: I've just posted to linux-kernel list patches that add support for both
MSI and MSI-X interrupt modes to uio_pci_generic driver.
It addresses most (all) remarks on this thread and also
On 10/05/15 06:03, Greg KH wrote:
On Sun, Oct 04, 2015 at 11:43:16PM +0300, Vlad Zolotarov wrote:
Signed-off-by: Vlad Zolotarov
---
drivers/uio/uio.c | 15 +++
include/linux/uio_driver.h | 3 +++
2 files changed, 18 insertions(+)
You add an ioctl yet fail to
On 10/05/15 06:11, Greg KH wrote:
On Sun, Oct 04, 2015 at 11:43:17PM +0300, Vlad Zolotarov wrote:
Add support for MSI and MSI-X interrupt modes:
- Interrupt mode selection order is:
INT#X (for backward compatibility) -> MSI-X -> MSI.
- Add ioctl() co
On 10/05/15 11:41, Stephen Hemminger wrote:
On Sun, 4 Oct 2015 23:43:17 +0300
Vlad Zolotarov wrote:
+static int setup_maps(struct pci_dev *pdev, struct uio_info *info)
+{
+ int i, m = 0, p = 0, err;
+ static const char * const bar_names[] = {
+ "BAR0",
On 10/05/15 11:41, Stephen Hemminger wrote:
On Sun, 4 Oct 2015 23:43:17 +0300
Vlad Zolotarov wrote:
+static int setup_maps(struct pci_dev *pdev, struct uio_info *info)
+{
+ int i, m = 0, p = 0, err;
+ static const char * const bar_names[] = {
+ "BAR0",
On 10/05/15 12:08, Vlad Zolotarov wrote:
On 10/05/15 11:41, Stephen Hemminger wrote:
On Sun, 4 Oct 2015 23:43:17 +0300
Vlad Zolotarov wrote:
+static int setup_maps(struct pci_dev *pdev, struct uio_info *info)
+{
+int i, m = 0, p = 0, err;
+static const char * const bar_names
On Tue, Nov 20, 2018 at 2:17 PM Dennis Zhou wrote:
>
> Hi Eddie, Vlad, and Willem,
>
> A few people mentioned to me that you guys were experiencing issues with
> the percpu memory allocator. I saw the talk slides mention the
> following two bullets:
>
> 1) allocation p
On Wed 23 May 2018 at 23:14, Cong Wang wrote:
> On Wed, May 23, 2018 at 1:52 AM, Vlad Buslov wrote:
>> Initial net_device implementation used ingress_lock spinlock to synchronize
>> ingress path of device. This lock was used in both process and bh context.
>> In some code
On Thu 24 May 2018 at 23:34, Cong Wang wrote:
> On Mon, May 14, 2018 at 7:27 AM, Vlad Buslov wrote:
>> Currently, all netlink protocol handlers for updating rules, actions and
>> qdiscs are protected with single global rtnl lock which removes any
>> possibility for parall
Retry check-insert sequence in action init functions if action with same
index was inserted concurrently.
Signed-off-by: Vlad Buslov
---
net/sched/act_bpf.c| 8 +++-
net/sched/act_connmark.c | 8 +++-
net/sched/act_csum.c | 8 +++-
net/sched/act_gact.c | 8
Implement functions to atomically update and free action cookie
using rcu mechanism.
Signed-off-by: Vlad Buslov
---
include/net/act_api.h | 2 +-
include/net/pkt_cls.h | 1 +
net/sched/act_api.c | 44 ++--
3 files changed, 32 insertions(+), 15
Implement delete function that is required to delete actions without
holding rtnl lock. Use action API function that atomically deletes action
only if it is still in action idr. This implementation prevents concurrent
threads from deleting same action twice.
Signed-off-by: Vlad Buslov
---
net
'delete' function and 'unlocked' flag.
- Change action API to work with actions in lockless manner based on
primitives implemented in previous patches.
- Extend action API with new functions necessary to implement unlocked
actions.
Vlad Buslov (14):
net: sched: use rcu for
Implement new action API function to atomically delete action with
specified index and to atomically insert unique action. These functions are
required to implement init and delete functions for specific actions that
do not rely on rtnl lock.
Signed-off-by: Vlad Buslov
---
include/net/act_api.h
Extend rate estimator new and replace APIs with additional spinlock
parameter used by lockless actions to protect rate_est pointer from
concurrent modification.
Signed-off-by: Vlad Buslov
---
include/net/gen_stats.h| 2 ++
net/core/gen_estimator.c | 58
Substitute calls to action insert function with calls to action insert
unique function that warns if insertion overwrites index in idr.
Signed-off-by: Vlad Buslov
---
net/sched/act_bpf.c| 2 +-
net/sched/act_connmark.c | 2 +-
net/sched/act_csum.c | 2 +-
net/sched/act_gact.c
Add additional 'unlocked' argument to act API init functions.
Argument is true when rtnl lock is not taken and false otherwise.
It is required to implement actions that need to release rtnl lock before
loading kernel module and reacquire if afterwards.
Signed-off-by: Vlad Buslov
---
i
rtnl lock. Remove rtnl lock assertions that are no longer
needed.
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 98 -
net/sched/cls_api.c | 1 -
2 files changed, 82 insertions(+), 17 deletions(-)
diff --git a/net/sched/act_api.c b/net
orary reference and not expose it to userspace.
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 3f02cd1..2772276e 100644
--- a/net/sched/act_api.c
+++ b/net/sc
user must always hold reference to it.
Implement helper put list function to atomically release list of actions
after action API init code is done using them.
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 38 +-
1 file changed, 17 insertions(+), 21
Change type of action reference counter to refcount_t.
Change type of action bind counter to atomic_t.
This type is used to allow decrementing bind counter without testing
for 0 result.
Signed-off-by: Vlad Buslov
---
include/net/act_api.h | 5 +++--
net/sched/act_api.c| 32
always take reference to action before returning
successfully.
Signed-off-by: Vlad Buslov
---
net/sched/act_bpf.c| 8
net/sched/act_connmark.c | 5 +++--
net/sched/act_csum.c | 8
net/sched/act_gact.c | 5 +++--
net/sched/act_ife.c| 12
its reference and bind counters.
Implement both action search and check using new safe function.
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 38 --
1 file changed, 16 insertions(+), 22 deletions(-)
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
Extend action ops with 'delete' function. Each action type to implement its
own delete function that doesn't depend on rtnl lock.
Signed-off-by: Vlad Buslov
---
include/net/act_api.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/net/act_api.h b/include/net/act_api.
gt;Remove unsafe action idr lookup function. Instead of it, implement safe tcf
>>idr check function that atomically looks up action in idr and increments
>>its reference and bind counters.
>>
>>Implement both action search and check using new safe function.
>>
>&g
On Mon 14 May 2018 at 16:47, Jiri Pirko wrote:
> Mon, May 14, 2018 at 04:27:07PM CEST, vla...@mellanox.com wrote:
>
> [...]
>
>
>>+static int tcf_action_del_1(struct net *net, char *kind, u32 index,
>>+ struct netlink_ext_ack *extack)
>>+{
>>+ const struct tc_action_op
On Mon 14 May 2018 at 18:03, Jamal Hadi Salim wrote:
> On 14/05/18 10:27 AM, Vlad Buslov wrote:
>> Currently, all netlink protocol handlers for updating rules, actions and
>> qdiscs are protected with single global rtnl lock which removes any
>> possibility for parallelism
Underlying implementation of action map has changed and doesn't require
disabling bh anymore. Replace all action idr spinlock usage with regular
calls that do not disable bh.
Signed-off-by: Vlad Buslov
---
net/sched/act_api.c | 20 ++--
1 file changed, 10 insertions(+
Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
on teardown. Leaking pipe action causes failures in other tests.
Add additional teardown command to also flush gact actions.
Signed-off-by: Vlad Buslov
---
tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
Fix expected ip address to actually match configured ip address.
Fix test to expect single matched filter.
Signed-off-by: Vlad Buslov
---
tools/testing/selftests/tc-testing/tc-tests/filters/tests.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing
t; tc_action_net_exit include/net/act_api.h:151 [inline]
>> police_exit_net+0x168/0x360 net/sched/act_police.c:390
>
> This is really strange. It seems we still left some -EBUSY placeholders
> in the idr, however, we actually call tcf_action_destroy() to clean up
> everything in
ction insertions together")
Reported-by: syzbot+151e3e714d34ae4ce...@syzkaller.appspotmail.com
Signed-off-by: Vlad Buslov
---
include/net/act_api.h | 1 +
net/sched/act_api.c | 2 +-
net/sched/cls_api.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/net/act_api.h b/i
Adrian Bunk wrote:
> sctp_addto_param() can become static.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Ack
-vlad
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info a
Cedric Le Goater wrote:
> putting Vlad in Cc:
>
> Cedric Le Goater wrote:
>> Andrew Morton wrote:
>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc7/2.6.23-rc7-mm1/
>> I also get this compile error on s390. 'linux/scatterlist.h
Denis V. Lunev wrote:
> I have also seen this OOPS on e1000 card. So, looks like driver independent.
>
> By the way, this one has been triggered in a semi-stable way by the
> 'git-pull'
Do you have this patch:
commit 5c127c58ae9bf196d787815b1bd6b0aec5aee816
Author: David S. Miller <[EMAIL PROTEC
f (asoc->overall_error_count >= asoc->max_retrans &&
> +error != SCTP_ERROR_NO_ERROR) {
> abort = sctp_make_violation_max_retrans(asoc, chunk);
> if (abort)
> sctp_add_cmd_sf(commands, SCTP_CMD_REPLY,
This would pretty much stop all
ay.
Any message that a peer sends at this point will most likely result
in an ABORT to be send back or an association restart. Might
as well start fresh.
-vlad
> Thanks
>
> PS
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the bo
On 01/23/2015 12:10 PM, Daniel Borkmann wrote:
> On 01/23/2015 05:05 PM, Vlad Yasevich wrote:
>> On 01/23/2015 06:50 AM, Daniel Borkmann wrote:
>>> On 01/23/2015 11:25 AM, Sun Paul wrote:
>>> ...
>>>> I would like to check the behave in LKSCTP.
>>>
ture and pressure values.
>
> Signed-off-by: Irina Tirdea
Reviewed-by: Vlad Dogaru
Nice catch, this must have been lost during a refactoring.
Thanks,
Vlad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
On Thu, Jun 11, 2015 at 06:49:34PM +0300, Daniel Baluta wrote:
> Because of the ABI confusion proximity value exposed by SX9500
> was inverted.
>
> Signed-off-by: Daniel Baluta
Reviewed-by: Vlad Dogaru
Sorry for causing the confusion, it was the only proximity sensor I had
encount
On Wed 23 May 2018 at 01:10, Cong Wang wrote:
> On Mon, May 21, 2018 at 1:03 PM, Vlad Buslov wrote:
>> Initial net_device implementation used ingress_lock spinlock to synchronize
>> ingress path of device. This lock was used in both process and bh context.
>> In some code
eplace all action idr spinlock usage with regular calls that do not
disable bh.
Acked-by: Jiri Pirko
Acked-by: Jamal Hadi Salim
Signed-off-by: Vlad Buslov
---
Changes from V2 to V3:
- Expanded commit message.
Changes from V1 to V2:
- Expanded commit message.
net/sched/act_api.c | 20 ++
On Tue 15 May 2018 at 09:03, Jiri Pirko wrote:
> Mon, May 14, 2018 at 09:07:06PM CEST, vla...@mellanox.com wrote:
>>
>>On Mon 14 May 2018 at 16:47, Jiri Pirko wrote:
>>> Mon, May 14, 2018 at 04:27:07PM CEST, vla...@mellanox.com wrote:
>>>
>>> [...]
>>>
>>>
+static int tcf_action_del_1(struct
t;>after action API init code is done using them.
>>
>>Signed-off-by: Vlad Buslov
>>---
>> net/sched/act_api.c | 38 +-
>> 1 file changed, 17 insertions(+), 21 deletions(-)
>>
>
> [...]
>
>
>>@@ -1196,8 +1190,
or concurrent
>>>>modifications so user must always hold reference to it.
>>>>
>>>>Implement helper put list function to atomically release list of actions
>>>>after action API init code is done using them.
>>>>
>>>>Signed-off-b
101 - 200 of 344 matches
Mail list logo
