Re: [PATCH 0/3] Enable legacy irq mode before jump to kexec/kdump kernel

PIC(), which in the bootup path of dump kernel. But now, init_bsp_APIC doesn't initialize the apic to vitual wire mode when smp_found_config is non-zero. FYI, I'm working on this point. later i will send patches to mail list. Wei On Wed, 2016-07-20 at 10:58 +0800, Baoquan He wrote: >

[PATCH 3/3] x86/apic: Improved the setting of interrupt mode for bsp

ly through a SMP BIOS(MP table). That's not enough. It's better to do further check if APIC works with effective mode, and do some porper setting. Signed-off-by: Cao jin Signed-off-by: Wei Jiangang --- arch/x86/include/asm/io_apic.h | 5 arch/x86/kernel/apic/apic.c| 55 ++

[PATCH 2/3] x86/apic: Update comment about disabling processor focus

Fix references to discarded end_level_ioapic_irq(). Signed-off-by: Cao jin Signed-off-by: Wei Jiangang --- arch/x86/kernel/apic/apic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 0273b652c689..8e25b9b2d351 100644 --- a/arch

[PATCH 1/3] x86/apic: Remove "focus disabled" for 64bit case

[] x86_64_start_reservations+0x2f/0x31 [] x86_64_start_kernel+0x14c/0x16f Keep a consistent implementation with the setup_local_APIC(), always use processor focus for 64bit. more details refer to commit 89c38c2867eb ("x86: apic - unify setup_local_APIC") Signed-off-by: Cao jin Signed-o

Re: RFC: Fix kdump failed with 'notsc'

ping... On Tue, 2016-06-14 at 17:54 +0800, Wei Jiangang wrote: > Hi, > > When I trigger kernel crash and specify 'notsc' for capture-kernel, > The process of kdump will be blocked at calibrate_delay_converge(). > > /* wait for "start of" clock tic

Re: [PATCH v2 0/3] Fix dump-capture kernel hangs with notsc

Ping ... May I ask for some community attention to this series? I purpose is fixing the dump-capture kernel hangs in calibrate_delay_converge() while specifying notsc. Thanks in advance. wei On Tue, 2016-07-26 at 10:59 +0800, Wei Jiangang wrote: > v2: > Just about the commit ("x86/api

Re: [PATCH] vfio/pci: Fix typos in comments

ping... On Wed, 2016-08-17 at 14:37 +0800, Wei Jiangang wrote: > Signed-off-by: Wei Jiangang > --- > drivers/vfio/pci/vfio_pci_config.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c > b/drivers/vfio/

[PATCH] tools:perf: fix typo in scripts/perl/Perf-Trace-Util/README

Correct typo in tools/perf/scripts/perl/Perf-Trace-Util/README, desciptions => descriptions. Signed-off-by: Wei Jiangang --- tools/perf/scripts/perl/Perf-Trace-Util/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/README b/to

Re: [PATCH] tools: ffs-aio-example: free memory upon failure

To whom it may concern： Sorry to bother again, But any comment about this patch？ Regards, wei On Mon, 2015-11-09 at 14:16 +0800, Wei Jiangang wrote: > Free buffer to avoid memory leak upon failure occurs. > > Signed-off-by: Wei Jiangang > --- > tools/usb/ffs-aio-example/multi

[PATCH v2] tools: ffs-aio-example: clean up upon failure

Free buffer to avoid memory leak and close fd upon failure occurs. Signed-off-by: Wei Jiangang --- tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c | 6 ++ tools/usb/ffs-aio-example/simple/device_app/aio_simple.c | 6 ++ 2 files changed, 12 insertions(+) diff --git

Re: [PATCH] tools: ffs-aio-example: free memory upon failure

On Wed, 2015-11-18 at 10:46 +0100, Robert Baldyga wrote: > Hi Wei, > > On 11/18/2015 07:13 AM, Wei, Jiangang wrote: > > To whom it may concern： > > > > Sorry to bother again, > > But any comment about this patch？ > > > > Reviewed-by: Robert Baldyga

[PATCH] tools: ffs-aio-example: free memory upon failure

Free buffer to avoid memory leak upon failure occurs. Signed-off-by: Wei Jiangang --- tools/usb/ffs-aio-example/multibuff/device_app/aio_multibuff.c | 4 tools/usb/ffs-aio-example/simple/device_app/aio_simple.c | 4 2 files changed, 8 insertions(+) diff --git a/tools/usb/ffs

[PATCH] tools:testing/selftests: fix typo in futex/README

Correct typo in tools/testing/selftests/futex/README. Signed-off-by: Wei Jiangang --- tools/testing/selftests/futex/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/futex/README b/tools/testing/selftests/futex/README index 3224a049b196

[PATCH] xen/apic: Update the comment for apic_id_mask

verify_local_APIC() had been removed by commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), so apic_id_mask isn't used by it. Signed-off-by: Wei Jiangang --- arch/x86/xen/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/xen/apic.c

[PATCH] kexec: Fix kdump failure with notsc

duce the bug that can result in certain CPUs hanging if IO-APIC sends an APIC message if the lapic is disabled prematurely" And I think it's pertinent. Signed-off-by: Wei Jiangang --- arch/x86/include/asm/apic.h| 5 + arch/x86/kernel/apic/apic.c| 9

[PATCH v2] kexec: Fix kdump failure with notsc

duce the bug that can result in certain CPUs hanging if IO-APIC sends an APIC message if the lapic is disabled prematurely" And I think it's pertinent. Signed-off-by: Wei Jiangang --- arch/x86/include/asm/apic.h| 5 + arch/x86/kernel/apic/apic.c| 9

Re: [PATCH] kexec: Fix kdump failure with notsc

ed to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Wei-Jiangang/kexec-Fix-kdump-failure-with-notsc/20160707-152535 > config: x86_64-randconfig-s5-07071541 (attached as .config) > compiler: gcc-

Re: [PATCH v2] kexec: Fix kdump failure with notsc

Hi , Eric Thanks for your comments firstly. On Thu, 2016-07-07 at 12:55 -0500, Eric W. Biederman wrote: > Wei Jiangang writes: > > > If we specify the 'notsc' boot parameter for the dump-capture kernel, > > and then trigger a crash(panic) by using "ALT-SysR

RFC: Fix kdump failed with 'notsc'

Hi, When I trigger kernel crash and specify 'notsc' for capture-kernel, The process of kdump will be blocked at calibrate_delay_converge(). /* wait for "start of" clock tick */ ticks = jiffies; while (ticks == jiffies) ; /* nothing */ The reason is that the jiffies remains the same, no c

Re: [PATCH v2] kexec: Fix kdump failure with notsc

On Mon, 2016-07-11 at 18:28 +0800, Wei Jiangang wrote: > Hi , Ingo > > On Fri, 2016-07-08 at 09:38 +0200, Ingo Molnar wrote: > > * Eric W. Biederman wrote: > > > > > Sigh. Can we please just do the work to rip out the apic shutdown code > > > f

Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask

On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote: > On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: > >> verify_local_APIC() had been removed by > >> commit 4399c03c6780 ("x86/apic: Remov

[PATCH] apic: remove the unused field apic_id_mask

The only user verify_local_APIC() had been removed by commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), so no need to keep it. Signed-off-by: Wei Jiangang --- arch/x86/include/asm/apic.h | 1 - arch/x86/kernel/apic/apic_flat_64.c | 2 -- arch/x86/kernel/apic/a

[PATCH] x86/tsc: remove the unused check_tsc_disabled()

re.c"). so no need keep and export it any more. Signed-off-by: Wei Jiangang --- arch/x86/include/asm/tsc.h | 1 - arch/x86/kernel/tsc.c | 6 -- 2 files changed, 7 deletions(-) diff --git a/arch/x86/include/asm/tsc.h b/arch/x86/include/asm/tsc.h index 7428697c5b8d..a2828127afe

Re: [PATCH] x86/tsc: remove the unused check_tsc_disabled()

On Fri, 2016-07-15 at 10:34 +0200, Ingo Molnar wrote: > * Wei Jiangang wrote: > > > check_tsc_disabled() was introduced by commit c73deb6aecda ("perf/x86: > > Add ability to calculate TSC from perf sample timestamps"). > > The only caller arch_perf_update_use

Re: [PATCH 3/3] x86/apic: Improved the setting of interrupt mode for bsp

difficult to find a system with IO-APIC virtual wire mode, > maybe we can just keep it as is. Not sure if Intel engineers can help > explain and confirm this. > > That's all I can think of. > > Thanks > Baoquan > > On 07/22/16 at 04:10pm, Wei Jiangang w

Re: [PATCH 3/3] x86/apic: Improved the setting of interrupt mode for bsp

On Mon, 2016-07-25 at 16:21 +0800, Xunlei Pang wrote: > On 2016/07/25 at 11:04, Wei, Jiangang wrote: > > Hi He, > > > > Thanks for your response firstly. > > > > On Fri, 2016-07-22 at 18:40 +0800, Baoquan He wrote: > >> Hi Jiangang, > >> > &

[PATCH v2 2/3] x86/apic: Update comment about disabling processor focus

Fix references to discarded end_level_ioapic_irq(). Signed-off-by: Cao jin Signed-off-by: Wei Jiangang --- arch/x86/kernel/apic/apic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 0273b652c689..8e25b9b2d351 100644 --- a/arch

[PATCH v2 3/3] x86/apic: Improved the setting of interrupt mode for bsp

ly through a SMP BIOS(MP table). That's not enough. It's better to do further check if APIC works with effective interrupt mode, and then, do some proper setting. Signed-off-by: Cao jin Signed-off-by: Wei Jiangang --- arch/x86/include/asm/io_

[PATCH v2 0/3] Fix dump-capture kernel hangs with notsc

mments v1: The goal is to fix dump-capture kernel with notsc option hangs in calibrate_delay_converge() Wei Jiangang (3): x86/apic: Remove "focus disabled" for 64bit case x86/apic: Update comment about disabling processor focus x86/apic: Improved the setting of interrupt mode for bs

[PATCH v2 1/3] x86/apic: Remove "focus disabled" for 64bit case

[] x86_64_start_reservations+0x2f/0x31 [] x86_64_start_kernel+0x14c/0x16f Keep a consistent implementation with the setup_local_APIC(), always use processor focus for 64bit. more details refer to commit 89c38c2867eb ("x86: apic - unify setup_local_APIC") Signed-off-by: Cao jin Signed-o

Re: [PATCH v2 3/3] x86/apic: Improved the setting of interrupt mode for bsp

Hi Eric, Thanks for your response. But I have some different ideas... On Mon, 2016-07-25 at 22:53 -0500, Eric W. Biederman wrote: > Wei Jiangang writes: > > > If we specify the 'notsc' parameter for the dump-capture kernel, > > and then trigger a crash(pani

Re: [PATCH 1/2] x86/apic: shutdown local APIC before I/O APIC during crash

Hi, Ingo Thanks for your comments firstly. On Fri, 2016-07-01 at 12:36 +0200, Ingo Molnar wrote: > * Wei Jiangang wrote: > > > commit <522e66464467> disables I/O APIC before shutdown of > > the local APIC for both reboot and crash path. > > and commit <2885

Re: [PATCH v2 0/3] Fix dump-capture kernel hangs with notsc

Hi Eric, Thanks for your reply firstly. On Mon, 2016-08-01 at 12:09 -0500, Eric W. Biederman wrote: > "Wei, Jiangang" writes: > > > Ping ... > > May I ask for some community attention to this series? > > I purpose is fixing the dump-capture kernel hangs in &g

Re: [PATCH v2 3/3] x86/apic: Improved the setting of interrupt mode for bsp

Hi Eric, I have several questions about kdump and APIC mode. specific issues at the end of the mail. On Tue, 2016-08-02 at 09:26 -0500, Eric W. Biederman wrote: > "Wei, Jiangang" writes: > > > Hi Eric, > > > > Thanks for your response. > > But I have so

Re: [PATCH v2] kexec: Fix kdump failure with notsc

Hi , Ingo On Fri, 2016-07-08 at 09:38 +0200, Ingo Molnar wrote: > * Eric W. Biederman wrote: > > > Sigh. Can we please just do the work to rip out the apic shutdown code > > from the > > kexec on panic code path? > > > > I forgetting details but the only reason we have do any apic shutdown i

Re: [PATCH v2] kexec: Fix kdump failure with notsc

On Tue, 2016-07-12 at 14:52 +0800, Xunlei Pang wrote: > On 2016/07/07 at 18:17, Wei Jiangang wrote: > > If we specify the 'notsc' boot parameter for the dump-capture kernel, > > and then trigger a crash(panic) by using "ALT-SysRq-c" or "echo c > >

Re: [PATCH v2] kexec: Fix kdump failure with notsc

On Tue, 2016-07-12 at 16:21 +0800, Baoquan He wrote: > On 07/12/16 at 02:52pm, Xunlei Pang wrote: > > On 2016/07/07 at 18:17, Wei Jiangang wrote: > > > Signed-off-by: Wei Jiangang > > > --- > > > +/* Local APIC is disabled by the kernel for crash

Re: [PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing

On Thu, 2016-08-18 at 11:47 +0200, Ingo Molnar wrote: > * Wei Jiangang wrote: > > > Check the boot APIC ID firstly, > > and then setup the default routing of APIC looks better. > > > > And move default_setup_apic_routing() close to apic_bsp_setup(), > > whi

[PATCH v2 1/2] x86/smpboot: Check APIC ID before setting up default routing

) and apic_bsp_setup() are used to enable APIC mode. They two should be kept together, rather than being separated by the codes of checking APIC ID. Just like their usage in APIC_init_uniprocessor(). Signed-off-by: Wei Jiangang --- arch/x86/kernel/smpboot.c | 3 +-- 1 file changed, 1 insertion(

[PATCH v2 2/2] x86/apic: Update comment about disabling processor focus

Fix references to discarded end_level_ioapic_irq(). Signed-off-by: Wei Jiangang --- arch/x86/kernel/apic/apic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 20abd912f0e4..9d203712c146 100644 --- a/arch/x86/kernel/apic/apic.c

Re: RFC: Fix kdump failed with 'notsc'

g IO APIC and Local APIC just for a certain model C2000. do you have any suggestion to fix it? thanks in advance. PS， My machine is Lenovo's QiTianM4340, and the CPU is Intel(R) Core(TM) i5-3470 CPU @ 3.20GHz， 4Cores. Thanks, wei On Fri, 2016-06-24 at 10:41 +, Alok Kataria wrote:

[PATCH 2/2] time/tick-schede: fix typos

When investigating kdump's failure with 'notsc' and jiffies not incrementing, I found several spelling mistakes Signed-off-by: Wei Jiangang --- kernel/time/tick-sched.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/time/tick-sched.c b/k

[PATCH 1/2] x86/apic: shutdown local APIC before I/O APIC during crash

ts/specification-updates/atom-c2000-family-spec-update.pdf. IMO, It doesn't make sense that change the order of disabling between I/O APIC and local APIC just for a certain model C2000. And I couldn't find any related descriptions for Intel 64 and IA-32 Arch. so, I want to revert t

[PATCH] vfio/pci: Fix typos in comments

Signed-off-by: Wei Jiangang --- drivers/vfio/pci/vfio_pci_config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index 688691d9058d..c4f235452d81 100644 --- a/drivers/vfio/pci/vfio_pci_config.c

[PATCH 2/2] x86/apic: Update comment about disabling processor focus

Fix references to discarded end_level_ioapic_irq(). Signed-off-by: Wei Jiangang --- arch/x86/kernel/apic/apic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 20abd912f0e4..9d203712c146 100644 --- a/arch/x86/kernel/apic/apic.c

[PATCH 1/2] x86/smpboot: Check APIC ID before setting up default routing

Check the boot APIC ID firstly, and then setup the default routing of APIC looks better. And move default_setup_apic_routing() close to apic_bsp_setup(), which staying in step with the codes in APIC_init_uniprocessor(). Signed-off-by: Wei Jiangang --- arch/x86/kernel/smpboot.c | 3 +-- 1 file

[tip:x86/apic] x86/apic: Update comment about disabling processor focus

Commit-ID: 5035da41996d346c648a65c1d7a9f6469c7d358a Gitweb: http://git.kernel.org/tip/5035da41996d346c648a65c1d7a9f6469c7d358a Author: Wei Jiangang AuthorDate: Fri, 19 Aug 2016 11:22:37 +0800 Committer: Ingo Molnar CommitDate: Wed, 24 Aug 2016 11:24:33 +0200 x86/apic: Update comment

[tip:x86/apic] x86/smpboot: Check APIC ID before setting up default routing

Commit-ID: 384d9fe3741657c8ed8cd9bf30bc1d4611864d56 Gitweb: http://git.kernel.org/tip/384d9fe3741657c8ed8cd9bf30bc1d4611864d56 Author: Wei Jiangang AuthorDate: Fri, 19 Aug 2016 11:22:36 +0800 Committer: Ingo Molnar CommitDate: Wed, 24 Aug 2016 11:24:33 +0200 x86/smpboot: Check APIC ID

[tip:x86/timers] x86/tsc: Remove the unused check_tsc_disabled()

Commit-ID: c48ec42d6eae08f55685ab660f0743ed33b9f22a Gitweb: http://git.kernel.org/tip/c48ec42d6eae08f55685ab660f0743ed33b9f22a Author: Wei Jiangang AuthorDate: Fri, 15 Jul 2016 16:12:10 +0800 Committer: Ingo Molnar CommitDate: Fri, 15 Jul 2016 10:35:08 +0200 x86/tsc: Remove the unused

[tip:x86/apic] x86/apic: Remove the unused struct apic::apic_id_mask field

Commit-ID: 102bb9fef68a21f357dc813d4792666c8295bc35 Gitweb: http://git.kernel.org/tip/102bb9fef68a21f357dc813d4792666c8295bc35 Author: Wei Jiangang AuthorDate: Thu, 14 Jul 2016 10:24:06 +0800 Committer: Ingo Molnar CommitDate: Fri, 15 Jul 2016 10:39:05 +0200 x86/apic: Remove the

[tip:timers/core] timers/nohz: Fix several typos

Commit-ID: 6168f8ed01dc46a277908938294f1132d723f58d Gitweb: http://git.kernel.org/tip/6168f8ed01dc46a277908938294f1132d723f58d Author: Wei Jiangang AuthorDate: Wed, 29 Jun 2016 12:51:50 +0800 Committer: Ingo Molnar CommitDate: Fri, 1 Jul 2016 12:39:22 +0200 timers/nohz: Fix several