[PATCH v2 2/2] usb: dwc2: fix isoc split in transfer with no data

2018-05-01 Thread William Wu
SPLIT IN transaction - MDATA packet (176 bytes) - CSPLIT IN transaction - DATA0 packet (0 byte) This patch use both the length of DATA0 and qtd->isoc_split_offset to check if the DATA0 is in the second transaction. Signed-off-by: William Wu --- Changes in v2: - Modify the commit message drive

Re: [RFC] mm, THP: Map read-only text segments using large THP pages

2018-05-14 Thread William Kucharski
> On May 14, 2018, at 9:19 AM, Christopher Lameter wrote: > > Cool. This could be controlled by the faultaround logic right? If we get > fault_around_bytes up to huge page size then it is reasonable to use a > huge page directly. It isn't presently but certainly could be; for the prototype it

Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly

2019-02-28 Thread William Kucharski
> On Feb 28, 2019, at 1:33 AM, Andrey Ryabinin wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a9852ed7b97f..2d081a32c6a8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1614,8 +1614,8 @@ static __always_inline void update_lru_sizes(struct > lruvec *lruvec, > > } > > -/* > - *

Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly

2019-02-28 Thread William Kucharski
> On Feb 28, 2019, at 11:22 AM, Andrew Morton wrote: > > I don't think so. This kernedoc comment was missing its leading /**. > The patch fixes that. That makes sense; it had looked like just an extraneous asterisk.

[PATCH] arm64/stacktrace: Export save_stack_trace_regs()

2019-03-01 Thread William Cohen
similar to the ARM64 export of save_stack_trace_tsk() added in git commit e27c7fa015d6. Signed-off-by: William Cohen --- arch/arm64/kernel/stacktrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 1a29f2695ff2..d908b5e9e949

Re: [PATCH v3 0/1] mm: introduce put_user_page*(), placeholder versions

2019-03-14 Thread William Kucharski
> On Mar 14, 2019, at 7:30 AM, Jan Kara wrote: > > Well I have some crash reports couple years old and they are not from QA > departments. So I'm pretty confident there are real users that use this in > production... and just reboot their machine in case it crashes. Do you know what the use c

Re: [PATCH v2 0/3] slub: Do trivial comments fixes

2019-02-06 Thread William Kucharski
If you need it: Reviewed-by: William Kucharski

Re: CONFIG_DEBUG_VIRTUAL breaks boot on x86-32

2019-03-26 Thread William Kucharski
Does this still happen on 5.1-rc2? Do you have idea as to what max_low_pfn() gets set to on your system at boot time? From the screen shot I'm guessing it MIGHT be 0x373fe, but it's hard to know for sure. > On Mar 21, 2019, at 2:22 PM, Meelis Roos wrote: > > I tried to debug another problem

Re: CONFIG_DEBUG_VIRTUAL breaks boot on x86-32

2019-03-27 Thread William Kucharski
The dmesg output you posted confirms that max_low_pfn is indeed 0x373fe, and it appears that the value of phys_mem being checked mat be 0x3f401ff1, which translates to pfn 0x3f401, at least if what's still in registers can be believed. Since that is indeed greater than max_low_pfn, VIRTUAL_BUG

[PATCH] staging: rtl8192e: remove multiple blank lines

2021-02-13 Thread William Durand
This patch removes some blank lines in order to fix a checkpatch issue. Signed-off-by: William Durand --- This is my very first patch. drivers/staging/rtl8192e/rtllib_wx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e

[PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 11269fe6b395..1bbb9ed18e6d 100644 --- a/drivers/staging

[PATCH 00/13] bss_ht struct cleanups

2021-02-23 Thread William Durand
This patchset fixes the checkpatch issues related to the `bss_ht` struct defined in `rtl8192e/rtl819x_HT.h` (avoid camelcase). The first patch removes a blank line and the last patch reformats the struct a bit to be more consistent with the other types defined in the same file. William Durand (13

[PATCH 02/13] staging: rtl8192e: rename bdSupportHT to bd_support_ht in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++--- drivers/staging/rtl8192e/rtllib_softmac.c | 4 ++-- 4 files

[PATCH 03/13] staging: rtl8192e: rename bdHTCapBuf to bd_ht_cap_buf in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 17 + drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- drivers

[PATCH 04/13] staging: rtl8192e: rename bdHTCapLen to bd_ht_cap_len in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 drivers/staging/rtl8192e/rtllib_rx.c | 12 ++-- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 4 files

[PATCH 06/13] staging: rtl8192e: rename bdHTInfoLen to bd_ht_info_len in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++--- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 4

[PATCH 08/13] staging: rtl8192e: rename bdBandWidth to bd_bandwidth in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e

[PATCH 05/13] staging: rtl8192e: rename bdHTInfoBuf to bd_ht_info_buf in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- drivers/staging/rtl8192e/rtllib_rx.c | 13 +++-- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 4 files

[PATCH 13/13] staging: rtl8192e: reformat bss_ht struct

2021-02-23 Thread William Durand
This change uses a space instead of tabs between the type and name of each member of the struct. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 12/13] staging: rtl8192e: rename bdHT1R to bd_ht_1r in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e

[PATCH 09/13] staging: rtl8192e: rename bdRT2RTAggregation to bd_rt2rt_aggregation in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a

[PATCH 07/13] staging: rtl8192e: rename bdHTSpecVer to bd_ht_spec_ver in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 10 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a

[PATCH 10/13] staging: rtl8192e: rename bdRT2RTLongSlotTime to bd_rt2rt_long_slot_time in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 4 files

[PATCH 11/13] staging: rtl8192e: rename RT2RT_HT_Mode to rt2rt_ht_mode in bss_ht struct

2021-02-23 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 8 drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 4 files

Re: [PATCH 01/13] staging: rtl8192e: remove blank line in bss_ht struct

2021-02-24 Thread William Durand
> All these patches have the same vague commit message. It's okay if the > commit message basically restates the commit one line summary. It > should say something like: > > Fix a checkpatch warning about a blank line after an open curly brace. > > Rename FooBar to foo_bar to silence a checkpat

[PATCH v2 01/13] staging: rtl8192e: remove blank line in bss_ht struct

2021-02-24 Thread William Durand
Fix a checkpatch warning about a blank line after an open curly brace. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl8192e/rtl819x_HT.h index 11269fe6b395

[PATCH v2 00/13] bss_ht struct cleanups

2021-02-24 Thread William Durand
: Updated commit messages as per Dan Carpenter recommendation William Durand (13): staging: rtl8192e: remove blank line in bss_ht struct staging: rtl8192e: rename bdSupportHT to bd_support_ht in bss_ht struct staging: rtl8192e: rename bdHTCapBuf to bd_ht_cap_buf in bss_ht struct staging

[PATCH v2 04/13] staging: rtl8192e: rename bdHTCapLen to bd_ht_cap_len in bss_ht struct

2021-02-24 Thread William Durand
Rename bdHTCapLen to bd_ht_cap_len to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 8 drivers/staging/rtl8192e/rtllib_rx.c | 12 ++-- drivers

[PATCH v2 02/13] staging: rtl8192e: rename bdSupportHT to bd_support_ht in bss_ht struct

2021-02-24 Thread William Durand
Rename bdSupportHT to bd_support_ht to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 14 +++--- drivers

[PATCH v2 03/13] staging: rtl8192e: rename bdHTCapBuf to bd_ht_cap_buf in bss_ht struct

2021-02-24 Thread William Durand
Rename bdHTCapBuf to bd_ht_cap_buf to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 17 + drivers

[PATCH v2 07/13] staging: rtl8192e: rename bdHTSpecVer to bd_ht_spec_ver in bss_ht struct

2021-02-24 Thread William Durand
Rename bdHTSpecVer to bd_ht_spec_ver to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 10 +- 3 files

[PATCH v2 10/13] staging: rtl8192e: rename bdRT2RTLongSlotTime to bd_rt2rt_long_slot_time in bss_ht struct

2021-02-24 Thread William Durand
Rename bdRT2RTLongSlotTime to bd_rt2rt_long_slot_time to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 4

[PATCH v2 12/13] staging: rtl8192e: rename bdHT1R to bd_ht_1r in bss_ht struct

2021-02-24 Thread William Durand
Rename bdHT1R to bd_ht_1r to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e

[PATCH v2 05/13] staging: rtl8192e: rename bdHTInfoBuf to bd_ht_info_buf in bss_ht struct

2021-02-24 Thread William Durand
Rename bdHTInfoBuf to bd_ht_info_buf to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- drivers/staging/rtl8192e/rtllib_rx.c | 13 +++-- drivers

[PATCH v2 06/13] staging: rtl8192e: rename bdHTInfoLen to bd_ht_info_len in bss_ht struct

2021-02-24 Thread William Durand
Rename bdHTInfoLen to bd_ht_info_len to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 14

[PATCH v2 11/13] staging: rtl8192e: rename RT2RT_HT_Mode to rt2rt_ht_mode in bss_ht struct

2021-02-24 Thread William Durand
Rename RT2RT_HT_Mode to rt2rt_ht_mode to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl819x_HT.h| 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c| 8 drivers

[PATCH v2 08/13] staging: rtl8192e: rename bdBandWidth to bd_bandwidth in bss_ht struct

2021-02-24 Thread William Durand
Rename bdBandWidth to bd_bandwidth to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH v2 09/13] staging: rtl8192e: rename bdRT2RTAggregation to bd_rt2rt_aggregation in bss_ht struct

2021-02-24 Thread William Durand
Rename bdRT2RTAggregation to bd_rt2rt_aggregation to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- drivers/staging/rtl8192e/rtl819x_HTProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 6

[PATCH v2 13/13] staging: rtl8192e: reformat bss_ht struct

2021-02-24 Thread William Durand
This change uses a space instead of tabs between the type and name of each member of the struct. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_HT.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

[PATCH 2/3] staging: rtl8192e: rename FragNum to frag_num in sequence_control union

2021-02-17 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h index 34d66b8f5155..3e5bd3fc78ce 100644

[PATCH 1/3] staging: rtl8192e: rename ShortData to short_data in sequence_control union

2021-02-17 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 0/3] staging: rtl8192e: sequence_control union cleanups

2021-02-17 Thread William Durand
This patchset fixes the checkpatch issues related to the `sequence_control` union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). William Durand (3): staging: rtl8192e: rename ShortData to short_data in sequence_control union staging: rtl8192e: rename FragNum to frag_num in

[PATCH 3/3] staging: rtl8192e: rename SeqNum to seq_num in sequence_control union

2021-02-17 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 0/6] staging: rtl8192e: ba_param_set union cleanups

2021-02-19 Thread William Durand
This patchset fixes the checkpatch issues related to the `ba_param_set` union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). William Durand (6): staging: rtl8192e: rename charData to char_data in ba_param_set union staging: rtl8192e: rename shortData to short_data in ba_param_set

[PATCH 1/6] staging: rtl8192e: rename charData to char_data in ba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h index b2a784fa051e..4fdff19bb4ae 100644

[PATCH 3/6] staging: rtl8192e: rename BAPolicy to ba_policy in ba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 2/6] staging: rtl8192e: rename shortData to short_data in ba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 4/6] staging: rtl8192e: rename BufferSize to buffer_size in ba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 5/6] staging: rtl8192e: rename AMSDU_Support to amsdu_support in ba_param_set union

2021-02-19 Thread William Durand
This change does not fix a checkpatch issue but it is more consistent with the rest of the union. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 6/6] staging: rtl8192e: rename TID to tid in ba_param_set union

2021-02-19 Thread William Durand
This change uses lowercase for a field name to be more consistent with the rest of the union. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git

Hello dear

2021-01-28 Thread Dr.Tracy William
Tracy William, I am from the United States of America,but presently live and work in England. Pls reply to my personal email (tracymedicinem...@gmail.com) I will send my details and pictures as soon as i hear from you. bye Tracy Dr Tracy William

Re: [PATCH 1/1] netfilter: nat: add range checks for access to nf_nat_l[34]protos[]

2020-07-30 Thread William Mcvicker
Hi Pablo, Yes, I believe this oops is only triggered by userspace when the user specifically passes in an invalid nf_nat_l3protos index. I'm happy to re-work the patch to check for this in ctnetlink_create_conntrack(). > BTW, do you have a Fixes: tag for this? This will be useful for > -stable ma

Re: [PATCH] memremap: Convert devmap static branch to {inc,dec}

2020-08-11 Thread William Kucharski
Looks good to me. Reviewed-by: William Kucharski > On Aug 10, 2020, at 5:53 PM, ira.we...@intel.com wrote: > > From: Ira Weiny > > While reviewing Protection Key Supervisor support it was pointed out > that using a counter to track static branch enable was an anti-pattern

Re: [PATCH 1/1] netfilter: nat: add range checks for access to nf_nat_l[34]protos[]

2020-07-31 Thread William Mcvicker
dd it to this thread with the re-worked patch. Thanks, Will On 07/31/2020, Pablo Neira Ayuso wrote: > Hi William, > > On Fri, Jul 31, 2020 at 12:26:11AM +, William Mcvicker wrote: > > Hi Pablo, > > > > Yes, I believe this oops is only triggered by userspace when the

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-11 Thread William Roche
Thank you for your clarification, and let me explain what I was talking about before providing my last code version. kmsg_dump(KMSG_DUMP_PANIC); + panic_flush_to_console(); > > This is wrong. kmsg_dump() flushes the messages into the registered > dumpers, e.g. pstore. It han

Re: [PATCH v1] panic: push panic() messages to the console even from the MCE nmi handler

2021-01-07 Thread William Roche
On 06/01/2021 05:35, Sergey Senozhatsky wrote: > On (21/01/04 16:15), “William Roche wrote: > [..] >> diff --git a/kernel/panic.c b/kernel/panic.c >> index 332736a..eb90cc0 100644 >> --- a/kernel/panic.c >> +++ b/kernel/panic.c >> @@ -166,6 +166,15 @@ s

Re: [PATCH] mm, thp: Relax the VM_DENYWRITE constraint on file-backed THPs

2021-03-23 Thread William Kucharski
I like this, it reminds me of the changes I proposed a few years ago to try to automatically map read-only text regions of appropriate sizes and alignment with THPs. My concern had always been whether commercial software and distro vendors would buy into supplying the appropriate linker flags when

Re: [PATCH] mm/filemap: Drop check for truncated page after I/O

2021-03-04 Thread William Kucharski
LGTM. Reviewed-by: William Kucharski > On Mar 3, 2021, at 3:25 PM, Matthew Wilcox (Oracle) > wrote: > > If the I/O completed successfully, the page will remain Uptodate, > even if it is subsequently truncated. If the I/O completed with an error, > this check would cause u

Re: [PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-03-29 Thread William Roche
On 26/03/2021 23:43, Borislav Petkov wrote: On Fri, Mar 26, 2021 at 11:24:43PM +0100, William Roche wrote: What we want is to make cec_add_elem() to return !0 value only when the given pfn triggered an action, so that its callers should log the error. No, this is not what the CEC does - it

[PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-03-26 Thread William Roche
From: William Roche The Corrected Error events collected by the cec_add_elem() have to be consistently filtered out. We fix the case where the value of find_elem() to find the slot of a pfn was mistakenly used as the return value of the function. Now the MCE notifiers chain relying on

Re: [PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-03-26 Thread William Roche
On 26/03/2021 20:02, Borislav Petkov wrote: On Fri, Mar 26, 2021 at 02:30:29PM -0400, “William Roche wrote: From: William Roche The Corrected Error events collected by the cec_add_elem() have to be consistently filtered out. We fix the case where the value of find_elem() to find the slot of a

[PATCH v2] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-04-06 Thread William Roche
From: William Roche The Corrected Error events collected by the cec_add_elem() have to be consistently filtered out. We fix the case where the value of find_elem() to find the slot of a pfn was mistakenly used as the return value of the function. Now the MCE notifiers chain relying on

Re: [PATCH] mm, thp: Relax the VM_DENYWRITE constraint on file-backed THPs

2021-04-06 Thread William Kucharski
Sounds good. Reviewed-by: William Kucharski > On Apr 6, 2021, at 11:48 AM, Collin Fijalkovich > wrote: > > Instrumenting filemap_nr_thps_inc() should be sufficient for ensuring > writable file mappings will not be THP-backed. > > If filemap_nr_thps_dec() in unaccount_

Re: [PATCH v1] RAS/CEC: Memory Corrected Errors consistent event filtering

2021-04-02 Thread William Roche
On 01/04/2021 18:12, Borislav Petkov wrote: On Mon, Mar 29, 2021 at 11:44:05AM +0200, William Roche wrote: I totally agree with you, and in order to schedule a replacement, MCEs information (enriched by the notifiers chain) are more meaningful than only PFN values. Well, if you want to

Re: [RESEND][PATCH 0/6] Constify struct page arguments

2021-04-17 Thread William Kucharski
Looks good to me and I like the cleanup. For the series: Reviewed-by: William Kucharski > On Apr 16, 2021, at 5:15 PM, Matthew Wilcox (Oracle) > wrote: > > [I'm told that patches 2-6 did not make it to the list; resending and > cc'ing lkml this time] > > Whi

[PATCH] net/rds: correct socket tunable error in rds_tcp_tune()

2021-03-17 Thread William Kucharski
Correct an error where setting /proc/sys/net/rds/tcp/rds_tcp_rcvbuf would instead modify the socket's sk_sndbuf and would leave sk_rcvbuf untouched. Signed-off-by: William Kucharski --- net/rds/tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/tcp.c b/ne

Re: [PATCH] mm, thp: Relax the VM_DENYWRITE constraint on file-backed THPs

2021-04-05 Thread William Kucharski
I saw a similar change a few years ago with my prototype: https://lore.kernel.org/linux-mm/5bb682e1-dd52-4aa9-83e9-def091e0c...@oracle.com/ the key being a very nice drop in iTLB-load-misses, so it looks like your code is having the right effect. What about the call to filemap_nr_thps_dec() i

[PATCH 0/5] staging: rtl8192e: delba_param_set union cleanups

2021-02-19 Thread William Durand
This patchset fixes the checkpatch issues related to the `delba_param_set` union defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). William Durand (5): staging: rtl8192e: rename charData to char_data in delba_param_set union staging: rtl8192e: rename shortData to short_data in

[PATCH 3/5] staging: rtl8192e: rename Reserved to reserved in delba_param_set union

2021-02-19 Thread William Durand
This change uses lowercase for a field name to be more consistent with the rest of the union. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 5/5] staging: rtl8192e: rename TID to tid in delba_param_set union

2021-02-19 Thread William Durand
This change uses lowercase for a field name to be more consistent with the rest of the union. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 4/5] staging: rtl8192e: rename Initiator to initiator in delba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 2/5] staging: rtl8192e: rename shortData to short_data in delba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging

[PATCH 1/5] staging: rtl8192e: rename charData to char_data in delba_param_set union

2021-02-19 Thread William Durand
Fixes a checkpatch CHECK message. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers/staging/rtl8192e/rtl819x_BA.h index 36280c62fa56..de41d2182ff5 100644

[PATCH 1/7] staging: rtl8192e: rename Timer to timer in ba_record struct

2021-02-21 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a

[PATCH 3/7] staging: rtl8192e: rename DialogToken to dialog_token in ba_record struct

2021-02-21 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers

[PATCH 4/7] staging: rtl8192e: rename BaParamSet to ba_param_set in ba_record struct

2021-02-21 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 28 +++ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b

[PATCH 0/7] staging: rtl8192e: ba_record struct cleanups

2021-02-21 Thread William Durand
This patchset fixes the checkpatch issues related to the `ba_record` struct defined in `rtl8192e/rtl819x_BA.h` (avoid camelcase). The last patch reformats the struct a bit to be more consistent with the other types defined in the same file. William Durand (7): staging: rtl8192e: rename Timer to

[PATCH 2/7] staging: rtl8192e: rename bValid to b_valid in ba_record struct

2021-02-21 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 22 +++--- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff

[PATCH 7/7] staging: rtl8192e: reformat ba_record struct

2021-02-21 Thread William Durand
This change uses a space instead of tabs between the type and name of each member of the struct. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers

[PATCH 6/7] staging: rtl8192e: rename BaStartSeqCtrl to ba_start_seq_ctrl in ba_record struct

2021-02-21 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 18 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff

[PATCH 5/7] staging: rtl8192e: rename BaTimeoutValue to ba_timeout_value in ba_record struct

2021-02-21 Thread William Durand
Fixes a checkpatch CHECK issue. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BA.h | 2 +- drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BA.h b/drivers

[PATCH] staging: rtl8192e: fix alignment issues in rtllib_wx.c

2021-02-21 Thread William Durand
Fixes "Alignment should match open parenthesis" issues reported by checkpatch.pl in the `rtllib_wx.c` file. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtllib_wx.c | 42 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/drive

Re: Potential Issue in Tracing Ring Buffer

2020-11-30 Thread William Mcvicker
On Mon, Nov 30, 2020 at 09:48:46AM -0500, Steven Rostedt wrote: > On Thu, 26 Nov 2020 13:26:13 -0500 > Steven Rostedt wrote: > > > On Thu, 26 Nov 2020 06:52:45 +0100 > > Greg KH wrote: > > > > > On Tue, Nov 24, 2020 at 10:39:17PM +, J. Avila wrote: > > > > Hello, > > > > > > > > In the f

Re: [PATCH v2 1/5] USB: gadget: f_rndis: fix bitrate for SuperSpeed and above

2020-11-30 Thread William Mcvicker
On Mon, Nov 30, 2020 at 06:24:40AM +, Peter Chen wrote: > On 20-11-27 15:05:55, Greg Kroah-Hartman wrote: > > From: Will McVicker > > > > Align the SuperSpeed Plus bitrate for f_rndis to match f_ncm's ncm_bitrate > > defined by commit 1650113888fe ("usb: gadget: f_ncm: add SuperSpeed > > des

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

2020-11-23 Thread William Mcvicker
On Mon, Nov 23, 2020 at 09:02:57AM +, Christoph Hellwig wrote: > On Sat, Nov 21, 2020 at 01:16:49AM +, Will McVicker wrote: > > These two patches add module support to capture an external module's SCM > > version as a MODULE_INFO() attribute. This allows users to identity the SCM > > versio

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

2020-11-24 Thread William Mcvicker
On Tue, Nov 24, 2020 at 10:31:18AM +0100, Jessica Yu wrote: > +++ William Mcvicker [23/11/20 14:13 -0800]: > > On Mon, Nov 23, 2020 at 09:02:57AM +, Christoph Hellwig wrote: > > > On Sat, Nov 21, 2020 at 01:16:49AM +, Will McVicker wrote: > > > > These two

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

2020-11-24 Thread William Mcvicker
On Tue, Nov 24, 2020 at 07:12:40PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 24, 2020 at 10:05:16AM -0800, William Mcvicker wrote: > > On Tue, Nov 24, 2020 at 10:31:18AM +0100, Jessica Yu wrote: > > > +++ William Mcvicker [23/11/20 14:13 -0800]: > > > > On M

Re: [PATCH v1 0/2] Add support to capture external module's SCM version

2020-11-24 Thread William Mcvicker
On Tue, Nov 24, 2020 at 09:24:26PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 24, 2020 at 10:31:39AM -0800, William Mcvicker wrote: > > On Tue, Nov 24, 2020 at 07:12:40PM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Nov 24, 2020 at 10:05:16AM -0800, William Mcvicker wro

Re: [PATCH v2 0/2] Adds support to capture module's SCM version

2020-12-03 Thread William Mcvicker
On Wed, Nov 25, 2020 at 01:05:39AM +, Will McVicker wrote: > Hi All, > > I have updated the patchset to: > > *) Include Documentation. > *) Use a consistent output pattern for the SCM version. > > In my debugging, I found that the vermagic reported by modinfo can actually > vary based on h

From Dr.Tracy William

2021-03-12 Thread Dr.Tracy William
-- Hello Dear, how are you today,I hope you are doing great. It is my great pleasure to contact you,I want to make a new and special friend,I hope you don't mind. My name is Tracy William from the United States, Am an English and French nationalities. I will give you pictures and more de

Re: [PATCH v2] include: Remove pagemap.h from blkdev.h

2021-03-10 Thread William Kucharski
Nice cleanup, IMHO. Reviewed-by: William Kucharski > On Mar 9, 2021, at 12:57 PM, Matthew Wilcox (Oracle) > wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 326 files need to be rebuilt when I > touch pagemap.h.

Re: [PATCH] fb_defio: Remove custom address_space_operations

2021-03-10 Thread William Kucharski
Looks good, just one super minor nit inline. Reviewed-by: William Kucharski > On Mar 10, 2021, at 6:51 AM, Matthew Wilcox (Oracle) > wrote: > > There's no need to give the page an address_space. Leaving the > page->mapping as NULL will cause the VM to handle set_page

Re: [PATCH v2] fb_defio: Remove custom address_space_operations

2021-03-10 Thread William Kucharski
eaving the > page->mapping as NULL will cause the VM to handle set_page_dirty() > the same way that it's handled now, and that was the only reason to > set the address_space in the first place. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig &

[PATCH 2/9] staging: rtl8192e: rename RxIndicateSeq to rx_indicate_seq in rx_ts_record struct

2021-03-01 Thread William Durand
Rename RxIndicateSeq to rx_indicate_seq to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 16 - drivers/staging/rtl8192e/rtllib_rx.c | 42

[PATCH 3/9] staging: rtl8192e: rename RxTimeoutIndicateSeq to rx_timeout_indicate_seq in rx_ts_record struct

2021-03-01 Thread William Durand
Rename RxTimeoutIndicateSeq to rx_timeout_indicate_seq to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 6

[PATCH 1/9] staging: rtl8192e: rename TsCommonInfo to ts_common_info in rx_ts_record struct

2021-03-01 Thread William Durand
Rename TsCommonInfo to ts_common_info to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +- 3 files

[PATCH 0/9] rx_ts_record struct cleanups

2021-03-01 Thread William Durand
This patchset fixes the checkpatch issues related to the `rx_ts_record` struct defined in `rtl8192e/rtl819x_TS.h` (avoid camelcase). The last patch reformats the struct a bit to be more consistent with structures defined in other header files. William Durand (9): staging: rtl8192e: rename

[PATCH 4/9] staging: rtl8192e: rename RxPendingPktList to rx_pending_pkt_list in rx_ts_record struct

2021-03-01 Thread William Durand
Rename RxPendingPktList to rx_pending_pkt_list to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +- drivers/staging/rtl8192e/rtllib_rx.c | 12

[PATCH 8/9] staging: rtl8192e: rename RxLastFragNum to rx_last_frag_num in rx_ts_record struct

2021-03-01 Thread William Durand
Rename RxLastFragNum to rx_last_frag_num to silence a checkpatch warning about CamelCase. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 9/9] staging: rtl8192e: reformat rx_ts_record struct

2021-03-01 Thread William Durand
This change uses a space instead of tabs between the type and name of each member of the struct. Signed-off-by: William Durand --- drivers/staging/rtl8192e/rtl819x_TS.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b

<    1   2   3   4   5   6   7   8   9   10   >