Sun, Jul 16, 2017 at 11:52:32AM +0200, Wolf Entwicklungen wrote:
> > From: Marcus Wolf
> > Date: Tue,16 Jul 2017 11:52:06 +0100
> > Subject: [PATCH 1/1] drivers/staging/pi433: New driver
>
> Why is this all here in the patch body? Usually git will strip this
> out, but in
Hi Greg,
I am surprised and happy about getting all the feedback and ideas how to
improve. Wow!
Can you tell me, how this is going on? Do I need to collect all those patches,
evaluate and test them or is it done automatically?
Do you perhaps need diffrent kind of help from me?
Concerning th
Hi Joseph,
tested your patch and didn't observe a problem.
Thanks for your help :-)
Marcus
> Joseph Wright hat am 16. Juli 2017 um 16:48
> geschrieben:
>
>
> Error should be checked with IS_ERR after calling kthread_run()
> instead of comparing the returned pointer to an int.
>
> Found by spar
Hi Colin,
thanks for your patches.
#1 is fine. Same fix was provided by Joseph Wright. I tested it and it works
fine.
#2 looks fine, too.
Conerning #3, I would suggest to declare rf69_set_dc_cut_off_frequency static,
as well. Would you prefer to remove rf69_set_dc_cut_off_frequency from the
h
Declare rf69_set_dc_cut_off_frequency_intern as static since it
is used internaly only
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Marcus Wolf
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
--- a/drivers/staging/pi433/rf69.c
+++ b/drive
Reviewed-by: Marcus Wolf
Tested-by: Marcus Wolf
Am Di, 18.07.2017, 15:04 schrieb Colin King:
> From: Colin Ian King
>
> The check for thread_run failure is incorrect, use IS_ERR instead.
>
> Cleans up sparse error message:
> "error: incompatible types for operation (<
Reviewed-by: Marcus Wolf
Am Di, 18.07.2017, 15:03 schrieb Colin King:
> From: Colin Ian King
>
> The functions pi433_receive and pi433_tx_thread are local to the source
> and do not need to be in global scope, so make them static
>
> Cleans up sparse warnings:
> symbol &#
Reviewed-by: Marcus Wolf
Am Di, 18.07.2017, 15:03 schrieb Colin King:
> From: Colin Ian King
>
> The function rf69_set_bandwidth_intern is local to the source
> and do not need to be in global scope, so make it static. Also
> break overly wide line.
>
> Cleans up spa
Reviewed-by: Marcus Wolf
Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Declare functions static to fix sparse warnings:
>
> warning: symbol 'pi433_receive' was not declared. Should it be static?
> warning: symbol 'pi433_tx_thread' was not declared. Should
Reviewed-by: Marcus Wolf
Tested-by: Marcus Wolf
Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Error should be checked with IS_ERR after calling kthread_run()
> instead of comparing the returned pointer to an int.
>
> Found by sparse warning:
>
> incompatible t
Reviewed-by: Marcus Wolf
Am Do, 20.07.2017, 01:58 schrieb Randy Dunlap:
> From: Randy Dunlap
>
> The pi433 driver uses SPI interfaces so it should depend on SPI.
> Also, the "default n" can be removed since that is already the
> default.
>
> Fixes these build
Reviewed-by: Marcus Wolf
> Colin King hat am 18. Juli 2017 um 07:40
> geschrieben:
>
>
> From: Colin Ian King
>
> Trivial fix to spelling mistakes in dev_dbg debug messages
>
> "wiat" -> "wait"
> "fonud" -> "found"
>
0170717]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Wolf-Entwicklungen/drivers-staging-pi433-New-driver/20170716-181617
> config: m68k-allyesconfig (attached as .conf
Hi Colin,
mine is an aditional patch for an other function, that's pretty similar to the
one, you improoved. So we need both patches, yours and mine!
Cheers,
Marcus
> Colin Ian King hat am 20. Juli 2017 um 14:58
> geschrieben:
>
>
> On 20/07/17 12:01, Wolf Entwicklunge
Fixes problem with division in rf69_set_deviation
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Marcus Wolf
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -221,7 +22
gt;
>
> Hi Dan,
>
> On Thu, Jul 20, 2017 at 1:37 PM, Dan Carpenter
> wrote:
> > On Thu, Jul 20, 2017 at 01:23:05PM +0200, Marcus Wolf wrote:
> >> below you can see the report with the error on m68k. It was sent to me from
> >> a
> >> test robot of i
Reviewed-by: Marcus Wolf
Attention: This patch is nothing new, just a combination of Patch
[PATCH 2/3][staging-next] staging: pi433: Make functions
rf69_set_bandwidth_intern static
and
[PATCH 1/1][staging-next] staging: pi433: Make functions
rf69_set_dc_cut_off_frequency_intern static
> Co
Reviewed-by: Marcus Wolf
Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all
'm' as a column below each other, all 'a' below each other, ...). For me that
improves the readability a lot. Maybe that can be acchieved somehow without
breaking
Reviewed-by: Marcus Wolf
>From my point of view, the rearrangement of the block of SET_CHECKED reduces
>the
readability a lot. I like same stuff to be aligned (all brakets below each other
as a column, all spi->dev below each other and so on) But if it is necessary to
fullfill the
Reviewed-by: Marcus Wolf
Thanks for your work, Derek!
> Derek Robson hat am 22. Juli 2017 um 05:50 geschrieben:
>
>
> Fixed the alignment of block comments
> Found using checkpatch
>
> Signed-off-by: Derek Robson
> ---
> drivers/staging/pi433/pi433_if.c
.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c | 340 ++
1 file changed, 182 insertions(+), 158 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a215..8a31ed7 100644
--- a/drivers/staging/pi433
Am 04.12.2017 um 12:37 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
Perhaps choose different function names if you want? You could do it
as several patches:
patch 1: change types to bool
patch 2: sed -e '/ == optionOn//'
patch 3: split the functions i
Am 04.12.2017 um 12:33 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index 34ff0d4807bd..bcfe29840889 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b/drivers/staging/pi
Am 04.12.2017 um 12:24 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote:
Renames enum dataMode and its values packet, continuous, continuousNoSync
to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes
checkpatch.pl warnings: "Avoid CamelCase:
Am 04.12.2017 um 21:15 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 12:37 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
Perhaps choose different function names if you want? You could do it
as
Second there might be the idea of supporting different chips in the future
(I already thought about).
Linux style is never to write code for the future.
Ok. I didn't know.
To be honest, I already started writing code, also supporting the rf12
some time ago, thus programming a rfxx.c, but neve
Am 04.12.2017 um 21:18 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 12:33 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433
Am 04.12.2017 um 21:42 schrieb Simon Sandström:
On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 21:15 schrieb Dan Carpenter:
That's a bad name, because it doesn't just enable it also disables.
Please split them.
regards,
dan carpenter
Same appl
Am 04.12.2017 um 21:56 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote:
Then it might be, that DATAMODUL_MODE_PACKET might need an other value.
That's future code so we can delete that sentence for now.
With the rule above, you are absolutely right
x27;t introduced
by this patch, but were long and camel cased before.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c | 336 ++
1 file changed, 180 insertions(+), 156 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/
x27;t introduced
by this patch, but were long and camel cased before.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c | 336 ++
1 file changed, 180 insertions(+), 156 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/
Am 04.12.2017 um 21:05 schrieb Simon Sandström:
> On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote:
>>
>> Hi Simon, hi Dan,
>>
>> if you both are of the same opinion, for me, it's fine, if we go with two
>> functions.
>>
>> But
Am 05.12.2017 um 13:16 schrieb Dan Carpenter:
> On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote:
>> Keep in mind, that if you split the functions, in the interface
>> implementation you also need more code:
>>
>> SET_CHECKED(rf69_set_sync_enable(de
Am 06.12.2017 um 00:08 schrieb Simon Sandström:
Splits rf69_set_crc_enabled(dev, enabled) into
rf69_enable_crc(dev) and rf69_disable_crc(dev).
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 22 --
drivers/staging/pi433/rf69.c | 18 ++--
Am 06.12.2017 um 00:08 schrieb Simon Sandström:
Call rf69_set_data_mode with DATAMODUL_MODE value directly.
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 2 +-
drivers/staging/pi433/rf69.c | 15 ++-
drivers/staging/pi433/rf69.h | 2 +-
dri
Am 06.12.2017 um 00:08 schrieb Simon Sandström:
Replaces the functions rf69_set_amplifier_1, _2, _3 with two
functions: rf69_enable_amplifier(dev, amp_mask) and
rf69_disable_amplifier(dev, amp_mask).
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 6 +++---
drivers/s
Am 06.12.2017 um 00:08 schrieb Simon Sandström:
Renames the enum optionOnOff and its values optionOn, optionOff to enum
option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings:
"Avoid CamelCase: , , ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 34 +
Am 06.12.2017 um 11:02 schrieb Greg KH:
On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote:
Fixes issue with bit shift in rf69_get_modulation
What "issue"?
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
1 file changed, 1 insertion(+),
Am 06.12.2017 um 11:37 schrieb Dan Carpenter:
On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote:
Am 06.12.2017 um 00:08 schrieb Simon Sandström:
Splits rf69_set_crc_enabled(dev, enabled) into
rf69_enable_crc(dev) and rf69_disable_crc(dev).
Signed-off-by: Simon Sandström
Am 06.12.2017 um 12:23 schrieb Dan Carpenter:
On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote:
diff --git a/drivers/staging/pi433/rf69_enum.h
b/drivers/staging/pi433/rf69_enum.h
index babe597e2ec6..5247e9269de9 100644
--- a/drivers/staging/pi433/rf69_enum.h
+++ b/drivers/staging
>>
>> rf69 -set/get - action
>> -> rf69_set_crc_enable
>
> No... Simon's name is better. His is shorter and makes more sense.
I disagree. If I am going to implement a new functionality and need to
think about the naming of the function name, every time I need to change
a register setting th
er is new (mainline for just something like 2 monthes) and stil under
devel, I think we should "risk" it.
Gruß,
Marcus
> Am 06.12.2017 um 11:44 schrieb Dan Carpenter :
>
>> On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote:
>>
>>
>>> Am 06.12
sizeof(array) != sizeof(pointer to array)
Fixes: "staging: pi433: reduce stack size in tx thread"
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/pi433_if.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c
N_AUTO: return automatic;
case LNA_GAIN_MAX: return max;
case LNA_GAIN_MAX_MINUS_6: return maxMinus6;
--
Smarthome-Wolf UG (haftungsbeschränkt)
Helene-Lange-Weg 23
80637 München
Amtsgericht München, HRB 223529
Umastzsteuer-ID: DE304719911
Geschäftsführer: Marcus Wolf
_GAIN0x07
+#define SHIFT_LNA_CURRENT_GAIN3
#define LNA_GAIN_AUTO0x00 /* default */
#define LNA_GAIN_MAX 0x01
--
Smarthome-Wolf UG (haftungsbeschränkt)
Helene-Lange-Weg 23
80637 München
Amtsgericht München, HRB 223529
Umastzsteuer-ID: DE304719911
Geschäftsführer: Marcus Wolf
Am 13.12.2017 um 18:55 schrieb Valentin Vidic:
Avoid shifting by magic numbers and use defines instead.
Signed-off-by: Valentin Vidic
---
v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE
- move shifting to the header file
drivers/staging/pi433/rf69.c | 16 --
Am 13.12.2017 um 19:44 schrieb Valentin Vidic:
Avoid shifting by magic numbers and use defines instead.
Signed-off-by: Valentin Vidic
---
v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE
- move shifting to the header file
v3: - drop auto case
- use CURRENT suffix
- precomp
Hi!
This is an information for all of you, doing experiments with real hardware!
I wanted to explain, what this lna_gain stuff is used for:
If you are receiving messages from different sender (let's say several
thermometers), it may happen (e. g. due to different distance and
different batter
Am 04.12.2017 um 21:18 schrieb Dan Carpenter:
On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote:
Am 04.12.2017 um 12:33 schrieb Dan Carpenter:
On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote:
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433
Hi everybody,
from my point of view, we should stay with the old implementation.
Ok - line is too long according to style guide. But these long lines are
IMHO easy to read:
All four are pretty similar. By having all Tokens in exact the same length
and having one below other, you can easily dete
reviewed-by: Marcus Wolf
The fixes of this patch are fine, but there are already patches out there,
containing these fixes.
Thanks,
Marcus
> David Wittman hat am 24. Juli 2017 um 00:46 geschrieben:
>
>
> A few local functions in the pi433 module were getting flagged by Sparse
&
Hi Dan,
when I started with the RFM69CW about two years ago (at the beginning not as a
driver, but everything within the applicaton) I kind of automatically produced a
list of all registers of the chip (most probably by importing and reorganizing
the datasheet in Excel).
Everytime I need to touch
Hi Arnd,
we already have a patch for this:
[PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation
from 20.07.2017
Maybe I did something wrong, but my first solution was exactly like your
proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I
made a
l adresses and several mailboxes from one provider to another within the
next two monthes).
Sorry for any inconvenience,
Marcus
> Dan Carpenter hat am 28. Juli 2017 um 16:26
> geschrieben:
>
>
> On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote:
> > Hi Arnd,
>
Hi Greg,
according to the proposals of Walter Harms, I revised the rf69.c: I replaced
some macros with inline functions and removed some obsolete ifdefs. According to
walter this will improve the resource situation. In addition the readybility is
enhanced, since lines got shorter. It's a quite bi
0, 2017 at 05:56:36PM +0200, Marcus Wolf wrote:
> > Fixes problem with division in rf69_set_deviation
> >
> > Fixes: 874bcba65f9a ("staging: pi433: New driver")
> > Signed-off-by: Marcus Wolf
> >
> > diff --git a/drivers/staging/pi433/rf69.c b/driv
Hi Greg,
also had a very close look to this patch. Even in your reply I can't find any
problems with line wraps or other corruptions :-/
But we have alternative patches, solving these problems as well.
You e.g. could use the patch
[PATCH] Make functions rf69_set_bandwidth_intern and
rf69_set_dc_
change in rf69.c I will try to equip an SVN-diff with
apropriate headers next week, so Dan can crosscheck with his work - I hope, I
will make it without errors...
Have a nice weekend,
Marcus
> Greg KH hat am 30. Juli 2017 um 00:21
> geschrieben:
>
>
> On Sat, Jul 29, 2017 at 10:5
Reviewed-by: Marcus Wolf
Thank you Rishabh!
Marcus
Am Mo, 31.07.2017, 12:21 schrieb RishabhHardas:
> From: RishabhHardas
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: RishabhHardas
> ---
> drivers/staging/
Reviewed-by: Marcus Wolf
Thank you Marcin!
> Marcin Ciupak hat am 8. August 2017 um 15:54
> geschrieben:
>
>
> This patch is intended to fix coding style issues in order to comply
> with kernel coding style guide as requested by TODO file.
>
> It fixes the follo
Reviewed-by: Marcus Wolf
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c
> b/drivers/sta
Reviewed-by: Marcus Wolf
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/rf69.h | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.h
Reviewed-by: Marcus Wolf
Just reviewed, not tested.
As far as I can see, there is no technical issue with this patch.
I prefer the names of the enumerations in camel case, because then they are a
bit shorter.
If camel case is unwanted, for sure we need that change.
Please mind the allignment
Reviewed-by: Marcus Wolf
Maybe lnaGain should move to lna_gain instead of lnagain (also applies to the
headers...)
Marcus
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/rf69.c | 26 +-
> 1
Reviewed-by: Marcus Wolf
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/rf69_enum.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69_enum.h
&
Reviewed-by: Marcus Wolf
Thank you :-)
Am Di, 1.08.2017, 07:09 schrieb Rishabh Hardas:
> From: Rishabh Hardas
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/pi433_if.c | 24
Reviewed-by: Marcus Wolf
Maybe tx_buffer is a bit more clearly then buffer.
Thanks,
Marcus
Am Mo, 31.07.2017, 10:57 schrieb Arnd Bergmann:
> Putting a 900 byte array on the stack is a clearly too much in the
> kernel, and sometimes results in warnings like:
>
> drivers/s
en:
>
>
> On Wed, Aug 02, 2017 at 10:08:04AM +0200, Wolf Entwicklungen wrote:
> > Reviewed-by: Marcus Wolf
> >
> > Just reviewed, not tested.
> > As far as I can see, there is no technical issue with this patch.
>
> You need to be a bit more strict in your rev
Hi Dan,
I offered Greg to have an eye on the patches, that were submitted. He asked
me to reply to those patches, I had a look for, with the Reviewed-by tag.
Now I am a bit unsure, what I should do.
Since I am interested in, I for sure will read every patch. It's just a little
thing, to reply wi
: Marcus Wolf
---
drivers/staging/pi433/rf69.c | 544 ++
1 file changed, 238 insertions(+), 306 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -28,33
(my patch, concerning the bit shifting,
we talked about last week and an other patch fixing an issue
with a bit inversion).
Hope it helps :-)
Marcus
Am Mi, 2.08.2017, 13:10 schrieb Wolf Entwicklungen:
> According to the proposal of Walter Harms, I removed some macros
> and added some
From: Marcus Wolf
According to the proposal of Walter Harms, I removed some macros
and added some inline functions.
Since I used a bit more intelligent interface, this enhances
readability and reduces problems with checkpatch.pl at the same time.
In addition obsolete debug ifdefs were removed
per patch. And I totally get that redoing
> patches sucks... Sorry.
>
> On Wed, Aug 02, 2017 at 01:10:14PM +0200, Wolf Entwicklungen wrote:
> > According to the proposal of Walter Harms, I removed some macros
> > and added some inline functions.
> >
> > Since I used a
Reviewed-by: Marcus Wolf
This is similar to patch "[PATCH -next] staging: pi433: depends on SPI" of
Randy Dunlap
> Arnd Bergmann hat am 25. Juli 2017 um 17:38 geschrieben:
>
>
> I ran into a build error with the new pi433 driver and
> CONFIG_SPI disabled:
>
> d
From: root
Defines used in cases contain already shifted bits, so currentValue must not be
shifted.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
to prevent the From: line?
Should I resend the patch?
Thanks,
Marcus
Am 02.12.2017 um 12:06 schrieb Greg KH:
On Sat, Dec 02, 2017 at 11:58:12AM +0200, Marcus Wolf wrote:
From: root
I think something went wrong here :)
Also, you should never need to do kernel development as root...
Defines used in cases contain already shifted bits, so currentValue must not be
shifted.
signed_of_by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a215
Defines used in cases contain already shifted bits, so currentValue must not be
shifted.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e69a215
: Marcus Wolf
---
drivers/staging/pi433/rf69.c | 118 +-
1 file changed, 58 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 12c9df9..0df084e 100644
--- a/drivers/staging/pi433/rf69.c
+++ b
To increase the readability of the register accesses, the abstraction of the
helpers was increased from simple read and write to set bit, reset bit and
read modify write bit. In addition - according to the proposal from Walter
Harms from 20.07.2017 - instead of marcros inline functions were used.
response time of
the driver, the lower threshold can be set.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/pi433_if.c |1 +
drivers/staging/pi433/rf69.c |1 -
drivers/staging/pi433/rf69.h |5 -
drivers/staging/pi433/rf69_registers.h |5 +
4 files
rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
drivers/staging/pi433/rf69.h |1 -
2 files changed, 1 insertion
Revieved-by: Marcus Wolf
Am 11.10.2017 um 21:24 schrieb Marcin Ciupak:
This patch fixes the following checkpatch.pl error:
ERROR: code indent should use tabs where possible
in rf69.c file as requested by TODO file.
Additionally some style warnings remain valid here and could be fixed by
Leftover changes from patch [PATCH 2/5] staging: pi433: rf69.c style fix -
spaces required around
from Marcin Ciupak (11.10.2017)
Signed-of-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b
2, 2017 at 05:14:08PM +0200, Marcus Wolf wrote:
The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a
register,
it is a value, that is given by hardware (like the registers).
The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that is
freely choosen by the
Hi!
I am sorry :-/
Can you recover, or do I need to resend?
Cheers,
Marcus
Am 02.12.2017 um 17:56 schrieb Greg KH:
On Sat, Dec 02, 2017 at 05:20:22PM +0200, Marcus Wolf wrote:
rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header
annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sat, Dec 02, 2017 at 06:00:28PM +0200, Marcus Wolf wrote:
Hi Greg,
for me the action was "clean up the defines in rf69.c". So for me it was
fine, that two defines were
Am 02.12.2017 um 17:00 schrieb Greg KH:
On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote:
Since dev_dbg already depends on define DEBUG, there was no sense, to enclose
dev_dbg lines with #ifdef DEBUG.
Instead of removing #ifdef DEBUG, I introduced define DEBUG_FUNC_ENTRY. So now
it
Am 02.12.2017 um 18:46 schrieb Joe Perches:
On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote:
rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only.
Therefore removed the function from header and declared it staic in
the implemtation.
Signed-off-by: Marcus Wolf
Am 03.12.2017 um 17:17 schrieb Simon Sandström:
Renames the enum optionOnOff and its values optionOn, optionOff to enum
option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings:
"Avoid CamelCase: , , ".
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.c | 34 +
Am 06.12.2017 um 21:57 schrieb Simon Sandström:
On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote:
On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote:
Am 06.12.2017 um 12:23 schrieb Dan Carpenter:
Wow... This was the one patch I thought was going to sink this
Am 06.12.2017 um 22:42 schrieb Simon Sandström:
The enum is now only used for ioctl, so move it pi433_if.h.
Signed-off-by: Simon Sandström
---
drivers/staging/pi433/pi433_if.h | 5 +
drivers/staging/pi433/rf69_enum.h | 5 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff -
Am 06.12.2017 um 14:47 schrieb Dan Carpenter:
> On Wed, Dec 06, 2017 at 11:11:27AM +0200, Marcus Wolf wrote:
>>
>> Since the rule for kernel development seems to be, not to care about future,
>> most probably you patch is fine, anyway.
>>
>
> Yeah. Deleting cod
Fixes issue with bit shift in rf69_get_modulation
Signed-off-by: Marcus Wolf
---
drivers/staging/pi433/rf69.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 290b419..c945b4b 100644
--- a/drivers/staging
rking on a wrong version?
marcus@Laptop-Wolf:~/staging/drivers/staging/pi433$ git remote show origin
* remote origin
Fetch URL:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Push URL:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
Can anybody help m
On 10/11/17 16:49, Marcus Wolf wrote:
>> Hi all!
>>
>> Tryed to cross check...
>>
>> Don't get it, sorry.
>>
>> On my private version control (my SVN), where I initially developed the
>> driver the break isn't missing.
>> Same with my
Hi everybody!
Just comparing the master of Gregs statging of pi433 with my local SVN
to review all changes, that were done the last monthes.
I am not sure, but maybe we imported a bug in rf69.c lines 378 and
following:
Gregs repo:
case automatic: return WRITE_REG(REG_LNA, ( (READ_REG(RE
Hello everybody!
Concerning the naming:
==
When writing the rf69.c it wasn't intended to write a driver for Linux.
This file was written at a time, where the complete controlling of Pi433
was implemented in the application. Therefore it is written in a
completely different
maybe
you can just drop this patch?
Thanks,
Armin Wolf
Signed-off-by: Thomas Weißschuh
---
drivers/platform/x86/wmi-bmof.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/wmi-bmof.c b/drivers/platform/x86/wmi-bmof.c
index
101 - 199 of 199 matches
Mail list logo
