On Tue, Nov 13, 2018 at 1:40 PM Mika Westerberg
wrote:
>
> On Tue, Nov 13, 2018 at 01:13:31PM +0200, Yehezkel Bernat wrote:
> > On Tue, Nov 13, 2018 at 12:56 PM Mika Westerberg
> > wrote:
> > >
> > > > Just one point:
> > > > Have you considere
On Sun, Jul 8, 2018 at 10:31 AM Mika Westerberg
wrote:
>
> On Sat, Jul 07, 2018 at 11:14:01PM +0200, Lukas Wunner wrote:
> >
> > Because I'm fairly certain that
> > I do not get a PME for the Light Ridge in my MacBook Pro, but I'll test
> > this once more and modify negotiate_os_control() to grant
*/
> + kobject_uevent(&tb->dev.kobj, KOBJ_CHANGE);
> + }
> mutex_unlock(&tb->lock);
>
> err_free_acl:
> --
> 2.17.1
>
Acked-by: Yehezkel Bernat
On Sat, Oct 20, 2018 at 12:25 AM Wenwen Wang wrote:
>
> On Thu, Oct 18, 2018 at 4:13 AM Mika Westerberg
> wrote:
> >
> > Hi Wenwen,
> >
> > On Wed, Oct 17, 2018 at 09:00:29AM -0500, Wenwen Wang wrote:
> > > In tb_cfg_copy(), the header of the received control package, which is in
> > > the buffer
On Fri, Apr 27, 2018 at 6:58 PM Mika Westerberg <
mika.westerb...@linux.intel.com> wrote:
> If the boot ACL entry is already NULL we should not fill in the upper
> two DWs with 0xf. Otherwise they are not shown as empty entries
> when the sysfs attribute is read.
> Fixes: 9aaa3b8b4c56 ("th
(uuid[0] != 0 || uuid[1] != 0) {
> /* Upper two DWs are always one's */
> uuid[2] = 0xffff;
> uuid[3] = 0x;
> --
> 2.17.0
Acked-by: Yehezkel Bernat
On Wed, Oct 2, 2019 at 6:09 PM wrote:
>
> > -Original Message-
> > From: Mika Westerberg
> > Sent: Wednesday, October 2, 2019 3:39 AM
> > To: Limonciello, Mario
> > Cc: linux-...@vger.kernel.org; andreas.noe...@gmail.com;
> > michael.ja...@intel.com; yehezkel...@gmail.com; rajmohan.m...@i
On Fri, Oct 4, 2019 at 10:54 AM Mika Westerberg
wrote:
>
> On Thu, Oct 03, 2019 at 02:41:11PM +, mario.limoncie...@dell.com wrote:
> > > -Original Message-
> > > From: Mika Westerberg
> > > Sent: Thursday, October 3, 2019 3:00 AM
> > > To: Limonciello, Mario
> > > Cc: yehezkel...@gmai
On Fri, Oct 4, 2019 at 11:19 AM Mika Westerberg
wrote:
>
> On Fri, Oct 04, 2019 at 11:07:34AM +0300, Yehezkel Bernat wrote:
> > > Also if you can get the hw_vendor_id and hw_product_id from the kernel
> > > does that mean you don't need to do the two reads
On Tue, Jul 23, 2019 at 10:21 PM Andy Shevchenko
wrote:
>
> Use use device_property_count_uXX() directly, that makes code neater.
>
> Signed-off-by: Andy Shevchenko
Acked-by: Yehezkel Bernat
On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg
wrote:
>
> @@ -1913,12 +1915,7 @@ static int icm_start(struct tb *tb)
> if (IS_ERR(tb->root_switch))
> return PTR_ERR(tb->root_switch);
>
> - /*
> -* NVM upgrade has not been tested on Apple systems and they
> -
On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg
wrote:
>
> The register access should be using 32-bit reads/writes according to the
> datasheet. With the previous generation hardware 16-bit writes have been
> working but starting with ICL this is not the case anymore so fix
> producer/consumer reg
On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg
wrote:
>
> +static void icm_icl_rtd3_veto(struct tb *tb, const struct icm_pkg_header
> *hdr)
> +{
> + const struct icm_icl_event_rtd3_veto *pkg =
> + (const struct icm_icl_event_rtd3_veto *)hdr;
> + struct icm *icm = tb_pri
e
> > ACPI / property: Add two new Thunderbolt property GUIDs to the list
>
> Forgot to Cc Raanan and Raj, now added. Sorry about that. The patch
> series can also be viewed here:
>
>
> https://lore.kernel.org/lkml/20190705095800.43534-1-mika.westerb...@linux.intel.com/T/#m9cb5a393dfc79f1c2212d0787b6bad5b689db6bd
Besides a few comments, LGTM.
For Thunderbolt patches,
Reviewed-by: Yehezkel Bernat
On Fri, Jul 5, 2019 at 5:51 PM Mika Westerberg
wrote:
>
> > > +static int nhi_suspend_power_down(struct tb *tb)
> > > +{
> > > + int ret;
> > > +
> > > + /*
> > > +* If there is no device connected we need to perform an
> > > additional
> > > +* handshake through LC ma
On Mon, Sep 10, 2018 at 12:45 PM Mika Westerberg
wrote:
>
> Hi Lukas,
>
> On Sun, Sep 09, 2018 at 11:42:01PM +0200, Lukas Wunner wrote:
> > Ideas what we can do with correlation:
> >
> > * Represent the relationship between PCI devices and Thunderbolt ports
> > with symlinks in sysfs.
>
> I wond
nderbolt/tb.h | 9 +++--
> drivers/thunderbolt/tb_msgs.h | 5 +--
> drivers/thunderbolt/tb_regs.h | 3 +-
> drivers/thunderbolt/xdomain.c | 5 +--
> include/linux/thunderbolt.h| 5 +--
> 20 files changed, 107 insertions(+), 111 deletions(-)
>
> --
> 2.18.0
>
Acked-by: Yehezkel Bernat
> * Copyright (c) 2014 Andreas Noever
> + * Copyright (C) 2018, Intel Corporation
Nitpicking: (c) or (C)?
I can't find anything in the documentation and both are found in various files.
;> Signed-off-by: Mario Limonciello
>
> Reviewed-by: Mika Westerberg
FWIW,
Reviewed-by: Yehezkel Bernat
19 matches
Mail list logo
