On 11/13/17 4:59 AM, Oleg Nesterov wrote:
The patch looks good to me, but I have a question because I know nothing
about insn encoding,
On 11/10, Yonghong Song wrote:
+static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn)
+{
+ u8 opc1 = OPCODE1(insn
1.413.5
uretprobe 1.754.0
You can see that this patch significantly reduced the overhead,
50% for uprobe and 44% for uretprobe on x86_64, and even more
on x86_32.
Signed-off-by: Yonghong Song
---
arch/x86/include/asm/uprobes.h | 4 ++
arch/x86/kernel/uprobes.
On 11/14/17 7:34 AM, Oleg Nesterov wrote:
On 11/13, Yonghong Song wrote:
On 11/13/17 4:59 AM, Oleg Nesterov wrote:
+ switch (opc1) {
+ case 0x50:
+ reg_offset = offsetof(struct pt_regs, r8);
+ break
On 11/14/17 7:51 AM, Oleg Nesterov wrote:
On 11/13, Yonghong Song wrote:
+static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn)
+{
+ u8 opc1 = OPCODE1(insn), reg_offset = 0;
+
+ if (opc1 < 0x50 || opc1 > 0x57)
+ return -ENOSYS;
+
+
On 11/14/17 8:03 AM, Oleg Nesterov wrote:
On 11/14, Oleg Nesterov wrote:
+#ifdef CONFIG_X86_64
+ if (test_thread_flag(TIF_ADDR32))
+ return -ENOSYS;
+#endif
No, this doesn't look right, see my previous email. You should do this
check in the "if (insn->length == 2)" bran
Thanks for reporting. This issue has been fixed by the below commit in
bpf-next repo, which is waiting to be pulled into net-next.
=
commit 2310035fa03f651dd5b03f19a26a97512aa8842c
Author: Yonghong Song
Date: Mon Jan 22 22:53:51 2018 -0800
bpf: fix incorrect kmalloc usage in
Hi, Arnaldo,
When I studied the bpf compilation issue with latest linus/net-next
kernel (https://patchwork.kernel.org/patch/10333829/), an alternative
approach I tried is to use __BPF__ macro. The following patch
introduced "#ifndef __BPF__" in arch/x86/include/asm/asm.h for
some inline assembl
On 4/11/18 11:39 AM, Arnaldo Carvalho de Melo wrote:
Em Wed, Apr 11, 2018 at 09:37:46AM -0700, Yonghong Song escreveu:
Hi, Arnaldo,
When I studied the bpf compilation issue with latest linus/net-next
kernel (https://patchwork.kernel.org/patch/10333829/), an alternative
approach I tried is
On 4/11/18 4:17 PM, Arnaldo Carvalho de Melo wrote:
Em Wed, Apr 11, 2018 at 04:47:29PM -0300, Arnaldo Carvalho de Melo escreveu:
Em Wed, Apr 11, 2018 at 12:22:37PM -0700, Yonghong Song escreveu:
Look at test bpf-script-test-kbuild.c, I think you can drop
uapi/asm/ptrace.h from include file
On 3/20/18 5:58 AM, Thadeu Lima de Souza Cascardo wrote:
Function bpf_fill_maxinsns11 is designed to not be able to be JITed on
x86_64. So, it fails when CONFIG_BPF_JIT_ALWAYS_ON=y, and
commit 09584b406742 ("bpf: fix selftests/bpf test_kmod.sh failure when
CONFIG_BPF_JIT_ALWAYS_ON=y") makes sur
On 3/20/18 10:00 AM, Thadeu Lima de Souza Cascardo wrote:
On Tue, Mar 20, 2018 at 09:05:15AM -0700, Yonghong Song wrote:
On 3/20/18 5:58 AM, Thadeu Lima de Souza Cascardo wrote:
Function bpf_fill_maxinsns11 is designed to not be able to be JITed on
x86_64. So, it fails when
compilation error will disappear.
If later clang compiler starts to support asm_volatile_goto,
the change in this patch can be reverted and there should
be no impact on BPF compilation.
Fixes: d0266046ad54 ("x86: Remove FAST_FEATURE_TESTS")
Signed-off-by: Yonghong Song
---
arch/x86/include/asm
On 3/13/18 4:45 PM, Omar Sandoval wrote:
On Tue, Mar 13, 2018 at 04:16:27PM -0700, Howard McLauchlan wrote:
Error injection is a useful mechanism to fail arbitrary kernel
functions. However, it is often hard to guarantee an error propagates
appropriately to user space programs. By injecting in
On 12/7/18 4:53 PM, Roman Gushchin wrote:
> Implement bpffs pretty printing for cgroup local storage maps
> (both shared and per-cpu).
> Output example (captured for tools/testing/selftests/bpf/netcnt_prog.c):
>
> Shared:
>$ cat /sys/fs/bpf/map_2
># WARNING!! The output is for debug purp
On 6/16/18 5:26 AM, Arnaldo Carvalho de Melo wrote:
Hi Wang, Yogong,
While reviewing the BTF patches for pahole, I updated llvm/clang
to HEAD and then building perf with clang embedded I noticed this, will
investigate, posting here to document the regression, maybe this is
something y
lure. This patch fixed the issue with using
proper function signatures under different compiler versions.
Reported-by: Arnaldo Carvalho de Melo
Signed-off-by: Yonghong Song
---
tools/perf/util/c++/clang.cpp | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/perf
On 6/18/18 7:31 AM, Arnaldo Carvalho de Melo wrote:
Em Sat, Jun 16, 2018 at 10:20:21AM -0700, Yonghong Song escreveu:
On 6/16/18 5:26 AM, Arnaldo Carvalho de Melo wrote:
Hi Wang, Yogong,
While reviewing the BTF patches for pahole, I updated llvm/clang
to HEAD and then building
I cannot reproduce in my local fc28 system with the attached steps.
The netlink_dumper.c file, could you confirm whether the following
header files are missing form you rhel-7.2 host?
#include
#include
I suspect you probably miss linux/tc_act/tc_bpf.h. But could you confirm
it? If this is
On 11/6/18 2:04 AM, Li Zhijian wrote:
>
> On 11/6/2018 9:47 AM, Yonghong Song wrote:
>> I cannot reproduce in my local fc28 system with the attached steps.
>>
>> The netlink_dumper.c file, could you confirm whether the following
>> header files are missing form you
On 4/27/24 9:34 AM, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:443574b03387 riscv, bpf: Fix kfunc parameters incompatibil..
git tree: bpf
console output: https://syzkaller.appspot.com/x/log.txt?x=11ca8fe718
kernel config: https://syzkaller.appspot.com
On 11/21/23 7:50 PM, Edward Adam Davis wrote:
Confirm that skb->len is not 0 to ensure that skb length is valid.
Fixes: 114039b34201 ("bpf: Move skb->len == 0 checks into __bpf_redirect")
Reported-by: syzbot+e2c932aec5c8a6e1d...@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis
Sta
On 12/20/23 1:19 AM, Hou Tao wrote:
Hi,
On 12/14/2023 11:40 AM, xingwei lee wrote:
Hello I found a bug in net/bpf in the lastest upstream linux and
comfired in the lastest net tree and lastest net bpf titled BUG:
unable to handle kernel paging request in bpf_probe_read_compat_str
If you fix
Hi, Peter,
Just wanted to ping again so that you did not miss the email below.
Please let me know your opinion.
Thanks!
Yonghong
On 4/23/18 9:50 AM, Yonghong Song wrote:
Hi, Peter,
Please see comments below.
On 4/23/18 3:52 AM, Peter Zijlstra wrote:
On Fri, Apr 20, 2018 at 11:06:03AM
Hi, Peter,
Ping again. Did you get chances to think about this issue again?
Thanks!
Yonghong
On 4/27/18 9:34 AM, Yonghong Song wrote:
Hi, Peter,
Just wanted to ping again so that you did not miss the email below.
Please let me know your opinion.
Thanks!
Yonghong
On 4/23/18 9:50 AM
On 2/28/19 8:03 AM, Masami Hiramatsu wrote:
> Add probe_user_read(), strncpy_from_unsafe_user() and
> strnlen_unsafe_user() which allows caller to access user-space
> in IRQ context.
>
> Current probe_kernel_read() and strncpy_from_unsafe() are
> not available for user-space memory, because it s
On 2/28/19 6:29 PM, Masami Hiramatsu wrote:
> Hi Yonghong,
>
> On Thu, 28 Feb 2019 22:49:43 +
> Yonghong Song wrote:
>
>>
>>
>> On 2/28/19 8:03 AM, Masami Hiramatsu wrote:
>>> Add probe_user_read(), strncpy_from_unsafe_user() and
>>>
On 4/17/19 10:48 AM, Wang YanQing wrote:
> The older glibc (for example, 2.23) doesn't handle __UAPI_DEF_*
> in libc-compat.h properly, and it bring below compile errors:
I have an even old glibc 2.17 and it still works. Not sure
why it failed here. Could you explain more?
But I applied the cha
On 2/23/21 2:28 PM, Song Liu wrote:
To access per-task data, BPF programs usually creates a hash table with
pid as the key. This is not ideal because:
1. The user need to estimate the proper size of the hash table, which may
be inaccurate;
2. Big hash tables are slow;
3. To clean up
using assembly.
Suggested-by: John Fastabend
Signed-off-by: Brendan Jackman
Ack with a nit below.
Acked-by: Yonghong Song
---
Difference from v2->v3 [1]:
* Fixed missing ENABLE_ATOMICS_TESTS check.
Difference from v1->v2:
* Reworked commit message to clarify this only af
On 2/5/21 11:06 AM, Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo
wrote:
Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escreveu:
On Fri, Feb 5, 202
On 2/5/21 11:15 AM, Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 8:10 PM Yonghong Song wrote:
On 2/5/21 11:06 AM, Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de
On 2/5/21 11:24 AM, Arnaldo Carvalho de Melo wrote:
Em Fri, Feb 05, 2021 at 11:10:08AM -0800, Yonghong Song escreveu:
On 2/5/21 11:06 AM, Sedat Dilek wrote:
On Fri, Feb 5, 2021 at 7:53 PM Sedat Dilek wrote:
Grepping through linux.git/tools I guess some BTF tools/libs need to
know what
On 2/8/21 11:35 PM, Dmitry Vyukov wrote:
On Sun, Feb 7, 2021 at 1:20 PM syzbot
wrote:
Hello,
syzbot found the following issue on:
HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_..
git tree: https://github.com/google/kmsan.git master
console output: https:/
On 5/18/20 5:25 PM, Andrii Nakryiko wrote:
On Mon, May 18, 2020 at 5:09 PM Qian Cai wrote:
On Mon, May 18, 2020 at 7:55 PM Andrii Nakryiko
wrote:
On Sun, May 17, 2020 at 7:45 PM Qian Cai wrote:
With Clang 9.0.1,
return array->value + array->elem_size * (index & array->index_mask);
b
On 5/18/20 6:30 PM, Andrii Nakryiko wrote:
On Mon, May 18, 2020 at 6:00 PM Yonghong Song wrote:
On 5/18/20 5:25 PM, Andrii Nakryiko wrote:
On Mon, May 18, 2020 at 5:09 PM Qian Cai wrote:
On Mon, May 18, 2020 at 7:55 PM Andrii Nakryiko
wrote:
On Sun, May 17, 2020 at 7:45 PM Qian
On 5/18/20 2:46 AM, Alan Maguire wrote:
On Wed, 13 May 2020, Yonghong Song wrote:
+struct btf_show {
+ u64 flags;
+ void *target; /* target of show operation (seq file, buffer) */
+ void (*showfn)(struct btf_show *show, const char *fmt, ...);
+ const struct btf
10
BM_DumpHashMap/1/16k14925 14895 47448
BM_DumpHashMap/1/64k58870 58674 1
Suggested-by: Luigi Rizzo
Cc: Yonghong Song
Signed-off-by: Brian Vazquez
---
kernel/bpf/hashtab.c | 23 ---
1 file changed, 8 inser
zzo
Cc: Yonghong Song
Signed-off-by: Brian Vazquez
---
kernel/bpf/hashtab.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c
index 024276787055..b6d28bd6345b 100644
--- a/kernel/bpf/hashtab.c
+++ b/kernel/
_update_elem and rename the function to
sock_map_update_elem_sys.
Signed-off-by: Lorenz Bauer
Acked-by: Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote:
The verifier assumes that map values are simple blobs of memory, and
therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are
map types where this isn't true. For example, sockmap and sockhash store
sockets. In general this isn't a big pro
ing a callback via
sk_prot->unhash. However, we can't just lock_sock like in
sock_map_sk_acquire because that might sleep. So instead we disable
softirq processing and use bh_lock_sock to prevent further
modification.
Signed-off-by: Lorenz Bauer
Acked-by: Yonghong Song
On 8/19/20 2:24 AM, Lorenz Bauer wrote:
Add a test which copies a socket from a sockmap into another sockmap
or sockhash. This excercises bpf_map_update_elem support from BPF
context. Compare the socket cookies from source and destination to
ensure that the copy succeeded.
Signed-off-by: Lore
On 8/20/20 4:33 AM, Lorenz Bauer wrote:
On Wed, 19 Aug 2020 at 23:41, John Fastabend wrote:
John Fastabend wrote:
Lorenz Bauer wrote:
Allow calling bpf_map_update_elem on sockmap and sockhash from a BPF
context. The synchronization required for this is a bit fiddly: we
need to prevent the
On 8/20/20 4:58 AM, Lorenz Bauer wrote:
On Wed, 19 Aug 2020 at 21:46, Yonghong Song wrote:
On 8/19/20 2:24 AM, Lorenz Bauer wrote:
Add a test which copies a socket from a sockmap into another sockmap
or sockhash. This excercises bpf_map_update_elem support from BPF
context. Compare the
On 8/19/20 3:40 PM, Hao Luo wrote:
Pseudo_btf_id is a type of ld_imm insn that associates a btf_id to a
ksym so that further dereferences on the ksym can use the BTF info
to validate accesses. Internally, when seeing a pseudo_btf_id ld insn,
the verifier reads the btf_id stored in the insn[0]'
On 8/20/20 6:57 AM, Lorenz Bauer wrote:
The verifier assumes that map values are simple blobs of memory, and
therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are
map types where this isn't true. For example, sockmap and sockhash store
sockets. In general this isn't a big pro
On 8/20/20 9:15 AM, Lorenz Bauer wrote:
On Thu, 20 Aug 2020 at 17:10, Yonghong Song wrote:
On 8/20/20 6:57 AM, Lorenz Bauer wrote:
The verifier assumes that map values are simple blobs of memory, and
therefore treats ARG_PTR_TO_MAP_VALUE, etc. as such. However, there are
map types where
On 8/19/20 3:40 PM, Hao Luo wrote:
Pseudo_btf_id is a type of ld_imm insn that associates a btf_id to a
ksym so that further dereferences on the ksym can use the BTF info
to validate accesses. Internally, when seeing a pseudo_btf_id ld insn,
the verifier reads the btf_id stored in the insn[0]'
On 8/19/20 3:40 PM, Hao Luo wrote:
Propagate BPF_PSEUDO_BTF_ID from include/linux/uapi/bpf.h to
tools/include/linux/uapi/bpf.h.
This can be folded into the previous patch.
Signed-off-by: Hao Luo
---
tools/include/uapi/linux/bpf.h | 38 ++
1 file changed
On 8/19/20 3:40 PM, Hao Luo wrote:
For a ksym to be safely dereferenced and accessed, its type defined in
bpf program should basically match its type defined in kernel. Implement
a help function for a quick matching, which is used by libbpf when
resolving the kernel btf_id of a ksym.
Signed-o
On 8/19/20 3:40 PM, Hao Luo wrote:
Selftests for typed ksyms. Tests two types of ksyms: one is a struct,
the other is a plain int. This tests two paths in the kernel. Struct
ksyms will be converted into PTR_TO_BTF_ID by the verifier while int
typed ksyms will be converted into PTR_TO_MEM.
Sig
On 8/19/20 3:40 PM, Hao Luo wrote:
Sync tools/include/linux/uapi/bpf.h with include/linux/uapi/bpf.h
This can be folded into the previous patch.
Signed-off-by: Hao Luo
---
tools/include/uapi/linux/bpf.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tools/include
On 8/18/20 1:20 AM, Xu Wang wrote:
Simplify the return expression.
Signed-off-by: Xu Wang
---
tools/lib/bpf/libbpf.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 5055e1531e43..b423fdaae0b6 100644
--- a/tools
On 8/18/20 1:20 AM, Xu Wang wrote:
Simplify the return expression.
Signed-off-by: Xu Wang
Also, please tag your patch targeting to 'bpf-next' tree like
[PATCH bpf-next] so people knows which tree the patch targets.
---
tools/lib/bpf/libbpf.c | 6 +-
1 file changed, 1 insertion(+),
On 8/18/20 12:16 AM, Xu Wang wrote:
Replace a comma between expression statements by a semicolon.
Signed-off-by: Xu Wang
Acked-by: Yonghong Song
On 8/18/20 7:53 PM, Xu Wang wrote:
Simplify the return expression.
Signed-off-by: Xu Wang
Acked-by: Yonghong Song
On 8/18/20 6:12 PM, Udip Pant wrote:
While using dynamic program extension (of type BPF_PROG_TYPE_EXT), we
need to check the program type of the target program to grant the read /
write access to the packet data.
The BPF_PROG_TYPE_EXT type can be used to extend types such as XDP, SKB
and othe
On 8/19/20 2:24 AM, Lorenz Bauer wrote:
Merge the two very similar functions sock_map_update_elem and
sock_hash_update_elem into one.
Signed-off-by: Lorenz Bauer
Acked-by: Yonghong Song
On 1/8/21 3:19 PM, Song Liu wrote:
To access per-task data, BPF program typically creates a hash table with
pid as the key. This is not ideal because:
1. The use need to estimate requires size of the hash table, with may be
inaccurate;
2. Big hash tables are slow;
3. To clean up the
On 1/11/21 2:17 AM, KP Singh wrote:
On Mon, Jan 11, 2021 at 7:27 AM Yonghong Song wrote:
On 1/8/21 3:19 PM, Song Liu wrote:
To access per-task data, BPF program typically creates a hash table with
pid as the key. This is not ideal because:
1. The use need to estimate requires size of
On 1/8/21 3:19 PM, Song Liu wrote:
To access per-task data, BPF program typically creates a hash table with
pid as the key. This is not ideal because:
1. The use need to estimate requires size of the hash table, with may be
inaccurate;
2. Big hash tables are slow;
3. To clean up the
On 1/8/21 3:19 PM, Song Liu wrote:
Task local storage is enabled for tracing programs. Add a test for it
without CONFIG_BPF_LSM.
Signed-off-by: Song Liu
---
.../bpf/prog_tests/test_task_local_storage.c | 34 +
.../selftests/bpf/progs/task_local_storage.c | 37 +++
On 1/8/21 3:19 PM, Song Liu wrote:
Update the Makefile to prefer using ../../../vmlinux, which has latest
definitions for vmlinux.h
Signed-off-by: Song Liu
---
tools/bpf/runqslower/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/runqslower/Makefile
On 1/8/21 3:19 PM, Song Liu wrote:
Replace hashtab with task local storage in runqslower. This improves the
performance of these BPF programs. The following table summarizes average
runtime of these programs, in nanoseconds:
task-local hash-prealloc hash-no-prea
On 1/11/21 2:54 PM, Song Liu wrote:
On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote:
On 1/8/21 3:19 PM, Song Liu wrote:
Replace hashtab with task local storage in runqslower. This improves the
performance of these BPF programs. The following table summarizes average
runtime of these
On 1/11/21 11:14 PM, Andrii Nakryiko wrote:
On Mon, Jan 11, 2021 at 7:24 PM Yonghong Song wrote:
On 1/11/21 2:54 PM, Song Liu wrote:
On Jan 11, 2021, at 9:49 AM, Yonghong Song wrote:
On 1/8/21 3:19 PM, Song Liu wrote:
Replace hashtab with task local storage in runqslower. This
On 12/7/20 3:28 AM, Brendan Jackman wrote:
On Fri, Dec 04, 2020 at 07:21:22AM -0800, Yonghong Song wrote:
On 12/4/20 1:36 AM, Brendan Jackman wrote:
On Thu, Dec 03, 2020 at 10:42:19PM -0800, Yonghong Song wrote:
On 12/3/20 8:02 AM, Brendan Jackman wrote:
This adds instructions for
xt tree is fine
since this is not a correctness issue.
Acked-by: Yonghong Song
On 12/7/20 8:07 AM, Brendan Jackman wrote:
I can't find a reason why this code is in resolve_pseudo_ldimm64;
since I'll be modifying it in a subsequent commit, tidy it up.
Signed-off-by: Brendan Jackman
Acked-by: Yonghong Song
On 12/7/20 8:07 AM, Brendan Jackman wrote:
The BPF_FETCH field can be set in bpf_insn.imm, for BPF_ATOMIC
instructions, in order to have the previous value of the
atomically-modified memory location loaded into the src register
after an atomic op is carried out.
Suggested-by: Yonghong Song
On 12/7/20 8:07 AM, Brendan Jackman wrote:
This adds two atomic opcodes, both of which include the BPF_FETCH
flag. XCHG without the BPF_FETCH flag would naturally encode
atomic_set. This is not supported because it would be of limited
value to userspace (it doesn't imply any barriers). CMPXCHG
On 12/7/20 8:07 AM, Brendan Jackman wrote:
This adds instructions for
atomic[64]_[fetch_]and
atomic[64]_[fetch_]or
atomic[64]_[fetch_]xor
All these operations are isomorphic enough to implement with the same
verifier, interpreter, and x86 JIT code, hence being a single commit.
The main inte
32. A variable called skip_tests is
defined in the BPF object's data section, which tells the userspace
object whether to skip the atomics test.
Signed-off-by: Brendan Jackman
Ack with minor comments below.
Acked-by: Yonghong Song
---
tools/testing/selftests/bpf/Makefile
On 12/7/20 8:07 AM, Brendan Jackman wrote:
Document new atomic instructions.
Signed-off-by: Brendan Jackman
Ack with minor comments below.
Acked-by: Yonghong Song
---
Documentation/networking/filter.rst | 26 ++
1 file changed, 26 insertions(+)
diff --git a
On 12/8/20 4:41 AM, Brendan Jackman wrote:
On Mon, Dec 07, 2020 at 07:18:57PM -0800, Yonghong Song wrote:
On 12/7/20 8:07 AM, Brendan Jackman wrote:
The prog_test that's added depends on Clang/LLVM features added by
Yonghong in commit 286daafd6512 (was https://reviews.llvm.org/D
On 12/8/20 8:59 AM, Brendan Jackman wrote:
On Tue, Dec 08, 2020 at 08:38:04AM -0800, Yonghong Song wrote:
On 12/8/20 4:41 AM, Brendan Jackman wrote:
On Mon, Dec 07, 2020 at 07:18:57PM -0800, Yonghong Song wrote:
On 12/7/20 8:07 AM, Brendan Jackman wrote:
The prog_test that's
On 1/11/21 3:45 PM, Song Liu wrote:
On Jan 11, 2021, at 1:58 PM, Martin Lau wrote:
On Mon, Jan 11, 2021 at 10:35:43PM +0100, KP Singh wrote:
On Mon, Jan 11, 2021 at 7:57 PM Martin KaFai Lau wrote:
On Fri, Jan 08, 2021 at 03:19:47PM -0800, Song Liu wrote:
[ ... ]
diff --git a/kernel
could also refer to
the length of the input.
Signed-off-by: Brendan Jackman
Acked-by: Yonghong Song
On 1/12/21 4:39 AM, Brendan Jackman wrote:
The error message here is misleading, the argument will be rejected
unless it is a known constant.
Signed-off-by: Brendan Jackman
Okay, this is for bpf_ringbuf_reserve() helper where the size must be a
constant.
Acked-by: Yonghong Song
On 1/12/21 7:43 AM, Daniel Borkmann wrote:
On 1/12/21 4:35 PM, Gilad Reti wrote:
On Tue, Jan 12, 2021 at 4:56 PM KP Singh wrote:
On Tue, Jan 12, 2021 at 10:16 AM Gilad Reti
wrote:
Add test to check that the verifier is able to recognize spilling of
PTR_TO_MEM registers.
It would be nic
On 1/11/21 10:20 AM, Qais Yousef wrote:
Some subsystems only have bare tracepoints (a tracepoint with no
associated trace event) to avoid the problem of trace events being an
ABI that can't be changed.
From bpf presepective, bare tracepoints are what it calls
RAW_TRACEPOINT().
Since bpf ass
area pointed by it.
The patch was partially contributed by CyberArk Software, Inc.
Signed-off-by: Gilad Reti
I didn't verify result_unpriv = ACCEPT part. I think it is correct
by checking code.
Acked-by: Yonghong Song
On 1/13/21 2:16 AM, Qais Yousef wrote:
On 01/12/21 12:19, Yonghong Song wrote:
I applied the patch to my local bpf-next repo, and got the following
compilation error:
[...]
I dumped preprecessor result but after macro expansion, the code
becomes really complex and I have not figured out
On 1/13/21 2:57 AM, Tiezhu Yang wrote:
MIPS needs __SANE_USERSPACE_TYPES__ before to select
'int-ll64.h' in arch/mips/include/uapi/asm/types.h and avoid compile
warnings when printing __u64 with %llu, %llx or %lld.
could you mention which command produces the following warning?
prin
On 1/13/21 2:57 AM, Tiezhu Yang wrote:
When make M=samples/bpf on the Loongson 3A3000 platform which
belongs to MIPS arch, there exists many similar build errors
about 'asm/rwonce.h' file not found, so include it only under
CONFIG_ARM64 and CONFIG_ALPHA due to it exists only in arm64
and alpha
On 1/13/21 2:57 AM, Tiezhu Yang wrote:
There exists many build errors and warnings when make M=samples/bpf,
both fixes in this patch related to mips, please do mention in the
commit message that this is
mips related. x86 (and arm64 I assume) compiles just fine.
this patch series fix some
On 1/13/21 2:36 PM, Ian Rogers wrote:
Add inline to __always_inline making it match the linux/compiler.h.
Adding this avoids an unused function warning on bpf_tail_call_static
when compining with -Wall.
Signed-off-by: Ian Rogers
Acked-by: Yonghong Song
com/T/#m07264fc18fdc43af02fc1320968afefcc73d96f4
Signed-off-by: Brendan Jackman
Thanks for better description!
Acked-by: Yonghong Song
On 1/18/21 4:18 AM, Qais Yousef wrote:
On 01/16/21 18:11, Yonghong Song wrote:
On 1/16/21 10:21 AM, Qais Yousef wrote:
Reuse module_attach infrastructure to add a new bare tracepoint to check
we can attach to it as a raw tracepoint.
Signed-off-by: Qais Yousef
---
.../bpf/bpf_testmod
On 1/18/21 12:53 AM, Tiezhu Yang wrote:
In the current samples/bpf/README.rst, the url of llvm and clang git
may be out of date, they are unable to access:
$ git clone http://llvm.org/git/llvm.git
Cloning into 'llvm'...
fatal: unable to access 'http://llvm.org/git/llvm.git/ ': Maximum (20)
r
On 1/17/21 7:22 PM, Tiezhu Yang wrote:
On 01/14/2021 01:12 AM, Yonghong Song wrote:
On 1/13/21 2:57 AM, Tiezhu Yang wrote:
MIPS needs __SANE_USERSPACE_TYPES__ before to select
'int-ll64.h' in arch/mips/include/uapi/asm/types.h and avoid compile
warnings when printing __u64
ate the
related comment in Makefile.
[1] https://clang.llvm.org/get_started.html
Signed-off-by: Tiezhu Yang
Ack with minor nits in the above. Also, this is a documentation update.
I think it is okay to target the patch to bpf-next instead of bpf.
Acked-by: Yonghong Song
On 1/19/21 4:22 AM, Qais Yousef wrote:
Reuse module_attach infrastructure to add a new bare tracepoint to check
we can attach to it as a raw tracepoint.
Signed-off-by: Qais Yousef
Acked-by: Yonghong Song
ep consistent.
I verified the procedure and it is proved to be feasible, so we should
update README.rst to reflect the reality. At the same time, update the
related comment in Makefile.
[1]
https://clang.llvm.org/get_started.html
Signed-off-by: Tiezhu Yang
Acked-by: Yonghong Song
---
v2
On 1/7/21 6:08 PM, 彭浩(Richard) wrote:
struct bpf_object *obj is not used in bpf_object__probe_loading, so we
can remove it.
Signed-off-by: Peng Hao
Acked-by: Yonghong Song
On 1/13/21 2:36 PM, Ian Rogers wrote:
No additional warnings are generated by enabling this, but having it
enabled will help avoid regressions.
Signed-off-by: Ian Rogers
Acked-by: Yonghong Song
On 1/14/21 5:40 AM, Jiri Olsa wrote:
It's possible to have other build id types (other than default SHA1).
Currently there's also ld support for MD5 build id.
Currently, bpf build_id based stackmap does not returns the size of
the build_id. Did you see an issue here? I guess user space can c
On 1/14/21 12:01 PM, Jiri Olsa wrote:
On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote:
On 1/14/21 5:40 AM, Jiri Olsa wrote:
It's possible to have other build id types (other than default SHA1).
Currently there's also ld support for MD5 build id.
Currently, bp
On 1/14/21 2:02 PM, Jiri Olsa wrote:
On Thu, Jan 14, 2021 at 01:05:33PM -0800, Yonghong Song wrote:
On 1/14/21 12:01 PM, Jiri Olsa wrote:
On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote:
On 1/14/21 5:40 AM, Jiri Olsa wrote:
It's possible to have other build id
_ExtInt extension enabled in clang, which is under
review.
Link: https://clang.llvm.org/docs/LanguageExtensions.html#extended-integer-types
Link: https://reviews.llvm.org/D93103
Signed-off-by: Sean Young
---
changes since v2:
- added tests as suggested by Yonghong Song
- added kernel pretty-printer
1 - 100 of 332 matches
Mail list logo
