[PATCH v1] move page flip handle into cmdq cb

2021-02-19 Thread Yongqiang Niu
irq callback will before cmdq flush ddp register into hardware, that will cause the display frame page flip event before it realy display out time Yongqiang Niu (1): CHROMIUM: drm/mediatek: move page flip handle into cmdq cb drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 33

[PATCH v1] drm/mediatek: move page flip handle into cmdq cb

2021-02-19 Thread Yongqiang Niu
move page flip handle into cmdq cb irq callback will before cmdq flush ddp register into hardware, that will cause the display frame page flip event before it realy display out time Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 33

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Fri, 2021-01-29 at 14:24 +0800, Hsin-Yi Wang wrote: > On Fri, Jan 29, 2021 at 9:33 AM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > On Thu, 2021-01-28 at 19:23 +0800, Hsin-Yi Wang wrote: > > > From: Yongqiang Niu > > > > > > for 5 or 6 bpc

Re: [PATCH v12 6/8] drm/mediatek: enable dither function

2021-01-28 Thread Yongqiang Niu
On Fri, 2021-01-29 at 14:46 +0800, Hsin-Yi Wang wrote: > On Fri, Jan 29, 2021 at 2:30 PM Yongqiang Niu > wrote: > > > > On Fri, 2021-01-29 at 14:24 +0800, Hsin-Yi Wang wrote: > > > On Fri, Jan 29, 2021 at 9:33 AM CK Hu wrote: > > > > > > > > Hi

[PATCH v1 12/21] drm/mediatek: fix ccorr size config

2020-08-19 Thread Yongqiang Niu
fix ccorr size config Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 1d8dc6a..0c81253 100644 --- a

[PATCH v1 16/21] drm/mediatek: add ovl bypass shadow register function

2020-08-19 Thread Yongqiang Niu
add ovl bypass shadow register function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 03eaadb..fb0fe59 100644

[PATCH v1 02/21] drm/mediatek: add component POSTMASK

2020-08-19 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 3 files changed, 33 insertions(+) diff

[PATCH v1 01/21] drm/mediatek: add component OVL_2L2

2020-08-19 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v1 20/21] drm/mediatek: add ccorr bypass shadow register function

2020-08-19 Thread Yongqiang Niu
add ccorr bypass shadow register function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index b4a6df5

[PATCH v1 17/21] drm/mediatek: add rdma bypass shadow register function

2020-08-19 Thread Yongqiang Niu
add rdma bypass shadow register function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c index 0683bef

[PATCH v1 19/21] drm/mediatek: add aal bypass shadow register function

2020-08-19 Thread Yongqiang Niu
add aal bypass shadow register function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index

[PATCH v1 09/21] drm/mediatek: fix aal size config

2020-08-19 Thread Yongqiang Niu
fix aal size config Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index c90d2ee..fe76387

[PATCH v1 07/21] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2020-08-19 Thread Yongqiang Niu
enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 8cf9f3b..427fe7f 100644

[PATCH v1 00/21] add drm support for MT8192

2020-08-19 Thread Yongqiang Niu
description Yongqiang Niu (21): drm/mediatek: add component OVL_2L2 drm/mediatek: add component POSTMASK drm/mediatek: add component RDMA4 mtk-mmsys: add mt8192 mmsys support mtk-mmsys: add ovl mout on support drm/mediatek: add disp config and mm 26mhz clock into mutex device drm

[PATCH v1 13/21] drm/mediatek: add support for mediatek SOC MT8192

2020-08-19 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 7 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 + drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 7 + drivers/gpu/drm/mediatek/mtk_drm_ddp.c| 35

[PATCH v1 14/21] drm/mediatek: add bypass shadow register function call for ddp component

2020-08-19 Thread Yongqiang Niu
the shadow register for mt8192 ddp component is enable, we need disable it before enable ddp component Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 7 +++ 2 files changed, 10 insertions(+) diff --git a

[PATCH v1 04/21] mtk-mmsys: add mt8192 mmsys support

2020-08-19 Thread Yongqiang Niu
add mt8192 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 159 ++ 2 files changed, 160 insertions(+) create mode 100644 drivers/soc/mediatek/mmsys/mt8192-mmsys.c diff

[PATCH v1 03/21] drm/mediatek: add component RDMA4

2020-08-19 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v1 18/21] drm/mediatek: add dither bypass shadow register function

2020-08-19 Thread Yongqiang Niu
add dither bypass shadow register function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 0c81253

[PATCH v1 08/21] drm/mediatek: check if fb is null

2020-08-19 Thread Yongqiang Niu
It's possible that state->base.fb is null. Add a check before access its format. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/

[PATCH v1 05/21] mtk-mmsys: add ovl mout on support

2020-08-19 Thread Yongqiang Niu
add ovl mout on support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 23 +++ drivers/soc/mediatek/mtk-mmsys.c | 8 include/linux/soc/mediatek/mtk-mmsys.h| 3 +++ 3 files changed, 34 insertions(+) diff --git a/drivers

[PATCH v1 21/21] arm64: dts: mt8192: add display node

2020-08-19 Thread Yongqiang Niu
add display node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 126 +++ 1 file changed, 126 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 931e1ca..d2a814d 100644

[PATCH v1 11/21] drm/mediatek: fix gamma size config

2020-08-19 Thread Yongqiang Niu
fix gamma size config Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index becd72d..1d8dc6a 100644 --- a

[PATCH v1 06/21] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-08-19 Thread Yongqiang Niu
there are 2 more clock need enable for display. parser these clock when mutex device probe, enable and disable when mutex on/off Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 49 -- 1 file changed, 41 insertions(+), 8 deletions

[PATCH v1 15/21] drm/mediatek: add color bypass shadow register function

2020-08-19 Thread Yongqiang Niu
add color bypass shadow register function Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c index 31918fa..83b075a

[PATCH v1 10/21] drm/mediatek: fix dither size config

2020-08-19 Thread Yongqiang Niu
fix dither size config Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index fe76387..becd72d 100644 --- a

[RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-08-07 Thread Yongqiang Niu
rdma fifo size may be different even in same SOC, add this property to the corresponding rdma Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9 Signed-off-by: Yongqiang Niu --- .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 14 ++ 1 file changed, 14 insertions

[RESEND v7, PATCH 2/7] drm/mediatek: move ddp component define into mtk_mmsys.h

2020-08-07 Thread Yongqiang Niu
mmsys is the driver which control the routing of these ddp component, so the definition of mtk_ddp_comp_id should be placed in mtk-mmsys.h Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 34 + drivers/soc/mediatek/mtk-mmsys.c

[RESEND v7, PATCH 7/7] arm64: dts: add display nodes for mt8183

2020-08-07 Thread Yongqiang Niu
This patch add display nodes for mt8183 Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 98 1 file changed, 98 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index

[RESEND v7, PATCH 5/7] drm/mediatek: add fifo_size into rdma private data

2020-08-07 Thread Yongqiang Niu
Get the fifo size from device tree because each rdma in the same SoC may have different fifo size Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek

[RESEND v7, PATCH 3/7] mtk-mmsys: add mmsys private data

2020-08-07 Thread Yongqiang Niu
if it is need. Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/Makefile | 1 + drivers/soc/mediatek/mmsys/Makefile | 2 + drivers/soc/mediatek/mmsys/mt2701-mmsys.c | 250 +++ drivers/soc/mediatek/mtk-mmsys.c | 271

[RESEND v7, PATCH 4/7] mtk-mmsys: add mt8183 mmsys support

2020-08-07 Thread Yongqiang Niu
add mt8183 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 154 ++ drivers/soc/mediatek/mtk-mmsys.c | 1 + 3 files changed, 156 insertions(+) create mode 100644

[RESEND v7, PATCH 6/7] drm/mediatek: add support for mediatek SOC MT8183

2020-08-07 Thread Yongqiang Niu
This patch add support for mediatek SOC MT8183 1. add ovl private data 2. add rdma private data 3. add mutes private data 4. add main and external path module for crtc create Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 18 drivers/gpu/drm/mediatek

[RESEND v7, PATCH 0/7] add drm support for MT8183

2020-08-07 Thread Yongqiang Niu
mediatek drm in patch 25 Yongqiang Niu (7): dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display drm/mediatek: move ddp component define into mtk_mmsys.h mtk-mmsys: add mmsys private data mtk-mmsys: add mt8183 mmsys support drm/mediatek: add fifo_size into rdma private

[PATCH v3, 02/15] dt-bindings: mediatek: add description for mt8192 display

2021-01-10 Thread Yongqiang Niu
add description for mt8192 display Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH v3, 00/15] drm/mediatek: add support for mediatek SOC MT8192

2021-01-10 Thread Yongqiang Niu
This series are based on 5.11-rc1 and SoC MT8183, and provide 15 patch to support mediatek SOC MT8192 Changes since v2: - fix review comment in v2 - add pm runtime for gamma and color - move ddp path select patch to mmsys series - remove some useless patch Yongqiang Niu (15): dt-bindings

[PATCH v3, 04/15] drm/mediatek: add component OVL_2L2

2021-01-10 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index 81ed076..a715127 100644 --- a

[PATCH v3, 05/15] drm/mediatek: add component POSTMASK

2021-01-10 Thread Yongqiang Niu
This patch add component POSTMASK, Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile| 1 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 160 +++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 + drivers/gpu/drm/mediatek

[PATCH v3, 03/15] arm64: dts: mt8192: add display node

2021-01-10 Thread Yongqiang Niu
add display node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 134 +++ 1 file changed, 134 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index e12e024..dcf9fdf 100644

[PATCH v3, 06/15] drm/mediatek: add component RDMA4

2021-01-10 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index bc6b10a..fc01fea 100644 --- a/drivers

[PATCH v3, 10/15] drm/mediatek: Add pm runtime support for color

2021-01-10 Thread Yongqiang Niu
color power domain need controled in the device. Signed-off-by: Yongqiang Niu Signed-off-by: Yidi Lin --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c

[PATCH v3, 11/15] drm/mediatek: fix aal size config

2021-01-10 Thread Yongqiang Niu
the orginal setting is not correct, fix it follow hardware data sheet. if keep this error setting, mt8173/mt8183 display ok but mt8192 display abnormal. Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek

[PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma

2021-01-10 Thread Yongqiang Niu
gamma power domain need controled in the device. Signed-off-by: Yongqiang Niu Signed-off-by: Yidi Lin --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c

[PATCH v3, 12/15] drm/mediatek: separate ccorr module

2021-01-10 Thread Yongqiang Niu
ccorr ctm matrix bits will be different in mt8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/Makefile | 3 +- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 222 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 92 +--- drivers/gpu

[PATCH v3, 14/15] drm/mediatek: add DDP support for MT8192

2021-01-10 Thread Yongqiang Niu
Add DDP support for MT8192 SoC. Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index 1308046..7aa7fc3

[PATCH v3, 07/15] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2021-01-10 Thread Yongqiang Niu
enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index b47c238..4934bee

[PATCH v3, 08/15] drm/mediatek: check if fb is null

2021-01-10 Thread Yongqiang Niu
It's possible that state->base.fb is null. Add a check before access its format. Fixes: b6b1bb980ec4 ( drm/mediatek: Turn off Alpha bit when plane format has no alpha) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3, 15/15] drm/mediatek: add support for mediatek SOC MT8192

2021-01-10 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c| 6 drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 + drivers/gpu/drm/mediatek/mtk_disp_postmask.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6

[PATCH v3, 01/15] dt-bindings: mediatek: add description for postmask

2021-01-10 Thread Yongqiang Niu
add description for postmask postmask is used control round corner for display frame Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek

[PATCH v3, 13/15] drm/mediatek: add matrix bits private data for ccorr

2021-01-10 Thread Yongqiang Niu
matrix bits of mt8183 is 12 matrix bits of mt8192 is 13 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ccorr.c b/drivers/gpu/drm/mediatek

Re: [PATCH v8, 1/6] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display

2020-12-10 Thread Yongqiang Niu
On Thu, 2020-12-10 at 23:40 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月10日 週四 下午5:22寫道: > > > > rdma fifo size may be different even in same SOC, add this > > property to the corresponding rdma > > > > Signed-off-by: Yongqiang

Re: [PATCH v8, 5/6] drm/mediatek: add RDMA fifo size error handle

2020-12-10 Thread Yongqiang Niu
On Thu, 2020-12-10 at 23:50 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月10日 週四 下午5:08寫道: > > > > This patch add RDMA fifo size error handle > > rdma fifo size will not always bigger than the calculated threshold > > if that case happe

[PATCH v2, 00/17] drm/mediatek: add support for mediatek SOC MT8192

2020-12-11 Thread Yongqiang Niu
mmsys support - add ovl mount on support - add 2 more clock into mutex device - fix ovl smi_id_en and fb null software bug - fix ddp compoent size config bug - add mt8192 drm support - add ddp bypass shadow register function - add 8192 dts description Yongqiang Niu (17): dt-bindings: mediatek: add

[PATCH v2, 01/17] dt-bindings: mediatek: add description for postmask

2020-12-11 Thread Yongqiang Niu
add description for postmask Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings

[PATCH v2, 11/17] drm/mediatek: fix dither size config

2020-12-11 Thread Yongqiang Niu
fix dither size config Fixes: 450aa87c7353 (drm/mediatek: add component DITHER) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm

[PATCH v2, 13/17] drm/mediatek: fix ccorr size config

2020-12-11 Thread Yongqiang Niu
fix ccorr size config Fixes: cefb6abfcc1c (drm/mediatek: add ddp component CCORR) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm

[PATCH v2, 05/17] drm/mediatek: add component POSTMASK

2020-12-11 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 31 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 3 files changed, 33 insertions(+) diff

[PATCH v2, 07/17] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-12-11 Thread Yongqiang Niu
there are 2 more clock need enable for display. parser these clock when mutex device probe, enable and disable when mutex on/off Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 49 -- 1 file changed, 41 insertions(+), 8 deletions

[PATCH v2, 09/17] drm/mediatek: check if fb is null

2020-12-11 Thread Yongqiang Niu
It's possible that state->base.fb is null. Add a check before access its format. Fixes: b6b1bb980ec4 ( drm/mediatek: Turn off Alpha bit when plane format has no alpha) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2, 14/17] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-11 Thread Yongqiang Niu
Use function call for setting mmsys ovl mout register Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mtk-mmsys.c | 18 ++ include/linux/soc/mediatek/mtk-mmsys.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/soc/mediatek/mmsys/mtk-mmsys.c b

[PATCH v2, 02/17] dt-bindings: mediatek: add CLK_MM_DISP_CONFIG control description for mt8192 display

2020-12-11 Thread Yongqiang Niu
add CLK_MM_DISP_CONFIG control description for mt8192 displa Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b

[PATCH v2, 04/17] drm/mediatek: add component OVL_2L2

2020-12-11 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v2, 03/17] dt-bindings: mediatek: add description for mt8192 display

2020-12-11 Thread Yongqiang Niu
add description for mt8192 display Signed-off-by: Yongqiang Niu --- Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation

[PATCH v2, 06/17] drm/mediatek: add component RDMA4

2020-12-11 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + include/linux/soc/mediatek/mtk-mmsys.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek

[PATCH v2, 10/17] drm/mediatek: fix aal size config

2020-12-11 Thread Yongqiang Niu
fix aal size config Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b

[PATCH v2, 15/17] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-11 Thread Yongqiang Niu
add mt8192 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 119 ++ include/linux/soc/mediatek/mtk-mmsys.h| 1 + 3 files changed, 121 insertions(+) create mode 100644

[PATCH v2, 17/17] arm64: dts: mt8192: add display node

2020-12-11 Thread Yongqiang Niu
add display node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 130 +++ 1 file changed, 130 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 7c0c233..da681b0 100644

[PATCH v2, 16/17] drm/mediatek: add support for mediatek SOC MT8192

2020-12-11 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 6 drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 + drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 drivers/gpu/drm/mediatek/mtk_drm_ddp.c| 35

[PATCH v2, 12/17] drm/mediatek: fix gamma size config

2020-12-11 Thread Yongqiang Niu
fix gamma size config Fixes: e0a5d3370245 (drm/mediatek: Add GAMMA engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu

[PATCH v2, 08/17] drm/mediatek: enable OVL_LAYER_SMI_ID_EN for multi-layer usecase

2020-12-11 Thread Yongqiang Niu
enable OVL_LAYER_SMI_ID_EN for multi-layer usecase Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 8cf9f3b..97f8380

Re: [PATCH v1, 3/5] mailbox: mediatek: add control_by_sw private data

2020-12-22 Thread Yongqiang Niu
On Sat, 2020-12-05 at 15:35 +0800, Nicolas Boichat wrote: > On Sat, Dec 5, 2020 at 12:18 PM Yongqiang Niu > wrote: > > > > add control_by_sw private data > > Can you describe in a bit more details what this means? gce works well without this patch, and it will be

Re: [PATCH v1, 4/5] soc: mediatek: cmdq: add address shift in jump

2020-12-22 Thread Yongqiang Niu
On Wed, 2020-12-09 at 23:16 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Nicolas Boichat 於 2020年12月5日 週六 下午3:30寫道: > > > > On Sat, Dec 5, 2020 at 12:16 PM Yongqiang Niu > > wrote: > > > > > > Add address shift when compose jump instruction > &

Re: [PATCH v2, 2/2] soc: mediatek: mmsys: Use function call for setting the routing registers

2020-12-22 Thread Yongqiang Niu
On Thu, 2020-12-17 at 14:04 +0800, Hsin-Yi Wang wrote: > On Wed, Dec 9, 2020 at 9:32 AM Yongqiang Niu > wrote: > > > > Actually, setting the registers for routing, use multiple 'if-else' for > > different > > routes, but this code would be more and more c

Re: [PATCH v2, 01/17] dt-bindings: mediatek: add description for postmask

2020-12-22 Thread Yongqiang Niu
On Tue, 2020-12-15 at 22:49 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > > > add description for postmask > > What is postmask? I google it and find a postmask ECO. So it is postmask ECO? > > Regards, > Chun

Re: [PATCH v2, 02/17] dt-bindings: mediatek: add CLK_MM_DISP_CONFIG control description for mt8192 display

2020-12-22 Thread Yongqiang Niu
On Wed, 2020-12-16 at 23:17 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > > > add CLK_MM_DISP_CONFIG control description for mt8192 displa > > display > > > > > Signed-off-by: Yongqiang Niu > > --

Re: [PATCH v2, 04/17] drm/mediatek: add component OVL_2L2

2020-12-22 Thread Yongqiang Niu
On Sun, 2020-12-13 at 09:15 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月12日 週六 下午12:12寫道: > > > > This patch add component OVL_2L2 > > Break drm part and soc part into different patches. > > Regards, > Chun-Kuang. will be fix

Re: [PATCH v2, 07/17] drm/mediatek: add disp config and mm 26mhz clock into mutex device

2020-12-22 Thread Yongqiang Niu
On Tue, 2020-12-15 at 21:37 +0800, Nicolas Boichat wrote: > On Sat, Dec 12, 2020 at 12:12 PM Yongqiang Niu > wrote: > > > > there are 2 more clock need enable for display. > > parser these clock when mutex device probe, > > enable and disable when mutex on/off > &

Re: [PATCH v2, 10/17] drm/mediatek: fix aal size config

2020-12-22 Thread Yongqiang Niu
On Wed, 2020-12-16 at 23:10 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月12日 週六 下午12:22寫道: > > > > fix aal size config > > > > Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) > > Signed-off-by: Yongqiang Niu

Re: [PATCH v2, 12/17] drm/mediatek: fix gamma size config

2020-12-22 Thread Yongqiang Niu
On Tue, 2020-12-15 at 07:40 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月12日 週六 下午12:13寫道: > > > > fix gamma size config > > I would like you to provide more information. The original code works > in mt8173, why do you modify this? Th

Re: [PATCH v2, 14/17] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-22 Thread Yongqiang Niu
On Tue, 2020-12-15 at 21:42 +0800, Nicolas Boichat wrote: > On Sat, Dec 12, 2020 at 12:13 PM Yongqiang Niu > wrote: > > > > Use function call for setting mmsys ovl mout register > > > > Signed-off-by: Yongqiang Niu > > --- > > d

soc: mediatek: cmdq: add address shift in jump

2020-12-23 Thread Yongqiang Niu
Change since v1: -move out from mt8192 seri series Yongqiang Niu (1): soc: mediatek: cmdq: add address shift in jump drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.1.1.dirty

[PATCH v2] soc: mediatek: cmdq: add address shift in jump

2020-12-23 Thread Yongqiang Niu
Add address shift when compose jump instruction to compatible with 35bit format. Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") Signed-off-by: Yongqiang Niu Reviewed-by: Nicolas Boichat --- drivers/mailbox/mtk-cmdq-mailbox.c | 3 ++- 1 file changed, 2

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-01-07 Thread Yongqiang Niu
On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > Add address shift when compose jump instruction > to compatible with 35bit format. > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > Signed-off-by: Yongqiang Niu &g

Re: [PATCH v3, 7/8] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-28 Thread Yongqiang Niu
On Tue, 2020-12-29 at 00:38 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:38寫道: > > > > Use function call for setting mmsys ovl mout register > > > > Signed-off-by: Yongqiang Niu > > --- > >

Re: [PATCH v3, 7/8] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-28 Thread Yongqiang Niu
On Tue, 2020-12-29 at 00:38 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月28日 週一 下午4:38寫道: > > > > Use function call for setting mmsys ovl mout register > > > > Signed-off-by: Yongqiang Niu > > --- > >

[PATCH v2, 0/3] support gce on mt8192 platform

2020-12-23 Thread Yongqiang Niu
Change since v1: - move out shit jump patch - rmove usless patch Yongqiang Niu (3): dt-binding: gce: add gce header file for mt8192 arm64: dts: mt8192: add gce node mailbox: cmdq: add mt8192 support .../devicetree/bindings/mailbox/mtk-gce.txt| 7 +- arch/arm64/boot/dts/mediatek

[PATCH v2, 2/3] arm64: dts: mt8192: add gce node

2020-12-23 Thread Yongqiang Niu
add gce node Signed-off-by: Yongqiang Niu --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 69d45c7..e9684a6 100644 --- a/arch/arm64/boot/dts

[PATCH v2, 3/3] mailbox: cmdq: add mt8192 support

2020-12-23 Thread Yongqiang Niu
add mt8192 support Signed-off-by: Yongqiang Niu --- drivers/mailbox/mtk-cmdq-mailbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 75378e3..7f243e1 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b

[PATCH v2, 1/3] dt-binding: gce: add gce header file for mt8192

2020-12-23 Thread Yongqiang Niu
Add documentation for the mt8192 gce. Add gce header file defined the gce hardware event, subsys number and constant for mt8192. Signed-off-by: Yongqiang Niu --- .../devicetree/bindings/mailbox/mtk-gce.txt| 7 +- include/dt-bindings/gce/mt8192-gce.h | 419

Re: [PATCH v2, 3/3] mailbox: cmdq: add mt8192 support

2020-12-24 Thread Yongqiang Niu
On Thu, 2020-12-24 at 22:28 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年12月24日 週四 上午8:55寫道: > > > > add mt8192 support > > > > Signed-off-by: Yongqiang Niu > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 1 + > >

soc: mediatek: Prepare MMSYS for DDP routing using function call

2020-12-28 Thread Yongqiang Niu
The following series are intended to prepare the mtk-mmsys driver to allow different DDP (Data Display Path) function call per SoC. base change: https://patchwork.kernel.org/project/linux-mediatek/patch/20201006193320.405529-4-enric.balle...@collabora.com/ Change since v2: - fix review issue in v

[PATCH v3, 4/8] soc: mediatek: mmsys: add component OVL_2L2

2020-12-28 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 4b6c514..42476c2 100644 --- a/include/linux/soc

[PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

2020-12-28 Thread Yongqiang Niu
the mmsys will more and more complicated after support more and more SoCs, add an independent folder will be more clear Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/Makefile | 2 +- drivers/soc/mediatek/mmsys/Makefile| 2 + drivers/soc/mediatek/mmsys/mtk-mmsys.c | 380

[PATCH v3, 5/8] soc: mediatek: mmsys: add component POSTMASK

2020-12-28 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 42476c2..09ee424 100644 --- a/include/linux/soc

[PATCH v3, 2/8] soc: mediatek: mmsys: Use function call for setting the routing registers

2020-12-28 Thread Yongqiang Niu
Actually, setting the registers for routing, use multiple 'if-else' for different routes, but this code would be more and more complicated while we support more and more SoCs. Change that and use a function call per SoC so the code will be more portable and clear. Signed-off-by: Yon

[PATCH v3, 7/8] soc: mediatek: mmsys: Use function call for setting mmsys ovl mout register

2020-12-28 Thread Yongqiang Niu
Use function call for setting mmsys ovl mout register Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/mtk-mmsys.c | 20 include/linux/soc/mediatek/mtk-mmsys.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/soc/mediatek/mmsys/mtk-mmsys.c b

[PATCH v3, 8/8] soc: mediatek: mmsys: add mt8192 mmsys support

2020-12-28 Thread Yongqiang Niu
add mt8192 mmsys support Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8192-mmsys.c | 119 ++ drivers/soc/mediatek/mmsys/mtk-mmsys.c| 9 +++ include/linux/soc/mediatek/mtk-mmsys.h| 1 + 4

[PATCH v3, 6/8] soc: mediatek: mmsys: add component RDMA4

2020-12-28 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 09ee424..aa4f60e 100644 --- a/include/linux/soc

[PATCH v3, 3/8] soc: mediatek: mmsys: add mt8183 function call for setting the routing registers

2020-12-28 Thread Yongqiang Niu
add mt8183 function call for setting the routing registers Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mmsys/Makefile | 1 + drivers/soc/mediatek/mmsys/mt8183-mmsys.c | 90 +++ drivers/soc/mediatek/mmsys/mtk-mmsys.c| 1 + include/linux/soc

Re: [PATCH v1, 3/3] drm/mediatek: gamma set with cmdq

2021-04-12 Thread Yongqiang Niu
On Mon, 2021-04-12 at 16:28 +0800, CK Hu wrote: > Hi, Yongqiang: > > On Mon, 2021-04-12 at 14:35 +0800, Yongqiang Niu wrote: > > gamma lut set in vsync active will caused display flash issue > > set gamma lut with cmdq > > In MT8173, it's ok to set gammma

  1   2   >