: f3b5a8d9b50d ("phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Changes from v2:
- revise the commit log (s/pm_runtime_pm/pm_runtime_enable)
Changes from v1:
- revise the commit log (s/the own/its ow
t;
> Cc: Geert Uytterhoeven <geert+rene...@glider.be>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
Hi,
> From: Yoshihiro Shimoda
> Sent: Friday, March 03, 2017 8:33 PM
>
> This patch fixes an issue that phy_create() never enables the pm_runtime.
> And then, we can remove calling the pm_runtime_{en,dis}able from some
> phy drivers.
>
> Fixes: ff764963479a ("
This patch fixes an issue that phy_create() never enables the pm_runtime.
And then, we can remove calling the pm_runtime_{en,dis}able from some
phy drivers.
Fixes: ff764963479a ("drivers: phy: add generic PHY framework")
Cc: sta...@vger.kernel.org # v3.13+
Signed-off-by: Yoshihi
I don't think this explanation needs.
After this is removed,
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
> Print error message and propagate the return value of platform_get_irq
> on failure.
>
> This issue was detected with the
gt;
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
Hi,
> -Original Message-
> From: Rob Herring
> Sent: Saturday, June 24, 2017 3:21 AM
>
> On Thu, Jun 15, 2017 at 08:34:22PM +0900, Yoshihiro Shimoda wrote:
> > USB 2.0 PHY of R-Car Gen3 can change the clock source from an oscillator
> > to an external clock via
Hi,
> From: Yoshihiro Shimoda
> Sent: Wednesday, May 24, 2017 9:04 PM
>
> The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
> - Spread spectrum clock (ssc).
> - Using USB 2.0 EXTAL clock instead of USB 3.0 clock.
> - Enabling VBUS detection for usb3.0 peripheral.
>
&g
The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
- Spread spectrum clock (ssc).
- Using USB 2.0 EXTAL clock instead of USB 3.0 clock.
- Enabling VBUS detection for usb3.0 peripheral.
So, this driver supports these features.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
- Spread spectrum clock (ssc).
- Using USB 2.0 EXTAL clock instead of USB 3.0 clock.
- Enabling VBUS detection for usb3.0 peripheral.
So, this driver supports these features.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
Hi Geert-san,
> From: Geert Uytterhoeven
> Sent: Wednesday, May 24, 2017 9:39 PM
>
> Hi Shimoda-san,
>
> On Wed, May 24, 2017 at 2:17 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
- Spread spectrum clock (ssc).
- Using USB 2.0 EXTAL clock instead of USB 3.0 clock.
- Enabling VBUS detection for usb3.0 peripheral.
So, this driver supports these features.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
USB 2.0 PHY of R-Car Gen3 can change the clock source from an oscillator
to an external clock via a register. So, this patch adds support
the clock source selector as a generic PHY driver.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
This patch is based on the
Hi Kishon,
> From: Yoshihiro Shimoda
> Sent: Monday, May 29, 2017 7:42 PM
>
> The USB 3.0 PHY modules of R-Car Gen3 SoCs have:
> - Spread spectrum clock (ssc).
> - Using USB 2.0 EXTAL clock instead of USB 3.0 clock.
> - Enabling VBUS detection for usb3.0 peripheral.
Hi Simon-san,
Thank you for the comments!
> From: Simon Horman, Sent: Tuesday, October 10, 2017 4:46 PM
>
> On Tue, Oct 10, 2017 at 02:58:28PM +0900, Yoshihiro Shimoda wrote:
> > This patch cleanups the role_{store,show}() and replaces the local
> > "bool"
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++
he code.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/phy/renesas
This patch modifies the role_store() to use "enum phy_mode" instead
of the local "bool" for host/device mode selection.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 29 ++-
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't
have dedicated pins (ID, VBUS), this will match against the generic
fallback on R-Car D3.
For now, this driver doesn't support usb role swap for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
by".
Changes from v2:
- Revise the commit log ("SoCs" is not third-person singular present).
Changes from v1:
- Revise typo "wronly" to "wrongly".
- Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in
patch 3/4
- Remove the driver change from
m Chen-Yu Tsai (for phy-sun4i-usb.c & extcon-axp288.c)
> - Add acked-by from Charles Keepax (for drivers/extcon/extcon-arizona.c)
> - Add acked-by from Lee Jones (fo include/linux/mfd/palmas.h)
< snip >
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +-
and
< snip >
> drivers/usb/gadget/udc/renesas_usb3.c | 2 +-
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
Hi Kishon,
Would you review this patch set?
I checked this can apply your latest linux-phy.git / next branch (the commit id
= 415060b21f31).
Best regards,
Yoshihiro Shimoda
> -Original Message-
> From: Yoshihiro Shimoda
> Sent: Friday, September 1, 2017 11:41 AM
> To: k
Hi,
> From: Kishon Vijay Abraham I [mailto:kis...@ti.com], Sent: Wednesday, October
> 11, 2017 5:28 PM
>
> Hi,
>
> On Tuesday 10 October 2017 03:11 PM, Yoshihiro Shimoda wrote:
> > This patch modifies the role_store() to use "enum phy_mode" instead
> >
s is needed?
I know. This behavior is the same as R-Car H3. But, I didn't find any errata
documents. So, I'm asking HW guys why this environment causes it. However,
I don't get any feedback yet. I think we need any reason for applying such a
quirk.
Best regards,
Yoshihiro Shimoda
> >>&
#define RENESAS_USB_DRIVER_H
>
> -#include
> +#include
Since this driver doesn't use any extcon-provider APIs for now,
we doesn't need the modification, IIUC.
Best regards,
Yoshihiro Shimoda
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --g
This patch adds SoC-specific parameter to avoid reading/writing
specific registers wrongly if this driver runs on a SoC which doesn't
have dedicated pins (e.g. R-Car D3).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't
have dedicated pins (ID, VBUS), this will match against the generic
fallback on R-Car D3.
For now, this driver doesn't support usb role swap for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
po "wronly" to "wrongly".
- Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in
patch 3/4
- Remove the driver change from patch 4/4.
- Revise the commit log of patch 4/4.
Yoshihiro Shimoda (4):
phy: rcar-gen3-usb2: check dr_mode for otg mode
phy: rcar-ge
Hi Geert-san,
Thank you for the comments!
> From: Geert Uytterhoeven
> Sent: Thursday, August 31, 2017 4:51 PM
>
> Hi Shimoda-san,
>
> On Thu, Aug 31, 2017 at 9:31 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > This patch adds SoC-sp
Hi Geert-san,
> From: Geert Uytterhoeven
> Sent: Thursday, August 31, 2017 5:27 PM
>
> Hi Shimoda-san,
>
> On Thu, Aug 31, 2017 at 10:15 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> >> From: Geert Uytterhoeven
> >> Sent: Thurs
as "has dedicated otg pins" and adds a new value
"can_role_swap". For now, the behavior is the same as before.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 ++--
1 file cha
Hello,
> -Original Message-
> From: Sergei Shtylyov
> Sent: Thursday, August 31, 2017 6:41 PM
>
> Hello!
>
> On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote:
>
> > The previous code assumed a channel has otg capability if a channel
> > has interrupt p
as "has dedicated otg pins" and adds a new value
"can_role_swap". For now, the behavior is the same as before.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 ++--
1 file cha
> -Original Message-
> From: Sergei Shtylyov
> Sent: Thursday, August 31, 2017 6:43 PM
>
> On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote:
>
> > This patch adds SoC-specific parameter to avoid reading/writing
> > specific registers wronly if this driv
This patch adds SoC-specific parameter to avoid reading/writing
specific registers wrongly if this driver runs on a SoC which doesn't
have dedicated pins (e.g. R-Car D3).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't
have dedicated pins (ID, VBUS), this will match against the generic
fallback on R-Car D3.
For now, this driver doesn't support usb role swap for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --g
commit log ("SoCs" is not third-person singular present).
Changes from v1:
- Revise typo "wronly" to "wrongly".
- Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in
patch 3/4
- Remove the driver change from patch 4/4.
- Revise the commit log of patch
as "has dedicated otg pins" and adds a new value
"can_role_swap". For now, the behavior is the same as before.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 ++--
1 file cha
This patch set is based on the latest phy.git / next branch
(the commit id = d9c51f4c53ae2af03aa8bd001d46f21b0adcdab8).
After this patch set is applied, a usb 2.0 host node that is combined
with usb 2.0 peripheral needs 'dr_mode = "otg";' property.
Yoshihiro Shimoda (4):
phy: rcar
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --g
This patch adds SoC-specific parameter to avoid reading/writing
specific registers wronly if this driver runs on a SoC which doesn't
have dedicated pins (e.g. R-Car D3).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't
have dedicated pins (ID, VBUS), this of_device_id doesn't have any data.
For now, this driver doesn't support usb role swap for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documen
Hi,
Thank you for the comment!
I will submit v4 patch soon. But, I wrote some comments below.
> From: Kishon Vijay Abraham I, Sent: Monday, October 9, 2017 7:07 PM
>
> Hi,
>
> On Friday 01 September 2017 08:11 AM, Yoshihiro Shimoda wrote:
> > The has_otg on previous cod
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++
This patch cleanups the role_{store,show}() and replaces the local
"bool" for host/device mode selection with the "enum phy_mode" in
the role_store().
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't
have dedicated pins (ID, VBUS), this will match against the generic
fallback on R-Car D3.
For now, this driver doesn't support usb role swap for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
SoCs" is not third-person singular present).
Changes from v1:
- Revise typo "wronly" to "wrongly".
- Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in
patch 3/4
- Remove the driver change from patch 4/4.
- Revise the commit log of patch 4/4.
Yoshihiro Shim
he code.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/phy/renesas
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't
have dedicated pins (ID, VBUS), this will match against the generic
fallback on R-Car D3.
For now, this driver doesn't support usb role swap for r8a77995.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
This patch modifies the role_store() to use "enum phy_mode" instead
of the local "bool" for host/device mode selection.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/r
typo "wronly" to "wrongly".
- Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in
patch 3/4
- Remove the driver change from patch 4/4.
- Revise the commit log of patch 4/4.
Yoshihiro Shimoda (4):
phy: rcar-gen3-usb2: check dr_mode for otg mode
phy: rcar-gen3
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++
he code.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Reviewed-by: Simon Horman <horms+rene...@verge.net.au>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/phy/renesas
eature is enabled? But, I don't find the point yet.
The renesas_usbhs also uses the phy_rcar_gen3_usb2 driver.
--> If I only used the renesas_usbhs driver (in other words, I don't install
[eo]hci-{hcd,platform} drivers), the issue disappeared.
--> So, I think the phy_rcar_gen3_usb2 driver doesn't cause this issue.
(But, it is possible to be related though.)
I'll continue to investigate this issue tomorrow.
Best regards,
Yoshihiro Shimoda
Hi,
> From: Ulf Hansson, Sent: Wednesday, November 29, 2017 2:23 AM
>
> On 28 November 2017 at 13:48, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Hi Geert-san,
> >
> >> From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7
Hi,
> From: Alan Stern, Sent: Wednesday, November 29, 2017 12:07 AM
>
> On Tue, 28 Nov 2017, Yoshihiro Shimoda wrote:
>
> > Hi Geert-san,
> >
> > > From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM
> > >
> > > Hi Rafael, Shimo
to that the driver may be misbehaving in some
> way. I can help to check what is going on.
I guess so. But, I don't find yet...
Best regards,
Yoshihiro Shimoda
> Kind regards
> Uffe
Hi,
> From: Ulf Hansson, Sent: Monday, December 4, 2017 7:41 PM
>
> On 1 December 2017 at 12:03, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Sure! I tested your patch, and then the following message disappeared!
> >
> >Enabling runt
Hi Rob,
Thank you for your comments!
> -Original Message-
> From: Rob Herring, Sent: Sunday, December 17, 2017 3:05 AM
>
> On Fri, Dec 15, 2017 at 02:45:26PM +0900, Yoshihiro Shimoda wrote:
> > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS
> &
Hi Rob,
> From: Rob Herring, Sent: Tuesday, December 19, 2017 9:10 AM
>
> On Sun, Dec 17, 2017 at 11:16 PM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Hi Rob,
> >
> > Thank you for your comments!
> >
> >> From: R
ore [1]
and it will be merged into the usb repository [2] in near the future.
[1] https://lkml.org/lkml/2017/11/2/373
[2] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the
usb-linus branch.
Best regards,
Yoshihiro Shimoda
> ---
> drivers/phy/renesas/Kconfig | 2 ++
&g
This patch unifies the OBINTEN handling to clean-up the code.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/phy/renesas/ph
f "enable_" to "control_" or "set_" that
will enable/disable irq or vbus.
Yoshihiro Shimoda (6):
phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway
phy: renesas: rcar-gen3-usb2: unify OBINTEN handling
phy: renesas: rcar-gen3-usb2: change the function name to
This patch add rcar_gen3_role_swap_ops to support other feature
(e.g. gpio handling) easily.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 51 +++-
1 file changed, 43 insertions(+), 8 del
Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS
and ID. So, they may be connected to gpio pins. To handle the gpio
pins, this patch adds the handling of VBUS and ID pins instead of
dedicated pins.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
To support gpio handling in the future, this patch clean-ups the code
to use prefix "has_otg_pins_" functions.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 130 ---
1 file change
In the future, the work struct will be used by non-irq related code.
So, this patch moves the INIT_WORK() timing.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
This patch changes the function name from rcar_gen3_enable_vbus_ctrl()
to rcar_gen3_set_vbus_ctrl() because the fucntion both enables and
disables.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 16
t_dr_mode_by_phy() is available.
>
> Signed-off-by: Vladimir Murzin <vladimir.mur...@arm.com>
Thank you for the patch! However, Arnd already sent such a patch before.
https://lkml.org/lkml/2017/11/2/373
The latest Linux-phy.git doesn't apply it yet though...
Best regards,
Yoshihiro Shimoda
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, December 13, 2017 5:55 PM
>
> Hi Shimoda-san,
>
> On Wed, Dec 13, 2017 at 7:27 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicat
Hello!
> From: Sergei Shtylyov, Sent: Wednesday, December 13, 2017 6:10 PM
>
> Hello!
>
> On 12/13/2017 9:27 AM, Yoshihiro Shimoda wrote:
>
> > This patch unifies the OBINTEN handling to clean-up the code.
> >
> > Signed-off-by: Yoshihiro Shimo
This patch add rcar_gen3_role_swap_ops to support other feature
(e.g. gpio handling) easily.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 51 +++-
1 file changed, 43 insertions(+), 8 del
Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS
and ID. So, they may be connected to gpio pins. To handle the gpio
pins, this patch adds the handling of VBUS and ID pins instead of
dedicated pins.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.
This patch set is based on the latest linux-phy / next branch
(commit id = 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323).
This new feature will be used by the renesas_usbhs driver on R-Car D3.
Yoshihiro Shimoda (5):
phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway
phy: renesas: rcar-gen3
In the future, the work struct will be used by non-irq related code.
So, this patch moves the INIT_WORK() timing.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
To support gpio handling in the future, this patch clean-ups the code
to use prefix "has_otg_pins_" functions.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 130 ---
1 file change
This patch unifies the OBINTEN handling to clean-up the code.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/drivers/phy/renesas/ph
rsion 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
rgmann <a...@arndb.de>
Thank you for the patch!
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Best regards,
Yoshihiro Shimoda
Hunk #1 succeeded at 525 (offset -9 lines).
Hunk #2 succeeded at 703 (offset -9 lines).
I'm not sure you should resolve it or not.
But, this patch could work without any regressions. So,
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
[1] https://www.spinics.net/lists/linux-usb/msg162421.html
Best regards,
Yoshihiro Shimoda
Hi,
> From: Ulf Hansson, Sent: Friday, December 1, 2017 6:22 PM
>
> + Kishon
>
> On 30 November 2017 at 13:51, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Hi,
> >
> >> From: Ulf Hansson, Sent: Wednesday, November 29, 2017 6
Hi again,
> From: Yoshihiro Shimoda, Sent: Friday, December 1, 2017 8:04 PM
>
> Hi,
>
> However, the following message still exists.
>
>Enabling runtime PM for inactive device (ee08.usb) with active children
>
> So, I guess ohci-platform.c also has similar
h
> @@ -17,7 +17,6 @@
> #include
> #include
> #include
> -#include
After I applied this patch, some ata and gpu drivers causes build error [1].
So, we should fix the drivers at first...
Best regards,
Yoshihiro Shimoda
---
[1]
drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_resume':
driv
> From: Ulf Hansson, Sent: Thursday, December 21, 2017 7:58 PM
>
> On 21 December 2017 at 11:33, Yoshihiro Shimoda
> <yoshihiro.shimoda...@renesas.com> wrote:
> > Hi Ulf-san,
> >
> >> -Original Message-
> >> From: Ulf Hansson, Sent: Wedn
ly rebasing and
> adding the right SoB?
I'm very sorry for this trouble.
When I ported this patch, I dropped the author's Signed-of-by wrongly..
Signed-off-by: Takeshi Kihara
Best regards,
Yoshihiro Shimoda
> Yours,
> Linus Walleij
>
> On Mon, Jul 9, 2018 at 11:54 PM Steph
Hi,
> From: Kishon Vijay Abraham I, Sent: Friday, March 2, 2018 5:15 PM
>
> On Tuesday 27 February 2018 11:22 AM, Yoshihiro Shimoda wrote:
> > This patch adds binding for r8a77965 (R-Car M3-N).
>
> $subject should be dt-bindings: rcar-gen3-phy-usb3: Add binding for r8
Hi,
> From: Kishon Vijay Abraham I, Sent: Friday, March 2, 2018 5:15 PM
>
> On Tuesday 27 February 2018 11:22 AM, Yoshihiro Shimoda wrote:
> > This patch adds support for r8a77965 (R-Car M3-N). This SoC has
> > dedicated pins.
> >
> > Signed-off-by: Yos
This patch adds support for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-ph
This patch set adds R-Car Gen3 USB 2.0 and 3.0 support for R8A77965.
Changes from v1:
- Separate patch1 to dt-bindings and adding of_device_id table entry.
- Revise the subject for dt-bindings patch(es).
Yoshihiro Shimoda (3):
dt-bindings: rcar-gen3-phy-usb2: Add bindings for r8a77965
phy
This patch adds bindings for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-ph
This patch adds support for r8a77965 (R-Car M3-N). This SoC has
dedicated pins.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb
This patch set adds R-Car Gen3 USB 2.0 and 3.0 support for R8A77965.
Yoshihiro Shimoda (2):
phy: rcar-gen3-usb2: Add support for r8a77965
phy: rcar-gen3-usb3: Add binding for r8a77965
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
Documentation/devicetree/bindings/phy
This patch adds binding for r8a77965 (R-Car M3-N).
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-ph
This patch adds support for r8a77965 (R-Car M3-N). This SoC has
dedicated pins.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
---
Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4 +
tart = xhci_plat_start;
Thank you for the care of xhci-rcar driver.
However, this "xhci_plat_hc_drver" should be "xhci_plat_hc_driver".
After I modified it by myself, I could build the xhci-plat-hcd.ko in my
environment.
Best regards,
Yoshihiro Shimoda
--
To unsubscribe from this list
as "has dedicated otg pins" and adds a new value
"can_role_swap". For now, the behavior is the same as before.
Signed-off-by: Yoshihiro Shimoda
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 ++--
1 file changed, 42 insertions(+), 19 deletions(-)
has dr_mode property or
not. If it has 'dr_mode = "otg";', this driver enables otg capability.
Signed-off-by: Yoshihiro Shimoda
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/phy/renesas/phy-rcar-gen3
This patch adds SoC-specific parameter to avoid reading/writing
specific registers wronly if this driver runs on a SoC which doesn't
have dedicated pins (e.g. R-Car D3).
Signed-off-by: Yoshihiro Shimoda
---
drivers/phy/renesas/phy-rcar-gen3-usb2.c | 25 -
1 file changed
101 - 200 of 633 matches
Mail list logo