[PATCH 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-08-31 Thread Yoshihiro Shimoda
This patch set is based on the latest phy.git / next branch (the commit id = d9c51f4c53ae2af03aa8bd001d46f21b0adcdab8). After this patch set is applied, a usb 2.0 host node that is combined with usb 2.0 peripheral needs 'dr_mode = "otg";' property. Yoshihiro Shimoda (4): phy: rcar

[PATCH 4/4] phy: rcar-gen3-usb2: add binding for r8a77995

2017-08-31 Thread Yoshihiro Shimoda
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't have dedicated pins (ID, VBUS), this of_device_id doesn't have any data. For now, this driver doesn't support usb role swap for r8a77995. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen3

RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-08-31 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for the comments! > From: Geert Uytterhoeven > Sent: Thursday, August 31, 2017 4:51 PM > > Hi Shimoda-san, > > On Thu, Aug 31, 2017 at 9:31 AM, Yoshihiro Shimoda > wrote: > > This patch adds SoC-specific parameter to avoid reading/writing &g

RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-08-31 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven > Sent: Thursday, August 31, 2017 5:27 PM > > Hi Shimoda-san, > > On Thu, Aug 31, 2017 at 10:15 AM, Yoshihiro Shimoda > wrote: > >> From: Geert Uytterhoeven > >> Sent: Thursday, August 31, 2017 4:51 PM > >

[PATCH v2 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

2017-08-31 Thread Yoshihiro Shimoda
has dr_mode property or not. If it has 'dr_mode = "otg";', this driver enables otg capability. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3

[PATCH v2 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-08-31 Thread Yoshihiro Shimoda
po "wronly" to "wrongly". - Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in patch 3/4 - Remove the driver change from patch 4/4. - Revise the commit log of patch 4/4. Yoshihiro Shimoda (4): phy: rcar-gen3-usb2: check dr_mode for otg mode phy: rcar-ge

[PATCH v2 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-08-31 Thread Yoshihiro Shimoda
This patch adds SoC-specific parameter to avoid reading/writing specific registers wrongly if this driver runs on a SoC which doesn't have dedicated pins (e.g. R-Car D3). Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 24 +++- 1 file changed

[PATCH v2 4/4] phy: rcar-gen3-usb2: add binding for r8a77995

2017-08-31 Thread Yoshihiro Shimoda
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't have dedicated pins (ID, VBUS), this will match against the generic fallback on R-Car D3. For now, this driver doesn't support usb role swap for r8a77995. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree

[PATCH v2 2/4] phy: rcar-gen3-usb2: split the two meaning of "has_otg"

2017-08-31 Thread Yoshihiro Shimoda
as "has dedicated otg pins" and adds a new value "can_role_swap". For now, the behavior is the same as before. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 ++-- 1 file changed, 42 insertions(+), 19 deletions(-)

RE: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

2017-08-31 Thread Yoshihiro Shimoda
Hello, > -Original Message- > From: Sergei Shtylyov > Sent: Thursday, August 31, 2017 6:41 PM > > Hello! > > On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: > > > The previous code assumed a channel has otg capability if a channel > > has interrupt p

RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-08-31 Thread Yoshihiro Shimoda
> -Original Message- > From: Sergei Shtylyov > Sent: Thursday, August 31, 2017 6:43 PM > > On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote: > > > This patch adds SoC-specific parameter to avoid reading/writing > > specific registers wronly if this driv

[PATCH v3 2/4] phy: rcar-gen3-usb2: split the two meaning of "has_otg"

2017-08-31 Thread Yoshihiro Shimoda
as "has dedicated otg pins" and adds a new value "can_role_swap". For now, the behavior is the same as before. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 ++-- 1 file changed, 42 insertions(+), 19 deletions(-)

[PATCH v3 4/4] phy: rcar-gen3-usb2: add binding for r8a77995

2017-08-31 Thread Yoshihiro Shimoda
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't have dedicated pins (ID, VBUS), this will match against the generic fallback on R-Car D3. For now, this driver doesn't support usb role swap for r8a77995. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree

[PATCH v3 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

2017-08-31 Thread Yoshihiro Shimoda
has dr_mode property or not. If it has 'dr_mode = "otg";', this driver enables otg capability. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3

[PATCH v3 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-08-31 Thread Yoshihiro Shimoda
commit log ("SoCs" is not third-person singular present). Changes from v1: - Revise typo "wronly" to "wrongly". - Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in patch 3/4 - Remove the driver change from patch 4/4. - Revise the commit log of patch

[PATCH v3 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-08-31 Thread Yoshihiro Shimoda
This patch adds SoC-specific parameter to avoid reading/writing specific registers wrongly if this driver runs on a SoC which doesn't have dedicated pins (e.g. R-Car D3). Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 24 +++- 1 file changed

RE: [PATCH v3 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-10-05 Thread Yoshihiro Shimoda
Hi Kishon, Would you review this patch set? I checked this can apply your latest linux-phy.git / next branch (the commit id = 415060b21f31). Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Friday, September 1, 2017 11:41 AM > To: k

[PATCH v6 2/4] phy: rcar-gen3-usb2: use enum phy_mode in the role_store()

2017-10-12 Thread Yoshihiro Shimoda
This patch modifies the role_store() to use "enum phy_mode" instead of the local "bool" for host/device mode selection. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 29 ++--- 1 file ch

[PATCH v6 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-10-12 Thread Yoshihiro Shimoda
typo "wronly" to "wrongly". - Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in patch 3/4 - Remove the driver change from patch 4/4. - Revise the commit log of patch 4/4. Yoshihiro Shimoda (4): phy: rcar-gen3-usb2: check dr_mode for otg mode phy: rcar-gen3

[PATCH v6 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

2017-10-12 Thread Yoshihiro Shimoda
has dr_mode property or not. If it has 'dr_mode = "otg";', this driver enables otg capability. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/p

[PATCH v6 4/4] phy: rcar-gen3-usb2: add binding for r8a77995

2017-10-12 Thread Yoshihiro Shimoda
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't have dedicated pins (ID, VBUS), this will match against the generic fallback on R-Car D3. For now, this driver doesn't support usb role swap for r8a77995. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

[PATCH v6 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-10-12 Thread Yoshihiro Shimoda
he code. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 00a

RE: [PATCH v5 2/4] phy: rcar-gen3-usb2: use enum phy_mode in the role_store()

2017-10-12 Thread Yoshihiro Shimoda
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com], Sent: Wednesday, October > 11, 2017 5:28 PM > > Hi, > > On Tuesday 10 October 2017 03:11 PM, Yoshihiro Shimoda wrote: > > This patch modifies the role_store() to use "enum phy_mode" instead > >

RE: [PATCH 06/11] usb: renesas_usbhs: constify hc_driver structures

2017-07-31 Thread Yoshihiro Shimoda
gt; > Signed-off-by: Julia Lawall Thank you for the patch! Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-09-28 Thread Yoshihiro Shimoda
#define RENESAS_USB_DRIVER_H > > -#include > +#include Since this driver doesn't use any extcon-provider APIs for now, we doesn't need the modification, IIUC. Best regards, Yoshihiro Shimoda

RE: [PATCH v2 6/6] phy: renesas: rcar-gen3-usb2: add gpio handling

2017-12-19 Thread Yoshihiro Shimoda
Hi Rob, > From: Rob Herring, Sent: Tuesday, December 19, 2017 9:10 AM > > On Sun, Dec 17, 2017 at 11:16 PM, Yoshihiro Shimoda > wrote: > > Hi Rob, > > > > Thank you for your comments! > > > >> From: Rob Herring, Sent: Sunday, December 17, 2017 3:

RE: [PATCH] phy: rcar: fix gen3-usb2 build error

2017-12-19 Thread Yoshihiro Shimoda
sb repository [2] in near the future. [1] https://lkml.org/lkml/2017/11/2/373 [2] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-linus branch. Best regards, Yoshihiro Shimoda > --- > drivers/phy/renesas/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) &g

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-28 Thread Yoshihiro Shimoda
it today. I don't find the root cause yet. However, it seems related to usb host and/or usb core. --> USB host related devices' child_count will be 1 in suspend timing. --> I guess remote wakeup feature is enabled? But, I don't find the point yet. The renesas_usbhs also uses the phy_rcar_gen3_usb2 driver. --> If I only used the renesas_usbhs driver (in other words, I don't install [eo]hci-{hcd,platform} drivers), the issue disappeared. --> So, I think the phy_rcar_gen3_usb2 driver doesn't cause this issue. (But, it is possible to be related though.) I'll continue to investigate this issue tomorrow. Best regards, Yoshihiro Shimoda

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-29 Thread Yoshihiro Shimoda
Hi, > From: Ulf Hansson, Sent: Wednesday, November 29, 2017 2:23 AM > > On 28 November 2017 at 13:48, Yoshihiro Shimoda > wrote: > > Hi Geert-san, > > > >> From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM > >> > >> Hi Rafael,

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-29 Thread Yoshihiro Shimoda
Hi, > From: Alan Stern, Sent: Wednesday, November 29, 2017 12:07 AM > > On Tue, 28 Nov 2017, Yoshihiro Shimoda wrote: > > > Hi Geert-san, > > > > > From: Geert Uytterhoeven, Sent: Tuesday, November 28, 2017 7:58 PM > > > > > > Hi Rafael, Shimo

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-12-04 Thread Yoshihiro Shimoda
Hi, > From: Ulf Hansson, Sent: Monday, December 4, 2017 7:41 PM > > On 1 December 2017 at 12:03, Yoshihiro Shimoda > wrote: > > Sure! I tested your patch, and then the following message disappeared! > > > >Enabling runtime PM for inactive device (ee080200.usb-

RE: [PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling

2017-12-14 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, December 13, 2017 5:55 PM > > Hi Shimoda-san, > > On Wed, Dec 13, 2017 at 7:27 AM, Yoshihiro Shimoda > wrote: > > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS > > and ID. So, they

RE: [PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling

2017-12-14 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov, Sent: Wednesday, December 13, 2017 6:10 PM > > Hello! > > On 12/13/2017 9:27 AM, Yoshihiro Shimoda wrote: > > > This patch unifies the OBINTEN handling to clean-up the code. > > > > Signed-off-by: Yoshihiro Shimoda > &

[PATCH v2 2/6] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling

2017-12-14 Thread Yoshihiro Shimoda
This patch unifies the OBINTEN handling to clean-up the code. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy

[PATCH v2 0/6] phy: renesas: rcar-gen3-usb2: add gpio handling for R-Car D3

2017-12-14 Thread Yoshihiro Shimoda
f "enable_" to "control_" or "set_" that will enable/disable irq or vbus. Yoshihiro Shimoda (6): phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway phy: renesas: rcar-gen3-usb2: unify OBINTEN handling phy: renesas: rcar-gen3-usb2: change the function name to

[PATCH v2 1/6] phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway

2017-12-14 Thread Yoshihiro Shimoda
In the future, the work struct will be used by non-irq related code. So, this patch moves the INIT_WORK() timing. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3

[PATCH v2 3/6] phy: renesas: rcar-gen3-usb2: change the function name to set_vbus_ctrl()

2017-12-14 Thread Yoshihiro Shimoda
This patch changes the function name from rcar_gen3_enable_vbus_ctrl() to rcar_gen3_set_vbus_ctrl() because the fucntion both enables and disables. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 16 1 file changed, 8 insertions(+), 8 deletions

[PATCH v2 4/6] phy: renesas: rcar-gen3-usb2: use prefix "has_otg_pins_" for dedicated pins handling

2017-12-14 Thread Yoshihiro Shimoda
To support gpio handling in the future, this patch clean-ups the code to use prefix "has_otg_pins_" functions. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 130 --- 1 file changed, 85 insertions(+), 45 deletions(-)

[PATCH v2 6/6] phy: renesas: rcar-gen3-usb2: add gpio handling

2017-12-14 Thread Yoshihiro Shimoda
Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS and ID. So, they may be connected to gpio pins. To handle the gpio pins, this patch adds the handling of VBUS and ID pins instead of dedicated pins. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/phy/rcar-gen3-phy

[PATCH v2 5/6] phy: renesas: rcar-gen3-usb2: add rcar_gen3_role_swap_ops

2017-12-14 Thread Yoshihiro Shimoda
This patch add rcar_gen3_role_swap_ops to support other feature (e.g. gpio handling) easily. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 51 +++- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/drivers/phy/renesas

RE: [PATCH] phy: rcar-gen3-usb2: add dependency on USB

2017-12-15 Thread Yoshihiro Shimoda
t_dr_mode_by_phy() is available. > > Signed-off-by: Vladimir Murzin Thank you for the patch! However, Arnd already sent such a patch before. https://lkml.org/lkml/2017/11/2/373 The latest Linux-phy.git doesn't apply it yet though... Best regards, Yoshihiro Shimoda

RE: [PATCH v2 2/3] phy: core: Drop unused runtime PM APIs

2017-12-21 Thread Yoshihiro Shimoda
h > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include After I applied this patch, some ata and gpu drivers causes build error [1]. So, we should fix the drivers at first... Best regards, Yoshihiro Shimoda --- [1] drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_resume': driv

RE: [PATCH v2 2/3] phy: core: Drop unused runtime PM APIs

2017-12-21 Thread Yoshihiro Shimoda
> From: Ulf Hansson, Sent: Thursday, December 21, 2017 7:58 PM > > On 21 December 2017 at 11:33, Yoshihiro Shimoda > wrote: > > Hi Ulf-san, > > > >> -Original Message- > >> From: Ulf Hansson, Sent: Wednesday, December 20, 2017 11:09 PM > &

RE: [PATCH v2 6/6] phy: renesas: rcar-gen3-usb2: add gpio handling

2017-12-17 Thread Yoshihiro Shimoda
Hi Rob, Thank you for your comments! > -Original Message- > From: Rob Herring, Sent: Sunday, December 17, 2017 3:05 AM > > On Fri, Dec 15, 2017 at 02:45:26PM +0900, Yoshihiro Shimoda wrote: > > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS > &

RE: [PATCH] phy: rcar-gen3-usb2: select USB_COMMON

2017-11-06 Thread Yoshihiro Shimoda
gen3-usb2.c:(.text+0x250): undefined reference to > `of_usb_get_dr_mode_by_phy' > > Other phy drivers select USB_COMMON for this, so let's do the same > here. > > Fixes: 7e0540f41332 ("phy: rcar-gen3-usb2: check dr_mode for otg mode") > Signed-off-by: Arnd Bergmann

RE: [PATCH] usb: gadget: udc: renesas_usb3: make const array max_packet_array static

2017-11-06 Thread Yoshihiro Shimoda
igned-off-by: Colin Ian King Thank you for the patch! Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] usb: xhci: Renesas uPD720202 needs short TX quirk

2017-09-06 Thread Yoshihiro Shimoda
is the same as R-Car H3. But, I didn't find any errata documents. So, I'm asking HW guys why this environment causes it. However, I don't get any feedback yet. I think we need any reason for applying such a quirk. Best regards, Yoshihiro Shimoda > >>> [77122.622952] handle_tx_event:

RE: [PATCH] usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

2017-08-09 Thread Yoshihiro Shimoda
I don't think this explanation needs. After this is removed, Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > Print error message and propagate the return value of platform_get_irq > on failure. > > This issue was detected with the help of Coccinelle. > > Signed-o

RE: [PATCH 1/2] phy: rcar-gen3-usb2: Add support for r8a77965

2018-03-04 Thread Yoshihiro Shimoda
Hi, > From: Kishon Vijay Abraham I, Sent: Friday, March 2, 2018 5:15 PM > > On Tuesday 27 February 2018 11:22 AM, Yoshihiro Shimoda wrote: > > This patch adds support for r8a77965 (R-Car M3-N). This SoC has > > dedicated pins. > > > > Signed-off-by: Yoshihiro Sh

RE: [PATCH 2/2] phy: rcar-gen3-usb3: Add binding for r8a77965

2018-03-04 Thread Yoshihiro Shimoda
Hi, > From: Kishon Vijay Abraham I, Sent: Friday, March 2, 2018 5:15 PM > > On Tuesday 27 February 2018 11:22 AM, Yoshihiro Shimoda wrote: > > This patch adds binding for r8a77965 (R-Car M3-N). > > $subject should be dt-bindings: rcar-gen3-phy-usb3: Add binding for r8

[PATCH v2 0/3] phy: rcar-gen3-usb[23]: Add support for r8a77965

2018-03-04 Thread Yoshihiro Shimoda
This patch set adds R-Car Gen3 USB 2.0 and 3.0 support for R8A77965. Changes from v1: - Separate patch1 to dt-bindings and adding of_device_id table entry. - Revise the subject for dt-bindings patch(es). Yoshihiro Shimoda (3): dt-bindings: rcar-gen3-phy-usb2: Add bindings for r8a77965 phy

[PATCH v2 3/3] dt-bindings: rcar-gen3-phy-usb3: Add bindings for r8a77965

2018-03-04 Thread Yoshihiro Shimoda
This patch adds bindings for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt b/Documentation/devicetree

[PATCH v2 2/3] phy: rcar-gen3-usb2: Add support for r8a77965

2018-03-04 Thread Yoshihiro Shimoda
This patch adds support for r8a77965 (R-Car M3-N). This SoC has dedicated pins. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3

[PATCH v2 1/3] dt-bindings: rcar-gen3-phy-usb2: Add bindings for r8a77965

2018-03-04 Thread Yoshihiro Shimoda
This patch adds support for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree

[PATCH 0/2] phy rcar-gen3-usb[23]: Add support for r8a77965

2018-02-26 Thread Yoshihiro Shimoda
This patch set adds R-Car Gen3 USB 2.0 and 3.0 support for R8A77965. Yoshihiro Shimoda (2): phy: rcar-gen3-usb2: Add support for r8a77965 phy: rcar-gen3-usb3: Add binding for r8a77965 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ Documentation/devicetree/bindings/phy

[PATCH 1/2] phy: rcar-gen3-usb2: Add support for r8a77965

2018-02-26 Thread Yoshihiro Shimoda
This patch adds support for r8a77965 (R-Car M3-N). This SoC has dedicated pins. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4 2 files changed, 6 insertions(+) diff

[PATCH 2/2] phy: rcar-gen3-usb3: Add binding for r8a77965

2018-02-26 Thread Yoshihiro Shimoda
This patch adds binding for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb3.txt b/Documentation/devicetree

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-12-01 Thread Yoshihiro Shimoda
Hi, > From: Ulf Hansson, Sent: Friday, December 1, 2017 6:22 PM > > + Kishon > > On 30 November 2017 at 13:51, Yoshihiro Shimoda > wrote: > > Hi, > > > >> From: Ulf Hansson, Sent: Wednesday, November 29, 2017 6:59 PM > >> > >> On 2

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-12-01 Thread Yoshihiro Shimoda
Hi again, > From: Yoshihiro Shimoda, Sent: Friday, December 1, 2017 8:04 PM > > Hi, > > However, the following message still exists. > >Enabling runtime PM for inactive device (ee08.usb) with active children > > So, I guess ohci-platform.c also has similar

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-11-30 Thread Yoshihiro Shimoda
isbehaving in some > way. I can help to check what is going on. I guess so. But, I don't find yet... Best regards, Yoshihiro Shimoda > Kind regards > Uffe

RE: [PATCH] renesas_usbhs: use renesas_usbhs_get_info()

2017-11-07 Thread Yoshihiro Shimoda
-9 lines). I'm not sure you should resolve it or not. But, this patch could work without any regressions. So, Acked-by: Yoshihiro Shimoda [1] https://www.spinics.net/lists/linux-usb/msg162421.html Best regards, Yoshihiro Shimoda

RE: [PATCH v3 2/4] phy: rcar-gen3-usb2: split the two meaning of "has_otg"

2017-10-10 Thread Yoshihiro Shimoda
Hi, Thank you for the comment! I will submit v4 patch soon. But, I wrote some comments below. > From: Kishon Vijay Abraham I, Sent: Monday, October 9, 2017 7:07 PM > > Hi, > > On Friday 01 September 2017 08:11 AM, Yoshihiro Shimoda wrote: > > The has_otg on previous cod

[PATCH v4 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-10-10 Thread Yoshihiro Shimoda
SoCs" is not third-person singular present). Changes from v1: - Revise typo "wronly" to "wrongly". - Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in patch 3/4 - Remove the driver change from patch 4/4. - Revise the commit log of patch 4/4. Yoshihiro Shim

[PATCH v4 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-10-10 Thread Yoshihiro Shimoda
he code. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 761

[PATCH v4 4/4] phy: rcar-gen3-usb2: add binding for r8a77995

2017-10-10 Thread Yoshihiro Shimoda
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't have dedicated pins (ID, VBUS), this will match against the generic fallback on R-Car D3. For now, this driver doesn't support usb role swap for r8a77995. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

[PATCH v4 2/4] phy: rcar-gen3-usb2: cleanup the role_{store,show}()

2017-10-10 Thread Yoshihiro Shimoda
This patch cleanups the role_{store,show}() and replaces the local "bool" for host/device mode selection with the "enum phy_mode" in the role_store(). Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 58 ++--

[PATCH v4 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

2017-10-10 Thread Yoshihiro Shimoda
has dr_mode property or not. If it has 'dr_mode = "otg";', this driver enables otg capability. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/p

RE: [PATCH v4 2/4] phy: rcar-gen3-usb2: cleanup the role_{store,show}()

2017-10-10 Thread Yoshihiro Shimoda
Hi Simon-san, Thank you for the comments! > From: Simon Horman, Sent: Tuesday, October 10, 2017 4:46 PM > > On Tue, Oct 10, 2017 at 02:58:28PM +0900, Yoshihiro Shimoda wrote: > > This patch cleanups the role_{store,show}() and replaces the local > > "bool"

[PATCH v5 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

2017-10-10 Thread Yoshihiro Shimoda
has dr_mode property or not. If it has 'dr_mode = "otg";', this driver enables otg capability. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/p

[PATCH v5 4/4] phy: rcar-gen3-usb2: add binding for r8a77995

2017-10-10 Thread Yoshihiro Shimoda
This patch adds binding for r8a77995 (R-Car D3). Since r8a77995 doesn't have dedicated pins (ID, VBUS), this will match against the generic fallback on R-Car D3. For now, this driver doesn't support usb role swap for r8a77995. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

[PATCH v5 0/4] phy: rcar-gen3-usb2: add support for r8a77995

2017-10-10 Thread Yoshihiro Shimoda
by". Changes from v2: - Revise the commit log ("SoCs" is not third-person singular present). Changes from v1: - Revise typo "wronly" to "wrongly". - Remove RCAR_GEN3_PHY_HAS_DEDICATED_PINS from generic gen3 entry in patch 3/4 - Remove the driver change from

[PATCH v5 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins

2017-10-10 Thread Yoshihiro Shimoda
he code. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 731

[PATCH v5 2/4] phy: rcar-gen3-usb2: use enum phy_mode in the role_store()

2017-10-10 Thread Yoshihiro Shimoda
This patch modifies the role_store() to use "enum phy_mode" instead of the local "bool" for host/device mode selection. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 29 ++--- 1 file changed, 18 insertions(+), 11 dele

RE: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

2017-10-10 Thread Yoshihiro Shimoda
bastian Reichel (for drivers/power/supply/) > - Add acked-by from Chen-Yu Tsai (for phy-sun4i-usb.c & extcon-axp288.c) > - Add acked-by from Charles Keepax (for drivers/extcon/extcon-arizona.c) > - Add acked-by from Lee Jones (fo include/linux/mfd/palmas.h) < snip > > drivers/p

[PATCH 1/5] phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway

2017-12-12 Thread Yoshihiro Shimoda
In the future, the work struct will be used by non-irq related code. So, this patch moves the INIT_WORK() timing. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3

[PATCH 3/5] phy: renesas: rcar-gen3-usb2: use prefix "has_otg_pins_" for dedicated pins handling

2017-12-12 Thread Yoshihiro Shimoda
To support gpio handling in the future, this patch clean-ups the code to use prefix "has_otg_pins_" functions. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 130 --- 1 file changed, 85 insertions(+), 45 deletions(-)

[PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling

2017-12-12 Thread Yoshihiro Shimoda
Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS and ID. So, they may be connected to gpio pins. To handle the gpio pins, this patch adds the handling of VBUS and ID pins instead of dedicated pins. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/phy/rcar-gen3-phy

[PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling

2017-12-12 Thread Yoshihiro Shimoda
This patch unifies the OBINTEN handling to clean-up the code. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy

[PATCH 0/5] phy: renesas: rcar-gen3-usb2: add gpio handling for R-Car D3

2017-12-12 Thread Yoshihiro Shimoda
This patch set is based on the latest linux-phy / next branch (commit id = 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323). This new feature will be used by the renesas_usbhs driver on R-Car D3. Yoshihiro Shimoda (5): phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway phy: renesas: rcar-gen3

[PATCH 4/5] phy: renesas: rcar-gen3-usb2: add rcar_gen3_role_swap_ops

2017-12-12 Thread Yoshihiro Shimoda
This patch add rcar_gen3_role_swap_ops to support other feature (e.g. gpio handling) easily. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 51 +++- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/drivers/phy/renesas

RE: [PATCH 11/20] dt-bindings: usb: renesas,usbhs: Add r8a774e1 support

2020-08-27 Thread Yoshihiro Shimoda
gt; > Reviewed-by: Marian-Cristian Rotariu > > > > --- > > Documentation/devicetree/bindings/usb/renesas,usbhs.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > Gentle ping. Thank you for the ping. Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 08/20] dt-bindings: usb: usb-xhci: Document r8a774e1 support

2020-08-27 Thread Yoshihiro Shimoda
> > > Gentle ping. Thank you for the ping. However, since the latest kernel has renesas,usb-xhci.yaml, would you fix the patch? Best regards, Yoshihiro Shimoda

RE: [PATCH 01/20] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1

2020-08-27 Thread Yoshihiro Shimoda
> > Reviewed-by: Marian-Cristian Rotariu > > > > --- > > Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 + > > 1 file changed, 1 insertion(+) > > > Gentle ping. Thank you for the ping. Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 1/2] dt-bindings: iommu: renesas,ipmmu-vmsa: Add r8a7742 support

2020-08-27 Thread Yoshihiro Shimoda
-by: Chris Paterson > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 1/2] dt-bindings: pwm: renesas,pwm-rcar: Add r8a774e1 support

2020-08-27 Thread Yoshihiro Shimoda
; Signed-off-by: Marian-Cristian Rotariu > > Signed-off-by: Lad Prabhakar > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.yaml | 1 + > 1 file changed, 1 insertion(+) > > d

RE: [PATCH 1/5] dt-bindings: pci: rcar-pci-ep: Document r8a774a1 and r8a774b1

2020-08-24 Thread Yoshihiro Shimoda
or R-Car Gen3 and RZ/G2 devices as the > PCIe module is identical. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH RESEND v3 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic()

2020-09-10 Thread Yoshihiro Shimoda
Hi Chunfeng, Thank you for the patch! > From: Chunfeng Yun, Sent: Thursday, September 10, 2020 5:22 PM > > Use readl_poll_timeout_atomic() to simplify code > > Cc: Mathias Nyman > Cc: Yoshihiro Shimoda > Signed-off-by: Chunfeng Yun > --- > v2~v3: no changes >

RE: [PATCH RESEND v3 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic()

2020-09-10 Thread Yoshihiro Shimoda
> > > > > > Cc: Mathias Nyman > > > Cc: Yoshihiro Shimoda > > > Signed-off-by: Chunfeng Yun > > > --- > > > v2~v3: no changes > > > --- > > > drivers/usb/host/xhci-rcar.c | 43 > > >

RE: [PATCH RESEND v3 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic()

2020-09-10 Thread Yoshihiro Shimoda
Hi Chunfeng, > From: Chunfeng Yun, Sent: Friday, September 11, 2020 1:13 PM > > On Fri, 2020-09-11 at 03:13 +, Yoshihiro Shimoda wrote: > > Hi Daniel, Chunfeng, > > > > > From: Chunfeng Yun, Sent: Friday, September 11, 2020 11:33 AM > > > > >

RE: [PATCH RESEND v3 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic()

2020-09-11 Thread Yoshihiro Shimoda
te: > > > > On Thu, 2020-09-10 at 14:12 +0100, Daniel Thompson wrote: > > > > > On Thu, Sep 10, 2020 at 04:21:45PM +0800, Chunfeng Yun wrote: > > > > > > Use readl_poll_timeout_atomic() to simplify code > > > > > > > > > >

RE: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-10 Thread Yoshihiro Shimoda
Hi Matti-san, > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 8:56 PM > > Hi Yoshihiro san, > > On Thu, 2020-12-10 at 10:58 +0000, Yoshihiro Shimoda wrote: > > Hi Matti, > > > > > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM

[PATCH v2 02/10] mfd: rohm-generic: Add BD9571 and BD9574

2020-12-11 Thread Yoshihiro Shimoda
Add chip IDs for BD9571MWV and BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- include/linux/mfd/rohm-generic.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h index 4283b5b..affacf8 100644 --- a/include/linux/mfd/rohm

[PATCH v2 06/10] gpio: bd9571mwv: rid of using struct bd9571mwv

2020-12-11 Thread Yoshihiro Shimoda
To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda --- drivers/gpio/gpio-bd9571mwv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio

[PATCH v2 01/10] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

2020-12-11 Thread Yoshihiro Shimoda
Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree

[PATCH v2 00/10] treewide: bd9571mwv: Add support for BD9574MWF

2020-12-11 Thread Yoshihiro Shimoda
umber" with "part_name". https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059 Khiem Nguyen (2): mfd: bd9571mwv: Make the driver more generic mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda (8): dt-bindings: mfd: bd9571mwv: Document BD9574MWF mf

[PATCH v2 05/10] gpio: bd9571mwv: Use the SPDX license identifier

2020-12-11 Thread Yoshihiro Shimoda
Use the SPDX license identifier instead of a local description. Signed-off-by: Yoshihiro Shimoda --- drivers/gpio/gpio-bd9571mwv.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c index c0abc9c..abb622c

[PATCH v2 07/10] gpio: bd9571mwv: Add BD9574MWF support

2020-12-11 Thread Yoshihiro Shimoda
Add support for BD9574MWF which is silimar chip with BD9571MWV. Note that BD9574MWF has an additional feature, but doesn't support it for now. Signed-off-by: Yoshihiro Shimoda --- drivers/gpio/gpio-bd9571mwv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 03/10] regulator: bd9571mwv: rid of using struct bd9571mwv

2020-12-11 Thread Yoshihiro Shimoda
To simplify this driver, use dev_get_regmap() and rid of using struct bd9571mwv. Signed-off-by: Yoshihiro Shimoda --- drivers/regulator/bd9571mwv-regulator.c | 49 + 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/regulator/bd9571mwv

[PATCH v2 09/10] mfd: bd9571mwv: Make the driver more generic

2020-12-11 Thread Yoshihiro Shimoda
From: Khiem Nguyen Since the driver supports BD9571MWV PMIC only, this patch makes the functions and data structure become more generic so that it can support other PMIC variants as well. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers

[PATCH v2 10/10] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-11 Thread Yoshihiro Shimoda
From: Khiem Nguyen The new PMIC BD9574MWF inherits features from BD9571MWV. Add the support of new PMIC to existing bd9571mwv driver. Signed-off-by: Khiem Nguyen [shimoda: rebase and refactor] Signed-off-by: Yoshihiro Shimoda --- drivers/mfd/bd9571mwv.c | 86

<    1   2   3   4   5   6   7   >