Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that BD9574MWF doesn't support AVS and VID.
Signed-off-by: Yoshihiro Shimoda
---
drivers/regulator/bd9571mwv-regulator.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c b/drivers
Hi again,
> From: Yoshihiro Shimoda, Sent: Friday, December 11, 2020 9:49 AM
>
> > but as I said - these are only 'nit' comments and I am not insisting on
> > changing these. Especially since some of the comments are more related
> > to changing the original bd957
Hello Sergei,
> From: Sergei Shtylyov, Sent: Thursday, December 24, 2020 5:50 PM
> On 24.12.2020 10:04, Yoshihiro Shimoda wrote:
>
> > Use dev_regmap_add_irq_chip() to simplify the code.
>
> devm_?
Thank you for the pointed it out.
I'll fix it.
Best regards,
Yoshihiro Shimoda
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Matti Vaittinen
--
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (10):
mfd: bd9571mwv: Use devm_mfd_add_devices()
dt-bindings: mfd: bd9571mwv: Document BD9574MW
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 77 +++
include/linux/mfd/bd9571mwv.h | 18 ++
2 files changed, 43 insertions(+), 52 deletions(-)
diff
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
Use devm_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Matti Vaittinen
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:26 PM
>
> Hi Shimoda-san,
>
> On Tue, Dec 8, 2020 at 9:06 AM Yoshihiro Shimoda
> wrote:
> > index 80c6ef0..57bdb6a 100644
> > --- a/drivers/mfd/bd9
>
> > +#define BD9574MWF_VDCORE_VINIT 0x50
> > +#define BD9574MWF_VD09_VINIT 0x51
> > +#define BD9574MWF_VDCORE_SETVMAX 0x52
> > +#define BD9574MWF_VDCORE_SETVID0x54
> > +#define BD9574MWF_VDCORE_MONIVDAC 0x55
> > +#define BD9574MWF_VDCORE_PGD_CNT 0x56
>
> Some of the above are the same as the corresponding BD9571MWV
> registers, so using the same define may simplify regulator support
> (cfr. BD9571MWV_DVFS_SETVID and BD9571MWV_DVFS_MONIVDAC).
Indeed. I'll fix it.
> > +#define BD9574MWF_PART_NUMBER "BD9574MWF"
>
> BD9574MWF_PART_NAME?
Yes, I'll rename it.
Best regards,
Yoshihiro Shimoda
Hi Geert-san, Matti,
Thank you for your comments!
> From: Geert Uytterhoeven, Sent: Thursday, December 10, 2020 5:20 PM
>
> Hi Matti, Shimoda-san,
>
> On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti
> wrote:
> > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wr
> > }
> > }
>
> Given we probably won't have more than a handful variants, I'm
> leaning towards the switch() approach.
OK. I got it. I'll use switch().
Best regards,
Yoshihiro Shimoda
Hi Matti,
> From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM
>
> On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote:
> > From: Khiem Nguyen
> >
> > The new PMIC BD9574MWF inherits features from BD9571MWV.
> > Add the support of new
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM
> On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda
> wrote:
> > --- a/drivers/mfd/bd9571mwv.c
> > +++ b/drivers/mfd/bd9571mwv.c
>
> > @@ -200,12 +277,14
Hi Matti-san,
> From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM
>
> On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote:
> > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda
> > wrote:
> > > Use dev_regmap_add_irq_chip() to simplify th
d_table[]?
> You still need the "bd9574mwf-gpio" entry, don't you?
You're correct. The MFD driver uses "bd9574mwf-gpio". And,
"bd9574mwf-gpio" with 0 is not good. So, I'll keep this patch.
Thank you for the point it out.
Best regards,
Yoshihiro Shimoda
, at least this MFD driver uses "bd9574mwf-gpio"
for probing. So, I'll keep that patch as-is.
Best regards,
Yoshihiro Shimoda
Hi Matti-san,
> From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:39 PM
>
> On Tue, 2020-12-22 at 09:25 +, Yoshihiro Shimoda wrote:
> > Hi Matti-san,
> >
> > > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM
> > >
> &g
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
b/Documentation/devicetree
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Matti Vaittinen
--
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c | 89 +--
include/linux/mfd/bd9571mwv.h | 18 +
2 files changed, 54 insertions(+), 53 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git
BD9574MWF.
- Rename "part_number" with "part_name".
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (10):
mfd: bd9571mwv: Us
Use dev_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Matti Vaittinen
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff
Hi Sergei,
> From: Sergei Shtylyov, Sent: Wednesday, December 23, 2020 6:15 PM
>
> On 22.12.2020 14:22, Yoshihiro Shimoda wrote:
>
> > Add support for BD9574MWF which is silimar chip with BD9571MWV.
>
> Similar (again)? :-)
Thank you for pointed it out! I'll fix th
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Matti Vaittinen
--
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-
Use dev_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Matti Vaittinen
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff
-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c | 89 +--
include/linux/mfd/bd9571mwv.h | 18 +
2 files changed, 54 insertions(+), 53 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
b/Documentation/devicetree
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (10):
mfd: bd9571mwv: Use devm_mfd_add_devices()
dt-bindings: mfd: bd9571mwv: Document BD9574MWF
mfd: rohm-generic: Add BD9571 and BD9574
regulator: bd9571mwv: rid of using struct bd9571m
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Hi Lee,
> From: Lee Jones, Sent: Thursday, December 24, 2020 12:39 AM
> On Wed, 23 Dec 2020, Yoshihiro Shimoda wrote:
> > From: Khiem Nguyen
> >
> > Since the driver supports BD9571MWV PMIC only, this patch makes
> > the functions and data structure become more gene
ator drivers.
- Add missing regmap ranges for BD9574MWF.
- Rename "part_number" with "part_name".
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support fo
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
b/Documentation/devicetree
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/mfd/bd9571mwv.c | 77 +++
include/linux/mfd/bd9571mwv.h | 18 ++
2 files changed, 43 insertions(+), 52 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
Use dev_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Matti Vaittinen
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
Reviewed-by: Geert Uytterhoeven
Reviewed-by: Matti Vaittinen
--
Hi Lee,
> From: Lee Jones, Sent: Thursday, December 24, 2020 4:34 PM
> > Hi Lee,
> >
> > > From: Lee Jones, Sent: Thursday, December 24, 2020 12:39 AM
> > > On Wed, 23 Dec 2020, Yoshihiro Shimoda wrote:
> > > > From: Khiem Nguyen
> &
MWF.
- Add BD9574MWF support for gpio and regulator drivers.
- Add missing regmap ranges for BD9574MWF.
- Rename "part_number" with "part_name".
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more ge
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 6 +++---
1 file changed, 3 insert
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Use dev_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c
index
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
Acked-for-MFD-by: Lee Jones
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
Co-developed-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 83
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
Acked-for-MFD-by: Lee Jones
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
-by: Yoshihiro Shimoda
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 89 +--
include/linux/mfd/bd9571mwv.h | 18 +
2 files changed, 54 insertions(+), 53 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c
Document other similar specification chip BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
---
Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
b/Documentation/devicetree
Hello Matti-san,
> From: Vaittinen, Matti, Sent: Friday, December 11, 2020 9:34 PM
>
> Hello again Shimada-san,
>
> On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> > Add support for BD9574MWF which is silimar chip with BD9571MWV.
> > Note that BD9574MWF
Hi Matti-san,
Thank you for your review!
> From: Vaittinen, Matti, Sent: Friday, December 11, 2020 9:55 PM
>
> On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> > Add support for BD9574MWF which is silimar chip with BD9571MWV.
> > Note that BD9574MWF has
Hi Matti-san,
Thank you for your review!
> From: Vaittinen, Matti, Sent: Friday, December 11, 2020 10:29 PM
>
> Hi Yoshihiro-san,
>
> On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote:
> > From: Khiem Nguyen
> >
> > Since the driver supports BD9571MW
Hello Matti-san,
> From: Vaittinen, Matti, Sent: Monday, December 14, 2020 4:13 PM
>
> Hello Shimoda-san,
>
> On Mon, 2020-12-14 at 04:57 +0000, Yoshihiro Shimoda wrote:
> > Hello Matti-san,
> >
> > > From: Vaittinen, Matti, Sent: Friday, December 11,
> From: Yoshihiro Shimoda, Sent: Friday, December 11, 2020 8:28 PM
>
> Use the SPDX license identifier instead of a local description.
>
> Signed-off-by: Yoshihiro Shimoda
I forgot to add Geert-san's Reviewed-by here. So, I'll submit v3 patch series
later.
https://patch
Hi Geert-san, Matti-san,
> From: Geert Uytterhoeven, Sent: Wednesday, December 16, 2020 1:13 AM
> On Tue, Dec 15, 2020 at 5:02 PM Geert Uytterhoeven
> wrote:
> > On Fri, Dec 11, 2020 at 3:03 PM Vaittinen, Matti
> > wrote:
> > > On Fri, 2020-12-11 at 20:27
Hi Matti-san,
> From: Vaittinen, Matti, Sent: Wednesday, December 16, 2020 3:00 PM
> On Wed, 2020-12-16 at 02:13 +, Yoshihiro Shimoda wrote:
> > Hi Geert-san, Matti-san,
> >
> > > From: Geert Uytterhoeven, Sent: Wednesday, December 16, 2020 1:13
> > > AM
&
soc/list/?series=398059
Khiem Nguyen (2):
mfd: bd9571mwv: Make the driver more generic
mfd: bd9571mwv: Add support for BD9574MWF
Yoshihiro Shimoda (10):
mfd: bd9571mwv: Use devm_mfd_add_devices()
dt-bindings: mfd: bd9571mwv: Document BD9574MWF
mfd: rohm-generic: Add BD9571 and BD95
Add chip IDs for BD9571MWV and BD9574MWF.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
include/linux/mfd/rohm-generic.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h
index 4283b5b..affacf8 100644
To remove mfd devices when unload this driver, should use
devm_mfd_add_devices() instead.
Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver")
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/gpio/gpio-bd9571mwv.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio
Add support for BD9574MWF which is silimar chip with BD9571MWV.
Note that we don't support voltage rails VD{09,18,25,33} by this
driver on BD9574. The VD09 voltage could be read from PMIC but that
is not supported by this commit.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
From: Khiem Nguyen
Since the driver supports BD9571MWV PMIC only,
this patch makes the functions and data structure become more generic
so that it can support other PMIC variants as well.
Signed-off-by: Khiem Nguyen
[shimoda: rebase and refactor]
Signed-off-by: Yoshihiro Shimoda
---
drivers
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/gpio/gpio-bd9571mwv.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio
Use the SPDX license identifier instead of a local description.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Geert Uytterhoeven
---
drivers/mfd/bd9571mwv.c | 10 +-
include/linux/mfd/bd9571mwv.h | 10 +-
2 files changed, 2 insertions(+), 18 deletions(-)
diff --git
Use dev_regmap_add_irq_chip() to simplify the code.
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c
index e68c3fa..49e968e 100644
To simplify this driver, use dev_get_regmap() and
rid of using struct bd9571mwv.
Signed-off-by: Yoshihiro Shimoda
Reviewed-by: Matti Vaittinen
---
drivers/regulator/bd9571mwv-regulator.c | 49 +
1 file changed, 26 insertions(+), 23 deletions(-)
diff --git
From: Khiem Nguyen
The new PMIC BD9574MWF inherits features from BD9571MWV.
Add the support of new PMIC to existing bd9571mwv driver.
Signed-off-by: Khiem Nguyen
[shimoda: rebase and refactor]
Signed-off-by: Yoshihiro Shimoda
---
drivers/mfd/bd9571mwv.c | 86
301 - 400 of 633 matches
Mail list logo
