[PATCH v3 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF

2020-12-15 Thread Yoshihiro Shimoda
Document other similar specification chip BD9574MWF. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree

[PATCH v3 08/12] gpio: bd9571mwv: Add BD9574MWF support

2020-12-15 Thread Yoshihiro Shimoda
Add support for BD9574MWF which is silimar chip with BD9571MWV. Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen --- drivers/gpio/gpio-

RE: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

2020-12-17 Thread Yoshihiro Shimoda
Hi Lee, Thank you for your review! > From: Lee Jones, Sent: Thursday, December 17, 2020 12:35 AM > > On Wed, 16 Dec 2020, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > Since the driver supports BD9571MWV PMIC only, > > this patch makes the func

RE: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

2020-12-17 Thread Yoshihiro Shimoda
Hi Lee, Thank you for your review! > From: Lee Jones, Sent: Thursday, December 17, 2020 12:38 AM > > On Wed, 16 Dec 2020, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > The new PMIC BD9574MWF inherits features from BD9571MWV. > > Add the suppo

RE: [PATCH] PCI: pcie-rcar-host: Drop unused members from struct rcar_pcie_host

2020-10-27 Thread Yoshihiro Shimoda
Hi Lad, > From: Lad Prabhakar, Sent: Saturday, October 24, 2020 1:20 AM > > Drop unused members dev and base from struct rcar_pcie_host. > > Signed-off-by: Lad Prabhakar Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > --- > d

RE: phy-rcar-gen3-usb2: wrong parsing of role in role_store?

2019-07-30 Thread Yoshihiro Shimoda
so data beyond count in buf are going to be accessed. Thank you for the report. I think the driver should use sysfs_streq() helper instead of strncmp() on the sysfs function. So, I'll submit such a patch later. Best regards, Yoshihiro Shimoda > Best regards, >

[PATCH] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

2019-07-31 Thread Yoshihiro Shimoda
r usb role swap") Cc: # v4.10+ Signed-off-by: Yoshihiro Shimoda --- Just a record. The role_store() doesn't need to check the count because the sysfs_streq() checks the first argument is NULL or not. On "if (sysfs_streq(buf, "host"))" Example 1: echo ho > role -->

RE: [PATCH] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

2019-07-31 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, July 31, 2019 6:27 PM > > Hi Shimoda-san, > > On Wed, Jul 31, 2019 at 11:04 AM Yoshihiro Shimoda > wrote: > > Since the role_store() uses strncmp(), it's possible to refer > > out-of-memory if the sysfs da

RE: [PATCH v2] dt-bindings: usb: renesas,usb-xhci: Document r8a774e1 support

2020-08-28 Thread Yoshihiro Shimoda
> Reviewed-by: Marian-Cristian Rotariu > > Acked-by: Rob Herring > Reviewed-by: Geert Uytterhoeven Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 1/2] dt-bindings: PCI: rcar: Add device tree support for r8a7742

2020-08-17 Thread Yoshihiro Shimoda
your patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 2/5] dt-bindings: pwm: renesas,pwm-rcar: Add r8a7742 support

2020-08-17 Thread Yoshihiro Shimoda
Hi Lad-san, > From: Lad Prabhakar, Sent: Friday, August 7, 2020 3:32 AM > > Document RZ/G1H (R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Thank you for your patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH v4 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic()

2020-09-23 Thread Yoshihiro Shimoda
Hi Chungeng, Thank you for the patch! > From: Chunfeng Yun, Sent: Monday, September 21, 2020 3:13 PM > > Use readl_poll_timeout_atomic() to simplify code > > Cc: Mathias Nyman > Cc: Yoshihiro Shimoda > Signed-off-by: Chunfeng Yun > --- > v4: changes > 1.

RE: [PATCH v2] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada 3720

2021-02-01 Thread Yoshihiro Shimoda
ak > Fixes: bd3d25b07342 ("arm64: dts: marvell: armada-37xx: link USB hosts with > their PHYs") > Cc: # 5.1+: ea17a0f153af: phy: marvell: comphy: > Convert internal SMCC firmware return codes to > errno > Cc: # 5.1+: f768e718911e: usb: host: xhci-plat: add > pri

RE: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-02-01 Thread Yoshihiro Shimoda
> From: Pali Rohár, Sent: Tuesday, February 2, 2021 12:12 AM > On Tuesday 26 January 2021 10:06:06 Pali Rohár wrote: > > On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote: > > > Hi Pali, > > > > > I can see the benefit in this. > >

RE: [PATCH 2/3] dt-bindings: iommu: renesas,ipmmu-vmsa: Make 'power-domains' conditionally required

2021-02-03 Thread Yoshihiro Shimoda
roperty > > Based on the dts files, a 'power-domains' property only exists on Gen 3 > which can be conditioned on !renesas,ipmmu-vmsa. > > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Yoshihiro Shimoda > Cc: io...@lists.linux-foundation.org > Signed-off-by: Rob

RE: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

2021-02-03 Thread Yoshihiro Shimoda
ffery > Cc: Joel Stanley > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: Yoshihiro Shimoda > Cc: Vincent Cheng > Cc: linux-...@vger.kernel.org > Cc: linux-cry...@vger.kernel.org > Cc: linux-g...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: io...@lists.l

RE: [PATCH v2] usb: host: xhci-plat: fix support for XHCI_SKIP_PHY_INIT quirk

2021-01-26 Thread Yoshihiro Shimoda
(hcd); > > >>> + if (ret) > > >>> + goto disable_usb_phy; > > >>> + } > > >>> + > > >>> + if ((xhci->quirks & XHCI_SKIP_PHY_INIT) || (priv && > > >&

RE: [PATCH] clk: renesas: cpg-mssr: Fix reset control race condition

2019-07-12 Thread Yoshihiro Shimoda
n able to reproduce the issue on R-Car Gen2 (after > forcing i2c reset on Gen2, too). Perhaps my Koelsch doesn't have enough > CPU cores. What about Lager? According to the test team, Lager also could not reproduce this issue. Should we investigate it why? Best regards, Yoshihiro Shimoda

RE: [PATCH 2/6] Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2"

2019-05-20 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for your reply! > From: Geert Uytterhoeven, Sent: Monday, May 20, 2019 4:38 PM > > Hi Shimoda-san, > > Thanks for your analysis! > > On Mon, May 20, 2019 at 4:18 AM Yoshihiro Shimoda > wrote: > > > From: Eugeniu Rosca, S

RE: [PATCH v2] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-10 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Friday, June 7, 2019 10:23 PM > > Hi Shimoda-san, > > Thanks for the update! > > On Fri, Jun 7, 2019 at 12:07 PM Yoshihiro Shimoda > wrote: > > The powered flag should be set for any other phys anyway. Also

[PATCH v3] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-10 Thread Yoshihiro Shimoda
en Fixes: 549b6b55b005 ("phy: renesas: rcar-gen3-usb2: enable/disable independent irqs") Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven --- Changes from v2: - Revise the commit log. - Add a comment on the mutex definition. - Add G

[PATCH] phy: renesas: rcar-gen3-usb2: Disable clearing VBUS in over-current

2019-08-06 Thread Yoshihiro Shimoda
en3-usb2: change the mode to OTG on the combined channel") Cc: # v4.5+ Signed-off-by: Yoshihiro Shimoda --- This patch might be difficult to backport to v4.9 or older because the v4.13 added vendor specific directories by commit 0b56e9a7e835 ("phy: Group vendor specific phy drivers

RE: [PATCH] pinctrl: sh-pfc: Do not use platform_get_irq() to count interrupts

2019-10-01 Thread Yoshihiro Shimoda
a fix for v5.4-rc1. Thank you for the patch! Reviewed-by: Yoshihiro Shimoda And, I tested this patch on R-Car H3. So, Tested-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq

2019-10-01 Thread Yoshihiro Shimoda
index 0 not found > > Fix this by calling platform_get_irq_optional() instead. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to > platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > --- > This is a fix for v5.4-rc1. > --- T

RE: [PATCH] mmc: renesas_sdhi: Do not use platform_get_irq() to count interrupts

2019-10-01 Thread Yoshihiro Shimoda
ed-off-by: Geert Uytterhoeven > --- > This is a fix for v5.4-rc1. > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda And, I tested this patch on R-Car H3. So, Tested-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] mmc: sh_mmcif: Use platform_get_irq_optional() for optional interrupt

2019-10-01 Thread Yoshihiro Shimoda
essage to > platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > --- > This is a fix for v5.4-rc1. > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda And, I tested this patch on R-Car H2. So, Tested-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory

2019-10-01 Thread Yoshihiro Shimoda
s is a fix for v5.4-rc1. > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda And, I tested this patch on R-Car H3. So, Tested-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] serial: sh-sci: Use platform_get_irq_optional() for optional interrupts

2019-10-01 Thread Yoshihiro Shimoda
ll but the > first interrupts, which are optional. > > Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to > platform_get_irq*()") > Signed-off-by: Geert Uytterhoeven > --- > This is a fix for v5.4-rc1. Thank you for the patch! Reviewed-by: Yo

RE: [PATCH] mmc: sh_mmcif: Use platform_get_irq_optional() for optional interrupt

2019-10-02 Thread Yoshihiro Shimoda
done. Starting network: ip: OVERRUN: Bad address ip: OVERRUN: Bad address ip: OVERRUN: Bad address Best regards, Yoshihiro Shimoda

RE: [PATCH] mmc: sh_mmcif: Use platform_get_irq_optional() for optional interrupt

2019-10-02 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, October 2, 2019 5:32 PM > > Hi Shimoda-san, Wolfram, > > On Wed, Oct 2, 2019 at 10:26 AM Yoshihiro Shimoda > wrote: > > > From: Wolfram Sang, Sent: Wednesday, October 2, 2019 5:16 PM > > > &g

[PATCH v2] phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

2019-10-07 Thread Yoshihiro Shimoda
r usb role swap") Cc: # v4.10+ Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Acked-by: Pavel Machek --- Changes from v1: - Rebase on v5.4-rc2. - Add Reviewed-by and Acked-by tags. https://patchwork.kernel.org/patch/11067371/ drivers/phy/renesas/phy-rcar-gen3-usb2

RE: [PATCH 02/10] dt-bindings: dmaengine: usb-dmac: Add binding for r8a774b1

2019-10-08 Thread Yoshihiro Shimoda
Hi Fabrizio-san, > From: Fabrizio Castro, Sent: Tuesday, October 8, 2019 7:39 PM > > This patch adds the binding for r8a774b1 SoC (RZ/G2N). > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 03/10] dt-bindings: usb: renesas_usbhs: Add r8a774b1 support

2019-10-08 Thread Yoshihiro Shimoda
Hi Fabrizio-san, > From: Fabrizio Castro, Sent: Tuesday, October 8, 2019 7:39 PM > > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 01/10] dt-bindings: rcar-gen3-phy-usb2: Add r8a774b1 support

2019-10-08 Thread Yoshihiro Shimoda
Hi Fabrizio-san, > From: Fabrizio Castro, Sent: Tuesday, October 8, 2019 7:39 PM > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Fabrizio Castro > --- Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 05/10] dt-bindings: usb-xhci: Add r8a774b1 support

2019-10-08 Thread Yoshihiro Shimoda
Hi Fabrizio-san, > From: Fabrizio Castro, Sent: Tuesday, October 8, 2019 7:39 PM > > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 06/10] dt-bindings: usb: renesas_usb3: Document r8a774b1 support

2019-10-08 Thread Yoshihiro Shimoda
Hi Fabrizio-san, > From: Fabrizio Castro, Sent: Tuesday, October 8, 2019 7:39 PM > > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 04/10] dt-bindings: rcar-gen3-phy-usb3: Add r8a774b1 support

2019-10-08 Thread Yoshihiro Shimoda
Hi Fabrizio-san, > From: Fabrizio Castro, Sent: Tuesday, October 8, 2019 7:39 PM > > Document RZ/G2N (R8A774B1) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH] usb: renesas_usbhs: fix __le16 warnings

2019-10-16 Thread Yoshihiro Shimoda
uce usbhs_read_le. > Likewise for write. I'm afraid but, I could not understand these comments. At the moment, the usbhs_{read,write}() call io{read,write}16(), not {read,write}l(). https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/renesas_usbhs

RE: [PATCH] MAINTAINERS: Add Marek and Shimoda-san as R-Car PCIE co-maintainers

2019-10-16 Thread Yoshihiro Shimoda
Horman Thank you very much for your support until now! Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

[PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

2019-10-18 Thread Yoshihiro Shimoda
Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation to json-schema. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 70 -- .../devicetree/bindings/phy/renesas,usb2-phy.yaml | 106 + 2 files changed

[PATCH] dt-bindings: phy: renesas: usb3-phy: convert bindings to json-schema

2019-10-18 Thread Yoshihiro Shimoda
Convert Renesas R-Car generation 3 USB 3.0 PHY bindings documentation to json-schema. Signed-off-by: Yoshihiro Shimoda --- .../devicetree/bindings/phy/rcar-gen3-phy-usb3.txt | 52 -- .../devicetree/bindings/phy/renesas,usb3-phy.yaml | 80 ++ 2 files changed, 80

RE: [PATCH] usb: renesas_usbhs: fix type of buf

2019-10-15 Thread Yoshihiro Shimoda
assignment (different base types) > drivers/usb/renesas_usbhs/mod_gadget.c:335:14:expected unsigned short > drivers/usb/renesas_usbhs/mod_gadget.c:335:14:got restricted __le16 > [usertype] > > Signed-off-by: Ben Dooks Thank you for the patch! Reviewed-by: Yoshihiro Sh

RE: [PATCH] usb: renesas_usbhs: fix __le16 warnings

2019-10-15 Thread Yoshihiro Shimoda
in > argument 3 (different base types) > drivers/usb/renesas_usbhs/common.c:175:39:expected unsigned short > [usertype] data > > Note. I belive this to be correct, and should be a no-op on arm. > > Signed-off-by: Ben Dooks Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH v2][next] PCI: rcar-gen2: Use fallthrough pseudo-keyword

2020-07-31 Thread Yoshihiro Shimoda
highlight=fallthrough#implicit-switch-case-fall-through > > Reviewed-by: Geert Uytterhoeven > Signed-off-by: Gustavo A. R. Silva Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-15 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 9:40 PM > > Hi Shimoda-san, > > On Tue, Jul 14, 2020 at 1:42 PM Yoshihiro Shimoda > wrote: > > > From: Geert Uytterhoeven, Sent: Tuesday, July 14, 2020 5:42 PM > > > On Tue, Jul

RE: [PATCH v2] phy: renesas: rcar-gen3-usb2: fix SError happen if DEBUG_SHIRQ is enabled

2020-07-17 Thread Yoshihiro Shimoda
Hello Vinod, > From: Vinod Koul, Sent: Friday, July 17, 2020 3:39 PM > > hello Yoshihiro, > > On 13-07-20, 21:11, Yoshihiro Shimoda wrote: > > Please consider revising patch subject. It tell me you are fixing an > error but it doesnt tell me what this patch is about :

RE: [PATCH v2] phy: renesas: rcar-gen3-usb2: fix SError happen if DEBUG_SHIRQ is enabled

2020-07-17 Thread Yoshihiro Shimoda
line :) > > > > Yes. We could be 80 over characters in a line now :) > > I'll fix it. > > > > > Should we continue on error here? > > > > Hmm, maybe it's better if the request_irq() failed because > > it can avoid unexpected behaviors. But, original code continued on error. > > In this case, should I make a separated incremental patch to exit on error? > > Yes that would be better :), Always, a patch per change Thank you for the reply. I got it :) Best regards, Yoshihiro Shimoda

[PATCH v3 2/2] phy: renesas: rcar-gen3-usb2: exit if request_irq() failed

2020-07-17 Thread Yoshihiro Shimoda
To avoid unexpected behaviors, it's better to exit if request_irq() failed. Suggested-by: Vinod Koul Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b

[PATCH v3 1/2] phy: renesas: rcar-gen3-usb2: move irq registration to init

2020-07-17 Thread Yoshihiro Shimoda
Reported-by: Wolfram Sang Reported-by: Geert Uytterhoeven Fixes: 9f391c574efc ("phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection") Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 61 +--- 1 file changed, 33 insertions(+

[PATCH v3 0/2] phy: renesas: rcar-gen3-usb2: fix an issue and minor update

2020-07-17 Thread Yoshihiro Shimoda
in patch 2. https://patchwork.kernel.org/patch/11659547/ Changes from v1: - Move the irq registration to rcar_gen3_phy_usb2_init() instead of add a condition into the irq handler. https://patchwork.kernel.org/patch/11654097/ Yoshihiro Shimoda (2): phy: renesas: rcar-gen3-usb2: move irq

[PATCH v2] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-05-27 Thread Yoshihiro Shimoda
This patch fixes memory leak at error paths of the probe function. In for_each_child_of_node, if the loop returns, the driver should call of_put_node() before returns. Reported-by: Julia Lawall Fixes: 1233f59f745 ("phy: Renesas R-Car Gen2 PHY driver") Signed-off-by: Yoshihiro Shimoda

RE: [PATCH] usb: gadget: udc: renesas_usb3: remove redundant assignment to ret

2019-06-26 Thread Yoshihiro Shimoda
is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: rcar_gen3_phy_usb2: unbalanced disables for USB20_VBUS0

2019-06-05 Thread Yoshihiro Shimoda
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, June 5, 2019 4:03 PM > > Hi Shimoda-san, > > On Wed, Jun 5, 2019 at 6:06 AM Yoshihiro Shimoda > wrote: > > > From: Geert Uytterhoeven, Sent: Wednesday, June 5, 2019 3:06 AM > > > Using a tree base

RE: [PATCH] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-05 Thread Yoshihiro Shimoda
h system resume phase, but never touching it > otherwise) is still present. Umm, since I'd like to investigate this, would you share your debug print patch? Best regards, Yoshihiro Shimoda

RE: [PATCH] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-07 Thread Yoshihiro Shimoda
lator. -- Other phy channels (phy-ee0[ac]0200.usb-phy) don't have their regulators. - phy-ee080200.usb-phy.{8,9,10,11} are phy devices. Best regards, Yoshihiro Shimoda

[PATCH v2] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-07 Thread Yoshihiro Shimoda
en Fixes: 549b6b55b005 ("phy: renesas: rcar-gen3-usb2: enable/disable independent irqs") Signed-off-by: Yoshihiro Shimoda --- Changes from v1: - Add mutex lock to avoid enabling the regulator imbalance during resume. - I got Geert-san's Tested-by, but I didn't add the tag because v1 stil

RE: rcar_gen3_phy_usb2: unbalanced disables for USB20_VBUS0

2019-06-04 Thread Yoshihiro Shimoda
think regulator_{en,dis}able() don't need such a condition though. I'll submit a bugfix patch with your Reported-by tag later. Best regards, Yoshihiro Shimoda

[PATCH] phy: renesas: rcar-gen3-usb2: fix imbalance powered flag

2019-06-04 Thread Yoshihiro Shimoda
]--- [ 56.273290] phy phy-ee080200.usb-phy.10: phy poweroff failed --> -5 Reported-by: Geert Uytterhoeven Fixes: 549b6b55b005 ("phy: renesas: rcar-gen3-usb2: enable/disable independent irqs") Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 8 +++

RE: [PATCH v8 1/5] usb: xhci: Change the XHCI link order in the Makefile

2020-05-11 Thread Yoshihiro Shimoda
y environment (r8a77951 and r8a77961) and then I didn't detect any regression. So, Tested-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda

RE: [PATCH v4 0/4] dt-bindings: phy: add r8a77961 support

2020-05-14 Thread Yoshihiro Shimoda
Hi Kishon, > From: Yoshihiro Shimoda, Sent: Friday, March 27, 2020 6:34 PM > > This patch adds USBPHY 2.0/3.0 devices support for r8a77961 > (R-Car M3-W+). Would you apply this patch series to your repository? Or, should I resend? JFYI: https://patchwork.kernel.org/project/linux

RE: [PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if regulators are disabled

2020-06-29 Thread Yoshihiro Shimoda
Hello! > From: Sergei Shtylyov, Sent: Saturday, June 27, 2020 12:54 AM > > Hello! > > On 06/26/2020 12:32 PM, Yoshihiro Shimoda wrote: > > > If regulator_is_enabled() of both vmmc and vqmmc returns false, > > _mmc_suspend() should call

RE: [PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume

2020-06-30 Thread Yoshihiro Shimoda
Hi Mark, > From: Mark Brown, Sent: Monday, June 29, 2020 9:58 PM > > On Mon, Jun 29, 2020 at 02:42:26AM +, Yoshihiro Shimoda wrote: > > > From: Mark Brown, Sent: Friday, June 26, 2020 11:39 PM > > Copying in Sudeep for the feedback on firmware interfac

RE: [PATCH] phy: renesas: rcar-gen3-usb2: fix SError happen if DEBUG_SHIRQ is enabled

2020-07-13 Thread Yoshihiro Shimoda
Hi Vinod, > From: Vinod Koul, Sent: Monday, July 13, 2020 2:17 PM > > Hi Yoshihiro, > > On 09-07-20, 19:36, Yoshihiro Shimoda wrote: > > If CONFIG_DEBUG_SHIRQ was enabled, r8a77951-salvator-xs could boot > > correctly. If we appended "earlycon keep_bootcon&quo

[PATCH v2] phy: renesas: rcar-gen3-usb2: fix SError happen if DEBUG_SHIRQ is enabled

2020-07-13 Thread Yoshihiro Shimoda
Reported-by: Wolfram Sang Reported-by: Geert Uytterhoeven Fixes: 9f391c574efc ("phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection") Signed-off-by: Yoshihiro Shimoda --- Changes from v1: - Move the irq registration to rcar_gen3_phy_usb2_init() instead of add a conditio

RE: [PATCH 2/9] iommu/ipmmu-vmsa: Hook up R8A774E1 DT matching code

2020-07-14 Thread Yoshihiro Shimoda
lso the recent patch to add > > "r8a77961" just adds to soc_rcar_gen3_whitelist. > > Oops, commit 17fe16181639801b ("iommu/renesas: Add support for r8a77961") > did it wrong, too. Thank you for the point it out. We should add r8a77961 to the soc_rcar_gen3[]. However, I don't know why I could not realize this issue... So, I investigated this a little and then, IIUC, glob_match() which soc_device_match() uses seems to return true, if *pat = "r8a7796" and *str = "r8a77961". Best regards, Yoshihiro Shimoda

[PATCH] phy: renesas: rcar-gen3-usb2: fix SError happen if DEBUG_SHIRQ is enabled

2020-07-09 Thread Yoshihiro Shimoda
backports this patch to v5.1 or less, we need to make other way. Reported-by: Wolfram Sang Reported-by: Geert Uytterhoeven Fixes: 9f391c574efc ("phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection") Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 6 ++

[PATCH/RFC v4 0/4] treewide: add regulator condition on _mmc_suspend()

2020-06-26 Thread Yoshihiro Shimoda
. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=305523 Changes from v1: - Use pm_suspend_via_firmware() API instead of pm_suspend_target_state. - Modify the psci driver to call pm_set_suspend_via_firmware. https://patchwork.kernel.org/patch/11557505/ Yoshihiro Shimoda (4

[PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume

2020-06-26 Thread Yoshihiro Shimoda
-nodes and properties [1], regulator_is_enabled() will return false while suspend() of a consumer. [1] - The node has regulator-state-(standby|mem|disk) sub-nodes. - The node doesn't have regulator-always-on. - The sub-node has regulator-off-in-suspend property. Signed-off-by: Yoshihiro Shimoda

[PATCH/RFC v4 1/4] regulator: core: add prepare and resume_early

2020-06-26 Thread Yoshihiro Shimoda
-in-suspend property. However, suitable regulator_ops APIs didn't exist. So, add new regulator_ops APIs and prepare()/resume_early() in the regulator_pm_ops to set/clear the condition by new APIs before suspend() functions of consumers are called. Signed-off-by: Yoshihiro Shimoda --- drivers

[PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if regulators are disabled

2020-06-26 Thread Yoshihiro Shimoda
-off-by: Yoshihiro Shimoda --- drivers/mmc/core/mmc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 4203303..75df5f8 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -12,6 +12,7

[PATCH/RFC v4 4/4] arm64: dts: renesas: add regulator-off-in-suspend property for eMMC

2020-06-26 Thread Yoshihiro Shimoda
before. before: - enter sleep mode and then turn the vmmc and vqmmc off. after: - call mmc_poweroff_nofity() and then turn the vmmc and vqmmc off. Signed-off-by: Yoshihiro Shimoda --- arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts | 10 -- arch/arm64/boot/dts/renesas/r8a77980

RE: [PATCH/RFC v4 1/4] regulator: core: add prepare and resume_early

2020-06-28 Thread Yoshihiro Shimoda
Hi Mark, > From: Mark Brown, Sent: Friday, June 26, 2020 11:30 PM > > On Fri, Jun 26, 2020 at 06:32:19PM +0900, Yoshihiro Shimoda wrote: > > > The regulator-fixed driver is possible to be off by firmware > > like PSCI while the system is suspended. If a consumer could

RE: [PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume

2020-06-28 Thread Yoshihiro Shimoda
Hi Mark, > From: Mark Brown, Sent: Friday, June 26, 2020 11:39 PM > > On Fri, Jun 26, 2020 at 06:32:20PM +0900, Yoshihiro Shimoda wrote: > > > +static int reg_is_enabled(struct regulator_dev *rdev) > > +{ > > + struct fixed_voltage_data *priv = rdev_get_drvda

RE: [PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if regulators are disabled

2020-06-28 Thread Yoshihiro Shimoda
Hi Mark, > From: Mark Brown, Sent: Saturday, June 27, 2020 12:14 AM > > On Fri, Jun 26, 2020 at 06:32:21PM +0900, Yoshihiro Shimoda wrote: > > Note that this is possible to happen when the regulator-fixed driver > > turns the vmmc and vqmmc off by firmware like

RE: [PATCH] [v2] PCI: rcar: Fix runtime PM imbalance on error

2020-06-07 Thread Yoshihiro Shimoda
> > Signed-off-by: Dinghao Liu Thank you for your patch! I think we can add Fixes tag like below. Fixes: 0df6150e7ceb ("PCI: rcar: Use runtime PM to control controller clock") And, I reviewed this patch. So, Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > ---

RE: linux-next: Signed-off-by missing for commit in the pinctrl tree

2018-07-09 Thread Yoshihiro Shimoda
ly rebasing and > adding the right SoB? I'm very sorry for this trouble. When I ported this patch, I dropped the author's Signed-of-by wrongly.. Signed-off-by: Takeshi Kihara Best regards, Yoshihiro Shimoda > Yours, > Linus Walleij > > On Mon, Jul 9, 2018 at 11:54 PM Steph

RE: [PATCH -next] usb: renesas_usbhs: Fix unused function warning when CONFIG_PM not set

2018-12-12 Thread Yoshihiro Shimoda
/git/gregkh/usb.git/commit/?h=usb-next=eaf3074e0a8c2a39c4c14aa8ef1c2ec09ace9c79 Best regards, Yoshihiro Shimoda

RE: [PATCH AUTOSEL 4.19 45/73] net: phy: micrel: add toggling phy reset if PHY is not attached

2018-12-12 Thread Yoshihiro Shimoda
Hi, > From: Sasha Levin , Sent: Thursday, December 13, 2018 1:28 > PM > > From: Yoshihiro Shimoda > > [ Upstream commit 8c85f4b81296a530b8af2796c110fa482ac42d4f ] Since this upstream commit are reverted by the following commit, we should not backpo

RE: [PATCH AUTOSEL 4.19 44/73] net: phy: Fix not to call phy_resume() if PHY is not attached

2018-12-12 Thread Yoshihiro Shimoda
Hi, > From: Sasha Levin, Sent: Thursday, December 13, 2018 1:28 PM > > From: Yoshihiro Shimoda > > [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ] This upstream commit is also reverted on mainline as I mentioned other email thread[1] [1] https://lore.

RE: [PATCH AUTOSEL 4.14 25/41] net: phy: Fix not to call phy_resume() if PHY is not attached

2018-12-12 Thread Yoshihiro Shimoda
Hi, > From: Sasha Levin, Sent: Thursday, December 13, 2018 1:31 PM > > From: Yoshihiro Shimoda > > [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ] This upstream commit is also reverted on mainline as I mentioned other email thread [1]. So, we should not backport

RE: [PATCH AUTOSEL 4.9 21/34] net: phy: Fix not to call phy_resume() if PHY is not attached

2018-12-12 Thread Yoshihiro Shimoda
Hi, > From: Sasha Levin, Sent: Thursday, December 13, 2018 1:32 PM > > From: Yoshihiro Shimoda > > [ Upstream commit ef1b5bf506b1f0ee3edc98533e1f3ecb105eb46a ] This upstream commit is reverted on mainline as I mentioned other email thread [1]. So, we should not backport

RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support

2018-12-13 Thread Yoshihiro Shimoda
Hi Fabrizio, > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM > > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda By the way, I'm not sure, but I'm wondering that we need to

RE: [PATCH] dt-bindings: rcar-gen3-phy-usb2: Add r8a774c0 support

2018-12-14 Thread Yoshihiro Shimoda
Hi Fabrizio, > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:21 AM > > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > --- > Documentatio

RE: [PATCH] usb: gadget: udc: renesas_usb3: Add bindings for r8a774c0

2018-12-14 Thread Yoshihiro Shimoda
Hi Fabrizio, > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:22 AM > > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > --- > Documentatio

RE: [PATCH] usb: gadget: udc: renesas_usb3: add support for r8a774c0

2018-12-14 Thread Yoshihiro Shimoda
Hi Fabrizio, > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:24 AM > > RZ/G2E USB 3.0 implementation is like the one found on R-Car E3, > therefore add the same quirk. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Reviewed-by: Yoshihiro Shim

RE: [PATCH] usb: renesas_usbhs: add support for RZ/G2E

2018-12-14 Thread Yoshihiro Shimoda
add > r8a774c0 support in a similar fashion to what was done for the > r8a77990. > > Signed-off-by: Fabrizio Castro Thank you for the patch! Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda > --- > drivers/usb/renesas_usbhs/common.c | 4 > 1 file chan

RE: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support

2018-12-14 Thread Yoshihiro Shimoda
Hello Fabrizio-san, > From: Fabrizio Castro, Sent: Friday, December 14, 2018 5:16 PM > > Hello Yoshihiro-san, > > Thank you for your feedback! > > > From: Yoshihiro Shimoda > > Sent: 14 December 2018 06:01 > > Subject: RE: [PATCH] dt-bindings: usb:

RE: [PATCH] usb: renesas_usbhs: mark PM functions as __maybe_unused

2018-12-11 Thread Yoshihiro Shimoda
Hi Arnd, Thank you for the patch! > From: Arnd Bergmann, Sent: Tuesday, December 11, 2018 7:06 PM > To: Greg Kroah-Hartman > Cc: Arnd Bergmann ; Yoshihiro Shimoda > ; Felipe Balbi > ; Simon Horman ; > Chris Brandt ; > linux-...@vger.kernel.org; linux-kernel@vger.kernel.

RE: [PATCH 2/6] Revert "arm64: dts: renesas: r8a7796: Enable DMA for SCIF2"

2019-05-19 Thread Yoshihiro Shimoda
ma_len = 0" transferring. and - also we have to fix the rcar-dmac driver to avoid this issue because the DMA Engine API guide doesn't prevent the len = 0. Eugeniu-san, Geert-san, what do you think? Best regards, Yoshihiro Shimoda >> > > Thanks! > > Likewise! >

[PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-26 Thread Yoshihiro Shimoda
This patch fixes memory leak at error paths of the probe function. In for_each_child_of_node, if the loop returns, the driver should call of_put_node() before returns. Reported-by: Julia Lawall Fixes: 1233f59f745 ("phy: Renesas R-Car Gen2 PHY driver") Signed-off-by: Yoshihi

RE: [PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-27 Thread Yoshihiro Shimoda
Hello, > From: Julia Lawall, Sent: Wednesday, February 27, 2019 5:25 PM > > On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote: > > > This patch fixes memory leak at error paths of the probe function. > > In for_each_child_of_node, if the loop returns, the driver should >

RE: [PATCH] USB: renesas_usbhs: fix spelling mistake "doens't" -> "doesn't"

2019-02-17 Thread Yoshihiro Shimoda
Hi, > From: Colin King, Sent: Monday, February 18, 2019 7:44 AM > > From: Colin Ian King > > There is a spelling mistake in a dev_err message. Fix it. > > Signed-off-by: Colin Ian King Thank you for the patch! Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shim

RE: [PATCH] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk

2019-02-26 Thread Yoshihiro Shimoda
ntrollers [1] also seem unclear why this quirk needs. So, Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda [1] --- commit da99706689481717998d1d48edd389f339eea979 Author: Daniel Thompson Date: Thu Dec 21 15:06:15 2017 +0200 usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720

RE: question about drivers/phy/renesas/phy-rcar-gen2.c

2019-02-26 Thread Yoshihiro Shimoda
'm sorry, but what is "dynamically allocated device nodes"? Best regards, Yoshihiro Shimoda > If so, it looks like the following code could cause a > use-after-free, due to not incrementing th reference count: > > for_each_child_of_node(dev->of_node, np) { > str

RE: question about drivers/phy/renesas/phy-rcar-gen2.c

2019-02-26 Thread Yoshihiro Shimoda
Hello, > From: Julia Lawall, Sent: Tuesday, February 26, 2019 6:01 PM > > On Tue, 26 Feb 2019, Yoshihiro Shimoda wrote: > > > Hello, > > (Sergei made this code, so I added his email as CC) > > > > I'm sorry for the delayed response. > > > > > F

Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

2014-09-03 Thread Yoshihiro Shimoda
&& HAS_DMA > help > Renesas USBHS is a discrete USB host and peripheral controller chip > that supports both full and high speed USB 2.0 data transfers. > Acked-by: Yoshihiro Shimoda Best regards, Yoshihiro Shimoda -- To unsubscribe from

Re: [PATCH v2] usb: renesas_usbhs: fix driver dependencies

2014-09-03 Thread Yoshihiro Shimoda
ARM SoCs and SuperH architecture. >>> >>> Signed-off-by: Bartlomiej Zolnierkiewicz >>> Acked-by: Kyungmin Park >>> Cc: Simon Horman >>> Cc: Magnus Damm >>> --- >>> v2: >>> - s/ARCH_SH/SUPERH/ (thanks to Sergei Shtylyov) >

[PATCH] phy: phy-rcar-gen2: Fix USBHS_UGSTS_LOCK value

2015-04-02 Thread Yoshihiro Shimoda
According to the technical update (No. TN-RCS-B011A/E), the UGSTS LOCK bit location is bit 8, not bits 1 and 0. It also says that the register address offset of UGSTS is 0x88, not 0x90. So, this patch fixes the USBHS_UGSTS_LOCK value and some comments. Signed-off-by: Yoshihiro Shimoda

[PATCH] phy: rcar-gen2: Add support for R-Car E2

2015-05-18 Thread Yoshihiro Shimoda
This patch adds a compatible string to support for R-Car E2. Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 1 + drivers/phy/phy-rcar-gen2.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Documentation/devicetree

RE: [PATCH] phy: rcar-gen3-usb2: Add R-Car Gen3 USB2 PHY driver

2015-08-24 Thread Yoshihiro Shimoda
Hi Geert-san, > Sent: Monday, August 24, 2015 9:13 PM > > Hi Shimoda-san, > > On Thu, Aug 20, 2015 at 8:28 AM, Yoshihiro Shimoda > wrote: > > This patch adds support for R-Car generation 3 USB2 PHY driver. > > This SoC has 3 EHCI/OHCI channels, and the channel

<    1   2   3   4   5   6   7   >