Re: [PATCH 09/26] IB/ocrdma: Improve another size determination in ocrdma_mq_cq_handler()

gt; u16 cq_id) > ocrdma_process_acqe(dev, cqe); > else if (cqe->valid_ae_cmpl_cons & OCRDMA_MCQE_CMPL_MASK) > ocrdma_process_mcqe(dev, cqe); > - memset(cqe, 0, sizeof(struct ocrdma_mcqe)); > + memset(cqe,

Re: [PATCH 07/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_get_ctrl_attribs()

+1331,7 @@ static int ocrdma_mbx_get_ctrl_attribs(struct > ocrdma_dev *dev) > struct ocrdma_get_ctrl_attribs_rsp *ctrl_attr_rsp; > struct mgmt_hba_attribs *hba_attribs; > > - mqe = kzalloc(sizeof(struct ocrdma_mqe), GFP_KERNEL); > + mqe = kzalloc(sizeof(*mqe

Re: [PATCH 07/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_get_ctrl_attribs()

dev *dev) > struct ocrdma_get_ctrl_attribs_rsp *ctrl_attr_rsp; > struct mgmt_hba_attribs *hba_attribs; > > - mqe = kzalloc(sizeof(struct ocrdma_mqe), GFP_KERNEL); > + mqe = kzalloc(sizeof(*mqe), GFP_KERNEL); > if (!mqe) > return status; >

Re: [PATCH 05/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_query_qp()

487,7 @@ int ocrdma_mbx_query_qp(struct ocrdma_dev *dev, struct > ocrdma_qp *qp, > if (status) > goto mbx_err; > rsp = (struct ocrdma_query_qp_rsp *)cmd; > - memcpy(param, >params, sizeof(struct ocrdma_qp_params)); > + memcpy(param, >param

Re: [PATCH 05/26] IB/ocrdma: Improve another size determination in ocrdma_mbx_query_qp()

gt; ocrdma_qp *qp, > if (status) > goto mbx_err; > rsp = (struct ocrdma_query_qp_rsp *)cmd; > - memcpy(param, >params, sizeof(struct ocrdma_qp_params)); > + memcpy(param, >params, sizeof(*param)); > mbx_err: > kfree(cmd); > return

Re: [PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config()

a_dev > *dev, u32 ptype, > int status; > dma_addr_t pa; > struct ocrdma_mqe cmd; > - > - struct ocrdma_get_dcbx_cfg_req *req = NULL; > - struct ocrdma_get_dcbx_cfg_rsp *rsp = NULL; > + struct ocrdma_get_dcbx_cfg_req *req; > + struct ocrdma

Re: [PATCH 04/26] IB/ocrdma: Delete unnecessary variable initialisations in ocrdma_mbx_get_dcbx_config()

; > struct ocrdma_mqe cmd; > - > - struct ocrdma_get_dcbx_cfg_req *req = NULL; > - struct ocrdma_get_dcbx_cfg_rsp *rsp = NULL; > + struct ocrdma_get_dcbx_cfg_req *req; > + struct ocrdma_get_dcbx_cfg_rsp *rsp; Reviewed-by: Yuval Shaia > str

Re: [PATCH 02/26] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range()

On Wed, Mar 08, 2017 at 01:41:00PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 18:23:54 +0100 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. >

Re: [PATCH 02/26] IB/ocrdma: Use kcalloc() in ocrdma_mbx_alloc_pd_range()

On Wed, Mar 08, 2017 at 01:41:00PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 18:23:54 +0100 > > * Multiplications for the size determination of memory allocations > indicated that array data structures should be processed. > Thus reuse the corresponding

Re: [PATCH 03/26] IB/ocrdma: Improve size determinations in ocrdma_mbx_get_dcbx_config()

eof(struct ocrdma_get_dcbx_cfg_rsp)); > - memcpy(dcbxcfg, >cfg, sizeof(struct ocrdma_dcbx_cfg)); > - > + ocrdma_le32_to_cpu(rsp, sizeof(*rsp)); > + memcpy(dcbxcfg, >cfg, sizeof(*dcbxcfg)); > mbx_err: > dma_free_coherent(>dev, cmd.hdr.pyld_len, req, pa); >

Re: [PATCH 03/26] IB/ocrdma: Improve size determinations in ocrdma_mbx_get_dcbx_config()

t;cfg, sizeof(struct ocrdma_dcbx_cfg)); > - > + ocrdma_le32_to_cpu(rsp, sizeof(*rsp)); > + memcpy(dcbxcfg, >cfg, sizeof(*dcbxcfg)); > mbx_err: > dma_free_coherent(>dev, cmd.hdr.pyld_len, req, pa); > mem_err: Reviewed-by: Yuval Shaia > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 16/26] IB/IPoIB: Inline ib_dma_map_*() functions

_TO_DEVICE); > > return -EIO; > } > @@ -320,8 +322,8 @@ void ipoib_dma_unmap_tx(struct ipoib_dev_priv *priv, > int off; > > if (skb_headlen(skb)) { > - ib_dma_unmap_single(priv->ca, mapping[0], skb_headlen(skb), > -

Re: [PATCH v2 16/26] IB/IPoIB: Inline ib_dma_map_*() functions

ma_unmap_tx(struct ipoib_dev_priv *priv, > int off; > > if (skb_headlen(skb)) { > - ib_dma_unmap_single(priv->ca, mapping[0], skb_headlen(skb), > - DMA_TO_DEVICE); > + dma_unmap_single(priv->ca->dma_d

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

W compiled also on SPARC Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> > > Signed-off-by: Zhouyi Zhou <zhouzho...@gmail.com> > --- > drivers/infiniband/hw/nes/nes_nic.c | 5 +++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +- > driv

Re: [PATCH] net: return value of skb_linearize should be handled in Linux kernel

W compiled also on SPARC Reviewed-by: Yuval Shaia > > Signed-off-by: Zhouyi Zhou > --- > drivers/infiniband/hw/nes/nes_nic.c | 5 +++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-- > drivers/scsi/

Re: [PATCH] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible

One minor comment inline. Besides that: Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com> On Sun, Aug 28, 2016 at 12:00:18AM +0800, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: s/biuld/build > drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previo

Re: [PATCH] fix:infiniband:hw:cxgb4:qp:mark symbols static where possible

One minor comment inline. Besides that: Reviewed-by: Yuval Shaia On Sun, Aug 28, 2016 at 12:00:18AM +0800, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: s/biuld/build > drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype for > '_free_qp' [

Re: [PATCH v3 18/22] IB/fmr_pool: Convert the cleanup thread into kthread worker API

On Wed, Nov 18, 2015 at 02:25:23PM +0100, Petr Mladek wrote: > Kthreads are currently implemented as an infinite loop. Each > has its own variant of checks for terminating, freezing, > awakening. In many cases it is unclear to say in which state > it is and sometimes it is done a wrong way. > >

Re: [PATCH v3 18/22] IB/fmr_pool: Convert the cleanup thread into kthread worker API

On Wed, Nov 18, 2015 at 02:25:23PM +0100, Petr Mladek wrote: > Kthreads are currently implemented as an infinite loop. Each > has its own variant of checks for terminating, freezing, > awakening. In many cases it is unclear to say in which state > it is and sometimes it is done a wrong way. > >

<    1   2