Re: [PATCH v2 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling

2019-10-23 Thread asutoshd
On 2019-10-23 09:39, Asutosh Das wrote: Qualcomm controller needs to be in hibern8 before scaling clocks. This change puts the controller in hibern8 state before scaling and brings it out after scaling of clocks. Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufs-qcom.c | 4 1 file chang

Re: [PATCH v3 2/5] scsi: ufs: clear UAC for FFU and RPMB LUNs

2020-10-26 Thread asutoshd
On 2020-10-24 08:06, Jaegeuk Kim wrote: From: Jaegeuk Kim In order to conduct FFU or RPMB operations, UFS needs to clear UAC. This patch clears it explicitly, so that we could get no failure given early execution. What's the meaning of 'given early execution'? Signed-off-by: Jaegeuk Kim

Re: [PATCH v3 3/5] scsi: ufs: use WQ_HIGHPRI for gating work

2020-10-26 Thread asutoshd
On 2020-10-24 08:06, Jaegeuk Kim wrote: From: Jaegeuk Kim Must have WQ_MEM_RECLAIM ``WQ_MEM_RECLAIM`` All wq which might be used in the memory reclaim paths **MUST** have this flag set. The wq is guaranteed to have at least one execution context regardless of memory pressure. Signed-off

Re: [PATCH v3 5/5] scsi: ufs: fix clkgating on/off correctly

2020-10-26 Thread asutoshd
On 2020-10-24 08:06, Jaegeuk Kim wrote: The below call stack prevents clk_gating at every IO completion. We can remove the condition, ufshcd_any_tag_in_use(), since clkgating_work will check it again. ufshcd_complete_requests(struct ufs_hba *hba) ufshcd_transfer_req_compl() __ufshcd_tran

Re: [PATCH v2 5/5] scsi: ufs: fix clkgating on/off correctly

2020-10-26 Thread asutoshd
On 2020-10-22 17:53, Jaegeuk Kim wrote: On 10/21, Can Guo wrote: On 2020-10-21 12:52, jaeg...@kernel.org wrote: > On 10/21, Can Guo wrote: > > On 2020-10-21 03:52, Jaegeuk Kim wrote: > > > The below call stack prevents clk_gating at every IO completion. > > > We can remove the condition, ufshcd_