Re: [PATCH] inotify: add error handling for kmem_cache_create

2018-06-12 Thread cgxu...@gmx.com
> 在 2018年6月12日,下午12:22,Zhouyang Jia 写道: > > When kmem_cache_create fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling kmem_cache_create. I think SLAB_PANIC can handle this case. Thanks, Chengguang. > > Signed-off-by:

Re: [RESEND PATCH] x86: remove redundant check for kmem_cache_create()

2018-06-12 Thread cgxu...@gmx.com
So still need to keep return type as int, I’ll fix in V2. Thanks. > 在 2018年6月12日,下午7:27,kbuild test robot 写道: > > Hi Chengguang, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on tip/x86/core] > [also build test WARNING on v4.17 next-20180612] > [if y

Re: [V9fs-developer] [PATCH v2 1/2] net/9p: detecting invalid options as much as possible

2018-05-02 Thread cgxu...@gmx.com
Thanks for your review, I’ll fix the issue in v3. > 在 2018年5月3日,上午6:32,Andrew Morton 写道: > > On Tue, 17 Apr 2018 14:45:01 +0800 Chengguang Xu wrote: > >> Currently when detecting invalid options in option parsing, >> some options(e.g. msize) just set errno and allow to continuously >> validat

Re: [PATCH 1/2] hfs: fix potential refcnt problem of nls module

2018-04-18 Thread cgxu...@gmx.com
在 2018年4月19日,上午3:42,Andrew Morton 写道: > > On Tue, 17 Apr 2018 15:05:32 +0800 Chengguang Xu wrote: > >> When specifying iocharset/codepage multiple times in a mount, >> current option parsing will cause inaccurate refcount of nls >> module. Hence, call unload_nls for previous one in this case. >