[Patch 1/2] drivers/char/vt.c: remove unnecessary code

In the palette escape sequence, setting the elems of par[] at 0 is not needed, since its values are every time overwritten in this case. Signed-off-by: Emmanuel Colbus <[EMAIL PROTECTED]> --- old/drivers/char/vt.c 2004-12-24 22:35:25.0 +0100 +++ new/drivers/char/vt.c 2005-02-

[patch 3/2] drivers/char/vt.c: remove unnecessary code

We could change an affectation into an incrementation by this patch, and, so far I know, incrementing is quicker than or as quick as setting a variable (depends on the architecture). Please _don't_ apply this, but tell me what you think about it. Note that npar is unsigned. Signed-off-by: Emman

[patch 2/2] drivers/chat/vt.c: remove unnecessary code

Avoid changing the state of the console two times in some cases. Signed-off-by: Emmanuel Colbus <[EMAIL PROTECTED]> --- old/drivers/char/vt.c 2004-12-24 22:35:25.0 +0100 +++ new/drivers/char/vt.c 2005-02-28 12:56:46.154311486 +0100 @@ -1571,7 +1571,6 @@ } sw

Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

>On Mon, Feb 28, 2005 at 01:57:59PM +0100, [EMAIL PROTECTED] wrote: >> Please _don't_ apply this, but tell me what you think about it. >It's broken. 8) >> --- old/drivers/char/vt.c 2004-12-24 22:35:25.0 +0100 >> +++ new/drivers/char/vt.c 2005-02-28 12:53:57.933256631 +0100 >> @@ -1655,9

Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

Surlignage Russell King <[EMAIL PROTECTED]>: > On Mon, Feb 28, 2005 at 02:13:57PM +0100, [EMAIL PROTECTED] wrote: > > NPAR times :-). As I stated, npar is unsigned. > > I think that's disgusting then - it isn't obvious what's going on, which > leads to mistakes. > > For the sake of a micro-optim

Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

>> - for(npar = 0 ; npar < NPAR ; npar++) >> + for(npar = NPAR - 1; npar >= 0; npar--) >> par[npar] = 0; >if you really want to clean this up.. Well, actually, I was not myself entirely convinced about it... This is the reason for I wrote "please _don't_ apply this, but tell me what you think

Re: [patch 2/2] drivers/chat/vt.c: remove unnecessary code

>On Mon, Feb 28, 2005 at 01:55:28PM +0100, [EMAIL PROTECTED] wrote: > >> Avoid changing the state of the console two times in some cases. > >A bad change for several reasons. > >(i) more object code is generated >(ii) the code is slower >(iii) you change something > >Straight line code is cheap,

[2.4]drivers/char/console.c: check if caller is proprietary of the current console

This patch adds a verification that the calling process is writing to the current console, in the DEC alignment screen test. (The bug can be observed by typing : $chvt 2 && sleep 1 && echo -e "\033#8" in vt1.) Signed-off-by: Emmanuel Colbus <[EMAIL PROTECTED]> --- This patch was already

[2.2]drivers/char/console.c: check if caller is proprietary of the current console

This patch adds a verification that the calling process is writing to the current console, in the DEC alignment screen test. Signed-off-by: Emmanuel Colbus <[EMAIL PROTECTED]> --- This patch was already sent on: - 04 Jan 2005 --- old/drivers/char/console.c Mon Sep 16 18:26:11 2002 +++ patche