Re: [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types

2012-08-13 Thread Fengguang Wu
68k. > > Signed-off-by: Greg Ungerer Signed-off-by: Fengguang Wu Thanks for the complete solution! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: Architectures missing atomic64_t

2012-08-14 Thread Fengguang Wu
On Mon, Aug 13, 2012 at 12:08:47PM -0700, Eric W. Biederman wrote: > Fengguang Wu writes: > > > On Tue, Aug 14, 2012 at 01:55:16AM +0800, Fengguang Wu wrote: > >> > >I'd suggest to fix it in m68k and make atomic64_t generally available. > >> &

[PATCH] mn10300: select generic atomic64_t support

2012-08-14 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- arch/mn10300/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux.orig/arch/mn10300/Kconfig 2012-08-03 15:36:21.391560778 +0800 +++ linux/arch/mn10300/Kconfig 2012-08-14 22:53:14.751795832 +0800 @@ -8,6 +8,7 @@ config MN10300 select HAVE

[PATCH] h8300: select generic atomic64_t support

2012-08-14 Thread Fengguang Wu
Rationals from Eric: So I just looked a little deeper and it appears architectures that do not support atomic64_t are broken. The generic atomic64 support came in 2009 to support the perf subsystem with the expectation that all architectures would implement atomic64 support. Furthermore upon ins

[PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-14 Thread Fengguang Wu
Sorry I have no compilers for build testing these changes, however the risk looks low and it's much better than to leave the arch broken, considering that Eric will do atomic64_t in the core fs/namespace.c code. CC: "Eric W. Biederman" Signed-off-by: Fengguang Wu --- A

Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-14 Thread Fengguang Wu
On Tue, Aug 14, 2012 at 12:22:49PM -0400, Mark Salter wrote: > On Tue, 2012-08-14 at 23:34 +0800, Fengguang Wu wrote: > > Sorry I have no compilers for build testing these changes, however the > > risk looks low and it's much better than to leave the arch broken, > > con

Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-14 Thread Fengguang Wu
> -#define L1_CACHE_BYTESL2_CACHE_BYTES > +#define L1_CACHE_SHIFTL2_CACHE_SHIFT > +#define L1_CACHE_BYTES(1 << L2_CACHE_SHIFT) Nitpick: the last line could better be: +#define L1_CACHE_BYTES(1 << L1_CACHE_SHIFT) Reviewed-by: Fenggua

Re: yama_ptrace_access_check(): possible recursive locking detected

2012-08-14 Thread Fengguang Wu
On Tue, Aug 14, 2012 at 02:16:52PM -0700, Kees Cook wrote: > On Thu, Aug 9, 2012 at 6:52 PM, Fengguang Wu wrote: > > On Thu, Aug 09, 2012 at 06:39:34PM -0700, Kees Cook wrote: > >> Hi, > >> > >> So, after taking a closer look at this, I cannot understand how

Re: [PATCH] select GENERIC_ATOMIC64 for c6x/score/unicore32 archs

2012-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2012 at 09:42:58AM -0400, Mark Salter wrote: > On Wed, 2012-08-15 at 10:36 +0800, Fengguang Wu wrote: > > > -#define L1_CACHE_BYTESL2_CACHE_BYTES > > > +#define L1_CACHE_SHIFTL2_CACHE_SHIFT > > > +#define L1_CACHE_BYTES(1 <&

Re: NULL pointer dereference in ext4_ext_remove_space on 3.5.1

2012-08-16 Thread Fengguang Wu
> --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -2432,6 +2432,10 @@ ext4_ext_rm_leaf(handle_t *handle, struct inode *inode, > > /* the header must be checked already in ext4_ext_remove_space() */ > ext_debug("truncate since %u in leaf to %u\n", start, end); > + if (!path[

Re: suspicious RCU usage in xfrm_net_init()

2012-08-16 Thread Fengguang Wu
et->xfrm.xfrm4_dst_ops = *afinfo->dst_ops; > #if IS_ENABLED(CONFIG_IPV6) > -- > 1.7.1 > > > > > On 2012年08月16日 15:37, Fengguang Wu wrote: > >Hi Priyanka, > > > >The below warning shows up, probably related to this commit: &

[PATCH] avr32: fix build error in ATSTK1002 code

2012-07-21 Thread Fengguang Wu
arch/avr32/boards/atstk1000/atstk1002.c:100: error: 'num_partitions' undeclared here (not in a function) which is introduced by commit 1754aab9bb86 ("mtd: ATMEL, AVR32: inline nand partition table access "). Signed-off-by: Fengguang Wu --- arch/avr32/boards/atstk1000/atst

[vhost:vhost-net-next 82/99] arch/arm/include/asm/timex.h:15:24: fatal error: mach/timex.h: No such file or directory

2012-07-21 Thread Fengguang Wu
Hi Russell, I get this build failure on config arm-spear13xx_defconfig (attached as .config): arch/arm/include/asm/timex.h:15:24: fatal error: mach/timex.h: No such file or directory Thanks, Fengguang # # Automatically generated file; DO NOT EDIT. # Linux/arm 3.5.0-rc7 Kernel Configuration # CO

mach-at91: undefined reference to `at91sam926x_timer'

2012-07-21 Thread Fengguang Wu
Hi Andrew, I get this build failure on config arm-at91_dt_defconfig (attached as .config): arch/arm/mach-at91/built-in.o:(.arch.info.init+0x34): undefined reference to `at91sam926x_timer' Thanks, Fengguang # # Automatically generated file; DO NOT EDIT. # Linux/arm 3.5.0-rc7 Kernel Configuration

arm-allnoconfig error: '__LINUX_ARM_ARCH__' undeclared

2012-07-21 Thread Fengguang Wu
Hi Russell, Kernel build failed on arm-allnoconfig: include/linux/math64.h:55:15: error: '__LINUX_ARM_ARCH__' undeclared (first use in this function) arch/arm/include/asm/glue-cache.h:129:2: error: #error Unknown cache maintenance model arch/arm/include/asm/glue-df.h:99:2: error: #error Unknown

[next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-22 Thread Fengguang Wu
ckend Open Source Technology Centre Fengguang Wu Intel Corporation # # Automatically generated file; DO NOT EDIT. # Linux/parisc 3.5.0 Kernel Configuration # CONFIG_PARISC=y CONFIG_MMU=y CONFIG_STACK_GROWSUP=y CONFIG_RWSEM_GENERIC_SPINLOCK=y # CONFIG_ARCH_HAS_IL

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-23 Thread Fengguang Wu
On Mon, Jul 23, 2012 at 12:42:58PM +0100, Mel Gorman wrote: > On Mon, Jul 23, 2012 at 12:20:20PM +0100, James Bottomley wrote: > > [Parisc list cc added] > > On Mon, 2012-07-23 at 12:16 +0100, Mel Gorman wrote: > > > On Mon, Jul 23, 2012 at 12:30:58AM +0800, Fengguang

Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

2012-07-24 Thread Fengguang Wu
> It would be easier to see what's happening with preprocessed source. Here is the line in sock.i: struct static_key memalloc_socks = ((struct static_key) { .enabled = ((atomic_t) { (0) }) }); Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [QUERY]: Understanding the calculations in mm/page-writeback.c

2012-07-24 Thread Fengguang Wu
Hi Rajman, On Sun, Jul 22, 2012 at 09:18:57PM +0530, rajman mekaco wrote: > Hi, > > I am trying to understand the calculations in mm/page-writeback.c but > I am falling short of theoretical knowledge. > > What online (or otherwise) reading material can be used to fully > understand the maths for

Testing tracer wakeup_rt: .. no entries found ..FAILED!

2012-07-24 Thread Fengguang Wu
On Tue, Jul 24, 2012 at 05:03:30PM +0800, Fengguang Wu wrote: > Hi Steven, > > This looks like some old bug, so I directly report to you w/o trying > to bisect it. It only happens on the attached i386 randconfig and > happens in about half of the kvm boots. > > [1.3

[PATCH] fix nouveau build error on !CONFIG_MXM_WMI

2012-07-25 Thread Fengguang Wu
Fix build error on IA64: ERROR: "mxm_wmi_supported" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! Signed-off-by: Fengguang Wu --- include/linux/mxm-wmi.h |8 1 file changed, 8 insertions(+) diff --git a/include/linux/mxm-wmi.h b/include/linux/mxm-wmi.h index 617a29

[PATCH] ia64: mark PARAVIRT and KVM as broken

2012-07-25 Thread Fengguang Wu
Well, this at least makes allmodconfig happy. Proposed-by: David Howells Signed-off-by: Fengguang Wu --- arch/ia64/Kconfig |3 +-- arch/ia64/kvm/Kconfig |1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 8186ec5..310cf57

[PATCH] nouveau: fix build error on IA64

2012-07-25 Thread Fengguang Wu
I'm not sure if this is the best way, however it does fix the last 2 allmodconfig errors on IA64: ERROR: "wmi_has_guid" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! ERROR: "wmi_evaluate_method" [drivers/gpu/drm/nouveau/nouveau.ko] undefined! Signed-off-by: Fengguang

[PATCH] ia64: rename platform_name to ia64_platform_name

2012-07-25 Thread Fengguang Wu
The macro name is too generic and conflicts with snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors. Signed-off-by: Fengguang Wu --- (not sure if the previous sent was successful, so resend) arch/ia64/include/asm/machvec.h |2 +- arch/ia64/include/asm

Re: [PATCH] avr32: fix build error in ATSTK1002 code

2012-07-25 Thread Fengguang Wu
Andrew, will you accept this fix? It's obviously caused by a typo in commit 1754aab9bb86. On Sun, Jul 22, 2012 at 10:25:41AM +0800, Fengguang Wu wrote: > arch/avr32/boards/atstk1000/atstk1002.c:100: error: 'num_partitions' > undeclared here (not in a function) > > wh

[PATCH] Coccinelle: fix typo in memdup_user.cocci

2012-07-25 Thread Fengguang Wu
Signed-off-by: Fengguang Wu --- scripts/coccinelle/api/memdup_user.cocci |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/coccinelle/api/memdup_user.cocci b/scripts/coccinelle/api/memdup_user.cocci index 2efac28..2b131a8 100644 --- a/scripts/coccinelle/api

coccinelle hung on mini_lock.cocci

2012-07-25 Thread Fengguang Wu
Hi all, This command seem to hang for ever on the current linus/master. It happens only on mini_lock.cocci _and_ mm/shmem.c I've updated coccinelle to its git release, however it didn't help.. % spatch -debug -D report -I /c/kernel-tests/src/linux/include -sp_file /c/kernel-tests/src/linux/scri

bcma_bus_scan/bcma_bus_scan_early: missing iounmap

2012-07-25 Thread Fengguang Wu
Hi Hauke, The coccinelle static checker emits these warnings: drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465 drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539 It

[PATCH] ia64: rename platform_* to ia64_platform_*

2012-07-25 Thread Fengguang Wu
On Wed, Jul 25, 2012 at 01:18:39AM -0700, Joe Perches wrote: > On Wed, 2012-07-25 at 16:06 +0800, Fengguang Wu wrote: > > The macro name is too generic and conflicts with > > snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors. > > Is platform_name

Re: [Cocci] coccinelle hung on mini_lock.cocci

2012-07-25 Thread Fengguang Wu
re > are a lot of ifs in between. It seems possible that there is too much > information, and it gets too slow. I will look further. Ah OK, yeah this coccinelle case is a bit complex. Thanks, Fengguang > On Wed, 25 Jul 2012, Fengguang Wu wrote: > > > Hi all, > > > &g

Re: [PATCH] nouveau: fix build error on IA64

2012-07-25 Thread Fengguang Wu
> - select ACPI_WMI if ACPI > + select ACPI_WMI if ACPI && !IA64 > select MXM_WMI if ACPI Sorry, the MXM_WMI line should also be changed. Although MXM_WMI depends on ACPI_WMI, "select" is dumb and will ignore that dependency.. Thanks, Fengguang --- From:

Re: [Cocci] coccinelle hung on mini_lock.cocci

2012-07-25 Thread Fengguang Wu
On Wed, Jul 25, 2012 at 04:43:04PM +0200, Julia Lawall wrote: > On Wed, 25 Jul 2012, Fengguang Wu wrote: > > > Hi Julia, > > > > On Wed, Jul 25, 2012 at 04:15:19PM +0200, Julia Lawall wrote: > > > Do you use a timeout when you run Coccinelle You could put

Re: [Cocci] coccinelle hung on mini_lock.cocci

2012-07-25 Thread Fengguang Wu
On Wed, Jul 25, 2012 at 05:19:40PM +0200, Julia Lawall wrote: > I looked at it a bit more, and I think the timeout is the best solution. > The big jump backwards is under an if, and the pattern tries to match an > if up to a return, which tries to go across gotos. So I think it is just > a patholo

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-16 Thread Fengguang Wu
On Sun, Aug 05, 2012 at 09:58:26AM -0700, Greg KH wrote: > On Sun, Aug 05, 2012 at 10:59:38AM +0800, Fengguang Wu wrote: > > Hi all, > > > > This line triggers an oops in kvm boot test: > > > > usb_match_id(): > > ==> 748 for (; id->idVen

Re: show_uevent() and general protection fault

2012-08-16 Thread Fengguang Wu
On Thu, Aug 16, 2012 at 10:27:11AM -0700, Greg KH wrote: > On Wed, Jul 18, 2012 at 01:15:52PM +0800, Fengguang Wu wrote: > > On Mon, Jul 16, 2012 at 06:33:42PM -0700, Greg Kroah-Hartman wrote: > > > On Fri, Jul 13, 2012 at 04:46:16PM +0800, Fengguang Wu wrote: > > >

Re: show_uevent() and general protection fault

2012-08-16 Thread Fengguang Wu
> > --- tip.orig/drivers/base/core.c2012-08-17 08:48:07.101972082 +0800 > > +++ tip/drivers/base/core.c 2012-08-17 09:49:43.665912992 +0800 > > @@ -343,8 +343,11 @@ static ssize_t show_uevent(struct device > > goto out; > > > > /* copy keys to file */ > > -

Re: show_uevent() and general protection fault

2012-08-16 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 10:44:37AM +0800, Ming Lei wrote: > On Fri, Aug 17, 2012 at 10:29 AM, Fengguang Wu wrote: > > > > > Something obviously wrong here: > > > > env->buflen == 12 > > env->envp_idx == 1627389952 > > e

Re: NULL pointer dereference in ext4_ext_remove_space on 3.5.1

2012-08-16 Thread Fengguang Wu
On Thu, Aug 16, 2012 at 11:25:13AM -0400, Theodore Ts'o wrote: > On Thu, Aug 16, 2012 at 07:10:51PM +0800, Fengguang Wu wrote: > > > > Here is the dmesg. BTW, it seems 3.5.0 don't have this issue. > > Fengguang, > > It sounds like you have a (at least fai

ext4 write performance regression in 3.6-rc1

2012-08-16 Thread Fengguang Wu
Ted, I find ext4 write performance dropped by 3.3% on average in the 3.6-rc1 merge window. xfs and btrfs are fine. Two machines are tested. The performance regression happens in the lkp-nex04 machine, which is equipped with 12 SSD drives. lkp-st02 does not see regression, which is equipped with H

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Fengguang Wu
Hi Bjørn, > -static const struct usb_device_id id_table[] __devinitconst = { > +static const struct usb_device_id id_table[] = { Good catch! It magically fixed the oops. So that id_table was freed sometime with __devinitconst? There are some more "usb_device_id .* __devinitconst" users in the sy

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 05:27:08PM +0800, Fengguang Wu wrote: > Hi Bjørn, > > > -static const struct usb_device_id id_table[] __devinitconst = { > > +static const struct usb_device_id id_table[] = { > > Good catch! It magically fixed the oops. So that id_table w

Re: NULL pointer dereference in ext4_ext_remove_space on 3.5.1

2012-08-17 Thread Fengguang Wu
Hi Ted, On Fri, Aug 17, 2012 at 09:15:58AM -0400, Theodore Ts'o wrote: > Thanks Fengguang: > > For the record, I was able to find my own easy repro, last night using > only a 220 meg partition: > > # mke2fs -t ext4 -b 1024 -J size=1 /dev/vdc > # mount -t ext2 /dev/vdc /vdc > # mkdir /vdc/a > # c

Re: lockdep warning on rt_mutex_lock()

2012-08-17 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 06:43:28AM -0700, Paul E. McKenney wrote: > On Fri, Aug 17, 2012 at 06:06:35PM +0800, Fengguang Wu wrote: > > Greetings, > > > > FYI, a lockdep warning: > > Certainly looks problematic! > > Any hint as to what version of the kernel produc

Re: ext4 write performance regression in 3.6-rc1

2012-08-17 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote: > On Fri, Aug 17, 2012 at 02:09:15PM +0800, Fengguang Wu wrote: > > Ted, > > > > I find ext4 write performance dropped by 3.3% on average in the > > 3.6-rc1 merge window. xfs and btrfs are fine. >

Re: ext4 write performance regression in 3.6-rc1 on RAID0/5

2012-08-17 Thread Fengguang Wu
[CC md list] On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote: > On Fri, Aug 17, 2012 at 02:09:15PM +0800, Fengguang Wu wrote: > > Ted, > > > > I find ext4 write performance dropped by 3.3% on average in the > > 3.6-rc1 merge window. xfs and btrfs are

Re: lockdep warning on rt_mutex_lock()

2012-08-17 Thread Fengguang Wu
On Fri, Aug 17, 2012 at 07:44:37AM -0700, Paul E. McKenney wrote: > On Fri, Aug 17, 2012 at 10:02:40PM +0800, Fengguang Wu wrote: > > On Fri, Aug 17, 2012 at 06:43:28AM -0700, Paul E. McKenney wrote: > > > On Fri, Aug 17, 2012 at 06:06:35PM +0800, Fengguang Wu wrote:

Re: [PATCH 1/3] writeback: change nr_pages_dirtied argument into local variable

2012-08-18 Thread Fengguang Wu
On Sat, Aug 18, 2012 at 05:48:29AM -0400, Namjae Jeon wrote: > There is no reason nr_pages_dirtied is argument anymore. > because nr_pages_dirtied value from caller is not used in > balance_dirty_pages_ratelimited_nr function. Looks good to me. If the fs developers don't have problems with this, I

Re: [PATCH 2/3] writeback: fix incorrect return value type of bdi_dirty_limit

2012-08-18 Thread Fengguang Wu
On Sat, Aug 18, 2012 at 05:49:21AM -0400, Namjae Jeon wrote: > unsigned long bdi_dirty_limit(struct backing_dev_info *bdi, unsigned long > dirty) > > Above function return type is unsigned long, but return value is > kept in "u64 bdi_dirty". > It can return incorrect value by type casting. I don

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-18 Thread Fengguang Wu
On Sat, Aug 18, 2012 at 05:50:02AM -0400, Namjae Jeon wrote: > From: Namjae Jeon > > This patch is based on suggestion by Wu Fengguang: > https://lkml.org/lkml/2011/8/19/19 > > kernel has mechanism to do writeback as per dirty_ratio and dirty_background > ratio. It also maintains per task dirty

Re: IPv4 BUG: held lock freed!

2012-08-19 Thread Fengguang Wu
> Could you test following patch ? Yes, sure. Thanks for the quick fix! I should have reported it earlier (so as to get it fixed earlier) once find the bisect will be time consuming.. Please be patient -- it will take 1-2 days to confirm the bug fix. Thanks, Fengguang -- To unsubscribe from thi

Force enabled HPET at 0x%lx

2012-08-19 Thread Fengguang Wu
Hi, [ 38.650387] PCI host bridge to bus :00 [ 38.657920] pci_bus :00: Force enabled HPET at 0x%lx ~~~ That "0x%lx" message should be emitted by one of the dev_printks in arch/x86/kernel/quirks.c and I fail

Re: Force enabled HPET at 0x%lx

2012-08-19 Thread Fengguang Wu
On Sun, Aug 19, 2012 at 04:18:24PM +0200, Markus Trippelsdorf wrote: > On 2012.08.19 at 22:02 +0800, Fengguang Wu wrote: > > Hi, > > > > [ 38.650387] PCI host bridge to bus :00 > > [ 38.657920] pci_bus :00:

Re: BUG: scheduling while atomic, under native_smp_prepare_cpus()

2012-08-20 Thread Fengguang Wu
Hi Michael, On Mon, Aug 20, 2012 at 05:20:35PM +0800, Michael Wang wrote: > On 08/17/2012 09:49 PM, Fengguang Wu wrote: > > Hi, FengGuang > > native_smp_prepare_cpus has already disabled the preempt before > reach __irq_alloc_descs(), and sleep in mutex_lock() cause the bu

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-20 Thread Fengguang Wu
On Mon, Aug 20, 2012 at 09:48:42AM +0900, Namjae Jeon wrote: > 2012/8/19, Fengguang Wu : > > On Sat, Aug 18, 2012 at 05:50:02AM -0400, Namjae Jeon wrote: > >> From: Namjae Jeon > >> > >> This patch is based on suggestion by Wu Fengguang: > >> https:

Re: BUG: NULL pointer dereference in shmem_evict_inode()

2012-08-20 Thread Fengguang Wu
On Mon, Aug 20, 2012 at 06:10:57PM -0700, John Stultz wrote: > On 08/20/2012 06:04 PM, Fengguang Wu wrote: > >Hi John, > > > >The below oops happens in v3.5..v3.6-rc2 and it's bisected down to commit > >2a8c0883c ("time: Move xtime_nsec adjustment unde

Re: BUG: NULL pointer dereference in shmem_evict_inode()

2012-08-20 Thread Fengguang Wu
On Mon, Aug 20, 2012 at 06:15:00PM -0700, John Stultz wrote: > On 08/20/2012 06:10 PM, John Stultz wrote: > >On 08/20/2012 06:04 PM, Fengguang Wu wrote: > >>Hi John, > >> > >>The below oops happens in v3.5..v3.6-rc2 and it's bisected down > >&

Re: BUG: NULL pointer dereference in shmem_evict_inode()

2012-08-20 Thread Fengguang Wu
On Mon, Aug 20, 2012 at 06:46:05PM -0700, John Stultz wrote: > On 08/20/2012 06:31 PM, Fengguang Wu wrote: > >On Mon, Aug 20, 2012 at 06:10:57PM -0700, John Stultz wrote: > >>On 08/20/2012 06:04 PM, Fengguang Wu wrote: > >>>Hi John, > >>> > >>

Re: BUG: NULL pointer dereference in shmem_evict_inode()

2012-08-21 Thread Fengguang Wu
On Mon, Aug 20, 2012 at 06:49:52PM -0700, John Stultz wrote: > On 08/20/2012 06:40 PM, Fengguang Wu wrote: > >On Mon, Aug 20, 2012 at 06:15:00PM -0700, John Stultz wrote: > >>On 08/20/2012 06:10 PM, John Stultz wrote: > >>>On 08/20/2012 06:04 PM, Fengguang Wu wrote: &

Re: ext4 write performance regression in 3.6-rc1 on RAID0/5

2012-08-21 Thread Fengguang Wu
On Sat, Aug 18, 2012 at 06:44:57AM +1000, NeilBrown wrote: > On Fri, 17 Aug 2012 22:25:26 +0800 Fengguang Wu > wrote: > > > [CC md list] > > > > On Fri, Aug 17, 2012 at 09:40:39AM -0400, Theodore Ts'o wrote: > > > On Fri, Aug 17, 2012 at 02:09:15

[PATCH] score: select generic atomic64_t support

2012-08-21 Thread Fengguang Wu
It's required for the core fs/namespace.c and many other basic features. Acked-by: Lennox Wu Signed-off-by: Fengguang Wu --- arch/score/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux.orig/arch/score/Kconfig 2012-08-17 11:13:49.184134240 +0800 +++ linux/arch/score/Kc

[PATCH] unicore32: select generic atomic64_t support

2012-08-21 Thread Fengguang Wu
It's required for the core fs/namespace.c and many other basic features. CC: "Eric W. Biederman" Signed-off-by: Guan Xuetao Signed-off-by: Fengguang Wu --- arch/unicore32/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux.orig/arch/unicore32/Kconfig 2012-08-17 11:

Re: ext4 write performance regression in 3.6-rc1 on RAID0/5

2012-08-21 Thread Fengguang Wu
On Tue, Aug 21, 2012 at 05:42:21PM +0800, Fengguang Wu wrote: > On Sat, Aug 18, 2012 at 06:44:57AM +1000, NeilBrown wrote: > > On Fri, 17 Aug 2012 22:25:26 +0800 Fengguang Wu > > wrote: > > > > > [CC md list] > > > > > > On Fri, Aug 17, 2012 at 0

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-21 Thread Fengguang Wu
On Tue, Aug 21, 2012 at 02:48:35PM +0900, Namjae Jeon wrote: > 2012/8/21, J. Bruce Fields : > > On Mon, Aug 20, 2012 at 12:00:04PM +1000, Dave Chinner wrote: > >> On Sun, Aug 19, 2012 at 10:57:24AM +0800, Fengguang Wu wrote: > >> > On Sat, Aug 18, 2012 at 05:50

Re: [PATCH 3/3] writeback: add dirty_ratio_time per bdi variable (NFS write performance)

2012-08-21 Thread Fengguang Wu
On Tue, Aug 21, 2012 at 03:00:13PM +0900, Namjae Jeon wrote: > 2012/8/20, Fengguang Wu : > > On Mon, Aug 20, 2012 at 09:48:42AM +0900, Namjae Jeon wrote: > >> 2012/8/19, Fengguang Wu : > >> > On Sat, Aug 18, 2012 at 05:50:02AM -0400, Namjae Jeon wr

Re: BUG: scheduling while atomic, under native_smp_prepare_cpus()

2012-08-21 Thread Fengguang Wu
On Mon, Aug 20, 2012 at 05:42:22PM +0800, Michael Wang wrote: > On 08/20/2012 05:27 PM, Fengguang Wu wrote: > > Hi Michael, > > > > On Mon, Aug 20, 2012 at 05:20:35PM +0800, Michael Wang wrote: > >> On 08/17/2012 09:49 PM, Fengguang Wu

Re: [patch] mm, slub: ensure irqs are enabled for kmemcheck

2012-07-09 Thread Fengguang Wu
is fixes a warning for such allocations: > > > > WARNING: at kernel/lockdep.c:2739 lockdep_trace_alloc+0x14e/0x1c0() > > > > Cc: sta...@vger.kernel.org [3.1+] > > Acked-by: Fengguang Wu > > Tested-by: Fengguang Wu > > Signed-off-by: David Rientje

Re: rcu_dyntick and suspicious RCU usage

2012-07-09 Thread Fengguang Wu
Hi Paul, Fortunately this bug is bisectable and the first bad commit is: commit 9b2e4f1880b789be1f24f9684f7a54b90310b5c0 Author: Paul E. McKenney Date: Fri Sep 30 12:10:22 2011 -0700 rcu: Track idleness independent of idle tasks However, at that commit, th

Re: general protection fault on ttm_init()

2012-07-10 Thread Fengguang Wu
On Sat, Jul 07, 2012 at 11:31:42PM +0800, Fengguang Wu wrote: > On Sat, Jul 07, 2012 at 10:08:47AM +0800, Fengguang Wu wrote: > > On Fri, Jul 06, 2012 at 06:09:20PM +0100, Dave Airlie wrote: > > > On Fri, Jul 6, 2012 at 5:49 PM, Dave Airlie wrote: > > > > On Fri, Jul

Re: rcu_dyntick and suspicious RCU usage

2012-07-11 Thread Fengguang Wu
On Wed, Jul 11, 2012 at 12:49:24AM -0700, Paul E. McKenney wrote: > On Tue, Jul 10, 2012 at 12:47:00PM +0800, Fengguang Wu wrote: > > Hi Paul, > > > > Fortunately this bug is bisectable and the first bad commit is: > > > > commit 9b2e4f1

Re: rcu_dyntick and suspicious RCU usage

2012-07-11 Thread Fengguang Wu
On Wed, Jul 11, 2012 at 08:36:16PM +0800, Fengguang Wu wrote: > On Wed, Jul 11, 2012 at 12:49:24AM -0700, Paul E. McKenney wrote: > > On Tue, Jul 10, 2012 at 12:47:00PM +0800, Fengguang Wu wrote: > > > Hi Paul, > > > > > > Fortunately this bug is bi

Re: Kernel boot hangs on commit "switch fput to task_work_add"

2012-07-12 Thread Fengguang Wu
On Tue, Jul 10, 2012 at 10:18:30PM +0800, w...@linux.intel.com wrote: > Hi Al, > > The linux-next kernel reliably hung after this line: > > [4.846260] debug: unmapping init [mem > 0x88000182a000-0x8800019f] FYI, in another config (attached), it hangs after: [6.803484] debug

Re: rcu_dyntick and suspicious RCU usage

2012-07-12 Thread Fengguang Wu
On Wed, Jul 11, 2012 at 08:55:59PM +0800, Fengguang Wu wrote: > On Wed, Jul 11, 2012 at 08:36:16PM +0800, Fengguang Wu wrote: > > On Wed, Jul 11, 2012 at 12:49:24AM -0700, Paul E. McKenney wrote: > > > On Tue, Jul 10, 2012 at 12:47:00PM +0800, Fengguang Wu wrot

Re: rcu_dyntick and suspicious RCU usage

2012-07-12 Thread Fengguang Wu
On Thu, Jul 12, 2012 at 09:43:08AM -0700, Paul E. McKenney wrote: > On Wed, Jul 11, 2012 at 12:49:24AM -0700, Paul E. McKenney wrote: > > On Tue, Jul 10, 2012 at 12:47:00PM +0800, Fengguang Wu wrote: > > > Hi Paul, > > > > > > Fortunately this bug is bi

Re: rcu_dyntick and suspicious RCU usage

2012-07-13 Thread Fengguang Wu
On Thu, Jul 12, 2012 at 10:02:42AM -0700, Paul E. McKenney wrote: > On Fri, Jul 13, 2012 at 12:57:38AM +0800, Fengguang Wu wrote: > > On Thu, Jul 12, 2012 at 09:43:08AM -0700, Paul E. McKenney wrote: > > > On Wed, Jul 11, 2012 at 12:49:24AM -0700, Paul E. McKenney wrote: >

Re: [PATCH] ia64: rename cache_show to topology_cache_show

2013-02-16 Thread Fengguang Wu
On Sat, Feb 16, 2013 at 01:18:53PM +0100, Michal Hocko wrote: > On Fri 15-02-13 14:46:29, Andrew Morton wrote: > > On Fri, 15 Feb 2013 13:38:24 +0100 > > Michal Hocko wrote: > > > > > Fenguang Wu has reported the following compile time issue > > > arch/ia64/kernel/topology.c:278:16: error: confli

Re: [PATCH V2] smp: Give WARN()ing when calling smp_call_function_many()/single() in serving irq

2013-02-17 Thread Fengguang Wu
Chuansheng, It works fine on tip/next. Thanks for the fix! Tested-by: Fengguang Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

[GIT PULL] trivial writeback fixes

2012-10-11 Thread Fengguang Wu
Hi Linus, Please pull 3 trivial writeback fixes. Thanks, Fengguang --- The following changes since commit fea7a08acb13524b47711625eebea40a0ede69a0: Linux 3.6-rc3 (2012-08-22 13:29:06 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux.git

Re: [PATCH] ACPI: fix the wrong #ifdef for acpi_no_s4_hw_signature

2012-10-15 Thread Fengguang Wu
eclare in #ifdef CONFIG_PM_SLEEP block. And it's better to always include the original build error/warning messages when fixing build problems. Otherwise looks good to me. Reviewed-by: Fengguang Wu > Signed-off-by: Yuanhan Liu > --- > include/linux/acpi.h |5 - &

Re: [PATCH v2] ACPI: move acpi_no_s4_hw_signature() declaration into #ifdef CONFIG_HIBERNATION

2012-10-15 Thread Fengguang Wu
> Signed-off-by: Yuanhan Liu > Reviewed-by: Fengguang Wu > --- > include/linux/acpi.h |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index 90be989..a468429 100644 > --- a/include/linux/acpi

Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP

2012-10-16 Thread Fengguang Wu
; defined but not used [-Wunused-function] > > Because > SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) > > Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). > > Cc: Jeff Garzik > Cc: Viresh Kumar > Cc: linux-...@vger.kernel.org

Re: fadvise interferes with readahead

2012-11-20 Thread Fengguang Wu
On Wed, Nov 21, 2012 at 02:51:41PM +0800, Jaegeuk Hanse wrote: > On 11/20/2012 11:15 PM, Fengguang Wu wrote: > >On Tue, Nov 20, 2012 at 10:11:54PM +0800, Jaegeuk Hanse wrote: > >>On 11/20/2012 04:04 PM, Fengguang Wu wrote: > >>>Hi Claudio, > >>> > &

Re: fadvise interferes with readahead

2012-11-20 Thread Fengguang Wu
On Wed, Nov 21, 2012 at 03:51:03PM +0800, Jaegeuk Hanse wrote: > On 11/20/2012 10:58 PM, Fengguang Wu wrote: > >On Tue, Nov 20, 2012 at 10:34:11AM -0300, Claudio Freire wrote: > >>On Tue, Nov 20, 2012 at 5:04 AM, Fengguang Wu > >>wrote: > >>>Yes. T

Re: Problem in Page Cache Replacement

2012-11-21 Thread Fengguang Wu
On Wed, Nov 21, 2012 at 04:34:40PM +0800, Jaegeuk Hanse wrote: > Cc Fengguang Wu. > > On 11/21/2012 04:13 PM, metin d wrote: > >> Curious. Added linux-mm list to CC to catch more attention. If you run > >>echo 1 >/proc/sys/vm/drop_caches does it evict data-1 page

Re: Problem in Page Cache Replacement

2012-11-21 Thread Fengguang Wu
On Wed, Nov 21, 2012 at 05:02:04PM +0800, Fengguang Wu wrote: > On Wed, Nov 21, 2012 at 04:34:40PM +0800, Jaegeuk Hanse wrote: > > Cc Fengguang Wu. > > > > On 11/21/2012 04:13 PM, metin d wrote: > > >> Curious. Added linux-mm list to CC to catch more attentio

Re: Problem in Page Cache Replacement

2012-11-22 Thread Fengguang Wu
Hi Jaegeuk, Sorry for the delay. I'm traveling these days.. On Wed, Nov 21, 2012 at 05:42:33PM +0800, Jaegeuk Hanse wrote: > On 11/21/2012 05:02 PM, Fengguang Wu wrote: > >On Wed, Nov 21, 2012 at 04:34:40PM +0800, Jaegeuk Hanse wrote: > >>Cc Fengguang Wu. > >> >

Re: Problem in Page Cache Replacement

2012-11-22 Thread Fengguang Wu
On Wed, Nov 21, 2012 at 12:07:22PM +0200, Metin Döşlü wrote: > On Wed, Nov 21, 2012 at 12:00 PM, Jaegeuk Hanse > wrote: > > > > On 11/21/2012 05:58 PM, metin d wrote: > > > > Hi Fengguang, > > > > I run tests and attached the results. The line below I guess shows the > > data-1 page caches. > >

Re: Problem in Page Cache Replacement

2012-11-22 Thread Fengguang Wu
On Thu, Nov 22, 2012 at 11:41:07PM +0800, Fengguang Wu wrote: > On Wed, Nov 21, 2012 at 12:07:22PM +0200, Metin Döşlü wrote: > > On Wed, Nov 21, 2012 at 12:00 PM, Jaegeuk Hanse > > wrote: > > > > > > On 11/21/2012 05:58 PM, metin d wrote: > > > >

Re: Problem in Page Cache Replacement

2012-11-22 Thread Fengguang Wu
Jaegeuk, > Thanks for your response. But which kind of pages are in the special > reserved and which are all-flags-cleared? The all-flags-cleared pages are mostly free pages in the buddy system. The pages with flag "buddy" are also free pages: the buddy system only marks the head pages of each or

Re: [PATCH V2] vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them

2013-01-11 Thread Fengguang Wu
On Fri, Jan 11, 2013 at 09:12:11PM +0100, Jan Kara wrote: > On Thu 10-01-13 13:47:57, Miao Xie wrote: > > writeback_inodes_sb(_nr)_if_idle() is re-implemented by replacing > > down_read() > > with down_read_trylock() because > > - If ->s_umount is write locked, then the sb is not idle. That is > >

Re: [PATCH 5/5] writeback: add more tracepoints

2013-01-11 Thread Fengguang Wu
Patch looks good to me. But CC more people for review. On Fri, Jan 11, 2013 at 01:06:37PM -0800, Tejun Heo wrote: > Add tracepoints for page dirtying, writeback_single_inode start, inode > dirtying and writeback. For the latter two inode events, a pair of > events are defined to denote start and

Re: livelock in __writeback_inodes_wb ?

2012-12-14 Thread Fengguang Wu
On Tue, Dec 11, 2012 at 02:41:13PM +0100, Jan Kara wrote: > On Tue 11-12-12 16:23:27, Wu Fengguang wrote: > > On Wed, Nov 28, 2012 at 09:55:15AM -0500, Dave Jones wrote: > > > We had a user report the soft lockup detector kicked after 22 > > > seconds of no progress, with this trace.. > > > > Wher

Re: [PATCH v4] kpageflags: fix wrong KPF_THP on non-huge compound pages

2012-09-26 Thread Fengguang Wu
t; + * sure a given page is a thp, not a non-huge compound page. > + */ > + else if (PageTransCompound(page) && PageLRU(compound_trans_head(page))) > u |= 1 << KPF_THP; Reviewed-by: Fengguang Wu Thanks! -- To unsubscribe from this list: send the li

[PATCH] slub: init_kmem_cache_cpus() and put_cpu_partial() can be static

2012-09-28 Thread Fengguang Wu
Acked-by: Glauber Costa Signed-off-by: Fengguang Wu --- mm/slub.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux.orig/mm/slub.c2012-09-24 10:22:11.0 +0800 +++ linux/mm/slub.c 2012-09-28 16:31:31.987092387 +0800 @@ -1709,7 +1709,7 @@ static inline

Re: [PATCH] CPU hotplug, writeback: Don't call writeback_set_ratelimit() too often during hotplug

2012-09-28 Thread Fengguang Wu
On Tue, Sep 25, 2012 at 02:18:20AM +0530, Srivatsa S. Bhat wrote: > > From: Srivatsa S. Bhat > > The CPU hotplug callback related to writeback calls writeback_set_ratelimit() > during every state change in the hotplug sequence. This is unnecessary > since num_online_cpus() changes only once duri

Re: INFO: rcu_preempt detected stalls on CPUs/tasks: { 1} (detected by 0, t=10002 jiffies)

2012-09-30 Thread Fengguang Wu
On Sun, Sep 30, 2012 at 01:10:55PM +0200, Avi Kivity wrote: > On 09/28/2012 05:35 AM, Paul E. McKenney wrote: > > On Thu, Sep 27, 2012 at 12:40:44PM +0800, Fengguang Wu wrote: > >> On Wed, Sep 26, 2012 at 09:28:50PM -0700, Paul E. McKenney wrote: > >> > On Thu, Se

Re: INFO: rcu_preempt detected stalls on CPUs/tasks: { 1} (detected by 0, t=10002 jiffies)

2012-09-30 Thread Fengguang Wu
On Sun, Sep 30, 2012 at 01:32:46PM +0200, Avi Kivity wrote: > On 09/30/2012 01:23 PM, Fengguang Wu wrote: > > On Sun, Sep 30, 2012 at 01:10:55PM +0200, Avi Kivity wrote: > >> On 09/28/2012 05:35 AM, Paul E. McKenney wrote: > >> > On Thu, Sep 27, 2012 at 12:40:

Re: task_work_add/scheduler_tick: possible circular locking dependency detected

2012-10-01 Thread Fengguang Wu
On Mon, Oct 01, 2012 at 12:50:39PM +0200, Peter Zijlstra wrote: > On Fri, 2012-09-28 at 19:34 +0800, Fengguang Wu wrote: > > Peter, > > > > I got the warning > > > > [ 10.412023] > > [ 10.412611] ===

Re: task_work_add/scheduler_tick: possible circular locking dependency detected

2012-10-01 Thread Fengguang Wu
On Mon, Oct 01, 2012 at 02:05:15PM +0200, Ingo Molnar wrote: > > * Fengguang Wu wrote: > > > On Mon, Oct 01, 2012 at 12:50:39PM +0200, Peter Zijlstra wrote: > > > On Fri, 2012-09-28 at 19:34 +0800, Fengguang Wu wrote: > > > > Peter

Re: [PATCH v2] writeback: mark sysctl vm.block_dump for removal

2013-01-15 Thread Fengguang Wu
gt; > index 9fb9bfe..b2582cb 100644 > > --- a/patches/series > > +++ b/patches/series > > @@ -18,3 +18,4 @@ kill-pool-gcwq > > remove-gcwq > > rename-nr_running > > cleanup-leftovers > > +dbg An extra chunk. Reviewed-by: Fengguang Wu Thanks! -- To

Re: general protection fault on ttm_init()

2012-07-06 Thread Fengguang Wu
On Fri, Jul 06, 2012 at 06:09:20PM +0100, Dave Airlie wrote: > On Fri, Jul 6, 2012 at 5:49 PM, Dave Airlie wrote: > > On Fri, Jul 6, 2012 at 3:48 PM, Fengguang Wu wrote: > >> ... The missed kconfig. > >> > >> On Fri, Jul 06, 2012 at 10:46:22PM +0800,

<    1   2   3   4   5   6   7   8   9   10   >