Re: [PATCH] f2fs: optimize gc for better performance

2013-08-29 Thread Jaegeuk Kim
_sel_policy { > int alloc_mode; /* LFS or SSR */ > int gc_mode;/* GC_CB or GC_GREEDY */ > unsigned long *dirty_segmap;/* dirty segment bitmap */ > + int dirty_type; int max_search; /* maximum # of segments to search */ > unsigned int offset;/* last scanned bitmap offset */ > unsigned int ofs_unit; /* bitmap search unit */ > unsigned int min_cost; /* minimum cost */ -- Jaegeuk Kim Samsung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [f2fs-dev][PATCH]f2fs: avoid congestion_wait when do_checkpoint for better performance

2013-10-06 Thread Jaegeuk Kim
per(struct super_block *sb, void > *data, int silent) > mutex_init(&sbi->gc_mutex); > mutex_init(&sbi->writepages); > mutex_init(&sbi->cp_mutex); > + init_waitqueue_head(&sbi->writeback_wqh); > for (i = 0; i < NR_GLOBAL_LOCKS; i++) > mutex_init(&sbi->fs_lock[i]); > mutex_init(&sbi->node_write); > -- Jaegeuk Kim Samsung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] f2fs: optimize gc for better performance

2013-09-04 Thread Jaegeuk Kim
Hi Jin, 2013-09-04 (수), 07:59 +0800, Jin Xu: > Hi Jaegeuk, > > On 03/09/2013 08:45, Jaegeuk Kim wrote: > > Hi Jin, > > > >> [...] > >>> > >>> It seems that we can obtain the performance gain just by setting the > >>> MAX_VICT

Re: [PATCH] f2fs: optimize gc for better performance

2013-09-04 Thread Jaegeuk Kim
Hi Jin, 2013-09-04 (수), 21:17 +0800, Jin Xu: > Hi Jaegeuk, > > On 04/09/2013 17:40, Jaegeuk Kim wrote: > > Hi Jin, > > > > 2013-09-04 (수), 07:59 +0800, Jin Xu: > >> Hi Jaegeuk, > >> > >> On 03/09/2013 08:45, Jaegeuk Kim wrote: > >>&g

[PATCH] f2fs: merge more bios of node block writes

2013-09-04 Thread Jaegeuk Kim
ync, sector = 500109320, size = 500K And finally, we can improve the sequential write performance, from 458.775 MB/s to 479.945 MB/s on SSD. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/nod

Re: [PATCH] f2fs: optimize gc for better performance

2013-09-04 Thread Jaegeuk Kim
irty segments for SSR use most of the > time when free space is in shortage). The well-known iozone test tool > was not used for benchmarking the patch becuase it seems do not have > a test case that performs random re-write on a full disk. > > This patch is the revised version based

[GIT PULL] f2fs updates for v3.12

2013-09-05 Thread Jaegeuk Kim
36f571e9ed0419e73d127e18aa8992ced867268c: Merge tag 'firewire-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394 (2013-07-29 17:08:22 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git tags/for-f2fs-3.1

Re: [f2fs-dev][PATCH] f2fs: optimize fs_lock for better performance

2013-09-09 Thread Jaegeuk Kim
75c7dc3..4f27596 > > --- a/fs/f2fs/super.c > > +++ b/fs/f2fs/super.c > > @@ -657,6 +657,7 @@ static int f2fs_fill_super(struct super_block *sb, > void *data, int silent) > > mutex_init(&sbi->cp_mutex); > > for (i = 0; i < NR_GLOBAL_LOCKS; i++)

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-09 Thread Jaegeuk Kim
> > > > > > > > > -- > Learn the latest--Visual Studio 2012, SharePoint 2013, SQL > 2012, more! > Discover the easy way to master current and pr

Re: Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-09 Thread Jaegeuk Kim
spin_lock_init(&sbi->stat_lock); > > (END) > > > > > > > > > -- > Learn t

Re: Re: [f2fs-dev][PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
t; > + spin_unlock(&sbi->spin_lock); > > > > + > > > > + mutex_lock(&sbi->fs_lock[next_lock]); > > > > return next_lock; > > > > } > > > > > > > > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
Hi Russ, The usage of fs_locks is for the recovery, so it doesn't matter with stress-testing. Actually what I've concerned is that we should not grab two or more fs_locks in the same call path. Thanks, 2013/9/11 Russ Knize : > Hi Jaegeuk/Gu, > > I've removed the lock and

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-11 Thread Kim Jaegeuk
Hi Gu, 2013/9/11 Gu Zheng : > Hi Jaegeuk, Chao, > > On 09/10/2013 08:52 AM, Jaegeuk Kim wrote: > >> Hi, >> >> At first, thank you for the report and please follow the email writing >> rules. :) >> >> Anyway, I agree to the below issue. >> One

[PATCH] f2fs: avoid unnecessary checkpoints

2013-10-07 Thread Jaegeuk Kim
During the f2fs_put_super procedure, we don't need to conduct checkpoint all the time, since we don't need to do that if superblock is clean. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2

[PATCH] f2fs: fix writing incorrect orphan blocks

2013-10-07 Thread Jaegeuk Kim
block according to the wrong sbi->n_orphans. To avoid this, simply we should make cover acquire_orphan_inode too with f2fs_lock_op. Signed-off-by: Jaegeuk Kim --- fs/f2fs/namei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c inde

[PATCH] f2fs: fix to store and retrieve i_rdev correctly

2013-10-08 Thread Jaegeuk Kim
Previously f2fs stores i_rdev information into i_addr. But, if inline_xattr is set, f2fs should avoid using i_addr fields. So, this patch adds to use i_nid fields instead of i_addrs when inline_xattr is set. Signed-off-by: Jaegeuk Kim --- fs/f2fs/inode.c | 63

[PATCH] f2fs: fix the starvation problem on cp_rwsem

2013-10-09 Thread Jaegeuk Kim
didn't need to do this before neither. Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h | 13 - fs/f2fs/super.c | 1 - 2 files changed, 14 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index a955a59..308967b 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -18,8

Re: [PATCH] f2fs: optimize gc for better performance

2013-09-02 Thread Jaegeuk Kim
TIM_SEARCH_THRESH 4096 > >> > >> struct f2fs_gc_kthread { > >>struct task_struct *f2fs_gc_task; > >> diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h > >> index 062424a..cd33f96 100644 > >> --- a/fs/f2fs/segment.h > >> +++ b/fs/f2fs/segment.h > >> @@ -142,6 +142,7 @@ struct victim_sel_policy { > >>int alloc_mode; /* LFS or SSR */ > >>int gc_mode;/* GC_CB or GC_GREEDY */ > >>unsigned long *dirty_segmap;/* dirty segment bitmap */ > >> + int dirty_type; > > > > int max_search; /* maximum # of segments to search */ > > > >>unsigned int offset;/* last scanned bitmap offset */ > >>unsigned int ofs_unit; /* bitmap search unit */ > >>unsigned int min_cost; /* minimum cost */ > > > -- Jaegeuk Kim Samsung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 2/2] f2fs: avoid an overflow during utilization calculation

2013-09-02 Thread Jaegeuk Kim
The current f2fs uses all the block counts with 32 bit numbers, which is able to cover about 15TB volume. But in calculation of utilization, f2fs multiplies the count by 100 which can induce overflow. This patch fixes this. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.h | 2 +- 1 file

[PATCH 1/2] f2fs: trigger GC when there are prefree segments

2013-09-02 Thread Jaegeuk Kim
Previously, f2fs conducts SSR when free_sections() < overprovision_sections. But, even though there are a lot of prefree segments, it can consider SSR only. So, let's consider the number of prefree segments too for triggering SSR. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.h | 3 ++-

Re: [RFC 1/1] f2fs: don't GC or take an fs_lock from f2fs_initxattrs()

2013-09-25 Thread Jaegeuk Kim
; > > exit: > > - mutex_unlock_op(sbi, ilock); > > kzfree(base_addr); > > return error; > > } > > + > > +int f2fs_setxattr(struct inode *inode, int name_index, const char *name, > > + const void *value, size_t valu

Re: [PATCH 16/16] f2fs: update Kconfig and Makefile

2012-10-06 Thread Jaegeuk Kim
greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Jae

Re: [PATCH 10/16] f2fs: add core inode operations

2012-10-06 Thread Jaegeuk Kim
gt; + ri->i_ctime = cpu_to_le32(inode->i_ctime.tv_sec); > > + ri->i_mtime = cpu_to_le32(inode->i_mtime.tv_sec); > > + ri->i_atime = cpu_to_le32(inode->i_atime.tv_sec); > > + ri->current_depth = cpu_to_le32(F2FS_I(inode)->current_depth); > > + ri->

Re: [PATCH 13/16] f2fs: add xattr and acl functionalities

2012-10-06 Thread Jaegeuk Kim
age to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Jaegeuk Kim Samsung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: [PATCH 02/16] f2fs: add on-disk layout

2012-10-06 Thread Jaegeuk Kim
t; Ok, I'll take a look at this. Thanks, > > Regards > > > > Dan > > > > Thanks > Boaz > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More maj

Re: [PATCH 02/16] f2fs: add on-disk layout

2012-10-06 Thread Jaegeuk Kim
2012-10-05 (금), 19:46 +0200, Martin Steigerwald: > Am Freitag, 5. Oktober 2012 schrieb 김재극: > > This adds a header file describing the on-disk layout of f2fs. > > > > Signed-off-by: Changman Lee > > Signed-off-by: Chul Lee > > Signed-off-by: Jaegeuk Kim >

Re: [PATCH 01/16] f2fs: add document

2012-10-06 Thread Jaegeuk Kim
I'll apply this. Thanks, 2012-10-05 (금), 12:56 -0700, Randy Dunlap: > On 10/05/2012 04:56 AM, 김재극 wrote: > > > This adds a document describing the mount options, proc entries, usage, and > > design of Flash-Friendly File System, namely F2FS. > > &

Re: [PATCH 01/16] f2fs: add document

2012-10-06 Thread Jaegeuk Kim
2012-10-06 (토), 09:19 +0200, Stefan Hajnoczi: > > This adds a document describing the mount options, proc entries, usage, and > > design of Flash-Friendly File System, namely F2FS. > > > > Signed-off-by: Jaegeuk Kim samsung.com> > > --- > > Do

Re: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-06 Thread Jaegeuk Kim
2012-10-06 (토), 17:54 +0400, Vyacheslav Dubeyko: > Hi Jaegeuk, Hi. We know each other, right? :) > > > From: 김재극 > > To: v...@zeniv.linux.org.uk, 'Theodore Ts'o' , > > gre...@linuxfoundation.org, linux-kernel@vger.kerne

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-07 Thread Jaegeuk Kim
> -Original Message- > From: Marco Stornelli [mailto:marco.storne...@gmail.com] > Sent: Sunday, October 07, 2012 4:10 PM > To: Jaegeuk Kim > Cc: Vyacheslav Dubeyko; jaegeuk@samsung.com; Al Viro; ty...@mit.edu; > gre...@linuxfoundation.org; > linux-kernel@

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-08 Thread Jaegeuk Kim
> -Original Message- > From: Vyacheslav Dubeyko [mailto:sl...@dubeyko.com] > Sent: Sunday, October 07, 2012 9:09 PM > To: Jaegeuk Kim > Cc: 'Marco Stornelli'; 'Jaegeuk Kim'; 'Al Viro'; ty...@mit.edu; > gre...@linuxfoundation.org; linux

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-08 Thread Jaegeuk Kim
> -Original Message- > From: Namjae Jeon [mailto:linkinj...@gmail.com] > Sent: Monday, October 08, 2012 7:00 PM > To: Jaegeuk Kim > Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu; > gre...@linuxfoundation.org; linux-kernel@vger.k

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-08 Thread Jaegeuk Kim
> -Original Message- > From: Namjae Jeon [mailto:linkinj...@gmail.com] > Sent: Monday, October 08, 2012 8:22 PM > To: Jaegeuk Kim > Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu; > gre...@linuxfoundation.org; linux-kernel@vger.k

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Jaegeuk Kim
> -Original Message- > From: Vyacheslav Dubeyko [mailto:sl...@dubeyko.com] > Sent: Tuesday, October 09, 2012 4:23 AM > To: Jaegeuk Kim > Cc: 'Marco Stornelli'; 'Jaegeuk Kim'; 'Al Viro'; ty...@mit.edu; > gre...@linuxfoundation.org; linux

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Jaegeuk Kim
--- Jaegeuk Kim Samsung > -Original Message- > From: Namjae Jeon [mailto:linkinj...@gmail.com] > Sent: Tuesday, October 09, 2012 12:52 PM > To: Jaegeuk Kim > Cc: Vyacheslav Dubeyko; Marco Stornelli; Jaegeuk Kim; Al Viro; ty...@mit.edu; > gre...@linuxfoundation

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Jaegeuk Kim
> -Original Message- > From: linux-fsdevel-ow...@vger.kernel.org > [mailto:linux-fsdevel-ow...@vger.kernel.org] On Behalf Of > Luka? Czerner > Sent: Tuesday, October 09, 2012 5:32 PM > To: Jaegeuk Kim > Cc: 'Namjae Jeon'; 'Vyacheslav Dubeyko'; 

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Jaegeuk Kim
> -Original Message- > From: Lukáš Czerner [mailto:lczer...@redhat.com] > Sent: Tuesday, October 09, 2012 8:01 PM > To: Jaegeuk Kim > Cc: 'Lukáš Czerner'; 'Namjae Jeon'; 'Vyacheslav Dubeyko'; 'Marco Stornelli'; > 'Jaegeuk Kim&

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Jaegeuk Kim
2012-10-09 (화), 14:39 +0200, Lukáš Czerner: > On Tue, 9 Oct 2012, Jaegeuk Kim wrote: > > > > > > > > > > > > > > > > > As you can see the f2fs kernel document patch, I think one of > > > > > > > > the most &

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-09 Thread Jaegeuk Kim
> -Original Message- > From: linux-fsdevel-ow...@vger.kernel.org > [mailto:linux-fsdevel-ow...@vger.kernel.org] On Behalf Of > Dave Chinner > Sent: Wednesday, October 10, 2012 6:20 AM > To: Jaegeuk Kim > Cc: 'Lukáš Czerner'; 'Namjae Jeon'

RE: [PATCH 02/16] f2fs: add on-disk layout

2012-10-09 Thread Jaegeuk Kim
[snip] > > +/* > > + * For superblock > > + */ > > +struct f2fs_super_block { > > + __le32 magic; /* Magic Number */ > > + __le16 major_ver; /* Major Version */ > > + __le16 minor_ver; /* Minor Version */ > > + __le32 log_sectorsize; /* log2 (Sector size in bytes) */

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-10 Thread Jaegeuk Kim
[snip] > > How about the following scenario? > > 1. data "a" is newly written. > > 2. checkpoint "A" is done. > > 3. data "a" is truncated. > > 4. checkpoint "B" is done. > > > > If fs supports multiple snapshots like "A" and "B" to users, it cannot > > reuse the space allocated by > > data "a" af

Re: [PATCH 1/6] f2fs: fix the compiler warning for uninitialized use of variable

2012-12-02 Thread Jaegeuk Kim
s/node.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 25d3036..1987036 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -266,6 +266,7 @@ void get_node_info(struct f2fs_sb_info *sbi, nid_t nid, > struct node_in

Re: [PATCH -next] f2fs: remove unused variable

2012-12-02 Thread Jaegeuk Kim
F2FS_DIRTY_DENTS); > inode_dec_dirty_dents(dir); > - page_offset = page->index << PAGE_CACHE_SHIFT; > f2fs_put_page(page, 1); > } else { > f2fs_put_page(page, 1); > > -- Jaegeuk Kim Samsung signature.asc Description: This is a digitally signed message part

RE: [PATCH 11/16] f2fs: add inode operations for special inodes

2012-10-17 Thread Jaegeuk Kim
> On Tuesday 16 October 2012, Jaegeuk Kim wrote: > > > > > > > > An xattr on the root inode that holds a list like this is something > > > > > that could be set at mkfs time, but then also updated easily by new > > > > > software

RE: [PATCH 00/16] f2fs: introduce flash-friendly file system

2012-10-18 Thread Jaegeuk Kim
> [snip] > > > > > > And Would you share ppt or document of f2fs if Korea Linux Forum is > > > finished ? > > > > > > > Here I attached the slides, and LF will also share the slides. > > Thanks, > > > > I had hope that slides will have more detailed description. Maybe it is > good for Linux Forum

[PATCH 00/16 v2] f2fs: introduce flash-friendly file system

2012-10-22 Thread Jaegeuk Kim
, "mkfs.f2fs", is available from the following download page: http://sourceforge.net/projects/f2fs-tools/ Usage = If you'd like to experience f2fs, simply: # mkfs.f2fs /dev/sdb1 # mount -t f2fs /dev/sdb1 /mnt/f2fs Short log ===== Jaegeuk Kim (16): f2fs: add

[PATCH 01/16 v2] f2fs: add document

2012-10-22 Thread Jaegeuk Kim
This adds a document describing the mount options, proc entries, usage, and design of Flash-Friendly File System, namely F2FS. Signed-off-by: Jaegeuk Kim --- Documentation/filesystems/00-INDEX |2 + Documentation/filesystems/f2fs.txt | 404 2 files

[PATCH 02/16 v2] f2fs: add on-disk layout

2012-10-22 Thread Jaegeuk Kim
This adds a header file describing the on-disk layout of f2fs. Signed-off-by: Changman Lee Signed-off-by: Chul Lee Signed-off-by: Jaegeuk Kim --- include/linux/f2fs_fs.h | 362 +++ 1 file changed, 362 insertions(+) create mode 100644 include/linux

[PATCH 04/16 v2] f2fs: add super block operations

2012-10-22 Thread Jaegeuk Kim
This adds the implementation of superblock operations for f2fs, which includes - init_f2fs_fs/exit_f2fs_fs - f2fs_mount - super_operations of f2fs Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 590 +++ 1 file changed, 590 insertions

[PATCH 05/16 v2] f2fs: add checkpoint operations

2012-10-22 Thread Jaegeuk Kim
order to provide an address space for meta pages, f2fs_sb_info has a special inode, namely meta_inode. This patch also adds the address space operations for meta_inode. Signed-off-by: Chul Lee Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 795

[PATCH 06/16 v2] f2fs: add node operations

2012-10-22 Thread Jaegeuk Kim
management such as getting, allocating, and truncating node blocks to index data. - In order to cache node blocks in memory, F2FS has a node_inode with an address space for node pages. This patch also adds the address space operations for node_inode. Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c

[PATCH 07/16 v2] f2fs: add segment operations

2012-10-22 Thread Jaegeuk Kim
functions to write data, node, and meta pages. Since LFS basically produces a series of sequential writes, F2FS merges sequential bios with a single one as much as possible to reduce the IO scheduling overhead. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 1795

[PATCH 08/16 v2] f2fs: add file operations

2012-10-22 Thread Jaegeuk Kim
This adds memory operations and file/file_inode operations. - F2FS supports fallocate(), mmap(), fsync(), and basic ioctl(). Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 640 1 file changed, 640 insertions(+) create mode 100644 fs

[PATCH 09/16 v2] f2fs: add address space operations for data

2012-10-22 Thread Jaegeuk Kim
This adds address space operations for data. - F2FS supports readpages(), writepages(), and direct_IO(). - Because of out-of-place writes, f2fs_direct_IO() does not write data in place. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 701

[PATCH 10/16 v2] f2fs: add core inode operations

2012-10-22 Thread Jaegeuk Kim
This adds core functions to get, read, write, and evict an inode. Signed-off-by: Changman Lee Signed-off-by: Jaegeuk Kim --- fs/f2fs/inode.c | 262 +++ 1 file changed, 262 insertions(+) create mode 100644 fs/f2fs/inode.c diff --git a/fs

[PATCH 11/16 v2] f2fs: add inode operations for special inodes

2012-10-22 Thread Jaegeuk Kim
This adds inode operations for directory, symlink, and special inodes. Signed-off-by: Changman Lee Signed-off-by: Jaegeuk Kim --- fs/f2fs/namei.c | 494 +++ 1 file changed, 494 insertions(+) create mode 100644 fs/f2fs/namei.c diff --git a

[PATCH 12/16 v2] f2fs: add core directory operations

2012-10-22 Thread Jaegeuk Kim
This adds core functions to find, add, delete, and link dentries. Signed-off-by: Jaegeuk Kim --- fs/f2fs/dir.c | 657 fs/f2fs/hash.c | 98 + 2 files changed, 755 insertions(+) create mode 100644 fs/f2fs/dir.c create mode

[PATCH 13/16 v2] f2fs: add xattr and acl functionalities

2012-10-22 Thread Jaegeuk Kim
This implements xattr and acl functionalities. - F2FS uses a node page to contain use extended attributes. Signed-off-by: Changman Lee Signed-off-by: Jaegeuk Kim --- fs/f2fs/acl.c | 465 +++ fs/f2fs/acl.h | 57 +++ fs/f2fs/xattr.c

[PATCH 14/16 v2] f2fs: add garbage collection functions

2012-10-22 Thread Jaegeuk Kim
of on-demand cleaning, F2FS should move the data right away. - In order to identify valid blocks in a victim segment, F2FS scans the bitmap of the segment managed as an SIT entry. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 1139 ++ fs

[PATCH 15/16 v2] f2fs: add recovery routines for roll-forward

2012-10-22 Thread Jaegeuk Kim
on of next node block in each direct node block for reconstructing the chain of node blocks during the recovery. - In order to enhance the performance, F2FS keeps a "dentry" mark also in direct node blocks. If this is set during the recovery, F2FS replays adding a dentry. Signed

[PATCH 16/16 v2] f2fs: update Kconfig and Makefile

2012-10-22 Thread Jaegeuk Kim
This adds Makefile and Kconfig for f2fs, and updates Makefile and Kconfig files in the fs directory. Signed-off-by: Jaegeuk Kim --- fs/Kconfig |1 + fs/Makefile |1 + fs/f2fs/Kconfig | 55 ++ fs/f2fs/Makefile |6

[GIT PULL] f2fs: request for tree inclusion

2012-12-10 Thread Jaegeuk Kim
tency repeatedly, while running a reliability test. So, please pull the f2fs filesystem. If I'm missing any issues or made mistakes, please let me know. Thanks, Jaegeuk Kim The following changes since commit 29594404d7fe73cd80eaa4ee8c43dcc53970c60e: Linux 3.7 (2012-12-10 19:30:57 -0800) are

Re: [PATCH] f2fs: fix up f2fs_get_parent issue to retrieve correct parent inode number

2012-12-11 Thread Jaegeuk Kim
dotdot dentries should have zero-value hash code */ + if (!memcmp(name, ".", 1) || !memcmp(name, "..", 2)) + return 0; + /* Initialize the default seed for the hash checksum functions */ buf[0] = 0x67452301; buf[1] = 0xefcdab89; -- 1.8.0.1.250.gb7973fb -- Jaegeuk Kim Samsung signature.asc Description: This is a digitally signed message part

Re: [PATCH] tmpfs: fix shmem_getpage_gfp VM_BUG_ON

2012-11-13 Thread Jaegeuk Hanse
tantiate a new page there, but the expected parameter will not be NULL, the result is radix_tree_insert will not be called and shmem_add_to_page_cache will not return -EEXIST, then why trigger BUG_ON ? Regards, Jaegeuk So although I believe my VM_BUG_ON(error != -ENOENT) is safe, it's not

Re: [PATCH] tmpfs: fix shmem_getpage_gfp VM_BUG_ON

2012-11-14 Thread Jaegeuk Hanse
On 11/14/2012 11:50 AM, Hugh Dickins wrote: On Wed, 14 Nov 2012, Jaegeuk Hanse wrote: On 11/07/2012 07:48 AM, Hugh Dickins wrote: On Tue, 6 Nov 2012, Dave Jones wrote: On Mon, Nov 05, 2012 at 05:32:41PM -0800, Hugh Dickins wrote: > - /* We already confirmed swap,

Re: [PATCH 00/16 v3] f2fs: introduce flash-friendly file system

2012-11-11 Thread Jaegeuk Kim
ts version. I suggest to output version of f2fs utilities. Agreed. But, I'd like to note that f2fs is not merged yet. IMHO, it'd better give an initial version after f2fs is merged. Thanks, > > With the best regards, > Vyacheslav Dubeyko. > -- Jaegeuk Kim Samsung -- To uns

Re: [PATCH 1/5] f2fs: Introduce some information prints in the mount path

2012-12-25 Thread Jaegeuk Kim
node for node space */ > sbi->node_inode = f2fs_iget(sb, F2FS_NODE_INO(sbi)); > if (IS_ERR(sbi->node_inode)) { > + pr_err("Failed to read node inode\n"); > err = PTR_ERR(sbi->node_inode); > goto free_nm; > } > @@ -534,6 +559,7 @@ static int f2fs_fill_super(struct super_block *sb, void > *data, int silent) > /* read root inode and dentry */ > root = f2fs_iget(sb, F2FS_ROOT_INO(sbi)); > if (IS_ERR(root)) { > + pr_err("Failed to read root inode\n"); > err = PTR_ERR(root); > goto free_node_inode; > } -- Jaegeuk Kim Samsung signature.asc Description: This is a digitally signed message part

Re: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk

2012-12-25 Thread Jaegeuk Kim
GROUP assigning e_id is > unnecessary. Remove the assignment so f2fs will build with user > namespaces enabled. > > Cc: Jaegeuk Kim > Cc: Namjae Jeon > Cc: Amit Sahrawat > Signed-off-by: "Eric W. Biederman" Acked-by: Jaegeuk Kim -- Jaegeuk Kim Samsung signature.asc Description: This is a digitally signed message part

Re: [PATCH] f2fs: add missing pretech.h include

2012-12-27 Thread Jaegeuk Kim
: [PATCH] f2fs: add missing pretech.h include > > That should have been "prefetch.h", obviously... > At least the patch is correct. Hi, This was fixed by Geert Uytterhoeven before. I'm supposed to push other bug fixes with this to linus today. Anyway, thank you very much. :)

[GIT PULL] f2fs fixes for 3.8-rc2

2012-12-27 Thread Jaegeuk Kim
Hi Linus, Please pull the following patches for bug fixes on the f2fs file system. Thank you very much. -- Jaegeuk Kim Samsung The following changes since commit 637704cbc95c02d18741b4a6e7a5d2397f8b28ce: Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linu

Re: [GIT PULL] f2fs fixes for 3.8-rc2

2012-12-27 Thread Jaegeuk Kim
2012-12-28 (금), 03:00 +0100, Sedat Dilek: > Looks like you didn't S-o-b-ed all patches in your tree (see Leon's or > Geert's patch). I've fixed all the patches. Thank you. :) > > - Sedat - > > On Fri, Dec 28, 2012 at 2:54 AM, Jaegeuk Kim wrote: > >

[GIT PULL v2] f2fs fixes for 3.8-rc2

2012-12-27 Thread Jaegeuk Kim
Hi Linus, Sorry for the noise. I've resolved the S-O-B issue in v1 tree. Here is the pull request v2. Thanks, -- Jaegeuk Kim Samsung The following changes since commit 637704cbc95c02d18741b4a6e7a5d2397f8b28ce: Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.d

Re: [PATCH 3/4] f2fs: fix removing cache entry within proper lock

2013-01-01 Thread Jaegeuk Kim
t_lock); > if (__lookup_free_nid_list(nid, &nm_i->free_nid_list)) { > - spin_unlock(&nm_i->free_nid_list_lock); > kmem_cache_free(free_nid_slab, i); > + spin_unlock(&nm_i->free_nid_list_lock); > return 0; > } >

Re: [PATCH -next] f2fs: add missing #include

2012-12-19 Thread Jaegeuk Kim
Merged. Thank you very much. -- Jaegeuk Kim Samsung 2012-12-19 (수), 22:19 +0100, Geert Uytterhoeven: > m68k allmodconfig: > > fs/f2fs/data.c: In function ‘read_end_io’: > fs/f2fs/data.c:311: error: implicit declaration of function ‘prefetchw’ > > fs/f2fs/segm

[PATCH] f2fs: add MAINTAINERS entry

2012-12-20 Thread Jaegeuk Kim
This patch adds myself to MAINTAINERS entry for the f2fs file system. Signed-off-by: Jaegeuk Kim --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9386a63..f15d168 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3204,6 +3204,16 @@ F

Re: [PATCH] tmpfs: fix shmem_getpage_gfp VM_BUG_ON

2012-11-15 Thread Jaegeuk Hanse
On 11/16/2012 03:56 AM, Hugh Dickins wrote: Offtopic... On Thu, 15 Nov 2012, Jaegeuk Hanse wrote: Another question. Why the function shmem_fallocate which you add to kernel need call shmem_getpage? Because shmem_getpage(_gfp) is where shmem's page lookup and allocation complexitie

Re: [PATCH 20/21] mm: drop vmtruncate

2012-11-15 Thread Jaegeuk Hanse
On 11/03/2012 05:32 PM, Marco Stornelli wrote: Removed vmtruncate Hi Marco, Could you explain me why vmtruncate need remove? What's the problem and how to substitute it? Regards, Jaegeuk Signed-off-by: Marco Stornelli --- include/linux/mm.h |1 - mm/truncate.c |

Re: [PATCH] tmpfs: fix shmem_getpage_gfp VM_BUG_ON

2012-11-16 Thread Jaegeuk Hanse
On 11/16/2012 03:56 AM, Hugh Dickins wrote: Offtopic... On Thu, 15 Nov 2012, Jaegeuk Hanse wrote: Another question. Why the function shmem_fallocate which you add to kernel need call shmem_getpage? Because shmem_getpage(_gfp) is where shmem's page lookup and allocation complexitie

Re: [PATCH] tmpfs: fix shmem_getpage_gfp VM_BUG_ON

2012-11-17 Thread Jaegeuk Hanse
On 11/17/2012 12:48 PM, Hugh Dickins wrote: Further offtopic.. Thanks for your explanation, Hugh. :-) On Fri, 16 Nov 2012, Jaegeuk Hanse wrote: Some questions about your shmem/tmpfs: misc and fallocate patchset. - Since shmem_setattr can truncate tmpfs files, why need add another similar

Re: [PATCH] tmpfs: fix shmem_getpage_gfp VM_BUG_ON

2012-11-17 Thread Jaegeuk Hanse
ene, nr_unswapped maybe grow bigger enough than shmem_falloc.nr_falloced 2) why return -ENOMEM, it's not really OOM, is it a trick or ...? Regards, Jaegeuk On Fri, 16 Nov 2012, Jaegeuk Hanse wrote: Some questions about your shmem/tmpfs: misc and fallocate patchset. - Since shmem_setattr c

Re: [PATCH v6 10/12] thp: implement refcounting for huge zero page

2012-11-17 Thread Jaegeuk Hanse
easy reclaimable memory. This time callback called with nr_to_scan > 0 and we freed hzp. " What's "usemem"? Is it a tool and how to get it? It's hard for me to find nr_to_scan > 0 in every callset, how can nr_to_scan > 0 in your scenario? Regards, Jaege

Re: [PATCH] tmpfs: change final i_blocks BUG to WARNING

2012-11-18 Thread Jaegeuk Hanse
+1 when it should be 0, and then the asymmetry stops it from being corrected with -1 before hitting the BUG. Hi Hugh, So if race happen, still have pages swapout after inode and radix tree destroied. What will happen when the pages need be swapin in the scenacio like swapoff. Regards, Jaegeuk O

Re: [PATCH v6 10/12] thp: implement refcounting for huge zero page

2012-11-19 Thread Jaegeuk Hanse
On 11/19/2012 05:56 PM, Kirill A. Shutemov wrote: On Sun, Nov 18, 2012 at 02:23:44PM +0800, Jaegeuk Hanse wrote: On 11/16/2012 03:27 AM, Kirill A. Shutemov wrote: From: "Kirill A. Shutemov" H. Peter Anvin doesn't like huge zero page which sticks in memory forever after the f

Re: [PATCH v6 10/12] thp: implement refcounting for huge zero page

2012-11-19 Thread Jaegeuk Hanse
On 11/19/2012 06:23 PM, Kirill A. Shutemov wrote: On Mon, Nov 19, 2012 at 06:20:01PM +0800, Jaegeuk Hanse wrote: On 11/19/2012 05:56 PM, Kirill A. Shutemov wrote: On Sun, Nov 18, 2012 at 02:23:44PM +0800, Jaegeuk Hanse wrote: On 11/16/2012 03:27 AM, Kirill A. Shutemov wrote: From: "Kir

Re: [PATCH v6 10/12] thp: implement refcounting for huge zero page

2012-11-19 Thread Jaegeuk Hanse
On 11/19/2012 07:09 PM, Kirill A. Shutemov wrote: On Mon, Nov 19, 2012 at 07:02:22PM +0800, Jaegeuk Hanse wrote: On 11/19/2012 06:23 PM, Kirill A. Shutemov wrote: On Mon, Nov 19, 2012 at 06:20:01PM +0800, Jaegeuk Hanse wrote: On 11/19/2012 05:56 PM, Kirill A. Shutemov wrote: On Sun, Nov 18

Re: [RFT PATCH v1 0/5] fix up inaccurate zone->present_pages

2012-11-19 Thread Jaegeuk Hanse
On 11/19/2012 12:07 AM, Jiang Liu wrote: The commit 7f1290f2f2a4 ("mm: fix-up zone present pages") tries to resolve an issue caused by inaccurate zone->present_pages, but that fix is incomplete and causes regresions with HIGHMEM. And it has been reverted by commit 5576646 revert "mm: fix-up zone

Re: [RFT PATCH v1 4/5] mm: provide more accurate estimation of pages occupied by memmap

2012-11-19 Thread Jaegeuk Hanse
On 11/19/2012 12:07 AM, Jiang Liu wrote: If SPARSEMEM is enabled, it won't build page structures for non-existing pages (holes) within a zone, so provide a more accurate estimation of pages occupied by memmap if there are big holes within the zone. And pages for highmem zones' memmap will be all

Re: [RFT PATCH v1 0/5] fix up inaccurate zone->present_pages

2012-11-19 Thread Jaegeuk Hanse
On 11/20/2012 10:43 AM, Jiang Liu wrote: On 2012-11-20 10:13, Jaegeuk Hanse wrote: On 11/19/2012 12:07 AM, Jiang Liu wrote: The commit 7f1290f2f2a4 ("mm: fix-up zone present pages") tries to resolve an issue caused by inaccurate zone->present_pages, but that fix is incomple

Re: [PATCH v3 06/12] memory-hotplug: unregister memory section on SPARSEMEM_VMEMMAP

2012-11-19 Thread Jaegeuk Hanse
, In order to review this patch, I should dig sparse memory codes in advance. But I have some confuse of codes. Why need encode/decode mem map instead of set mem_map to ms->section_mem_map directly? Regards, Jaegeuk CC: David Rientjes CC: Jiang Liu CC: Len Brown CC: Christoph Lameter

Re: [PATCH v3 06/12] memory-hotplug: unregister memory section on SPARSEMEM_VMEMMAP

2012-11-19 Thread Jaegeuk Hanse
On 11/20/2012 02:55 PM, Wen Congyang wrote: At 11/20/2012 02:22 PM, Jaegeuk Hanse Wrote: On 11/01/2012 05:44 PM, Wen Congyang wrote: From: Yasuaki Ishimatsu Currently __remove_section for SPARSEMEM_VMEMMAP does nothing. But even if we use SPARSEMEM_VMEMMAP, we can unregister the

Re: [PATCH v3 06/12] memory-hotplug: unregister memory section on SPARSEMEM_VMEMMAP

2012-11-20 Thread Jaegeuk Hanse
On 11/20/2012 05:37 PM, Wen Congyang wrote: At 11/20/2012 02:58 PM, Jaegeuk Hanse Wrote: On 11/20/2012 02:55 PM, Wen Congyang wrote: At 11/20/2012 02:22 PM, Jaegeuk Hanse Wrote: On 11/01/2012 05:44 PM, Wen Congyang wrote: From: Yasuaki Ishimatsu Currently __remove_section for

Re: [PATCH v3 06/12] memory-hotplug: unregister memory section on SPARSEMEM_VMEMMAP

2012-11-20 Thread Jaegeuk Hanse
work correctly. Regards, Jaegeuk CC: David Rientjes CC: Jiang Liu CC: Len Brown CC: Christoph Lameter Cc: Minchan Kim CC: Andrew Morton CC: KOSAKI Motohiro CC: Wen Congyang Signed-off-by: Yasuaki Ishimatsu --- mm/memory_hotplug.c | 13 - 1 file changed, 8 insertions(

Re: [PATCH 0/5] Add movablecore_map boot option.

2012-11-20 Thread Jaegeuk Hanse
On 11/20/2012 07:07 PM, Yasuaki Ishimatsu wrote: 2012/11/20 5:53, Andrew Morton wrote: On Mon, 19 Nov 2012 22:27:21 +0800 Tang Chen wrote: This patchset provide a boot option for user to specify ZONE_MOVABLE memory map for each node in the system. movablecore_map=nn[KMG]@ss[KMG] This optio

Re: fadvise interferes with readahead

2012-11-20 Thread Jaegeuk Hanse
On 11/20/2012 04:04 PM, Fengguang Wu wrote: Hi Claudio, Thanks for the detailed problem description! On Fri, Nov 09, 2012 at 04:30:32PM -0300, Claudio Freire wrote: Hi. First of all, I'm not subscribed to this list, so I'd suggest all replies copy me personally. I have been trying to implemen

Re: fadvise interferes with readahead

2012-11-20 Thread Jaegeuk Hanse
start + size - aysnc_size + 1, then what will happen? It seems that variable hit_readahead_marker is false, and related codes can't run, where I miss? Regards, Jaegeuk On Fri, Nov 09, 2012 at 04:30:32PM -0300, Claudio Freire wrote: Hi. First of all, I'm not subscribed to this list,

Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submit bio

2013-04-21 Thread Jaegeuk Kim
>= META_FLUSH) > rw = WRITE_FLUSH_FUA; > > + if (type == META) Should be if (btype == META). Thanks, > + rw |= REQ_META; > + > if (sbi->bio[btype]) { > struct bio_private *p = sbi->bio[btype]->bi_private; >

Re: [PATCH v4 0/7] f2fs: Add tracepoints support in f2fs filesystem

2013-04-23 Thread Jaegeuk Kim
em for tracing the filesystem > operations for information/debugging purpose if needed. All the > tracepoints are clubbed with respect to functionalities. > > Change Log: > v4: Modified the tracepoints as per the review comments of > Jaegeuk Kim. Follo

Re: [PATCH v4 1/7] f2fs: add tracepoints for sync & Inode operations

2013-04-23 Thread Jaegeuk Kim
gned-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Acked-by: Steven Rostedt [Jaegeuk: combine and modify the tracepoint structures] Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 7 +- fs/f2fs/inode.c | 13 ++- fs/f2fs/namei.c | 3 + fs/f2fs/sup

Re: [PATCH v4 2/7] f2fs: add tracepoints for truncate operation

2013-04-23 Thread Jaegeuk Kim
add tracepoints for tracing the truncate operations like truncate node/data blocks, f2fs_truncate etc. Tracepoints are added at entry and exit of operation to trace the success & failure of operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Acked-by: Steven Rostedt [Jae

Re: [PATCH v4 3/7] f2fs: add tracepoint for tracing the page i/o operations

2013-04-23 Thread Jaegeuk Kim
Add tracepoints for page i/o operations and block allocation tracing during page read operation. Signed-off-by: Namjae Jeon Signed-off-by: Pankaj Kumar Acked-by: Steven Rostedt [Jaegeuk: combine and modify the tracepoint structures] Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c

<    1   2   3   4   5   6   7   8   9   10   >