2016-02-19 2:47 GMT+03:00 Greg Kroah-Hartman :
> On Thu, Feb 18, 2016 at 11:29:07PM +0300, Matwey V. Kornilov wrote:
>> 2016-02-18 23:21 GMT+03:00 Andy Shevchenko :
>> > On Thu, Feb 18, 2016 at 8:47 PM, Matwey V. Kornilov
>> > wrote:
>> >> serial8250_em485_
2016-02-10 19:05 GMT+03:00 Peter Hurley :
> Hi Matwey,
>
> On 02/01/2016 10:09 AM, Matwey V. Kornilov wrote:
>> Changes from v7:
>> - rework comments to follow guidelines
>> - minor style changes
>> Changes from v6:
>> - minor style changes
>> -
санов
Signed-off-by: Matwey V. Kornilov
---
Changes from v1:
- Properly filled Reported-by: tag
drivers/tty/serial/8250/8250_port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
index c908b77..4d6deef
Formally, currently there is no memory leak, but if
serial8250_ports[line] is reused with other 8250 driver, then em485
will be already activated and it will cause issues.
Fixes: e490c9144cfa ("tty: Add software emulated RS485 support for 8250")
Signed-off-by: Matwey V. Kornilov
--
Hi,
Teresa replied me, but unfortunately I found that the answer not
reached the public maillists. Briefly, we don't need this patch,
PhyTec will send better one this year.
2015-03-07 15:59 GMT+03:00 Matwey V. Kornilov :
> The following patch is to support Phytec phyBOARD-Wega-AM335
2015-03-06 17:42 GMT+03:00 Stanimir Varbanov :
> On 02/19/2015 07:41 PM, Matwey V. Kornilov wrote:
>> spear13xx_pcie_driver.driver is allocated in text.init section
>> and then the pointer to it is passed futher. This patch is to avoid
>> crashes like the following, when
ollowing developers:
Christian Arlt
Stefan Müller-Klieser
Teresa Gámez
Wadim Egorov
Tested-by: Matwey V. Kornilov
Signed-off-by: Matwey V. Kornilov
---
The patch has been tested on 3.19.0 with openSUSE Factory on
phyBOARD-Wega-AM335x kit. The board successfully boots, ethernet works
=-1225602132, flags=0) at
../kernel/module.c:3518
#23 0xc021a680 in ?? ()
Fixes: 6675ef212da (PCI: spear: Fix Section mismatch compilation warning for
probe())
Signed-off-by: Matwey V. Kornilov
---
drivers/pci/host/pcie-spear13xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
2015-02-09 7:22 GMT+03:00 Viresh Kumar :
> On Sun, Feb 8, 2015 at 3:37 PM, Matwey V. Kornilov wrote:
>> spear13xx_pcie_driver.driver is allocated in text.init section
>> and then the pointer to it is passed futher. This patch is to avoid
>> crashes like the following, when
2015-02-09 16:11 GMT+03:00 Matwey V. Kornilov :
> 2015-02-09 7:22 GMT+03:00 Viresh Kumar :
>> On Sun, Feb 8, 2015 at 3:37 PM, Matwey V. Kornilov wrote:
>>> spear13xx_pcie_driver.driver is allocated in text.init section
>>> and then the pointer to it is passed fut
=-1225602132, flags=0) at
../kernel/module.c:3518
#23 0xc021a680 in ?? ()
Fixes: 6675ef212da (PCI: spear: Fix Section mismatch compilation warning for
probe())
Signed-off-by: Matwey V. Kornilov
---
drivers/pci/host/pcie-spear13xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Use platform_driver_probe instead of platform_driver_register
because the former allows us to use probe function placed into __init section
and the driver itself is not support hotplugging (yet?).
Signed-off-by: Matwey V. Kornilov
---
Changes from v1:
- Use platform_driver_probe instead of
2015-02-11 12:19 GMT+03:00 Stanimir Varbanov :
> please don't top posting.
>
> On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote:
>>
>> It sounds reasonable, but does current implementation support deferring?
>
>
> yes, it uses deferred probe see devm_phy_get() a
2015-02-13 5:08 GMT+03:00 Stanimir Varbanov :
> Hi,
>
> On 02/12/2015 11:07 AM, Matwey V. Kornilov wrote:
>> 2015-02-11 12:19 GMT+03:00 Stanimir Varbanov :
>>> please don't top posting.
>>>
>>> On 02/11/2015 10:38 AM, Matwey V. Kornilov wrote:HI
2015-01-21 19:51 GMT+03:00 Leopold Palomo-Avellaneda :
> finally this patch was applied?
This has been applied and it is available at 3.18+
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
--
To unsubscribe from this l
c02e0a44 in SYSC_finit_module (flags=, uargs=, fd=) at ../kernel/module.c:3537
#22 SyS_finit_module (fd=7, uargs=-1225602132, flags=0) at
../kernel/module.c:3518
#23 0xc021a680 in ?? ()
Signed-off-by: Matwey V. Kornilov
---
Changes from v2:
- Drop __init from all probing functions to allow defer
2015-02-20 13:06 GMT+03:00 Stanimir Varbanov :
> On 02/19/2015 07:41 PM, Matwey V. Kornilov wrote:
>> spear13xx_pcie_driver.driver is allocated in text.init section
>> and then the pointer to it is passed futher. This patch is to avoid
>> crashes like the following, when
Signed-off-by: Matwey V. Kornilov
---
drivers/of/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index b5e0c87..fdca685 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -85,7 +85,7 @@ config OF_RESOLVE
bool
2015-02-15 23:00 GMT+03:00 Paul Bolle :
> On Sun, 2015-02-15 at 18:22 +0300, Matwey V. Kornilov wrote:
>> Signed-off-by: Matwey V. Kornilov
>> ---
>> drivers/of/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/o
Add prompt for OF_OVERLAY config option to make in visible in menuconfig/xconfig
to make user be able to set or unset this option.
Signed-off-by: Matwey V. Kornilov
---
Changes from v1:
- Explanation commit message has been added to 1/2
- Add 2/2 (drop depends on OF) as suggested by
drivers
The whole menu already depends on OF, so there is no need to additionaly
specify it.
Suggested-by: Paul Bolle
Signed-off-by: Matwey V. Kornilov
---
drivers/of/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index fdca685..4831137 100644
--- a
ime when I tried to run my moxa PCI board with 3.1(?) and mxser
it deadlocked my PC from time to time.
8250_moxa implementation is much more cleaner.
>
> The problem is mxser supports ISA and PCI boards and I don't have the
> hardware to test it.
>
> Mathieu
--
With best regar
2016-03-24 11:03 GMT+03:00 :
> From: Yegor Yefremov
>
> When in half-duplex mode RX will be disabled before TX, but not
> enabled after deactivating transmitter. This patch enables
> UART_IER_RLSI and UART_IER_RDI interrupts after TX is over.
>
> Cc: Matwey V. Kornilov
&
Introduce new capability UART_CAP_HW485 to mark 8250 UARTs which have
hardware support of line direction control.
Signed-off-by: Matwey V. Kornilov
---
Changes since v1:
- Commit message has been wrapped
drivers/tty/serial/8250/8250.h | 1 +
drivers/tty/serial/8250/8250_fintek.c | 1
When 8250 driver doesn't have its own hardware RS485 support and doesn't
want to override rs485_config callback, then default
serial8250_rs485_config is used. It just stores supplied by user-space
config.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250_c
: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250_port.c | 32
1 file changed, 32 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
index 52d82d2..a9291f7 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b
2015-11-07 15:22 GMT+03:00 Peter Hurley :
> On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
>> Introduce new capability UART_CAP_HW485 to mark 8250 UARTs which have
>> hardware support of line direction control.
>
> Since capabilities are not exported to user-space, how will
2015-11-07 15:29 GMT+03:00 Peter Hurley :
> Hi Matwey,
>
> On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
>> When 8250 driver doesn't have its own hardware RS485 support and doesn't
>> want to override rs485_config callback, then default
>> serial8250
2015-11-07 18:32 GMT+03:00 Peter Hurley :
> On 11/07/2015 07:39 AM, Matwey V. Kornilov wrote:
>> 2015-11-07 15:22 GMT+03:00 Peter Hurley :
>>> On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
>>>> Introduce new capability UART_CAP_HW485 to mark 8250 UARTs which have
2015-11-07 19:03 GMT+03:00 Peter Hurley :
> Hi Matwey,
>
> On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
>> Implementation of software emulation of RS485 direction handling is based
>> on omap-serial driver. It is acts as the following. At transmission start,
>> R
2015-11-09 17:40 GMT+03:00 Peter Hurley :
> On 11/08/2015 05:52 AM, Matwey V. Kornilov wrote:
>> 2015-11-07 19:03 GMT+03:00 Peter Hurley :
>>> Hi Matwey,
>>>
>>> On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
>>>> Implementation of software emulat
2015-11-10 0:30 GMT+03:00 Peter Hurley :
> On 11/09/2015 10:45 AM, Matwey V. Kornilov wrote:
>> 2015-11-09 17:40 GMT+03:00 Peter Hurley :
>>> On 11/08/2015 05:52 AM, Matwey V. Kornilov wrote:
>>>> 2015-11-07 19:03 GMT+03:00 Peter Hurley :
>>>>> On
2015-11-10 1:05 GMT+03:00 Peter Hurley :
> On 11/09/2015 04:43 PM, Matwey V. Kornilov wrote:
>> 2015-11-10 0:30 GMT+03:00 Peter Hurley :
>>> On 11/09/2015 10:45 AM, Matwey V. Kornilov wrote:
>>>> 2015-11-09 17:40 GMT+03:00 Peter Hurley :
>>>>> On
2015-11-10 19:12 GMT+03:00 Peter Hurley :
> Hi Matwey,
>
> I noticed 3 other issues here; see below.
>
> On 11/07/2015 05:09 AM, Matwey V. Kornilov wrote:
>> Implementation of software emulation of RS485 direction handling is based
>> on omap-serial driver. It i
gt; to
> indicate that with a read-only bit. Naming it something else is fine too;
> SER_RS485_NOT_REALTIME_EOT?
>
> A more comprehensive approach might be to add a capabilities word
> to struct serial_rs485 which would allow the driver to report what
> it supports; eg. realtime turn
2015-11-17 12:24 GMT+03:00 Uwe Kleine-König :
> Hello,
>
> On Thu, Nov 12, 2015 at 05:33:56PM +0300, Matwey V. Kornilov wrote:
>> +static void serial8250_start_tx(struct uart_port *port)
>> +{
>> + struct uart_8250_port *up = up_to_u8250p(
вт, 2 июл. 2019 г. в 20:33, Bin Liu :
>
> Matwey,
>
> On Tue, Jul 02, 2019 at 08:29:03PM +0300, Matwey V. Kornilov wrote:
> > Ping?
>
> I was offline and just got back. I will review it soon. Sorry for the
> delay.
Ping?
>
> -Bin.
>
> >
> >
Hi Anton,
I hope you are doing good. Could you please check this patch, since
you are initial author of zynq-zturn.dts and I suppose you do have the
"v4" board variant to test.
вт, 28 апр. 2020 г. в 13:04, Matwey V. Kornilov :
>
> There are at least two different versions existin
пн, 9 сент. 2019 г. в 19:33, Matwey V. Kornilov :
>
> вт, 2 июл. 2019 г. в 20:33, Bin Liu :
> >
> > Matwey,
> >
> > On Tue, Jul 02, 2019 at 08:29:03PM +0300, Matwey V. Kornilov wrote:
> > > Ping?
> >
> > I was offline and just got back. I wil
not attach PHY (-19)
After the patch:
[ 28.257365] macb e000b000.ethernet eth0: PHY [e000b000.ethernet-:00]
driver [Micrel KSZ9031 Gigabit PHY] (irq=POLL)
[ 28.257384] macb e000b000.ethernet eth0: configuring for phy/rgmii-id link
mode
Signed-off-by: Matwey V. Kornilov
---
Changes
We assign "urb->hcpriv = qh;" a few lines down. The valid qh for the urb is
hep->hcpriv in this code path.
Fixes: 714bc5ef3eda ("musb: potential use after free")
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+),
By the way, why do we need to store the qh in urb->hcpriv?
qh can always be accessible through urb->ep->hcpriv
Wouldn't it be better to drop entire urb->hcpriv usage?
ср, 23 янв. 2019 г. в 20:52, Matwey V. Kornilov :
>
> We assign "urb->hcpriv = qh;" a few lin
вт, 30 апр. 2019 г. в 18:31, Bin Liu :
>
> Hi Greg and all devs,
>
> On Wed, Apr 03, 2019 at 09:53:10PM +0300, Matwey V. Kornilov wrote:
> > Previously, the algorithm was the following:
> >
> > 1. giveback current URB
> > 2. if current qh is not empty
&g
Closing angle bracket was missing.
Signed-off-by: Matwey V. Kornilov
---
drivers/power/reset/reboot-mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/reset/reboot-mode.c
b/drivers/power/reset/reboot-mode.c
index 06ff035b57f5..b4076b10b893 100644
--- a
Ping?
пт, 14 июн. 2019 г. в 19:47, Matwey V. Kornilov :
>
> The series is concerned to issues with isochronous transfer while
> streaming the USB webcam data. I discovered the issue first time
> when attached PWC USB webcam to AM335x-based BeagleBone Black SBC.
> It appeared that
("musb: potential use after free")
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index b59ce9ad14ce..a60d52c7e112 100644
--- a/drivers/usb/musb/m
"igb: Remove GS40G specific defines/functions")
Cc: # 4.5+
Signed-off-by: Matwey V. Kornilov
---
drivers/net/ethernet/intel/igb/e1000_82575.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.c
b/drivers/net/ethernet/intel/igb/e1000_82575.c
to do it soon. Your board is supported by mxser driver
> (drivers/tty/mxser.c).
> I think it would be nice to move everything from mxser.c to 8250_moxa.c.
>
> The problem is mxser supports ISA and PCI boards and I don't have the
> hardware to test it.
>
> Mathieu
rnel measures maxerror in usec and
ntpd does in nsec.
--
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2...@jabber.ru
_port.c | 12 ++--
> include/linux/serial_8250.h | 4
> include/linux/serial_core.h | 2 ++
> 5 files changed, 43 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonos
When struct moxa8250_board is allocated, then num_ports should
be initialized in order to use it later in moxa8250_remove.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250_moxa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/8250/8250_moxa.c
b/drivers
And actually S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH can be simplified
to S_IRUGO | S_IWUSR, not?
I think we need to have and use dedicated special macros for most
common magic octal permissions like 0755 or 0644.
2016-08-02 16:19 GMT+03:00 Matwey V. Kornilov :
> Hello,
>
> I believe tha
_array(probe_rsa, ulong, &probe_rsa_count, S_IRUSR | S_IRGRP |
> S_IROTH);
> MODULE_PARM_DESC(probe_rsa, "Probe I/O ports for RSA");
> #endif
> MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR);
> --
> 2.9.2
>
--
With best regards,
Matwey V. Kornilov.
Sternberg Astronomical Institute, Lomonosov Moscow State University, Russia
119991, Moscow, Universitetsky pr-k 13, +7 (495) 9392382
24.02.2016 22:10, Mathieu OTHACEHE пишет:
Add support for :
- CP-102E: 2 ports RS232 PCIE card
- CP-102EL: 2 ports RS232 PCIE card
- CP-132EL: 2 ports RS422/485 PCIE card
- CP-114EL: 4 ports RS232/422/485 PCIE card
- CP-104EL-A: 4 ports RS232 PCIE card
- CP-168EL-A: 8 ports RS232 PCIE card
- CP-
2016-03-07 16:03 GMT+03:00 Russell King - ARM Linux :
> On Mon, Mar 07, 2016 at 01:51:40PM +0100, Vlastimil Babka wrote:
>> [+CC ARM, module maintainers/lists]
>>
>> On 03/07/2016 12:14 PM, Matwey V. Kornilov wrote:
>> >
>> >Hello,
>> >
>> >
2016-02-11 19:40 GMT+03:00 Ильяс Гасанов :
> Hello,
>
> 2016-02-01 21:09 GMT+03:00 "Matwey V. Kornilov" :
>> +static int omap_8250_rs485_config(struct uart_port *port,
>> + struct serial_rs485 *rs485)
>> +{
>> + st
Fix possbile race in serial8250_em485_destroy() when timer handlers can
dereference p->em485 which is alread destroyed but not yet NULLed.
Signed-off-by: Matwey V. Kornilov
---
I've found that Greg applied initial patchset, so this erratum goes as separate
patch.
drivers/tty/ser
I am sorry, please ignore it. There is no issue actually. The timer
handlers and rs485_config callbacks are protected by the same
spinlock, so they are never run in parallel.
2016-02-11 22:32 GMT+03:00 Matwey V. Kornilov :
> Fix possbile race in serial8250_em485_destroy() when timer handlers
2016-02-11 23:19 GMT+03:00 Ильяс Гасанов :
> 2016-02-11 22:08 GMT+03:00 Matwey V. Kornilov :
>> Thanks for pointing out. serial8250_unregister_port should set
>> serial8250_ports[line].em485 to NULL in order to prevent unneeded
>> activation when this struct is reused.
&
el.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
--
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2...@jabber.ru
--
To unsubscribe from this list: send the line "unsubscribe linux-ke
and Matwey.
>
> I suggest you to ask people I added to the Cc list.
>
> On Sat, Dec 26, 2015 at 6:17 PM, Ильяс Гасанов wrote:
>> Hello.
>>
>> We are upgrading to the 4.1.x kernel for our smart metering appliance
>> project, which is based on TI's Sitara hardw
. Otherwise,
emultaion cannot be used.
Both serial8250_em485_init() and serial8250_em485_destroy() are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 2 +
drivers/tty/serial/8250/8250_port.c | 223 +++-
include/linux
Changes from v3:
- Completely redesigned.
Changes from v2:
- Introduced SER_RS485_SOFTWARE to show that software implementation is being
used
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_after timeouts
Signed-off-by: Matwey V. Kornilov
Use software emulated RS485 direction control to provide RS485 API
existed in omap_serial driver. Note that 8250_omap issues interrupt
on shift register empty which is single prerequesite for using software
emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
Software RS485 emultaion is to be added in the following commit.
serial8250_start_tx() will need to refer serial8250_stop_rx().
Move serial8250_stop_rx() in front of serial8250_start_tx() in order
to avoid function forward declaration.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial
Are there any other issues except empty changelog that I have to fix before v5?
2015-12-05 19:06 GMT+03:00 Greg KH :
> On Sat, Dec 05, 2015 at 01:54:49PM +0300, Matwey V. Kornilov wrote:
>> Signed-off-by: Matwey V. Kornilov
>
> Why?
>
> Please say so in the changelog.
>
Changes from v4:
- Add commit message to 1/3
Changes from v3:
- Completely redesigned.
Changes from v2:
- Introduced SER_RS485_SOFTWARE to show that software implementation is being
used
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_aft
Use software emulated RS485 direction control to provide RS485 API existed in
omap_serial driver. Note that 8250_omap issues interrupt on shift register
empty which is single prerequesite for using software emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
,
emultaion cannot be used.
Both serial8250_em485_init and serial8250_em485_destroy are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 6 ++
drivers/tty/serial/8250/8250_port.c | 161 +++-
include/linux
Software RS485 emultaion is to be added in the following commit.
serial8250_start_tx will need to refer serial8250_stop_rx.
Move serial8250_stop_rx in front of serial8250_start_tx in order
to avoid function forward declaration.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
2015-12-20 19:41 GMT+03:00 Andy Shevchenko :
> On Sat, Dec 12, 2015 at 1:23 PM, Matwey V. Kornilov wrote:
>> Implementation of software emulation of RS485 direction handling is based
>> on omap_serial driver.
>> Before and after transmission RTS is set to the appropriate v
- serial8250_rs485_config is located as required
- Timers are used to implement delay_before and delay_after timeouts
Signed-off-by: Matwey V. Kornilov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
,
emultaion cannot be used.
Both serial8250_em485_init and serial8250_em485_destroy are
idempotent functions.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250/8250.h | 6 ++
drivers/tty/serial/8250/8250_port.c | 161 +++-
include/linux
Use software emulated RS485 direction control to provide RS485 API existed in
omap_serial driver. Note that 8250_omap issues interrupt on shift register
empty which is single prerequesite for using software emulated RS485.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
Software RS485 emultaion is to be added in the following commit.
serial8250_start_tx will need to refer serial8250_stop_rx.
Move serial8250_stop_rx in front of serial8250_start_tx in order
to avoid function forward declaration.
Signed-off-by: Matwey V. Kornilov
---
drivers/tty/serial/8250
This function allows us to start arbitrary urb.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index 3a202a2a521d..ed99ecd4e63a 100644
Use USB_DIR_IN instead of 1 when calling musb_advance_schedule().
This is consistent with the rest of musb_host.c code and impoves
the readability.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb
In the following commit we introduce new musb_start_urb() function
which will be able to start arbitrary urb. In order to have
intuitive function names we rename musb_start_urb() to
musb_start_next_urb().
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 8
1 file
3] IN : 5.5
11.335007 d= 0.03 [ 33 + 6.750] [ 3] DATA0: 00 00
Removing this glitches makes us able to successfully run 10fps
video stream from the webcam attached via USB hub. That was
previously impossible.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.
Reduce the following similar snippets by using musb_qh_free().
qh->hep->hcpriv = NULL;
list_del(&qh->ring);
kfree(qh);
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 66 +---
1 file changed, 32 inse
Use musb_qh_empty() instead of &qh->hep->urb_list to avoid code
duplicating.
Signed-off-by: Matwey V. Kornilov
---
drivers/usb/musb/musb_host.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_ho
lows for faster
response.
References:
[1] https://www.spinics.net/lists/linux-usb/msg165735.html
[2] https://www.spinics.net/lists/linux-media/msg144279.html
Changes since v1:
- Patch 6 was redone to keep URB giveback order and stop transmission at
erroneous URB.
Matwey V. Kornilov (6):
ng
urb->callback() after setting MUSB_RXCSR_H_REQPKT for the
next urb if there is the next urb pending in queue.
[1] https://www.spinics.net/lists/linux-usb/msg145747.html
Fixes: f551e1352983 ("Revert "usb: musb: musb_host: Enable HCD_BH flag to
handle urb return in bottom half"&q
2017-04-27 18:35 GMT+03:00 Bin Liu :
> Hi Matwey,
>
> On Thu, Apr 27, 2017 at 01:20:33PM +0300, Matwey V. Kornilov wrote:
>> This commit changes the order of actions undertaken in
>> musb_advance_schedule() in order to overcome issue with broken
>> isochronous transfer
2017-04-27 20:13 GMT+03:00 Bin Liu :
> On Thu, Apr 27, 2017 at 07:26:31PM +0300, Matwey V. Kornilov wrote:
>> 2017-04-27 18:35 GMT+03:00 Bin Liu :
>> > Hi Matwey,
>> >
>> > On Thu, Apr 27, 2017 at 01:20:33PM +0300, Matwey V. Kornilov wrote:
>> >> Thi
which i
2017-04-28 14:58 GMT+03:00 Bin Liu :
> On Fri, Apr 28, 2017 at 10:04:30AM +0300, Matwey V. Kornilov wrote:
>> 2017-04-27 20:13 GMT+03:00 Bin Liu :
>> > On Thu, Apr 27, 2017 at 07:26:31PM +0300, Matwey V. Kornilov wrote:
>> >> 2017-04-27 18:35 GMT+03:
2017-04-28 15:43 GMT+03:00 Bin Liu :
> On Fri, Apr 28, 2017 at 03:13:55PM +0300, Matwey V. Kornilov wrote:
>> which i
>>
>> 2017-04-28 14:58 GMT+03:00 Bin Liu :
>> > On Fri, Apr 28, 2017 at 10:04:30AM +0300, Matwey V. Kornilov wrote:
>> >> 2017-04-27 20:
The issue is also present in 4.9.60-ti-r75
2017-11-04 17:05 GMT+03:00 Matwey V. Kornilov :
> Hi Bin,
>
> I've just checked that the issue is still present in 4.13.10.
>
> 2017-04-27 13:20 GMT+03:00 Matwey V. Kornilov :
>> This commit changes the orde
2017-11-16 19:32 GMT+03:00 Bin Liu :
> Hi,
>
> On Wed, Nov 15, 2017 at 06:19:08PM +0300, Matwey V. Kornilov wrote:
>> The issue is also present in 4.9.60-ti-r75
>>
>> 2017-11-04 17:05 GMT+03:00 Matwey V. Kornilov :
>> > Hi Bin,
>> >
>> > I'
2017-04-28 16:30 GMT+03:00 Bin Liu :
> On Fri, Apr 28, 2017 at 04:15:09PM +0300, Matwey V. Kornilov wrote:
>> 2017-04-28 15:43 GMT+03:00 Bin Liu :
>> > On Fri, Apr 28, 2017 at 03:13:55PM +0300, Matwey V. Kornilov wrote:
>> >> which i
>> >>
>> >&g
2017-04-29 11:16 GMT+03:00 Matwey V. Kornilov :
> 2017-04-28 16:30 GMT+03:00 Bin Liu :
>> On Fri, Apr 28, 2017 at 04:15:09PM +0300, Matwey V. Kornilov wrote:
>>> 2017-04-28 15:43 GMT+03:00 Bin Liu :
>>> > On Fri, Apr 28, 2017 at 03:13:55PM +0300, Matwey V. K
2017-04-29 17:24 GMT+03:00 Matwey V. Kornilov :
> 2017-04-29 11:16 GMT+03:00 Matwey V. Kornilov :
>> 2017-04-28 16:30 GMT+03:00 Bin Liu :
>>> On Fri, Apr 28, 2017 at 04:15:09PM +0300, Matwey V. Kornilov wrote:
>>>> 2017-04-28 15:43 GMT+03:00 Bin Liu :
>>>
101 - 192 of 192 matches
Mail list logo
