[patch 0/9] assorted fixes and cleanups

2007-08-09 Thread miklos
This is not really a patch series, just random pending stuff. None of it is 2.6.23 material I think. Thanks, Miklos -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[patch 1/9] unprivileged mounts: fix subtype handling

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Subtype handling was done in do_kern_mount(), but "unprivileged mounts: allow unprivileged mounts" patch made do_new_mount() use vfs_kern_mount(). This broke the filesystem subtype handling. Fix this by moving the subtype handling fr

[patch 2/9] VFS: check nanoseconds in utimensat

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> utimensat() (and possibly other callers of do_utimes()) didn't check if the nanosecond value was within the allowed range. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index:

[patch 4/9] exec: remove unnecessary check for MNT_NOEXEC

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> vfs_permission(MAY_EXEC) checks if the filesystem is mounted with "noexec", so there's no need to repeat this check in sys_uselib() and open_exec(). Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]>

[patch 6/9] fuse: clean up execute permission checking

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Define a new function fuse_refresh_attributes() that conditionally refreshes the attributes based on the validity timeout. In fuse_permission() only refresh the attributes for checking the execute bits if necessary. Signed-off-by: Miklos Szeredi &

[patch 5/9] fuse: fix setting i_mode bits

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> The patch titled "fuse: fix permission checking on sticky directories" removed all but the S_IFMT bits from i_mode. However some of these are unfortunately used by the VFS, such as the execute, suid and sgid bits. So only remove the stic

[patch 3/9] fix execute checking in permission()

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> permission() checks that MAY_EXEC is only allowed on regular files if at least one execute bit is set in the file mode. generic_permission() already ensures this, so the extra check in permission() is superfluous. If the filesystem defines it

[patch 7/9] clean out unused code in dentry pruning

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> It looks like in the end all pruners want parents removed. So remove unused code and function arguments. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux

[patch 9/9] fix warnings is revoked_inode.c

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Fix following warnings introduced by fs-introduce-write_begin-write_end-and-perform_write-aops-revoke.patch fs/revoked_inode.c:381: warning: ‘revoked_write_begin’ defined but not used fs/revoked_inode.c:388: warning: ‘revoked_write_end’ d

[patch 8/9] UML: remove unnecessary hostfs_getattr()

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Currently hostfs_getattr() just defines the default behavior. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/fs/hostfs/hostfs_kern.c === --- linux.or

[RFC PATCH 0/4] VFS updates

2007-08-09 Thread miklos
VFS tweaks needed for some FUSE features, but possibly useful to other filesystems as well. Comments are welcome. -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-inf

[RFC PATCH 3/4] allow filesystems to implement atomic open+truncate

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a new attribute flag ATTR_OPEN, with the meaning: "truncation was initiated by open() due to the O_TRUNC flag". This way filesystems wanting to implement truncation within their ->open() method can ignore such truncate request

[RFC PATCH 1/4] pass open file to ->setattr()

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Pass the open file into the filesystem's ->setattr() method for fchmod, fchown and some of the utimes variants. This is needed to be able to correctly implement open-unlink-fsetattr semantics in some filesystem such as sshfs, without havin

[RFC PATCH 4/4] VFS: allow filesystem to override mknod capability checks

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Add a new filesystem flag, that results in the VFS not checking if the current process has enough privileges to do an mknod(). This is needed on filesystems, where an unprivileged user may be able to create a device node, without causing security pr

[RFC PATCH 2/4] pass open file to ->getattr()

2007-08-09 Thread miklos
From: Miklos Szeredi <[EMAIL PROTECTED]> Pass the open file into the filesystem's ->getattr() method for fstat(). This is needed to be able to correctly implement open-unlink-fstat semantics in some filesystem such as sshfs, without having to resort to "silly-renaming&quo

Re: [PATCH 1/2] autofs4: allow autofs to work outside the initial PID namespace

2012-11-26 Thread Miklos Szeredi
me userspace entity (autofs) and copying it to the new namespace or to some other part of the tree makes no sense since a new instance of the userspace entity responsible for managing those mounts will need to be started in the new namespace as well. I can't think of any other sane solution to

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-18 Thread Miklos Szeredi
s to clean up the security uglilness and optimize storage. But I think the most important aspect is the userspace interface and I'm far from sure that a new filetype is the best solution here. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-19 Thread Miklos Szeredi
s become visible and similar fun. Far from likely to happen, but ... Add a rename-with-whiteout primitive on filesystems? That one is not going to be as simple as plain whiteout. Or? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-19 Thread Miklos Szeredi
On Tue, Mar 19, 2013 at 12:04 PM, David Howells wrote: > Miklos Szeredi wrote: > >> > BTW, I wonder what's the right locking for that sucker; overlayfs is >> > probably too heavy - we are talking about copying a file from one fs to >> > another, which can ob

Re: [PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-19 Thread Miklos Szeredi
On Tue, Mar 19, 2013 at 6:03 PM, Al Viro wrote: > On Tue, Mar 19, 2013 at 11:29:41AM +0100, Miklos Szeredi wrote: > >> Copy up is a once-in-a-lifetime event for an object. Optimizing it is >> way down in the list of things to do. I'd drop splice in a jiffy if >> it

Re: [PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-20 Thread Miklos Szeredi
outs and various overlay-specific flags to filesystem code. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: User-triggerable WARNING with fuse

2013-02-04 Thread Miklos Szeredi
thinks it matters in this case. > Thanks, the attached patch should fix it. Miklos fuse-dont-warn-when-nlink-is-zero.patch Description: Binary data

Re: [PATCH] fuse: make fuse daemon frozen along with kernel threads

2013-02-06 Thread Miklos Szeredi
our patch looks like it won't work on most of the unprivileged fuse filesystems which use the fusermount(1) helper to perform the actual mounting. Thanks, Miklos (*) setting this flag for other than the current process should, I think, be a privileged operation, otherwise it might

Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads

2013-02-06 Thread Miklos Szeredi
areful audit (or nscd might mark itself PF_FREEZE_DAEMON for that reason). And that's just an example of a most basic C library function. There are many more such hidden interactions that can trip up this scheme. Thanks, Miklos -- To unsubscribe from this list: send the line

Re: [PATCH 0/3] fuse: fix accounting background requests

2013-02-06 Thread Miklos Szeredi
ckground processing, > the processing ends in request_end() where another wakeup happens an so on. Thanks. These patches look okay. But they don't apply to for-next. Can you please update them? Thanks, Miklos > > Thanks, > Maxim > > --- > > Maxim Patlasov (3): >

Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads

2013-02-07 Thread Miklos Szeredi
[CC list restored] On Thu, Feb 7, 2013 at 9:41 AM, Goswin von Brederlow wrote: > On Wed, Feb 06, 2013 at 10:27:40AM +0100, Miklos Szeredi wrote: >> On Wed, Feb 6, 2013 at 2:11 AM, Li Fei wrote: >> > >> > There is well known issue that freezing will fail in case that

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-11 Thread Miklos Szeredi
r...] > > Again, I'm not sure what you mean. > > Are you trying to say that it would be OK to freeze user space tasks in > the D state? I think that's what Pavel is saying. Processes in D state sleeping on non-device mutexes _are_ actually OK to freeze. And that would nicel

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-11 Thread Miklos Szeredi
On Mon, Feb 11, 2013 at 1:08 PM, Rafael J. Wysocki wrote: > On Monday, February 11, 2013 11:11:40 AM Miklos Szeredi wrote: >> On Mon, Feb 11, 2013 at 12:31 AM, Rafael J. Wysocki wrote: >> > On Sunday, February 10, 2013 07:55:05 PM Pavel Machek wrote: >> >>

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-12 Thread Miklos Szeredi
On Tue, Feb 12, 2013 at 11:46 AM, Pavel Machek wrote: > (After all, with FUSE, filesystem clients are just doing IPC. In ideal > world, that would be freezeable and killable with -9). Exactly. Attaching a patch > > Pavel >

Re: Getting rid of freezer for suspend [was Re: [fuse-devel] [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-12 Thread Miklos Szeredi
On Tue, Feb 12, 2013 at 2:13 PM, Miklos Szeredi wrote: > On Tue, Feb 12, 2013 at 11:46 AM, Pavel Machek wrote: > >> (After all, with FUSE, filesystem clients are just doing IPC. In ideal >> world, that would be freezeable and killable with -9). > > Exactly. > > At

Re: [PATCH 06/14] fuse: Trust kernel i_size only - v2

2013-01-29 Thread Miklos Szeredi
On Fri, Jan 25, 2013 at 7:22 PM, Maxim V. Patlasov wrote: > Make fuse think that when writeback is on the inode's i_size is always > up-to-date and not update it with the value received from the userspace. > This is done because the page cache code may update i_size without letting > the FS know.

Re: [PATCH 07/14] fuse: Update i_mtime on buffered writes

2013-01-29 Thread Miklos Szeredi
;update_time(), which sets the FUSE_I_MTIME_UPDATED flag and flush mtime just like you do now. Except now it doesn't need to take i_mutex since all mtime updates are now done by the kernel. Does that make sense? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 08/14] fuse: Flush files on wb close

2013-01-29 Thread Miklos Szeredi
_finish(struct fuse_conn *fc, > struct fuse_req *req) > } > bdi_writeout_inc(bdi); > wake_up(&fi->page_waitq); > + if (fc->writeback_cache) > + __fuse_file_put(req->ff); > } I don't see how this belongs in this

Re: [PATCH 09/14] fuse: Implement writepages and write_begin/write_end callbacks - v2

2013-01-29 Thread Miklos Szeredi
On Fri, Jan 25, 2013 at 7:25 PM, Maxim V. Patlasov wrote: > The .writepages one is required to make each writeback request carry more than > one page on it. > > Changed in v2: > - fixed fuse_prepare_write() to avoid reads beyond EOF > - fixed fuse_prepare_write() to zero uninitialized part of pa

Re: [PATCH v2 00/14] fuse: An attempt to implement a write-back cache policy

2013-01-25 Thread Miklos Szeredi
anch of the fuse tree. I see that you have some other patchsets pending. Are they independent? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

[GIT PULL] fuse updates for 3.9

2013-02-20 Thread Miklos Szeredi
d various fixes and cleanups. There's a one line change outside of fuse to mm/filemap.c which makes the argument of iov_iter_single_seg_count() const, required by Maxim's patches. Thanks, Miklos Anand V. Avati (1): fuse: implement NFS-like readdirplus support Anatol Pomozov

Re: [fuse-devel] Getting rid of freezer for suspend [was Re: [PATCH] fuse: make fuse daemon frozen along with kernel threads]

2013-02-20 Thread Miklos Szeredi
t ordinary userspace processes, and so should be frozen before kernel threads. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-12 Thread Miklos Szeredi
eredi/vfs.git overlayfs.v16 Thanks, Miklos --- Andy Whitcroft (3): overlayfs-add-statfs-support ovl-switch-to-inode_permission overlayfs-copy-up-i_uid-i_gid-from-the-underlying-inode Erez Zadok (1): overlayfs-implement-show_options Miklos Szeredi (6): vfs-add

[PATCH 03/13] vfs-introduce-clone_private_mount

2013-03-12 Thread Miklos Szeredi
From: Miklos Szeredi Overlayfs needs a private clone of the mount, so create a function for this and export to modules. Signed-off-by: Miklos Szeredi --- fs/namespace.c| 18 ++ include/linux/mount.h |3 +++ 2 files changed, 21 insertions(+) diff --git a/fs

[PATCH 09/13] overlayfs-fix-possible-leak-in-ovl_new_inode

2013-03-12 Thread Miklos Szeredi
From: Robin Dong After allocating a new inode, if the mode of inode is incorrect, we should release it by iput(). Signed-off-by: Robin Dong Signed-off-by: Miklos Szeredi --- fs/overlayfs/inode.c |1 + 1 file changed, 1 insertion(+) diff --git a/fs/overlayfs/inode.c b/fs/overlayfs

[PATCH 11/13] vfs-export-inode_permission-to-modules

2013-03-12 Thread Miklos Szeredi
From: Miklos Szeredi We need to be able to check inode permissions (but not filesystem implied permissions) for stackable filesystems. Expose this interface for overlayfs. Signed-off-by: Miklos Szeredi --- fs/internal.h |5 - fs/namei.c |1 + include/linux/fs.h

[PATCH 13/13] overlayfs-copy-up-i_uid-i_gid-from-the-underlying-inode

2013-03-12 Thread Miklos Szeredi
it. BugLink: http://bugs.launchpad.net/bugs/944386 Signed-off-by: Andy Whitcroft Signed-off-by: Miklos Szeredi --- fs/overlayfs/dir.c |2 ++ fs/overlayfs/inode.c |2 ++ fs/overlayfs/overlayfs.h |6 ++ fs/overlayfs/super.c |1 + 4 files changed, 11 insertions(+

[PATCH 02/13] vfs-export-do_splice_direct-to-modules

2013-03-12 Thread Miklos Szeredi
From: Miklos Szeredi Export do_splice_direct() to modules. Needed by overlay filesystem. Signed-off-by: Miklos Szeredi --- fs/splice.c |1 + 1 file changed, 1 insertion(+) diff --git a/fs/splice.c b/fs/splice.c index 718bd00..0e8f44a 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -1308,6

[PATCH 06/13] overlayfs-implement-show_options

2013-03-12 Thread Miklos Szeredi
From: Erez Zadok This is useful because of the stacking nature of overlayfs. Users like to find out (via /proc/mounts) which lower/upper directory were used at mount time. Signed-off-by: Erez Zadok Signed-off-by: Miklos Szeredi --- fs/overlayfs/super.c | 63

[PATCH 05/13] overlayfs-add-statfs-support

2013-03-12 Thread Miklos Szeredi
were not expecting, but it is better than nothing. Use the upper layer dentry and mount from the overlayfs root inode, passing the statfs call to that filesystem. Signed-off-by: Andy Whitcroft Signed-off-by: Miklos Szeredi --- fs/overlayfs/super.c | 40 1

[PATCH 12/13] ovl-switch-to-inode_permission

2013-03-12 Thread Miklos Szeredi
restricted files. Switch over to __inode_permissions. Signed-off-by: Andy Whitcroft Signed-off-by: Miklos Szeredi --- fs/overlayfs/inode.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c index 033de6f..3218a38 100644 --- a/fs

[PATCH 10/13] overlayfs-create-new-inode-in-ovl_link

2013-03-12 Thread Miklos Szeredi
ount", the result is not the same. In order to make the behavior coherent, we need to create inode in ovl_link. Signed-off-by: Robin Dong Signed-off-by: Miklos Szeredi --- fs/overlayfs/dir.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/overlayfs/dir.c b/fs/

[PATCH 08/13] fs-limit-filesystem-stacking-depth

2013-03-12 Thread Miklos Szeredi
From: Miklos Szeredi Add a simple read-only counter to super_block that indicates deep this is in the stack of filesystems. Previously ecryptfs was the only stackable filesystem and it explicitly disallowed multiple layers of itself. Overlayfs, however, can be stacked recursively and also may

[PATCH 07/13] overlay-overlay-filesystem-documentation

2013-03-12 Thread Miklos Szeredi
From: Neil Brown Document the overlay filesystem. Signed-off-by: Miklos Szeredi --- Documentation/filesystems/overlayfs.txt | 199 +++ MAINTAINERS |7 ++ 2 files changed, 206 insertions(+) create mode 100644 Documentation

[PATCH 01/13] vfs-add-i_op-dentry_open

2013-03-12 Thread Miklos Szeredi
From: Miklos Szeredi Add a new inode operation i_op->dentry_open(). This is for stacked filesystems that want to return a struct file from a different filesystem. Signed-off-by: Miklos Szeredi --- Documentation/filesystems/Locking |2 ++ Documentation/filesystems/vfs.txt |

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-12 Thread Miklos Szeredi
On Tue, Mar 12, 2013 at 5:49 PM, Sedat Dilek wrote: > > What happened to the subject lines (see v15)? > Oops, will fix. Thanks. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-12 Thread Miklos Szeredi
On Tue, Mar 12, 2013 at 6:22 PM, J. R. Okajima wrote: > > Miklos Szeredi: >> Please consider overlayfs for inclusion into 3.10. > > Thank you for CCing me. > > First, I'd suggest you to follow some recent activities in mainline > kernel such as > - MODULE_ALIA

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-13 Thread Miklos Szeredi
On Wed, Mar 13, 2013 at 11:09 AM, Sedat Dilek wrote: > On Tue, Mar 12, 2013 at 4:41 PM, Miklos Szeredi wrote: >> Al and Linus, >> >> Please consider overlayfs for inclusion into 3.10. >> >> It's included in Ubuntu and openSUSE, used by OpenWrt and vario

[PATCH 3/9] vfs: export __inode_permission() to modules

2013-03-13 Thread Miklos Szeredi
From: Miklos Szeredi We need to be able to check inode permissions (but not filesystem implied permissions) for stackable filesystems. Expose this interface for overlayfs. Signed-off-by: Miklos Szeredi --- fs/internal.h |5 - fs/namei.c |1 + include/linux/fs.h

[PATCH 7/9] overlayfs: implement show_options

2013-03-13 Thread Miklos Szeredi
From: Erez Zadok This is useful because of the stacking nature of overlayfs. Users like to find out (via /proc/mounts) which lower/upper directory were used at mount time. Signed-off-by: Erez Zadok Signed-off-by: Miklos Szeredi --- fs/overlayfs/super.c | 63

[PATCH 6/9] overlayfs: add statfs support

2013-03-13 Thread Miklos Szeredi
were not expecting, but it is better than nothing. Use the upper layer dentry and mount from the overlayfs root inode, passing the statfs call to that filesystem. Signed-off-by: Andy Whitcroft Signed-off-by: Miklos Szeredi --- fs/overlayfs/dir.c |2 ++ fs/overlayfs/inode.c |2

[PATCH 9/9] fs: limit filesystem stacking depth

2013-03-13 Thread Miklos Szeredi
From: Miklos Szeredi Add a simple read-only counter to super_block that indicates deep this is in the stack of filesystems. Previously ecryptfs was the only stackable filesystem and it explicitly disallowed multiple layers of itself. Overlayfs, however, can be stacked recursively and also may

[PATCH 8/9] overlay: overlay filesystem documentation

2013-03-13 Thread Miklos Szeredi
From: Neil Brown Document the overlay filesystem. Signed-off-by: Miklos Szeredi --- Documentation/filesystems/overlayfs.txt | 199 +++ MAINTAINERS |7 ++ 2 files changed, 206 insertions(+) create mode 100644 Documentation

[PATCH 1/9] vfs: add i_op->dentry_open()

2013-03-13 Thread Miklos Szeredi
From: Miklos Szeredi Add a new inode operation i_op->dentry_open(). This is for stacked filesystems that want to return a struct file from a different filesystem. Signed-off-by: Miklos Szeredi --- Documentation/filesystems/Locking |2 ++ Documentation/filesystems/vfs.txt |

[PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-13 Thread Miklos Szeredi
here: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.current Thanks, Miklos --- Andy Whitcroft (1): overlayfs: add statfs support Erez Zadok (1): overlayfs: implement show_options Miklos Szeredi (6): vfs: add i_op->dentry_open() vfs

[PATCH 4/9] vfs: introduce clone_private_mount()

2013-03-13 Thread Miklos Szeredi
From: Miklos Szeredi Overlayfs needs a private clone of the mount, so create a function for this and export to modules. Signed-off-by: Miklos Szeredi --- fs/namespace.c| 18 ++ include/linux/mount.h |3 +++ 2 files changed, 21 insertions(+) diff --git a/fs

[PATCH 2/9] vfs: export do_splice_direct() to modules

2013-03-13 Thread Miklos Szeredi
From: Miklos Szeredi Export do_splice_direct() to modules. Needed by overlay filesystem. Signed-off-by: Miklos Szeredi --- fs/splice.c |1 + 1 file changed, 1 insertion(+) diff --git a/fs/splice.c b/fs/splice.c index 718bd00..0e8f44a 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -1308,6

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-13 Thread Miklos Szeredi
t(ovl_init); > module_exit(ovl_exit); > +MODULE_DESCRIPTION("overlayfs v17: provides overlay-filesystem > functionality"); > +MODULE_AUTHOR("Miklos Szeredi "); > +MODULE_LICENSE("GPL"); No, it *is* already in there. Thanks, Miklos -- To unsubscribe f

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-13 Thread Miklos Szeredi
id, do you plan to send out the series for review sometime? > Oh, and the third one - I still owe you a bottle of your choice for sorting > the atomic_open shite out. Is there any chance you'll be able to attend > LSFS this year? Can't make it this year. But I do plan to go

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-13 Thread Miklos Szeredi
#x27;t. It's not compulsory and not very useful. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-13 Thread Miklos Szeredi
s to be done more carefully, only actually revealing the copied up dentry once the setattr operation has completed successfully. > > * ->follow_link(): Why the hell do you bother with struct ovl_link_data??? > Just to avoid calling ovl_dentry_real() in ovl_put_link()? Yes, a copy-up between ovl_fo

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v16)

2013-03-14 Thread Miklos Szeredi
On Thu, Mar 14, 2013 at 12:19 AM, Al Viro wrote: > On Wed, Mar 13, 2013 at 11:09:07PM +0100, Miklos Szeredi wrote: >> As for same upper on unrelated lower: just don't do it. As I said, we >> could enforce this, but I don't think this is top priority. > > Tell that

Re: [PATCH 1/9] vfs: add i_op->dentry_open()

2013-03-14 Thread Miklos Szeredi
On Wed, Mar 13, 2013 at 11:44 PM, Andrew Morton wrote: > On Wed, 13 Mar 2013 15:16:25 +0100 Miklos Szeredi wrote: > >> From: Miklos Szeredi >> >> Add a new inode operation i_op->dentry_open(). This is for stacked >> filesystems >> that want to return a

Re: [PATCH 4/9] vfs: introduce clone_private_mount()

2013-03-14 Thread Miklos Szeredi
On Wed, Mar 13, 2013 at 11:48 PM, Andrew Morton wrote: > On Wed, 13 Mar 2013 15:16:28 +0100 Miklos Szeredi wrote: > >> From: Miklos Szeredi >> >> Overlayfs needs a private clone of the mount, so create a function for >> this and export to modules. &g

Re: [PATCH 8/9] overlay: overlay filesystem documentation

2013-03-14 Thread Miklos Szeredi
On Thu, Mar 14, 2013 at 12:06 AM, Andrew Morton wrote: > On Wed, 13 Mar 2013 15:16:32 +0100 Miklos Szeredi wrote: > >> From: Neil Brown >> >> Document the overlay filesystem. >> > > Damn, I did it again. This is good, thanks. > >> +Changes to the u

Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17)

2013-03-14 Thread Miklos Szeredi
On Thu, Mar 14, 2013 at 12:08 AM, Andrew Morton wrote: > On Wed, 13 Mar 2013 15:16:24 +0100 Miklos Szeredi wrote: > >> Here's another version with the comments addressed plus a small bugfix and >> some >> checkpatch cleanups. > > It all looks nice to my ru

Re: [PATCH] fuse: mark variables uninitialized

2012-08-28 Thread Miklos Szeredi
urn non-zero unless the &val > is modified, so the warning is misleading. Let the compiler know > about it by marking 'val' with 'uninitialized_var'. Thanks, applied. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 05/13] overlayfs: add statfs support

2012-08-29 Thread Miklos Szeredi
Ben Hutchings writes: > On Wed, Aug 15, 2012 at 05:48:12PM +0200, Miklos Szeredi wrote: >> From: Andy Whitcroft >> >> Add support for statfs to the overlayfs filesystem. As the upper layer >> is the target of all write operations assume that the space in that >&g

Re: [PATCH 08/13] fs: limit filesystem stacking depth

2012-09-03 Thread Miklos Szeredi
up" is the most stack hungry operation, it may be worth trying to reduce its stack usage. Thanks, Miklos --- global rec_level, stacks probe kernel.function("ovl_permission"), kernel.function("ovl_getattr"), kernel.function("ovl_dir_getatt

Re: [RFC PATCH 0/2] issues with NFS filesystems as lower layer

2012-09-11 Thread Miklos Szeredi
r user on the > same system? Ignoring ACL's should always give less access, isn't that right? > > Is it possible to arrange that the check for a readonly filesystem be > done only by the vfs and not also by ->permission? You'd need to modify NFS servers for that to

Re: [RFC PATCH 0/2] issues with NFS filesystems as lower layer

2012-09-12 Thread Miklos Szeredi
"J. Bruce Fields" writes: > On Tue, Sep 11, 2012 at 10:56:52PM +0200, Miklos Szeredi wrote: >> "J. Bruce Fields" writes: >> >> >> > Secondly when using an NFSv3 R/O lower layer the filesystem permissions >> >> > chec

Re: [PATCH 1/6] fuse: general infrastructure for pages[] of variable size

2012-09-12 Thread Miklos Szeredi
Maxim Patlasov writes: > The patch removes inline array of FUSE_MAX_PAGES_PER_REQ page pointers from > fuse_req. Instead of that, req->pages may now point either to small inline > array or to an array allocated dynamically. > > This essentially means that all callers of fuse_request_alloc[_nofs]

Re: [PATCH 2/6] fuse: categorize fuse_get_req()

2012-09-12 Thread Miklos Szeredi
ther cases. I think you are overcomplicating this. Just have two functions: fuse_get_req_nopages() and fuse_get_req(). I don't think the _onepage variant deserves a separate helper. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 3/6] fuse: rework fuse_retrieve()

2012-09-12 Thread Miklos Szeredi
Maxim Patlasov writes: > The patch reworks fuse_retrieve() to allocate only so many page pointers > as needed. The core part of the patch is the following calculation: > > num_pages = (num + offset + PAGE_SIZE - 1) >> PAGE_SHIFT; > > (thanks Miklos for formula

Re: [PATCH 4/6] fuse: rework fuse_readpages()

2012-09-12 Thread Miklos Szeredi
Maxim Patlasov writes: > The patch uses 'nr_pages' argument of fuse_readpages() as the heuristics for > number of page pointers to allocate. > > This can be improved further by taking in consideration fc->max_read and gaps > between page indices, but it's not clear wheteher it's worthy or not. >

Re: [PATCH 5/6] fuse: rework fuse_perform_write()

2012-09-12 Thread Miklos Szeredi
Maxim Patlasov writes: > The patch allocates as many page pointers in fuse_req as needed to cover > interval [pos .. pos+len-1]. FUSE_WR_PAGES macro is introduced to hide this > cumbersome arithmetics. Please don't ever use a macro for something which you can use an inline function. > --- > fs

Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically

2012-09-12 Thread Miklos Szeredi
"Maxim V. Patlasov" writes: > Hi Miklos, > > So far as no objections appeared, I'll go ahead and replace fuse req->page > with > req->pagevec. It will point to an array of structs: > > struct page_vec { > struct page*pv_page; > unsigne

Re: [PATCH 0/6] fuse: allocate req->pages[] dynamically

2012-09-14 Thread Miklos Szeredi
"Maxim V. Patlasov" writes: > Hi Miklos, > > 09/12/2012 08:49 PM, Miklos Szeredi пишет: >> "Maxim V. Patlasov" writes: >> >>> Hi Miklos, >>> >>> So far as no objections appeared, I'll go ahead and replace fuse r

Re: [patch] vfs: create /proc//mountinfo

2008-01-31 Thread Miklos Szeredi
t I think this is implicit in all of the multi-fields-per-line formats, and I'm quite confident all sane parsers already ignore unknown junk at the end of a line. > > > > > [EMAIL PROTECTED] > > > > - new file, rearrange fields > > - for mount ID's u

Re: [patch 2/6] mm: bdi: export BDI attributes in sysfs

2008-01-31 Thread Miklos Szeredi
> On Tue, 29 Jan 2008 16:49:02 +0100 > Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > From: Peter Zijlstra <[EMAIL PROTECTED]> > > > > Provide a place in sysfs (/sys/class/bdi) for the backing_dev_info > > object. This allows us to see a

Re: [patch 6/6] mm: bdi: allow setting a maximum for the bdi dirty limit

2008-01-31 Thread Miklos Szeredi
> On Tue, 29 Jan 2008 16:49:06 +0100 > Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > > Add "max_ratio" to /sys/class/bdi. This indicates the maximum > > percentage of the global dirty threshold allocated to this bdi. > > Maybe I'm having a stu

Re: [patch 01/26] mount options: add documentation

2008-01-31 Thread Miklos Szeredi
;m=119362955431694&w=2 > > So, with this patch mount(8) needn't to maintain info about loops and > umount(8) doesn't need to call LOOP_CLR_FD ioctl, because umount(2) > is enough. Excellent! This is a very good example how moving a functionality into the kernel can grea

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-01 Thread Miklos Szeredi
lesystems. We can't just say, fix the broken servers, especially not with FUSE, where the server is totally untrusted. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-01 Thread Miklos Szeredi
E, this > > goes into an infinite loop. How are we planning to deal with that? > > > > > > Would you describe the situation that would cause the kernel to > go into an infinite loop, please? The patch basically does: do { ... er

Re: [PATCH 2/3] enhanced syscall ESTALE error handling (v2)

2008-02-02 Thread Miklos Szeredi
lly. There might be installed systems that rely on current behavior, and we want to avoid breaking those on a kernel upgrade. A few solutions come to mind, perhaps the best is to introduce a kernel internal errno value (ERETRYSTALE), that forces the relevant system calls to be retried. NFS coul

Re: [PATCH] Allow NBD to be used locally

2008-02-02 Thread Miklos Szeredi
not impossible: throttle_vm_writeout() can stall an allocation until pending writes have completed, all with plenty of memory available in the system. BTW, you can basically substitute local NBD with fuse-over-loop, and get a similar kind of service, with similar problems. Miklos -- To unsubscri

[patch 2/3] mm: bdi: use MAJOR:MINOR in /sys/class/bdi

2008-02-02 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Uniformly use MAJOR:MINOR in /sys/class/bdi/ for both block devices and non-block device backed filesystems: FUSE and NFS. Add symlink for block devices: /sys/block//bdi -> /sys/class/bdi/ Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]

[patch 3/3] mm: bdi: move statistics to debugfs

2008-02-02 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Move BDI statistics to debugfs: /sys/kernel/debug/bdi//stats Use postcore_initcall() to initialize the sysfs class and debugfs, because debugfs is initialized in core_initcall(). Update descriptions in ABI documentation. Signed-off-by:

[patch 1/3] mm: bdi: fix read_ahead_kb_store()

2008-02-02 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> This managed to completely evade testing :( Fix return value to be count or -errno. Also bring the function in line with the other store functions on this object, which have more strict input checking. Also fix bdi_set_max_ratio() to actually ret

[patch 0/3] mm: bdi: updates

2008-02-02 Thread Miklos Szeredi
also done some testing, and fixed some bugs. Including patches in -mm can do wonders, even before the kernel containing them is released :) Let me know if you prefer a resubmission of the original series with these changes folded in. Thanks, Miklos -- -- To unsubscribe from this list: send the li

[patch 2/3] mm: Add NR_WRITEBACK_TEMP counter

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Fuse will use temporary buffers to write back dirty data from memory mappings (normal writes are done synchronously). This is needed, because there cannot be any guarantee about the time in which a write will complete. By using temporary buffers

[patch 1/3] mm: bdi: export bdi_writeout_inc()

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Fuse needs this for writable mmap support. Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/include/linux/backing-dev.h === --- linux.orig/include/linux/b

[patch 3/3] fuse: support writable mmap

2008-02-04 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> Quoting Linus (3 years ago, FUSE inclusion discussions): "User-space filesystems are hard to get right. I'd claim that they are almost impossible, unless you limit them somehow (shared writable mappings are the nastiest part - i

[patch 0/3] fuse: writable mmap

2008-02-04 Thread Miklos Szeredi
that depends on whether the bdi things go). Thanks, Miklos -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[patch 1/3] vfs: introduce perform_write in a_ops

2008-02-04 Thread Miklos Szeredi
ecache. For some filesystems, using this can provide significant speedups. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Signed-off-by: Miklos Szeredi <[EMAIL PROTECTED]> --- Index: linux/include/linux/fs.h === --- linux.

  1   2   3   4   5   6   7   8   9   10   >