RE: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
> Also cache misses in this situation tend to be much more than 48 cycles > (even an K8 with integrated memory controller with fastest DIMMs is > slower than that) Mathieu probably measured an L2 miss, not a load from > RAM. > Load from RAM can be hundreds of ns in the worst case. > The 48 cycle

RE: [patch 10/10] Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
> I found that memory latency is difficult to measure in modern x86 > CPUs because they have very clever prefetchers that can often > outwit benchmarks. A pointer-chasing program that accesses a random sequence of addresses usually can produce a good estimate on memory latency. Also, prefetching c

RE: [patch 10/10] *Tests* Scheduler profiling - Use immediate values

2007-07-06 Thread Li, Tong N
cycles_per_iter += (time2 - time1)/(double)NR_ITER; > } > cycles_per_iter /= (double)NR_TESTS; > printf("Just getting the pointer, doing noting with it, cycles per > iteration (mean) : %g\n", cycles_per_iter); > Some comments on the code: 1.

[PATCH] Kprobes on select architectures no longer EXPERIMENTAL

2007-07-09 Thread Ananth N Mavinakayanahalli
From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> Based on usage and testing over the past couple of years, kprobes on i386, ia64, powerpc and x86_64 is no longer EXPERIMENTAL. This is a follow-up to Robert P.J. Day's patch making "Instrumentation support" non-EXPERI

Re: [PATCH 1/12] drivers/isdn/hisax/avm_pci.c: replace pci_find_device with pci_get_device

2007-07-15 Thread Surya Prabhakar N
On Sun, 2007-07-15 at 03:40 -0400, Jeff Garzik wrote: > To be more clear, your solution is incorrect unless the pci_dev_put() > occurs after the last reference to hw.{elsa,diva,hfc,njet,...}.dev, > which is where the HiSax ISDN drivers store their reference to struct > pci_dev during the runtime

RE: Re: [ANNOUNCE][RFC] PlugSched-6.5.1 for 2.6.22

2007-07-15 Thread Li, Tong N
> On Thursday 12 July 2007 00:17, Al Boldi wrote: > > > Peter Williams wrote: > >> > >> Probably the last one now that CFS is in the main line :-(. > > > > What do you mean? A pluggable scheduler framework is indispensible even > in > > the presence of CFS or SD. > > Indeed, and I hope it gets m

RE: Re: [ANNOUNCE][RFC] PlugSched-6.5.1 for 2.6.22

2007-07-15 Thread Li, Tong N
> -Original Message- > From: Adrian Bunk [mailto:[EMAIL PROTECTED] > Sent: Sunday, July 15, 2007 4:46 PM > To: Li, Tong N > Cc: Giuseppe Bilotta; linux-kernel@vger.kernel.org > Subject: Re: Re: [ANNOUNCE][RFC] PlugSched-6.5.1 for 2.6.22 > > On Sun, Jul 15, 2007

Drop patch update-isdn-tree-to-use-pci_get_device.patch from -mm tree

2007-07-15 Thread Surya Prabhakar N
Hi Andrew, I would request you to drop the patch update-isdn-tree-to-use-pci_get_device.patch from the -mm tree since a new bug is been identified in that by jeff. thanks. surya. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTEC

Re: [patch 1/8] Kprobes - do not use kprobes mutex in arch code

2007-07-16 Thread Ananth N Mavinakayanahalli
On Sat, Jul 14, 2007 at 03:20:02PM -0400, Mathieu Desnoyers wrote: > * Christoph Hellwig ([EMAIL PROTECTED]) wrote: > > On Fri, Jul 13, 2007 at 09:21:34PM -0400, Mathieu Desnoyers wrote: > > > Remove the kprobes mutex from kprobes.h, since it does not belong there. > > > Also > > > remove all use

Re: [patch 1/8] Kprobes - do not use kprobes mutex in arch code

2007-07-16 Thread Ananth N Mavinakayanahalli
gnostic code. > > Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> Acked-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> Thanks Mathieu. > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > --- > arch/i386/k

Re: [PATCH] Kprobes - use a mutex to protect the instruction pages list.

2007-07-16 Thread Ananth N Mavinakayanahalli
that > does > not need to call arch_remove_kprobe() does not take an unneeded kprobes mutex. > > Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > CC: [EMAIL PROTECTED] > CC: [EMAIL PRO

Re: [PATCH] Kprobes - Declare kprobe_mutex static

2007-07-16 Thread Ananth N Mavinakayanahalli
On Sat, Jul 14, 2007 at 03:52:41PM -0400, Mathieu Desnoyers wrote: > Kprobes - Declare kprobe_mutex static > > Since it will not be used by other kernel objects, it makes sense to declare > it > static. > > Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECT

Re: [patch 05/10] Linux Kernel Markers - i386 optimized version

2007-05-10 Thread Ananth N Mavinakayanahalli
On Thu, May 10, 2007 at 12:59:18PM -0400, Mathieu Desnoyers wrote: > * Alan Cox ([EMAIL PROTECTED]) wrote: ... > > > * Third issue : Scalability. Changing code will stop every CPU on the > > > system for a while. Compared to this, the int3-based approach will run > > > through the breakpoint h

[RFC] Extend Linux to support proportional-share scheduling

2007-06-05 Thread Li, Tong N
Hi all, I've ported my code to mainline 2.6.21.3. You can get it at http://www.cs.duke.edu/~tongli/linux/. As I said before, the intent of the patch is not to compete with CFS and SD because the design relies on the underlying scheduler for interactive performance. The goal here is to present a co

RE: [RFC] Extend Linux to support proportional-share scheduling

2007-06-05 Thread Li, Tong N
user cares more). Thanks, tong > -Original Message- > From: Willy Tarreau [mailto:[EMAIL PROTECTED] > Sent: Tuesday, June 05, 2007 8:33 PM > To: Li, Tong N > Cc: linux-kernel@vger.kernel.org; Ingo Molnar; Con Kolivas; Linus Torvalds; > Arjan van de Ven; Siddha, Suresh B

updated sbpcd.c

2007-06-28 Thread Surya Prabhakar N
again. * Still room for improvement in the request handling here if anyone * actually cares. Bring your own chainsaw.Paul G. 02/2002 + * + * Deprecated check_region cleanup to request_region + * -Surya Prabhakar N08/07/2007 */ @@ -555,6 +558,7 @@ stati

Re: [RFC] [PATCH 0/3] Add group fairness to CFS

2007-05-25 Thread Li, Tong N
On Fri, 2007-05-25 at 21:44 +0530, Srivatsa Vaddagiri wrote: > > > > That assumes per-user scheduling groups; other configurations would > > make it one step for each level of hierarchy. It may be possible to > > reduce those steps to only state transitions that change weightings > > and increment

Re: [Fastboot] [PATCH 11/20] x86_64: wakeup.S misc cleanups

2007-03-08 Thread Lombard, David N
; this piece code be there. > > Ok. (I was not sure how common are displays of port 0x80). They're now typically available in reasonably well stocked stores; I picked one up from CompUSA about a year ago... -- David N. Lombard, Intel, Irvine, CA I do not speak for Intel Corporatio

[PATCH] Kprobes: Make kprobe.symbol_name const

2007-03-14 Thread Ananth N Mavinakayanahalli
From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> Kprobes doesn't scribble the kprobe.symbol_name field. Its only set by the module when registering the probe. Modules that exercise good hygiene using the "const" qualifier will see warnings... warning: assignmen

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-13 Thread Ananth N Mavinakayanahalli
On Fri, Apr 13, 2007 at 12:50:20PM +1000, Nick Piggin wrote: > Andrew Morton wrote: > >On Fri, 13 Apr 2007 12:18:56 +1000 Nick Piggin <[EMAIL PROTECTED]> > >wrote: > > > > > >>>I guess one could generate an answer to the static question with > >>>systemtap, > >>>by accumulating running counts acr

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-13 Thread Ananth N Mavinakayanahalli
On Fri, Apr 13, 2007 at 12:54:36PM +1000, Nick Piggin wrote: > Matt Mackall wrote: > >On Fri, Apr 13, 2007 at 12:21:25PM +1000, Nick Piggin wrote: > > > >>Matt Mackall wrote: > >> > >>>On Fri, Apr 13, 2007 at 11:42:29AM +1000, Nick Piggin wrote: > >> > If kprobes is simply crappy and doesn't wo

Re: [S390] add arch_trampoline_kprobe.

2007-04-20 Thread Ananth N Mavinakayanahalli
h sometime earlier (http://marc.info/?l=linux-kernel&m=117620748921086&w=2). Andrew has picked it up into -mm. Ananth > > Cc: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > Cc: Srinivasa DS <[EMAIL PROTECTED]> > Cc: Andrew Morton <[EMAIL PROTECTED]&g

Re: [patch] CFS scheduler, -v8

2007-05-07 Thread Li, Tong N
On Mon, 2007-05-07 at 19:52 +0530, Srivatsa Vaddagiri wrote: > On Thu, May 03, 2007 at 08:53:47AM -0700, William Lee Irwin III wrote: > > On Thu, May 03, 2007 at 08:23:18PM +0530, Srivatsa Vaddagiri wrote: > > > And what about group scheduling extensions? Do you have plans to work on > > > it? I wa

Re: [PATCH] kprobes: fix sparse NULL warning

2007-03-16 Thread Ananth N Mavinakayanahalli
[EMAIL PROTECTED]> Acked-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > --- > kernel/kprobes.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-2621-rc4.orig/kernel/kprobes.c > +++ linux-2621-rc4/kernel/kprobes.c > @@ -35,6 +35,7

Re: [RFC][PATCH] Kprobes: The ON/OFF knob thru debugfs - updated

2007-04-05 Thread Ananth N Mavinakayanahalli
On Wed, Apr 04, 2007 at 11:13:30AM -0700, Keshavamurthy, Anil S wrote: > On Wed, Apr 04, 2007 at 05:43:49PM +0530, Ananth N Mavinakayanahalli wrote: > > This patch provides a debugfs knob to turn kprobes on/off > Nice feature. Thanks. Review inline. Thanks for the review Anil... >

Re: [RFC][PATCH] Kprobes: The ON/OFF knob thru debugfs

2007-04-08 Thread Ananth N Mavinakayanahalli
On Sun, Apr 08, 2007 at 11:22:31AM +0100, Christoph Hellwig wrote: > On Wed, Apr 04, 2007 at 05:43:49PM +0530, Ananth N Mavinakayanahalli wrote: > > This patch provides a debugfs knob to turn kprobes on/off > > > > o A new file /debug/kprobes/enabled indicates if kprobes is

Re: 2.6.21-rc6-mm1

2007-04-10 Thread Ananth N Mavinakayanahalli
On Tue, Apr 10, 2007 at 02:24:21PM +0200, Cornelia Huck wrote: > On Sun, 8 Apr 2007 14:35:59 -0700, > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc6/2.6.21-rc6-mm1/ > > > +kprobes-the-on-off-knob-thru-debugfs-updated.patch >

Announce: New release of Linux-ready Firmware Dev Kit - Release 2

2007-04-11 Thread Selbak, Rolla N
The Linux-ready Firmware Developer Kit team is pleased to announce the release R2 of the kit. This release is mostly very heavy with bug-fixes, infrastructure re-org. to make it easier for outside developers to write & contribute plugins, and of course, tons of documentation. A few new tests an

RE: [REPORT] cfs-v4 vs sd-0.44

2007-04-23 Thread Li, Tong N
I don't know if we've discussed this or not. Since both CFS and SD claim to be fair, I'd like to hear more opinions on the fairness aspect of these designs. In areas such as OS, networking, and real-time, fairness, and its more general form, proportional fairness, are well-defined terms. In fact, p

Re: [REPORT] cfs-v4 vs sd-0.44

2007-04-24 Thread Li, Tong N
On Mon, 2007-04-23 at 18:57 -0700, Bill Huey wrote: > On Mon, Apr 23, 2007 at 05:59:06PM -0700, Li, Tong N wrote: > > I don't know if we've discussed this or not. Since both CFS and SD claim > > to be fair, I'd like to hear more opinions on the fairness aspect of &g

RE: [REPORT] cfs-v4 vs sd-0.44

2007-04-24 Thread Li, Tong N
e second metric and still consider an algorithm to be fair as long as the second metric is bounded by a constant. > > On Mon, Apr 23, 2007 at 05:59:06PM -0700, Li, Tong N wrote: > > I understand that via experiments we can show a design is reasonably > > fair in the common case, bu

Re: [REPORT] cfs-v4 vs sd-0.44

2007-04-26 Thread Li, Tong N
planation, I think Ingo's approach would also fall into this category. With careful design, all such algorithms that order tasks based on some notion of time can achieve good fairness. There are some subtle differences. Some algorithms of this type can achieve a constant lag bound, but some onl

Re: [2.6 patch] include/linux/kprobes.h: always offer show_registers() prototype

2007-04-26 Thread Ananth N Mavinakayanahalli
On Fri, Apr 27, 2007 at 01:47:49AM +0200, Adrian Bunk wrote: > Allow gcc to perform show_registers() type checking also with > CONFIG_KPROBES=n. Is kprobes.h the correct place to allow for this change? Perhaps, with Christoph's patch http://marc.info/?l=linux-kernel&m=1174

Re: [PATCH 3/3] kprobes: kretprobes simplifcations

2007-04-01 Thread Ananth N Mavinakayanahalli
ig <[EMAIL PROTECTED]> Acked-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > > Index: linux-2.6/arch/i386/kernel/kprobes.c > === > --- linux-2.6.orig/arch/i386/kernel/kprobes.c 2007-03-31 14:31:24.

[PATCH] Kprobes: Print details of kretprobe on assertion failure

2007-04-02 Thread Ananth N Mavinakayanahalli
From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> In certain cases like when the real return address can't be found or when the number of tracked calls to a kretprobed function is less than the number of returns, we may not be able to find the correct return address after p

Re: [PATCH] Kprobes: Print details of kretprobe on assertion failure

2007-04-02 Thread Ananth N Mavinakayanahalli
On Mon, Apr 02, 2007 at 02:17:32PM -0700, Andrew Morton wrote: > On Mon, 2 Apr 2007 14:56:36 +0530 > Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> wrote: > > > From: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> > > > > In certain cases like when th

[RFC][PATCH] Kprobes: The ON/OFF knob thru debugfs

2007-04-04 Thread Ananth N Mavinakayanahalli
reflect these changes. While there also update the doc to make it current. Patch against 2.6.21-rc5-mm4 We are also looking at providing sysrq key support to tie to the disabling feature provided by this patch. Signed-off-by: Ananth N Mavinakayanahalli <[EMAIL PROTECTED]> Signed-off-by: Sri

Re: [patch] CFS scheduler, -v8

2007-05-02 Thread Li, Tong N
> Based on my understanding, adopting something like EEVDF in CFS should > not be very difficult given their similarities, although I do not have > any idea on how this impacts the load balancing for SMP. Does this worth > a try? > > Sorry for such a long email :-) Thanks for the excellent

Re: [patch] CFS scheduler, -v8

2007-05-03 Thread Li, Tong N
On Thu, 2007-05-03 at 08:53 -0700, William Lee Irwin III wrote: > On Thu, May 03, 2007 at 03:29:32PM +0200, Damien Wyart wrote: > >> What are your thoughts/plans concerning merging CFS into mainline ? Is > >> it a bit premature to get it into 2.6.22 ? I remember Linus was ok to > >> change the defa

[net-next PATCH 3/3] ARM: dts: dra72-evm-revc: fix non-working cpsw second ethernet

2016-07-20 Thread Mugunthan V N
Second ethernet of cpsw is not working, make it work by adding impedance configuration. Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/dra72-evm-revc.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/dra72-evm-revc.dts b/arch/arm/boot/dts/dra72-evm-revc.dts index

[net-next PATCH 2/3] net: phy: dp83867: add support for MAC impedance configuration

2016-07-20 Thread Mugunthan V N
Add support for programmable MAC impedance configuration Signed-off-by: Mugunthan V N --- drivers/net/phy/dp83867.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 91177a4..ace3558 100644 --- a/drivers/net

[net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control

2016-07-20 Thread Mugunthan V N
Add documention of ti,impedance-control which can be used to correct MAC impedance mismatch using phy extended registers. Signed-off-by: Mugunthan V N --- Documentation/devicetree/bindings/net/ti,dp83867.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree

[net-next PATCH 0/3] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-07-20 Thread Mugunthan V N
Add support for configurable impedance control for TI dp83867 phy via devicetree. More documentation in [1] CPSW second ethernet is not working, fix it by enabling impedance configuration on the phy. Public Datasheet - http://www.ti.com/lit/ds/symlink/dp83867ir.pdf Mugunthan V N (3): net: phy

Re: [net-next PATCH 1/3] net: phy: dp83867: Add documentation for optional impedance control

2016-07-22 Thread Mugunthan V N
Rob, On Friday 22 July 2016 02:44 AM, Rob Herring wrote: > On Thu, Jul 21, 2016 at 11:52:36AM +0530, Sekhar Nori wrote: >> Nishanth, >> >> On Wednesday 20 July 2016 09:03 PM, Nishanth Menon wrote: >>> On 07/20/2016 09:56 AM, Mugunthan V N wrote: >>>> Add

[PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support

2016-09-21 Thread Mugunthan V N
This patch adds the required pieces to ti_am335x_adc driver for DMA support Signed-off-by: Mugunthan V N --- drivers/iio/adc/ti_am335x_adc.c | 160 ++- include/linux/mfd/ti_am335x_tscadc.h | 7 ++ 2 files changed, 164 insertions(+), 3 deletions(-) diff

[PATCH 1/4] mfd: ti_am335x_tscadc: store physical address

2016-09-21 Thread Mugunthan V N
store the physical address of the device in its priv to use it for DMA addressing in the client drivers. Signed-off-by: Mugunthan V N --- drivers/mfd/ti_am335x_tscadc.c | 1 + include/linux/mfd/ti_am335x_tscadc.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/mfd

[PATCH 4/4] ARM: dts: am4372: add DMA properties for tscadc

2016-09-21 Thread Mugunthan V N
Add DMA properties for tscadc Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/am4372.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi index 0fadae5..6094d17 100644 --- a/arch/arm/boot/dts/am4372.dtsi +++ b/arch/arm/boot

[PATCH 3/4] ARM: dts: am33xx: add DMA properties for tscadc

2016-09-21 Thread Mugunthan V N
Add DMA properties for tscadc Signed-off-by: Mugunthan V N --- arch/arm/boot/dts/am33xx.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 98748c6..6d607b8 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot

[PATCH 0/4] Add DMA support for ti_am335x_adc driver

2016-09-21 Thread Mugunthan V N
] [1] - http://pastebin.ubuntu.com/23211490/ [2] - http://pastebin.ubuntu.com/23211492/ [3] - http://pastebin.ubuntu.com/23211494/ [4] - git://git.ti.com/~mugunthanvnm/ti-linux-kernel/linux.git iio-dma Mugunthan V N (4): mfd: ti_am335x_tscadc: store physical address drivers: iio: ti_am335x_adc

Re: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support

2016-09-22 Thread Mugunthan V N
On Thursday 22 September 2016 12:50 PM, Peter Ujfalusi wrote: > On 09/21/16 19:11, Mugunthan V N wrote: >> This patch adds the required pieces to ti_am335x_adc driver for >> DMA support >> >> Signed-off-by: Mugunthan V N >> --- >> dri

Re: [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support

2016-09-22 Thread Mugunthan V N
On Thursday 22 September 2016 11:48 AM, Vignesh R wrote: > > > On Wednesday 21 September 2016 09:41 PM, Mugunthan V N wrote: >> This patch adds the required pieces to ti_am335x_adc driver for >> DMA support >> >> Signed-off-by: Mugunthan V N >> --- >>

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-21 Thread Naveen N. Rao
On 2016/06/21 09:38AM, Michael Ellerman wrote: > On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > > On 2016/06/17 10:53PM, Michael Ellerman wrote: > > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > > diff --git a/arch/powe

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-21 Thread Naveen N. Rao
On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote: > On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > Hi, Michael and Naveen. > > > > > > I noticed i

[PATCH 1/3] bpf powerpc: introduce accessors for using the tmp local stack space

2016-09-23 Thread Naveen N. Rao
While at it, ensure that the location of the local save area is consistent whether or not we setup our own stackframe. This property is utilised in the next patch that adds support for tail calls. Signed-off-by: Naveen N. Rao --- arch/powerpc/net/bpf_jit64.h | 16 +--- arch/powerpc/net

[PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-23 Thread Naveen N. Rao
t don't do tail calls themselves, the first two instructions are NOPs. Signed-off-by: Naveen N. Rao --- arch/powerpc/include/asm/ppc-opcode.h | 2 + arch/powerpc/net/bpf_jit.h| 2 + arch/powerpc/net/bpf_jit64.h | 1 + arch/powerpc/net/bpf_ji

[PATCH 3/3] bpf powerpc: add support for bpf constant blinding

2016-09-23 Thread Naveen N. Rao
2,r2,39131 6c: xoris r2,r2,48399 70: rotlwi r2,r2,0 74: mr r8,r2 78: rotlwi r8,r8,0 7c: ld r27,-40(r1) 80: ld r28,-32(r1) 84: mr r3,r8 88: blr Signed-off-by: Naveen N. Rao --- arch/powerpc/net/bpf_jit64.h | 9 + arch/p

[PATCH 2/2] bpf samples: update tracex5 sample to use __seccomp_filter

2016-09-23 Thread Naveen N. Rao
seccomp_phase1() does not exist anymore. Instead, update sample to use __seccomp_filter(). While at it, set max locked memory to unlimited. Signed-off-by: Naveen N. Rao --- I am not completely sure if __seccomp_filter is the right place to hook in. This works for me though. Please review

[PATCH 1/2] bpf samples: fix compiler errors with sockex2 and sockex3

2016-09-23 Thread Naveen N. Rao
These samples fail to compile as 'struct flow_keys' conflicts with definition in net/flow_dissector.h. Fix the same by renaming the structure used in the sample. Signed-off-by: Naveen N. Rao --- samples/bpf/sockex2_kern.c | 10 +- samples/bpf/sockex3_kern.c | 8 s

Re: [PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-26 Thread Naveen N. Rao
On 2016/09/24 03:30AM, Alexei Starovoitov wrote: > On Sat, Sep 24, 2016 at 12:33:54AM +0200, Daniel Borkmann wrote: > > On 09/23/2016 10:35 PM, Naveen N. Rao wrote: > > >Tail calls allow JIT'ed eBPF programs to call into other JIT'ed eBPF > > >programs. Th

Re: [PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-26 Thread Naveen N. Rao
On 2016/09/26 11:00AM, Daniel Borkmann wrote: > On 09/26/2016 10:56 AM, Naveen N. Rao wrote: > > On 2016/09/24 03:30AM, Alexei Starovoitov wrote: > > > On Sat, Sep 24, 2016 at 12:33:54AM +0200, Daniel Borkmann wrote: > > > > On 09/23/2016 10:35 PM, Naveen N. Rao wro

Re: [PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

2016-07-29 Thread Mugunthan V N
rnet: ti: cpsw: use destroy ctlr to destroy channels") was merged. > > Signed-off-by: Grygorii Strashko Reviewed-by: Mugunthan V N Regards Mugunthan V N

Re: [PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove

2016-07-29 Thread Mugunthan V N
ces are down. > > Hence, ensure that CPSW powered up by PM runtime before performing any > deinitialization actions which require CPSW registers access. In case > of PM runtime error just leave cpsw_remove() as we can't do anything > anymore. > > Signed-off-by: Grygorii

Re: [PATCH v2 3/4] drivers: net: cpsw: use of_platform_depopulate()

2016-07-29 Thread Mugunthan V N
ure that all steps done in > of_platform_populate() are reverted, including cleaning up of > OF_POPULATED flag. > > Signed-off-by: Grygorii Strashko Reviewed-by: Mugunthan V N Regards Mugunthan V N

Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture

2016-09-14 Thread Naveen N. Rao
s still fails for me on ppc64. Perhaps we should guard P_MMAP_FLAG(32BIT) and potentially others with a #ifdef, which was earlier reverted by commit 256763b0 ("perf trace beauty mmap: Add more conditional defines")? - Naveen --- In file included from builtin-trace.c:560:0: trace/beauty/

Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture

2016-09-14 Thread Naveen N. Rao
On 2016/09/14 05:36PM, Wang Nan wrote: > > > On 2016/9/14 17:28, Naveen N. Rao wrote: > > On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo > > > escreveu: > > > > Em Mo

Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture

2016-09-14 Thread Naveen N. Rao
On 2016/09/14 06:23PM, Wang Nan wrote: > > > On 2016/9/14 18:00, Naveen N. Rao wrote: > > On 2016/09/14 05:36PM, Wang Nan wrote: > > > > > > On 2016/9/14 17:28, Naveen N. Rao wrote: > > > > On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote: >

Re: [PATCH 2/2] tools include: Add mman macros needed by perf for all arch

2016-09-14 Thread Naveen N. Rao
man.h for each archs, defines these missing > macros for perf. For missing MADV_*, fall back to asm-generic/mman-common > because they are in 'case ...' statement. For flags, define to 0. This resolves the build issue on powerpc, thanks! Tested-by: Naveen N. Rao

Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture

2016-09-14 Thread Naveen N. Rao
On 2016/09/14 10:52AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 14, 2016 at 02:58:10PM +0530, Naveen N. Rao escreveu: > > On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo > > > escrev

Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture

2016-09-15 Thread Naveen N. Rao
On 2016/09/14 02:00PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 14, 2016 at 10:04:28PM +0530, Naveen N. Rao escreveu: > > On 2016/09/14 10:52AM, Arnaldo Carvalho de Melo wrote: > > > And yeah, I'll try and cross-build audit-lib for my powerpc cross build > > >

Re: [PATCH v2 01/14] net: ethernet: ti: cpsw: simplify submit routine

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > As second net dev is created only in case of dual_emac mode, port > number can be figured out in simpler way. Also no need to pass > redundant ndev struct. > > Signed-off-by: Ivan Khoronzhuk Reviewed-by: Muguntha

Re: [PATCH v2 02/14] net: ethernet: ti: cpsw: remove redundant check in napi poll

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > No need to check number of handled packets, when in most cases (> 99%) > it's not 0. It can be 0 only in rare cases, even in this case > it's not bad to print just 0. > > Signed-off-by: Ivan Khoronzhuk

Re: [PATCH v2 03/14] net: ethernet: ti: cpsw: remove priv from cpsw_get_slave_port() parameters list

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > There is no need in priv here. > > Signed-off-by: Ivan Khoronzhuk Reviewed-by: Mugunthan V N Regards Mugunthan V N

Re: [PATCH v2 04/14] net: ethernet: ti: cpsw: remove clk var from priv

2016-08-09 Thread Mugunthan V N
On Saturday 06 August 2016 04:18 PM, Ivan Khoronzhuk wrote: > There is no need to hold link to clk, it's used only once > while probe. > > Signed-off-by: Ivan Khoronzhuk Reviewed-by: Mugunthan V N Regards Mugunthan V N

Re: [PATCH 1/2] perf: add container identifier entry in perf sample data

2016-08-25 Thread Ananth N Mavinakayanahalli
>>+ /* > >>+* Container identifier for a given task. > >>+* Using cgroup namespace inode number for this. > >>+*/ > >>+ data->cid_entry.cid = current->nsproxy->cgroup_ns->ns.inum; > >>+

[PATCH 0/2] A couple of small updates/fixes for kprobes tracer

2017-06-21 Thread Naveen N. Rao
for powerpc. Thanks, Naveen Naveen N. Rao (2): trace/kprobes: Sanitize derived event names selftests/ftrace: Update multiple kprobes test for powerpc kernel/trace/trace_kprobe.c | 9 + tools/testing/selftests/ftrace/test.d/kprobe

[PATCH 1/2] trace/kprobes: Sanitize derived event names

2017-06-21 Thread Naveen N. Rao
vents trace_kprobe: Failed to allocate trace_probe.(-22) -sh: write error: Invalid argument After this patch: # echo 'p kobject_example:foo_store' > kprobe_events # cat kprobe_events p:kprobes/p_kobject_example_foo_store_0 kobject_example:foo_store Signed-off-by: Navee

[PATCH 2/2] selftests/ftrace: Update multiple kprobes test for powerpc

2017-06-21 Thread Naveen N. Rao
names properly in the presence of ':' and '.', such names are accepted by kprobe_events and constitutes a good test for those symbols. Signed-off-by: Naveen N. Rao --- tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 8 1 file changed, 4 insertions(+), 4 d

Re: [PATCH -tip v3 3/7] kprobes: Warn if optprobe handler tries to change execution path

2017-10-17 Thread Naveen N. Rao
On 2017/10/12 05:04AM, Masami Hiramatsu wrote: > On Tue, 10 Oct 2017 22:32:31 +0530 > "Naveen N. Rao" wrote: > > > On 2017/09/19 10:00AM, Masami Hiramatsu wrote: > > So, we don't seem to _require_ users to return !0 if the handler > > changes [n]ip?

[PATCH] Revert "kprobes: Warn if optprobe handler tries to change execution path"

2017-10-17 Thread Naveen N. Rao
ptprobe as described in commit 762df10bad6954 ("powerpc/kprobes: Optimize kprobe in kretprobe_trampoline()"). With the above commit, we end up with a warning. As such, revert this change. Reported-by: Michael Ellerman Signed-off-by: Naveen N. Rao --- Discussion here: https://www.ma

Re: [PATCH v3 1/2] perf/bench/numa: Add functions to detect sparse numa nodes

2017-10-31 Thread Naveen N. Rao
Hi Satheesh, On 2017/08/21 10:15AM, sathn...@linux.vnet.ibm.com wrote: > From: Satheesh Rajendran > > Added functions 1) to get a count of all nodes that are exposed to > userspace. These nodes could be memoryless cpu nodes or cpuless memory > nodes, 2) to check given node is present and 3) to c

Re: [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse numa nodes

2017-10-31 Thread Naveen N. Rao
int i; > > for (i = 0; i < mul; i++) { > - if (t >= g->p.nr_tasks) { > + if (t >= g->p.nr_tasks || > !node_has_cpus(bind_node)) { >

Re: [RFC] perf tool: Fix memory corruption because of zero length symbols

2017-10-25 Thread Naveen N. Rao
On 2017/10/25 08:28AM, Jiri Olsa wrote: > On Tue, Oct 24, 2017 at 07:50:06PM +0530, Ravi Bangoria wrote: > > Perf top is often crashing at very random locations on powerpc. > > After investigating, I found the crash only happens when sample > > is of zero length symbol. Powerpc kernel has many such

Re: [kernel-hardening] Re: [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Kaiwan N Billimoria
On Mon, Nov 13, 2017 at 10:05 AM, Tobin C. Harding wrote: > On Mon, Nov 13, 2017 at 06:37:28AM +0300, Kirill A. Shutemov wrote: >> On Mon, Nov 13, 2017 at 10:06:46AM +1100, Tobin C. Harding wrote: >> > On Sun, Nov 12, 2017 at 02:10:07AM +0300, Kirill A. Shutemov wrote: ... >> > >> > Thanks for the

Re: [kernel-hardening] [PATCH v4] scripts: add leaking_addresses.pl

2017-11-12 Thread Kaiwan N Billimoria
On Mon, Nov 13, 2017 at 11:38 AM, Tobin C. Harding wrote: > On Mon, Nov 13, 2017 at 11:16:28AM +0530, kaiwan.billimo...@gmail.com wrote: >> On Mon, 2017-11-13 at 09:21 +1100, Tobin C. Harding wrote: >> > On Fri, Nov 10, 2017 at 07:26:34PM +0530, kaiwan.billimo...@gmail.com >> > wrote: >> > > On T

Re: [PATCH v4 2/3] powerpc/modules: Don't try to restore r2 after a sibling call

2017-11-14 Thread Naveen N. Rao
Kamalesh Babulal wrote: From: Josh Poimboeuf When attempting to load a livepatch module, I got the following error: module_64: patch_module: Expect noop after relocate, got 3c82 The error was triggered by the following code in unregister_netdevice_queue(): 14c: 00 00 00 48 b

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

2017-11-04 Thread Naveen N. Rao
waker(): p->pid = %u, p->comm = %s\n"; bpf_trace_printk(fmt, sizeof(fmt), _(p->pid), _(p->comm)); it is seen that upon rebuilding and running this sample followed by inspecting /sys/kernel/debug/tracing/trace, the output looks like the following

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

2017-11-06 Thread Naveen N. Rao
Alexei Starovoitov wrote: On 11/5/17 2:31 AM, Naveen N. Rao wrote: Hi Alexei, Alexei Starovoitov wrote: On 11/3/17 3:58 PM, Sandipan Das wrote: For added security, the layout of some structures can be randomized by enabling CONFIG_GCC_PLUGIN_RANDSTRUCT. One such structure is task_struct. To

Re: [PATCH] perf probe powerpc: Ignore SyS symbols irrespective of endianness

2018-08-28 Thread Naveen N. Rao
Sandipan Das wrote: This makes sure that the SyS symbols are ignored for any powerpc system, not just the big endian ones. Fixes: fb6d59423115 ("perf probe ppc: Use the right prefix when ignoring SyS symbols on ppc") Reported-by: Naveen N. Rao Signed-off-by: Sandipan Das R

Re: [PATCH] perf probe powerpc: Fix trace event post-processing

2018-08-09 Thread Naveen N. Rao
_open%return) ... Fixes: 99e608b5954c ("perf probe ppc64le: Fix probe location when using DWARF") Reported-by: Aneesh Kumar K.V Signed-off-by: Sandipan Das Acked-by: Naveen N. Rao - Naveen

Re: [PATCH v9 0/4] Uprobes: Support SDT markers having reference count (semaphore)

2018-08-21 Thread Naveen N. Rao
Song Liu wrote: I am testing the patch set with the following code: #include #include volatile short semaphore = 0; int for_uprobe(int c) { printf("%d\n", c + 10); return c + 1; } int main(int argc, char *argv[]) { for_uprobe(argc);

[PATCH 3/4] selftests/ftrace: Fix bashisms

2017-05-13 Thread Naveen N. Rao
Fix a few bashisms in ftrace selftests. Signed-off-by: Naveen N. Rao --- tools/testing/selftests/ftrace/ftracetest | 2 +- tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +- tools/testing/selftests/ftrace/test.d/functions

[PATCH 0/4] ftrace: Fix a few issues

2017-05-13 Thread Naveen N. Rao
explicitly catch this issue going forward. - Naveen Naveen N. Rao (4): ftrace: Simplify glob handling in unregister_ftrace_function_probe_func() ftrace/instances: Clear function triggers when removing instances selftests/ftrace: Fix bashisms selftests/ftrace: Add test to remove instance

[PATCH 4/4] selftests/ftrace: Add test to remove instance with active event triggers

2017-05-13 Thread Naveen N. Rao
Add a test to ensure we clean up properly when removing an instance with active event triggers. Signed-off-by: Naveen N. Rao --- Steven, I have also removed what looked like an incorrect 'exit' in the middle of this test. Kindly take a look if that's ok. - Naveen tools/te

[PATCH 2/4] ftrace/instances: Clear function triggers when removing instances

2017-05-13 Thread Naveen N. Rao
0xc21edde8 Faulting instruction address: 0xc21edde8 To address this, let's clear all registered function probes before deleting the ftrace instance. Reported-by: Michael Ellerman Signed-off-by: Naveen N. Rao --- kernel/trace/ftrace.c | 8 kernel/trace/trac

[PATCH 1/4] ftrace: Simplify glob handling in unregister_ftrace_function_probe_func()

2017-05-13 Thread Naveen N. Rao
Handle a NULL glob properly. Signed-off-by: Naveen N. Rao --- kernel/trace/ftrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 39dca4e86a94..28dc824ad072 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace

Re: [PATCH 4.14 120/189] powerpc/trace/syscalls: Update syscall name matching logic

2018-06-18 Thread Naveen N. Rao
Greg Kroah-Hartman wrote: 4.14-stable review patch. If anyone has any objections, please let me know. Please drop this and the next patch since these depend on commit e145242ea0df6, which is not in v4.14. - Naveen -- From: "Naveen N. Rao" [ Upstr

Re: [PATCH 4.16 188/279] powerpc/trace/syscalls: Update syscall name matching logic

2018-06-18 Thread Naveen N. Rao
Greg Kroah-Hartman wrote: 4.16-stable review patch. If anyone has any objections, please let me know. Please drop this and the next patch since these depend on commit e145242ea0df6, which is not in v4.16. - Naveen -- From: "Naveen N. Rao" [ Upstr

Re: [PATCH -tip v4 00/27] kprobes: Cleanup jprobe implementation

2018-05-31 Thread Naveen N. Rao
Hi Masami, Masami Hiramatsu wrote: Hi Naveen, Sorry, I might miss to add you on CC list. Could you test and review this on powerpc? Sure, thanks for letting me know. If possible, please mark powerpc patches to linuxppc-...@lists.ozlabs.org so that it gets good review. - Naveen

Re: [PATCH -tip v4 24/27] bpf: error-inject: kprobes: Clear current_kprobe and enable preempt in kprobe

2018-05-31 Thread Naveen N. Rao
Masami Hiramatsu wrote: Clear current_kprobe and enable preemption in kprobe even if pre_handler returns !0. This simplifies function override using kprobes. Jprobe used to require to keep the preemption disabled and keep current_kprobe until it returned to original function entry. For this rea

Re: [PATCH -tip v4 24/27] bpf: error-inject: kprobes: Clear current_kprobe and enable preempt in kprobe

2018-06-02 Thread Naveen N. Rao
Masami Hiramatsu wrote: On Thu, 31 May 2018 16:25:38 +0530 "Naveen N. Rao" wrote: Masami Hiramatsu wrote: > Clear current_kprobe and enable preemption in kprobe > even if pre_handler returns !0. > > This simplifies function override using kprobes. > > Jprobe

<    1   2   3   4   5   6   7   8   9   10   >