Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-18 Thread oskar.andero
On 21:16 Fri 08 Mar , Greg Kroah-Hartman wrote: > On Fri, Mar 08, 2013 at 11:56:26PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 08-03-2013 16:53, oskar.and...@sonymobile.com wrote: > > > > >From: Truls Bengtsson > > > > >The udc_irq service runs the isr_tr_complete_handler which in

[RFC PATCHv2 0/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-19 Thread oskar.andero
Hi, This is patch version 2. Besides review I hope to get some feed-back on what the preferred solution is. Background: When going through our patches to be mainlined I stumbled on this one which we have fixed in many different ways internally. The problem is a NULL pointer dereference that can

[RFC PATCHv2 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-19 Thread oskar.andero
From: Truls Bengtsson The udc_irq service runs the isr_tr_complete_handler which in turn "nukes" the endpoints, including a call to rndis_response_complete, if appropriate. If the rndis_msg_parser fails here, an error will be printed using a dev_err call (through the ERROR() macro). However, if

[PATCHv2] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-20 Thread oskar.andero
From: Truls Bengtsson The udc_irq service runs the isr_tr_complete_handler which in turn "nukes" the endpoints, including a call to rndis_response_complete, if appropriate. If the rndis_msg_parser fails here, an error will be printed using a dev_err call (through the ERROR() macro). However, if

Re: [PATCH] kprobe: initialize kprobe_blacklist when it is used firstly

2013-04-02 Thread oskar.andero
On 12:49 Tue 02 Apr , Masami Hiramatsu wrote: > Hi, > > (2013/04/01 15:55), Joonsoo Kim wrote: > > Currently, initializing kprobe_blacklist is done during boot process. > > It takes 230 ms on our android platform and this is significant amount > > for our use case. We can disable CONFIG_KPROBE

[PATCH 3/4] kprobes: move x86-specific blacklist symbols to arch directory

2013-04-03 Thread oskar.andero
From: Björn Davidsson The common kprobes blacklist contains x86-specific symbols. Looking for these in kallsyms takes unnecessary time during startup on non-X86 platform. The symbols where moved to arch/x86/kernel/kprobes/core.c. Reviewed-by: Radovan Lekanovic Signed-off-by: Björn Davidsson Si

[PATCH 2/4] kprobes: split blacklist into common and arch

2013-04-03 Thread oskar.andero
Some blackpoints are only valid for specific architectures. To let each architecture specify its own blackpoints the list has been split in two lists: common and arch. The common list is kept in kernel/kprobes.c and the arch list is kept in the arch/ directory. Signed-off-by: Oskar Andero --- ar

[PATCH 0/4] kprobes: split blacklist into common and arch

2013-04-03 Thread oskar.andero
Hi, This is a slight rework of the following patches which I posted earlier: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols [PATCH] delay blacklist symbol lookup until we actually need it This serie includes a patch that moves the architecture dependent black points to the arch

[PATCH 4/4] kprobes: replace printk with pr_-functions

2013-04-03 Thread oskar.andero
Instead of using printk use pr_info/pr_err/pr_warn. This was detected by the checkpatch.pl script. Signed-off-by: Oskar Andero --- kernel/kprobes.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 3396eb8..03a9dd3 10

[PATCH 1/4] kprobes: delay blacklist symbol lookup until we actually need it

2013-04-03 Thread oskar.andero
From: Toby Collett The symbol lookup can take a long time and kprobes is initialised very early in boot, so delay symbol lookup until the blacklist is first used. Reviewed-by: Radovan Lekanovic Signed-off-by: Toby Collett Signed-off-by: Oskar Andero --- kernel/kprobes.c | 91

[PATCH] lowmemorykiller: Use ktimer instead of jiffies

2013-03-07 Thread oskar.andero
From: Peter Enderborg Reviewed-by: Radovan Lekanovic Signed-off-by: Peter Enderborg Signed-off-by: Oskar Andero --- drivers/staging/android/lowmemorykiller.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/s

[PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

2013-03-07 Thread oskar.andero
From: Bj�rn Davidsson The kprobes blacklist contains x86-specific symbols. Looking for these in kallsyms takes unnecessary time during startup on non-X86 platform. Added #ifdef CONFIG_X86 around them. Reviewed-by: Radovan Lekanovic Signed-off-by: Björn Davidsson Signed-off-by: Oskar Andero --

[PATCH] delay blacklist symbol lookup until we actually need it

2013-03-07 Thread oskar.andero
From: Toby Collett The symbol lookup can take a long time and kprobes is initialised very early in boot, so delay symbol lookup until the blacklist is first used. Reviewed-by: Radovan Lekanovic Signed-off-by: Toby Collett Signed-off-by: Oskar Andero --- kernel/kprobes.c | 91 ++

[PATCH] input: don't call input_dev_release_keys() in resume

2013-03-07 Thread oskar.andero
From: Aleksej Makarov When waking up the platform by pressing a specific key, sending a release on that key makes it impossible to react on the event in user-space. Cc: Dmitry Torokhov Reviewed-by: Radovan Lekanovic Signed-off-by: Aleksej Makarov Signed-off-by: Oskar Andero --- drivers/inpu

Re: [PATCH] lowmemorykiller: Use ktimer instead of jiffies

2013-03-08 Thread oskar.andero
On 18:25 Thu 07 Mar , Greg KH wrote: > On Thu, Mar 07, 2013 at 11:32:39AM +0100, oskar.and...@sonymobile.com wrote: > > From: Peter Enderborg > > > > Reviewed-by: Radovan Lekanovic > > Signed-off-by: Peter Enderborg > > Signed-off-by: Oskar Andero > > --- > > No changelog entry saying why

[RFC PATCH 0/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread oskar.andero
Hi, When going through our patches to be mainlined I stumbled on this one which we have fixed in many different ways internally. The problem is a NULL pointer dereference that can be triggered by disconnecting the USB cable at a specific time. Before submitting the final patch I would like to he

[RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

2013-03-08 Thread oskar.andero
From: Truls Bengtsson The udc_irq service runs the isr_tr_complete_handler which in turn "nukes" the endpoints, including a call to rndis_response_complete, if appropriate. If the rndis_msg_parser fails here, an error will be printed using a dev_err call (through the ERROR() macro). However, if

Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

2013-03-08 Thread oskar.andero
On 05:23 Fri 08 Mar , Masami Hiramatsu wrote: > (2013/03/07 19:44), oskar.and...@sonymobile.com wrote: > > From: Bjorn Davidsson > > > > The kprobes blacklist contains x86-specific symbols. > > Looking for these in kallsyms takes unnecessary time > > during startup on non-X86 platform. > > Ad

Re: [PATCH] Kprobes blacklist: Conditionally add x86-specific symbols

2013-03-08 Thread oskar.andero
On 07:03 Fri 08 Mar , Ananth N Mavinakayanahalli wrote: > On Fri, Mar 08, 2013 at 01:23:25PM +0900, Masami Hiramatsu wrote: > > (2013/03/07 19:44), oskar.and...@sonymobile.com wrote: > > > From: Bjorn Davidsson > > > > > > The kprobes blacklist contains x86-specific symbols. > > > Looking for