On 05/05/2014 10:20 AM, Preeti U Murthy wrote:
On 05/04/2014 06:11 PM, Rik van Riel wrote:
On 05/04/2014 07:44 AM, Preeti Murthy wrote:
Hi Rik, Mike
On Fri, May 2, 2014 at 12:00 PM, Rik van Riel r...@redhat.com wrote:
On 05/02/2014 02:13 AM, Mike Galbraith wrote:
On Fri, 2014-05-02 at 00:42
Hi Thomas,
Any comments on this patch?
Regards
Preeti U Murthy
On 04/01/2014 11:02 AM, Preeti U Murthy wrote:
On 03/28/2014 02:17 PM, Srivatsa S. Bhat wrote:
On 03/27/2014 03:44 PM, Preeti U Murthy wrote:
On 03/27/2014 11:58 AM, Srivatsa S. Bhat wrote:
Actually, my suggestion was to remove
on
* a busy processor. So reset next_balance.
*/
this_rq-next_balance = next_balance;
}
Also the comment in the above snippet does not look right to me.
It says we are going idle but the condition checks for pulled_task.
Regards
Preeti U Murthy
we be resetting rq-next_balance? And if we should, then the
dependence on pulled_tasks is not justified is it? All this assuming
that rq-next_balance should always reflect the minimum value of
sd-next_balance among the sched domains of which the rq is a part.
Regards
Preeti U Murthy
concerned with an additional point that
I have mentioned in my reply to Peter's mail on this thread.
Should we verify if rq-next_balance update is independent of
pulled_tasks? sd-balance_interval is changed during load_balance() and
rq-next_balance should perhaps consider that?
Regards
Preeti U Murthy
,
.balance_interval = sd_weight,
+ .max_newidle_lb_cost= 0,
+ .next_decay_max_lb_cost = jiffies,
};
SD_INIT_NAME(sd, NUMA);
sd-private = tl-data;
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send
)
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
is aimed at ensuring that the runlatch bits are consisten with the
utilization of a CPU under all circumstances.
---
Preeti U Murthy (3):
ppc/powernv: Set the runlatch bits correctly for offline cpus
ppc/kvm: Set the runlatch bit of a CPU just before starting guest
ppc/kvm: Clear
When the guest cedes the vcpu or the vcpu has no guest to
run it naps. Clear the runlatch bit of the vcpu before
napping to indicate an idle cpu.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Paul Mackerras pau...@samba.org
Reviewed-by: Srivatsa S. Bhat srivatsa.b
to be set to indicate that they
are busy. The primary thread has its runlatch bit set though, but there is no
harm in setting this bit once again. Hence set the runlatch bit for all
threads before they start guest.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Paul Mackerras pau
to be cleared to indicate an unused CPU. Hence this patch has the
runlatch bit cleared for an offline CPU just before entering an idle state
and sets it immediately after it exits the idle state.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Paul Mackerras pau...@samba.org
is aimed at ensuring that the runlatch bits are consisten with the
utilization of a CPU under all circumstances.
---
Preeti U Murthy (3):
ppc/powernv: Set the runlatch bits correctly for offline cpus
ppc/kvm: Set the runlatch bit of a CPU just before starting guest
ppc/kvm: Clear
On 03/28/2014 02:17 PM, Srivatsa S. Bhat wrote:
On 03/27/2014 03:44 PM, Preeti U Murthy wrote:
On 03/27/2014 11:58 AM, Srivatsa S. Bhat wrote:
Actually, my suggestion was to remove the dying CPU from the force_mask
alone,
in the CPU_DYING notifier. The rest of the cleanup (removing it from
value'
or something similar would be more appropriate. What do you think?
Regards
Preeti U Murthy
Create a more generic function arch_scale_cpu_power that can be also used by
non SMT platform to set cpu_power_orig.
The weak behavior of arch_scale_cpu_power is the previous SMT one in order
...@linaro.org
Should not the subject be add per rq cpu_power_orig?
Regards
Preeti U Murthy
---
kernel/sched/core.c | 2 +-
kernel/sched/fair.c | 1 +
kernel/sched/sched.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 5b20b27
On 04/01/2014 04:50 PM, Vincent Guittot wrote:
On 1 April 2014 12:39, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 03/28/2014 06:52 PM, Vincent Guittot wrote:
cpu_power_orig is only changed for SMT system in order to reflect the lower
capacity of CPUs. Heterogenous system
On 07/09/2014 04:13 PM, Peter Zijlstra wrote:
On Wed, Jul 09, 2014 at 09:24:54AM +0530, Preeti U Murthy wrote:
In the example that I mention above, t1 and t2 are on the rq of cpu0;
while t1 is running on cpu0, t2 is on the rq but does not have cpu1 in
its cpus allowed mask. So during load
+ * can try to migrate them.
+ */
schedstat_inc(sd, lb_balanced[idle]);
sd-nr_balance_failed = 0;
This patch looks good to me.
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Peter, Vincent,
On 07/10/2014 02:44 PM, Vincent Guittot wrote:
On 9 July 2014 12:43, Peter Zijlstra pet...@infradead.org wrote:
On Wed, Jul 09, 2014 at 09:24:54AM +0530, Preeti U Murthy wrote:
[snip]
Continuing with the above explanation; when LBF_ALL_PINNED flag is
set,and we jump
Commit 8d6f7c5a: powerpc/powernv: Make it possible to skip the IRQHAPPENED
check in power7_nap() added code that prevents even cores which enter sleep
on idle, from checking for pending interrupts. Fix this.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/powerpc/kernel
IPI complaining that the sleeping cpu is stuck.
This patch fixes these issues by ensuring that cpus check for pending interrupts
just before entering any idle state as long as they are not in the path of split
core operations.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked
in
*this* level of sched_domain, but can potentially run on a cpu at any
higher level of sched_domain. By clearing the flag, we are not
encouraging load balance at that level for t2.
Am I missing something?
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
Hi Vincent,
On 07/08/2014 03:42 PM, Vincent Guittot wrote:
On 8 July 2014 05:13, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 06/30/2014 09:35 PM, Vincent Guittot wrote:
The imbalance flag can stay set whereas there is no imbalance.
Let assume that we have 3 tasks that run on a dual
fixes ths issue by ensuring that cpus check for pending interrupts
just before entering any idle state as long as they are not in the path of split
core operations.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Chanes in V2: https://lkml.org/lkml/2014/7/1/3
Modified the changelog
. For such
a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock
device cannot be shutdown. To make way for this support, change the return
type of tick_broadcast_oneshot_control() and hence clockevents_notify() to
indicate such scenarios.
Signed-off-by: Preeti U Murthy pre
comments and code around programming of the broadcast hrtimer.
---
Preeti U Murthy (2):
time: Change the return type of clockevents_notify() to integer
time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with
CPUIDLE_FLAG_TIMER_STOP set
Thomas Gleixner (1):
tick/cpuidle
of
the stand by CPU as well by moving the hrtimer on to the CPU handling the
CPU_DEAD
notification.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
[Added Changelog and code to handle reprogramming of hrtimer]
---
include/linux/clockchips.h |9 +++
kernel/time/Makefile
we are in no further position to take a decision on an alternative
idle state to enter into.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle.c | 38 +++---
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git
-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Nicolas,
powernv in the subject of the patch?
Regards
Preeti U Murthy
On 02/06/2014 07:46 PM, Nicolas Pitre wrote:
The core idle loop now takes care of it.
Signed-off-by: Nicolas Pitre n...@linaro.org
---
arch/arm64/kernel/process.c | 7 ++-
1 file changed, 2 insertions(+), 5
as a result of Nicolas's cleanup, we would need to add the
ppc64_runlatch_on and off functions before and after the entry into the
powernv idle states.
Thanks
Regards
Preeti U Murthy
-- Daniel
-}
-
define_machine(powernv) {
.name = PowerNV,
.probe
Hi Thomas,
On 02/06/2014 09:33 PM, Thomas Gleixner wrote:
On Thu, 6 Feb 2014, Preeti U Murthy wrote:
Compiler warnings are not so important, right?
kernel/time/tick-broadcast.c: In function ‘tick_broadcast_oneshot_control’:
kernel/time/tick-broadcast.c:700:3: warning: ‘return
Hi Nicolas,
On 02/07/2014 06:47 AM, Nicolas Pitre wrote:
On Thu, 6 Feb 2014, Preeti U Murthy wrote:
Hi Daniel,
On 02/06/2014 09:55 PM, Daniel Lezcano wrote:
Hi Nico,
On 6 February 2014 14:16, Nicolas Pitre nicolas.pi...@linaro.org wrote:
The core idle loop now takes care
local_irq_enable() since we are in the call path of
cpuidle driver and that explicitly enables irqs on exit from
idle states.
On 02/07/2014 06:47 AM, Nicolas Pitre wrote:
On Thu, 6 Feb 2014, Preeti U Murthy wrote:
Hi Daniel,
On 02/06/2014 09:55 PM, Daniel Lezcano wrote:
Hi Nico,
On 6 February 2014 14
on the idea discussed here:
http://www.kernelhub.org/?p=2msg=399516
Changes in V4:
1. Cleared the stand by CPU from the oneshot mask. As a result PATCH 3/3
was simplified.
2. Fixed compile time warnings.
---
Preeti U Murthy (2):
time: Change the return type of clockevents_notify() to integer
. For such
a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock
device cannot be shutdown. To make way for this support, change the return
type of tick_broadcast_oneshot_control() and hence clockevents_notify() to
indicate such scenarios.
Signed-off-by: Preeti U Murthy pre
we are in no further position to take a decision on an alternative
idle state to enter into.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b
of
the stand by CPU as well by moving the hrtimer on to the CPU handling the
CPU_DEAD
notification.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
[Added Changelog and code to handle reprogramming of hrtimer]
---
include/linux/clockchips.h |9 +++
kernel/time/Makefile
Hi Deepthi,
On 02/07/2014 03:15 PM, Deepthi Dharwar wrote:
Hi Preeti,
Thanks for the patch.
On 02/07/2014 12:31 PM, Preeti U Murthy wrote:
Hi Nicolas,
Find below the patch that will need to be squashed with this one.
This patch is based on the mainline.Adding Deepthi, the author
Hi Nicolas,
On 02/07/2014 04:18 PM, Nicolas Pitre wrote:
On Fri, 7 Feb 2014, Preeti U Murthy wrote:
Hi Nicolas,
On 02/07/2014 06:47 AM, Nicolas Pitre wrote:
What about creating arch_cpu_idle_enter() and arch_cpu_idle_exit() in
arch/powerpc/kernel/idle.c and calling ppc64_runlatch_off
The broadcast timer registration has to be done only when
GENERIC_CLOCKEVENTS_BROADCAST and TICK_ONESHOT config options are enabled.
Also fix max_delta_ticks value for the pseudo clock device.
Reported-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Preeti U Murthy pre
Hi Thomas,
On 02/07/2014 11:27 PM, Thomas Gleixner wrote:
On Fri, 7 Feb 2014, Preeti U Murthy wrote:
The broadcast timer registration has to be done only when
GENERIC_CLOCKEVENTS_BROADCAST and TICK_ONESHOT config options are enabled.
Then we should compile that file only when those
Hi David,
I have sent out a revised patch on
https://lkml.org/lkml/2014/2/9/2. Can you let me
know if this works for you?
Thanks
Regards
Preeti U Murthy
On 02/09/2014 01:01 PM, David Rientjes wrote:
On Fri, 7 Feb 2014, Preeti U Murthy wrote:
The broadcast timer registration has to be done
deep
idle states on powerpc.
The patchset has been appended by a RESEND tag since nothing has changed from
the previous post except for an added config condition around
tick_broadcast() which handles sending broadcast IPIs, and the update in the
cover
letter.
---
Preeti U Murthy (1):
cpuidle
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com
[Functions renamed to tick_broadcast* and Changelog modified by
Preeti U. Murthypre...@linux.vnet.ibm.com]
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch
From: Preeti U Murthy pre...@linux.vnet.ibm.com
Split timer_interrupt(), which is the local timer interrupt handler on ppc
into routines called during regular interrupt handling and __timer_interrupt(),
which takes care of running local timers and collecting time related stats.
This will enable
...@linux.vnet.ibm.com
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part]
---
arch/powerpc/include/asm/smp.h |2 +-
arch/powerpc/kernel/smp.c | 12 +---
arch/powerpc/platforms/cell/interrupt.c |2
Hi Peter,
On 02/07/2014 06:11 PM, Peter Zijlstra wrote:
On Fri, Feb 07, 2014 at 05:11:26PM +0530, Preeti U Murthy wrote:
But observe the idle state snooze on powerpc. The power that this idle
state saves is through the lowering of the thread priority of the CPU.
After it lowers the thread
() should be called in the reboot path generically. The
latter might not be an enticing option for other platforms.
Regards
Preeti U Murthy
Now the deal is how do we move to nominal frequency on reboot..
@Rafael: Any suggestions? How do we ensure that governors
are stopped on these notifiers
balancing?
Regards
Preeti U Murthy
-#define SD_SIBLING_INIT (struct sched_domain) {
\
- .min_interval = 1,\
- .max_interval = 2,\
-#define SD_MC_INIT
sched: power aware load balance
sched: lazy power balance
sched: don't do power balance on share cpu power domain
Preeti U Murthy (3):
sched/power: Remove cpu idle state selection and cpu frequency tuning
sched/power: Move idle state selection into the scheduler
.
This will enable us to benchmark and optimize the power aware scheduler
from scratch.If we are to benchmark it against the performance of the
existing design, we will get sufficiently distracted by the performance
numbers and get steered away from a sane design.
Signed-off-by: Preeti U Murthy pre
as the logic used
by the menu governor. However going ahead the heuristics will be tuned and
improved upon with metrics better known to the scheduler.
Note: cpufrequency is still left disabled when CONFIG_SCHED_POWER is selected.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
to fill up the topology
levels with appropriate cpuidle state information while they discover
it themselves.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-powernv.c |8
include/linux/sched.h |3 +++
2 files changed, 11 insertions
in the
group is full, power oriented.
The incoming patches will enable powersaving scheduling in CFS.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c |5
-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Documentation/ABI/testing/sysfs-devices-system-cpu | 23 +++
kernel/sched/fair.c| 69
2 files changed, 92 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-devices-system
@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/debug.c |3 +++
kernel/sched/fair.c | 15 +++
kernel/sched/sched.h |9 +
3 files changed, 27 insertions(+)
diff --git a/kernel
-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c |9 +
1 file changed, 9 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 681ad06..3d6d081
From: Alex Shi alex@intel.com
Power aware fork/exec/wake balancing needs both of structs in incoming
patches. So move ahead before it.
Signed-off-by: Alex Shi alex@intel.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c | 89
.
The 'sysctl_sched_burst_threshold' used for wakeup burst, set it as
double of sysctl_sched_migration_cost.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
include/linux/sched/sysctl.h |3 +++
kernel/sched
. Then the rq utilization is sum of rt util and cfs
util.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c | 47 +++
1
a idlest cpu from the busiest while still has
utilization group, if the system is using power aware policy and
has such group.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched
alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched
a idlest
cpu in leader group.
Morten Rasmussen catch a type bug. And PeterZ reminder to consider
rt_util. thanks you!
Inspired-by: Vincent Guittot vincent.guit...@linaro.org
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U
group has no tasks
at the time, that is the power balance hope so.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c | 51
@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c |8
1 file changed, 8 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e7a677e..f9b2a21 100644
--- a/kernel/sched
utilizations of group_min
Signed-off-by: Alex Shi alex@intel.com
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c |4
1 file changed, 4 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fd93eaf..6d40aa3 100644
--- a/kernel
load balance code.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/sched/fair.c | 126 +++
1 file changed, 125 insertions(+), 1
-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
include/linux/sched.h |4 ++-
kernel/sched/fair.c | 70 +
2 files changed, 61 insertions(+), 13 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 009da6a
From: Alex Shi alex@intel.com
Packing tasks among such domain can't save power, just performance
losing. So no power balance on them.
Signed-off-by: Alex Shi alex@intel.com
[Added CONFIG_SCHED_POWER switch to enable this patch]
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
On 08/18/2014 09:24 PM, Nicolas Pitre wrote:
On Mon, 11 Aug 2014, Preeti U Murthy wrote:
The goal of the power aware scheduling design is to integrate all
policy, metrics and averaging into the scheduler. Today the
cpu power management is fragmented and hence inconsistent.
As a first step
On 08/18/2014 09:09 PM, Nicolas Pitre wrote:
On Mon, 11 Aug 2014, Preeti U Murthy wrote:
As a first step towards improving the power awareness of the scheduler,
this patch enables a dumb state where all power management is turned off.
Whatever additionally we put into the kernel for cpu
?
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
as compared to nap/fastsleep
and traced the problem to the pstate of the core being kept at a high even
when the core is offline. This can keep the socket pstate high, thus burning
power unnecessarily. This patchset fixes this issue.
---
Preeti U Murthy (2):
cpufreq: Allow stop CPU callback
.
The assumption is if the drivers find the GOV_STOP path to be a suitable
way of implementing what they want to do with the freq of the cpu
going offine,they will not implement the stop CPU callback at all.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpufreq/cpufreq.c |2
gets hotplugged out.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpufreq/powernv-cpufreq.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 379c083..7bb988e 100644
--- a/drivers
On 09/05/2014 12:37 PM, Viresh Kumar wrote:
On 5 September 2014 12:31, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
+ smp_call_function_any(policy-cpus, set_pstate, freq_data, 1);
We will surely have a single CPU alive at this point, so should we call
this function on policy-cpu
.
The assumption is if the drivers find the GOV_STOP path to be a suitable
way of implementing what they want to do with the freq of the cpu
going offine,they will not implement the stop CPU callback at all.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpufreq/cpufreq.c |2
gets hotplugged out.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpufreq/powernv-cpufreq.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 379c083..5a628f1 100644
--- a/drivers
() to smp_call_function_single() in
Patch[2/2]
---
Preeti U Murthy (2):
cpufreq: Allow stop CPU callback to be used by all cpufreq drivers
powernv/cpufreq: Set the pstate of the last hotplugged out cpu in
policy-cpus to minimum
drivers/cpufreq/cpufreq.c |2 +-
drivers/cpufreq/powernv-cpufreq.c
-sum_nr_running += rq-nr_running;
+ sgs-sum_nr_running += rq-cfs.h_nr_running;
Yes this was one of the concerns I had around the usage of
rq-nr_running. Looks good to me.
if (rq-nr_running 1)
*overload = true;
Reviewed-by: Preeti U Murthy pre
? There are no real time
tasks/interrupts that get generated.
Besides, what is the column that says patchset+irq? What is the irq
accounting patchset that you refer to in your cover letter?
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Vincent,
On 09/03/2014 10:28 PM, Vincent Guittot wrote:
On 3 September 2014 14:21, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi,
Hi Preeti,
There are places in kernel/sched/fair.c in the load balancing part where
rq-nr_running is used as against cfs_rq-nr_running. At least I
, we
would anyway not be able to load balance. So while I was looking through
this patch, I noticed this and wanted to cross verify if we are checking
rq-nr_running on purpose in some places in load balancing; another
example being in nohz_kick_needed().
Regards
Preeti U Murthy
--
To unsubscribe
this check above? I understand that it is not
crucial, but that would also mean removing ARCH_CAPACITY sched_feat
altogether, wouldn't it?
Regards
Preeti U Murthy
- capacity *= arch_scale_smt_capacity(sd, cpu);
- else
- capacity
;
+ return false;
if (time_before(now, nohz.next_balance))
- return 0;
+ return false;
if (rq-nr_running = 2)
Will this check ^^ not catch those cases which this patch is targeting?
Regards
Preeti U Murthy
- goto need_kick
Today the procfs interface /proc/sys/kernel/powersave-nap is used to control
entry into deep idle states beyond snooze. Check for the value of this
parameter before entering fastsleep. We already do this check for nap in
power7_idle().
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Hi Peter, Vincent,
On 09/03/2014 10:28 PM, Vincent Guittot wrote:
On 3 September 2014 14:21, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi,
Hi Preeti,
There are places in kernel/sched/fair.c in the load balancing part where
rq-nr_running is used as against cfs_rq-nr_running
On 09/15/2014 12:29 PM, Michael Ellerman wrote:
On Fri, 2014-09-12 at 16:31 +0530, Preeti U Murthy wrote:
Today the procfs interface /proc/sys/kernel/powersave-nap is used to control
entry into deep idle states beyond snooze. Check for the value of this
parameter before entering fastsleep. We
a comment
which assumes that cpuset masks are changed only during a hot-unplug operation.
With this patch it is ensured that cpuset masks are consistent with online cpus
in both default and legacy hierarchy.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/cpuset.c | 38
Hi Peter,
On 10/08/2014 01:37 PM, Peter Zijlstra wrote:
On Wed, Oct 08, 2014 at 12:37:40PM +0530, Preeti U Murthy wrote:
There are two masks associated with cpusets. The cpus/mems_allowed
and effective_cpus/mems. On the legacy hierarchy both these masks
are consistent with each other
Hi Raghu,
On 10/08/2014 08:24 PM, Raghavendra KT wrote:
On Wed, Oct 8, 2014 at 12:37 PM, Preeti U Murthy
pre...@linux.vnet.ibm.com wrote:
There are two masks associated with cpusets. The cpus/mems_allowed
and effective_cpus/mems. On the legacy hierarchy both these masks
are consistent
On 10/08/2014 03:48 PM, Peter Zijlstra wrote:
On Wed, Oct 08, 2014 at 03:07:51PM +0530, Preeti U Murthy wrote:
I still completely hate all that.. It basically makes cpusets useless,
they no longer guarantee anything, it makes then an optional placement
hint instead.
Why do you say
thread has restored it
anyway. So we are safe. We will certainly add a comment there.
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
with reality except
for the first entry.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Do we still need this workaround? Or can we get rid of the check
on powersave_nap altogether?
---
drivers/cpuidle/cpuidle-powernv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 10/28/2014 11:58 PM, Daniel Lezcano wrote:
On 10/28/2014 08:01 AM, Preeti Murthy wrote:
On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
In the current code, the check to reflect or not the outcoming state
is done
against the idle state which has been
On 10/29/2014 12:29 AM, Daniel Lezcano wrote:
On 10/28/2014 04:51 AM, Preeti Murthy wrote:
Hi Daniel,
On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
When the pmqos latency requirement is set to zero that means poll in
all the
cases.
That is correctly
Hi Joel,
On 11/19/2014 08:04 AM, Joel Stanley wrote:
Hey Preeti,
On Tue, Nov 18, 2014 at 5:26 PM, Preeti U Murthy
pre...@linux.vnet.ibm.com wrote:
Commit dcb18694 Fix ipi on palmeto disabled fastsleep at boot time.
I couldn't find this commit in any tree; upstream, mpe's next, nor
)
+ print_name_offset(m, dev-set_dev_mode);
+ else
+ print_name_offset(m, dev-set_mode);
SEQ_printf(m, \n);
SEQ_printf(m, event_handler: );
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On 09/05/2014 05:57 PM, Vincent Guittot wrote:
On 5 September 2014 14:19, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 09/03/2014 10:28 PM, Vincent Guittot wrote:
On 3 September 2014 14:21, Preeti U Murthy pre...@linux.vnet.ibm.com
wrote:
Hi,
Hi Preeti
401 - 500 of 1331 matches
Mail list logo