Re: [PATCH v2 3/5] drm/bridge: squash lines for simple wrapper functions

2016-09-15 Thread Sean Paul
On Thu, Sep 15, 2016 at 9:51 AM, Sean Paul wrote: > On Wed, Sep 14, 2016 at 10:39 AM, Masahiro Yamada > wrote: >> Remove unneeded variables and assignments. >> >> Signed-off-by: Masahiro Yamada > > Reviewed-by: Sean Paul > Decided to apply patch

Re: [PATCH v2 1/7] [media] rc-main: assign driver type during allocation

2016-09-01 Thread Sean Young
, it will be > set as RC_DRIVER_SCANCODE which was the default '0' value. > > Suggested-by: Sean Young > Signed-off-by: Andi Shyti > --- ... > diff --git a/drivers/media/pci/cx88/cx88-input.c > b/drivers/media/pci/cx88/cx88-input.c > index 3f1342c..e52bf69 10

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-01 Thread Sean Young
Thanks Andi, this is looking great! On Fri, Sep 02, 2016 at 02:16:29AM +0900, Andi Shyti wrote: > The ir-spi is a simple device driver which supports the > connection between an IR LED and the MOSI line of an SPI device. > > The driver, indeed, uses the SPI framework to stream the raw data > prov

Re: [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters

2016-09-01 Thread Sean Young
ce applications, therefore they > don't need any input device allocation, but still they need to be > registered as raw devices. > > Suggested-by: Sean Young > Signed-off-by: Andi Shyti > --- > drivers/media/rc/rc-main.c | 39 +++ > in

Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices

2016-09-02 Thread Sean Young
ensures that it waits as long as the IR is long (see schedule_repeat_timer in lirc). This change was introduced in 3.10, commit f8e00d5. Sean

Re: [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI

2016-09-02 Thread Sean Young
On Fri, Sep 02, 2016 at 02:27:08PM +0900, Andi Shyti wrote: > > Thanks Andi, this is looking great! > > Thanks Sean! With your reviews the whole thing looks much better > now :) > > I agree with all your points here, I will fix them. Can I add > your reviewd-by? Yes, ple

Re: [PATCH v2 0/7] drm/mediatek: cleaning up and refine

2016-08-04 Thread Sean Paul
ach page and the cover letter for what changed between v1 and v2. I've queued these up for -misc once the merge window closes. Sean > -- > 1.7.9.5 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-04 Thread Sean Paul
t have a few nits in the transfer() function. Tested-by: Sean Paul > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 390 > +++-- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 39 +-- > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 324 --

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-05 Thread Sean Paul
e to > use them instead of duplicating them. > > Signed-off-by: Tomeu Vizoso > Tested-by: Javier Martinez Canillas > Tested-by: Sean Paul > Cc: Javier Martinez Canillas > Cc: Mika Kahola > Cc: Yakir Yang > Cc: Daniel Vetter > Thanks for the respin. Reviewed-by: Se

[PATCH v2] drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-08 Thread Sean Paul
d-off-by: Sean Paul --- Changes in v2: - Added panel_is_modeset state/lock to avoid racing detect with modeset (marcheu) - Added prepare/unprepare in .get_modes (yakir) drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 101 ++--- drivers/gpu/drm/bridge/analogix/analogix_dp_c

[PATCH] drm/bridge: analogix_dp: Don't read EDID if panel present

2016-08-24 Thread Sean Paul
es in their get_modes implementation. Signed-off-by: Sean Paul --- This patch is based on Tomeu's cleanup patch which can be found here: https://patchwork.freedesktop.org/patch/107114/ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insert

[PATCH v3] drm/bridge: analogix_dp: Remove duplicated code

2016-08-24 Thread Sean Paul
: Tomeu Vizoso Tested-by: Javier Martinez Canillas Tested-by: Sean Paul Reviewed-by: Sean Paul Signed-off-by: Sean Paul Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter Cc: Archit Taneja --- v2: - A bunch of good fixes from Sean and Yakir - Moved the

Re: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number

2016-08-25 Thread Sean Paul
On Thu, Aug 25, 2016 at 1:15 PM, Sean Paul wrote: > > > On Wed, Aug 24, 2016 at 10:25 PM, Mark yao wrote: >> >> On 2016年08月23日 21:13, Sean Paul wrote: >>> >>> On Mon, Aug 22, 2016 at 8:40 PM, Mark yao >>> wrote: >>>> >>>>

Re: [PATCH v3 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding

2017-08-15 Thread Sean Wang
the controller and dma base, length of > memory > mapped region. >- interrupts: interrupt number to the cpu. Hi, Jun the patch for new soc support and clean-ups should better be in separate patch following previous Matthias suggestion. http://lists.infradead.org/pipermail/linux-mediatek/2017-August/009740.html And also spelling for Mediatek should be corrected using MediaTek. Sean

Re: [PATCH v3 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622

2017-08-15 Thread Sean Wang
On Tue, 2017-08-15 at 21:08 +0800, Jun Gao wrote: > From: Jun Gao > > Add i2c compatible for MT7622. Compare to MT8173 i2c controller, > MT7622 limits message numbers to 255, and does not support 4GB > DMA mode. > > Signed-off-by: Jun Gao you seemed missing a Reviewed-by tag from Joe.C http:/

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-20 Thread Sean Wang
1:56:53PM +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Changes since v1: > > - update the bindings with the specific "mediatek,mt7622-rng" > > instead of the generic one as "mediatek,generic-rng" > > > > The ser

Re: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622

2017-06-20 Thread Sean Wang
On Tue, 2017-06-20 at 16:59 +0200, Torsten Duwe wrote: > On Tue, Jun 20, 2017 at 10:21:17PM +0800, Sean Wang wrote: > > Hi Herbert, > > > > thanks for effort reviewing on those patches. > > > > By the way, also loop in Torsten > > > > Could you

Re: [PATCH] fs: buffer: Modify alloc_page_buffers.

2017-06-21 Thread Sean Fu
On Mon, Jun 19, 2017 at 05:03:16PM +0100, Al Viro wrote: > On Mon, Jun 19, 2017 at 09:01:36PM +0800, Sean Fu wrote: > > Make alloc_page_buffers support circular buffer list and initialise > > b_state field. > > Optimize the performance by removing the buffer list traversal t

Re: [PATCH v4 4/7] soc: mediatek: pwrap: update pwrap_init without slave programming

2017-10-15 Thread Sean Wang
On Fri, 2017-10-13 at 16:07 +0200, Matthias Brugger wrote: > > On 10/13/2017 11:41 AM, Sean Wang wrote: > > On Tue, 2017-10-10 at 20:00 +0200, Matthias Brugger wrote: > >> > >> On 09/21/2017 10:26 AM, sean.w...@mediatek.com wrote: > >>> From: Sean Wang

Re: [PATCH v2] soc: mediatek: place Kconfig for all SoC drivers under menu

2017-10-16 Thread Sean Wang
On Thu, 2017-10-05 at 10:52 +0200, Jean Delvare wrote: > Hi Sean, > > On Thu, 5 Oct 2017 11:17:49 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add cleanup for placing all Kconfig for all MediaTek SoC drivers under > > the independent menu

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-16 Thread Sean Wang
Hi Alexandre, Thanks for your valuable suggestions on the driver. I added comments inline and will have following-ups in the next version Sean On Thu, 2017-10-12 at 23:20 +0200, Alexandre Belloni wrote: > Hi, > > On 22/09/2017 at 11:33:15 +0800, sean.w...@mediatek.com wrote:

Re: [PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-16 Thread Sean Paul
; ) > When I run this spatch on drm-tip, I get a bunch more changes than this (below). Are you just running it on i915_pci? Sean diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 09d97e0990b7..2f106cca46b4 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/

Re: [PATCH v5] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-16 Thread Sean Paul
On Mon, Oct 16, 2017 at 2:53 PM, Harsha Sharma wrote: > On Tue, Oct 17, 2017 at 12:15 AM, Sean Paul wrote: >> On Sat, Oct 14, 2017 at 2:36 PM, Harsha Sharma >> wrote: >>> Replace instances of drm_framebuffer_reference/unreference() with >>> *_get/put() suff

Re: [Outreachy kernel] [PATCH] drm/tinydrm: Replace list_for_each with list_for_each_entry

2017-10-16 Thread Sean Paul
gt; } > > @@ > identifier s.p; > @@ > > - struct list_head *p; > ... when != p > > @@ > identifier s.i,s.f; > expression s.e; > statement S; > @@ > > list_for_each_entry(i,e,f) > - { > S > - } > > Signed-off-by: Harsha Sharma

Re: [PATCH 2/5] drm: Add new LEASE debug level

2017-10-16 Thread Sean Paul
On Thu, Oct 12, 2017 at 06:56:28PM -0700, Keith Packard wrote: > Separate out lease debugging from the core. > > Signed-off-by: Keith Packard Reviewed-by: Sean Paul > --- > drivers/gpu/drm/drm_drv.c | 3 ++- > include/drm/drmP.h| 4 > 2 files changed, 6 inse

Re: [PATCH 1/5] drm/plane: drop num_overlay_planes (v2)

2017-10-16 Thread Sean Paul
the need > for num_overlay_planes. > > v2: don't forget to assign plane_ptr. (keithp) > > Signed-off-by: Dave Airlie Reviewed-by: Sean Paul > --- > drivers/gpu/drm/drm_mode_config.c | 1 - > drivers/gpu/drm/drm_plane.c | 46 > ++

Re: [PATCH 3/5] drm: Add drm_object lease infrastructure [v4]

2017-10-16 Thread Sean Paul
s to all leased objects Can you add "(idr_mutex held)" like you have in _drm_lease_held()? > + * @master: the master losing its lease s/master/top/ > + */ > + > +void _drm_lease_revoke(struct drm_master *top) > +{ > + int object; > + void *entry; > +

Re: [PATCH 4/5] drm: Check mode object lease status in all master ioctl paths [v3]

2017-10-16 Thread Sean Paul
by Dave Airlie > > * remove support for leasing encoders. > * add support for leasing planes. > > Signed-off-by: Keith Packard > Signed-off-by: Dave Airlie Reviewed-by: Sean Paul > --- > drivers/gpu/drm/drm_auth.c| 2 +- > drivers/gpu/drm/drm_

Re: [PATCH 5/5] drm: Add four ioctls for managing drm mode object leases [v6]

2017-10-16 Thread Sean Paul
ode_get_lease) > +#define DRM_IOCTL_MODE_REVOKE_LEASE DRM_IOWR(0xC9, struct > drm_mode_revoke_lease) > + > /** > * Device specific ioctls should only be in their respective headers > * The device specific ioctl range is from 0x40 to 0x9f. > diff --git a/include/uapi/drm/drm_mode.h b/include/ua

Re: [PATCH 3/5] drm: Add drm_object lease infrastructure [v4]

2017-10-16 Thread Sean Paul
On Mon, Oct 16, 2017 at 01:42:46PM -0700, Keith Packard wrote: > Sean Paul writes: > > > > With these nits fixed, > > Reviewed-by: Sean Paul > > Like this? > Perfect, thanks! Sean > From 0aa52dd5a0873831c79c14942075354c041e5bed Mon Sep 17 00:00:00 2001 &

Re: [PATCH 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-16 Thread Sean Wang
On Mon, 2017-10-16 at 16:17 +0800, Sean Wang wrote: > Hi Alexandre, > > Thanks for your valuable suggestions on the driver. > > I added comments inline and will have following-ups in the next version > > Sean > > On Thu, 2017-10-12 at 23:20 +0200, Alex

Re: [PATCH v5 6/7] soc: mediatek: pwrap: add support for MT7622 SoC

2017-10-17 Thread Sean Wang
> > > Signed-off-by: Chenglin Xu > > Signed-off-by: Chen Zhong > > Signed-off-by: Sean Wang > > --- > > drivers/soc/mediatek/mtk-pmic-wrap.c | 180 > > +++ > > 1 file changed, 180 insertions(+) > > > > dif

Re: [PATCH v3 3/4] drm/rockchip: Add support for Rockchip Soc RGB output interface

2017-10-17 Thread Sean Paul
> + ret = drm_panel_attach(rgb->panel, connector); > + if (ret < 0) { > + DRM_DEV_ERROR(drm_dev->dev, > + "failed to attach panel: %d\n", ret); > + goto err_f

Re: [PATCH v3 4/4] drm/rockchip: vop: Add more RGB output interface type

2017-10-17 Thread Sean Paul
; > Signed-off-by: Sandy Huang Reviewed-by: Sean Paul > --- > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h > b/dri

Re: [RFC PATCH v4 2/8] drm/rockchip: analogix_dp: Fix error handling path

2017-10-17 Thread Sean Paul
k_disable_unprepare(dp->pclk); Hi Jeffy, This part of the cleanup is handling things setup by rockchip_dp_init(). However if someone adds something to rockchip_dp_init(), it's not obvious that it should be cleaned up here and in unbind(). I'd suggest rebasing this on a new patch whi

Re: [RFC PATCH v4 3/8] drm/rockchip: dw-mipi-dsi: Fix error handling path

2017-10-17 Thread Sean Paul
_set_drvdata(dev, dsi); > return 0; > > -err_mipi_dsi_host: > +err_unreg_mipi_dsi_host: > mipi_dsi_host_unregister(&dsi->dsi_host); > -err_cleanup: > +err_disable_pm_runtime: > + pm_runtime_disable(dev); > drm_encoder_cleanup(&dsi->encoder);

Re: [RFC PATCH v4 4/8] drm/rockchip: dw_hdmi: Fix error handling path

2017-10-17 Thread Sean Paul
clk_disable_unprepare(hdmi->vpll_clk); Same comment with respect to rockchip_hdmi_parse_dt(). This bug would have probably been avoided if the contents of rockchip_hdmi_parse_dt() were inline with dw_hdmi_rockchip_bind(), since then it's obvious what needs to be cleaned up. Sean > + } > > return ret; > } > -- > 2.11.0 > > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [RFC PATCH v4 5/8] drm/rockchip: inno_hdmi: Fix error handling path

2017-10-17 Thread Sean Paul
mi; > > + return 0; > +err_cleanup_hdmi: > + drm_connector_cleanup(&hdmi->connector); > + drm_encoder_cleanup(&hdmi->encoder); Same question regarding cleanup vs destroy. > +err_put_adapter: > + i2c_put_adapter(hdmi->ddc); > +err_disable_clk: >

Re: [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata

2017-10-17 Thread Sean Paul
g their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Jeffy Chen > Reviewed-by: Andrzej Hajda Reviewed-by: Sean Paul > --- > > Changes in v4: None > Changes in v3: None > Changes in v2: N

Re: [RFC PATCH v4 8/8] drm/rockchip: Add device links for master and components

2017-10-17 Thread Sean Paul
nup_dev_links; This cleanup should take place in rockchip_drm_match_add(). The review theme for this entire series is that, when possible, we should cleanup things where they are initialized. Since you'll also need to clean up the links elsewhere, consider adding a helper function to do the cle

Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer

2017-05-26 Thread Sean Paul
On Fri, May 26, 2017 at 10:30:09AM +0800, jeffy wrote: > Hi sean, > > On 05/25/2017 11:30 PM, Sean Paul wrote: > > On Tue, May 23, 2017 at 02:39:43PM +0800, Jeffy Chen wrote: > > > The system would crash when trying to alloc zero sized gem buffer: > > > [6.712

Re: [PATCH v2 4/4] arm64: dts: mt7622: group clock DT nodes into separate DT file

2017-05-29 Thread Sean Wang
On Mon, 2017-05-29 at 17:09 +0200, Matthias Brugger wrote: > > On 29/05/17 14:56, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > For more readability and maintenance, all the clock related DT > > nodes for mt7622 SoC are grouped into a separate DT

Re: [PATCH] media: av7110: switch to useing timer_setup()

2017-10-31 Thread Sean Young
scancodes for the remote(s) are, for example. Any suggestions for what hardware to get off ebay for this? New patch will be reply this. Thanks, Sean

[PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young --- drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 54 ++--- 2 files changed, 21 insertions

Re: [PATCH] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Hi Dmitry, On Tue, Oct 31, 2017 at 11:22:36AM -0700, Dmitry Torokhov wrote: > Hi Sean, > > On Tue, Oct 31, 2017 at 05:45:58PM +0000, Sean Young wrote: > > Leave the autorepeat handling up to the input layer, and move > > to the new timer API. > > > > Compile te

[PATCH v2] media: ttpci: remove autorepeat handling and use timer_setup

2017-10-31 Thread Sean Young
Leave the autorepeat handling up to the input layer, and move to the new timer API. Compile tested only. Signed-off-by: Sean Young --- v2: - fixes and improvements from Dmitry Torokhov drivers/media/pci/ttpci/av7110.h| 2 +- drivers/media/pci/ttpci/av7110_ir.c | 56

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-11-01 Thread Sean Paul
ou need the patchset where I've refactored the psr locking/workers. I have a version of it based on Heiko's tree at https://cgit.freedesktop.org/~seanpaul/dogwood/log/?h=rk3399-display With this kernel, the backlight comes on, but I don't have anything on the display (which is why I didn

Re: [PATCH 1/4] drm/msm/dsi: convert to msm_clk_get()

2017-10-24 Thread Sean Paul
> in bindings while maintaing backwards compatibility. > > Signed-off-by: Rob Clark Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 8 > drivers/gpu/drm/msm/dsi/dsi_host.c| 30 +++--- > drivers/gpu/drm/ms

Re: [PATCH 2/4] drm/msm/edp: convert to msm_clk_get()

2017-10-24 Thread Sean Paul
> in bindings while maintaing backwards compatibility. > > Signed-off-by: Rob Clark Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/edp/edp_ctrl.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/msm/e

Re: [PATCH 3/4] drm/msm/hdmi: convert to msm_clk_get()

2017-10-24 Thread Sean Paul
> in bindings while maintaing backwards compatibility. > > Signed-off-by: Rob Clark Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 10 +- > drivers/gpu/drm/msm/hdmi/hdmi_phy.c | 2 +- > drivers/gpu/drm/msm/hdmi/hdmi_phy_8960.c | 2 +

Re: [PATCH v3 1/6] drm/rockchip/dsi: Define and use macros for PHY register addresses

2017-10-25 Thread Sean Paul
On Wed, Oct 25, 2017 at 11:50:58AM +0800, Nickey Yang wrote: > Replace the hardcoded register address numerical values with macros to > clarify the code. > > Signed-off-by: Nickey Yang Reviewed-by: Sean Paul > --- > drivers/gpu/drm/rockchip/d

Re: [PATCH v3 2/6] drm/rockchip/dsi: correct phy parameter setting

2017-10-25 Thread Sean Paul
On Wed, Oct 25, 2017 at 11:50:59AM +0800, Nickey Yang wrote: > As MIPI PHY document show, icpctrl<3..0> and lpfctrl<5..0> > should depend on frequency,so fix it. > > Reviewed-by: Sean Paul > Reviewed-by: Matthias Kaehlcke > Signed-off-by: Nickey Yang >

Re: [PATCH v3 3/6] drm/rockchip/dsi: correct Feedback divider setting

2017-10-25 Thread Sean Paul
ould be helpful. In future, list the changes between patches and Cc people who have given you review on your previous versions (I've cc'd Archit and Kristian). Sean > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 93 > ++ > 1 file changed, 62 insertion

Re: [PATCH v3 4/6] drm/rockchip/dsi: add dual mipi channel support

2017-10-25 Thread Sean Paul
if (!dsi->slave) > + return -EPROBE_DEFER; Archit asked you not to do this in the previous review. > + > + dsi->slave->master = dsi; > + } > + > + return 0; > +} > -- > 1.9.1 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [intel-sgx-kernel-dev] [PATCH v5 08/11] intel_sgx: in-kernel launch enclave

2017-11-14 Thread Sean Christopherson
On Mon, 2017-11-13 at 21:45 +0200, Jarkko Sakkinen wrote: > This commits implements the in-kernel launch enclave. It is wrapped into > a user space program that reads SIGSTRUCT instances from stdin and > outputs launch tokens to stdout. > > The commit also adds enclave signing tool that is used by

Re: [intel-sgx-kernel-dev] [PATCH v5 06/11] intel_sgx: driver for Intel Software Guard Extensions

2017-11-14 Thread Sean Christopherson
On Mon, 2017-11-13 at 21:45 +0200, Jarkko Sakkinen wrote: > Intel SGX is a set of CPU instructions that can be used by applications > to set aside private regions of code and data.  The code outside the > enclave is disallowed to access the memory inside the enclave by the CPU > access control. >

Re: [intel-sgx-kernel-dev] [PATCH v5 10/11] intel_sgx: glue code for in-kernel LE

2017-11-14 Thread Sean Christopherson
On Mon, 2017-11-13 at 21:45 +0200, Jarkko Sakkinen wrote: > --- a/drivers/platform/x86/intel_sgx/sgx_main.c > +++ b/drivers/platform/x86/intel_sgx/sgx_main.c > @@ -88,6 +88,37 @@ u64 sgx_encl_size_max_64; >  u64 sgx_xfrm_mask = 0x3; >  u32 sgx_misc_reserved; >  u32 sgx_xsave_size_tbl[64]; > +bool s

Re: [PATCH] drm/rockchip: add CONFIG_OF dependency for lvds

2017-11-06 Thread Sean Paul
d support for Rockchip Soc LVDS") > Signed-off-by: Arnd Bergmann Thanks for the patch Arnd, I've pushed to drm-misc-next-fixes. Sean > --- > drivers/gpu/drm/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

2017-10-18 Thread Sean Young
isi-tv-demo.c > b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c > new file mode 100644 > index 000..410b17d > --- /dev/null > +++ b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c > @@ -0,0 +1,70 @@ > +#include > +#include Both keymaps are missing a copyri

Re: [PATCH v2 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-18 Thread Sean Wang
On Wed, 2017-10-18 at 17:52 +0800, Yingjoe Chen wrote: > On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > This patch introduces the driver for the RTC on MT7622 SoC. > > > > Signed-off-by: Sean Wang > >

Re: [PATCH v2 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-18 Thread Sean Wang
Hi, both On Wed, 2017-10-18 at 14:57 +0200, Alexandre Belloni wrote: > On 18/10/2017 at 19:12:06 +0800, Yingjoe Chen wrote: > > On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote: > > > From: Sean Wang > > > > > > This patch introduces

Re: [PATCH v2 1/4] dt-bindings: rtc: mediatek: add bindings for MediaTek SoC based RTC

2017-10-18 Thread Sean Wang
On Wed, 2017-10-18 at 21:32 +0800, Yingjoe Chen wrote: > On Tue, 2017-10-17 at 17:40 +0800, sean.w...@mediatek.com wrote: > > From: Sean Wang > > > > Add device-tree binding for MediaTek SoC based RTC > > > > Cc: devicet...@vger.kernel.org > > Signed-off-b

Re: [PATCH v2 2/4] rtc: mediatek: add driver for RTC on MT7622 SoC

2017-10-19 Thread Sean Wang
On Thu, 2017-10-19 at 11:02 +0200, Alexandre Belloni wrote: > On 19/10/2017 at 10:55:49 +0800, Sean Wang wrote: > > Hi, both > > > > On Wed, 2017-10-18 at 14:57 +0200, Alexandre Belloni wrote: > > > On 18/10/2017 at 19:12:06 +0800, Yingjoe Chen wrote: > > &

RE: [PATCH v5 0/4] PCI: Add support for PCI Enhanced Allocation "BARs"

2015-10-07 Thread Stalley, Sean
[PATCH 3/4 & 4/4] Acked-by: Sean O. Stalley I won't be able to test it out until next week, but I like how it looks :) Thanks Again, Sean > -Original Message- > From: David Daney [mailto:ddaney.c...@gmail.com] > Sent: Tuesday, October 06, 2015 4:51 PM > To: linux-k

Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success.

2015-08-27 Thread Sean Fu
On Thu, Aug 27, 2015 at 4:32 PM, Sean Fu wrote: > On Thu, Aug 27, 2015 at 10:32 AM, Steven Rostedt wrote: >> On Thu, 27 Aug 2015 08:17:29 +0800 >> Sean Fu wrote: >> >>> On Thu, Aug 27, 2015 at 4:36 AM, Steven Rostedt wrote: >>> > On Wed, 26 Au

Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success.

2015-09-07 Thread Sean Fu
On Fri, Aug 28, 2015 at 11:31 AM, Sean Fu wrote: > On Thu, Aug 27, 2015 at 4:32 PM, Sean Fu wrote: >> On Thu, Aug 27, 2015 at 10:32 AM, Steven Rostedt wrote: >>> On Thu, 27 Aug 2015 08:17:29 +0800 >>> Sean Fu wrote: >>>> strace execute result: >>&g

RE: [PATCH] infiniband:core:Fix mutex locking to lock before unlocking in the function cma_ib_mc_handler

2015-09-08 Thread Hefty, Sean
> This fixes mutex locking to lock before unlocking in the function > cma_ib_mc_handler for the mutex handler_mutex as part of the pointer > id_priv before unlocking it after the critical region for event handler > work and execution in order to have actual proper concurrent execution > protection

RE: [PATCH] infiniband:Fix error handling in the function cm_init_av_by_path

2015-09-08 Thread Hefty, Sean
r to handle the error in its own > intended error paths. > > Signed-off-by: Nicholas Krause Acked-by: Sean Hefty > --- > drivers/infiniband/core/cm.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/infiniband/core/cm.c b/drive

RE: [PATCH] infiniband:core:Fix error handling in the function join_handler

2015-09-08 Thread Hefty, Sean
lback to their join operation, and the SA believes that this port is part of the multicast group. If we don't get a valid pkey, the group will be left set to 'MCAST_INVALID_PKEY_INDEX'. - Sean -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

RE: [PATCH] infiniband:core:Fix assumation that the function ib_send_cm_drep never fails in rdma_disconnect

2015-09-08 Thread Hefty, Sean
> This fixes the incorrect assumation that the function ib_send_cm_drep > always runs successfully and never fails in the function rdma_disconnect > by making this call be assigned the variable used to return to callers > of rdma_disconnect in order to make sure that a error code is returned > if a

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-03 Thread Sean Wang
On Fri, 2018-08-03 at 14:51 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>>>>>> + > >>>>>>> +static int mtk_hci_wmt_sync(struct hci_dev *hdev, u8 op, u8 flag, > >>>>>>> u16 plen, > >>>>>>&g

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-03 Thread Sean Wang
On Fri, 2018-08-03 at 19:19 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>>>>>>>> + > >>>>>>>>> +static int mtk_hci_wmt_sync(struct hci_dev *hdev, u8 op, u8 flag, > >>>>>>>>> u16 plen, > >>

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-07 Thread Sean Wang
On Mon, 2018-08-06 at 17:39 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>>>>>>>>>> + [ ... ] > >> this is even more hackish since the __hci_cmd_sync_ev command is really > >> meant to get a cmd status first before waiting for that

[PATCH] x86/pkeys: Explicitly treat PK #PF on kernel address as a bad area

2018-08-07 Thread Sean Christopherson
gardless of the kernel's TLB flushing behavior. [1] http://lists-archives.com/linux-kernel/28407455-x86-pkeys-new-page-fault-error-code-bit-pf_pk.html Signed-off-by: Sean Christopherson Cc: Dave Hansen --- There's no indication that this condition has ever been encountered.

Re: [PATCH] fs/buffer.c: Optimize grow_buffer function.

2018-08-07 Thread Sean Fu
On Sat, Jul 21, 2018 at 07:21:16PM +0100, Al Viro wrote: > On Sun, Jul 22, 2018 at 01:30:17AM +0800, Sean Fu wrote: > > Use PAGE_SHIFT and i_blkbits of bd_inode directly to avoid ugly sizebits > > calculation. > > Remove ugly sizebits calculation. > > Remove unnece

Re: [PATCH] soc: mediatek: pwrap: use true and false for boolean values

2018-08-08 Thread Sean Wang
ers/soc/mediatek/mtk-pmic-wrap.c > @@ -1096,7 +1096,7 @@ static bool pwrap_is_pmic_cipher_ready(struct > pmic_wrapper *wrp) > ret = pwrap_read(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_RDY], >&rdata); > if (ret) > -

Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-20 Thread Sean Christopherson
On Fri, 2018-06-08 at 19:09 +0200, Jarkko Sakkinen wrote: > SGX has a set of data structures to maintain information about the enclaves > and their security properties. BIOS reserves a fixed size region of > physical memory for these structures by setting Processor Reserved Memory > Range Registers

Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave

2018-06-20 Thread Sean Christopherson
On Wed, Jun 20, 2018 at 11:39:00AM -0700, Jethro Beekman wrote: > On 2018-06-20 11:16, Jethro Beekman wrote: > > > This last bit is also repeated in different words in Table 35-2 and > > > Section 42.2.2. The MSRs are *not writable* before the write-lock bit > > > itself is locked. Meaning the MSRs

Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave

2018-06-21 Thread Sean Christopherson
it > manages to actually maximize both security and freedom. > > [0]: details here - > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/README#n19 > On Thu, Jun 21, 2018 at 11:29 AM Neil Horman wrote: > > > > On Thu, Jun 21, 2

Re: [lkp-robot] [fs] 3deb642f0d: will-it-scale.per_process_ops -8.8% regression

2018-06-22 Thread Sean Paul
d that you have to insult not only the author, but also people with speech impediments? Sean > > mask = vfs_poll(f.file, wait); > > + if (f.file->f_op->poll) { > > ... not to mention that here you forgot

Re: [PATCH] HID: add support for Apple Magic Keyboards

2018-08-27 Thread Sean O'Brien
On Mon, Aug 27, 2018 at 5:19 AM Benjamin Tissoires wrote: > > Hi Sean, > > On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote: > > > > USB device > > Vendor 05ac (Apple) > > Device 026c (Magic Keyboard with Numeric Keypad) > > >

[PATCH] [v2] HID: add support for Apple Magic Keyboards

2018-08-27 Thread Sean O'Brien
connection. Add support for the Magic Keyboard over Bluetooth connection, and for the Magic Keyboard with Numeric Keypad over Bluetooth and USB connection. Signed-off-by: Sean O'Brien --- drivers/hid/hid-apple.c | 9 - drivers/hid/hid-ids.h | 2 ++ 2 files changed, 10 insertions(

[PATCH] HID: add support for Apple Magic Trackpad 2

2018-08-27 Thread Sean O'Brien
Signed-off-by: Marek Wyborski Signed-off-by: Sean O'Brien --- drivers/hid/hid-ids.h| 2 + drivers/hid/hid-magicmouse.c | 187 --- 2 files changed, 152 insertions(+), 37 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h

[PATCH] [v2] HID: add support for Apple Magic Trackpad 2

2018-08-28 Thread Sean O'Brien
Signed-off-by: Marek Wyborski Signed-off-by: Sean O'Brien --- drivers/hid/hid-ids.h| 2 + drivers/hid/hid-magicmouse.c | 184 --- 2 files changed, 149 insertions(+), 37 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h

Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

2018-08-28 Thread Sean Christopherson
On Tue, Aug 28, 2018 at 07:07:33AM -0700, Dave Hansen wrote: > On 08/28/2018 01:35 AM, Jarkko Sakkinen wrote: > > On Mon, Aug 27, 2018 at 02:15:34PM -0700, Dave Hansen wrote: > >> On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > >>> +struct sgx_epc_page_ops { > >>> + bool (*get)(struct sgx_epc_page

Re: [PATCH v13 07/13] x86/sgx: Add data structures for tracking the EPC pages

2018-08-28 Thread Sean Christopherson
On Tue, Aug 28, 2018 at 09:53:11AM -0700, Dave Hansen wrote: > >>> + sgx_nr_epc_banks++; > >>> + } > >>> + > >>> + if (!sgx_nr_epc_banks) { > >>> + pr_err("There are zero EPC banks.\n"); > >>> + return -ENODEV; > >>> + } > >>> + > >>> + return 0; > >>> +} > >> > >> Does this

Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager

2018-08-28 Thread Sean Christopherson
On Tue, Aug 28, 2018 at 02:26:36PM -0700, Dave Hansen wrote: > On 08/28/2018 02:22 PM, Sean Christopherson wrote: > > On Tue, Aug 28, 2018 at 07:07:33AM -0700, Dave Hansen wrote: > >> On 08/28/2018 01:35 AM, Jarkko Sakkinen wrote: > >>> On Mon, Aug 27, 2018 at 02:15

Re: [PATCH] pinctrl: Convert to using %pOFn instead of device_node.name

2018-08-28 Thread Sean Wang
; Cc: Stefan Agner > Cc: Pengutronix Kernel Team > Cc: Sean Wang > Cc: Matthias Brugger > Cc: Carlo Caione > Cc: Kevin Hilman > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Gregory Clement > Cc: Sebastian Hesselbarth > Cc: Jean-Christophe Plagniol-Villard > Cc: Nic

Re: [PATCH v2 2/3] x86/mm: add .data..decrypted section to hold shared variables

2018-08-29 Thread Sean Christopherson
On Tue, Aug 28, 2018 at 05:12:56PM -0500, Brijesh Singh wrote: > kvmclock defines few static variables which are shared with hypervisor > during the kvmclock initialization. > > When SEV is active, memory is encrypted with a guest-specific key, and > if guest OS wants to share the memory region wi

Re: [PATCH v3 4/4] x86/kvm: use __decrypted attribute in shared variables

2018-08-29 Thread Sean Christopherson
ependency") > Cc: Tom Lendacky > Cc: k...@vger.kernel.org > Cc: Thomas Gleixner > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: linux-kernel@vger.kernel.org > Cc: Paolo Bonzini > Cc: Sean Christopherson > Cc: k...@vger.kernel.org > Cc: "Radi

Re: [RFC PATCH 1/6] x86/alternative: assert text_mutex is taken

2018-08-29 Thread Sean Christopherson
On Wed, Aug 29, 2018 at 07:36:22PM +, Nadav Amit wrote: > at 10:11 AM, Nadav Amit wrote: > > > at 1:59 AM, Masami Hiramatsu wrote: > > > >> On Wed, 29 Aug 2018 01:11:42 -0700 > >> Nadav Amit wrote: > >> > >>> Use lockdep to ensure that text_mutex is taken when text_poke() is > >>> called.

Re: [PATCH v13 10/13] x86/sgx: Add sgx_einit() for initializing enclaves

2018-08-29 Thread Sean Christopherson
X2 signals a #PF with the PF_SGX error code bit set. This is problematic because the kernel looks at the PTEs for CR2 and sees nothing wrong, so it thinks it should just restart the instruction, leading to an infinite fault loop. Resolving this is fairly straightforward, but a com

Re: [RFC PATCH 1/6] x86/alternative: assert text_mutex is taken

2018-08-29 Thread Sean Christopherson
On Wed, Aug 29, 2018 at 08:44:47PM +, Nadav Amit wrote: > at 1:13 PM, Sean Christopherson wrote: > > > On Wed, Aug 29, 2018 at 07:36:22PM +, Nadav Amit wrote: > >> at 10:11 AM, Nadav Amit wrote: > >> > >>> at 1:59 AM, Masami Hiramatsu wrote:

Re: [PATCH v13 10/13] x86/sgx: Add sgx_einit() for initializing enclaves

2018-08-29 Thread Sean Christopherson
On Wed, Aug 29, 2018 at 01:58:09PM -0700, Huang, Kai wrote: > > -Original Message- > > From: Christopherson, Sean J > > Sent: Thursday, August 30, 2018 8:34 AM > > To: Huang, Kai > > Cc: Jarkko Sakkinen ; platform-driver- > > x...@vger.kernel.org;

Re: [PATCH v7 2/3] Bluetooth: mediatek: Add protocol support for MediaTek serial devices

2018-08-08 Thread Sean Wang
On Tue, 2018-08-07 at 17:54 +0200, Marcel Holtmann wrote: > Hi Sean, > > >>>> this is even more hackish since the __hci_cmd_sync_ev command is really > >>>> meant to get a cmd status first before waiting for that event. > >>>> > >>&

[PATCH] md/bcache: Remove NULL check.

2018-08-13 Thread Sean Fu
Remove unnessesary NULL check before kmem_cache_destroy() in drivers/md/bcache/request.c Signed-off-by: Sean Fu --- drivers/md/bcache/request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index ae67f5f..0ddee35

Re: [PATCH v1 1/2] Bluetooth: mediatek: Add protocol support for MediaTek MT7668U USB devices

2018-08-13 Thread Sean Wang
On Mon, 2018-08-13 at 10:00 +0200, Marcel Holtmann wrote: > Hi Sean, > > > This adds the support of enabling MT7668U Bluetooth function running > > on the top of btusb driver. The patch also adds a newly created file > > mtkbt.c able to be reused independently from the tr

Re: [PATCH v1 1/2] Bluetooth: mediatek: Add protocol support for MediaTek MT7668U USB devices

2018-08-13 Thread Sean Wang
On Mon, 2018-08-13 at 18:20 +0800, Sean Wang wrote: > On Mon, 2018-08-13 at 10:00 +0200, Marcel Holtmann wrote: > > Hi Sean, > > > > > This adds the support of enabling MT7668U Bluetooth function running > > > on the top of btusb driver. The patch also adds a newl

Re: [PATCH] md/bcache: Remove NULL check.

2018-08-13 Thread Sean Fu
On Mon, Aug 13, 2018 at 06:00:11PM +0800, Coly Li wrote: > On 2018/8/13 5:38 PM, Sean Fu wrote: > > Remove unnessesary NULL check before kmem_cache_destroy() in > > drivers/md/bcache/request.c > > > > Signed-off-by: Sean Fu > > Hi Sean, > > A same cha

[PATCH 1/2] KVM: vmx: Add defines for SGX ENCLS exiting

2018-08-14 Thread Sean Christopherson
it reasons"). Signed-off-by: Sean Christopherson --- arch/x86/include/asm/vmx.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h index 6aa8499e1f62..2665c10ece4c 100644 --- a/arch/x86/include/asm/vmx.h +++ b/arch/x86/include/asm

<    1   2   3   4   5   6   7   8   9   10   >