Enable the crossbar IP support for DRA7xx soc.
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
---
arch/arm/mach-omap2/Kconfig|2 +-
arch/arm/mach-omap2/omap4-common.c |4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a
r
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
---
arch/arm/boot/dts/dra7.dtsi |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index afb89f1..6a5404f 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts
hould be implemented
to get a free irq and to configure the IP to route it.
Cc: Thomas Gleixner
Cc: Linus Walleij
Cc: Santosh Shilimkar
Cc: Russell King
Cc: Tony Lindgren
Cc: Rajendra Nayak
Cc: Marc Zyngier
Cc: Grant Likely
Cc: Rob Herring
Signed-off-by: Sricharan R
---
[V2] Added de
and wakeup gen code
cannot rely on these numbers to access the irq registers. Instead
use the hwirq element of the irq_data which represent the physical
irq number.
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
---
arch/arm/mach-omap2/omap-wakeupgen.c
only one
controller's input line. The crossbar device is used to map
a peripheral input to a free mpu's interrupt controller line.
Cc: Benoit Cousson
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
---
[V2] Renamed the bindings as per Kumar Gala
Cousson
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
---
arch/arm/boot/dts/dra7.dtsi | 93 +++
1 file changed, 50 insertions(+), 43 deletions(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7
t, so that it is setup to handle the
irqchip callbacks.
Cc: Thomas Gleixner
Cc: Linus Walleij
Cc: Santosh Shilimkar
Cc: Russell King
Cc: Tony Lindgren
Cc: Rajendra Nayak
Cc: Marc Zyngier
Cc: Grant Likely
Cc: Rob Herring
Signed-off-by: Sricharan R
---
[V2] Addressed Thomas Gleixner com
Hi Thomas,
Sorry for top posting. My mailer is not allowing me any formatting.
I agree with both of your comments below.
I will post V3 for this.
Regards,
Sricharan
From: Thomas Gleixner [t...@linutronix.de]
Sent: Wednesday, October 30, 2013 8:45
Hi Thomas,
Again sorry for top post.
I agree and will fix both of the comments below.
Thanks for the reviews.
Regards,
Sricharan
From: Thomas Gleixner [t...@linutronix.de]
Sent: Wednesday, October 30, 2013 9:00 PM
To: R, Sricharan
Cc: linux
On Tuesday 19 November 2013 02:07 PM, Linus Walleij wrote:
> On Thu, Nov 14, 2013 at 1:18 PM, Sricharan R wrote:
>
>> The minimal crossbar driver to track and allocate free GIC lines and
>> configure the
>> crossbar is added here, along with the DT bindings.
>>
>
Hi Mark,
Sorry for delayed response. I was away for some time.
On Friday 15 November 2013 04:53 PM, Mark Rutland wrote:
> On Thu, Nov 14, 2013 at 04:46:36PM +0000, Sricharan R wrote:
>> Hi Mark,
>>
>> On Thursday 14 November 2013 07:31 PM, Mark Rutland wrote:
>>>
and wakeup gen code
cannot rely on these numbers to access the irq registers. Instead
use the hwirq element of the irq_data which represent the physical
irq number.
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
Acked-by
Enable the crossbar IP support for DRA7xx soc.
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
Acked-by: Linus Walleij
---
arch/arm/mach-omap2/Kconfig|1 +
arch/arm/mach-omap2/omap4-common.c |2 ++
2 files
t, so that it is setup to handle the
irqchip callbacks.
Cc: Thomas Gleixner
Cc: Linus Walleij
Cc: Santosh Shilimkar
Cc: Russell King
Cc: Tony Lindgren
Cc: Rajendra Nayak
Cc: Marc Zyngier
Cc: Grant Likely
Cc: Rob Herring
Signed-off-by: Sricharan R
Acked-by: Kumar Gala (for DT binding po
hould be implemented
to get a free irq and to configure the IP to route it.
Cc: Thomas Gleixner
Cc: Linus Walleij
Cc: Santosh Shilimkar
Cc: Russell King
Cc: Tony Lindgren
Cc: Rajendra Nayak
Cc: Marc Zyngier
Cc: Grant Likely
Cc: Rob Herring
Signed-off-by: Sricharan R
Reviewed-by: T
nics.net/lists/linux-doc/msg16726.html
Sricharan R (4):
DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs
DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP
ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number
ARM: DRA: Enable Crossbar IP support for DRA7XX
Documentation
Hi Thomas,
On Tuesday 03 December 2013 03:57 PM, Sricharan R wrote:
> Some socs have a large number of interrupts requests to service
> the needs of its many peripherals and subsystems. All of the
> interrupt lines from the subsystems are not needed at the same
> time, so they have to
The dma-request lines from peripherals are connected to
the dma-controller through a crossbar router. Adding this
crossbar phandle to the peripheral's dma-specs. This is
used by the driver to identify the router associated with
a dma-request line and map it.
Signed-off-by: Sricharan R
---
registered during probe a
the dma request line free is mapped using the registered router's map function
during the device_alloc_chan_resource callback and freed with free_resource.
When a router is not registered, the dma request number is same as the
crossbar number.
Signed-off-by: Sricha
e dma-controller driver map/unmap
the peripheral dma crossbar line to dma-controller's request
line.
This is on top of Russell's OMAP dma engine rework series
http://www.spinics.net/lists/linux-omap/msg102969.html
Sricharan R (9):
drivers: dma: omap-dma: Avoid hard-coding of
st of free dma request lines and
allocates one during the map callback which is invoked as
a part the dma engine driver's device_alloc_chan_resources
callback. The allocated request line is freed during the
device_free_chan_resources.
Signed-off-by: Sricharan R
---
.../devicetree/bindin
: Sricharan R
---
arch/arm/boot/dts/dra7.dtsi |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index baa781e..f5ae8c9 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -167,7 +167,7
Adding the crossbar node.
Signed-off-by: Sricharan R
---
arch/arm/boot/dts/dra7.dtsi |7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 1fd75aa..f84991b 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts
Enable dma crossbar support on dra7xx
Signed-off-by: Sricharan R
---
arch/arm/configs/omap2plus_defconfig |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/omap2plus_defconfig
b/arch/arm/configs/omap2plus_defconfig
index 3a0b53d..1cf8277 100644
--- a/arch/arm/configs
-channel specific structure. This is used to map/unmap
the dma request lines.
Signed-off-by: Sricharan R
---
drivers/dma/omap-dma.c | 47 ---
1 file changed, 44 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
The total number of dma-request channels is hard-coded. Instead read the
data from DT.
Signed-off-by: Sricharan R
---
drivers/dma/omap-dma.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index 64ceca2..a0d6639 100644
have to check if a request line is routed
and then use that router's map/unmap function to configure the
request line.
Signed-off-by: Sricharan R
---
drivers/dma/of-dma.c | 82 ++--
include/linux/of_dma.h | 22 +
2 files ch
Hi Rob,
On Sunday 09 March 2014 01:23 AM, Rob Herring wrote:
> On Fri, Mar 7, 2014 at 6:16 AM, Sricharan R wrote:
>> In some SoCs the dma request lines from the peripherals are
>> routed to the dma-controller through a crossbar. With this the
>> dma controller's a
it's immutable unless you tell me I applied something
>> incorrectly. Once it goes into irqchip/core, it's immutable no matter
>> what you say. ;-)
>
> Thanks, looks good to me. Sricharan and Nishant, can you please
> check that we can now apply the related .dts changes
ned-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 4be30c0..a39cb31 100644
--- a/driv
(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter
'write'
2 warnings
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c |4 ++
tch warning:
WARNING: Unnecessary space before function pointer arguments
#37: FILE: drivers/irqchip/irq-crossbar.c:37:
+ void (*write) (int, int);
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
.../devicetree/bindings/arm/omap/crossbar.txt |3 +++
From: Nishanth Menon
Today '0' is actually reserved, but may not be the same in the future.
So, use a flag to mark the GIC interrupts that are reserved.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c |
Adding kerneldoc for unmap callback function.
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index a8c6156..518d712
use it to
validate requests.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
.../devicetree/bindings/arm/omap/crossbar.txt |2 ++
drivers/irqchip/irq-crossbar.c | 21 ++--
2 files changed, 21 insertions(+), 2
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
.../devicetree/bindings/arm/omap/crossbar.txt | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt
b/Documentation/devicetree/bindings/arm/omap/crossbar.txt
From: Nishanth Menon
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq
ation/programming of crossbar should be avoided.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
.../devicetree/bindings/arm/omap/crossbar.txt | 12 ++--
drivers/irqchip/irq-crossbar.c | 20 ++--
2
, GFP_KERNEL);
WARNING: Prefer kcalloc over kzalloc with multiply
+ cb->register_offsets = kzalloc(max * sizeof(int), GFP_KERNEL);
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c |7 ---
1 file changed, 4
If crossbar_of_init returns with a error, then set the cb pointer
to null.
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index
From: Nishanth Menon
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers
From: Nishanth Menon
crossbar_of_init always returns -ENOMEM in case of errors.
There can be other causes of failure like invalid data from
DT. So return a appropriate error value for that case.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers
From: Nishanth Menon
Using err1,2,3,4 etc makes it hard to ensure a new exit path in the
middle will not result in spurious changes, so rename the error paths
as per the function it does.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers
-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh Shilimkar
---
drivers/irqchip/irq-crossbar.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 20105bc..51d4b87 100644
--- a/drivers
quirky hardware with direct hardwiring
of GIC
Sricharan R (2):
irqchip: crossbar: Set cb pointer to null in case of error
irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback
.../devicetree/bindings/arm/omap/crossbar.txt | 36 +
drivers/irqchip
From: Nishanth Menon
When, in the system due to varied reasons, interrupts might be unusable
due to hardware behavior, but register maps do exist, then those interrupts
should be skipped while mapping irq to crossbars.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Acked-by: Santosh
property and ti,irqs-safe-map property to
crossbar dt node.
[V4] Introduced macros MAX_SOURCES and DIRECT_IRQ
R Sricharan (2):
arm: dts: dra7: add routable-irqs property for gic node
arm: dts: dra7: add crossbar device binding
arch/arm/boot/dts/dra7.dts
From: R Sricharan
There is a IRQ crossbar device in the soc, which
maps the irq requests from the peripherals to the
mpu interrupt controller's inputs. The Peripheral irq
requests are connected to only one crossbar
input and the output of the crossbar is connected to only one
controller
From: R Sricharan
There is a IRQ crossbar device in the soc, which maps the
irq requests from the peripherals to the mpu interrupt
controller's inputs. The gic provides the support for such
IPs in the form of routable-irqs. So adding the property
here to gic node.
Signed-off-by: Sricha
Hi Tony,
On Thursday 26 June 2014 01:14 PM, Tony Lindgren wrote:
> * Sricharan R [140626 00:29]:
>> From: R Sricharan
>>
>> There is a IRQ crossbar device in the soc, which
>> maps the irq requests from the peripherals to the
>> mpu interrupt controller's
From: Nishanth Menon
Today '0' is actually reserved, but may not be the same in the future.
So, use a flag to mark the GIC interrupts that are reserved.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Signed-off-by: Tony Lindgren
---
drivers/irqchip/irq-crossbar.c |
From: Nishanth Menon
On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131,
132, 133 are direct wired to hardware blocks bypassing crossbar.
This quirky implementation is *NOT* supposed to be the expectation
of crossbar hardware usage. However, these are already marked in our
descript
From: Nishanth Menon
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon
---
drivers/irqchip/irq-crossbar.c | 14 --
1 file changed, 12 insert
From: Nishanth Menon
crossbar_of_init always returns -ENOMEM in case of errors, return proper
error results in case of failures.
Signed-off-by: Nishanth Menon
---
drivers/irqchip/irq-crossbar.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/irqch
From: Nishanth Menon
There is absolutely no need for crossbar driver to expose functions and
variables into global namespace. So make them all static
Fixes sparse warnings:
drivers/irqchip/irq-crossbar.c:129:29: warning: symbol
'routable_irq_domain_ops' was not declared. Should it be static?
dr
ue must be written to
ensure that the crossbar mapping matches with interrupt controller
usage.
So provide a safe value in the compatible data to map if
'0' is not safe for the platform and use it during init and unmap
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
From: Nishanth Menon
When the provided unused skip list entry is greater than max irqs
possible, we go to err3, but we fail to free register_offsets,
should have returned to err4 instead which ensures that allocated
register_offsets are freed as well.
Signed-off-by: Nishanth Menon
---
drivers/
From: Nishanth Menon
Using err1,2,3,4 etc makes it hard to ensure a new exit path in the
middle will not result in spurious changes, so rename the error paths
as per the function it does.
Signed-off-by: Nishanth Menon
---
drivers/irqchip/irq-crossbar.c | 22 +++---
1 file cha
kerneldoc for unmap callback clarity.
Signed-off-by: Sricharan R
---
drivers/irqchip/irq-crossbar.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 5f3e75a..2a73a66 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b
From: Nishanth Menon
The current crossbar description does not include the description
required for the consumer of the crossbar, a.k.a devices whoes events
pass through the crossbar into the GIC interrupt controller.
So, provide documentation for the same.
Signed-off-by: Nishanth Menon
---
.
From: Nishanth Menon
Currently we attempt to map any crossbar value to an IRQ, however,
this is not correct from hardware perspective. There is a max crossbar
event number upto which hardware supports. So describe the same in
device tree using 'ti,max-crossbar-sources' property and use it to
vali
If crossbar_of_init returns with a error, then set the cb pointer
to null.
Signed-off-by: Sricharan R
---
drivers/irqchip/irq-crossbar.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index cf0d79f..5f3e75a 100644
--- a
used to track the update.
Reported-by: Nishanth Menon
Reported-by: Sricharan R
Reported-by: Suman Anna
Signed-off-by: Rajendra Nayak
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip
From: Nishanth Menon
kernel doc style is wrong in code. fix it to squelch
kerneldoc warnings:
Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description
on line:
* struct crossbar_device: crossbar device description
Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for st
From: Nishanth Menon
remove un-necessary space in function pointer.
Fixes checkpatch warning:
WARNING: Unnecessary space before function pointer arguments
#37: FILE: drivers/irqchip/irq-crossbar.c:37:
+ void (*write) (int, int);
WARNING: Missing a blank line after declarations
+ in
From: Nishanth Menon
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon
---
drivers/irqchip/irq-crossbar.c |6 +++---
1 file changed, 3 insert
From: Nishanth Menon
When, in the system due to varied reasons, interrupts might be unusable
due to hardware behavior, but register maps do exist, then those interrupts
should be skipped while mapping irq to crossbars.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Signed-off-by
-off-by: Nishanth Menon
Signed-off-by: Sricharan R
Signed-off-by: Tony Lindgren
---
drivers/irqchip/irq-crossbar.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 20105bc..51d4b87 100644
--- a/drivers
: Sricharan R
Signed-off-by: Tony Lindgren
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 287d3ce..de021638 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers
entralized check for crossbar write
Documentation: dt: OMAP: crossbar: add description for interrupt
consumer
irqchip: crossbar allow for quirky hardware with direct hardwiring of
GIC
Rajendra Nayak (1):
irqchip: crossbar: DRA7: Fix unused crossbar list
Sricharan R (2):
irqchip: cro
Hi Jason,
On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
>> From: Nishanth Menon
>>
>> When, in the system due to varied reasons, interrupts might be unusable
>> due to hardware behavior, but r
Hi Jason,
On Thursday 12 June 2014 06:46 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote:
>> From: Rajendra Nayak
>>
>> On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ,
>> IRQ133 is default mapped to NMI pin
Hi Jason,
On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote:
>> From: Nishanth Menon
>>
>> remove un-necessary space in function pointer.
>>
>> Fixes checkpatch warning:
>> WARNING: Un
Hi Jason,
On Thursday 12 June 2014 06:50 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:19PM +0530, Sricharan R wrote:
>> From: Nishanth Menon
>>
>> When the provided unused skip list entry is greater than max irqs
>> possible, we go to err3, but we fa
Hi Jason,
On Thursday 12 June 2014 06:44 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote:
>> From: Nishanth Menon
>>
>> kernel doc style is wrong in code. fix it to squelch
>> kerneldoc warnings:
>
> I would re-word the abo
Hi Jason,
On Thursday 12 June 2014 07:19 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:23PM +0530, Sricharan R wrote:
>> The crossbar_domain_map/unmap callbacks need not be called same number
>> of times for a particular irq. But still use counting is not needed
>>
Hi Jason,
On Thursday 12 June 2014 06:26 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote:
>> From: Nishanth Menon
>>
>> Reverse the search algorithm to ensure that address mapping and IRQ
>> allocation logics are proper. This can
oice (and last I saw,
> that's you) to ignore whatever doesn't fit the appropriate
> vision for the code.
>
> $ ./scripts/get_maintainer.pl -f drivers/irqchip/irq-crossbar.c
> Thomas Gleixner (maintainer:IRQCHIP DRIVERS)
> Jason Cooper (maintainer:IRQCHIP DRIVERS)
Ok,
On Thursday 12 June 2014 07:27 PM, Tony Lindgren wrote:
> * Jason Cooper [140612 05:52]:
>> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
>>> From: Nishanth Menon
>>>
>>> When, in the system due to varied reasons, interrupts might be unusab
Hi Jason,
On Thursday 12 June 2014 07:37 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 06:49:17PM +0530, Sricharan R wrote:
>> Hi Jason,
>>
>> On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote:
>>> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wr
Hi Jason,
On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote:
>> * Jason Cooper [140612 05:52]:
>>> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
>>>> From: Nishanth Menon
>&g
Hi Jason,
On Thursday 12 June 2014 07:24 PM, Jason Cooper wrote:
> On Thu, Jun 12, 2014 at 05:23:24PM +0530, Sricharan R wrote:
>> From: Nishanth Menon
>>
>> Currently we attempt to map any crossbar value to an IRQ, however,
>> this is not correct from hardware
On Friday 13 June 2014 12:26 PM, Sricharan R wrote:
> Hi Jason,
>
> On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote:
>> On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote:
>>> * Jason Cooper [140612 05:52]:
>>>> On Thu, Jun 12, 2014 at
Hi Tony,
On Monday 30 December 2013 12:28 PM, Sricharan R wrote:
> Hi Benoit,
>
> On Thursday 14 November 2013 05:55 PM, Sricharan R wrote:
>> Some socs have a large number of interrupts requests to service
>> the needs of its many peripherals and subsystems. All of the
only one
controller's input line. The crossbar device is used to map
a peripheral input to a free mpu's interrupt controller line.
Cc: Benoit Cousson
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
Signed-off-by: Nishanth Menon
---
[V5] Rebased
This series depends on crossbar-driver-fixes sent below
http://marc.info/?l=linux-omap&m=139929963420299&w=2
Sricharan R (3):
arm: dts: dra7: Add crossbar device binding
arm: dts: dra7: Replace peripheral interrupt numbers with crossbar
inputs
arm: dts: dra7: Add routable-irqs
Cousson
Cc: Santosh Shilimkar
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
Signed-off-by: Nishanth Menon
---
[V5] Rebased on 3.15-rc4 and replaced irqs numbers with crossbar
numbers for new peripherals.
arch/arm/boot/dts/dra7.dtsi | 100
r
Cc: Rajendra Nayak
Cc: Tony Lindgren
Signed-off-by: Sricharan R
Signed-off-by: Nishanth Menon
---
[V5] Rebased and corrected routable irqs from 160 to 192
arch/arm/boot/dts/dra7.dtsi |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
On Wednesday 07 May 2014 03:15 AM, Darren Etheridge wrote:
> Sricharan R wrote on Tue [2014-May-06 19:26:16 +0530]:
>> Some socs have a large number of interrupts requests to service
>> the needs of its many peripherals and subsystems. All of the interrupt
>> requests line
depends on crossbar-driver-fixes sent below
http://marc.info/?l=linux-omap&m=139929963420299&w=2
[V6] Reordered patch 3 to patch 1 and
squashed patch 2 and 3 from V5 in to patch 2
Sricharan R (2):
arm: dts: dra7: Add routable-irqs property for gic node
arm: dts: dra7: Add crossba
There is a IRQ crossbar device in the soc, which maps the
irq requests from the peripherals to the mpu interrupt
controller's inputs. The gic provides the support for such
IPs in the form of routable-irqs. So adding the property
here to gic node.
Signed-off-by: Sricharan R
Signed-o
e crossbar device is used to map
a peripheral input to a free mpu's interrupt controller line.
Here, adding a new crossbar device node and replacing all the peripheral
interrupt numbers with its fixed crossbar input lines.
Signed-off-by: Sricharan R
Signed-off-by: Nishanth Menon
Cc: Ben
ts interrupt number. Since the crossbar dts patches are not yet
there, this causes a warning during boot. So interrupts = < >
property should be removed from DT and added later by crossbar series.
Regards,
Sricharan
--
To unsubscribe from this list: send the line "unsubscribe linux-k
o identify
valid crossbar mapping
irqchip: crossbar: introduce centralized check for crossbar write
documentation: dt: omap: crossbar: add description for interrupt
consumer
irqchip: crossbar: allow for quirky hardware with direct hardwiring
of GIC
Sricharan R (2):
irqchip: crossb
(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter
'write'
2 warnings
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
---
[V3] Reworded the commit log
drivers/irqchip/irq-crossbar.c |4 ++
-off-by: Nishanth Menon
Signed-off-by: Sricharan R
---
drivers/irqchip/irq-crossbar.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 20105bc..51d4b87 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b
From: Nishanth Menon
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
---
drivers/irqchip/irq-crossbar.c |6
From: Nishanth Menon
crossbar_of_init always returns -ENOMEM in case of errors.
There can be other causes of failure like invalid data from
DT. So return a appropriate error value for that case.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
---
[V3] Changed commit log
drivers
From: Nishanth Menon
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon
Signed-off-by: Sricharan R
---
drivers/irqchip/irq-crossbar.c | 14
Adding kerneldoc for unmap callback function.
Signed-off-by: Sricharan R
---
[V3] Reworded the kerneldoc
drivers/irqchip/irq-crossbar.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 9b4c0f1..df16ef8
401 - 500 of 985 matches
Mail list logo