[PATCH V2 7/7] ARM: DRA: Enable Crossbar IP support for DRA7XX

2013-10-30 Thread Sricharan R
Enable the crossbar IP support for DRA7xx soc. Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R --- arch/arm/mach-omap2/Kconfig|2 +- arch/arm/mach-omap2/omap4-common.c |4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a

[PATCH V2 5/7] ARM: DTS: DRA7: Add routable-irqs property for gic node

2013-10-30 Thread Sricharan R
r Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R --- arch/arm/boot/dts/dra7.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index afb89f1..6a5404f 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts

[PATCH V2 1/7] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-10-30 Thread Sricharan R
hould be implemented to get a free irq and to configure the IP to route it. Cc: Thomas Gleixner Cc: Linus Walleij Cc: Santosh Shilimkar Cc: Russell King Cc: Tony Lindgren Cc: Rajendra Nayak Cc: Marc Zyngier Cc: Grant Likely Cc: Rob Herring Signed-off-by: Sricharan R --- [V2] Added de

[PATCH V2 6/7] ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number

2013-10-30 Thread Sricharan R
and wakeup gen code cannot rely on these numbers to access the irq registers. Instead use the hwirq element of the irq_data which represent the physical irq number. Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R --- arch/arm/mach-omap2/omap-wakeupgen.c

[PATCH V2 3/7] ARM: DTS: DRA: Add crossbar device binding

2013-10-30 Thread Sricharan R
only one controller's input line. The crossbar device is used to map a peripheral input to a free mpu's interrupt controller line. Cc: Benoit Cousson Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R --- [V2] Renamed the bindings as per Kumar Gala

[PATCH V2 4/7] ARM: DTS: DRA: Replace peripheral interrupt numbers with crossbar inputs

2013-10-30 Thread Sricharan R
Cousson Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R --- arch/arm/boot/dts/dra7.dtsi | 93 +++ 1 file changed, 50 insertions(+), 43 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7

[PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

2013-10-30 Thread Sricharan R
t, so that it is setup to handle the irqchip callbacks. Cc: Thomas Gleixner Cc: Linus Walleij Cc: Santosh Shilimkar Cc: Russell King Cc: Tony Lindgren Cc: Rajendra Nayak Cc: Marc Zyngier Cc: Grant Likely Cc: Rob Herring Signed-off-by: Sricharan R --- [V2] Addressed Thomas Gleixner com

RE: [PATCH V2 1/7] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-10-31 Thread R, Sricharan
Hi Thomas, Sorry for top posting. My mailer is not allowing me any formatting. I agree with both of your comments below. I will post V3 for this. Regards, Sricharan From: Thomas Gleixner [t...@linutronix.de] Sent: Wednesday, October 30, 2013 8:45

RE: [PATCH V2 2/7] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

2013-10-31 Thread R, Sricharan
Hi Thomas, Again sorry for top post. I agree and will fix both of the comments below. Thanks for the reviews. Regards, Sricharan From: Thomas Gleixner [t...@linutronix.de] Sent: Wednesday, October 30, 2013 9:00 PM To: R, Sricharan Cc: linux

Re: [PATCH V4 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-12-01 Thread Sricharan R
On Tuesday 19 November 2013 02:07 PM, Linus Walleij wrote: > On Thu, Nov 14, 2013 at 1:18 PM, Sricharan R wrote: > >> The minimal crossbar driver to track and allocate free GIC lines and >> configure the >> crossbar is added here, along with the DT bindings. >> >

Re: [PATCH V4 1/4] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-12-02 Thread Sricharan R
Hi Mark, Sorry for delayed response. I was away for some time. On Friday 15 November 2013 04:53 PM, Mark Rutland wrote: > On Thu, Nov 14, 2013 at 04:46:36PM +0000, Sricharan R wrote: >> Hi Mark, >> >> On Thursday 14 November 2013 07:31 PM, Mark Rutland wrote: >>>

[PATCH V5 3/4] ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number

2013-12-03 Thread Sricharan R
and wakeup gen code cannot rely on these numbers to access the irq registers. Instead use the hwirq element of the irq_data which represent the physical irq number. Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar Acked-by

[PATCH V5 4/4] ARM: DRA: Enable Crossbar IP support for DRA7XX

2013-12-03 Thread Sricharan R
Enable the crossbar IP support for DRA7xx soc. Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar Acked-by: Linus Walleij --- arch/arm/mach-omap2/Kconfig|1 + arch/arm/mach-omap2/omap4-common.c |2 ++ 2 files

[PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

2013-12-03 Thread Sricharan R
t, so that it is setup to handle the irqchip callbacks. Cc: Thomas Gleixner Cc: Linus Walleij Cc: Santosh Shilimkar Cc: Russell King Cc: Tony Lindgren Cc: Rajendra Nayak Cc: Marc Zyngier Cc: Grant Likely Cc: Rob Herring Signed-off-by: Sricharan R Acked-by: Kumar Gala (for DT binding po

[PATCH V5 1/4] DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs

2013-12-03 Thread Sricharan R
hould be implemented to get a free irq and to configure the IP to route it. Cc: Thomas Gleixner Cc: Linus Walleij Cc: Santosh Shilimkar Cc: Russell King Cc: Tony Lindgren Cc: Rajendra Nayak Cc: Marc Zyngier Cc: Grant Likely Cc: Rob Herring Signed-off-by: Sricharan R Reviewed-by: T

[PATCH V5 0/4] DRIVERS: IRQCHIP: Add support for crossbar IP

2013-12-03 Thread Sricharan R
nics.net/lists/linux-doc/msg16726.html Sricharan R (4): DRIVERS: IRQCHIP: IRQ-GIC: Add support for routable irqs DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP ARM: OMAP4+: Correct Wakeup-gen code to use physical irq number ARM: DRA: Enable Crossbar IP support for DRA7XX Documentation

Re: [PATCH V5 2/4] DRIVERS: IRQCHIP: CROSSBAR: Add support for Crossbar IP

2014-01-16 Thread Sricharan R
Hi Thomas, On Tuesday 03 December 2013 03:57 PM, Sricharan R wrote: > Some socs have a large number of interrupts requests to service > the needs of its many peripherals and subsystems. All of the > interrupt lines from the subsystems are not needed at the same > time, so they have to

[RFC PATCH 7/9] arm: dts: dra: Add dma-request crossbar phandle to dma-specs

2014-03-07 Thread Sricharan R
The dma-request lines from peripherals are connected to the dma-controller through a crossbar router. Adding this crossbar phandle to the peripheral's dma-specs. This is used by the driver to identify the router associated with a dma-request line and map it. Signed-off-by: Sricharan R ---

[RFC PATCH 4/9] drivers: omap-dma: Add crossbar line as a resource to omap_chan structure

2014-03-07 Thread Sricharan R
registered during probe a the dma request line free is mapped using the registered router's map function during the device_alloc_chan_resource callback and freed with free_resource. When a router is not registered, the dma request number is same as the crossbar number. Signed-off-by: Sricha

[RFC PATCH 0/9] drivers: dma: Add support for dma-channel router

2014-03-07 Thread Sricharan R
e dma-controller driver map/unmap the peripheral dma crossbar line to dma-controller's request line. This is on top of Russell's OMAP dma engine rework series http://www.spinics.net/lists/linux-omap/msg102969.html Sricharan R (9): drivers: dma: omap-dma: Avoid hard-coding of

[RFC PATCH 5/9] drivers: dma: Add dma crossbar driver

2014-03-07 Thread Sricharan R
st of free dma request lines and allocates one during the map callback which is invoked as a part the dma engine driver's device_alloc_chan_resources callback. The allocated request line is freed during the device_free_chan_resources. Signed-off-by: Sricharan R --- .../devicetree/bindin

[RFC PATCH 9/9] arm: dts: dra7: Change the total dma-req numbers to crossbar channels

2014-03-07 Thread Sricharan R
: Sricharan R --- arch/arm/boot/dts/dra7.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index baa781e..f5ae8c9 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -167,7 +167,7

[RFC PATCH 6/9] arm: dts: dra: Add dma crossbar node

2014-03-07 Thread Sricharan R
Adding the crossbar node. Signed-off-by: Sricharan R --- arch/arm/boot/dts/dra7.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 1fd75aa..f84991b 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts

[RFC PATCH 8/9] arm: dra: Enable dma crossbar support on dra7xx

2014-03-07 Thread Sricharan R
Enable dma crossbar support on dra7xx Signed-off-by: Sricharan R --- arch/arm/configs/omap2plus_defconfig |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig index 3a0b53d..1cf8277 100644 --- a/arch/arm/configs

[RFC PATCH 3/9] drivers: dma: omap-dma: Add a seperate xlate function to get router data

2014-03-07 Thread Sricharan R
-channel specific structure. This is used to map/unmap the dma request lines. Signed-off-by: Sricharan R --- drivers/dma/omap-dma.c | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c

[RFC PATCH 1/9] drivers: dma: omap-dma: Avoid hard-coding of the dma-request channels

2014-03-07 Thread Sricharan R
The total number of dma-request channels is hard-coded. Instead read the data from DT. Signed-off-by: Sricharan R --- drivers/dma/omap-dma.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index 64ceca2..a0d6639 100644

[RFC PATCH 2/9] drivers: dma: of-dma: Add support for dma-request line routers

2014-03-07 Thread Sricharan R
have to check if a request line is routed and then use that router's map/unmap function to configure the request line. Signed-off-by: Sricharan R --- drivers/dma/of-dma.c | 82 ++-- include/linux/of_dma.h | 22 + 2 files ch

Re: [RFC PATCH 0/9] drivers: dma: Add support for dma-channel router

2014-03-10 Thread Sricharan R
Hi Rob, On Sunday 09 March 2014 01:23 AM, Rob Herring wrote: > On Fri, Mar 7, 2014 at 6:16 AM, Sricharan R wrote: >> In some SoCs the dma request lines from the peripherals are >> routed to the dma-controller through a crossbar. With this the >> dma controller's a

Re: [PATCH V4 00/16] irqchip: crossbar: Driver fixes

2014-07-01 Thread Sricharan R
it's immutable unless you tell me I applied something >> incorrectly. Once it goes into irqchip/core, it's immutable no matter >> what you say. ;-) > > Thanks, looks good to me. Sricharan and Nishant, can you please > check that we can now apply the related .dts changes

[PATCH V4 05/16] irqchip: crossbar: Change allocation logic by reversing search for free irqs

2014-06-26 Thread Sricharan R
ned-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 4be30c0..a39cb31 100644 --- a/driv

[PATCH V4 08/16] irqchip: crossbar: Fix kerneldoc warning

2014-06-26 Thread Sricharan R
(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter 'write' 2 warnings Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c |4 ++

[PATCH V4 04/16] irqchip: crossbar: Initialise the crossbar with a safe value

2014-06-26 Thread Sricharan R
tch warning: WARNING: Unnecessary space before function pointer arguments #37: FILE: drivers/irqchip/irq-crossbar.c:37: + void (*write) (int, int); Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- .../devicetree/bindings/arm/omap/crossbar.txt |3 +++

[PATCH V4 01/16] irqchip: crossbar: Dont use '0' to mark reserved interrupts

2014-06-26 Thread Sricharan R
From: Nishanth Menon Today '0' is actually reserved, but may not be the same in the future. So, use a flag to mark the GIC interrupts that are reserved. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c |

[PATCH V4 12/16] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

2014-06-26 Thread Sricharan R
Adding kerneldoc for unmap callback function. Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index a8c6156..518d712

[PATCH V4 13/16] irqchip: crossbar: Introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-26 Thread Sricharan R
use it to validate requests. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- .../devicetree/bindings/arm/omap/crossbar.txt |2 ++ drivers/irqchip/irq-crossbar.c | 21 ++-- 2 files changed, 21 insertions(+), 2

[PATCH V4 15/16] documentation: dt: omap: crossbar: Add description for interrupt consumer

2014-06-26 Thread Sricharan R
Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- .../devicetree/bindings/arm/omap/crossbar.txt | 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt b/Documentation/devicetree/bindings/arm/omap/crossbar.txt

[PATCH V4 14/16] irqchip: crossbar: Introduce centralized check for crossbar write

2014-06-26 Thread Sricharan R
From: Nishanth Menon This is a basic check to ensure that crossbar register needs to be written. This ensures that we have a common check which is used in both map and unmap logic. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq

[PATCH V4 16/16] irqchip: crossbar: Allow for quirky hardware with direct hardwiring of GIC

2014-06-26 Thread Sricharan R
ation/programming of crossbar should be avoided. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- .../devicetree/bindings/arm/omap/crossbar.txt | 12 ++-- drivers/irqchip/irq-crossbar.c | 20 ++-- 2

[PATCH V4 07/16] irqchip: crossbar: Fix sparse and checkpatch warnings

2014-06-26 Thread Sricharan R
, GFP_KERNEL); WARNING: Prefer kcalloc over kzalloc with multiply + cb->register_offsets = kzalloc(max * sizeof(int), GFP_KERNEL); Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c |7 --- 1 file changed, 4

[PATCH V4 11/16] irqchip: crossbar: Set cb pointer to null in case of error

2014-06-26 Thread Sricharan R
If crossbar_of_init returns with a error, then set the cb pointer to null. Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index

[PATCH V4 06/16] irqchip: crossbar: Remove IS_ERR_VALUE check

2014-06-26 Thread Sricharan R
From: Nishanth Menon IS_ERR_VALUE makes sense only *if* there could be valid values in negative error range. But in the cases that we do use it, there is no such case. Just remove the same. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers

[PATCH V4 09/16] irqchip: crossbar: Return proper error value

2014-06-26 Thread Sricharan R
From: Nishanth Menon crossbar_of_init always returns -ENOMEM in case of errors. There can be other causes of failure like invalid data from DT. So return a appropriate error value for that case. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers

[PATCH V4 10/16] irqchip: crossbar: Change the goto naming

2014-06-26 Thread Sricharan R
From: Nishanth Menon Using err1,2,3,4 etc makes it hard to ensure a new exit path in the middle will not result in spurious changes, so rename the error paths as per the function it does. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers

[PATCH V4 02/16] irqchip: crossbar: Check for premapped crossbar before allocating

2014-06-26 Thread Sricharan R
-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh Shilimkar --- drivers/irqchip/irq-crossbar.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 20105bc..51d4b87 100644 --- a/drivers

[PATCH V4 00/16] irqchip: crossbar: Driver fixes

2014-06-26 Thread Sricharan R
quirky hardware with direct hardwiring of GIC Sricharan R (2): irqchip: crossbar: Set cb pointer to null in case of error irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback .../devicetree/bindings/arm/omap/crossbar.txt | 36 + drivers/irqchip

[PATCH V4 03/16] irqchip: crossbar: Introduce ti,irqs-skip to skip irqs that bypass crossbar

2014-06-26 Thread Sricharan R
From: Nishanth Menon When, in the system due to varied reasons, interrupts might be unusable due to hardware behavior, but register maps do exist, then those interrupts should be skipped while mapping irq to crossbars. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Acked-by: Santosh

[PATCH V4 0/2] arm: dts: dra7: add crossbar dt support

2014-06-26 Thread Sricharan R
property and ti,irqs-safe-map property to crossbar dt node. [V4] Introduced macros MAX_SOURCES and DIRECT_IRQ R Sricharan (2): arm: dts: dra7: add routable-irqs property for gic node arm: dts: dra7: add crossbar device binding arch/arm/boot/dts/dra7.dts

[PATCH V4 2/2] arm: dts: dra7: add crossbar device binding

2014-06-26 Thread Sricharan R
From: R Sricharan There is a IRQ crossbar device in the soc, which maps the irq requests from the peripherals to the mpu interrupt controller's inputs. The Peripheral irq requests are connected to only one crossbar input and the output of the crossbar is connected to only one controller&#x

[PATCH V4 1/2] arm: dts: dra7: add routable-irqs property for gic node

2014-06-26 Thread Sricharan R
From: R Sricharan There is a IRQ crossbar device in the soc, which maps the irq requests from the peripherals to the mpu interrupt controller's inputs. The gic provides the support for such IPs in the form of routable-irqs. So adding the property here to gic node. Signed-off-by: Sricha

Re: [PATCH V4 2/2] arm: dts: dra7: add crossbar device binding

2014-06-26 Thread Sricharan R
Hi Tony, On Thursday 26 June 2014 01:14 PM, Tony Lindgren wrote: > * Sricharan R [140626 00:29]: >> From: R Sricharan >> >> There is a IRQ crossbar device in the soc, which >> maps the irq requests from the peripherals to the >> mpu interrupt controller's

[PATCH V2 01/19] irqchip: crossbar: dont use '0' to mark reserved interrupts

2014-06-12 Thread Sricharan R
From: Nishanth Menon Today '0' is actually reserved, but may not be the same in the future. So, use a flag to mark the GIC interrupts that are reserved. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Signed-off-by: Tony Lindgren --- drivers/irqchip/irq-crossbar.c |

[PATCH V2 19/19] irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC

2014-06-12 Thread Sricharan R
From: Nishanth Menon On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131, 132, 133 are direct wired to hardware blocks bypassing crossbar. This quirky implementation is *NOT* supposed to be the expectation of crossbar hardware usage. However, these are already marked in our descript

[PATCH V2 17/19] irqchip: crossbar: introduce centralized check for crossbar write

2014-06-12 Thread Sricharan R
From: Nishanth Menon This is a basic check to ensure that crossbar register needs to be written. This ensures that we have a common check which is used in both map and unmap logic. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 14 -- 1 file changed, 12 insert

[PATCH V2 12/19] irqchip: crossbar: return proper error value

2014-06-12 Thread Sricharan R
From: Nishanth Menon crossbar_of_init always returns -ENOMEM in case of errors, return proper error results in case of failures. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/irqch

[PATCH V2 07/19] irqchip: crossbar: fix sparse warnings

2014-06-12 Thread Sricharan R
From: Nishanth Menon There is absolutely no need for crossbar driver to expose functions and variables into global namespace. So make them all static Fixes sparse warnings: drivers/irqchip/irq-crossbar.c:129:29: warning: symbol 'routable_irq_domain_ops' was not declared. Should it be static? dr

[PATCH V2 04/19] irqchip: crossbar: Initialise the crossbar with a safe value

2014-06-12 Thread Sricharan R
ue must be written to ensure that the crossbar mapping matches with interrupt controller usage. So provide a safe value in the compatible data to map if '0' is not safe for the platform and use it during init and unmap Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R

[PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry

2014-06-12 Thread Sricharan R
From: Nishanth Menon When the provided unused skip list entry is greater than max irqs possible, we go to err3, but we fail to free register_offsets, should have returned to err4 instead which ensures that allocated register_offsets are freed as well. Signed-off-by: Nishanth Menon --- drivers/

[PATCH V2 13/19] irqchip: crossbar: change the goto naming

2014-06-12 Thread Sricharan R
From: Nishanth Menon Using err1,2,3,4 etc makes it hard to ensure a new exit path in the middle will not result in spurious changes, so rename the error paths as per the function it does. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c | 22 +++--- 1 file cha

[PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

2014-06-12 Thread Sricharan R
kerneldoc for unmap callback clarity. Signed-off-by: Sricharan R --- drivers/irqchip/irq-crossbar.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 5f3e75a..2a73a66 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b

[PATCH V2 18/19] Documentation: dt: OMAP: crossbar: add description for interrupt consumer

2014-06-12 Thread Sricharan R
From: Nishanth Menon The current crossbar description does not include the description required for the consumer of the crossbar, a.k.a devices whoes events pass through the crossbar into the GIC interrupt controller. So, provide documentation for the same. Signed-off-by: Nishanth Menon --- .

[PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-12 Thread Sricharan R
From: Nishanth Menon Currently we attempt to map any crossbar value to an IRQ, however, this is not correct from hardware perspective. There is a max crossbar event number upto which hardware supports. So describe the same in device tree using 'ti,max-crossbar-sources' property and use it to vali

[PATCH V2 14/19] irqchip: crossbar: set cb pointer to null in case of error

2014-06-12 Thread Sricharan R
If crossbar_of_init returns with a error, then set the cb pointer to null. Signed-off-by: Sricharan R --- drivers/irqchip/irq-crossbar.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index cf0d79f..5f3e75a 100644 --- a

[PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list

2014-06-12 Thread Sricharan R
used to track the update. Reported-by: Nishanth Menon Reported-by: Sricharan R Reported-by: Suman Anna Signed-off-by: Rajendra Nayak --- drivers/irqchip/irq-crossbar.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip

[PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning

2014-06-12 Thread Sricharan R
From: Nishanth Menon kernel doc style is wrong in code. fix it to squelch kerneldoc warnings: Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description on line: * struct crossbar_device: crossbar device description Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for st

[PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Sricharan R
From: Nishanth Menon remove un-necessary space in function pointer. Fixes checkpatch warning: WARNING: Unnecessary space before function pointer arguments #37: FILE: drivers/irqchip/irq-crossbar.c:37: + void (*write) (int, int); WARNING: Missing a blank line after declarations + in

[PATCH V2 06/19] irqchip: crossbar: remove IS_ERR_VALUE check

2014-06-12 Thread Sricharan R
From: Nishanth Menon IS_ERR_VALUE makes sense only *if* there could be valid values in negative error range. But in the cases that we do use it, there is no such case. Just remove the same. Signed-off-by: Nishanth Menon --- drivers/irqchip/irq-crossbar.c |6 +++--- 1 file changed, 3 insert

[PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Sricharan R
From: Nishanth Menon When, in the system due to varied reasons, interrupts might be unusable due to hardware behavior, but register maps do exist, then those interrupts should be skipped while mapping irq to crossbars. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R Signed-off-by

[PATCH V2 02/19] irqchip: crossbar: check for premapped crossbar before allocating

2014-06-12 Thread Sricharan R
-off-by: Nishanth Menon Signed-off-by: Sricharan R Signed-off-by: Tony Lindgren --- drivers/irqchip/irq-crossbar.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 20105bc..51d4b87 100644 --- a/drivers

[PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs

2014-06-12 Thread Sricharan R
: Sricharan R Signed-off-by: Tony Lindgren --- drivers/irqchip/irq-crossbar.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 287d3ce..de021638 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b/drivers

[PATCH V2 00/19] irqchip: crossbar: driver fixes

2014-06-12 Thread Sricharan R
entralized check for crossbar write Documentation: dt: OMAP: crossbar: add description for interrupt consumer irqchip: crossbar allow for quirky hardware with direct hardwiring of GIC Rajendra Nayak (1): irqchip: crossbar: DRA7: Fix unused crossbar list Sricharan R (2): irqchip: cro

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> When, in the system due to varied reasons, interrupts might be unusable >> due to hardware behavior, but r

Re: [PATCH V2 10/19] irqchip: crossbar: DRA7: Fix unused crossbar list

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:46 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote: >> From: Rajendra Nayak >> >> On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ, >> IRQ133 is default mapped to NMI pin

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> remove un-necessary space in function pointer. >> >> Fixes checkpatch warning: >> WARNING: Un

Re: [PATCH V2 11/19] irqchip: crossbar: fix memory leak incase of invalid entry

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:50 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:19PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> When the provided unused skip list entry is greater than max irqs >> possible, we go to err3, but we fa

Re: [PATCH V2 09/19] irqchip: crossbar: fix kerneldoc warning

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:44 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> kernel doc style is wrong in code. fix it to squelch >> kerneldoc warnings: > > I would re-word the abo

Re: [PATCH V2 15/19] irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 07:19 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:23PM +0530, Sricharan R wrote: >> The crossbar_domain_map/unmap callbacks need not be called same number >> of times for a particular irq. But still use counting is not needed >>

Re: [PATCH V2 05/19] irqchip: crossbar: Change allocation logic by reversing search for free irqs

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 06:26 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> Reverse the search algorithm to ensure that address mapping and IRQ >> allocation logics are proper. This can

Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

2014-06-12 Thread Sricharan R
oice (and last I saw, > that's you) to ignore whatever doesn't fit the appropriate > vision for the code. > > $ ./scripts/get_maintainer.pl -f drivers/irqchip/irq-crossbar.c > Thomas Gleixner (maintainer:IRQCHIP DRIVERS) > Jason Cooper (maintainer:IRQCHIP DRIVERS) Ok,

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Sricharan R
On Thursday 12 June 2014 07:27 PM, Tony Lindgren wrote: > * Jason Cooper [140612 05:52]: >> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote: >>> From: Nishanth Menon >>> >>> When, in the system due to varied reasons, interrupts might be unusab

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 07:37 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 06:49:17PM +0530, Sricharan R wrote: >> Hi Jason, >> >> On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote: >>> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wr

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-12 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote: >> * Jason Cooper [140612 05:52]: >>> On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote: >>>> From: Nishanth Menon >&g

Re: [PATCH V2 16/19] irqchip: crossbar: introduce ti,max-crossbar-sources to identify valid crossbar mapping

2014-06-13 Thread Sricharan R
Hi Jason, On Thursday 12 June 2014 07:24 PM, Jason Cooper wrote: > On Thu, Jun 12, 2014 at 05:23:24PM +0530, Sricharan R wrote: >> From: Nishanth Menon >> >> Currently we attempt to map any crossbar value to an IRQ, however, >> this is not correct from hardware

Re: [PATCH V2 03/19] irqchip: crossbar: Skip some irqs from getting mapped to crossbar

2014-06-13 Thread Sricharan R
On Friday 13 June 2014 12:26 PM, Sricharan R wrote: > Hi Jason, > > On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote: >> On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote: >>> * Jason Cooper [140612 05:52]: >>>> On Thu, Jun 12, 2014 at

Re: [PATCH V4 0/3] ARM: DTS: DRA7: Updates for adding crossbar device

2014-05-05 Thread Sricharan R
Hi Tony, On Monday 30 December 2013 12:28 PM, Sricharan R wrote: > Hi Benoit, > > On Thursday 14 November 2013 05:55 PM, Sricharan R wrote: >> Some socs have a large number of interrupts requests to service >> the needs of its many peripherals and subsystems. All of the

[PATCH V5 1/3] arm: dts: dra7: Add crossbar device binding

2014-05-06 Thread Sricharan R
only one controller's input line. The crossbar device is used to map a peripheral input to a free mpu's interrupt controller line. Cc: Benoit Cousson Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R Signed-off-by: Nishanth Menon --- [V5] Rebased

[PATCH V5 0/3] arm: dts: dra7: Updates for adding crossbar device

2014-05-06 Thread Sricharan R
This series depends on crossbar-driver-fixes sent below http://marc.info/?l=linux-omap&m=139929963420299&w=2 Sricharan R (3): arm: dts: dra7: Add crossbar device binding arm: dts: dra7: Replace peripheral interrupt numbers with crossbar inputs arm: dts: dra7: Add routable-irqs

[PATCH V5 2/3] arm: dts: dra7: Replace peripheral interrupt numbers with crossbar inputs

2014-05-06 Thread Sricharan R
Cousson Cc: Santosh Shilimkar Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R Signed-off-by: Nishanth Menon --- [V5] Rebased on 3.15-rc4 and replaced irqs numbers with crossbar numbers for new peripherals. arch/arm/boot/dts/dra7.dtsi | 100

[PATCH V5 3/3] arm: dts: dra7: Add routable-irqs property for gic node

2014-05-06 Thread Sricharan R
r Cc: Rajendra Nayak Cc: Tony Lindgren Signed-off-by: Sricharan R Signed-off-by: Nishanth Menon --- [V5] Rebased and corrected routable irqs from 160 to 192 arch/arm/boot/dts/dra7.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi

Re: [PATCH V5 0/3] arm: dts: dra7: Updates for adding crossbar device

2014-05-06 Thread Sricharan R
On Wednesday 07 May 2014 03:15 AM, Darren Etheridge wrote: > Sricharan R wrote on Tue [2014-May-06 19:26:16 +0530]: >> Some socs have a large number of interrupts requests to service >> the needs of its many peripherals and subsystems. All of the interrupt >> requests line

[PATCH V6 0/2] arm: dts: dra7: Updates for adding crossbar device

2014-05-07 Thread Sricharan R
depends on crossbar-driver-fixes sent below http://marc.info/?l=linux-omap&m=139929963420299&w=2 [V6] Reordered patch 3 to patch 1 and squashed patch 2 and 3 from V5 in to patch 2 Sricharan R (2): arm: dts: dra7: Add routable-irqs property for gic node arm: dts: dra7: Add crossba

[PATCH V6 1/2] arm: dts: dra7: Add routable-irqs property for gic node

2014-05-07 Thread Sricharan R
There is a IRQ crossbar device in the soc, which maps the irq requests from the peripherals to the mpu interrupt controller's inputs. The gic provides the support for such IPs in the form of routable-irqs. So adding the property here to gic node. Signed-off-by: Sricharan R Signed-o

[PATCH V6 2/2] arm: dts: dra7: Add crossbar device binding

2014-05-07 Thread Sricharan R
e crossbar device is used to map a peripheral input to a free mpu's interrupt controller line. Here, adding a new crossbar device node and replacing all the peripheral interrupt numbers with its fixed crossbar input lines. Signed-off-by: Sricharan R Signed-off-by: Nishanth Menon Cc: Ben

Re: [Resend/PATCH] arm: dts: dra7: Add qspi device.

2014-05-30 Thread Sricharan R
ts interrupt number. Since the crossbar dts patches are not yet there, this causes a warning during boot. So interrupts = < > property should be removed from DT and added later by crossbar series. Regards, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-k

[PATCH V3 00/16] irqchip: crossbar: driver fixes

2014-06-16 Thread Sricharan R
o identify valid crossbar mapping irqchip: crossbar: introduce centralized check for crossbar write documentation: dt: omap: crossbar: add description for interrupt consumer irqchip: crossbar: allow for quirky hardware with direct hardwiring of GIC Sricharan R (2): irqchip: crossb

[PATCH V3 08/16] irqchip: crossbar: fix kerneldoc warning

2014-06-16 Thread Sricharan R
(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter 'write' 2 warnings Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R --- [V3] Reworded the commit log drivers/irqchip/irq-crossbar.c |4 ++

[PATCH V3 02/16] irqchip: crossbar: check for premapped crossbar before allocating

2014-06-16 Thread Sricharan R
-off-by: Nishanth Menon Signed-off-by: Sricharan R --- drivers/irqchip/irq-crossbar.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 20105bc..51d4b87 100644 --- a/drivers/irqchip/irq-crossbar.c +++ b

[PATCH V3 06/16] irqchip: crossbar: remove IS_ERR_VALUE check

2014-06-16 Thread Sricharan R
From: Nishanth Menon IS_ERR_VALUE makes sense only *if* there could be valid values in negative error range. But in the cases that we do use it, there is no such case. Just remove the same. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R --- drivers/irqchip/irq-crossbar.c |6

[PATCH V3 09/16] irqchip: crossbar: return proper error value

2014-06-16 Thread Sricharan R
From: Nishanth Menon crossbar_of_init always returns -ENOMEM in case of errors. There can be other causes of failure like invalid data from DT. So return a appropriate error value for that case. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R --- [V3] Changed commit log drivers

[PATCH V3 14/16] irqchip: crossbar: introduce centralized check for crossbar write

2014-06-16 Thread Sricharan R
From: Nishanth Menon This is a basic check to ensure that crossbar register needs to be written. This ensures that we have a common check which is used in both map and unmap logic. Signed-off-by: Nishanth Menon Signed-off-by: Sricharan R --- drivers/irqchip/irq-crossbar.c | 14

[PATCH V3 12/16] irqchip: crossbar: add kerneldoc for crossbar_domain_unmap callback

2014-06-16 Thread Sricharan R
Adding kerneldoc for unmap callback function. Signed-off-by: Sricharan R --- [V3] Reworded the kerneldoc drivers/irqchip/irq-crossbar.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c index 9b4c0f1..df16ef8

<    1   2   3   4   5   6   7   8   9   10   >