[PATCH] iwlwifi: mvm: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] rndis_wlan: tighten check of rndis_query_oid return

From: Tom Rix clang static analysis reports this problem rndis_wlan.c:3147:25: warning: Assigned value is garbage or undefined wiphy->max_num_pmkids = le32_to_cpu(caps.num_pmkids); ^ The setting of caps happens h

[PATCH] USB: realtek_cr: fix return check for dma functions

From: Tom Rix clang static analysis reports this representative problem realtek_cr.c:639:3: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage SET_BIT(value, 2); ^ value is set by a successful ca

[PATCH] cdc-acm: rework notification_buffer resizing

From: Tom Rix Clang static analysis reports this error cdc-acm.c:409:3: warning: Use of memory after it is freed acm_process_notification(acm, (unsigned char *)dr); There are three problems, the first one is that dr is not reset The variable dr is set with if (acm->nb_index) d

[PATCH] ieee802154/adf7242: check status of adf7242_read_reg

From: Tom Rix Clang static analysis reports this error adf7242.c:887:6: warning: Assigned value is garbage or undefined len = len_u8; ^ ~~ len_u8 is set in adf7242_read_reg(lp, 0, &len_u8); When this call fails, len_u8 is not set. So check the return code. Fixe

[PATCH] brcmfmac: check ndev pointer

From: Tom Rix Clang static analysis reports this error brcmfmac/core.c:490:4: warning: Dereference of null pointer (*ifp)->ndev->stats.rx_errors++; ^~~ In this block of code if (ret || !(*ifp) || !(*ifp)->ndev) { if (ret != -E

[PATCH] crypto: drbg: check blocklen is non zero

From: Tom Rix Clang static analysis reports this error crypto/drbg.c:441:40: warning: Division by zero padlen = (inputlen + sizeof(L_N) + 1) % (drbg_blocklen(drbg)); ~^~~ When drbg_bocklen fails it returns 0. if (

[PATCH] input: atmel_mxt_ts: fix double free

From: Tom Rix Clang static analysis reports this error atmel_mxt_ts.c:1850:2: warning: Attempt to free released memory kfree(id_buf); ^ The problem is with this code block data->raw_info_block = id_buf; ... error = mxt_parse_object_table(data, id_buf + MXT_OBJECT_ST

[PATCH] hwmon: applesmc: check status earlier.

From: Tom Rix clang static analysis reports this representative problem applesmc.c:758:10: warning: 1st function call argument is an uninitialized value left = be16_to_cpu(*(__be16 *)(buffer + 6)) >> 2; ^~~~ buffer is filled by the earlie

[PATCH] video: fbdev: sis: fix null ptr dereference

From: Tom Rix Clang static analysis reports this representative error init.c:2501:18: warning: Array access (from variable 'queuedata') results in a null pointer dereference templ |= ((queuedata[i] & 0xc0) << 3); This is the problem block of code if(ModeNo > 0x13) { ...

[PATCH] drm/gma500: fix error check

From: Tom Rix Reviewing this block of code in cdv_intel_dp_init() ret = cdv_intel_dp_aux_native_read(gma_encoder, DP_DPCD_REV, ... cdv_intel_edp_panel_vdd_off(gma_encoder); if (ret == 0) { /* if this fails, presume the device is a ghost */ DRM_INFO("failed to retrieve link info,

[PATCH] hwrng : cleanup initialization

From: Tom Rix clang static analysis reports this problem intel-rng.c:333:2: warning: Assigned value is garbage or undefined void __iomem *mem = mem; ^ ~~~ Because mem is assigned before it is used, this is not a real problem. But the initialization is strange

[PATCH] iio: imu: inv_mpu6050: check for temp_fifo_enable

From: Tom Rix clang static analysis reports this problem inv_mpu_ring.c:181:18: warning: Division by zero nb = fifo_count / bytes_per_datum; ~~~^ This is a false positive. Dividing by 0 is protected by this check if (!(st->chip_config.accl_f

[PATCH] leds: mt6323: move period calculation

From: Tom Rix clang static analysis reports this problem leds-mt6323.c:275:12: warning: Division by zero duty_hw = MT6323_CAL_HW_DUTY(*delay_on, period); ^ This is because period can be 0. period = *delay_on + *delay_off; T

[PATCH] vfs: samples: fix memory leak

From: Tom Rix clang static analysis reports this represenative problem test-fsinfo.c:615:3: warning: Potential leak of memory pointed to by 'r' memset(r, 0xbd, buf_size); ^~ r dynamically allocated in a loop an increasing size. for (;;) {

[PATCH] iio: imu: st_lsm6dsx: check st_lsm6dsx_shub_read_output return

From: Tom Rix clang static analysis reports this represenative problem st_lsm6dsx_shub.c:540:8: warning: Assigned value is garbage or undefined *val = (s16)le16_to_cpu(*((__le16 *)data)); ^ ~~~ data is set with err = st_lsm6dsx_shub_

[PATCH] media: tw5864: check status of tw5864_frameinterval_get

From: Tom Rix clang static analysis reports this problem tw5864-video.c:773:32: warning: The left expression of the compound assignment is an uninitialized value. The computed value will also be garbage fintv->stepwise.max.numerator *= std_max_fps; ~~~

[PATCH] writeback: clear auto_free in initializaiton

From: Tom Rix Review fs/fs-writeback.c bdi_split_work_to_wbs The CONFIG_CGROUP_WRITEBACK version contains this line base_work->auto_free = 0; Which seems like a strange place to set auto_free as it is not where the rest of base_work is initialized. In the default version of bdi_split_wor

[PATCH] soc: qcom: initialize local variable

From: Tom Rix clang static analysis reports this problem pdr_interface.c:596:6: warning: Branch condition evaluates to a garbage value if (!req.service_path[0]) ^~~~ This check that req.service_path was set in an earlier loop. However req is a stack variabl

[PATCH] block/rnbd-clt: improve find_or_create_sess() return check

From: Tom Rix clang static analysis reports this problem rnbd-clt.c:1212:11: warning: Branch condition evaluates to a garbage value else if (!first) ^~ This is triggered in the find_and_get_or_create_sess() call because the variable first is not initialized and th

[PATCH] USB: serial: mos7720: improve handling of a kmalloc failure in read_mos_reg()

From: Tom Rix clang static analysis reports this problem mos7720.c:352:2: warning: Undefined or garbage value returned to caller return d; ^~~~ In the parport_mos7715_read_data()'s call to read_mos_reg(), 'd' is only set after the alloc block. buf = kmalloc(1, GFP_K

[PATCH] x86/resctrl: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- arch/x86/kernel/cpu/resctrl/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/cpu/resctrl/interna

[PATCH] Input: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- drivers/input/rmi4/rmi_bus.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/rmi4/rmi_bus.h b/drivers/input/

[PATCH] PNP: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- drivers/pnp/interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c

[PATCH] [SCSI] BusLogic: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- drivers/scsi/BusLogic.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/BusLogic.h b/drivers/scsi/BusLogic.h

[PATCH] scsi: qedi: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- drivers/scsi/qedi/qedi_dbg.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_db

[PATCH] usb: musb: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- drivers/usb/musb/musb_debug.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/musb_debug.h b/drivers/usb/

[PATCH] tracing: add printf attribute to log function

From: Tom Rix Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix --- include/linux/trace.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/trace.h b/include/li

[PATCH] media: pxa_camera: declare variable when DEBUG is defined

From: Tom Rix When DEBUG is defined this error occurs drivers/media/platform/pxa_camera.c:1410:7: error: ‘i’ undeclared (first use in this function) for (i = 0; i < vb->num_planes; i++) ^ The variable 'i' is missing, so declare it. Fixes: 6f28435d1c15 ("[media] media: platform: pxa_c

[PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

From: Tom Rix When DEBUG is defined this error occurs drivers/clocksource/mxs_timer.c:138:1: error: expected ‘;’ before ‘}’ token The preceding statement needs a semicolon. Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface") Signed-off-by: Tom Rix --- dri

[PATCH v2] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

From: Tom Rix When DEBUG is defined this error occurs drivers/clocksource/mxs_timer.c:138:1: error: expected ‘;’ before ‘}’ token The preceding statement needs a semicolon. Replace pr_info() with pr_debug() and remove the unneeded ifdef. Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate

[PATCH] gianfar: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/net/ethernet/freescale/gianfar.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index d3

[PATCH] i2c: stub: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/i2c/i2c-stub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/i2c-stub.c b/drivers/i2c/i2c-stub.c index 537a598e22db..d642cad219d9 100644 --- a/drivers/i2c/i2c-s

[PATCH] x86 mmiotrace: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- arch/x86/mm/mmio-mod.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c index bd7aff5c51f7..cd768dafca9e 100644 --- a/arch/x86/mm/mmi

[PATCH] x86/mm/mtrr: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- arch/x86/kernel/cpu/mtrr/generic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index a29997e6cf9e..b90f3f

[PATCH v2] x86 : remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- v1: merge all 4 in arch/x86/ --- arch/x86/kernel/cpu/mtrr/generic.c | 1 - arch/x86/kernel/cpu/mtrr/mtrr.c| 2 -- arch/x86/kernel/pci-iommu_table.c | 3 --- arch/x86/mm/mmio-mod.c

[PATCH] neighbor: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- net/core/neighbour.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 277ed854aef1..ff073581b5b1 100644 --- a/net/core/neighbour.c ++

[PATCH] rxrpc: fix handling of an unsupported token type in rxrpc_read()

From: Tom Rix clang static analysis reports this problem net/rxrpc/key.c:657:11: warning: Assigned value is garbage or undefined toksize = toksizes[tok++]; ^ ~~~ rxrpc_read() contains two loops. The first loop calculates the token sizes and s

[PATCH] RDMA/ocrdma: fix use after free in ocrdma_dealloc_ucontext_pd()

From: Tom Rix In ocrdma_dealloc_ucontext_pd() uctx->cntxt_pd is assigned to the variable pd and then after uctx->cntxt_pd is freed, the variable pd is passed to function _ocrdma_dealloc_pd() which dereferences pd directly or through its call to ocrdma_mbx_dealloc_pd(). Reorder the free using the

[PATCH] jffs2: fix use after free in jffs2_sum_write_data()

From: Tom Rix clang static analysis reports this problem fs/jffs2/summary.c:794:31: warning: Use of memory after it is freed c->summary->sum_list_head = temp->u.next; ^~~~ In jffs2_sum_write_data(), in a loop summary data is ha

[PATCH] block: sed-opal: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] RDMA/hns: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] net: ena: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] amd-xgbe: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] igb: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] net/mlx5e: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] nfp: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] qed: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] via-velocity: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi

[PATCH] MAINTAINERS: add self as reviewer to INTEL STRATIX10 FIRMWARE DRIVERS

From: Tom Rix The Intel stratix 10 is a fpga. I review fpga's. So I want to help in this related subsystem. Signed-off-by: Tom Rix --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 67b104202602..00828de0a7bc 100644 --- a/MAINTAINERS +++ b/MAIN

[PATCH v2] scsi: qla2xxx: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Remove unneeded escaped newline. Signed-off-by: Tom Rix --- v2: remove unneeded escaped newline --- drivers/scsi/qla2xxx/qla_def.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/d

[RFC] fpga: dfl: a prototype uio driver

From: Tom Rix >From [PATCH 0/2] UIO support for dfl devices https://lore.kernel.org/linux-fpga/1602828151-24784-1-git-send-email-yilun...@intel.com/ Here is an idea to have uio support with no driver override. This makes UIO the primary driver interface because every feature will have one and m

[PATCH v2] net: bna: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Clean up escaped newlines. Signed-off-by: Tom Rix --- v2: fix other macros, cleanup newlines --- drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/driv

[PATCH v2] bpf: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Clean up escaped newlines Signed-off-by: Tom Rix --- v2: more macros fixed, escaped newlines cleaned --- include/trace/events/xdp.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/trace/events/x

[PATCH] ata: sata_nv: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] MAINTAINERS: Add FPGA SUBDEVICES

From: Tom Rix Every FPGA has several subdevices in other subsystems. The new FPGA subdevices section is necessary to ensure changes to the subdevices files get reviewed within the context of the FPGA subsystem. Signed-off-by: Tom Rix --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+)

[PATCH] sched/deadline: fix BUG_ON() ENQUEUE_REPLENISH check

From: Tom Rix When the BUG_ON check for (flags != ENQUEUE_REPLENISH) was created, the flag was set to ENQUEUE_REPLENISH in rt_mutex_setprio(), now it is or-ed in. So the checking logic needs to change. Fixes: 1de64443d755 ("sched/core: Fix task and run queue sched_info::run_delay inconsistenci

[PATCH] net: phy: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] net: ks8851: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/net/ethernet/micrel/ks8851_common.c | 2 -- drivers/net/ethernet/micrel/ks8851_par.c| 2 -- drivers/net/ethernet/micrel/ks8851_spi.c| 2 -- 3 files changed, 6 deletions(

[PATCH] watchdog: it8712f_wdt: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/watchdog/it8712f_wdt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/watchdog/it8712f_wdt.c b/drivers/watchdog/it8712f_wdt.c index 9b89d2f09568..3ce6a58bd81e 100644

[PATCH] tracing: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- kernel/trace/trace_mmiotrace.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c index 84582bf1ed5f..2c3c31791497 1006

[PATCH] net: phy: national: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/net/phy/national.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/phy/national.c b/drivers/net/phy/national.c index 5a8c8eb18582..46160baaafe3 100644 --- a/dri

[PATCH] [media] s5p-mfc: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/media/platform/s5p-mfc/s5p_mfc_debug.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_debug.h b/drivers/media/platform/s5p-mfc/s5p_

[PATCH] Input: i8042: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/input/serio/i8042.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index abae23af0791..411ebb2cefb5 100644 --- a/dr

[PATCH] intel_idle: remove definition of DEBUG

From: Tom Rix Defining DEBUG should only be done in development. So remove DEBUG. Signed-off-by: Tom Rix --- drivers/idle/intel_idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c index 28f93b9aa51b..3273360f30f7 1006

[PATCH v2] selftests: drivers: fpga: A test for interrupt support

From: Tom Rix Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns an expected result. Tested on vf device 0xbcc1 Sample run with # make -C tools/testing/selftests TARGETS=drivers/fpga run_tests ... TAP version 13 1..1 # selftests: drivers/fpga: intr # TAP version 13 # 1..1 # # St

[PATCH v3] selftests: drivers: fpga: A test for interrupt support

From: Tom Rix Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns an expected result. Tested on vf device 0xbcc1 Sample run with # make -C tools/testing/selftests TARGETS=drivers/fpga run_tests ... TAP version 13 1..1 # selftests: drivers/fpga: intr # TAP version 13 # 1..1 # # St

[PATCH] arcnet: fix macro name when DEBUG is defined

From: Tom Rix When DEBUG is defined this error occurs drivers/net/arcnet/com20020_cs.c:70:15: error: ‘com20020_REG_W_ADDR_HI’ undeclared (first use in this function); did you mean ‘COM20020_REG_W_ADDR_HI’? ioaddr, com20020_REG_W_ADDR_HI); ^~ >From r

[PATCH] net: hns: fix variable used when DEBUG is defined

From: Tom Rix When DEBUG is defined this error occurs drivers/net/ethernet/hisilicon/hns/hns_enet.c:1505:36: error: ‘struct net_device’ has no member named ‘ae_handle’; did you mean ‘rx_handler’? assert(skb->queue_mapping < ndev->ae_handle->q_num); ^

[PATCH] media: mtk-vcodec: fix argument used when DEBUG is defined

From: Tom Rix When DEBUG is defined this error occurs drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c:306:41: error: ‘i’ undeclared (first use in this function) mtk_v4l2_debug(2, "reg[%d] base=0x%p", i, dev->reg_base[VENC_SYS]); Reviewing the old line mtk_v4l2_debug(2, "reg[

[PATCH v2] MAINTAINERS: Add FPGA SUBDEVICES

From: Tom Rix Every FPGA has several subdevices in other subsystems. The new FPGA subdevices section is necessary to ensure changes to the subdevices files get reviewed within the context of the FPGA subsystem. Signed-off-by: Tom Rix --- v1: Add several more subdevices --- MAINTAINERS | 11 +++

[PATCH] sgi-xp: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] can: mcba_usb: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] ipvlan: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH v4] selftests: drivers: fpga: A test for interrupt support

From: Tom Rix Check that the ioctl DFL_FPGA_PORT_ERR_GET_IRQ_NUM returns an expected result. Tested on vf device 0xbcc1 Sample run with # make -C tools/testing/selftests TARGETS=drivers/fpga run_tests ... TAP version 13 1..1 # selftests: drivers/fpga: intr # TAP version 13 # 1..1 # # St

[PATCH] ath10k: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] ath11k: remove h from printk format specifier

From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xud

[PATCH] cifs: check pointer before freeing

From: Tom Rix clang static analysis reports this problem dfs_cache.c:591:2: warning: Argument to kfree() is a constant address (18446744073709551614), which is not memory allocated by malloc() kfree(vi); ^ In dfs_cache_del_vol() the volume info pointer 'vi' being freed

[PATCH] mm: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- arch/x86/mm/fault.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c index

[PATCH] block: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- block/blk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 7663a9b94b80..7c

[PATCH] atm: ambassador: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/atm/ambassador.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassa

[PATCH] atm: horizon: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/atm/horizon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c i

[PATCH] drm/i915: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/i915/gt/intel_sseu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_sseu.c

[PATCH] drm/amdgpu: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 +

[PATCH] drm/radeon: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/gpu/drm/radeon/radeon_uvd.c | 2 +- drivers/gpu/drm/radeon/radeon_vce.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] greybus: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/greybus/greybus_trace.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/greybus/greybus_trace.h b/dri

[PATCH] HID: uclogic: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/hid/hid-uclogic-params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-uclogic-params.c b/drivers

[PATCH] HID: wiimote: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/hid/hid-wiimote-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid

[PATCH] hwmon: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/hwmon/smsc47m1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/smsc47m1.c b/drivers/hwmon/smsc47m1.

[PATCH] i2c: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/i2c/i2c-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c i

[PATCH] IB/hfi1: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/infiniband/hw/hfi1/sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hfi1/sdma.c b/driv

[PATCH] iommu/amd: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi]. Si

[PATCH] dm dust: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi]. Si

[PATCH] [media] radio-si470x: remove h from printk format specifier

From: Tom Rix See Documentation/core-api/printk-formats.rst. commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi]. Si

[PATCH] eCryptfs: add a semicolon

From: Tom Rix Function like macros should have a semicolon. Signed-off-by: Tom Rix --- fs/ecryptfs/keystore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c index f6a17d259db7..2abd219cfeec 100644 --- a/fs/ecryptfs/keystore.c

[PATCH] xen: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- arch/x86/include/asm/xen/page.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/xen/page.h b/arch/x86/include/asm/xen/page.h index 5941e18edd5a..1a162e559753 100644 --

[PATCH] x86/tboot: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- arch/x86/kernel/tboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c index 7b1425dc2549..fdbb2f9ac61d 100644 --- a/arch/x86/kernel/tboo

[PATCH] crypto: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- crypto/seed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/seed.c b/crypto/seed.c index 5e3bef3a617d..27720140820e 100644 --- a/crypto/seed.c +++ b/crypto/seed.c @@ -322,7 +322,7

[PATCH] drm/amdgpu/display: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index f9c81bc21ba4..301e93c9e

[PATCH] drm/i915: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix --- drivers/gpu/drm/i915/intel_device_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c index e67cec8f

  1   2   3   4   >