Re: 3.6.0 kernel - ext4 corruption, or?

2012-10-24 Thread tytso
On Wed, Oct 24, 2012 at 08:15:37AM -0400, Justin Piszcz wrote: > > I read there was a bug in 3.6.2, is there also one in 3.6.0, or can someone > help explain this? The problem which we are currently trying to investigate was reportedly introduced in v3.6.1. So far that's about how we know; we ha

Re: [Ext2-devel] ext2 inode size (on-disk)

2001-04-19 Thread tytso
On Thu, Apr 19, 2001 at 07:55:20AM -0400, Alexander Viro wrote: > Erm... Folks, can ->s_inode_size be not a power of 2? Both > libext2fs and kernel break in that case. This was a project that was never completed. I thought at one point of allowing the inode size to be not a power of 2, bu

Re: mke2fs and kernel VM issues

2001-02-16 Thread tytso
Date: Fri, 16 Feb 2001 09:48:17 + (GMT) From: Alan Cox <[EMAIL PROTECTED]> > heavily modifed VA kernel based on 2.2.18. Is there a kernel which is > believed to be a known good kernel? (both 2.2.x and 2.4.x) I've not seen the problem on unmodified 2.2.18. The 2.2.17/18 VM do

Re: [Ext2-devel] [rfc] Near-constant time directory index for Ext2

2001-02-21 Thread tytso
Daniel, Nice work! A couple of comments. If you make the beginning of each index block look like a an empty directory block (i.e, the first 8 blocks look like this): 32 bits: ino == 0 16 bits: rec_len == blocksize 16 bits: name_len = 0 ... then you will have full backw

Re: [Ext2-devel] [rfc] Near-constant time directory index for Ext2

2001-02-22 Thread tytso
From: Daniel Phillips <[EMAIL PROTECTED]> Date: Thu, 22 Feb 2001 08:24:08 +0100 Content-Type: text/plain > Is it worth it? Well, it means you lose an index entry from each > directory block, thus reducing your fanout at each node of the tree by a > worse case of 0.7% in the wor

Re: [Ext2-devel] [rfc] Near-constant time directory index for Ext2

2001-02-22 Thread tytso
From: Andreas Dilger <[EMAIL PROTECTED]> Date: Thu, 22 Feb 2001 11:16:32 -0700 (MST) One important question as to the disk format is whether the "." and ".." interception by VFS is a new phenomenon in 2.4 or if this also happened in 2.2? If so, then having these entries on disk wi

Re: [Ext2-devel] [rfc] Near-constant time directory index for Ext2

2001-02-23 Thread tytso
From: Daniel Phillips <[EMAIL PROTECTED]> Date: Fri, 23 Feb 2001 00:04:02 +0100 I resolve not to take a position on this subject, and I will carry forward both a 'squeaky clean' backward-compatible version that sets an INCOMPAT flag, and a 'slightly tarnished' but very clever versi

Re: [PATCH] /drivers/char/serial.c cleanup

2001-03-05 Thread tytso
Date: Mon, 5 Mar 2001 15:37:04 +0300 From: Andrey Panin <[EMAIL PROTECTED]> I already sent this patch some days ago, but didn't get an answer :( So, i'm trying to resubmit it. Thanks for submitting it; the general idea of the patch looks good, but as prumpf pointed out, the test for

Locking problem in 2.2.18/19-pre7? (fs/inode.c and fs/dcache.c)

2001-01-16 Thread tytso
HJ Lu recently pointed me at a potential locking problem try_to_free_inodes(), and when I started proding at it, I found what appears to be another set of SMP locking issues in the dcache code. (But if that were the case, why aren't we seeing huge numbers of complaints? So I'm wondering if I'm m

Re: Locking problem in 2.2.18/19-pre7? (fs/inode.c and fs/dcache.c)

2001-01-16 Thread tytso
Date: Tue, 16 Jan 2001 20:33:34 +0100 From: Andrea Arcangeli <[EMAIL PROTECTED]> > Of course, this is utterly unsafe on an SMP machines, since access to > the "block" variable isn't protected at all. So the first question is Wrong, it's obviously protected by the inode_lock. And

Re: [PATCH] pcmcia event thread. (fwd)

2000-11-16 Thread tytso
Date: Sat, 1 Jan 2000 02:54:52 + From: Pavel Machek <[EMAIL PROTECTED]> Cc: David Woodhouse <[EMAIL PROTECTED]>, David Hinds <[EMAIL PROTECTED]>, [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] > It's purposefully not on Ted's criti

Re: 2.4.0-test11: kernel: waitpid(823) failed, -512

2000-12-04 Thread tytso
On Sun, Dec 03, 2000 at 11:36:11PM +0100, Frank van Maarseveen wrote: > While playing with routing (zebra) and PPP I regularly see this > message appearing. It always happens when pppd terminates a connection, > e.g: > Dec 3 23:09:08 mimas kernel: waitpid(823) failed, -512 This means a system ca

Patch to ext2 for test8-pre1

2000-09-02 Thread tytso
Hi Linus, Could you please apply following patch against ext2. It contains Al Viro's truncate SMP rewrite to avoid races, which I've checked over and blessed. (Please remove truncate.c after applying this patch; the new truncate code is in inode.c because it needed certain static functions in

NLS handling in Filesystem code

2000-09-11 Thread tytso
From: Meelis Roos <[EMAIL PROTECTED]> Date:Sun, 20 Aug 2000 13:27:40 +0200 TTo> * If all the ISO NLS's are modules, there can be an TTo> undefined ref to CONFIG_NLS_DEFAULT in inode.c (Dale Amon) Somebody please recheck Config in about NLS. ISOFS has different

Re: Updated Linux 2.4 issues page

2000-09-11 Thread tytso
Date:Sun, 20 Aug 2000 14:16:04 +0200 (CEST) From: Urban Widmark <[EMAIL PROTECTED]> You mean the "$CONFIG_JOLIET" = "y" ? The only users of CONFIG_NLS_DEFAULT in 2.4 that I can find are fat and smbfs. The condition for enabling nls is: if [ "$CONFIG_JOLIET" = "y" -o "$

Re: rocket port patch for 2.4

2000-09-12 Thread tytso
Date: Tue, 5 Sep 2000 19:58:48 -0500 From: Steven Critchfield <[EMAIL PROTECTED]> I have been playing with the rocket port driver in 2.4 trying to make it work. It appears that the driver hasn't been modified in some time, as it did not work at all on the debian potato inbstall of

Re: [BUG] threaded processes get stuck in rt_sigsuspend/fillonedir/exit_notify

2000-09-12 Thread tytso
Date: Tue, 12 Sep 2000 07:28:22 -0700 From: David Ford <[EMAIL PROTECTED]> Well, how about backing out the threads change until somebody is ready to fix everything involved. I haven't the time, depth of knowledge, or rep for this. At present the only thing it seems to do is br

Update Linux 2.4 Status/TODO list

2000-09-12 Thread tytso
nges.html As always, if you're curious what state this document is in, you can always get the latest copy by going to: http://linux24.sourceforge.net - Ted Linux 2.4 Status/TODO Page Last modified

Re: Proposal: Linux Kernel Patch Management System

2000-09-13 Thread tytso
Date: Wed, 13 Sep 2000 15:29:04 +0100 (BST) From: Alan Cox <[EMAIL PROTECTED]> > Like any tracking system, the suceess or failure of its rollout depends > completely on whether Linus et al will be steadfast enough to refuse > to look at any patch that hasn't gone through the system

Re: Proposal: Linux Kernel Patch Management System

2000-09-14 Thread tytso
Date: Thu, 14 Sep 2000 15:28:48 -0700 (PDT) From: <[EMAIL PROTECTED]> On Wed, 13 Sep 2000, Daniel Quinlan wrote: > "Fixes" - followed by one or more bug numbers (tracked by tytso > for now). For example, "T0001" might be tytso

Re: fsck

2000-09-21 Thread tytso
Date:Mon, 18 Sep 2000 12:06:22 +0200 From: octave klaba <[EMAIL PROTECTED]> I make the tests of fsck with raid-soft 2x18Go raid-1. We crash the server to see how much time does fsck take (power down) :) - with standard /etc/rc.d/rc.sysinit of redhat 6.2 it takes 1h30

Re: Updated serial driver for 2.2.x

2000-09-22 Thread tytso
Date:Wed, 20 Sep 2000 23:01:26 + From: =?iso-8859-1?Q?Lubom=EDr?= Bulej <[EMAIL PROTECTED]> I'd like to ask if there exists a backport of 2.4 serial driver to 2.2.x. I've got to get one Oxford Semiconductor PCI serial board with UART 16950 on it running but fail to do

Re: Hang on 2.2.17 - serial/tty related?

2000-09-22 Thread tytso
From: Russell King <[EMAIL PROTECTED]> Date:Wed, 20 Sep 2000 22:45:59 +0100 (BST) I just experianced a complete hang of one of my systems here after using the serial port a lot (ie, open, read/write, close). I was using minicom, and I started to notice that each time I qui

Re: use of add_interrupt_randomness in drivers missing in many drivers

2000-10-19 Thread tytso
From: [EMAIL PROTECTED] (David Wagner) Date:18 Oct 2000 20:29:33 GMT Adding more bits to the pool should never hurt; the cryptographic mixing ensures this. What _can_ hurt is adding predictable bits but (erroneously) bumping up the entropy counter. Yes; and writing to /de

Re: ext2fs disaster - how to recover some files ?

2000-11-01 Thread tytso
On Wed, Oct 25, 2000 at 06:41:57PM -0600, Andreas Dilger wrote: > Since you have a filesystem > 500MB it will default to having 4kB blocks, > and the backup superblocks will be aligned on 32768 block boundaries. > Try "e2fsck -B 4096 -b 32768" (or 98304, 163840, 229376, 81920) to see > if that wor

Re: 2.4.0-test10-pre6: Use of abs()

2000-11-01 Thread tytso
On Mon, Oct 30, 2000 at 05:14:34PM +0100, Martin Dalecki wrote: > Of corse right! BTW. There are tons of places where log2 is calculated > explicitly in kernel which should be replaced with the corresponding > built > in functions as well (/dev/random code does it). And then If I remember > corre

BUG FIX?: mm->rss is modified in some places without holding the page_table_lock

2000-11-03 Thread tytso
I'm in the process of updating the 2.4 bug list for test10, and as near as I can tell, there was a lot of discussion about two different ways of fixing this bug: > 9. To Do > * mm->rss is modified in some places without holding the > page_table_lock (sct) To wit, either making mm->rss

Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-03 Thread tytso
the e-mail message which prompted me to include a bug/issue in this list, contact me. I keep an mail archive which will have that information assuming it was an item added since I took over the list from Alan. Last modified: [tytso:20001103.1002EST] Hopefully up to date as of: t

Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-07 Thread tytso
Date: Fri, 3 Nov 2000 15:53:34 + (GMT) From: Alan Cox <[EMAIL PROTECTED]> > * AIC7xxx doesnt work non PCI ? (Doug says OK, new version due >anyway) This is now in Justin Gibbs hand but will take time to move on. Doug confirmed his current code is now merged too

Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-07 Thread tytso
Date: Fri, 03 Nov 2000 16:10:50 -0500 From: Jeff Garzik <[EMAIL PROTECTED]> Part of that might be that serial doesn't support hotplug without patching. Did the patch which I sent out a few weeks ago actually work? I haven't had time to get back to it, but I now have a cardbus card,

Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-07 Thread tytso
Date: Fri, 03 Nov 2000 17:20:53 -0500 From: Jeff Garzik <[EMAIL PROTECTED]> > 4. Boot Time Failures > > * Crashes on boot on some Compaqs ? (may be fixed) compaq laptops? desktops? or alphas? Absolutely no idea. This was one I inherited from Alan's list. If Alan or s

Re: [ANNOUNCE] Generalised Kernel Hooks Interface (GKHI)

2000-11-11 Thread tytso
Date: Fri, 10 Nov 2000 19:29:26 -0800 From: "Matt D. Robinson" <[EMAIL PROTECTED]> We're planning to isolate the write functions as much as possible. In the past, we've been bitten by this whole concept of Linux "raw I/O". When I was at SGI, we were able to write to a block device

Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-11 Thread tytso
Date: Fri, 3 Nov 2000 17:10:52 -0800 (PST) From: James Simmons <[EMAIL PROTECTED]> > * VGA Console can cause SMP deadlock when doing printk {CRITICAL} >(Keith Owens) Still not fixed :-( Here is the patch again. Keith give it a try and tell me if it solves your prob

Re: What protects f_pos?

2000-11-11 Thread tytso
From: David Wragg <[EMAIL PROTECTED]> Date:04 Nov 2000 22:16:18 + Since f_pos of struct file is a loff_t, on 32-bit architectures it needs a lock to make accesses atomic (or some more sophisticated form of protection). But looking in 2.4.0-test10, there doesn't seem to

Linux 2.4 Status/TODO page (test11-pre3)

2000-11-12 Thread tytso
the person who originally reported the problem, or want to see the e-mail message which prompted me to include a bug/issue in this list, contact me. I keep an mail archive which will have that information assuming it was an item added since I took over the list from Alan. Last modified

Serial cardbus code.... for testing, please.....

2000-12-08 Thread tytso
I haven't been able to get PCMCIA working under Linux 2.4 with any kind of serial devices (Cardbus or normal ISA), at least not reliably, on my Vaio 505TX. I've tried both yenta_socket and i82365. It works about one time in ten, but I've never figured out what causes it to work or not work. Wh

Re: Serial cardbus code.... for testing, please.....

2000-12-13 Thread tytso
ly a critical problem because we have slop space in the flip buffer for this purpose, but it really would be good to have this fixed.) * Add support for the DCI PCCOM8 8-port serial board Patch gen

Re: Serial cardbus code.... for testing, please.....

2000-12-14 Thread tytso
really would be good to have this fixed.) * Add support for the DCI PCCOM8 8-port serial board Patch generated: on Wed Dec 13 10:39:41 EST 2000 by tytso@trampoline against Linux version 2.4.0 === RCS file: Doc

Re: [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954

2000-12-17 Thread tytso
Date: Sun, 17 Dec 2000 01:51:15 +0100 (CET) From: Lukasz Trabinski <[EMAIL PROTECTED]> OK, You have right, I'm not a driver programmer, but it probably should look like this: +#define PCI_DEVICE_ID_OXSEMI_16PCI954 0x9501 That's correct, yes. The reason why the original poster

Re: What is up with Redhat 7.0?

2000-10-02 Thread tytso
Date: Sat, 30 Sep 2000 15:07:49 +0100 (BST) From: Alan Cox <[EMAIL PROTECTED]> > If you don't like this, I suggest you send mail complaining to RedHat. > Customer complaints are going to be the only way that RH is going to be > influenced not to play games like this Remind

Re: Bug in block device read/write!

2000-09-12 Thread tytso
Date:Fri, 08 Sep 2000 03:41:27 +0100 From: Anton Altaparmakov <[EMAIL PROTECTED]> I have been trying to get the linear md driver to work with NTFS volumes for several months and it never worked. - I was suspecting the NTFS driver (after having fixed linear md and verified

Updated 2.4 TODO List

2000-10-08 Thread tytso
mail archive which will have that information assuming it was an item added since I took over the list from Alan. Last modified: [tytso:20001009.0008EDT] Hopefully up to date as of: test9 1. Should Be Fixed (Confirmation Wanted) * Fbcon races (cursor problems when running

Re: Updated 2.4 TODO List

2000-10-11 Thread tytso
Date: Tue, 10 Oct 2000 17:53:57 -0300 (BRST) From: Rik van Riel <[EMAIL PROTECTED]> > 2. Capable Of Corrupting Your FS/data > > * Non-atomic page-map operations can cause loss of dirty bit on >pages (sct, alan) Is anybody looking into fixing this bug ? Accordi

Re: tty_[un]register_devfs putting 3K structures on the stack

2000-10-11 Thread tytso
Date: Fri, 06 Oct 2000 16:22:11 -0500 From: Jeff Dike <[EMAIL PROTECTED]> [EMAIL PROTECTED] said: > And it's allocating a tty_struct for a really dumb reason, too. It's > just using it so it cna call tty_name. > Just replace the call to tty_name with something like this: >

Re: test10-pre1 BUG at page_alloc.c:221!

2000-10-11 Thread tytso
Date:Wed, 11 Oct 2000 16:33:09 +0100 (BST) From: Tigran Aivazian <[EMAIL PROTECTED]> Maybe this is because I called this machine - hilbert, so now it gives me nothing but very interesting and exciting Problems... in fact too many of them :) There was a similar problem repo

Re: Updated 2.4 TODO List

2000-10-11 Thread tytso
Date: Mon, 09 Oct 2000 20:13:35 +0200 From: Thomas Sailer <[EMAIL PROTECTED]> Alan Cox wrote: > > > 4. Boot Time Failures > > > > * IBM Thinkpad 390 won't boot since 2.3.11 (See Decklin Foster for > >more info) > > Add Palmax PD1100 hangs during boot s

Re: Updated 2.4 TODO List

2000-10-11 Thread tytso
Date: Mon, 9 Oct 2000 16:24:24 +0100 (BST) From: Alan Cox <[EMAIL PROTECTED]> > * FAT filesystem doesn't support 2kb sector sizes (did under 2.2.16, >doesn't under 2.4.0test7. Kazu Makashima, alan) [Same as the CDROM bug listed earlier I think] The bug report said th

Re: Updated 2.4 TODO List

2000-10-11 Thread tytso
Date: Sun, 8 Oct 2000 23:24:49 -0700 From: Mitchell Blank Jr <[EMAIL PROTECTED]> > * IBM Thinkpad 390 won't boot since 2.3.11 (See Decklin Foster for >more info) I _highly_ suspect that this is not a 2.4 bug but is instead user error. I've seen it several times.

Re: Request for TODO file

2000-10-11 Thread tytso
From: "Eric Bresie" <[EMAIL PROTECTED]> Date:Mon, 9 Oct 2000 15:31:56 -0500 The existing TODO type list I refer to are those produced by Kenneth C. Arnold ( http://kena.8k.com/linux-kernel/ ) (who is doing a fine job I might add) and formerly by Alan Cox. I've taken a look

Updated Linux 2.4 Status/TODO List (from the ALS show)

2000-10-12 Thread tytso
person who originally reported the problem, or want to see the e-mail message which prompted me to include a bug/issue in this list, contact me. I keep an mail archive which will have that information assuming it was an item added since I took over the list from Alan. Last modified:

Re: Renaming lost+found

2001-01-31 Thread tytso
On Sun, Jan 28, 2001 at 01:35:44PM -0800, H. Peter Anvin wrote: > *renamed*, i.e. does the tools (e2fsck &c) use "/lost+found" by name, > or by inode? As far as I know it always uses the same inode number e2fsck uses /lost+found by name, not by inode. It will recreate a new lost+found directory

Re: Lucent Microelectronics Venus Modem, serial 5.05, and Linux 2.4.0

2001-02-08 Thread tytso
On Sun, Jan 14, 2001 at 08:10:45PM +0100, W. Michael Petullo wrote: > > In serial.c, you seem to perform a check by writing to a possible > > modem's interrupt enable register and reading the result. This seems to > > be one of the points at which the auto-configuration process occasionally > > f

Re: Remove TO DO in jfs_xtree.c

2014-12-29 Thread tytso
On Mon, Dec 29, 2014 at 04:13:37PM -0600, Dave Kleikamp wrote: > On 12/27/2014 06:58 PM, nick wrote: > > Greetings Dave, > > I am wondering why there is a TO DO above this code: > > * ToDo: tlocks should be on doubly-linked list, so we can > > * quickly remove it and add it to the

Re: [PATCH] ext4: fix spelling mistakes in extents.c

2020-07-29 Thread tytso
On Wed, Jun 10, 2020 at 11:19:46PM -0400, Keyur Patel wrote: > Fix spelling issues over the comments in the code. > > requsted ==> requested > deterimined ==> determined > insde ==> inside > neet ==> need > somthing ==> something > > Signed-off-by: Keyur Patel Applied, thanks.

Re: [PATCH] Replace HTTP links with HTTPS ones: Ext4

2020-08-05 Thread tytso
On Mon, Jul 06, 2020 at 09:03:39PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. Thanks, applied. - Ted

Re: ext4: fix spelling typos in ext4_mb_initialize_context

2020-08-05 Thread tytso
On Wed, Jul 15, 2020 at 11:00:44AM +0800, brookxu wrote: > Fix spelling typos in ext4_mb_initialize_context. > > Signed-off-by: Chunguang Xu Thanks, applied. - Ted

Re: [PATCH] jbd2: fix incorrect code style

2020-08-05 Thread tytso
On Sat, Jul 18, 2020 at 08:57:37AM -0400, Xianting Tian wrote: > Remove unnecessary blank. > > Signed-off-by: Xianting Tian Thanks, applied. - Ted

Re: [PATCH] ext4: move buffer_mapped() to proper position

2020-08-07 Thread tytso
apped(bh)' to __sync_dirty_buffer(). This also has the benefit of fixing this for other file systems. With this addition, we can drop the workaround in ext4_commit_supper(). [ Commit description rewritten by tytso. ] Signed-off-by: Xianting Tian Link: https

Re: [PATCH] ext4: fix marking group trimmed if all blocks not trimmed

2020-08-07 Thread tytso
On Mon, Aug 03, 2020 at 04:17:44PM +, Lazar Beloica wrote: > When FTRIM is issued on a group, ext4 marks it as trimmed so another FTRIM > on the same group has no effect. Ext4 marks group as trimmed if at least > one block is trimmed, therefore it is possible that a group is marked as > trimmed

Re: [PATCH] ext4: fix debug format string warning

2021-04-09 Thread tytso
On Fri, Apr 09, 2021 at 10:12:05PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Using no_printk() for jbd_debug() revealed two warnings: > > fs/jbd2/recovery.c: In function 'fc_do_one_pass': > fs/jbd2/recovery.c:256:30: error: format '%d' expects a matching 'int' > argument [-Werror=fo

Re: [v7] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

2014-03-15 Thread tytso
I just noticed I had the v6 version of your patch in my tree. I've updated it to be the v7 version, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-16 Thread tytso
On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: > > Note that with indirect descriptors (which is supported by Almost > Everyone), we can actually use the full index, so this value is a bit > pessimistic. But it's OK as a starting point. So is this something that can go upstream w

Re: Q on ioctl BLKGETSIZE

2014-03-18 Thread tytso
On Tue, Mar 18, 2014 at 01:17:25PM +0100, Ulrich Windl wrote: > > Three questions: > 1) Shouldn't the manual page says that the sector size of always 512 Bytes, > even on new disks with larger sectors? > 2) Should the real sector size be used for new disks? The HDD industry is using 512 byte log

Re: [PATCH v2 0/4] RDSEED support for the Linux kernel

2014-03-18 Thread tytso
On Mon, Mar 17, 2014 at 04:36:26PM -0700, H. Peter Anvin wrote: > Changes since version 1: > > a. Rebased on top of random.git:dev. > b. Unbreak the PowerPC build (I had managed to miss that PowerPC had >grown archrandom.h support.) > c. Remove duplicate dummy function definitions in . > d. Ad

Re: Page cache corruption with mount/unmount of USB with Fat file system

2014-03-19 Thread tytso
On Thu, Mar 20, 2014 at 12:05:44AM +0530, Nilesh More wrote: > Hi all, > > First of all sorry for the lengthy mail but I did not want to miss out > on any details. > > The following issue that I am reporting occurs when I plugin the USB > drive on android tablet with USB mount support. Please not

Re: Trusted kernel patchset for Secure Boot lockdown

2014-03-20 Thread tytso
On Wed, Mar 19, 2014 at 01:16:15PM -0700, Kees Cook wrote: > UEFI is a red herring in both cases. This isn't about UEFI, it just > happens that one of the things that can assert "trusted_kernel" is the > UEFI Secure Boot path. Chrome OS would assert "trusted_kernel" by > passing it on the kernel co

Re: [PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread tytso
On Wed, Mar 19, 2014 at 08:06:45PM +0100, David Herrmann wrote: > > This series introduces the concept of "file sealing". Sealing a file restricts > the set of allowed operations on the file in question. Multiple seals are > defined and each seal will cause a different set of operations to return

Re: [PATCH 0/6] File Sealing & memfd_create()

2014-03-20 Thread tytso
On Thu, Mar 20, 2014 at 04:48:30PM +0100, David Herrmann wrote: > On Thu, Mar 20, 2014 at 4:32 PM, wrote: > > Why not make sealing an attribute of the "struct file", and enforce it > > at the VFS layer? That way all file system objects would have access > > to sealing interface, and for memfd_sh

Re: flaw in "nf_tables: add reject module for NFPROTO_INET"

2014-02-12 Thread tytso
On Wed, Feb 12, 2014 at 01:05:54PM -0800, Kees Cook wrote: > > I'd be up for it. It's why I CC'd you, I figured if I'd missed the > report it would have likely have come from you. :) Perhaps just start > by CCing each other, and if others want to get in on the fun too, move > to a list then? I'm

Re: [ksummit-attendees] [PATCH] commit: Add -f, --fixes option to add Fixes: line

2013-10-28 Thread tytso
[ I've removed Junio and the git mailing list form the -cc ] On Mon, Oct 28, 2013 at 11:41:17PM +, Russell King - ARM Linux wrote: > > I agree too. This whole thread seems to be about noise, and I too > thought there was something about not cross-posting between this list > and any other lis

Re: [PATCH] random: Add "initialized" variable to proc

2014-05-01 Thread tytso
On Wed, Apr 30, 2014 at 09:05:00PM -0700, H. Peter Anvin wrote: > > Giving the guest a seed would be highly useful, though. There are a > number of ways to do that; changing the boot protocol is probably > only useful if Qemu itself bouts the kernel as opposed to an in-VM > bootloader. So how ab

Re: random: Providing a seed value to VM guests

2014-05-01 Thread tytso
On Thu, May 01, 2014 at 12:02:49PM -0700, Andy Lutomirski wrote: > > Is RDSEED really reasonable here? Won't it slow down by several > orders of magnitude? That is I think the biggest problem; RDRAND and RDSEED are fast if they are native, but they will involve a VM exit if they need to be emula

Re: random: Providing a seed value to VM guests

2014-05-01 Thread tytso
On Thu, May 01, 2014 at 01:32:55PM -0700, Andy Lutomirski wrote: > On Thu, May 1, 2014 at 1:30 PM, H. Peter Anvin wrote: > > RDSEED is not synchronous. It is, however, nonblocking. > > What I mean is: IIUC it's reasonable to call RDSEED a few times in a > loop and hope it works. It makes no sen

Re: random: Providing a seed value to VM guests

2014-05-01 Thread tytso
On Thu, May 01, 2014 at 02:06:13PM -0700, Andy Lutomirski wrote: > > I still don't see the point. What does this do better than virtio-rng? I believe you had been complaining about how complicated it was to set up virtio? And this complexity is also an issue if we want to use it to initialize t

Re: Reminder for kernel summit nominations

2014-05-09 Thread tytso
On Fri, May 09, 2014 at 11:23:19AM -0400, Theodore Ts'o wrote: > ... please send nominations to: > > kernel-sum...@lists.linuxfoundation.org Argh, sorry, I screwed up the e-mail address. The correct e-mail address is. ksummit-disc...@lists.linuxfoundation.org My apologies

Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

2014-03-22 Thread tytso
On Fri, Mar 21, 2014 at 01:00:55PM -0700, Andrew Morton wrote: > > The whole point of __GFP_NOFAIL is to centralise this > wait-for-memory-for-ever operation. So it is implemented in a common > (core) place and so that we can easily locate these problematic > callers. > > is exactly wrong. Yes,

Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

2014-03-22 Thread tytso
On Sat, Mar 22, 2014 at 10:15:12AM -0700, Andrew Morton wrote: > > I'll note that since 2011, there has been precious little movement on > > removing the final few callers of GFP_NOFAIL, and we still have a bit > > under two dozen of them, including a new one in fs/buffer.c that was > > added in 20

Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

2014-03-22 Thread tytso
On Sat, Mar 22, 2014 at 01:26:06PM -0400, ty...@mit.edu wrote: > > Well. Converting an existing retry-for-ever caller to GFP_NOFAIL is > > good. Adding new retry-for-ever code is not good. Oh, and BTW --- now that checkpatch.pl now flags an warning whenever GFP_NOFAIL is used, because it is depr

Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

2014-03-22 Thread tytso
On Sat, Mar 22, 2014 at 10:55:24AM -0700, Andrew Morton wrote: > > From: Andrew Morton > Subject: scripts/checkpatch.pl: __GFP_NOFAIL isn't going away > > Revert 7e4915e78992eb ("checkpatch: add warning of future __GFP_NOFAIL use"). > > There are no plans to remove __GFP_NOFAIL. > > __GFP_NOFA

Re: [PATCH v7 19/22] ext4: Make ext4_block_zero_page_range static

2014-03-24 Thread tytso
On Sun, Mar 23, 2014 at 03:08:45PM -0400, Matthew Wilcox wrote: > It's only called within inode.c, so make it static, remove its prototype > from ext4.h and move it above all of its callers so it doesn't need a > prototype within inode.c. > > Signed-off-by: Matthew Wilcox Thanks, applied to the

Re: [PATCH v7 21/22] ext4: Fix typos

2014-03-24 Thread tytso
On Sun, Mar 23, 2014 at 03:08:47PM -0400, Matthew Wilcox wrote: > Comment fix only > > Signed-off-by: Matthew Wilcox Thanks, applied to the ext4 git tree. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 2/2] ext4: acl: remove unneeded include of linux/capability.h

2014-03-24 Thread tytso
On Mon, Mar 24, 2014 at 08:22:12AM +0100, Jakub Sitnicki wrote: > acl.c has not been (directly) using the interface defined by > linux/capability.h header since commit 3bd858ab1c451725c07a > ("Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid > check"). Remove it. > > Signed-off-by: Ja

Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

2014-03-25 Thread tytso
On Tue, Mar 25, 2014 at 06:06:17PM -0700, David Rientjes wrote: > > The point is not to add new callers and new code should handle NULL > correctly, not that we should run around changing current users to just do > infinite retries. Checkpatch should have nothing to do with that. My problem wi

Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

2014-03-26 Thread tytso
On Tue, Mar 25, 2014 at 11:32:09PM -0700, Andrew Morton wrote: > Well, there are always alternatives. For example ext3 could > preallocate a single transaction_t and a single IO page and fall back > to synchronous page-at-a-time journal writes. But I can totally see > that such things are unattra

Re: [RFC PATCH 0/5] CPU Jitter RNG

2014-02-04 Thread tytso
On Tue, Feb 04, 2014 at 11:06:04AM -0800, H. Peter Anvin wrote: > > The quantum noise sources there are in a system are generally two > independent clocks running against each other. However, independent > clocks are rare; instead, most clocks are in fact slaved against each > other using PLLs an

Re: Why is SECTOR_SIZE = 512 inside kernel ?

2015-08-18 Thread tytso
On Tue, Aug 18, 2015 at 11:06:47PM +0200, Brice Goglin wrote: > Le 17/08/2015 15:54, Theodore Ts'o a écrit : > > > > It's cast in stone. There are too many places all over the kernel, > > especially in a huge number of file systems, which assume that the > > sector size is 512 bytes. So above th

Re: [PATCH] ext4: Fix check of dqget() return value in ext4_ioctl_setproject()

2016-05-05 Thread tytso
On Thu, May 05, 2016 at 02:52:34PM +0200, Jan Kara wrote: > On Fri 22-04-16 13:36:32, Seth Forshee wrote: > > On Tue, Mar 29, 2016 at 08:01:03AM -0500, Seth Forshee wrote: > > > A failed call to dqget() returns an ERR_PTR() and not null. Fix > > > the check in ext4_ioctl_setproject() to handle this

Re: better patch for linux/bitops.h

2016-05-05 Thread tytso
On Thu, May 05, 2016 at 05:34:50PM -0400, Sandy Harris wrote: > > I completely fail to see why tests or compiler versions should be > part of the discussion. The C standard says the behaviour in > certain cases is undefined, so a standard-compliant compiler > can generate more-or-less any code the

Re: [RFC][PATCH 0/6] /dev/random - a new approach

2016-05-03 Thread tytso
On Tue, May 03, 2016 at 03:57:15PM +0200, Nikos Mavrogiannopoulos wrote: > > I believe their main concern is that they want to protect applications > which do not check error codes of system calls, when running on a > kernel which does not provide getrandom(). That way, they have an > almost impo

Re: [PATCH 1/3] random: replace non-blocking pool with a Chacha20-based CRNG

2016-05-04 Thread tytso
On Tue, May 03, 2016 at 10:50:25AM +0200, Stephan Mueller wrote: > > +/* > > + * crng_init = 0 --> Uninitialized > > + * 2 --> Initialized > > + * 3 --> Initialized from input_pool > > + */ > > +static int crng_init = 0; > > shouldn't that be an atomic_t ? The crng_init variable

Re: [PATCH 1/3] random: replace non-blocking pool with a Chacha20-based CRNG

2016-05-04 Thread tytso
On Wed, May 04, 2016 at 10:40:20AM -0400, Jeffrey Walton wrote: > > +static inline u32 rotl32(u32 v, u8 n) > > +{ > > + return (v << n) | (v >> (sizeof(v) * 8 - n)); > > +} > > That's undefined behavior when n=0. Sure, but it's never called with n = 0; I've double checked and the compiler s

Re: [PATCH 1/3] random: replace non-blocking pool with a Chacha20-based CRNG

2016-05-04 Thread tytso
On Wed, May 04, 2016 at 11:29:57AM -0700, H. Peter Anvin wrote: > > We don't care about UB, we care about gcc, and to a lesser extent > LLVM and ICC. If bitops.h doesn't do the right thing, we need to > fix bitops.h. I'm going to suggest that we treat the ro[rl]{32,64}() question as separable fr

Re: [PATCH v2] CodingStyle: Inclusive Terminology

2020-07-08 Thread tytso
On Wed, Jul 08, 2020 at 12:23:59AM -0700, Dan Williams wrote: > Linux maintains a coding-style and its own idiomatic set of terminology. > Update the style guidelines to recommend replacements for the terms > master/slave and blacklist/whitelist. > > Link: > http://lore.kernel.org/r/159389297140.

Re: strace of io_uring events?

2020-07-15 Thread tytso
On Wed, Jul 15, 2020 at 06:11:30PM +0100, Matthew Wilcox wrote: > On Wed, Jul 15, 2020 at 07:35:50AM -0700, Andy Lutomirski wrote: > > > On Jul 15, 2020, at 4:12 AM, Miklos Szeredi wrote: > > > This thread is to discuss the possibility of stracing requests > > > submitted through io_uring. I'm n