[patch -mm 1/1] remove useless tolower in isofs

Hi, Remove useless tolower in isofs Signed-off-by: dave young <[EMAIL PROTECTED]> inode.c |2 +- 1 file changed, 1 insertions(+), 1 deletions(-) diff -dur linux/fs/isofs/inode.c linux.new/fs/isofs/inode.c --- linux/fs/isofs/inode.c 2007-05-28 08:54:33.0 + +++ linux.new/fs/is

Re: [patch -mm 1/1] remove useless tolower in isofs

Hi, And then there's the supercompact form. while (len--) { hash = partial_name_hash(tolower(*name++), hash); } But I do not like the last one at all. The first one is the best, because it clearly separates the condition and iteration parts of the expression, while STILL being only thre

Re: [patch -mm 1/1] remove useless tolower in isofs

Hi, Thanks, can this small fix be merged? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [NFS] [PATCH] NFSD: fix uninitialized variable

Hi, Given what you said above, I don't see gcc, on its best day, will ever know enough to validate that that variable is indeed always initialized. So I would vote for silencing it on those grounds. I agree too. How about this one: diff -dur linux/fs/nfsd/nfs4acl.c linux.new/fs/nfsd/nfs4acl

Re: [NFS] [PATCH] NFSD: fix uninitialized variable

Hi, matt embarrassed :) below resend it. diff -dur linux/fs/nfsd/nfs4acl.c linux.new/fs/nfsd/nfs4acl.c --- linux/fs/nfsd/nfs4acl.c 2007-05-29 12:28:29.0 + +++ linux.new/fs/nfsd/nfs4acl.c 2007-05-29 16:32:26.0 + @@ -183,8 +183,6 @@ summarize_posix_acl(struct posix_acl *

Re: [patch -mm 1/1] remove useless tolower in isofs

Hi, Thank you, andrew. Your email client replaces tabs with spaces. Really? I use gmail web via firefox, next time I will use mutt to send patches. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majord

Re: [patch -mm 1/1] remove useless tolower in isofs

Hi, Your email client replaces tabs with spaces. The tabs replacing was caused by copying them from vi session in gnome-terminal. I find the proper way is to copy them from some gui editor. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [RFC 1/4] CONFIG_STABLE: Define it

Hi Christoph, Introduce CONFIG_STABLE to control checks only useful for development. What about control checks only as SLUB_DEBUG is set? Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[patch -mm] alsa mixer_oss kfree fix

Hi, Fix possible null pointer kfree. Signed-off-by: dave young <[EMAIL PROTECTED]> mixer_oss.c |120 +- 1 file changed, 74 insertions(+), 46 deletions(-) diff -purN linux/sound/core/oss/mixer_oss.c linux.new/sound/core/oss/mixer_oss.c --- linux/sound/core/oss/mixer_oss.c2007-06-01 09:00:

Re: [patch -mm] alsa mixer_oss kfree fix

Hi, kfree(NULL) is legal, and is often used. Really? I don't know this before. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read t

Re: [patch -mm] alsa mixer_oss kfree fix

Hi, Just append to my email. The reason I read mixer_oss.c is that I see oops in 2.6.22-rc1-mm1, seems oops in mixer_oss.c, but the oops rised only once, I found rc3-mm1 have no change in this file, so I read the source , then post this patch. please find the oops message below: BUG: unable to

[BUG] 2.6.22-rc3-mm1 remove bluetooth usb adapter caused kmalloc bug

Hi, when I remove the usb bluetooth adapter , the kernel reporting bug: /* this two line is printk message I printed in net/bluetooth/hci_core.c */ #before free dev: c3758430 #after free dev = BUG kmalloc-1024: Poison o

Re: [BUG] 2.6.22-rc3-mm1 remove bluetooth usb adapter caused kmalloc bug

Hi, Are you able to reproduce this in 2.6.22-rc4? The kmalloc in dmesg is in skbuff.c:pskb_expand_head, I will try 2.6.22-rc4 ASAP. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.o

Re: [BUG] 2.6.22-rc3-mm1 remove bluetooth usb adapter caused kmalloc bug

Hi, Are you able to reproduce this in 2.6.22-rc4? The bug seems doesn't exist in 2.6.22-rc4, I have tested it, the unpluging can't produce kernel bug message. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mo

Re: [patch -mm] alsa mixer_oss kfree fix

Hi, Andrew kfree(NULL) is legal, and is often used. Apart from the null pointer, IMHO,there's two problem need to be fixed, I'm not sure. What's your opinion? 1. the label indent should be removed 2. similar code use different label, some use " __unlock" but others use "__unalloc", "__unlo

Re: [BUG] 2.6.22-rc3-mm1 remove bluetooth usb adapter caused kmalloc bug

Hi, 2007/6/6, Christoph Lameter <[EMAIL PROTECTED]>: Note that the corruption seems to have its cause in a decrement done at offset 16 into the object pointing to the refcount in struct hci_dev. So it looks like the refcount was decremented after the object was freed. sysfs related? I noticed

Re: 2.6.22-rc1-mm1

Hi, I have the same problem, your patch fixed it. My gcc version is 3.4.6 2007/5/16, H. Peter Anvin <[EMAIL PROTECTED]>: Andy Whitcroft wrote: > Getting this on both x86 and x86_64 boxes, they are the older boxen so > likely older compilers: Please give the gcc version number. > CC arch

Re: 2.6.22-rc1-mm1

Hi, After installation the new mm1 kernel, My system can not boot, the rc1 kernel works ok. The cursor just blinks after appearing "Bios data check successful" message. what do you think about this? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: 2.6.22-rc1-mm1

Hi, I tried the vga option , and the selection menu appeared, then I select 0(80x25) and nothing happened. 2007/5/21, H. Peter Anvin <[EMAIL PROTECTED]>: young dave wrote: > Hi, > My cpu is Intel(R) Pentium(R) D CPU 2.80GHz, below are the lspci > output and kernel Could you ple

Re: 2.6.22-rc1-mm1

Hi, Could you put printf's in the setup code (especially arch/i386/boot/main.c) to see how far it runs before it dies? -hpa I add some debug info to main.c, the result is that the kernel stopped in query_edd(); Then I use kernel argument edd=off, the kernel booted happilly. I will re

Re: 2.6.22-rc1-mm1

Hi, kernel booting and stopped in edd.c:read_sector. I add debug messages around the two inline assemblly sentence, recompile kernel, now strange thing happend, the kernel booting directly, but the printf messages can't be seen because it's too rapid. can we use printk in boot code? the change

Re: 2.6.22-rc1-mm1

Hi, This implies a miscompile somewhere, *or* that your bios stomps on registers that gcc expect preserved, and adding printf's disturbs the register allocation sufficiently. I think maybe it's caused by gcc optimize, so I add volatile to read_sector inline assemblly, then kernel can boot succe

2.6.22-rc1-mm1 cifs_mount oops

Hi, when I use mount -t cifs , the kernel oops, seems break at kthread_stop, I'm not sure. But if I add the CONFIG_CIFS_DEBUG2=y to config file, rebuild kernel, then the oops disappeared. Below is the oops message: BUG: unable to handle kernel NULL pointer dereference at virtual address 000

Re: 2.6.22-rc1-mm1

Hi, I have tried the patch, it works. could you explain it for me? thanks very much. Regards dave 2007/5/22, H. Peter Anvin <[EMAIL PROTECTED]>: Could you try the attached patch for me? -hpa diff --git a/arch/i386/boot/edd.c b/arch/i386/boot/edd.c index 84a0302..9697a56 100644 --- a/a

Re: 2.6.22-rc1-mm1 cifs_mount oops

Hi, maybe we can add if sentence before kthread_stop. diff -ur linux/fs/cifs/connect.c linux.new/fs/cifs/connect.c --- linux/fs/cifs/connect.c 2007-05-23 10:59:13.0 + +++ linux.new/fs/cifs/connect.c 2007-05-23 10:58:39.0 + @@ -2070,7 +2070,8 @@ s

Re: 2.6.22-rc1-mm1 cifs_mount oops

Hi, Yeah, that's racy: once we've sent the signal, the kernel thread can write NULL to srvTcp->tsk at any time. Yes, here is another patch : diff -ur linux/fs/cifs/connect.c linux.new/fs/cifs/connect.c --- linux/fs/cifs/connect.c 2007-05-23 10:59:13.0 + +++ linux.new/fs/cifs/c

Re: 2.6.22-rc1-mm1 cifs_mount oops

Hi, Sorry for the wrong patch in my last post. How about save the tsk then call kthread_stop like this: diff -udr linux/fs/cifs/connect.c linux.new/fs/cifs/connect.c --- linux/fs/cifs/connect.c 2007-05-23 10:59:13.0 + +++ linux.new/fs/cifs/connect.c 2007-05-23 16:33:54.0

Re: 2.6.22-rc1-mm1 cifs_mount oops

Hi, I have one problem about this: after the srvTcp->tsk is set to NULL (maybe the thread is still there, isn't it?), is the kthread still needed to be stopped by calling kthread_stop()? If it is true, then the task_struct should be saved before send_sig like my patch: i

2.6.22-rc2-mm1 SLUB oops

Hi, When I exec aumix from console, the kernel oops seems in modprobe process, and after a while , system hanged. BUG: unable to handle kernel paging request at virtual address 646c6f68 printing eip: c016531e *pde = Oops: [#1] PREEMPT Modules linked in: cifs snd_hda_intel snd_pcm s

Re: 2.6.22-rc2-mm1 SLUB oops

Hi, Reboot with slub_debug as a kernel parameter please. Yes, I will enable slub_debug as boot parameter, but it doesn't occur definitely. I will report the info if it arrive again ASAP. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: 2.6.22-rc2-mm1 NTFS & SLUB related fix

Hi, Is this ntfs_init_locked_inode? Yes, it is. > Bytes b4 0xc2959e28: 00 00 00 00 00 00 00 00 5a 5a 5a 5a 5a 5a 5a >Object 0xc2959e38: 24 00 51 00 00 00 6b a5 > Redzone 0xc2959e40: 00 00 cc cc First two bytes after the object overwritten. The allocation for this object should hav

2.6.22-rc2-mm1 NTFS & SLUB related fix

Hi, As I umount a ntfs partition, the kernel report some trace infomation, I can't call it oops, right? Andrew, could you tell me who is the right person should I send to? I navagated the ntfs inode.c, and found a possible bug, replaced kmalloc with kzalloc, because the ntfschar size is 2. the

Re: 2.6.22-rc2-mm1 NTFS & SLUB related fix

Hi Andrew, So I think this was meant: --- a/fs/ntfs/inode.c~a +++ a/fs/ntfs/inode.c @@ -140,7 +140,7 @@ static int ntfs_init_locked_inode(struct if (!ni->name) return -ENOMEM; memcpy(ni->name, na->name, i); - ni->name[i] = 0

Re: 2.6.22-rc2-mm1 NTFS & SLUB related fix

Yes, I'm sure. but the patch in top post of mine works, the diffrence is using kzalloc and remove the "ni->name[i] = 0;" line. Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger

Re: 2.6.22-rc2-mm1 NTFS & SLUB related fix

Hi, I'm very sorry, andrew, you are right. I directly modified the source and forgot remove the line ni->name[i] = 0; Regards dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Fwd: PROBLEM: 2.6.20-1 not working on ibook g4 (BUG/Oops)

-- Forwarded message -- Hi, I have tested on my mac mini g4. The 2.6.21-rc2 will cause oops like the above post. And for the new 2.6.21-rc3-git7 , the kernel load ok, penguin pixmap appears, but then it stopped, there's no error messages also. Regards dave 2007/3/7, Benjamin

Re: PROBLEM: 2.6.20-1 not working on ibook g4 (BUG/Oops)

2007/3/13, Benjamin Herrenschmidt <[EMAIL PROTECTED]>: On Tue, 2007-03-13 at 01:49 +, young dave wrote: > Hi, > I have tested on my mac mini g4. > > The 2.6.21-rc2 will cause oops like the above post. > > And for the new 2.6.21-rc3-git7 , the kernel load ok, pengu

Re: Lockup after logging out of X

Hi, Seems I have the same problem. Sometimes whole system is locked, sometimes keyboard is still active but others dead. It does not happen till now since I run a silly script on background to log the kernel messages: - #!/bin/sh while true; do sleep 3 dmesg >/tmp/dmesg.txt sync d

linux-2.6.21-rc2 compile warnings

Hi, As I compile the linux-2.6.21-rc2 (gcc version 3.4.6), there's some warning messages: drivers/video/Kconfig:1622:warning: 'select' used by config symbol 'FB_PS3' refer to undefined symbol 'PS3_PS3AV' fs/partitions/check.c: In function `add_partition': fs/partitions/check.c:388: warning: ig

Re: Warning: unable to open an initial console.

Hi, Check if your U-boot enabled the udev, try diable the udev, then using mknod to create the /dev/console. Regards dave 2007/4/2, Tom Strader <[EMAIL PROTECTED]>: I checked /dev/ with U-boot and it shows the existence of /dev/console. From U-boot prompt: $ ls /dev crw---0 Mon

Re: Warning: unable to open an initial console.

Hi; The errno "-6" is defined as: #define ENXIO6 /* No such device or address*/ You can try to retrieve the rootfs and add the necessary device file to it, then reflash the rootfs. I'm Sorry, I have no embedded environment to test. Regards dave 2007/4/3, Tom Strader <[EMAIL