Re: [RFC -next v0 1/3] bpf: modular maps

Alexei Starovoitov writes: > On Fri, Nov 30, 2018 at 08:49:17AM -0500, Aaron Conole wrote: >> >> While this is one reason to use hash map, I don't think we should use >> this as a reason to exclude development of a data type that may work >> better. After all,

[PATCH nf-next] netfilter: ipset: deduplicate prefixlen maps

The prefixlen maps used here are identical, and have been since introduction. It seems to make sense to use a single large map, that the preprocessor will fill appropriately. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/ipset/pfxlen.c

[PATCH nf-next] netfilter: ipset: deduplicate prefixlen maps

The prefixlen maps used here are identical, and have been since introduction. It seems to make sense to use a single large map, that the preprocessor will fill appropriately. Signed-off-by: Aaron Conole --- net/netfilter/ipset/pfxlen.c | 395 +++ 1 file

[PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period

The sync_refresh_period variable is unsigned, so it can never be < 0. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/ipvs/ip_vs_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_syn

[PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period

The sync_refresh_period variable is unsigned, so it can never be < 0. Signed-off-by: Aaron Conole --- net/netfilter/ipvs/ip_vs_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c index b03c280..123d

[PATCH nf-next] nf_conntrack: remove double assignment

The protonet pointer will unconditionally be rewritten, so just do the needed assignment first. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/nf_conntrack_proto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_proto.c

[PATCH nf-next] nf_conntrack: remove double assignment

The protonet pointer will unconditionally be rewritten, so just do the needed assignment first. Signed-off-by: Aaron Conole --- net/netfilter/nf_conntrack_proto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_proto.c b/net/netfilter

[PATCH nf-next] nf_tables: remove double return statement

Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/nf_tables_api.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 2d822d2..1452fb7 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/net

[PATCH nf-next] nf_tables: remove double return statement

Signed-off-by: Aaron Conole --- net/netfilter/nf_tables_api.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 2d822d2..1452fb7 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -4435,8

[PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

There are no in-tree callers. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/ipset/ip_set_core.c | 8 1 file changed, 8 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index c296f9b..68ba531 100644 --- a/net/net

[PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

There are no in-tree callers. Signed-off-by: Aaron Conole --- net/netfilter/ipset/ip_set_core.c | 8 1 file changed, 8 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index c296f9b..68ba531 100644 --- a/net/netfilter/ipset/ip_set_core.c

[PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

There are no in-tree callers of this function and it isn't exported. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/net/ip_vs.h | 2 -- net/netfilter/ipvs/ip_vs_proto.c | 22 -- 2 files changed, 24 deletions(-) diff --git a/include/net/ip_

[PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

There are no in-tree callers of this function and it isn't exported. Signed-off-by: Aaron Conole --- include/net/ip_vs.h | 2 -- net/netfilter/ipvs/ip_vs_proto.c | 22 -- 2 files changed, 24 deletions(-) diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h

Re: [RFC net-next] bpf: taint loading !is_gpl programs

Hi Alexei, and Daniel, Alexei Starovoitov <alexei.starovoi...@gmail.com> writes: > On Wed, Apr 05, 2017 at 10:59:49PM -0400, Aaron Conole wrote: >> Hi Daniel, >> >> Daniel Borkmann <dan...@iogearbox.net> writes: >> >> > On 04/04/2017 08:33

Re: [RFC net-next] bpf: taint loading !is_gpl programs

Hi Alexei, and Daniel, Alexei Starovoitov writes: > On Wed, Apr 05, 2017 at 10:59:49PM -0400, Aaron Conole wrote: >> Hi Daniel, >> >> Daniel Borkmann writes: >> >> > On 04/04/2017 08:33 PM, Aaron Conole wrote: >> >> The eBPF framework i

Re: [RFC net-next] bpf: taint loading !is_gpl programs

Hi Daniel, Daniel Borkmann <dan...@iogearbox.net> writes: > On 04/04/2017 08:33 PM, Aaron Conole wrote: >> The eBPF framework is used for more than just socket level filtering. It >> can also provide tracing, and even change the way packets coming into the >> sys

Re: [RFC net-next] bpf: taint loading !is_gpl programs

Hi Daniel, Daniel Borkmann writes: > On 04/04/2017 08:33 PM, Aaron Conole wrote: >> The eBPF framework is used for more than just socket level filtering. It >> can also provide tracing, and even change the way packets coming into the >> system look. Most of the

[RFC net-next] bpf: taint loading !is_gpl programs

. An exemption is made for socket-level filters, since they do not really impact networking for the whole kernel. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- kernel/bpf/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c

[RFC net-next] bpf: taint loading !is_gpl programs

. An exemption is made for socket-level filters, since they do not really impact networking for the whole kernel. Signed-off-by: Aaron Conole --- kernel/bpf/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index ab0cf4c4..1255b51 100644

Re: [PATCH] virtio-net: Update the mtu code to match virtio spec

Aaron Conole <acon...@redhat.com> writes: >> From: Aaron Conole <acon...@bytheb.org> >> >> The virtio committee recently ratified a change, VIRTIO-152, which >> defines the mtu field to be 'max' MTU, not simply desired MTU. >> >> This commit brings

Re: [PATCH] virtio-net: Update the mtu code to match virtio spec

Aaron Conole writes: >> From: Aaron Conole >> >> The virtio committee recently ratified a change, VIRTIO-152, which >> defines the mtu field to be 'max' MTU, not simply desired MTU. >> >> This commit brings the virtio-net device in compliance with

[PATCH v2 net-next] virtio-net: Update the mtu code to match virtio spec

by virtio_cread16 will never exceed the initial value of max_mtu. Signed-off-by: Aaron Conole <acon...@redhat.com> Acked-by: "Michael S. Tsirkin" <m...@redhat.com> Acked-by: Jarod Wilson <ja...@redhat.com> --- Nothing code-wise has changed, but I've included the ACKs and fixed up

[PATCH v2 net-next] virtio-net: Update the mtu code to match virtio spec

by virtio_cread16 will never exceed the initial value of max_mtu. Signed-off-by: Aaron Conole Acked-by: "Michael S. Tsirkin" Acked-by: Jarod Wilson --- Nothing code-wise has changed, but I've included the ACKs and fixed up the subject line. drivers/net/virtio_net.c | 6 -- 1 file changed, 4

Re: [PATCH] virtio-net: Update the mtu code to match virtio spec

> From: Aaron Conole <acon...@bytheb.org> > > The virtio committee recently ratified a change, VIRTIO-152, which > defines the mtu field to be 'max' MTU, not simply desired MTU. > > This commit brings the virtio-net device in compliance with VIRTIO-152. > > Additio

Re: [PATCH] virtio-net: Update the mtu code to match virtio spec

> From: Aaron Conole > > The virtio committee recently ratified a change, VIRTIO-152, which > defines the mtu field to be 'max' MTU, not simply desired MTU. > > This commit brings the virtio-net device in compliance with VIRTIO-152. > > Additionally, drop the max_mtu bra

[PATCH] virtio-net: Update the mtu code to match virtio spec

From: Aaron Conole <acon...@bytheb.org> The virtio committee recently ratified a change, VIRTIO-152, which defines the mtu field to be 'max' MTU, not simply desired MTU. This commit brings the virtio-net device in compliance with VIRTIO-152. Additionally, drop the max_mtu branch - it

[PATCH] virtio-net: Update the mtu code to match virtio spec

From: Aaron Conole The virtio committee recently ratified a change, VIRTIO-152, which defines the mtu field to be 'max' MTU, not simply desired MTU. This commit brings the virtio-net device in compliance with VIRTIO-152. Additionally, drop the max_mtu branch - it cannot be taken since the u16

Re: [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers

"Michael S. Tsirkin" writes: > On Thu, Oct 20, 2016 at 10:37:20PM -0400, Jarod Wilson wrote: >> On Thu, Oct 20, 2016 at 11:23:54PM +0300, Michael S. Tsirkin wrote: >> > On Thu, Oct 20, 2016 at 01:55:21PM -0400, Jarod Wilson wrote: >> ... >> > > diff --git

Re: [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers

"Michael S. Tsirkin" writes: > On Thu, Oct 20, 2016 at 10:37:20PM -0400, Jarod Wilson wrote: >> On Thu, Oct 20, 2016 at 11:23:54PM +0300, Michael S. Tsirkin wrote: >> > On Thu, Oct 20, 2016 at 01:55:21PM -0400, Jarod Wilson wrote: >> ... >> > > diff --git a/drivers/net/virtio_net.c

Re: [PATCH net-next 5/6] net: use core MTU range checking in virt drivers

Jarod Wilson writes: > hyperv_net: > - set min/max_mtu > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > > vmxnet3: > - set min/max_mtu > > CC: net...@vger.kernel.org > CC: virtualizat...@lists.linux-foundation.org > CC: "K. Y. Srinivasan"

Re: [PATCH net-next 5/6] net: use core MTU range checking in virt drivers

Jarod Wilson writes: > hyperv_net: > - set min/max_mtu > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > > vmxnet3: > - set min/max_mtu > > CC: net...@vger.kernel.org > CC: virtualizat...@lists.linux-foundation.org > CC: "K. Y. Srinivasan" > CC: Haiyang Zhang > CC: "Michael

Re: slab corruption with current -git

Michal Kubecek writes: > On Mon, Oct 10, 2016 at 04:24:01AM -0400, David Miller wrote: >> From: David Miller >> Date: Sun, 09 Oct 2016 23:57:45 -0400 (EDT) >> >> This means that the netns is possibly getting freed up before we >> unregister the netfilter

Re: slab corruption with current -git

Michal Kubecek writes: > On Mon, Oct 10, 2016 at 04:24:01AM -0400, David Miller wrote: >> From: David Miller >> Date: Sun, 09 Oct 2016 23:57:45 -0400 (EDT) >> >> This means that the netns is possibly getting freed up before we >> unregister the netfilter hooks. > > Sounds a bit like the issue

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

by: Linus Torvalds <torva...@linux-foundation.org> > > to the patch, though. > > David, if you want me to just commit that thing directly, I can > obviously do so, but I do think somebody should look at > > (a) that I actually got the priority list ordering right on the

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

ht* that was the > match. > > My list rewrite fixes that. > > Anyway, I'm assuming it will come to me from the networking tree after > more testing by the maintainers. You can add my > > Signed-off-by: Linus Torvalds > > to the patch, though. > > David,

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

Linus Torvalds writes: > On Sun, Oct 9, 2016 at 7:49 PM, Linus Torvalds > wrote: >> >> There is one *correct* way to remove an entry from a singly linked >> list, and it looks like this: >> >> struct entry **pp, *p; >> >> pp

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

Linus Torvalds writes: > On Sun, Oct 9, 2016 at 7:49 PM, Linus Torvalds > wrote: >> >> There is one *correct* way to remove an entry from a singly linked >> list, and it looks like this: >> >> struct entry **pp, *p; >> >> pp = >> while ((p = *pp) != NULL) { >> if

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

Florian Westphal writes: > Linus Torvalds wrote: >> On Sun, Oct 9, 2016 at 12:11 PM, Linus Torvalds >> wrote: >> > >> > Anyway, I don't think I can bisect it, but I'll try to narrow it down >> > a *bit* at least. >>

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

Florian Westphal writes: > Linus Torvalds wrote: >> On Sun, Oct 9, 2016 at 12:11 PM, Linus Torvalds >> wrote: >> > >> > Anyway, I don't think I can bisect it, but I'll try to narrow it down >> > a *bit* at least. >> > >> > Not doing any more pulls on this unstable base, I've been puttering >>

Re: 4.9-rc0: nf_hooks_ingress missing, breaking compilation

Pavel Machek writes: > Hi! Hi Pavel, > In kernel based on edadd0e, I get plenty of errors such as: In this case, I screwed up - sincere apologies. Enabling CONFIG_NETFILTER_INGRESS will work around this error for the time being, while the fix makes it way through the various

Re: 4.9-rc0: nf_hooks_ingress missing, breaking compilation

Pavel Machek writes: > Hi! Hi Pavel, > In kernel based on edadd0e, I get plenty of errors such as: In this case, I screwed up - sincere apologies. Enabling CONFIG_NETFILTER_INGRESS will work around this error for the time being, while the fix makes it way through the various trees. >

Re: [PATCH 2/3] netfilter: hide reference to nf_hooks_ingress

Arnd Bergmann writes: > A recent cleanup added an unconditional reference to the nf_hooks_ingress > pointer, > but that fails when CONFIG_NETFILTER_INGRESS is disabled and that member is > not present in net_device: > > net/netfilter/core.c: In function 'nf_set_hooks_head': >

Re: [PATCH 2/3] netfilter: hide reference to nf_hooks_ingress

Arnd Bergmann writes: > A recent cleanup added an unconditional reference to the nf_hooks_ingress > pointer, > but that fails when CONFIG_NETFILTER_INGRESS is disabled and that member is > not present in net_device: > > net/netfilter/core.c: In function 'nf_set_hooks_head': >

Re: pull-request: wireless-drivers-next 2016-09-29

David Miller writes: > From: Kalle Valo > Date: Thu, 29 Sep 2016 19:57:28 +0300 > ... >> Or actually I had one problem. While doing a test merge I noticed that >> net-next fails to compile for me, but I don't think this is anything >> wireless related:

Re: pull-request: wireless-drivers-next 2016-09-29

David Miller writes: > From: Kalle Valo > Date: Thu, 29 Sep 2016 19:57:28 +0300 > ... >> Or actually I had one problem. While doing a test merge I noticed that >> net-next fails to compile for me, but I don't think this is anything >> wireless related: >> >> CC net/netfilter/core.o >>

[PATCH -next] virtio_net: Update the feature bit to comply with spec

-by: Aaron Conole <acon...@redhat.com> Suggested-by: "Michael S. Tsirkin" <m...@redhat.com> --- include/uapi/linux/virtio_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h index 1ab4ea6..0da0e3

[PATCH -next] virtio_net: Update the feature bit to comply with spec

-by: Aaron Conole Suggested-by: "Michael S. Tsirkin" --- include/uapi/linux/virtio_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h index 1ab4ea6..0da0e3a 100644 --- a/include/uapi/linux/virtio_n

[PATCH v3] virtio-net: Add initial MTU advice feature

-off-by: Aaron Conole <acon...@redhat.com> --- v2->v3: * Added a check for the MTU, and a bit clear for it being out of range. drivers/net/virtio_net.c| 10 ++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/virti

[PATCH v3] virtio-net: Add initial MTU advice feature

-off-by: Aaron Conole --- v2->v3: * Added a check for the MTU, and a bit clear for it being out of range. drivers/net/virtio_net.c| 10 ++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_ne

[PATCH v2 -next] virtio-net: Add initial MTU advice feature

-off-by: Aaron Conole <acon...@redhat.com> --- v1->v2: * Fixed omitted hunk from virtio_net.h * Squashed to a single commit * Fixed commit message. drivers/net/virtio_net.c| 7 +++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/dr

[PATCH v2 -next] virtio-net: Add initial MTU advice feature

-off-by: Aaron Conole --- v1->v2: * Fixed omitted hunk from virtio_net.h * Squashed to a single commit * Fixed commit message. drivers/net/virtio_net.c| 7 +++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/virtio_net.c b/driv

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

kbuild test robot <l...@intel.com> writes: > Hi, > > [auto build test ERROR on next-20160602] > > url: > https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 > config: i386-allmodconfig (attached as .config) > c

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

kbuild test robot writes: > Hi, > > [auto build test ERROR on next-20160602] > > url: > https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 > config: i386-allmodconfig (attached as .config) > compiler: gcc-6 (Debian

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

"Michael S. Tsirkin" <m...@redhat.com> writes: > On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper er

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

"Michael S. Tsirkin" writes: > On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provi

Re: [PATCH -next 1/2] virtio: Start feature MTU support

"Michael S. Tsirkin" <m...@redhat.com> writes: > On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: >> This commit adds the feature bit and associated mtu device entry for the >> virtio network device. Future commits will make use of these bits to >

Re: [PATCH -next 1/2] virtio: Start feature MTU support

"Michael S. Tsirkin" writes: > On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: >> This commit adds the feature bit and associated mtu device entry for the >> virtio network device. Future commits will make use of these bits to >> support negotiated

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

Hi Rick, In the future, please don't cut the list. Rick Jones <rick.jon...@hpe.com> writes: > On 06/02/2016 08:43 AM, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >>

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

Hi Rick, In the future, please don't cut the list. Rick Jones writes: > On 06/02/2016 08:43 AM, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handli

[PATCH -next 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@redhat.com> --- include/uapi/linux/virtio_net.h | 2 ++ 1 file changed, 2 insertions(+)

[PATCH -next 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole --- include/uapi/linux/virtio_net.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include

[PATCH -next 0/2] virtio-net: Advised MTU feature

as described in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg1.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron

[PATCH -next 0/2] virtio-net: Advised MTU feature

as described in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg1.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron

[PATCH -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@redhat.com> --- drivers/net/virtio_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e0638e5..ef5ee01 100644 --- a/drive

[PATCH -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole --- drivers/net/virtio_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e0638e5..ef5ee01 100644 --- a/drivers/net/virtio_net.c +++ b

[RFC v3 -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2: * Whitespace cleanup in the last hunk * Code style change around the pr_warn * Additional test for mtu change before printing warning v3: * removed the mtu change warning d

[RFC v3 -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole --- v2: * Whitespace cleanup in the last hunk * Code style change around the pr_warn * Additional test for mtu change before printing warning v3: * removed the mtu change warning drivers/net/virtio_net.c | 8

[RFC v3 -next 0/2] virtio-net: Advised MTU feature

: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning v3: * Removed the warning when changing MTU (which simplified the code) Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net

[RFC v3 -net 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2,v3: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file c

[RFC v3 -next 0/2] virtio-net: Advised MTU feature

: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning v3: * Removed the warning when changing MTU (which simplified the code) Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net

[RFC v3 -net 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole --- v2,v3: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file changed, 3 insertions

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: > Hello. > > On 3/16/2016 12:04 AM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No prop

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

Sergei Shtylyov writes: > Hello. > > On 3/16/2016 12:04 AM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provid

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

>> >> The second patch adds a user of the bit, and a warning when the guest changes >> the MTU from the hypervisor advised MTU. Future patches may add more thorough >> error handling. >> >> v2: >> * Whitespace and code style cleanups from Sergei Shtylyov and Pa

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

econd patch adds a user of the bit, and a warning when the guest changes >> the MTU from the hypervisor advised MTU. Future patches may add more thorough >> error handling. >> >> v2: >> * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni >>

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

"Michael S. Tsirkin" <m...@redhat.com> writes: > On Tue, Mar 15, 2016 at 05:04:13PM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper er

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

"Michael S. Tsirkin" writes: > On Tue, Mar 15, 2016 at 05:04:13PM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provi

Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

Stephen Hemminger <step...@networkplumber.org> writes: > On Tue, 15 Mar 2016 17:04:12 -0400 > Aaron Conole <acon...@redhat.com> wrote: > >> --- a/include/uapi/linux/virtio_net.h >> +++ b/include/uapi/linux/virtio_net.h >> @@ -55,6 +55,7 @@ >>

Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

Stephen Hemminger writes: > On Tue, 15 Mar 2016 17:04:12 -0400 > Aaron Conole wrote: > >> --- a/include/uapi/linux/virtio_net.h >> +++ b/include/uapi/linux/virtio_net.h >> @@ -55,6 +55,7 @@ >> #define VIRTIO_NET_F_MQ 22

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

Rick Jones <rick.jon...@hpe.com> writes: > On 03/15/2016 02:04 PM, Aaron Conole wrote: >> The following series adds the ability for a hypervisor to set an MTU on the >> guest during feature negotiation phase. This is useful for VM orchestration >> when, for inst

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

Rick Jones writes: > On 03/15/2016 02:04 PM, Aaron Conole wrote: >> The following series adds the ability for a hypervisor to set an MTU on the >> guest during feature negotiation phase. This is useful for VM orchestration >> when, for instance, tunneling is involved and t

[RFC v2 -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2: * Whitespace cleanup in the last hunk * Code style change around the pr_warn * Additional test for mtu change before printing warning drivers/net/virtio_net.c | 12 +

[RFC v2 -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole --- v2: * Whitespace cleanup in the last hunk * Code style change around the pr_warn * Additional test for mtu change before printing warning drivers/net/virtio_net.c | 12 1 file changed, 12

[RFC v2 -next 0/2] virtio-net: Advised MTU feature

: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c| 12 include/uapi/linux/virtio_net.h | 3 +++ 2

[RFC v2 -next 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file chan

[RFC v2 -next 0/2] virtio-net: Advised MTU feature

: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c| 12 include/uapi/linux/virtio_net.h | 3 +++ 2

[RFC v2 -next 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole --- v2: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: > Hello. Hi Sergei, > On 03/10/2016 05:28 PM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >&g

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Sergei Shtylyov writes: > Hello. Hi Sergei, > On 03/10/2016 05:28 PM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Paolo Abeni <pab...@redhat.com> writes: > On Thu, 2016-03-10 at 09:28 -0500, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Paolo Abeni writes: > On Thu, 2016-03-10 at 09:28 -0500, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided for the case where a use

[RFC -next 0/2] virtio-net: Advised MTU feature

as described in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg1.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron

[RFC -next 0/2] virtio-net: Advised MTU feature

as described in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg1.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron

[RFC -next 1/2] virtio: Start the advised MTU feature support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@redhat.com> --- include/uapi/linux/virtio_net.h | 3 +++ 1 file changed, 3 inse

[RFC -next 2/2] virtio_net: Read and use the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@redhat.com> --- drivers/net/virtio_net.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 767ab11..7

[RFC -next 2/2] virtio_net: Read and use the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole --- drivers/net/virtio_net.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 767ab11..7175563 100644 --- a/drivers

[RFC -next 1/2] virtio: Start the advised MTU feature support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole --- include/uapi/linux/virtio_net.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

Arnd Bergmann writes: > On Friday 04 December 2015 16:51:42 Aaron Conole wrote: >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h >> @@ -106,13 +106,14 @@ struct va_format { >> >> /* >> * Dummy printk for disabled debugging statements

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

Arnd Bergmann <a...@arndb.de> writes: > On Friday 04 December 2015 16:51:42 Aaron Conole wrote: >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h >> @@ -106,13 +106,14 @@ struct va_format { >> >> /* >> * Dummy printk for disabled d

[PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

linux/printk.h: use and neaten no_printk") Signed-off-by: Aaron Conole Reported-by: Dmitry Vyukov Cc: Joe Perches Cc: Jason Baron --- v1->v2 - Change no_printk behavior to elide arguments instead of modifying individual pr_* macros, per Jason Baron's suggestion. include/linux/

  1   2   >