This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
ertion but
only generates a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
Acked-by: P
a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
Acked-by: Philippe Ombredanne
---
drivers/net/ethernet/cavium/Kconfig| 1 +
drivers
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki <r...@semihalf.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@ca
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off-by: Aleksey Makarov
Acked-by: Philippe Ombredanne
---
drivers/net/ethernet/cavium/Kconfig
On 12.12.2017 05:32, Richard Cochran wrote:
> On Mon, Dec 11, 2017 at 05:14:31PM +0300, Aleksey Makarov wrote:
>> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h
>> b/drivers/net/ethernet/cavium/thunder/nic.h
>> index 4a02e618e318..204b234beb9d 100644
>> --- a/
On 12.12.2017 05:32, Richard Cochran wrote:
> On Mon, Dec 11, 2017 at 05:14:31PM +0300, Aleksey Makarov wrote:
>> diff --git a/drivers/net/ethernet/cavium/thunder/nic.h
>> b/drivers/net/ethernet/cavium/thunder/nic.h
>> index 4a02e618e318..204b234beb9d 100644
>> --- a/
Hi Richard,
On 12/12/2017 01:59 AM, Richard Cochran wrote:
Sorry I didn't finish reviewing before...
On Mon, Dec 11, 2017 at 05:14:30PM +0300, Aleksey Makarov wrote:
[ ... ]
+static int cavium_ptp_probe(struct pci_dev *pdev,
+ const struct pci_device_id *ent
Hi Richard,
On 12/12/2017 01:59 AM, Richard Cochran wrote:
Sorry I didn't finish reviewing before...
On Mon, Dec 11, 2017 at 05:14:30PM +0300, Aleksey Makarov wrote:
[ ... ]
+static int cavium_ptp_probe(struct pci_dev *pdev,
+ const struct pci_device_id *ent
ertion but
only generates a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/n
a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig| 1 +
drivers/net/ethernet/cavium/thunder/nic.h
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki <r...@semihalf.com>
Signed-off-by: Aleksey Makarov <aleksey.mak
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig | 12 +
drivers/net
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
ertion but
only generates a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/n
a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig| 1 +
drivers/net/ethernet/cavium/thunder/nic.h
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki <r...@semihalf.com>
Signed-off-by: Aleksey Makarov <aleksey.mak
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig | 12 +
drivers/net
ertion but
only generates a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/n
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki <r...@semihalf.com>
Signed-off-by: Aleksey Makarov <aleksey.mak
a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig| 1 +
drivers/net/ethernet/cavium/thunder/nic.h
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig | 13 +
drivers/net
cjacob <cja...@caviumnetworks.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c
b/drivers/net/ethernet/cavium/th
From: Sunil Goutham
on T81 there are only 4 cores, hence setting max queue count to 4
would leave nothing for XDP_TX. This patch fixes this by doubling
max queue count in above scenarios.
Signed-off-by: Sunil Goutham
Signed-off-by: cjacob
Signed-off-by: Aleksey Makarov
---
drivers/net
From: Sunil Goutham <sgout...@cavium.com>
This patch adds support for XDP_REDIRECT. Flush is not
yet supported.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: cjacob <cja...@caviumnetworks.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.
From: Sunil Goutham
This patch adds support for XDP_REDIRECT. Flush is not
yet supported.
Signed-off-by: Sunil Goutham
Signed-off-by: cjacob
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 110 -
drivers/net/ethernet/cavium/thunder
s IPv4 when IP csum offload is set
in the SQ descriptor.
Fixes: 3a9024f52c2e ("net: thunderx: Enable TSO and checksum offloads for
ipv6")
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@auriga.com>
Reviewed-by: Eric
is set
in the SQ descriptor.
Fixes: 3a9024f52c2e ("net: thunderx: Enable TSO and checksum offloads for
ipv6")
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
Reviewed-by: Eric Dumazet
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 -
1 file changed, 1 delet
s IPv4 when IP csum offload is set
in the SQ descriptor.
Fixes: 3a9024f52c2e ("net: thunderx: Enable TSO and checksum offloads for
ipv6")
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@auriga.com>
---
drivers
is set
in the SQ descriptor.
Fixes: 3a9024f52c2e ("net: thunderx: Enable TSO and checksum offloads for
ipv6")
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 -
1 file changed, 1 deletion(-)
v3:
- fix the
s IPv4 when IP csum offload is set
in the SQ descriptor.
Fixes: 494fd005 ("net: thunderx: Enable TSO and checksum offloads for ipv6")
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@auriga.com>
---
drivers/net/ethernet/c
is set
in the SQ descriptor.
Fixes: 494fd005 ("net: thunderx: Enable TSO and checksum offloads for ipv6")
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 -
1 file changed, 1 deletion(-)
v2:
- Don't enabl
Fixes: 494fd005 ("net: thunderx: Enable TSO and checksum offloads for ipv6")
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@auriga.com>
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 ++-
1 file changed, 2 insertions(+
nderx: Enable TSO and checksum offloads for ipv6")
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c
b/d
ertion but
only generates a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/n
a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig| 1 +
drivers/net/ethernet/cavium/thunder/nic.h
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki <r...@semihalf.com>
Signed-off-by: Aleksey Makarov <aleksey.mak
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig | 13 +
drivers/net
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
ing <colin.k...@canonical.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/net/ethernet/cavium/thunder/nic_main.c | 82 ++
1 file changed, 30 insertions(+), 52 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c
b/dri
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/thunder/nic_main.c | 82 ++
1 file changed, 30 insertions(+), 52 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c
b/drivers/net/ethernet/cavium/thunder/nic_main.c
index c12ab7f1adb9..
On 11/07/2017 10:49 PM, David Daney wrote:
On 11/07/2017 11:07 AM, Aleksey Makarov wrote:
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Ra
On 11/07/2017 10:49 PM, David Daney wrote:
On 11/07/2017 11:07 AM, Aleksey Makarov wrote:
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off
ertion but
only generates a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham <sgout...@cavium.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@cavium.com>
---
drivers/n
a separate CQE with transmitted packet's timestamp.
Also HW supports only one packet at a time for timestamping on the
transmit side.
Signed-off-by: Sunil Goutham
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig| 1 +
drivers/net/ethernet/cavium/thunder/nic.h
From: Radoslaw Biernacki <r...@semihalf.com>
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki <r...@semihalf.com>
Signed-off-by: Aleksey Makarov <aleksey.mak
From: Radoslaw Biernacki
This patch adds support for the Precision Time Protocol
Clocks and Timestamping hardware found on Cavium ThunderX
processors.
Signed-off-by: Radoslaw Biernacki
Signed-off-by: Aleksey Makarov
---
drivers/net/ethernet/cavium/Kconfig | 13 +
drivers/net
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
This series adds support for IEEE 1588 Precision Time Protocol
to Cavium ethernet driver.
The first patch adds support for the Precision Time Protocol Clocks and
Timestamping coprocessor (PTP) found on Cavium processors.
It registers a new PTP clock in the PTP core and provides functions
to use
On 05/18/2017 06:49 PM, Petr Mladek wrote:
On Sun 2017-05-14 23:37:50, Aleksey Makarov wrote:
On 05/12/2017 03:57 PM, Petr Mladek wrote:
On Thu 2017-05-11 17:41:58, Sergey Senozhatsky wrote:
On (05/11/17 17:24), Sergey Senozhatsky wrote:
On (05/09/17 10:29), Sabrina Dubroca wrote
On 05/18/2017 06:49 PM, Petr Mladek wrote:
On Sun 2017-05-14 23:37:50, Aleksey Makarov wrote:
On 05/12/2017 03:57 PM, Petr Mladek wrote:
On Thu 2017-05-11 17:41:58, Sergey Senozhatsky wrote:
On (05/11/17 17:24), Sergey Senozhatsky wrote:
On (05/09/17 10:29), Sabrina Dubroca wrote
mentioned 'console=' (preferred console) is the console that
should become /dev/console. Its driver is returned by console_device().
In other respects the last mentioned console is not special,
so I believe it is irrelevant to the report.
Thank you
Aleksey Makarov
mentioned 'console=' (preferred console) is the console that
should become /dev/console. Its driver is returned by console_device().
In other respects the last mentioned console is not special,
so I believe it is irrelevant to the report.
Thank you
Aleksey Makarov
d line twice (with different lines), which is pointless
so I would say it is irrelevant.
Thank you
Aleksey Makarov
d line twice (with different lines), which is pointless
so I would say it is irrelevant.
Thank you
Aleksey Makarov
ole is non-braille and it is preferred.
What is the problem?
Thank you
Aleksey Makarov
ole is non-braille and it is preferred.
What is the problem?
Thank you
Aleksey Makarov
will be able to look at this on the weekend.
Thank you
Aleksey Makarov
will be able to look at this on the weekend.
Thank you
Aleksey Makarov
On 04/11/2017 10:43 AM, Petr Mladek wrote:
On Mon 2017-04-10 21:00:35, Aleksey Makarov wrote:
On 04/10/2017 05:22 PM, Petr Mladek wrote:
On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote:
[..]
Thank you for review. Can you (or anybody else) ACK it?
I am going to resend the whole
On 04/11/2017 10:43 AM, Petr Mladek wrote:
On Mon 2017-04-10 21:00:35, Aleksey Makarov wrote:
On 04/10/2017 05:22 PM, Petr Mladek wrote:
On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote:
[..]
Thank you for review. Can you (or anybody else) ACK it?
I am going to resend the whole
On 04/10/2017 05:22 PM, Petr Mladek wrote:
On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote:
If a console was specified by ACPI SPCR table _and_ command line
parameters like "console=ttyAMA0" _and_ "earlycon" were specified,
then log messages appear twice.
The root ca
On 04/10/2017 05:22 PM, Petr Mladek wrote:
On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote:
If a console was specified by ACPI SPCR table _and_ command line
parameters like "console=ttyAMA0" _and_ "earlycon" were specified,
then log messages appear twice.
The root ca
On 04/06/2017 12:57 AM, Andy Shevchenko wrote:
On Wed, Apr 5, 2017 at 11:20 PM, Aleksey Makarov
<aleksey.maka...@linaro.org> wrote:
If a console was specified by ACPI SPCR table _and_ command line
parameters like "console=ttyAMA0" _and_ "earlycon" were specified
On 04/06/2017 12:57 AM, Andy Shevchenko wrote:
On Wed, Apr 5, 2017 at 11:20 PM, Aleksey Makarov
wrote:
If a console was specified by ACPI SPCR table _and_ command line
parameters like "console=ttyAMA0" _and_ "earlycon" were specified,
then log messages appear tw
hing entry.
Introduce variable console_cmdline_cnt that keeps the number
of elements of the console_cmdline array (Petr Mladek). It helps
to get rid of the loop that searches for the end of this array.
Reported-by: Sudeep Holla <sudeep.ho...@arm.com>
Signed-off-by: Aleksey Makarov <al
hing entry.
Introduce variable console_cmdline_cnt that keeps the number
of elements of the console_cmdline array (Petr Mladek). It helps
to get rid of the loop that searches for the end of this array.
Reported-by: Sudeep Holla
Signed-off-by: Aleksey Makarov
---
v8 -> v9:
- Introduce variab
with it. It was great
work. But the current solution of the cycle looks weird to me.
Sorry for the delay. I will send next version soon.
Thank you
Aleksey Makarov
with it. It was great
work. But the current solution of the cycle looks weird to me.
Sorry for the delay. I will send next version soon.
Thank you
Aleksey Makarov
On 03/27/2017 05:14 PM, Petr Mladek wrote:
On Mon 2017-03-20 13:03:00, Aleksey Makarov wrote:
[..]
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index fd752f0c8ef1..462036e7a767 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1909,8 +1909,28 @@ static
On 03/27/2017 05:14 PM, Petr Mladek wrote:
On Mon 2017-03-20 13:03:00, Aleksey Makarov wrote:
[..]
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index fd752f0c8ef1..462036e7a767 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1909,8 +1909,28 @@ static
irst matching entry.
Reported-by: Sudeep Holla <sudeep.ho...@arm.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@linaro.org>
---
v7 -> v8:
- add an explanation to the comment how console_cmdline can contain entries
referring to the same console
- move the body of the function introd
irst matching entry.
Reported-by: Sudeep Holla
Signed-off-by: Aleksey Makarov
---
v7 -> v8:
- add an explanation to the comment how console_cmdline can contain entries
referring to the same console
- move the body of the function introduced in the previous version to cycle
- don't panic() (
ored.
Did you test the code on real braille hardware?
I am asking because there could also be other problems with the code
that have not been run for 3 years since it was changed.
Thank you
Aleksey Makarov
Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>
Cc: Aleksey Makarov <a
ored.
Did you test the code on real braille hardware?
I am asking because there could also be other problems with the code
that have not been run for 3 years since it was changed.
Thank you
Aleksey Makarov
Signed-off-by: Samuel Thibault
Cc: Aleksey Makarov
Cc: Joe Perches
Cc: Ming Lei
Cc: Stev
irst matching entry.
Reported-by: Sudeep Holla <sudeep.ho...@arm.com>
Signed-off-by: Aleksey Makarov <aleksey.maka...@linaro.org>
---
v6 -> v7:
- return back to v5 :)
- leave the check for already registered entries and add a function that
maintains the invariant.
v5 -> v6:
-
irst matching entry.
Reported-by: Sudeep Holla
Signed-off-by: Aleksey Makarov
---
v6 -> v7:
- return back to v5 :)
- leave the check for already registered entries and add a function that
maintains the invariant.
v5 -> v6:
- drop v5 and continue to work on v4:
- introduce _braille_is_braille_c
On 03/17/2017 02:43 PM, Aleksey Makarov wrote:
[..]
> @@ -2457,40 +2491,50 @@ void register_console(struct console *newcon)
> }
>
> /*
> - * See if this console matches one we selected on
> - * the command line.
> + * See if this c
On 03/17/2017 02:43 PM, Aleksey Makarov wrote:
[..]
> @@ -2457,40 +2491,50 @@ void register_console(struct console *newcon)
> }
>
> /*
> - * See if this console matches one we selected on
> - * the command line.
> + * See if this c
introduce predicate _braille_is_braille_console() that checks if
its argument is an entry describing a braille console.
Also introduce a macro for_each_console_cmdline() to traverse
the console_cmdline array.
Reported-by: Sudeep Holla <sudeep.ho...@arm.com>
Signed-off-by: Aleksey Makarov <alekse
introduce predicate _braille_is_braille_console() that checks if
its argument is an entry describing a braille console.
Also introduce a macro for_each_console_cmdline() to traverse
the console_cmdline array.
Reported-by: Sudeep Holla
Signed-off-by: Aleksey Makarov
---
v5 -> v6:
- drop v5 and
On 03/17/2017 03:53 AM, Samuel Thibault wrote:
> Hello,
>
> Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote:
>> There can be 3 outcomes from this function:
>> 1) it returns NULL and does not set brl_options
>> 2) it returns NULL and set the variable
On 03/17/2017 03:53 AM, Samuel Thibault wrote:
> Hello,
>
> Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote:
>> There can be 3 outcomes from this function:
>> 1) it returns NULL and does not set brl_options
>> 2) it returns NULL and set the variable
On 03/16/2017 04:54 PM, Petr Mladek wrote:
> On Thu 2017-03-16 13:36:35, Aleksey Makarov wrote:
>>
>>
>> On 03/15/2017 07:58 PM, Petr Mladek wrote:
>>> On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote:
[..]
> I personally prefer v4. The braille console adds an
On 03/16/2017 04:54 PM, Petr Mladek wrote:
> On Thu 2017-03-16 13:36:35, Aleksey Makarov wrote:
>>
>>
>> On 03/15/2017 07:58 PM, Petr Mladek wrote:
>>> On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote:
[..]
> I personally prefer v4. The braille console adds an
Hi,
I am looking at the braille console code and don't understand how its
initialization works.
This is from kernel/printk/braille.c:
char *_braille_console_setup(char **str, char **brl_options)
{
if (!strncmp(*str, "brl,", 4)) {
*brl_options = "";
*str
Hi,
I am looking at the braille console code and don't understand how its
initialization works.
This is from kernel/printk/braille.c:
char *_braille_console_setup(char **str, char **brl_options)
{
if (!strncmp(*str, "brl,", 4)) {
*brl_options = "";
*str
On 03/15/2017 07:58 PM, Petr Mladek wrote:
> On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote:
>> If a console was specified by ACPI SPCR table _and_ command line
>> parameters like "console=ttyAMA0" _and_ "earlycon" were specified,
>> then log me
On 03/15/2017 07:58 PM, Petr Mladek wrote:
> On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote:
>> If a console was specified by ACPI SPCR table _and_ command line
>> parameters like "console=ttyAMA0" _and_ "earlycon" were specified,
>> then log me
On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> Hi Greg,
>
> On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote:
>>
>>
>> On 01/03/17 15:23, Aleksey Makarov wrote:
>>> The original patch makes the condition always true, so it
On 03/16/2017 10:11 AM, Jayachandran C. wrote:
> Hi Greg,
>
> On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote:
>>
>>
>> On 01/03/17 15:23, Aleksey Makarov wrote:
>>> The original patch makes the condition always true, so it is wrong.
>>>
&
. More consoles
are selected (enabled) and only one is preferred (first)."
Acked-by: Steven Rostedt (VMware) <rost...@goodmis.org>
Acked-by: Petr Mladek <pmla...@suse.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhat...@gmail.com>
Suggested-by: Peter Hurley <pe...@hurleysof
. More consoles
are selected (enabled) and only one is preferred (first)."
Acked-by: Steven Rostedt (VMware)
Acked-by: Petr Mladek
Reviewed-by: Sergey Senozhatsky
Suggested-by: Peter Hurley
Signed-off-by: Aleksey Makarov
---
kernel/printk/printk.c | 10 +-
1 file changed, 5 insert
1 - 100 of 780 matches
Mail list logo
