On Tue, Mar 16, 2021 at 12:21 AM Nicolas Dufresne wrote:
>
> Le lundi 15 mars 2021 à 20:28 +0900, Alexandre Courbot a écrit :
> > Hi Ezequiel,
> >
> > On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia
> > wrote:
> > >
> > > Hi Alex,
> > >
&g
On Tue, Mar 16, 2021 at 7:08 AM Ezequiel Garcia
wrote:
>
> Hi Alex,
>
> On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot wrote:
> >
> > Hi Ezequiel,
> >
> > On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia
> > wrote:
> > >
> > > Hi Al
On Tue, Mar 16, 2021 at 6:45 AM Ezequiel Garcia
wrote:
>
> Hi Alexandre,
>
> On Mon, 15 Mar 2021 at 08:28, Alexandre Courbot wrote:
> >
> > Hi Ezequiel, thanks for the feedback!
> >
> > On Thu, Mar 4, 2021 at 6:30 AM Ezequiel Garcia
> > wrote:
Hi Ezequiel,
On Thu, Mar 4, 2021 at 6:47 AM Ezequiel Garcia
wrote:
>
> Hi Alex,
>
> Thanks for the patch.
>
> On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot wrote:
> >
> > From: Yunfei Dong
> >
> > Add support for H.264 decoding using the
Hi Ezequiel, thanks for the feedback!
On Thu, Mar 4, 2021 at 6:30 AM Ezequiel Garcia
wrote:
>
> Hello Alex,
>
> Thanks for the patch.
>
> On Fri, 26 Feb 2021 at 07:06, Alexandre Courbot wrote:
> >
> > From: Yunfei Dong
> >
> > Support the state
On Thu, Mar 4, 2021 at 5:27 AM Ezequiel Garcia wrote:
>
> It doesn't seem to add any clarity to have a "header" suffix in controls,
> struct names and flags.
>
> Since this just makes names too long without any benefit, just drop it.
>
> Signed-off-by: Ezequiel Garcia
> ---
>
Hi Nicolas,
On Wed, Mar 3, 2021 at 2:38 AM Nicolas Dufresne wrote:
>
> Le jeudi 25 février 2021 à 19:16 +0900, Alexandre Courbot a écrit :
> > Add Mediatek's non-compressed 8 bit block video mode. This format is
> > produced by the MT8183 codec and can be converted to
On Tue, Mar 2, 2021 at 3:43 AM Nicolas Dufresne
wrote:
>
> Le dimanche 28 février 2021 à 15:13 +0900, Alexandre Courbot a écrit :
> > Hi Nicolas,
> >
> > On Thu, Feb 25, 2021 at 6:08 AM Nicolas Dufresne
> > wrote:
> > >
> > > Le jeudi 10 septemb
Hi Nicolas,
On Thu, Feb 25, 2021 at 6:08 AM Nicolas Dufresne
wrote:
>
> Le jeudi 10 septembre 2020 à 15:04 +0900, Alexandre Courbot a écrit :
> > Hi Ezequiel, sorry for the late review!
> >
> > On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia
> > wrote:
>
log a bit]
Signed-off-by: Alexandre Courbot
---
.../media/platform/mtk-vcodec/mtk_vcodec_enc.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c
index
The V4L2 encoder specification requires encoders to support the
V4L2_ENC_CMD_START and V4L2_ENC_CMD_STOP commands. Add support for these
to the mtk-vcodec encoder by reusing the same flush buffer as used by
the decoder driver.
Signed-off-by: Alexandre Courbot
---
.../platform/mtk-vcodec
safeguards to check against it.
Signed-off-by: Alexandre Courbot
---
.../media/platform/mtk-vcodec/mtk_vcodec_dec.c| 9 ++---
.../media/platform/mtk-vcodec/mtk_vcodec_dec.h| 2 --
.../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 12 +---
.../platform/mtk-vcodec
Let's use the dedicated helpers to make sure we get the expected
behavior on stateful decoders as well.
Signed-off-by: Alexandre Courbot
---
.../media/platform/mtk-vcodec/mtk_vcodec_dec.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/media
.
In the case of the stateless decoder, the problem was even bigger since
subsequently calling G_FMT on the CAPTURE queue would result in the
unclamped resolution being returned, further inducing the client into
error.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
From: Hirokazu Honda
Add H264 profiles supported by the MediaTek 8173 decoder.
Signed-off-by: Hirokazu Honda
[acourbot: fix commit log a bit]
Signed-off-by: Alexandre Courbot
---
.../platform/mtk-vcodec/mtk_vcodec_dec_stateful.c | 11 ++-
1 file changed, 10 insertions(+), 1
MT8183's decoder is instantiated similarly to MT8173's.
Signed-off-by: Alexandre Courbot
---
Documentation/devicetree/bindings/media/mediatek-vcodec.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt
b/Documentation/devicetree
From: Yunfei Dong
The stateless API requires a media device for issuing requests. Add one
if we are being instantiated as a stateless decoder.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off-by: Alexandre Courbot
---
drivers
From: Yunfei Dong
Now that all the supporting blocks are present, enable decoder for
MT8183.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 5
From: Yunfei Dong
Add support for H.264 decoding using the stateless API, as supported by
MT8183. This support takes advantage of the V4L2 H.264 reference list
builders.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off
From: Yunfei Dong
Support the stateless codec API that will be used by MT8183.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/Makefile| 1 +
.../platform/mtk
it on
this chip. There should only be one firmware version available for it
anyway.
Signed-off-by: Alexandre Courbot
---
.../mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 +
.../platform/mtk-vcodec/mtk_vcodec_drv.h | 4
.../media/platform/mtk-vcodec/vdec_ipi_msg.h | 5 +
.../media
Add Mediatek's non-compressed 8 bit block video mode. This format is
produced by the MT8183 codec and can be converted to a non-proprietary
format by the MDP3 component.
Signed-off-by: Alexandre Courbot
---
Documentation/userspace-api/media/v4l/pixfmt-reserved.rst | 7 +++
drivers/media
Add support for decoder firmware version 2, which makes the kernel
responsible for managing the VSI context and is used for stateless
codecs.
Signed-off-by: Alexandre Courbot
---
.../media/platform/mtk-vcodec/vdec_ipi_msg.h | 18 +---
.../media/platform/mtk-vcodec/vdec_vpu_if.c | 28
tually compiles (duh),
* Add follow-up patches fixing support for START/STOP commands for the
encoder, and stateful decoder.
Alexandre Courbot (8):
media: mtk-vcodec: vdec: handle firmware version field
media: mtk-vcodec: support version 2 of decoder firmware ABI
media: add Mediatek's MM21 forma
through ops that the common driver parts can call.
This patch only moves code around and introduces a set of abstractions ;
the behavior of the driver should not be changed in any way.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off
vidioc_try_fmt() does clamp height and width when called on the OUTPUT
queue, so clamping them prior to calling this function is redundant. Set
the queue's parameters after calling vidioc_try_fmt() so we can use the
values it computed.
Signed-off-by: Alexandre Courbot
---
.../media/platform/mtk
Add support for decoder firmware version 2, which makes the kernel
responsible for managing the VSI context and is used for stateless
codecs.
Signed-off-by: Alexandre Courbot
---
.../media/platform/mtk-vcodec/vdec_ipi_msg.h | 18 +---
.../media/platform/mtk-vcodec/vdec_vpu_if.c | 28
MT8183's decoder is instantiated similarly to MT8173's.
Signed-off-by: Alexandre Courbot
---
Documentation/devicetree/bindings/media/mediatek-vcodec.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt
b/Documentation/devicetree
From: Yunfei Dong
The stateless API requires a media device for issuing requests. Add one
if we are being instantiated as a stateless decoder.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off-by: Alexandre Courbot
---
drivers
From: Yunfei Dong
Now that all the supporting blocks are present, enable decoder for
MT8183.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 5
From: Yunfei Dong
Add support for H.264 decoding using the stateless API, as supported by
MT8183. This support takes advantage of the V4L2 H.264 reference list
builders.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off
From: Yunfei Dong
Support the stateless codec API that will be used by MT8183.
Signed-off-by: Yunfei Dong
[acourbot: refactor, cleanup and split]
Co-developed-by: Alexandre Courbot
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/Makefile| 1 +
.../platform/mtk
Add Mediatek's non-compressed 8 bit block video mode. This format is
produced by the MT8183 codec and can be converted to a non-proprietary
format by the MDP3 component.
Signed-off-by: Alexandre Courbot
---
Documentation/userspace-api/media/v4l/pixfmt-reserved.rst | 7 +++
drivers/media
it on
this chip. There should only be one firmware version available for it
anyway.
Signed-off-by: Alexandre Courbot
---
.../mtk-vcodec/mtk_vcodec_dec_stateful.c | 1 +
.../platform/mtk-vcodec/mtk_vcodec_drv.h | 4
.../media/platform/mtk-vcodec/vdec_ipi_msg.h | 5 +
.../media
and not the driver.
Alexandre Courbot (4):
media: mtk-vcodec: vdec: handle firmware version field
media: mtk-vcodec: support version 2 of decoder firmware ABI
media: add Mediatek's MM21 format
dt-bindings: media: document mediatek,mt8183-vcodec-dec
Yunfei Dong (4):
media: mtk-vcodec: vdec
On Sat, Feb 20, 2021 at 3:56 PM Irui Wang wrote:
>
> On Wed, 2021-02-03 at 19:44 +0900, Alexandre Courbot wrote:
> > Hi Irui,
> >
> > Thanks for pushing this forward. I had two small conflicts when
> > applying this patch to the media tree, so you may want to reba
On Wed, Feb 17, 2021 at 1:20 AM Diego Viola wrote:
>
> This code times out on GP108, probably because the BIOS puts it into a
> bad state.
>
> Since we reset the PMU on driver load anyway, we are at no risk from
> missing a response from it since we are not waiting for one to begin
> with.
This
Hi Irui,
Thanks for pushing this forward. I had two small conflicts when
applying this patch to the media tree, so you may want to rebase
before sending the next version. Please see the comments inline.
On Thu, Jan 21, 2021 at 3:18 PM Irui Wang wrote:
>
> MTK H264 Encoder(VENC_SYS) and VP8
On Thu, Jan 21, 2021 at 3:18 PM Irui Wang wrote:
>
> Updates binding document since the avc and vp8 hardware encoder in
> MT8173 are now separated. Separate "mediatek,mt8173-vcodec-enc" to
> "mediatek,mt8173-vcodec-vp8-enc" and "mediatek,mt8173-vcodec-avc-enc".
>
> Signed-off-by: Hsin-Yi Wang
>
have little to none practical consequences beyond making the
driver not rely on a particular behavior of the SG implementation.
Reported-by: Tomasz Figa
Signed-off-by: Alexandre Courbot
---
Hi everyone,
It probably doesn't hurt to fix this issue before some actual issue happens.
I have tested
On Fri, Dec 4, 2020 at 8:15 AM Arnd Bergmann wrote:
>
> From: Arnd Bergmann
>
> The SCP firmware can only be built if CONFIG_REMOTEPROC is
> enabled:
>
> WARNING: unmet direct dependencies detected for MTK_SCP
> Depends on [n]: REMOTEPROC [=n] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
>
On Wed, Dec 2, 2020 at 2:34 PM Alexandre Courbot wrote:
>
> DRC events can happen virtually at anytime, including when we are
> starting a seek. Should this happen, we must make sure to return to the
> DRC state, otherwise the firmware will expect buffers of the new
> resolution wh
On Wed, Dec 2, 2020 at 7:34 AM Stanimir Varbanov
wrote:
>
> Hi Fritz,
>
> On 12/1/20 6:23 AM, Fritz Koenig wrote:
> > If the DRC is near the end of the stream the client
> > may send a V4L2_DEC_CMD_STOP before the DRC occurs.
> > V4L2_DEC_CMD_STOP puts the driver into the
> >
resume for seeking makes sure that the
client will get the DRC event and will reallocate the buffers to fit the
firmware's expectations.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/qcom/venus/vdec.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git
On Tue, Dec 1, 2020 at 1:07 PM Fritz Koenig wrote:
>
> On Mon, Nov 30, 2020 at 7:24 PM Alexandre Courbot
> wrote:
> >
> > On Sun, Nov 29, 2020 at 3:05 PM Fritz Koenig wrote:
> > >
> > > V4L2_ENC_CMD_STOP and V4L2_ENC_CMD_START are already
> >
On Sun, Nov 29, 2020 at 3:05 PM Fritz Koenig wrote:
>
> V4L2_ENC_CMD_STOP and V4L2_ENC_CMD_START are already
> supported. Add a way to query for support.
I think your Signed-off-by is missing (checkpatch.pl should warn you
about such problems).
>
> ---
>
On Fri, Nov 27, 2020 at 7:42 AM Stanimir Varbanov
wrote:
>
>
>
> On 11/26/20 8:28 AM, Alexandre Courbot wrote:
> > On Wed, Nov 25, 2020 at 10:01 PM Stanimir Varbanov
> > wrote:
> >>
> >>
> >>
> >> On 11/25/20 5:46 AM, Alexandre C
On Wed, Nov 25, 2020 at 10:01 PM Stanimir Varbanov
wrote:
>
>
>
> On 11/25/20 5:46 AM, Alexandre Courbot wrote:
> > On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov
> > wrote:
> >>
> >> Currently we rely on firmware to return error when we reach the
On Tue, Nov 24, 2020 at 5:39 PM Sakari Ailus
wrote:
>
> On Tue, Nov 24, 2020 at 08:56:00AM +0900, Alexandre Courbot wrote:
> > Gentle ping about this - we are already well into the 5.10 cycle so we
> > don't have much time left if we want to merge this build breakage
>
On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov
wrote:
>
> From: Vikash Garodia
>
> For synchronous commands, update the message queue variable.
> This would inform video firmware to raise interrupt on host
> CPU whenever there is a response for such commands.
>
> Signed-off-by: Vikash Garodia
On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov
wrote:
>
> Currently we rely on firmware to return error when we reach the maximum
> supported number of sessions. But this errors are happened at reqbuf
> time which is a bit later. The more reasonable way looks like is to
> return the error on
Hi Stan,
On Fri, Nov 20, 2020 at 9:12 AM Stanimir Varbanov
wrote:
>
> Init the hfi session only once in queue_setup and also cover that
> with inst->lock.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/venus/venc.c | 98 ++--
> 1 file changed, 73
On Thu, Oct 29, 2020 at 10:17 AM Irui Wang wrote:
>
> when IPI time out, dump VPU status to get more debug information
>
> Signed-off-by: Irui Wang
Reviewed-by: Alexandre Courbot
On Thu, Oct 29, 2020 at 10:17 AM Irui Wang wrote:
>
> VPU should be in idle state before system is suspended
> or it will work abnormally like VPU program counter not
> in a correct address or VPU reset
>
> Signed-off-by: Irui Wang
FWIW,
Reviewed-by: Alexandre Courbot
Gentle ping about this - we are already well into the 5.10 cycle so we
don't have much time left if we want to merge this build breakage
fix...
On Tue, Oct 13, 2020 at 9:44 PM Alexandre Courbot wrote:
>
> No functional changes since v3, but it does the job at fixing the build
>
On Tue, Nov 3, 2020 at 6:48 PM Hans Verkuil wrote:
> There is one other place where this needs to be tested: testEvents() in
> v4l2-test-controls.cpp: currently this only tests select(), but there
> should be a second epoll test here as well that just tests EPOLLPRI.
>
> This would catch drivers
() unconditional, thus
making sure it will also be invoked during the first call.
The issue has been discussed in more detail on
https://www.spinics.net/lists/linux-media/msg179618.html.
Alexandre Courbot (2):
media: videobuf2: always call poll_wait() on queues
media: v4l2-mem2mem: always call
is requested, which may not necessarily be the case
during the first poll.
Fix this by making the call to poll_wait() happen first thing and
unconditionally in vb2_core_poll().
Signed-off-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-core.c | 11 +--
1 file changed, 9
of the queue-related events are requested.
Signed-off-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c
b/drivers/media/v4l2-core/v4l2-mem2mem.c
index b221b4e438a1
On Sun, Nov 22, 2020 at 6:25 PM Alexandre Courbot wrote:
>
> The "Interacting With the Legacy GPIO Subsystem" of the documentation
> was unclear at best, and even included a sentence that seems to say the
> opposite of what it should say about the lifetime of the return val
fully make that section more
readable.
Signed-off-by: Alexandre Courbot
---
Documentation/driver-api/gpio/consumer.rst | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/Documentation/driver-api/gpio/consumer.rst
b/Documentation/driver-api/gpio/consumer.rst
index 42
On Wed, Nov 11, 2020 at 9:47 PM Hans Verkuil wrote:
>
> On 11/11/2020 13:41, Alexandre Courbot wrote:
> > On Thu, Nov 5, 2020 at 11:05 PM Alexandre Courbot wrote:
> >>
> >> On Thu, Nov 5, 2020 at 10:12 PM Hans Verkuil
> >> wrote:
> >>>
On Thu, Nov 5, 2020 at 11:05 PM Alexandre Courbot wrote:
>
> On Thu, Nov 5, 2020 at 10:12 PM Hans Verkuil wrote:
> >
> > On 05/11/2020 13:52, Alexandre Courbot wrote:
> > > On Thu, Nov 5, 2020 at 9:36 PM Hans Verkuil
> > > wrote:
> > >>
>
On Thu, Nov 5, 2020 at 10:12 PM Hans Verkuil wrote:
>
> On 05/11/2020 13:52, Alexandre Courbot wrote:
> > On Thu, Nov 5, 2020 at 9:36 PM Hans Verkuil
> > wrote:
> >>
> >> On 05/11/2020 13:21, Alexandre Courbot wrote:
> >>> On Tue, N
On Thu, Nov 5, 2020 at 9:36 PM Hans Verkuil wrote:
>
> On 05/11/2020 13:21, Alexandre Courbot wrote:
> > On Tue, Nov 3, 2020 at 6:48 PM Hans Verkuil
> > wrote:
> >>
> >> On 03/11/2020 09:51, Alexandre Courbot wrote:
> >>> Hi Hans,
> >
On Tue, Nov 3, 2020 at 6:48 PM Hans Verkuil wrote:
>
> On 03/11/2020 09:51, Alexandre Courbot wrote:
> > Hi Hans,
> >
> > On Sat, Oct 31, 2020 at 12:09 AM Hans Verkuil
> > wrote:
> >>
> >> On 22/10/2020 14:24, Alexandre Courbot wrote:
> >
Hi Hans,
On Sat, Oct 31, 2020 at 12:09 AM Hans Verkuil wrote:
>
> On 22/10/2020 14:24, Alexandre Courbot wrote:
> > do_poll()/do_select() seem to set the _qproc member of poll_table to
> > NULL the first time they are called on a given table, making subsequent
>
On Tue, Nov 3, 2020 at 12:48 PM kernel test robot wrote:
>
> Hi Yunfei,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: b7cbaf59f62f8ab8f157698f9e31642bff525bd0
> commit:
On Mon, Nov 2, 2020 at 9:09 AM kernel test robot wrote:
>
> Hi Alexandre,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 3cea11cd5e3b00d91caf0b4730194039b45c5891
> commit:
: cbd2dca74926c0e4610c40923cc786b732c9e8ef remoteproc: scp: add
COMPILE_TEST dependency
Reported-by: kernel test robot
Signed-off-by: Alexandre Courbot
---
drivers/remoteproc/mtk_scp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
On Tue, Oct 13, 2020 at 9:44 PM Alexandre Courbot wrote:
>
> The addition of MT8183 support added a dependency on the SCP remoteproc
> module. However the initial patch used the "select" Kconfig directive,
> which may result in the SCP module to not be compiled if rem
On Tue, Oct 13, 2020 at 9:44 PM Alexandre Courbot wrote:
>
> mtk-vcodec supports two kinds of firmware, VPU and SCP. Both were
> supported from the same source files, but this is clearly unclean and
> makes it more difficult to disable support for one or the other.
>
> Move the
On Thu, Oct 22, 2020 at 9:24 PM Alexandre Courbot wrote:
>
> do_poll()/do_select() seem to set the _qproc member of poll_table to
> NULL the first time they are called on a given table, making subsequent
> calls of poll_wait() on that table no-ops. This is a problem for mem2mem
&
of the queue-related events are requested.
Signed-off-by: Alexandre Courbot
---
I seem to be hitting all the polling corner cases recently! ^_^; This
time I was wondering why epoll_wait() never returned after I received
the first resolution change event from the vicodec stateful decoder.
This is why
buffers.
The firmware unfortunately does not always provide the crop information
from the stream ; also make sure to detect when that happens and
fallback to providing the coded size in these cases.
Signed-off-by: Alexandre Courbot
---
Changes since v1:
* Fall back to the previous behavior of returning
Hi Dikshita,
On Mon, Oct 19, 2020 at 11:29 PM Dikshita Agarwal
wrote:
>
> Add handling for below commands in encoder:
> 1. V4L2_ENC_CMD_STOP
> 2. V4L2_ENC_CMD_START
I suspect this can be implemented more easily (and more safely) using
the m2m encoder helpers introduced recently. Please see this
; that information from the firmware and just returned the dimensions of
> > CAPTURE buffers.
> >
> > Signed-off-by: Alexandre Courbot
> > ---
> > drivers/media/platform/qcom/venus/core.h | 1 +
> > drivers/media/platform/qcom/venus/vdec.c | 21 +++
.
* Fixed typo in Kconfig description.
Alexandre Courbot (2):
media: mtk-vcodec: move firmware implementations into their own files
media: mtk-vcodec: fix build breakage when one of VPU or SCP is
enabled
drivers/media/platform/Kconfig| 28 ++-
drivers/media/platform/mtk-vcodec
this new scenario.
Also adapt the Kconfig text to explain the extra requirements for MT8173
and MT8183.
Reported-by: Sakari Ailus
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/Kconfig| 28 ++-
drivers/media/platform/mtk-vcodec/Makefile| 10 ++
.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/Makefile| 4 +-
.../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 2 +-
.../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 2 +-
.../media/platform/mtk-vcodec/mtk_vcodec_fw.c | 174 +-
.../media/platform
Hi Mauro,
On Mon, Oct 12, 2020 at 4:43 PM Mauro Carvalho Chehab
wrote:
>
> Em Mon, 12 Oct 2020 14:35:57 +0900
> Alexandre Courbot escreveu:
>
> > The addition of MT8183 support added a dependency on the SCP remoteproc
> > module. However the initial patch used the &q
On Tue, Oct 13, 2020 at 12:00 AM Randy Dunlap wrote:
>
> On 10/11/20 10:35 PM, Alexandre Courbot wrote:
> > The addition of MT8183 support added a dependency on the SCP remoteproc
> > module. However the initial patch used the "select" Kconfig directive,
> >
.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/Makefile| 4 +-
.../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 2 +-
.../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 2 +-
.../media/platform/mtk-vcodec/mtk_vcodec_fw.c | 174 +-
.../media/platform
implementations using two new transparent
Kconfig symbols.
Changes since v1:
* Added Acked-by from Randy.
* Fixed typo in Kconfig description.
Alexandre Courbot (2):
media: mtk-vcodec: move firmware implementations into their own files
media: mtk-vcodec: fix build breakage when one of VPU or SCP
this new scenario.
Also adapt the Kconfig text to explain the extra requirements for MT8173
and MT8183.
Reported-by: Sakari Ailus
Signed-off-by: Alexandre Courbot
Acked-by: Randy Dunlap # build-tested
Acked-by: Sakari Ailus
---
drivers/media/platform/Kconfig| 22 +++--
Hi Mauro,
On Fri, Oct 9, 2020 at 3:34 PM Mauro Carvalho Chehab
wrote:
>
> Em Fri, 9 Oct 2020 13:30:06 +0900
> Alexandre Courbot escreveu:
>
> > On Fri, Oct 9, 2020 at 1:13 AM Hans Verkuil
> > wrote:
>
> > > >>> If VIDEO_MEDIATEK_VPU=y
On Tue, Sep 29, 2020 at 1:44 AM Stanimir Varbanov
wrote:
>
> In real use of dynamic-resolution-change it is observed that the
> LAST buffer flag (which marks the last decoded buffer with the
> resolution before the resolution-change event) is not reliably set.
>
> Fix this by set the LAST buffer
On Tue, Sep 29, 2020 at 1:44 AM Stanimir Varbanov
wrote:
>
> In real use of dynamic-resolution-change it is observed that the
> LAST buffer flag (which marks the last decoded buffer with the
> resolution before the resolution-change event) is not reliably set.
>
> Fix this by set the LAST buffer
buffers.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/qcom/venus/core.h | 1 +
drivers/media/platform/qcom/venus/vdec.c | 21 -
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.h
b/drivers/media/platform/qcom
On Fri, Oct 9, 2020 at 1:13 AM Hans Verkuil wrote:
>
> On 08/10/2020 16:02, Alexandre Courbot wrote:
> > Hi Hans, thanks for taking the time to look at this!
> >
> > On Thu, Oct 8, 2020 at 10:12 PM Hans Verkuil
> > wrote:
> >>
> >> On 08/10/20
Hi Hans, thanks for taking the time to look at this!
On Thu, Oct 8, 2020 at 10:12 PM Hans Verkuil wrote:
>
> On 08/10/2020 15:07, Hans Verkuil wrote:
> > Hi Alexandre,
> >
> > On 04/10/2020 14:22, Alexandre Courbot wrote:
> >> The addition of MT8183 supp
On Mon, Oct 5, 2020 at 5:49 PM Sakari Ailus
wrote:
>
> Hi Alexandre,
>
> On Sun, Oct 04, 2020 at 09:22:34PM +0900, Alexandre Courbot wrote:
> > The addition of MT8183 support added a dependency on the SCP remoteproc
> > module. However the initial patch used the &q
On Sun, Oct 4, 2020 at 9:22 PM Alexandre Courbot wrote:
>
> The addition of MT8183 support added a dependency on the SCP remoteproc
> module. However the initial patch used the "select" Kconfig directive,
> which may result in the SCP module to not be compiled if rem
this new scenario.
Also adapt the Kconfig text to explain the extra requirements for MT8173
and MT8183.
Reported-by: Sakari Ailus
Signed-off-by: Alexandre Courbot
Acked-by: Randy Dunlap # build-tested
---
drivers/media/platform/Kconfig| 10 +--
.../media/platform/m
On Sun, Oct 4, 2020 at 1:50 AM Randy Dunlap wrote:
>
> On 10/3/20 6:09 AM, Alexandre Courbot wrote:
> > The addition of MT8183 support added a dependency on the SCP remoteproc
> > module. However the initial patch used the "select" Kconfig directive,
> >
this new scenario.
Also adapt the Kconfig text to explain the extra requirements for MT8173
and MT8183.
Reported-by: Sakari Ailus
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/Kconfig| 11 +--
.../media/platform/mtk-vcodec/mtk_vcodec_fw.c | 72 ---
2 files
On Tue, Sep 15, 2020 at 12:25 PM Bjorn Andersson
wrote:
>
> On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot wrote:
>
> > This will improve this driver's build coverage.
> >
> > Reported-by: Ezequiel Garcia
> > Signed-off-by: Alexandre Courbot
>
This will improve this driver's build coverage.
Reported-by: Ezequiel Garcia
Signed-off-by: Alexandre Courbot
---
Hi remoteproc maintainers,
Second resend as I got no reaction for almost 1 month on this one-liner.
Pretty please?
As explained in
https://www.spinics.net/lists/linux-media
On Thu, Sep 10, 2020 at 3:04 PM Alexandre Courbot wrote:
>
> Hi Ezequiel, sorry for the late review!
>
> On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia
> wrote:
> >
> > From: Boris Brezillon
> >
> > Add the VP9 stateless decoder co
Hi Ezequiel, sorry for the late review!
On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia wrote:
>
> From: Boris Brezillon
>
> Add the VP9 stateless decoder controls plus the documentation that goes
> with it.
>
> Signed-off-by: Boris Brezillon
> Signed-off-by: Ezequiel Garcia
> ---
>
1 - 100 of 3008 matches
Mail list logo
