On 2/3/21 8:29 PM, Masami Hiramatsu wrote:
Warn if the kprobe is reregistered, since there must be
a software bug (actively used resource must not be re-registered)
and caller must be fixed.
Signed-off-by: Masami Hiramatsu
Acked-by: Ananth N Mavinakayanahalli
Commit-ID: 4799f6856fdd38c8078a190eca3288029287cf66
Gitweb: https://git.kernel.org/tip/4799f6856fdd38c8078a190eca3288029287cf66
Author: Ananth N Mavinakayanahalli
AuthorDate: Tue, 17 Jul 2018 11:32:37 +0530
Committer: Ingo Molnar
CommitDate: Tue, 24 Jul 2018 17:01:28 +0200
MAINTAINERS
Commit-ID: 4799f6856fdd38c8078a190eca3288029287cf66
Gitweb: https://git.kernel.org/tip/4799f6856fdd38c8078a190eca3288029287cf66
Author: Ananth N Mavinakayanahalli
AuthorDate: Tue, 17 Jul 2018 11:32:37 +0530
Committer: Ingo Molnar
CommitDate: Tue, 24 Jul 2018 17:01:28 +0200
MAINTAINERS
Commit-ID: 1b51a2fe84d87ae3df11b169cfb38db16df0c9af
Gitweb: https://git.kernel.org/tip/1b51a2fe84d87ae3df11b169cfb38db16df0c9af
Author: Ananth N Mavinakayanahalli
AuthorDate: Tue, 17 Jul 2018 11:32:37 +0530
Committer: Ingo Molnar
CommitDate: Tue, 17 Jul 2018 09:23:23 +0200
MAINTAINERS
Commit-ID: 1b51a2fe84d87ae3df11b169cfb38db16df0c9af
Gitweb: https://git.kernel.org/tip/1b51a2fe84d87ae3df11b169cfb38db16df0c9af
Author: Ananth N Mavinakayanahalli
AuthorDate: Tue, 17 Jul 2018 11:32:37 +0530
Committer: Ingo Molnar
CommitDate: Tue, 17 Jul 2018 09:23:23 +0200
MAINTAINERS
Naveen has been contributing consistently reviewing and hardening
kprobes for some time now. I have not been able to do the same due
to other commitments.
Signed-off-by: Ananth N Mavinakayanahalli
---
MAINTAINERS |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS
Naveen has been contributing consistently reviewing and hardening
kprobes for some time now. I have not been able to do the same due
to other commitments.
Signed-off-by: Ananth N Mavinakayanahalli
---
MAINTAINERS |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS
On Thu, Nov 09, 2017 at 09:54:50PM +, David Howells wrote:
> Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com> wrote:
>
> > Yes, this patch will prevent any kprobe registration.
>
> Can I put that down as a Reviewed-by?
Reviewed-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
On Thu, Nov 09, 2017 at 09:54:50PM +, David Howells wrote:
> Ananth N Mavinakayanahalli wrote:
>
> > Yes, this patch will prevent any kprobe registration.
>
> Can I put that down as a Reviewed-by?
Reviewed-by: Ananth N Mavinakayanahalli
On Thu, Nov 09, 2017 at 04:52:05PM +, David Howells wrote:
> Hi,
>
> I need to lock down kprobes under secure boot conditions as part of the patch
> series that can be found here:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=efi-lock-down
>
> Can
On Thu, Nov 09, 2017 at 04:52:05PM +, David Howells wrote:
> Hi,
>
> I need to lock down kprobes under secure boot conditions as part of the patch
> series that can be found here:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=efi-lock-down
>
> Can
On Wed, Nov 08, 2017 at 04:21:33PM +, David Howells wrote:
> Hi,
>
> I need to lock down kprobes under secure boot conditions as part of the patch
> series that can be found here:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=efi-lock-down
>
> Can
On Wed, Nov 08, 2017 at 04:21:33PM +, David Howells wrote:
> Hi,
>
> I need to lock down kprobes under secure boot conditions as part of the patch
> series that can be found here:
>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=efi-lock-down
>
> Can
Bangoria <ravi.bango...@linux.vnet.ibm.com>
> Reviewed-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com>
Reviewed-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
y using lwz,
> effectively loading a corrupt (32bit) address, causing the kernel crash.
>
> Fix this by loading the 64bit value instead.
>
> Fixes: be96f63375a1 ("powerpc: Split out instruction analysis part of
> emulate_step()")
> Signed-off-by: Ravi Bangoria
> Reviewed-by: Naveen N. Rao
Reviewed-by: Ananth N Mavinakayanahalli
On Wed, Feb 22, 2017 at 07:23:38PM +0530, Naveen N. Rao wrote:
> With ABIv2, we offset 8 bytes into a function to get at the local entry
> point.
>
Looks good.
> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
On Wed, Feb 22, 2017 at 07:23:38PM +0530, Naveen N. Rao wrote:
> With ABIv2, we offset 8 bytes into a function to get at the local entry
> point.
>
Looks good.
> Signed-off-by: Naveen N. Rao
Acked-by: Ananth N Mavinakayanahalli
On Wed, Feb 15, 2017 at 12:28:34AM +0530, Naveen N. Rao wrote:
> Allow kprobes to be placed on ftrace _mcount() call sites. This
> optimization avoids the use of a trap, by riding on ftrace
> infrastructure.
>
> This depends on HAVE_DYNAMIC_FTRACE_WITH_REGS which depends on
> MPROFILE_KERNEL,
On Wed, Feb 15, 2017 at 12:28:34AM +0530, Naveen N. Rao wrote:
> Allow kprobes to be placed on ftrace _mcount() call sites. This
> optimization avoids the use of a trap, by riding on ftrace
> infrastructure.
>
> This depends on HAVE_DYNAMIC_FTRACE_WITH_REGS which depends on
> MPROFILE_KERNEL,
>
> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
>
> Signed-off-by: Naveen N. Rao
Acked-by: Ananth N Mavinakayanahalli
On Tue, Feb 14, 2017 at 02:08:02PM +0530, Naveen N. Rao wrote:
> This helper will be used in a subsequent patch to emulate instructions
> on re-entering the kprobe handler. No functional change.
>
> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com>
On Tue, Feb 14, 2017 at 02:08:02PM +0530, Naveen N. Rao wrote:
> This helper will be used in a subsequent patch to emulate instructions
> on re-entering the kprobe handler. No functional change.
>
> Signed-off-by: Naveen N. Rao
Acked-by: Ananth N Mavinakayanahalli
> c00d04c8 k _do_fork+0x8[DISABLED]
> c00d04d0 k _do_fork+0x10[DISABLED]
> c00412b0 k kretprobe_trampoline+0x0 [OPTIMIZED]
>
> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
> c00d04c8 k _do_fork+0x8[DISABLED]
> c00d04d0 k _do_fork+0x10[DISABLED]
> c00412b0 k kretprobe_trampoline+0x0[OPTIMIZED]
>
> Signed-off-by: Naveen N. Rao
Acked-by: Ananth N Mavinakayanahalli
aveen:
> insmod: ERROR: could not insert module
> samples/kprobes/kretprobe_example.ko: Operation not permitted
>
> And dmesg:
> [48253.757629] register_kretprobe failed, returned -22
>
> Signed-off-by: Naveen N. Rao <naveen.n....@linux.vnet.ibm.com>
Acked-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
aveen:
> insmod: ERROR: could not insert module
> samples/kprobes/kretprobe_example.ko: Operation not permitted
>
> And dmesg:
> [48253.757629] register_kretprobe failed, returned -22
>
> Signed-off-by: Naveen N. Rao
Acked-by: Ananth N Mavinakayanahalli
On Thu, Aug 25, 2016 at 10:50:18PM +0530, Hari Bathini wrote:
>
>
> On Thursday 25 August 2016 06:31 PM, Peter Zijlstra wrote:
> >On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote:
> >
> >>diff --git a/include/uapi/linux/perf_event.h
> >>b/include/uapi/linux/perf_event.h
> >>index
On Thu, Aug 25, 2016 at 10:50:18PM +0530, Hari Bathini wrote:
>
>
> On Thursday 25 August 2016 06:31 PM, Peter Zijlstra wrote:
> >On Thu, Aug 25, 2016 at 05:27:54PM +0530, Hari Bathini wrote:
> >
> >>diff --git a/include/uapi/linux/perf_event.h
> >>b/include/uapi/linux/perf_event.h
> >>index
running kprobe.
>
> Signed-off-by: Masami Hiramatsu <mhira...@kernel.org>
Good catch!
Reviewed-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
ting running kprobe.
>
> Signed-off-by: Masami Hiramatsu
Good catch!
Reviewed-by: Ananth N Mavinakayanahalli
The current ID is going away soon... update email address
Signed-off-by: Ananth N Mavinakayanahalli <ana...@linux.vnet.ibm.com>
diff --git a/MAINTAINERS b/MAINTAINERS
index 1d5b4be..dc23998 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6400,7 +6400,7 @@ F:mm/kmemleak.c
F:
The current ID is going away soon... update email address
Signed-off-by: Ananth N Mavinakayanahalli
diff --git a/MAINTAINERS b/MAINTAINERS
index 1d5b4be..dc23998 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6400,7 +6400,7 @@ F:mm/kmemleak.c
F: mm/kmemleak-test.c
KPROBES
-M
On Wed, Apr 06, 2016 at 06:02:57PM +0530, Naveen N. Rao wrote:
> + if (!pev->uprobes && map->dso->symtab_type == DSO_BINARY_TYPE__KALLSYMS)
> tev->point.offset += PPC64LE_LEP_OFFSET;
uprobes check against kallsysms? Am I missing something here?
Ananth
On Wed, Apr 06, 2016 at 06:02:57PM +0530, Naveen N. Rao wrote:
> + if (!pev->uprobes && map->dso->symtab_type == DSO_BINARY_TYPE__KALLSYMS)
> tev->point.offset += PPC64LE_LEP_OFFSET;
uprobes check against kallsysms? Am I missing something here?
Ananth
l the symbols during symbol table load,
> but only adjust the probe trace point.
>
> Cc: Mark Wielaard <m...@redhat.com>
> Cc: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com>
> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com>
> Cc: Arnaldo Carvalho de
l the symbols during symbol table load,
> but only adjust the probe trace point.
>
> Cc: Mark Wielaard
> Cc: Thiago Jung Bauermann
> Cc: Ananth N Mavinakayanahalli
> Cc: Arnaldo Carvalho de Melo
> Cc: Masami Hiramatsu
> Reported-by: Michael Ellerman
> Signed-off-by: Naveen N. Rao
Acked-by: Ananth N Mavinakayanahalli
to be had with a direct
jump instead of a breakpoint, but the caveats need to be traded off
with the complexity it brings in.
For now, mark OPTPROBES na for powerpc.
Signed-off-by: Ananth N Mavinakayanahalli
---
.../features/debug/optprobes/arch-support.txt |2 +-
1 file changed, 1 insertion
To be used for features we will not support on a particular architecture.
The git log that adds this needs to provide the justification 'why?'
Signed-off-by: Ananth N Mavinakayanahalli
---
Documentation/features/arch-support.txt |1 +
1 file changed, 1 insertion(+)
diff --git
to be had with a direct
jump instead of a breakpoint, but the caveats need to be traded off
with the complexity it brings in.
For now, mark OPTPROBES na for powerpc.
Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
.../features/debug/optprobes/arch-support.txt |2 +-
1 file
To be used for features we will not support on a particular architecture.
The git log that adds this needs to provide the justification 'why?'
Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
Documentation/features/arch-support.txt |1 +
1 file changed, 1 insertion(+)
diff
-by: Ananth N Mavinakayanahalli
---
.../features/debug/optprobes/arch-support.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/features/debug/optprobes/arch-support.txt
b/Documentation/features/debug/optprobes/arch-support.txt
index b8999d8..73662f9
To be used for features we will not support on a particular architecture.
The git log that adds this needs to provide the justification 'why?'
Signed-off-by: Ananth N Mavinakayanahalli
---
Documentation/features/arch-support.txt |1 +
1 file changed, 1 insertion(+)
diff --git
To be used for features we will not support on a particular architecture.
The git log that adds this needs to provide the justification 'why?'
Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
Documentation/features/arch-support.txt |1 +
1 file changed, 1 insertion(+)
diff
-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
.../features/debug/optprobes/arch-support.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/features/debug/optprobes/arch-support.txt
b/Documentation/features/debug/optprobes/arch-support.txt
index
On Thu, May 14, 2015 at 09:01:03AM +0900, Masami Hiramatsu wrote:
> On 2015/05/14 0:41, William Cohen wrote:
> > On 05/13/2015 05:22 AM, Masami Hiramatsu wrote:
> >> On 2015/05/12 21:48, William Cohen wrote:
> >
> >>> Hi Dave,
> >>>
> >>> In some of the previous diagnostic output it looked like
On Thu, May 14, 2015 at 09:01:03AM +0900, Masami Hiramatsu wrote:
On 2015/05/14 0:41, William Cohen wrote:
On 05/13/2015 05:22 AM, Masami Hiramatsu wrote:
On 2015/05/12 21:48, William Cohen wrote:
Hi Dave,
In some of the previous diagnostic output it looked like things would go
Commit-ID: c50fc0a43e33a6c3257c5cbb954cd747d7b9a680
Gitweb: http://git.kernel.org/tip/c50fc0a43e33a6c3257c5cbb954cd747d7b9a680
Author: Ananth N Mavinakayanahalli
AuthorDate: Tue, 28 Apr 2015 17:35:38 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 4 May 2015 12:43:45 -0300
Commit-ID: c50fc0a43e33a6c3257c5cbb954cd747d7b9a680
Gitweb: http://git.kernel.org/tip/c50fc0a43e33a6c3257c5cbb954cd747d7b9a680
Author: Ananth N Mavinakayanahalli ana...@in.ibm.com
AuthorDate: Tue, 28 Apr 2015 17:35:38 +0530
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate
n.
> > Error: Command Parse Error.
> >
> > Fix this by checking the probe pattern in more detail.
>
> Masami, can I have your Acked-by or Reviewed-by?
Arnaldo,
FWIW, I have reviewed this code...
Reviewed-by: Ananth N Mavinakayanahalli
>
>
> - Arnaldo
in more detail.
Masami, can I have your Acked-by or Reviewed-by?
Arnaldo,
FWIW, I have reviewed this code...
Reviewed-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
- Arnaldo
Signed-off-by: Naveen N. Rao naveen.n@linux.vnet.ibm.com
---
tools/perf/util/probe-event.c | 23
| 57 --
> tools/perf/util/symbol-elf.c | 11 -
> tools/perf/util/symbol.c | 6 +++
> 9 files changed, 170 insertions(+), 30 deletions(-)
> create mode 100644 tools/perf/arch/powerpc/util/elf-sym-decode.c
> create
and applying it won't break other arch users, but having a/rev-by from
> ppc developers should speed up this process.
Hi Arnaldo,
Yes, I have reviewed the patches. So, for all patches...
Reviewed-by: Ananth N Mavinakayanahalli
--
To unsubscribe from this list: send the line "unsubsc
-by from
ppc developers should speed up this process.
Hi Arnaldo,
Yes, I have reviewed the patches. So, for all patches...
Reviewed-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
| 6 +++
9 files changed, 170 insertions(+), 30 deletions(-)
create mode 100644 tools/perf/arch/powerpc/util/elf-sym-decode.c
create mode 100644 tools/perf/util/elf_sym.h
For the full patchset...
Reviewed-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
--
To unsubscribe from
On Tue, Oct 21, 2014 at 05:48:30PM +0200, Jiri Kosina wrote:
> kernel/kprobes.c| 28
> 2 files changed, 33 insertions(+)
>
> diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
> index f7296e5..f760555 100644
> --- a/include/linux/kprobes.h
> +++
On Tue, Oct 21, 2014 at 05:48:30PM +0200, Jiri Kosina wrote:
kernel/kprobes.c| 28
2 files changed, 33 insertions(+)
diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h
index f7296e5..f760555 100644
--- a/include/linux/kprobes.h
+++
e.lock again.
> Normal interrupts have no problem because they are disabled
> with the lock.
>
> Signed-off-by: Masami Hiramatsu
Acked-by: Ananth N Mavinakayanahalli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord
.
Normal interrupts have no problem because they are disabled
with the lock.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Acked-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
On Mon, May 12, 2014 at 07:08:22PM +0200, Oleg Nesterov wrote:
> On 05/08, Oleg Nesterov wrote:
> >
> > But let me send the initial changes first for review. If they pass the
> > review
> > and if nobody objects, I'd like to route them along with the pending uprobes
> > fixes.
>
> OK, nobody
On Mon, May 12, 2014 at 07:08:22PM +0200, Oleg Nesterov wrote:
On 05/08, Oleg Nesterov wrote:
But let me send the initial changes first for review. If they pass the
review
and if nobody objects, I'd like to route them along with the pending uprobes
fixes.
OK, nobody cares ;)
So I
On Thu, May 08, 2014 at 02:40:00PM +0900, Masami Hiramatsu wrote:
> (2014/05/08 13:47), Ananth N Mavinakayanahalli wrote:
> > On Wed, May 07, 2014 at 08:55:51PM +0900, Masami Hiramatsu wrote:
> >
> > ...
> >
> >> +#if defined(CONFIG_PPC64) &
On Thu, May 08, 2014 at 02:40:00PM +0900, Masami Hiramatsu wrote:
(2014/05/08 13:47), Ananth N Mavinakayanahalli wrote:
On Wed, May 07, 2014 at 08:55:51PM +0900, Masami Hiramatsu wrote:
...
+#if defined(CONFIG_PPC64) (!defined(_CALL_ELF) || _CALL_ELF == 1)
+/*
+ * On PPC64 ABIv1
On Wed, May 07, 2014 at 08:55:51PM +0900, Masami Hiramatsu wrote:
...
> +#if defined(CONFIG_PPC64) && (!defined(_CALL_ELF) || _CALL_ELF == 1)
> +/*
> + * On PPC64 ABIv1 the function pointer actually points to the
> + * function's descriptor. The first entry in the descriptor is the
> + * address
On Wed, May 07, 2014 at 08:55:51PM +0900, Masami Hiramatsu wrote:
...
+#if defined(CONFIG_PPC64) (!defined(_CALL_ELF) || _CALL_ELF == 1)
+/*
+ * On PPC64 ABIv1 the function pointer actually points to the
+ * function's descriptor. The first entry in the descriptor is the
+ * address of the
On Sat, Nov 09, 2013 at 06:53:50PM +0100, Oleg Nesterov wrote:
> Hello.
>
> Ananth, could you please explicitly ack or nack 2/2 ? It is
> really simple, but obviously I can't test it. And even if it
> is correct it should be merged only if you like it, this is
> the minor cleanup.
The changes
in hardware.
>*/
> - ret = emulate_step(regs, auprobe->ainsn);
> + ret = emulate_step(regs, auprobe->insn);
> if (ret > 0)
> return true;
Acked-by: Ananth N Mavinakayanahalli
Thanks Oleg.
Ananth
--
To unsubscribe from this list: send t
)
return true;
Acked-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
Thanks Oleg.
Ananth
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Sat, Nov 09, 2013 at 06:53:50PM +0100, Oleg Nesterov wrote:
Hello.
Ananth, could you please explicitly ack or nack 2/2 ? It is
really simple, but obviously I can't test it. And even if it
is correct it should be merged only if you like it, this is
the minor cleanup.
The changes look
On Sat, Aug 10, 2013 at 05:55:33PM -0700, Andi Kleen wrote:
> From: Joe Mario
>
> Use KSYM_NAME_LEN to size identifier buffers, so that it can
> be easier increased.
>
> Cc: ana...@in.ibm.com
> Signed-off-by: Joe Mario
> Signed-off-by: Andi Kleen
Acked-by: An
Acked-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
kernel/kprobes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 6e33498..e174daf 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -2083,7 +2083,7 @@ static
4db01c89af0f86f3e8920d354df
>
> Signed-off-by: Masami Hiramatsu
> Cc: Ingo Molnar
> Cc: Tejun Heo
> Cc: Ananth N Mavinakayanahalli
> Cc: "David S. Miller"
Acked-by: Ananth N Mavinakayanahalli
--
To unsubscribe from this list: send the line "unsubscribe linux-k
-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Cc: Ingo Molnar mi...@redhat.com
Cc: Tejun Heo t...@kernel.org
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: David S. Miller da...@davemloft.net
Acked-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
--
To unsubscribe from
On Wed, Apr 03, 2013 at 07:45:52PM +0200, Oleg Nesterov wrote:
> On 04/03, Anton Arapov wrote:
...
> Looks fine to me. I am going to add this to
> git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core
>
> Ananth. "4/9 uretprobes/ppc" looks "obviously correct", but could you
>
On Wed, Apr 03, 2013 at 06:00:34PM +0200, Anton Arapov wrote:
> Hijack the return address and replace it with a trampoline address.
> PowerPC implementation.
>
> Signed-off-by: Anton Arapov
Acked-by: Ananth N Mavinakayanahalli
> ---
> arch/powerpc/include/asm/uprobes.h | 1
On Wed, Apr 03, 2013 at 06:00:34PM +0200, Anton Arapov wrote:
Hijack the return address and replace it with a trampoline address.
PowerPC implementation.
Signed-off-by: Anton Arapov an...@redhat.com
Acked-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
arch/powerpc/include/asm
On Wed, Apr 03, 2013 at 07:45:52PM +0200, Oleg Nesterov wrote:
On 04/03, Anton Arapov wrote:
...
Looks fine to me. I am going to add this to
git://git.kernel.org/pub/scm/linux/kernel/git/oleg/misc uprobes/core
Ananth. 4/9 uretprobes/ppc looks obviously correct, but could you
please review
From: Ananth N Mavinakayanahalli
prepare_uprobe() already checks if the underlying unstruction
(on file) is a trap variant. We don't need to check this again.
Signed-off-by: Ananth N Mavinakayanahalli
---
arch/powerpc/kernel/uprobes.c |6 --
1 file changed, 6 deletions(-)
Index
From: Ananth N Mavinakayanahalli
Powerpc has many trap variants that could be used by entities like gdb.
Currently, running gdb on a program being traced by uprobes causes an
endless loop since uprobes doesn't understand that the trap was inserted
by some other entity and a SIGTRAP needs
From: Ananth N Mavinakayanahalli
Refuse to place a uprobe if a trap variant already exists in the
file copy at the address.
Signed-off-by: Ananth N Mavinakayanahalli
---
kernel/events/uprobes.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-3.9-rc3/kernel/events
From: Ananth N Mavinakayanahalli
Some architectures like powerpc have multiple variants of the trap
instruction. Introduce an additional helper is_trap_insn() for run-time
handling of non-uprobe traps on such architectures.
While there, change is_swbp_at_addr() to is_trap_at_addr() for reading
On Fri, Mar 22, 2013 at 03:54:06PM +0100, Oleg Nesterov wrote:
> On 03/22, Ananth N Mavinakayanahalli wrote:
> >
> > +/**
> > + * is_trap_insn - check if instruction is breakpoint instruction.
> > + * @insn: instruction to be checked.
> > + * Default implementatio
From: Ananth N Mavinakayanahalli
The current implementation of uprobes assumes that uprobes always wins
even when a register request is at a location with a conditional
breakpoint by some other entity. Refer to [1] for more details.
Remove the breakpoint instruction check during registration
From: Ananth N Mavinakayanahalli
Powerpc has many trap variants that could be used by entities like gdb.
Currently, running gdb on a program being traced by uprobes causes an
endless loop since uprobes doesn't understand that the trap was inserted
by some other entity and a SIGTRAP needs
From: Ananth N Mavinakayanahalli
Some architectures like powerpc have multiple variants of the trap
instruction. Introduce an additional helper is_trap_insn() for run-time
handling of non-uprobe traps on such architectures.
While there, change is_swbp_at_addr() to is_trap_at_addr() for reading
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
Some architectures like powerpc have multiple variants of the trap
instruction. Introduce an additional helper is_trap_insn() for run-time
handling of non-uprobe traps on such architectures.
While there, change is_swbp_at_addr
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
Powerpc has many trap variants that could be used by entities like gdb.
Currently, running gdb on a program being traced by uprobes causes an
endless loop since uprobes doesn't understand that the trap was inserted
by some other entity
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
The current implementation of uprobes assumes that uprobes always wins
even when a register request is at a location with a conditional
breakpoint by some other entity. Refer to [1] for more details.
Remove the breakpoint instruction check
On Fri, Mar 22, 2013 at 03:54:06PM +0100, Oleg Nesterov wrote:
On 03/22, Ananth N Mavinakayanahalli wrote:
+/**
+ * is_trap_insn - check if instruction is breakpoint instruction.
+ * @insn: instruction to be checked.
+ * Default implementation of is_trap_insn
+ * Returns true if @insn
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
Some architectures like powerpc have multiple variants of the trap
instruction. Introduce an additional helper is_trap_insn() for run-time
handling of non-uprobe traps on such architectures.
While there, change is_swbp_at_addr
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
Refuse to place a uprobe if a trap variant already exists in the
file copy at the address.
Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
kernel/events/uprobes.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
Powerpc has many trap variants that could be used by entities like gdb.
Currently, running gdb on a program being traced by uprobes causes an
endless loop since uprobes doesn't understand that the trap was inserted
by some other entity
From: Ananth N Mavinakayanahalli ana...@in.ibm.com
prepare_uprobe() already checks if the underlying unstruction
(on file) is a trap variant. We don't need to check this again.
Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com
---
arch/powerpc/kernel/uprobes.c |6 --
1 file
Commit-ID: 79146a69c8bc3f28e51c5267633abc6babf47a31
Gitweb: http://git.kernel.org/tip/79146a69c8bc3f28e51c5267633abc6babf47a31
Author: Ananth N Mavinakayanahalli
AuthorDate: Tue, 12 Mar 2013 14:32:17 +0530
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 13 Mar 2013 17:00:33 -0300
Commit-ID: 79146a69c8bc3f28e51c5267633abc6babf47a31
Gitweb: http://git.kernel.org/tip/79146a69c8bc3f28e51c5267633abc6babf47a31
Author: Ananth N Mavinakayanahalli ana...@in.ibm.com
AuthorDate: Tue, 12 Mar 2013 14:32:17 +0530
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate
hen registering probe
> and store the result on ainsn->if_modifier.
>
> Signed-off-by: Masami Hiramatsu
> Reported-by: Timo Juhani Lindfors
> Cc: "David S. Miller"
> Cc: Ananth N Mavinakayanahalli
> Cc: Thomas Gleixner
> Cc: Ingo Molnar
> Cc: "H.
Masami Hiramatsu
> Reported-by: Timo Juhani Lindfors
> Cc: "David S. Miller"
> Cc: Nadia Yvette Chambers
> Cc: Pavel Emelyanov
> Cc: Jiri Kosina
> Cc: Ananth N Mavinakayanahalli
> Cc: Ingo Molnar
> Cc: Linus Torvalds
Acked-by: Ananth N Mavinakayanaha
-by: Timo Juhani Lindfors timo.lindf...@iki.fi
Cc: David S. Miller da...@davemloft.net
Cc: Nadia Yvette Chambers n...@holomorphy.com
Cc: Pavel Emelyanov xe...@parallels.com
Cc: Jiri Kosina jkos...@suse.cz
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: Ingo Molnar mi...@kernel.org
Cc: Linus
-if_modifier.
Signed-off-by: Masami Hiramatsu masami.hiramatsu...@hitachi.com
Reported-by: Timo Juhani Lindfors timo.lindf...@iki.fi
Cc: David S. Miller da...@davemloft.net
Cc: Ananth N Mavinakayanahalli ana...@in.ibm.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Ingo Molnar mi
From: Ananth N Mavinakayanahalli
Fix segfault in perf probe due to a bug introduced by commit d8639f068
(perf tools: Stop using 'self' in strlist).
Signed-off-by: Ananth N Mavinakayanahalli
---
Index: linus/tools/perf/util/strlist.c
1 - 100 of 378 matches
Mail list logo
