[PATCH] MAINTAINERS: mark FRAMEBUFFER LAYER as Orphan

It has been a fun ride since 2017 but unfortunately I don't have enough time to look after it properly anymore. Signed-off-by: Bartlomiej Zolnierkiewicz --- MAINTAINERS |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/MAINTAINERS

[PATCH] MAINTAINERS: remove LIBATA PATA DRIVERS entry

Even though there is not much happening for libata PATA drivers I don't have time to look after them anymore. Since Jens is maintaining the whole libata anyway just remove "LIBATA PATA DRIVERS" entry. Signed-off-by: Bartlomiej Zolnierkiewicz --- MAINTAINERS |9 - 1 file

Re: [PATCH] fbdev: sm712fb: handle ioremap() errors in probe

d to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/fbdev/sm712fb.

Re: [PATCH] omapfb: fix spelling mistake "propert" -> "property"

On 8/5/20 12:28 PM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_err message. Fix it. > > Signed-off-by: Colin Ian King Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Sams

Re: [PATCH v3 00/12] video: fbdev: use generic power management

drivers/video/fbdev/vt8623fb.c | 41 ++--- > include/linux/via-core.h | 2 - > 17 files changed, 267 insertions(+), 256 deletions(-) Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH v4] video: fbdev: ssd1307fb: Added support to Column offset

, 7 insertions(+), 2 deletions(-) >> > > Acked-by: Rob Herring Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error

lated code. Very > little is now left.") > Signed-off-by: Colin Ian King Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/vga16fb.c | 14 +++---

Re: [PATCH] video: fbdev: sis: fix null ptr dereference

gt; queuedata is not set in the else block > > Reviewing the old code, the arrays FQBQData730 and FQBQData were > used directly. > > So hoist the setting of queuedata out of the if-else block. > > Fixes: 544393fe584d ("[PATCH] sisfb update") > > Signed-off-by:

Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings

@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > + return scnprintf(buf, PAGE_SIZE, "%d\n", blink); ditto for blink val > } > > static ssize_t store_cursor_blink(struct device *device, > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

t; CC: Denis Efremov > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > > tree: https://git.kernel.org/pub/scm/linu

Re: [PATCH] video: fbdev: replace spurious snprintf() with sprintf()

On 8/24/20 7:44 PM, Alex Dewar wrote: > par->vgapass is a u8, so if we are assuming that buf is at least > PAGE_SIZE then the extra checking is pointless. > > Signed-off-by: Alex Dewar Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH 22/29] video: fbdev: Avoid comma separated statements

On 8/25/20 6:56 AM, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/tgafb.c | 12 ++

Re: [PATCH] docs: fb: Correcting the location of FRAMEBUFFER_CONSOLE option.

Device Drivers->Graphics Support-> > Console display driver support->Framebuffer Console Support. > > Correcting it in the docs. > > Signed-off-by: Bilal Wasim Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Polan

Re: [PATCH v2] lib/fonts: add font 6x8 for OLED display

ven Schneider >> Signed-off-by: Sascha Hauer > > Reviewed-by: Greg Kroah-Hartman Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] video: fbdev: remove set but not used 'ulCoreClock'

’ set but not used [-Wunused-but-set-variable] // yanaijie > fixed > 247 | u32 ulCoreClock; > | ^~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institut

Re: [PATCH] video: fbdev: remove set but not used 'ulBestVCO'

’ set but not used [-Wunused-but-set-variable] > 123 | u32 ulBestVCO = 0, ulBestClk = 0, ulBestScore = 0; > | ^ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sam

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

gt; video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container > fbdev: radeonfb:use generic power management > > drivers/video/fbdev/aty/radeon_base.c | 10 --- > drivers/video/fbdev/aty/radeon_pm.c | 38 --- > drivers/video/fbdev/aty/radeonfb.h| 3 +-- > 3 files changed, 35 insertions(+), 16 deletions(-) Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH] fbdev: remove mbx framebuffer driver

ere is no > point to keep the obsolete framebuffer driver. > > Signed-off-by: Mike Rapoport Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > .../userspace-api/ioctl/ioctl-number.rst

Re: [PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register

eon_kick_out_firmware_fb(pdev); >> if (ret) >> - return ret; >> + goto err_release_fb; > > Good catch ! Thanks > > Reviewed-by: Mathieu Malaterre Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH v2 00/41] spi / fbdev / cpufreq / usb / mmc / hwmon / ARM: Prepare for multiplatform S3C

ist/?series=185855=* >> > > Hi All, Hi Krzysztof, > I applied second part of the set which finishes this step of S3C > cleanup. Thanks to Arnd for the work! Thank you (& Arnd) for working on this! PS I've checked fbdev related changes now and they all look good to me. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > Best regards, > Krzysztof

Re: [PATCH] video: fbdev: controlfb: Fix build for COMPILE_TEST=y && PPC_PMAC=n

pport") > Signed-off-by: Michael Ellerman Acked-by: Bartlomiej Zolnierkiewicz Thanks for fixing this. > --- > drivers/video/fbdev/controlfb.c | 2 ++ > 1 file changed, 2 insertions(+) > > Does anyone mind if I apply this via the powerpc tree for v5.9? > > It wo

Re: [PATCH] MAINTAINERS: enlist Greg formally for console stuff

dev maintainership > - lots of stuff in drivers/tty/vt, which is already under Greg's > maintainership. > > So I think this match gives reasonably useful Cc: lists for the files > and places I've tested. > > Cc: Bartlomiej Zolnierkiewicz > Cc: Greg KH > Cc: dri-d

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2017 I've tried to act as the last resort Maintainer for console stuff (AFAIK there are no "lost" patches) but it really deserves its own entry. Also most console patches make it through you nowadays anyway: $ git log --pretty=fuller --since=2017 drivers/video/console/|grep "Commit\:

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

wei.com/ and the patch is currently under review period (to give people chance to comment on it) and in my "to apply if no objections" folder. I see that your/Yunhai patch addresses the root source of the issue so I'll be happy to apply/ACK it instead of Yang's patch once the final version is pos

Re: [PATCH v2] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

ot;struct >>>> fbcon_ops"->clear_margins. >>>> from >>>> https://lkml.kernel.org/r/20200715015102.3814-1-penguin-ker...@i-love.sakura.ne.jp >>> >>> That should be taken by the fbdev maintainer, but I can take it too if >>> people want. >> >> Just missed this weeks pull request train and feeling like not worth >> making this an exception (it's been broken forever after all), so >> maybe best if you just add this to vt. >> >> Acked-by: Daniel Vetter >> >> Also this avoids the impression I know what's going on in fbdev code, >> maybe with sufficient abandon from my side someone will pop up who >> cares an fixes the bazillion of syzkaller issues we seem to have >> around console/vt and everything related. > > Great, will go queue it up now, thanks! Fine with me, thanks! PS I'll later queue the patch from George to drm-misc-next (after reading both fbdev patches in detail it seems that both are needed). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH v2 2/2] memory: samsung: exynos5422-dmc: Add module param to control IRQ mode

On 7/17/20 1:53 PM, Lukasz Luba wrote: > > > On 7/14/20 10:01 AM, Lukasz Luba wrote: >> Hi Bartek, >> >> On 7/14/20 8:42 AM, Bartlomiej Zolnierkiewicz wrote: >>> >>> Hi, >>> >>> On 7/10/20 9:11 PM, Lukasz Luba wrote: >>

Re: [PATCH v3 0/3] drivers: ide: use generic power management

On 7/14/20 9:52 AM, Vaibhav Gupta wrote: > On Tue, Jul 14, 2020 at 09:32:56AM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> Hi, >> >> On 7/13/20 7:36 PM, Vaibhav Gupta wrote: >>> Linux Kernel Mentee: Remove Legacy Power Management. >>> >>>

Re: [PATCH v2] efi: avoid error message when booting under Xen

287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when > mapping the FB") > Signed-off-by: Juergen Gross Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/efifb.c

Re: [PATCH v2 2/2] memory: samsung: exynos5422-dmc: Add module param to control IRQ mode

ould we leave the IRQ mode support in the dmc driver? What are the advantages over the polling mode? In what scenarios it should be used? [ If this is only for documentation purposes then it should be removed as it would stay in (easily accessible) git history anyway.. ] Best regards, -- Bart

Re: [PATCH v3 0/3] drivers: ide: use generic power management

gt; All patches are compile-tested only. This patchset needs (at least) some basic testing. It should be easier with libata subsystem as it also support SATA controllers and devices. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > v3: > - Modpost

Re: [PATCH] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

t; and somehow hit unexpectedly long bit_clear_margins() loops. I don't know > why syzbot does not hit general protection fault, but it would depend on > environment because in my VMware environment ioctl(FBIOPUT_VSCREENINFO) > returns -EINVAL if var.xres == var.yres == 0. > > [1]

Re: [PATCH] video: fbdev: vt8623fb: Constify static vga_regsets

623fb.o > > After: >textdata bss dec hex filename > 265336904 64 3350182dd drivers/video/fbdev/vt8623fb.o > > Signed-off-by: Rikard Falkeborn Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

Re: [PATCH] fbdev: sm712fb: set error code in probe

ication project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH] video: fbdev: neofb: fix memory leak in neo_scan_monitor()

xtesting.org). > > Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/neofb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH] omapfb: fix multiple reference count leaks due to pm_runtime_get_sync

. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +-- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 7 +-- > drivers/video/fbdev/omap2/omapfb/dss/dss.c | 7 +-- > dr

Re: [PATCH] fbdev: da8xx-fb: go to proper label on error handling paths in probe

kes fb_probe() to go to label err_release_fb on > corresponding error handling paths. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung

Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

applicable to stable 4.5+ while merging) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Linux 4.4 will need a similar patch, but it doesn't apply cleanly. > > The DRM version of this same fix is: > e2c4ed148cf3 ("drm/omap: fix

Re: [PATCH] video: fbdev: savage: fix memory leak on error handling path in probe

> Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/savage/savagefb_driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

lab.h:#include include/linux/vmalloc.h:#include so I've applied the patch as it is (hoping that the issue is so widespread that no-one tries to remove overflow.h from slab.h without fixing drivers at the same time).. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electro

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

-off-by: Gustavo A. R. Silva Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > include/linux/fb.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/lin

Re: [PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz > wrote: >> Since we lack the hardware (or proper emulator setup) for >> testing needed changes add FIXMEs to document the issues >> (so at least they are not forgo

Re: [PATCH][next] fbcon: Use array3_size() helper in scr_memcpyw()

le and, audited and fixed > manually. > > Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 > Signed-off-by: Gustavo A. R. Silva Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > dri

Re: [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset

n SEG2 and ends in SEG129. > > Signed-off-by: Rodrigo Alencar <455.rodrigo.alen...@gmail.com> Please resend with "From:" & "Signed-off-by:" tags fixed to match so I can merge the patch. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Sam

Re: [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz > wrote: >> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: >>> These #ifdefs are relics from APUS (Amiga Power-Up System), which >>> added a PPC board. APUS

Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold

o take it into his next/dt branch. >> >> In the cover letter you mentioned that this is a follow up for the >> Chanwoo's patchset. But are these patches really depending on it? Can >> they be picked up independently? > > > They are not heavily dependent on Chanwoo'

Re: [PATCH] vgacon: fix a UAF in do_update_region()

Hi, Please re-send adding the correct mailing lists: * dri-de...@lists.freedesktop.org * linux-fb...@vger.kernel.org to Cc: so the patch can be reviewed/merged. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics On 6/4/20 4:38 PM, Yang Yingliang wrote

Re: [PATCH -next] vgacon: Fix an out-of-bounds in vgacon_scrollback_update()

Hi, Please re-send adding the correct mailing lists: * dri-de...@lists.freedesktop.org * linux-fb...@vger.kernel.org to Cc: so the patch can be reviewed/merged. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics On 5/13/20 4:28 AM, Yang Yingliang

Re: [PATCH] efi: avoid error message when booting under Xen

t;>>   if ((efifb_fix.smem_start + efifb_fix.smem_len) > >>>       (md.phys_addr + (md.num_pages << EFI_PAGE_SHIFT))) { >>> >> > > In case I see no reaction from the maintainer for another week I'll take > this patch through the Xen tree. >From fbdev POV this change looks fine to me and I'm OK with merging it through Xen or EFI tree: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [RFC PATCH 0/2] PM / devfreq: Add delayed timer for polling

e (in some situations) but at the (unacceptable IMHO) cost of the correctness of operations of devfreq subsystem. ] Unfortunately this patchset currently fixes only exynos5422-dmc devfreq driver. To fix problems for Exynos platforms we need to also fix exynos-bus devfreq driver. Best regar

Re: brocken devfreq simple_ondemand for Odroid XU3/4?

, > +CC Bartek Hi Lukasz, As you remember in January Chanwoo has proposed another idea (to allow selecting workqueue type by devfreq device driver): "I'm developing the RFC patch and then I'll send it as soon as possible." (https://lore.kernel.org/linux-pm/6107fa2b-81ad-060d-89a2-d8941ac4d...@samsung.com/) "After posting my suggestion, we can discuss it" (https://lore.kernel.org/linux-pm/f5c5cd64-b72c-2802-f6ea-ab3d28483...@samsung.com/) so we have been waiting on the patch to be posted.. Similarly we have been waiting on (any) feedback for exynos-bus/nocp fixes for Exynos5422 support (which have been posted by Kamil also in January): https://lore.kernel.org/linux-pm/8f82d8d5-927b-afb4-272f-45c16b5a2...@samsung.com/ Considering the above and how hard it has been to push the changes through review/merge process last year we are near giving up when it comes to upstream devfreq contributions. Sylwester is still working on exynos-bus & interconnect integration (continuation of Artur Swigon's work from last year) & related issues (IRQ support for PPMU) but I'm seriously considering putting it all on-hold.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: include/linux/libata.h:1366:2: note: in expansion of macro '__ATA_BASE_SHT'

itialized field overwritten [-Woverride-init] .sdev_attrs = ahci_sdev_attrs ^ drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’ AHCI_SHT(DRV_NAME), ^ drivers/ata/ahci.h:388:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’) .sdev_attrs = ahci_sdev_attrs ^ drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’ AHCI_SHT(DRV_NAME), ^ Also it turns out that this is an old issue and not a regression introduced by commit 6f09eae3b5d974ef845e56690d6bc2b8f2a70acd ("ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts"). Anyway, it should be fixed by: https://lore.kernel.org/linux-ide/0d803e72-b15e-4673-4858-4741f2772...@samsung.com/ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

[PATCH] ata: fix AHCI_SHT() macro definition

), ^ Reported-by: kernel test robot Cc: Christoph Hellwig Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/ata/ahci.h |7 --- include/linux/libata.h |3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) Index: b/drivers/ata/ahci.h

Re: [PATCH v2] fbdev: geode: Add the missed pci_disable_device() in gx1fb_map_video_memory()

a/fbdev.c In order to bring back pci_disable_device() calls to gx1fb driver (and other affected ones) you should verify that the issue described in the above commit is no longer present (preferably with testing modified driver on a real hardware). Best regards, -- Bartlomiej Zolnierkiewicz Samsun

[PATCH v2] video: fbdev: uvesafb: fix "noblank" option handling

Fix the recent regression. Fixes: dbc7ece12a38 ("video: uvesafb: use true,false for bool variables") Cc: Jason Yan Reviewed-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - added Reviewed-by tag from Sam - removed no longer working Michal's email address from Cc:

[PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - rebased on top of updated patch #1/2 drivers/video

[PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

G_APUS. Add FIXME about using the C code variants (APUS ones) in the future. Reported-by: Al Viro Reported-by: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - added FIXME comment instead of removing the C code variants drivers/video/fbdev/amifb.c |6 ++ 1 fil

Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support

The only exception is the >> DIVUL() macro, which is used once during initialization, thus also not >> performance critical. > I see, thanks. Since the code in question is not performance critical it indeed seems to be good idea to use C version. However it still would need be tested on the hard

[PATCH 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/amifb.c |2 ++ 1 file changed, 2

[PATCH 1/2] video: fbdev: amifb: remove dead APUS support

CONFIG_APUS. Reported-by: Al Viro Reported-by: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/amifb.c | 63 1 file changed, 63 deletions(-) Index: b/drivers/video/f

Re: [PATCH] ata: return true in ata_is_host_link()

On 5/7/20 1:06 PM, Jason Yan wrote: > Fix the following coccicheck warning: > > include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function > 'ata_is_host_link' with return type bool > > Signed-off-by: Jason Yan Acked-by: Bartlomiej Zolnierkiewicz Best rega

Re: [PATCH] video: fbdev: pxafb: Use correct return value for pxafb_probe()

Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/pxafb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > index 00b96a7..423331

Re: [PATCH] omapfb/dss: fix comparison to bool warning

gt; Signed-off-by: Jason Yan Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 2 +- > drivers/video/fbdev/omap2/omapf

Re: [PATCH] video: pxafb: Fix the function used to balance a 'dma_alloc_coherent()' call

quot;[ARM] pxafb: allow video memory size to be > configurable") > Signed-off-by: Christophe JAILLET Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > driver

Re: [trivial PATCH] video: fbdev: Use IS_BUILTIN

. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/aty128fb.c | 6 +- > drivers/video/fbdev/aty/atyfb_base.c | 7 +-- > drivers/video/fbdev/aty/radeon_base.c | 6 +- > drivers/video/fbdev/nvidia/nvi

Re: [PATCH v3] console: newport_con: fix an issue about leak related system resources

d also > add release_mem_region() on device removal. > > Fixes: e86bb8acc0fdc ("[PATCH] VT binding: Make newport_con support binding") > Cc: Andy Shevchenko > Suggested-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Dejin Zheng Applied to drm-misc-next tree (patch should

Re: [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address

th fbdev") > CC: Andy Shevchenko > Signed-off-by: Dejin Zheng Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 2 ++ > 1 fil

Re: [PATCH] drivers/video: cleanup coding style in video a bit

On 4/27/20 10:05 AM, Bernard Zhao wrote: > Eliminate the magic numbers, add vender infoframe size macro > like other hdmi modules. > > Signed-off-by: Bernard Zhao Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH] video: uvesafb: use true,false for bool variables

nocrtc = true; > else if (!strcmp(this_opt, "noedid")) > - noedid = 1; > + noedid = true; > else if (!strcmp(this_opt, "noblank")) > - blank = 0; > +

Re: [PATCH] ata: omit superfluous error message

t be done automatically for device drivers which don't support deferred probing (i.e. pata_rb532_cf & sata_highbank). Unless there is a proof that -PROBE_DEFER can't happen for these two drivers this patch shouldn't be applied. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute P

Re: [PATCH 11/20] amifb: get rid of pointless access_ok() calls

On 5/14/20 4:07 PM, Al Viro wrote: > On Thu, May 14, 2020 at 03:45:09PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> Hi Al, >> >> On 5/10/20 1:45 AM, Al Viro wrote: >>> From: Al Viro >>> >>> addresses passed only to get_user() and put_us

Re: [PATCH 11/20] amifb: get rid of pointless access_ok() calls

return -EINVAL; > if (!var->height) > return -EINVAL; > - if (!access_ok(data, var->width * var->height)) > - return -EFAULT; > delta = 1 << fmode; > lofsprite = shfsprite = (u_short *)spritememory; > lspr = lofsprite + (delta << 1); > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 12/20] omapfb: get rid of pointless access_ok() calls

On 5/10/20 1:45 AM, Al Viro wrote: > From: Al Viro > > address is passed only to copy_to_user() > > Signed-off-by: Al Viro Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > driv

Re: [PATCH v10 3/3] tty: samsung_tty: 32-bit access for TX/RX hold registers

ewer SoCs? If not (i.e. this code is only to support Android GKI) then the code you are adding now may be removed at any time later during cleanups (due to lack of the in-kernel users). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > Signed-off-by

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

ect solution but at the cost of 2 ifdefs it allows controlfb driver to be compile tested on any arch. Being able to compile test fbdev device drivers is really useful for me and saves me a lot of time when doing fbdev maintainer duties. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Inst

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

On 4/29/20 1:54 PM, Sam Ravnborg wrote: > Hi Bartlomiej. > > On Wed, Apr 29, 2020 at 12:48:24PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> powerpc allyesconfig fails like this: >> >> drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': >>

Re: linux-next: build failure after merge of the drm-misc tree

On 4/29/20 10:09 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi Stephen, > > On 4/29/20 12:33 AM, Stephen Rothwell wrote: >> Hi all, >> >> On Mon, 20 Apr 2020 13:01:18 +1000 Stephen Rothwell >> wrote: >>> >>> After merging the drm-misc tr

[PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

adding missing PPC32 dependency. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Reported-by: kbuild test robot Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: fix implicit btext_update_di

Re: linux-next: build failure after merge of the drm-misc tree

ill appears to have not been addressed. Sorry for the delay, I've just posted a patch (also included below): "[PATCH] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n" which should fix it. Please verify it, thank you! Best regards, -- Bartlomiej Zo

[PATCH] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

adding missing PPC32 dependency. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Reported-by: kbuild test robot Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c |

Re: [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable()

On 10/8/19 5:48 PM, Mark Brown wrote: > On Tue, Oct 08, 2019 at 03:24:17PM +0200, Bartlomiej Zolnierkiewicz wrote: > >> Commit 7f93ff73f7c8 ("opp: core: add regulators enable and disable") >> currently can be safely reverted as all affected users use always-on

Re: [PATCH] regulator: core: Skip balancing of the enabled regulators in regulator_enable()

o functions: - one for setting constraints (before regulator_enable() operation) - the other one actually setting voltage (after enable operation) Unfortunately this is much bigger task and doesn't seem to be -rc time material so I'm in favor of just applying Marek's fix as it is for now. Best rega

Re: [PATCH v7] ata/pata_buddha: Probe via modalias instead of initcall

a_buddha_probe() by using ent->driver_data. > Support X-Surf via late_initcall() > > v3: Clean up devm_*, implement device removal. > > v2: Rename 'zdev' to 'z' to make the patch easy to analyse with > git diff --ignore-space-change > > Signed-off-by: Max Staud

Re: [PATCH v6] ata/pata_buddha: Probe via modalias instead of initcall

uppress_bind_attrs = true, I thought that we had agreed that this is not needed? With that fixed: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

On 8/21/19 2:16 PM, Krzysztof Kozlowski wrote: > On Wed, 21 Aug 2019 at 13:51, Bartlomiej Zolnierkiewicz > wrote: >>>>> Following this change, I am now seeing the above error on our Tegra >>>>> boards where this driver is enabled. This is triggering a kernel

Re: [PATCH v3 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API

s/soc/versatile/soc-realview.c > I'm also inclined to have it converted to a regular driver. We already > have "exynos-asv" driver matching on the chipid node (patch 3/9). > The ASV patches will not be merged soon anyway, all this needs some more > thought. Krzysztof, can we abandon the chipid patches for now? Your chipid driver is good and useful on its own. The preferred solution IMHO would be to just revert "soc: samsung: Convert exynos-chipid driver to use the regmap API" commit. > pull request doesn't appear to be merged to arm-soc yet. Sorry about > that. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall

On 8/20/19 6:42 PM, Max Staudt wrote: > Hi Bartlomiej, > > On 08/20/2019 02:06 PM, Bartlomiej Zolnierkiewicz wrote: >> WARNING: line over 80 characters >> #354: FILE: drivers/ata/pata_buddha.c:287: >> +while ((z = >> zorro_find_device(ZORRO_PR

Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall

On 8/20/19 5:59 PM, Max Staudt wrote: > Hi Bartlomiej, > > Thank you very much for your review! > > Question below. > > > On 08/20/2019 02:06 PM, Bartlomiej Zolnierkiewicz wrote: >>> + /* Workaround for X-Surf: Save drvdata in case zorro8390

Re: [PATCH 4/9] drivers: ata: ahci_xgene: use devm_platform_ioremap_resource()

ys prints an error on !res condition). > + if (IS_ERR(ctx->csr_mux)) { > + dev_info(>dev, "cant get ip mux resource (optional)"); No need for this message. > + ctx->csr_mux = NULL; > } > > of_devid = of_match_device(xgene_ahci_of_match, dev); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 3/9] drivers: ata: ahci_tegra: use devm_platform_ioremap_resource()

ource being optional we will get error message from devm_[platform_]ioremap_resource() (it always prints an error on !res condition). > + if (IS_ERR(tegra->sata_aux_regs)) { > + dev_info(>dev, "Cant get aux registers (optional)"); No need for this message. >

Re: [PATCH 9/9] drivers: ata: sata_rcar: use devm_platform_ioremap_resource()

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -

Re: [PATCH 8/9] drivers: ata: sata_gemini: use devm_platform_ioremap_resource()

nstead of -ENODEV) and print an error. > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/ata/sata_gemini.c | 7 +-- > 1 file changed,

Re: [PATCH 7/9] drivers: ata: sata_dwc_460ex: use devm_platform_ioremap_resource()

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -

Re: [PATCH 6/9] drivers: ata: pata_bk3710: use devm_platform_ioremap_resource()

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -

Re: [PATCH 5/9] drivers: ata: libahci_platform: use devm_platform_ioremap_resource()

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -

Re: [PATCH 2/9] drivers: ata: ahci_seattle: use devm_platform_ioremap_resource()

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -

Re: [PATCH 1/9] drivers: ata: ahci_octeon: use devm_platform_ioremap_resource()

On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote: > Use the new helper that wraps the calls to platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Enrico Weigelt, metux IT consult Acked-by: Bartlomiej Zolnierkiewicz Best regards, -

Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall

.driver = { .suppress_bind_attrs = true, }, to prevent the device from being unbinded (and thus ->remove called) from the driver using sysfs interface. > +}; > + Extra newline, please remove it. > + ditto > + > +/* > + * We cannot have a modalias for X-Surf bo

Re: [PATCH 6/7] efifb: Use PCI_STD_NUM_BARS in loops instead of PCI_STD_RESOURCE_END

On 8/11/19 5:08 PM, Denis Efremov wrote: > This patch refactors the loop condition scheme from > 'i <= PCI_STD_RESOURCE_END' to 'i < PCI_STD_NUM_BARS'. > > Signed-off-by: Denis Efremov Acked-by: Bartlomiej Zolnierkiewicz > --- > drivers/video/fbdev/efifb.c | 2

Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall

On 8/12/19 4:26 PM, Max Staudt wrote: > On 08/12/2019 02:15 PM, Bartlomiej Zolnierkiewicz wrote: >>> What's a good way to do that, given that we now have module_exit()> defined >>> and an exit function is void? >> >> What about something like t

Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall

On 8/12/19 12:55 PM, Max Staudt wrote: > Hi Bartlomiej, > > Thanks for your feedback! Hi Max, > On 08/12/2019 12:42 PM, Bartlomiej Zolnierkiewicz wrote: >> >> ide/buddha driver cannot be unloaded currently (it lacks module_exit()). >> >> [... snip ..

  1   2   3   4   5   6   7   8   9   10   >