Re: [PATCH 1/3] gpio: zynq: use module_platform_driver to simplify the code

2021-04-16 Thread Bartosz Golaszewski
On Wed, Apr 14, 2021 at 4:45 PM Srinivas Neeli wrote: > > HI baratosz and Andy, > It's Bartosz. You literally just need to copy & paste the name from my email... > > -Original Message- > > From: Bartosz Golaszewski > > Sent: Tuesday, April 13, 2021

Re: [PATCH] eeprom: at24: avoid adjusting offset for 24AA025E{48, 64}

2021-04-16 Thread Bartosz Golaszewski
On Tue, Apr 13, 2021 at 1:03 PM wrote: > > On 12.04.2021 21:29, Bartosz Golaszewski wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Apr 12, 2021 at 9:42 AM wrote: > >> > >>

Re: [PATCH v19 4/6] misc: eeprom: at24: check suspend status before disable regulator

2021-04-16 Thread Bartosz Golaszewski
lator_disable(at24->vcc_reg); > return -ENODEV; > } > > -- > 2.31.1.295.g9ea45b61b8-goog > Acked-by: Bartosz Golaszewski

[GIT PULL] gpio: fixes for v5.12-rc8

2021-04-15 Thread Bartosz Golaszewski
Linus, I waited until late with this non-urgent one hoping we'd get more fixes for this release cycle to go with it but nothing's coming up so please pull this single fix for an older problem with the sysfs interface. Bartosz The following changes since commit

Re: [PATCH 1/3] gpio: zynq: use module_platform_driver to simplify the code

2021-04-13 Thread Bartosz Golaszewski
On Sat, Apr 10, 2021 at 12:08 AM Andy Shevchenko wrote: > > > > On Friday, April 9, 2021, Srinivas Neeli wrote: >> >> module_platform_driver() makes the code simpler by eliminating >> boilerplate code. >> >> Signed-off-by: Srinivas Neeli >> --- >> drivers/gpio/gpio-zynq.c | 17

Re: [PATCH] gpio: mxs: remove useless function

2021-04-13 Thread Bartosz Golaszewski
On Mon, Apr 12, 2021 at 4:16 AM Jiapeng Chong wrote: > > Fix the following gcc warning: > > drivers/gpio/gpio-mxs.c:63:19: warning: kernel/sys_ni.cunused function > 'is_imx28_gpio'. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpio/gpio-mxs.c | 5 - > 1 file

Re: [PATCH v2 4/6] devres: handle zero size in devm_kmalloc()

2021-04-12 Thread Bartosz Golaszewski
On Sun, Apr 11, 2021 at 5:21 AM Dmitry Torokhov wrote: > > Hi Bartosz, > > On Mon, Jun 29, 2020 at 1:56 PM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > Make devm_kmalloc() behave similarly to non-managed kmalloc(): return > &

Re: [PATCH] eeprom: at24: avoid adjusting offset for 24AA025E{48, 64}

2021-04-12 Thread Bartosz Golaszewski
On Mon, Apr 12, 2021 at 9:42 AM wrote: > > On 07.04.2021 21:37, Bartosz Golaszewski wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Fri, Apr 2, 2021 at 3:24 PM Claudiu Beznea > > wrote:

Re: [PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
On Sat, Apr 10, 2021 at 2:07 PM Greg Kroah-Hartman wrote: > > On Sat, Apr 10, 2021 at 11:09:19AM +0200, Bartosz Golaszewski wrote: > > From: Andy Shevchenko > > > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > > see arch/arm/boot/d

[PATCH stable] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
piolib: generalize devprop_gpiochip_set_names() for device properties") Cc: sta...@vger.kernel.org Reported-by: Marek Vasut Reported-by: Roman Guskov Signed-off-by: Andy Shevchenko Tested-by: Marek Vasut Reviewed-by: Marek Vasut Signed-off-by: Bartosz Golaszewski --- Hi Greg, This patch somehow got lost

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-04-10 Thread Bartosz Golaszewski
On Sat, Apr 10, 2021 at 2:46 AM Marek Vasut wrote: > > On 3/15/21 6:04 PM, Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 6:49 PM Bartosz Golaszewski > > wrote: > >> > >> On Mon, Mar 15, 2021 at 3:34 PM Andy Shevchenko > >> wrote: > &g

Re: [PATCH] gpio: gpio-it87: remove unused code

2021-04-09 Thread Bartosz Golaszewski
On Tue, Apr 6, 2021 at 10:35 AM Simon Guinot wrote: > > On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote: > > Fix the following clang warning: > > > > drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw' > > [-Wunused-function]. > > > > Reported-by: Abaci Robot >

Re: [PATCH v2] gpio: gpio-104-dio-48e: Fixed coding style issues (revised)

2021-04-09 Thread Bartosz Golaszewski
On Thu, Apr 8, 2021 at 5:54 PM Barney Goette wrote: > > Fixed multiple bare uses of 'unsigned' without 'int'. > Fixed space around "*" operator. > Fixed function parameter alignment to opening parenthesis. > Reported by checkpatch. > > Signed-off-by: Barney Goette > Acked-by: William Breathitt

Re: [PATCH v4] gpio: mpc8xxx: Add ACPI support

2021-04-09 Thread Bartosz Golaszewski
On Thu, Apr 8, 2021 at 9:20 AM Linus Walleij wrote: > > On Tue, Apr 6, 2021 at 3:49 AM Ran Wang wrote: > > > Could this version be accepted, or any comment/suggestion? > > Andy says yes, then it is a yes :) > FWIW > Acked-by: Linus Walleij > > Yours, > Linus Walleij Applied, thanks! Bartosz

Re: [PATCH v1 1/1] gpio: sim: Initialize attribute allocated on the heap

2021-04-09 Thread Bartosz Golaszewski
On Thu, Apr 8, 2021 at 6:24 PM Andy Shevchenko wrote: > > The attributes on the heap must be initialized before use. > Neglecting that will produce an Oops in some configurations: > > BUG: key 000800eba398 has not been registered! > > Initialize attribute allocated on the heap. > > Fixes:

Re: [PATCH] eeprom: at24: avoid adjusting offset for 24AA025E{48, 64}

2021-04-07 Thread Bartosz Golaszewski
On Fri, Apr 2, 2021 at 3:24 PM Claudiu Beznea wrote: > > Some EEPROMs could be used only for MAC storage. In this case the > EEPROM areas where MACs resides could be modeled as NVMEM cells > (directly via DT bindings) such that the already available networking > infrastructure to read properly

Re: [PATCH 02/12] ARM: davinci: Constify the software nodes

2021-04-07 Thread Bartosz Golaszewski
ode can also be constant. > > > > Signed-off-by: Heikki Krogerus > > Cc: Sekhar Nori > > Cc: Bartosz Golaszewski > > I like to apply it soon. Can we get an ack, please? > Looks good to me. Acked-by: Bartosz Golaszewski

Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2021-04-01 Thread Bartosz Golaszewski
On Thu, Apr 1, 2021 at 1:16 PM Syed Nayyar Waris wrote: > > On Wed, Mar 31, 2021 at 8:56 PM Srinivas Neeli wrote: > > > > Hi, > > > > > -Original Message- > > > From: Bartosz Golaszewski > > > Sent: Friday, March 26, 2021 10:58 PM

Re: [PATCH RFC/RFT 1/1] misc: add simple logic analyzer using polling

2021-04-01 Thread Bartosz Golaszewski
On Thu, Apr 1, 2021 at 3:08 PM Linus Walleij wrote: > > On Tue, Mar 30, 2021 at 10:58 AM Wolfram Sang > wrote: > > > This is a simple logic analyzer using GPIO polling. It comes with a > > script to isolate a CPU for polling. While this is definately not a > > production level analyzer, it can

Re: [PATCH 1/3] docs: gpio: mockup: Fix parameter name

2021-03-31 Thread Bartosz Golaszewski
On Wed, Mar 31, 2021 at 2:53 PM Alexander Dahl wrote: > > Hello Andy, > > Am Wed, Mar 31, 2021 at 03:27:05PM +0300 schrieb Andy Shevchenko: > > On Mon, Mar 29, 2021 at 2:18 PM Alexander Dahl wrote: > > > > > > Module probing with the parameter documented yielded this in kernel log: > > > > > >

Re: [PATCH 1/2] gpio: sysfs: Obey valid_mask

2021-03-31 Thread Bartosz Golaszewski
On Wed, Mar 31, 2021 at 2:25 PM Andy Shevchenko wrote: > > On Wed, Mar 31, 2021 at 10:58 AM Bartosz Golaszewski > wrote: > > > > On Mon, Mar 29, 2021 at 1:41 PM Matti Vaittinen > > wrote: > > > > > > Do not allow exporting GPIOs which are

Re: [PATCH 2/2] gpiolib: Allow drivers to return EOPNOTSUPP from config

2021-03-31 Thread Bartosz Golaszewski
On Tue, Mar 30, 2021 at 6:32 AM Matti Vaittinen wrote: > > Morning Folks, > > On Mon, 2021-03-29 at 16:30 +0300, Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 03:20:07PM +0300, Matti Vaittinen wrote: > > > On Mon, 2021-03-29 at 14:59 +0300, Andy Shevchenko wrote: > > > > On Mon, Mar 29, 2021

Re: [PATCH 1/2] gpio: sysfs: Obey valid_mask

2021-03-31 Thread Bartosz Golaszewski
On Mon, Mar 29, 2021 at 1:41 PM Matti Vaittinen wrote: > > Do not allow exporting GPIOs which are set invalid > by the driver's valid mask. > > Fixes: 726cb3ba49692bdae6caff457755e7cdb432efa4 > > Signed-off-by: Matti Vaittinen > --- Applied, thanks! Bart

Re: [PATCH v6 0/2] Add Realtek Otto GPIO support

2021-03-31 Thread Bartosz Golaszewski
On Tue, Mar 30, 2021 at 7:48 PM Sander Vanheule wrote: > > Add support for the GPIO controller employed by Realtek in multiple series of > MIPS SoCs. These include the supported RTL838x and RTL839x. The register > layout > also matches the one found in the GPIO controller of other (Lexra-based)

Re: [PATCH 3/3] docs: kernel-parameters: Add gpio_mockup_named_lines

2021-03-31 Thread Bartosz Golaszewski
On Mon, Mar 29, 2021 at 1:17 PM Alexander Dahl wrote: > > Missing since introduced in the driver. > > Fixes: commit 8a68ea00a62e ("gpio: mockup: implement naming the lines") > Signed-off-by: Alexander Dahl > --- Applied, thanks! Bartosz

Re: [PATCH 2/3] docs: kernel-parameters: Move gpio-mockup for alphabetic order

2021-03-31 Thread Bartosz Golaszewski
On Mon, Mar 29, 2021 at 1:17 PM Alexander Dahl wrote: > > Fixes: commit 0f98dd1b27d2 ("gpio/mockup: add virtual gpio device") > Signed-off-by: Alexander Dahl > --- Applied, thanks! Bartosz

Re: [PATCH 1/3] docs: gpio: mockup: Fix parameter name

2021-03-31 Thread Bartosz Golaszewski
On Mon, Mar 29, 2021 at 1:17 PM Alexander Dahl wrote: > > Module probing with the parameter documented yielded this in kernel log: > > gpio_mockup: unknown parameter 'gpio_named_lines' ignored > > The parameter documented did not match the parameter actually > implemented with commit

[tip: irq/core] genirq/irq_sim: Shrink devm_irq_domain_create_sim()

2021-03-30 Thread tip-bot2 for Bartosz Golaszewski
The following commit has been merged into the irq/core branch of tip: Commit-ID: 883ccef355b910398b99dfaf96d40557479a7e9b Gitweb: https://git.kernel.org/tip/883ccef355b910398b99dfaf96d40557479a7e9b Author:Bartosz Golaszewski AuthorDate:Mon, 01 Mar 2021 15:26:59 +01:00

[tip: irq/core] genirq/irq_sim: Shrink devm_irq_domain_create_sim()

2021-03-29 Thread tip-bot2 for Bartosz Golaszewski
The following commit has been merged into the irq/core branch of tip: Commit-ID: e6d46eded43dacf6370a7ae70f927ef4692cfcab Gitweb: https://git.kernel.org/tip/e6d46eded43dacf6370a7ae70f927ef4692cfcab Author:Bartosz Golaszewski AuthorDate:Mon, 01 Mar 2021 15:26:59 +01:00

Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

2021-03-26 Thread Bartosz Golaszewski
p_set_value(). The code is now simpler > > to read and understand. Moreover, instead of looping for each bit > > in xgpio_set_multiple() function, now we can check each channel at > > a time and save cycles. > > > > Cc: Bartosz Golaszewski > > Cc: Michal Simek >

Re: [PATCH v2 10/17] gpio: support ROHM BD71815 GPOs

2021-03-26 Thread Bartosz Golaszewski
On Tue, Mar 23, 2021 at 10:57 AM Vaittinen, Matti wrote: > > > On Tue, 2021-01-19 at 12:07 +0100, Bartosz Golaszewski wrote: > > On Tue, Jan 19, 2021 at 8:23 AM Matti Vaittinen > > wrote: > > > Support GPO(s) found from ROHM BD71815 power management IC. The I

Re: [PATCH v5 00/11] gpio: implement the configfs testing module

2021-03-26 Thread Bartosz Golaszewski
On Thu, Mar 25, 2021 at 10:29 AM Linus Walleij wrote: > > On Mon, Mar 22, 2021 at 3:32 PM Bartosz Golaszewski wrote: > > > FYI The configfs patches from this series have been on the mailing > > list for months (long before the GPIO part) and have been re-sent > > seve

Re: [PATCH v9 02/22] gpio: regmap: set gpio_chip of_node

2021-03-26 Thread Bartosz Golaszewski
On Wed, Mar 24, 2021 at 9:19 AM Álvaro Fernández Rojas wrote: > > This is needed for properly registering GPIO regmap as a child of a regmap > pin controller. > > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Michael Walle > Reviewed-by: Andy Shevchenko >

Re: [PATCH v9 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP

2021-03-26 Thread Bartosz Golaszewski
quot;gpiolib: Introduce gpiochip_irqchip_add_domain()") > Suggested-by: Michael Walle > Signed-off-by: Álvaro Fernández Rojas > Reviewed-by: Linus Walleij > Reviewed-by: Michael Walle > --- Acked-by: Bartosz Golaszewski I suppose this will go through the pinctrl tree. Bartosz

Re: [PATCH RESEND 0/7] gpio-rockchip driver

2021-03-26 Thread Bartosz Golaszewski
On Wed, Mar 24, 2021 at 7:50 AM jay...@rock-chips.com wrote: > > I'm forget to send-to include Bartosz, I'll remember in next version > > -- > jay...@rock-chips.com > >Separate gpio driver from pinctrl driver, and support v2 controller. > > > >Jianqun Xu (7): > > pinctrl/rockchip:

Re: [PATCH] linux/gpio/driver.h: some edits for clarity

2021-03-26 Thread Bartosz Golaszewski
On Tue, Mar 23, 2021 at 11:19 PM Randy Dunlap wrote: > > Fix a few typos and some punctuation. > Also, change CONFIG_OF to CONFIG_OF_GPIO in one comment. > > Signed-off-by: Randy Dunlap > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: linux-g...@vger.k

Re: [PATCH] tools: gpio-utils: fix various kernel-doc warnings

2021-03-26 Thread Bartosz Golaszewski
xpecting prototype for doc(). Prototype was for > gpiotools_request_line() instead > gpio-utils.c:265: warning: Excess function parameter 'value' description in > 'gpiotools_sets' > gpio-utils.c:1: warning: 'gpiotools_request_lines' not found > > Signed-off-by: Randy Dunlap &g

Re: [PATCH v5 00/11] gpio: implement the configfs testing module

2021-03-22 Thread Bartosz Golaszewski
On Mon, Mar 15, 2021 at 10:14 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > This series adds a new GPIO testing module based on configfs committable items > and sysfs. The goal is to provide a testing driver that will be configurable > at runtime (won't

[GIT PULL] gpio: fixes for v5.12-rc4

2021-03-19 Thread Bartosz Golaszewski
Linus, Please pull the following two fixes for the GPIO subsystem. Both address issues in the core GPIO code. Best Regards, Bartosz Golaszewski The following changes since commit b41ba2ec54a70908067034f139aa23d0dd2985ce: gpiolib: Read "gpio-line-names" from a firmware node (2021-0

Re: [PATCH v1 1/1] gpio: mockup: Adjust documentation to the code

2021-03-16 Thread Bartosz Golaszewski
On Mon, Mar 15, 2021 at 5:59 PM Andy Shevchenko wrote: > > First of all one of the parameter missed 'mockup' in its name, > Second, the semantics of the integer pairs depends on the sign > of the base (the first value in the pair). > > Update documentation to reflect the real code behaviour. > >

Re: [RESEND PATCH] irq/irq_sim: shrink devm_irq_domain_create_sim()

2021-03-16 Thread Bartosz Golaszewski
On Mon, Mar 1, 2021 at 3:27 PM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > We don't have to use a custom devres structure if all we manage is a > single pointer - we can use devm_add_action_or_reset() for that and > shrink the code a bit. > > Signed-off

Re: [PATCH v1 1/1] gpio: mockup: Drop duplicate NULL check in gpio_mockup_unregister_pdevs()

2021-03-16 Thread Bartosz Golaszewski
On Mon, Mar 15, 2021 at 7:51 PM Andy Shevchenko wrote: > > Since platform_device_unregister() is NULL-aware, we don't need to duplicate > this check. Remove it and fold the rest of the code. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpio-mockup.c | 9 ++--- > 1 file changed, 2

Re: [PATCH v1 1/1] gpiolib: Assign fwnode to parent's if no primary one provided

2021-03-16 Thread Bartosz Golaszewski
ith the future > (for-next) code once it will be in upstream (v5.12-rcX). > > -- > With Best Regards, > Andy Shevchenko > > Tested-by: Bartosz Golaszewski Thanks for debugging this! Applied! Bartosz

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-15 Thread Bartosz Golaszewski
On Mon, Mar 15, 2021 at 3:34 PM Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 03:04:37PM +0100, Bartosz Golaszewski wrote: > > On Mon, Mar 15, 2021 at 1:50 PM Andy Shevchenko > > wrote: > > > > > > On Mon, Mar 15, 2021 at 12:16:26PM +0200, Andy Shevchenko

Re: [PATCH 5.10 081/290] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-15 Thread Bartosz Golaszewski
On Mon, Mar 15, 2021 at 4:01 PM Marek Vasut wrote: > > On 3/15/21 2:52 PM, gre...@linuxfoundation.org wrote: > > From: Greg Kroah-Hartman > > > > From: Andy Shevchenko > > > > commit b41ba2ec54a70908067034f139aa23d0dd2985ce upstream. > > > > On STM32MP1, the GPIO banks are subnodes of

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-15 Thread Bartosz Golaszewski
On Mon, Mar 15, 2021 at 1:50 PM Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 12:16:26PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 15, 2021 at 10:01:47AM +0100, Bartosz Golaszewski wrote: > > > On Fri, Mar 5, 2021 at 1:03 PM Andy Shevchenko > > > wrote:

[PATCH v5 10/11] selftests: gpio: add a helper for reading GPIO line names

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to read GPIO line names from the character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v5 11/11] selftests: gpio: add test cases for gpio-sim

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a set of tests for the new gpio-sim module. This is a pure shell test-suite and uses the helper programs available in the gpio selftests directory. These test-cases only test the functionalities exposed by the gpio-sim driver, not those handled by core gpiolib code

[PATCH v5 05/11] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The 'extern' keyword doesn't have any benefits in header files. Remove it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 115 - 1 file changed, 57 insertions(+), 58 deletions

[PATCH v5 08/11] gpio: sim: new testing module

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Implement a new, modern GPIO testing module controlled by configfs attributes instead of module parameters. The goal of this driver is to provide a replacement for gpio-mockup that will be easily extensible with new features and doesn't require reloading the module

[PATCH v5 06/11] lib: bitmap: order includes alphabetically

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: order the includes in bitmap source files alphabetically. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 4 ++-- lib/bitmap.c | 9 + 2 files changed, 7 insertions

[PATCH v5 09/11] selftests: gpio: provide a helper for reading chip info

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to retrieve chip properties from the GPIO character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v5 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc()

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide managed variants of bitmap_alloc() and bitmap_zalloc(). Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 8 lib/bitmap.c | 33 + 2 files changed, 41 insertions

[PATCH v5 02/11] configfs: use (1UL << bit) for internal flags

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: use the (1UL << bit) for flag definitions. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- fs/configfs/configfs_internal.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v5 01/11] configfs: increase the item name length

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 20 characters limit for item name is relatively small. Let's increase it to 32 to fit '04-committable-children' - a name we'll use in the sample code for committable items. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- include/linux/configfs.h | 2

[PATCH v5 00/11] gpio: implement the configfs testing module

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds a new GPIO testing module based on configfs committable items and sysfs. The goal is to provide a testing driver that will be configurable at runtime (won't need module reload) and easily extensible. The control over the attributes is also much more

[PATCH v5 04/11] samples: configfs: add a committable group

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add an example of using committable items to configfs samples. Each config item has two attributes: read-write 'storeme' which works similarly to other examples in this file and a read-only 'committed' attribute which changes its value between false and true depending

[PATCH v5 03/11] configfs: implement committable items

2021-03-15 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This implements configfs committable items. We mostly follow the documentation except that we extend config_group_ops with uncommit_item() callback for reverting the changes made by commit_item(). Each committable group has two sub-directories: pending and live. New

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-15 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 1:03 PM Andy Shevchenko wrote: > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for > pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c > and iterates over all of its DT subnodes

Re: [PATCH v6 0/6] gpiolib: switch to fwnode in the core

2021-03-12 Thread Bartosz Golaszewski
On Tue, Mar 9, 2021 at 10:37 AM Andy Shevchenko wrote: > > GPIO library uses of_node and fwnode in the core in non-unified way. > The series cleans this up and improves IRQ domain creation for non-OF cases > where currently the names of the domain are 'unknown'. > > This has been tested on Intel

Re: [PATCH v4 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc()

2021-03-12 Thread Bartosz Golaszewski
On Fri, Mar 12, 2021 at 12:40 PM Andy Shevchenko wrote: > > On Fri, Mar 12, 2021 at 10:56:56AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Provide managed variants of bitmap_alloc() and bitmap_zalloc(). > > Perhaps I missed your answer t

Re: [PATCH] gpio: mpc8xxx: Add ACPI support

2021-03-12 Thread Bartosz Golaszewski
On Fri, Mar 12, 2021 at 7:51 AM Ran Wang wrote: > > Current implementation only supports DT, now add ACPI support. > > Note that compared to device of 'fsl,qoriq-gpio', LS1028A and > LS1088A's GPIO have no extra programming, so simplify related checking. > > Signed-off-by: Ran Wang > --- >

[PATCH v4 11/11] selftests: gpio: add test cases for gpio-sim

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a set of tests for the new gpio-sim module. This is a pure shell test-suite and uses the helper programs available in the gpio selftests directory. These test-cases only test the functionalities exposed by the gpio-sim driver, not those handled by core gpiolib code

[PATCH v4 10/11] selftests: gpio: add a helper for reading GPIO line names

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to read GPIO line names from the character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v4 09/11] selftests: gpio: provide a helper for reading chip info

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to retrieve chip properties from the GPIO character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v4 06/11] lib: bitmap: order includes alphabetically

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: order the includes in bitmap source files alphabetically. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 4 ++-- lib/bitmap.c | 9 + 2 files changed, 7 insertions

[PATCH v4 08/11] gpio: sim: new testing module

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Implement a new, modern GPIO testing module controlled by configfs attributes instead of module parameters. The goal of this driver is to provide a replacement for gpio-mockup that will be easily extensible with new features and doesn't require reloading the module

[PATCH v4 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc()

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide managed variants of bitmap_alloc() and bitmap_zalloc(). Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 8 lib/bitmap.c | 33 + 2 files changed, 41 insertions

[PATCH v4 04/11] samples: configfs: add a committable group

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add an example of using committable items to configfs samples. Each config item has two attributes: read-write 'storeme' which works similarly to other examples in this file and a read-only 'committed' attribute which changes its value between false and true depending

[PATCH v4 03/11] configfs: implement committable items

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This implements configfs committable items. We mostly follow the documentation except that we extend config_group_ops with uncommit_item() callback for reverting the changes made by commit_item(). Each committable group has two sub-directories: pending and live. New

[PATCH v4 05/11] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The 'extern' keyword doesn't have any benefits in header files. Remove it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 115 - 1 file changed, 57 insertions(+), 58 deletions

[PATCH v4 02/11] configfs: use (1UL << bit) for internal flags

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: use the (1UL << bit) for flag definitions. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- fs/configfs/configfs_internal.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v4 01/11] configfs: increase the item name length

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 20 characters limit for item name is relatively small. Let's increase it to 32 to fit '04-committable-children' - a name we'll use in the sample code for committable items. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- include/linux/configfs.h | 2

[PATCH v4 00/11] gpio: implement the configfs testing module

2021-03-12 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds a new GPIO testing module based on configfs committable items and sysfs. The goal is to provide a testing driver that will be configurable at runtime (won't need module reload) and easily extensible. The control over the attributes is also much more

Re: [PATCH v3 08/11] gpio: sim: new testing module

2021-03-12 Thread Bartosz Golaszewski
On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko wrote: > [snip] > > + > > +static ssize_t gpio_sim_sysfs_line_show(struct device *dev, > > + struct device_attribute *attr, > > + char *buf) > > +{ > > + struct

[PATCH v3 11/11] selftests: gpio: add test cases for gpio-sim

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a set of tests for the new gpio-sim module. This is a pure shell test-suite and uses the helper programs available in the gpio selftests directory. These test-cases only test the functionalities exposed by the gpio-sim driver, not those handled by core gpiolib code

[PATCH v3 10/11] selftests: gpio: add a helper for reading GPIO line names

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to read GPIO line names from the character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v3 09/11] selftests: gpio: provide a helper for reading chip info

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a simple program that allows to retrieve chip properties from the GPIO character device. This will be used in gpio-sim selftests. Signed-off-by: Bartosz Golaszewski --- tools/testing/selftests/gpio/.gitignore | 1 + tools/testing/selftests/gpio/Makefile

[PATCH v3 08/11] gpio: sim: new testing module

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Implement a new, modern GPIO testing module controlled by configfs attributes instead of module parameters. The goal of this driver is to provide a replacement for gpio-mockup that will be easily extensible with new features and doesn't require reloading the module

[PATCH v3 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc()

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide managed variants of bitmap_alloc() and bitmap_zalloc(). Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 8 lib/bitmap.c | 33 + 2 files changed, 41 insertions

[PATCH v3 06/11] lib: bitmap: order includes alphabetically

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: order the includes in bitmap source files alphabetically. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 4 ++-- lib/bitmap.c | 9 + 2 files changed, 7 insertions

[PATCH v3 05/11] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The 'extern' keyword doesn't have any benefits in header files. Remove it. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko --- include/linux/bitmap.h | 115 - 1 file changed, 57 insertions(+), 58 deletions

[PATCH v3 01/11] configfs: increase the item name length

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski 20 characters limit for item name is relatively small. Let's increase it to 32 to fit '04-committable-children' - a name we'll use in the sample code for committable items. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- include/linux/configfs.h | 2

[PATCH v3 04/11] samples: configfs: add a committable group

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add an example of using committable items to configfs samples. Each config item has two attributes: read-write 'storeme' which works similarly to other examples in this file and a read-only 'committed' attribute which changes its value between false and true depending

[PATCH v3 02/11] configfs: use (1UL << bit) for internal flags

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski For better readability and maintenance: use the (1UL << bit) for flag definitions. Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij --- fs/configfs/configfs_internal.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v3 03/11] configfs: implement committable items

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This implements configfs committable items. We mostly follow the documentation except that we extend config_group_ops with uncommit_item() callback for reverting the changes made by commit_item(). Each committable group has two sub-directories: pending and live. New

[PATCH v3 00/11] gpio: implement the configfs testing module

2021-03-09 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series adds a new GPIO testing module based on configfs committable items and sysfs. The goal is to provide a testing driver that will be configurable at runtime (won't need module reload) and easily extensible. The control over the attributes is also much more

Re: [GIT PULL] gpio: fixes for v5.12-rc3

2021-03-09 Thread Bartosz Golaszewski
On Tue, Mar 9, 2021 at 4:34 PM Bartosz Golaszewski wrote: > > Linus, > > Here's a bunch of fixes for the GPIO subsystem. We have two regressions in the > core code spotted right after the merge window, a series of fixes for ACPI > GPIO > and a subsequent fix for a relat

[GIT PULL] gpio: fixes for v5.12-rc3

2021-03-09 Thread Bartosz Golaszewski
-line-names to remedy a regression in stm32mp151. Please pull! Best Regards, Bartosz Golaszewski The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux

Re: [PATCH v2 05/12] lib: bitmap: remove the 'extern' keyword from function declarations

2021-03-09 Thread Bartosz Golaszewski
On Thu, Mar 4, 2021 at 1:59 PM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 11:24:45AM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The 'extern' keyword doesn't have any benefits in header files. Remove it. > > Reviewed-by: Andy Shev

Re: [PATCH v3 0/5] gpiolib: switch to fwnode in the core

2021-03-09 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 8:52 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 09:36:52PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 08:29:27PM +0100, Bartosz Golaszewski wrote: > > > On Mon, Mar 8, 2021 at 8:26 PM Rafael J. Wysocki > > > wrot

Re: [PATCH v3 0/5] gpiolib: switch to fwnode in the core

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 8:26 PM Rafael J. Wysocki wrote: > > On Mon, Mar 8, 2021 at 8:23 PM Bartosz Golaszewski > wrote: > > > > On Mon, Mar 8, 2021 at 7:22 PM Rafael J. Wysocki wrote: > > > > > > On Thu, Mar 4, 2021 at 9:13 PM Andy Shevchenko > >

Re: [PATCH v3 0/5] gpiolib: switch to fwnode in the core

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 7:22 PM Rafael J. Wysocki wrote: > > On Thu, Mar 4, 2021 at 9:13 PM Andy Shevchenko > wrote: > > > > GPIO library uses of_node and fwnode in the core in non-unified way. > > The series cleans this up and improves IRQ domain creation for non-OF cases > > where currently the

Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

2021-03-08 Thread Bartosz Golaszewski
On Thu, Mar 4, 2021 at 12:01 PM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote: > > On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko > > wrote: > > > At least one module will benefit from using next_arg() helper. > > > Let's export it for that module

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 4:32 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 04:13:33PM +0100, Bartosz Golaszewski wrote: > > On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko > > wrote: > > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote: &g

Re: [PATCH] docs: driver-api: gpio: consumer: Mark another line of code as such

2021-03-08 Thread Bartosz Golaszewski
On Wed, Mar 3, 2021 at 9:43 PM Jonathan Neuschäfer wrote: > > Make it so that this #include line is rendered in monospace, like other > code blocks. > > Signed-off-by: Jonathan Neuschäfer > --- > Documentation/driver-api/gpio/consumer.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 4:05 PM Andy Shevchenko wrote: > > On Mon, Mar 08, 2021 at 03:23:31PM +0100, Bartosz Golaszewski wrote: > > On Fri, Mar 5, 2021 at 11:15 AM Andy Shevchenko > > wrote: > > > On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote:

Re: [PATCH 1/3] mfd: lp87565: fix typo in define names

2021-03-08 Thread Bartosz Golaszewski
On Fri, Feb 19, 2021 at 11:39 PM Luca Ceresoli wrote: > > "GOIO" should be "GPIO" here. > > Signed-off-by: Luca Ceresoli > --- For GPIO part: Acked-by: Bartosz Golaszewski

Re: [PATCH v2 09/12] gpio: sim: new testing module

2021-03-08 Thread Bartosz Golaszewski
On Fri, Mar 5, 2021 at 11:15 AM Andy Shevchenko wrote: > > On Thu, Mar 04, 2021 at 09:15:29PM +0100, Bartosz Golaszewski wrote: > > On Thu, Mar 4, 2021 at 2:15 PM Andy Shevchenko > > wrote: > > > On Thu, Mar 04, 2021 at 11:24:49AM +0100, Bartosz Golaszewski w

Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

2021-03-08 Thread Bartosz Golaszewski
On Mon, Mar 8, 2021 at 12:45 PM Andy Shevchenko wrote: > > On Sun, Mar 07, 2021 at 06:14:49PM +0200, Andy Shevchenko wrote: > > On Sun, Mar 7, 2021 at 4:22 PM Bartosz Golaszewski > > wrote: > > > On Fri, Mar 5, 2021 at 1:02 PM Andy Shevchenko > > > wrote: &

  1   2   3   4   5   6   7   8   9   10   >