Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2021-03-22 Thread Ben Greear
On 3/22/21 6:20 PM, Brian Norris wrote: On Mon, Mar 22, 2021 at 4:58 PM Ben Greear wrote: On 7/22/20 6:00 AM, Felix Fietkau wrote: On 2020-07-22 14:55, Johannes Berg wrote: On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: I'm considering testing a different approach (with mt76

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2021-03-22 Thread Ben Greear
realized I'm running Felix's patch since his mt76 driver needs it. Any chance it will go upstream? Thanks, Ben - Felix -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Ben Greear
On 12/17/20 2:24 PM, Brian Norris wrote: On Tue, Dec 15, 2020 at 10:23:33AM -0800, Ben Greear wrote: On 12/15/20 9:21 AM, Youghandhar Chintala wrote: From: Rakesh Pillai Currently in case of target hardware restart ,we just reconfig and re-enable the security keys and enable the network

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-15 Thread Ben Greear
/drivers that *can* support seamless restarts? If not, then just could always enable this feature in mac80211? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

BUG: Invalid wait context, related to serial console?

2020-09-22 Thread Ben Greear
4/0xb0 [2.531065] #2 [0.624831] __common_interrupt: 2.55 No irq handler for vector [2.542389] #3 [0.624831] __common_interrupt: 3.55 No irq handler for vector Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: Build failure for today's tree, Fedora-32

2020-09-21 Thread Ben Greear
On 9/21/20 12:50 PM, Ben Greear wrote: Hello, I'm seeing this build failure, any idea what is the issue?  I've cleared my ccache (ccache --clear) but that did not help.  A pull from this morning builds on Fedora-29 with same .config file.  I tried that same commit on my F32 system

Build failure for today's tree, Fedora-32

2020-09-21 Thread Ben Greear
nus/Makefile:1198: prepare0] Error 2 make: *** [/home/greearb/git/linux-linus/Makefile:185: __sub-make] Error 2 Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v2 1/3] ath10k: Add history for tracking certain events

2020-07-31 Thread Ben Greear
er debug compiled in) since it seems this stuff would be rarely used and it adds method calls to hot paths. That is a decision for Kalle though, so see what he says... Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] ath10k: Add history for tracking certain events

2020-06-28 Thread Ben Greear
On 06/27/2020 10:12 PM, Rakesh Pillai wrote: -Original Message- From: Ben Greear Sent: Saturday, June 27, 2020 8:58 PM To: Rakesh Pillai ; ath...@lists.infradead.org Cc: linux-wirel...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath10k: Add history

Re: [PATCH] ath10k: Add history for tracking certain events

2020-06-27 Thread Ben Greear
Enable - IRQ Disable - NAPI poll - CE service - WMI cmd - WMI event - WMI tx completion This will help in debugging any crash or any improper behaviour. -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 2/2] ath10k: Skip wait for delete response if firmware is down

2020-06-26 Thread Ben Greear
test_bit(ATH10K_FLAG_CRASH_FLUSH, >dev_flags)) { Don't you mean !test_bit(ATH10K_FLAG_CRASH_FLUSH, >dev_flags)) ??? Or maybe I'm just mis-reading your patch? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH v3 0/8] kernel: taint when the driver firmware crashes

2020-05-28 Thread Ben Greear
program to allow automatic reboot of the system soon after this event is seen, for instance. Could you post your devlink RFC patches somewhere public? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [RFC 1/2] devlink: add simple fw crash helpers

2020-05-25 Thread Ben Greear
experience with ath10k-ct, the OS normally recovers fine from firmware crashes. ath10k already reports full crash reports on udev, so easy for user-space to notice and report bug reports upstream if it cares to. Probably other NICs do the same, and if not, they certainly could. Thanks, Ben -- Ben Greea

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Ben Greear
On 05/18/2020 10:09 AM, Luis Chamberlain wrote: On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote: On 05/18/2020 09:51 AM, Luis Chamberlain wrote: On Sat, May 16, 2020 at 03:24:01PM +0200, Johannes Berg wrote: On Fri, 2020-05-15 at 21:28 +, Luis Chamberlain wrote

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-18 Thread Ben Greear
sten for udev events (I think that is the right term), and find crashes that way. You get the actual crash info as well. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] ath10k: increase rx buffer size to 2048

2020-04-28 Thread Ben Greear
similarly. Seems like upstream ath10k could really benefit from having some test beds so you can actually test code on different chips and have confidence in your changes! Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: WARNING at net/mac80211/sta_info.c:1057 (__sta_info_destroy_part2())

2019-09-11 Thread Ben Greear
On 09/11/2019 06:21 AM, Linus Torvalds wrote: On Wed, Sep 11, 2019 at 2:03 PM Ben Greear wrote: Out of curiosity, I'm interested to know what ath10k NIC chipset this is from. It's a Dell XPS 13 9380, with 02:00.0 Network controller: Qualcomm Atheros QCA6174 802.11ac Wireless Network

Re: WARNING at net/mac80211/sta_info.c:1057 (__sta_info_destroy_part2())

2019-09-11 Thread Ben Greear
10k firmware crashes, but it seems to not be a big deal and the system normally recovers fine. Out of curiosity, I'm interested to know what ath10k NIC chipset this is from. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] x86/speculation: Add document to describe Spectre and its mitigations

2019-01-08 Thread Ben Greear
On 1/7/19 9:57 AM, Tim Chen wrote: On 12/31/18 8:22 AM, Ben Greear wrote: On 12/21/2018 05:17 PM, Tim Chen wrote: If you don't worry about security and performance is paramount, then boot with "nospectre_v2".  That's explained in the document. There seem to be lots of differen

Re: [PATCH] x86/speculation: Add document to describe Spectre and its mitigations

2018-12-31 Thread Ben Greear
On 12/21/2018 05:17 PM, Tim Chen wrote: On 12/21/18 1:59 PM, Ben Greear wrote: On 12/21/18 9:44 AM, Tim Chen wrote: Thomas, Andi and I have made an update to our draft of the Spectre admin guide. We may be out on Christmas vacation for a while. But we want to send it out for everyone

Re: [PATCH] x86/speculation: Add document to describe Spectre and its mitigations

2018-12-21 Thread Ben Greear
anything beyond negligible performance impact for those running systems where performance is more important than security? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: Oops on the system startup in the function part_in_flight()

2018-05-04 Thread Ben Greear
is no longer valid. Can someone let me know what patch fixes this crash so I can apply it while bisecting? https://www.spinics.net/lists/linux-block/msg17809.html Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: Oops on the system startup in the function part_in_flight()

2018-05-04 Thread Ben Greear
is no longer valid. Can someone let me know what patch fixes this crash so I can apply it while bisecting? https://www.spinics.net/lists/linux-block/msg17809.html Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

2018-03-20 Thread Ben Greear
hat might be something to consider. Right now I don't see the point of handling packets that don't cross network namespace boundaries specially, other than to preserve backwards compatibility. Well, backwards compat is a big deal all by itself! Thanks, Ben Eric -- Ben Greear <gree...@can

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

2018-03-20 Thread Ben Greear
hat might be something to consider. Right now I don't see the point of handling packets that don't cross network namespace boundaries specially, other than to preserve backwards compatibility. Well, backwards compat is a big deal all by itself! Thanks, Ben Eric -- Ben Greear Candela Technol

Re: [PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread Ben Greear
allow someone to call napi_disable multiple times w/out deadlocking. Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: [PATCH net] virtio-net: disable NAPI only when enabled during XDP set

2018-02-28 Thread Ben Greear
eadlocking. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-10 Thread Ben Greear
On 02/09/2017 11:03 PM, Valo, Kalle wrote: Ben Greear <gree...@candelatech.com> writes: On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd <adr...@freebsd.org> writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-10 Thread Ben Greear
On 02/09/2017 11:03 PM, Valo, Kalle wrote: Ben Greear writes: On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd li

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-07 Thread Ben Greear
it more difficult for Adrian and makes the code no easier to read for the rest of us? Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

2017-02-07 Thread Ben Greear
rian and makes the code no easier to read for the rest of us? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-19 Thread Ben Greear
actually expect performance regressions? I'll be complaining if so, but will test first :) Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-19 Thread Ben Greear
egressions? I'll be complaining if so, but will test first :) Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: Question on kzalloc and GFP_DMA32

2016-09-28 Thread Ben Greear
On 09/28/2016 02:11 PM, David Rientjes wrote: On Tue, 27 Sep 2016, Ben Greear wrote: I have been running this patch for a while: ath10k: Use GPF_DMA32 for firmware swap memory. This fixes OS crash when using QCA 9984 NIC on x86-64 system without vt-d enabled. Also tested

Re: Question on kzalloc and GFP_DMA32

2016-09-28 Thread Ben Greear
On 09/28/2016 02:11 PM, David Rientjes wrote: On Tue, 27 Sep 2016, Ben Greear wrote: I have been running this patch for a while: ath10k: Use GPF_DMA32 for firmware swap memory. This fixes OS crash when using QCA 9984 NIC on x86-64 system without vt-d enabled. Also tested

Question on kzalloc and GFP_DMA32

2016-09-27 Thread Ben Greear
. Signed-off-by: Ben Greear <gree...@candelatech.com> drivers/net/wireless/ath/ath10k/wmi.c index e20aa39..727b3aa 100644 @@ -4491,7 +4491,7 @@ static int ath10k_wmi_alloc_chunk(struct ath10k *ar, u32 req_id, if (!poo

Question on kzalloc and GFP_DMA32

2016-09-27 Thread Ben Greear
. Signed-off-by: Ben Greear drivers/net/wireless/ath/ath10k/wmi.c index e20aa39..727b3aa 100644 @@ -4491,7 +4491,7 @@ static int ath10k_wmi_alloc_chunk(struct ath10k *ar, u32 req_id, if (!pool_size) return -EINVAL

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

2016-06-08 Thread Ben Greear
to that source. Why are you so concerned about the warning anyway? Thanks, Ben On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear <gree...@candelatech.com> wrote: On 06/08/2016 08:46 AM, Prasun Maiti wrote: Please tell me if I mention that this code is untested in commit log, then could you

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

2016-06-08 Thread Ben Greear
to that source. Why are you so concerned about the warning anyway? Thanks, Ben On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear wrote: On 06/08/2016 08:46 AM, Prasun Maiti wrote: Please tell me if I mention that this code is untested in commit log, then could you check the code kindly and also help

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

2016-06-08 Thread Ben Greear
some special cases it might be ok to send untested code but even then it needs to be clearly stated in the commit log that it's untested. Please resend once you have tested this, I'm dropping this now. -- Kalle Valo -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

2016-06-08 Thread Ben Greear
en then it needs to be clearly stated in the commit log that it's untested. Please resend once you have tested this, I'm dropping this now. -- Kalle Valo -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 3.2 085/115] veth: don???t modify ip_summed; doing so treats packets with bad checksums as good.

2016-05-13 Thread Ben Greear
On 05/13/2016 11:21 AM, David Miller wrote: From: Ben Greear <gree...@candelatech.com> Date: Fri, 13 May 2016 09:57:19 -0700 How do you feel about a new socket-option to allow a socket to request the old veth behaviour? I depend upon the opinions of the experts who work up

Re: [PATCH 3.2 085/115] veth: don???t modify ip_summed; doing so treats packets with bad checksums as good.

2016-05-13 Thread Ben Greear
On 05/13/2016 11:21 AM, David Miller wrote: From: Ben Greear Date: Fri, 13 May 2016 09:57:19 -0700 How do you feel about a new socket-option to allow a socket to request the old veth behaviour? I depend upon the opinions of the experts who work upstream on and maintain these components

Re: [PATCH 3.2 085/115] veth: don???t modify ip_summed; doing so treats packets with bad checksums as good.

2016-05-13 Thread Ben Greear
Mr Miller: How do you feel about a new socket-option to allow a socket to request the old veth behaviour? Thanks, Ben On 04/30/2016 10:30 PM, Willy Tarreau wrote: On Sat, Apr 30, 2016 at 03:43:51PM -0700, Ben Greear wrote: On 04/30/2016 03:01 PM, Vijay Pandurangan wrote: Consider: - App

Re: [PATCH 3.2 085/115] veth: don???t modify ip_summed; doing so treats packets with bad checksums as good.

2016-05-13 Thread Ben Greear
Mr Miller: How do you feel about a new socket-option to allow a socket to request the old veth behaviour? Thanks, Ben On 04/30/2016 10:30 PM, Willy Tarreau wrote: On Sat, Apr 30, 2016 at 03:43:51PM -0700, Ben Greear wrote: On 04/30/2016 03:01 PM, Vijay Pandurangan wrote: Consider: - App

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
On 04/30/2016 03:01 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 5:52 PM, Ben Greear <gree...@candelatech.com> wrote: Good point, so if you had: eth0 <-> raw <-> user space-bridge <-> raw <-> vethA <-> veth B <-> userspace-stub <->

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
On 04/30/2016 03:01 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 5:52 PM, Ben Greear wrote: Good point, so if you had: eth0 <-> raw <-> user space-bridge <-> raw <-> vethA <-> veth B <-> userspace-stub <->eth1 and user-space hub enabled

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
On 04/30/2016 02:36 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 5:29 PM, Ben Greear <gree...@candelatech.com> wrote: On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear <gree...@candelatech.com> wrote: On 04/30/2016 1

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
On 04/30/2016 02:36 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 5:29 PM, Ben Greear wrote: On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear wrote: On 04/30/2016 12:54 PM, Tom Herbert wrote: We've put considerable effort

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear <gree...@candelatech.com> wrote: On 04/30/2016 12:54 PM, Tom Herbert wrote: We've put considerable effort into cleaning up the checksum interface to make it as unambiguous as possible,

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear wrote: On 04/30/2016 12:54 PM, Tom Herbert wrote: We've put considerable effort into cleaning up the checksum interface to make it as unambiguous as possible, please be very careful to follow

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
want to send raw frames that do have broken checksums (lets assume a real NIC, not veth), and I want them to hit the wire with those bad checksums. How do I configure the checksumming in this case? Thanks, Ben Tom On Sat, Apr 30, 2016 at 12:40 PM, Ben Greear <gree...@candelatech.com>

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
want to send raw frames that do have broken checksums (lets assume a real NIC, not veth), and I want them to hit the wire with those bad checksums. How do I configure the checksumming in this case? Thanks, Ben Tom On Sat, Apr 30, 2016 at 12:40 PM, Ben Greear wrote: On 04/30/2016 11:33

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
programs would be sufficient I think. Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Ben Greear
programs would be sufficient I think. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-28 Thread Ben Greear
On 04/28/2016 03:29 AM, Sabrina Dubroca wrote: Hello, 2016-04-27, 17:14:44 -0700, Ben Greear wrote: On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote: Hi Ben, On Wed, Apr 27, 2016, at 20:07, Ben Hutchings wrote: On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote: On 04/26/2016 04:02 PM

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-28 Thread Ben Greear
On 04/28/2016 03:29 AM, Sabrina Dubroca wrote: Hello, 2016-04-27, 17:14:44 -0700, Ben Greear wrote: On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote: Hi Ben, On Wed, Apr 27, 2016, at 20:07, Ben Hutchings wrote: On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote: On 04/26/2016 04:02 PM

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-27 Thread Ben Greear
On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote: Hi Ben, On Wed, Apr 27, 2016, at 20:07, Ben Hutchings wrote: On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote: On 04/26/2016 04:02 PM, Ben Hutchings wrote: 3.2.80-rc1 review patch. If anyone has any objections, please let me know. I

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-27 Thread Ben Greear
On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote: Hi Ben, On Wed, Apr 27, 2016, at 20:07, Ben Hutchings wrote: On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote: On 04/26/2016 04:02 PM, Ben Hutchings wrote: 3.2.80-rc1 review patch. If anyone has any objections, please let me know. I

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-27 Thread Ben Greear
will cause bad checksum on forwarded packets */ - if (skb->ip_summed == CHECKSUM_NONE && - rcv->features & NETIF_F_RXCSUM) - skb->ip_summed = CHECKSUM_UNNECESSARY; length = skb->len; if (dev_forward_skb(rcv, skb) != NET_RX_SUCCESS) -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-27 Thread Ben Greear
s that - will cause bad checksum on forwarded packets */ - if (skb->ip_summed == CHECKSUM_NONE && - rcv->features & NETIF_F_RXCSUM) - skb->ip_summed = CHECKSUM_UNNECESSARY; length = skb->len; if (dev_forward_skb

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 01:29 PM, Eric Dumazet wrote: On Tue, 2016-04-12 at 13:23 -0700, Ben Greear wrote: It worked well enough for years that I didn't even know other algorithms were available. It was broken around 4.0 time, and I reported it to the list, and no one seemed to really care enough to do

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 01:29 PM, Eric Dumazet wrote: On Tue, 2016-04-12 at 13:23 -0700, Ben Greear wrote: It worked well enough for years that I didn't even know other algorithms were available. It was broken around 4.0 time, and I reported it to the list, and no one seemed to really care enough to do

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 01:17 PM, Eric Dumazet wrote: On Tue, 2016-04-12 at 13:11 -0700, Ben Greear wrote: On 04/12/2016 12:31 PM, Machani, Yaniv wrote: On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 01:17 PM, Eric Dumazet wrote: On Tue, 2016-04-12 at 13:11 -0700, Ben Greear wrote: On 04/12/2016 12:31 PM, Machani, Yaniv wrote: On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 12:31 PM, Machani, Yaniv wrote: On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: If you are using 'Cubic' TCP congestion control, then please try something different

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
On 04/12/2016 12:31 PM, Machani, Yaniv wrote: On Tue, Apr 12, 2016 at 18:04:52, Ben Greear wrote: On 04/12/2016 07:52 AM, Eric Dumazet wrote: On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: If you are using 'Cubic' TCP congestion control, then please try something different

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
found. If you are using 'Cubic' TCP congestion control, then please try something different. It was broken last I checked, at least when used with the ath10k driver. https://marc.info/?l=linux-netdev=144405216005715=2 Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologi

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Ben Greear
found. If you are using 'Cubic' TCP congestion control, then please try something different. It was broken last I checked, at least when used with the ath10k driver. https://marc.info/?l=linux-netdev=144405216005715=2 Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Deadlock related to file permissions and/or cgroup, 4.4.6+

2016-04-07 Thread Ben Greear
0x1c3 [] ? release_task+0x738/0x738 [] ? SyS_futex+0x152/0x1ee [] ? do_futex+0xb4d/0xb4d [] ? mark_held_locks+0x2d/0x90 [] ? lockdep_sys_exit+0x1a/0x91 [] ? lockdep_sys_exit_thunk+0x12/0x14 [] SyS_exit+0x1d/0x1d [] entry_SYSCALL_64_fastpath+0x16/0x7a 1 lock held by llvmpipe-2/1356: #0: (_threadgroup_rwsem){++}, at: [] exit_signals+0x80/0x1ef Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Deadlock related to file permissions and/or cgroup, 4.4.6+

2016-04-07 Thread Ben Greear
0x1c3 [] ? release_task+0x738/0x738 [] ? SyS_futex+0x152/0x1ee [] ? do_futex+0xb4d/0xb4d [] ? mark_held_locks+0x2d/0x90 [] ? lockdep_sys_exit+0x1a/0x91 [] ? lockdep_sys_exit_thunk+0x12/0x14 [] SyS_exit+0x1d/0x1d [] entry_SYSCALL_64_fastpath+0x16/0x7a 1 lock held by llvmpipe-2/1356: #0: (_threadgroup_rwsem){++}, at: [] exit_signals+0x80/0x1ef Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: Question on rhashtable in worst-case scenario.

2016-04-01 Thread Ben Greear
d! Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Re: Question on rhashtable in worst-case scenario.

2016-04-01 Thread Ben Greear
d! Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: Question on rhashtable in worst-case scenario.

2016-03-31 Thread Ben Greear
On 03/31/2016 12:46 AM, Johannes Berg wrote: On Wed, 2016-03-30 at 09:52 -0700, Ben Greear wrote: If someone can fix rhashtable, then great. I read some earlier comments [1] back when someone else reported similar problems, and the comments seemed to indicate that rhashtable was broken

Re: Question on rhashtable in worst-case scenario.

2016-03-31 Thread Ben Greear
On 03/31/2016 12:46 AM, Johannes Berg wrote: On Wed, 2016-03-30 at 09:52 -0700, Ben Greear wrote: If someone can fix rhashtable, then great. I read some earlier comments [1] back when someone else reported similar problems, and the comments seemed to indicate that rhashtable was broken

Re: Question on rhashtable in worst-case scenario.

2016-03-30 Thread Ben Greear
On 03/30/2016 09:38 AM, David Miller wrote: From: Johannes Berg <johan...@sipsolutions.net> Date: Wed, 30 Mar 2016 11:14:12 +0200 On Tue, 2016-03-29 at 09:16 -0700, Ben Greear wrote: Looks like rhashtable has too much policy in it to properly deal with cases where there are too man

Re: Question on rhashtable in worst-case scenario.

2016-03-30 Thread Ben Greear
On 03/30/2016 09:38 AM, David Miller wrote: From: Johannes Berg Date: Wed, 30 Mar 2016 11:14:12 +0200 On Tue, 2016-03-29 at 09:16 -0700, Ben Greear wrote: Looks like rhashtable has too much policy in it to properly deal with cases where there are too many hash collisions, so I am going

Re: Question on rhashtable in worst-case scenario.

2016-03-29 Thread Ben Greear
Looks like rhashtable has too much policy in it to properly deal with cases where there are too many hash collisions, so I am going to work on reverting it's use in mac80211. Thanks, Ben On 03/28/2016 01:29 PM, Ben Greear wrote: Hello! I have a use case for mac80211 where I create multiple

Re: Question on rhashtable in worst-case scenario.

2016-03-29 Thread Ben Greear
Looks like rhashtable has too much policy in it to properly deal with cases where there are too many hash collisions, so I am going to work on reverting it's use in mac80211. Thanks, Ben On 03/28/2016 01:29 PM, Ben Greear wrote: Hello! I have a use case for mac80211 where I create multiple

Question on rhashtable in worst-case scenario.

2016-03-28 Thread Ben Greear
to at least function in a linear-search manner. Any idea what I can do to get rid of the EBUSY return code problem, or how to debug it further? Thanks, Ben -- Ben Greear <gree...@candelatech.com> Candela Technologies Inc http://www.candelatech.com

Question on rhashtable in worst-case scenario.

2016-03-28 Thread Ben Greear
to at least function in a linear-search manner. Any idea what I can do to get rid of the EBUSY return code problem, or how to debug it further? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com

Re: 3.19.0-rc4+ fails to compile, missing 'usr/missing-syscalls'

2015-01-12 Thread Ben Greear
On 01/12/2015 12:55 PM, Guenter Roeck wrote: > On Mon, Jan 12, 2015 at 12:08:22PM -0800, Ben Greear wrote: >> >> Any idea what is wrong? >> >> -rc3 compiled ok, then I rebased just now, and get this: >> > My auto-builders are all happy, with no build or qemu fa

3.19.0-rc4+ fails to compile, missing 'usr/missing-syscalls'

2015-01-12 Thread Ben Greear
arch/x86/ia32/sys_ia32.o Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

3.19.0-rc4+ fails to compile, missing 'usr/missing-syscalls'

2015-01-12 Thread Ben Greear
arch/x86/ia32/sys_ia32.o Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: 3.19.0-rc4+ fails to compile, missing 'usr/missing-syscalls'

2015-01-12 Thread Ben Greear
On 01/12/2015 12:55 PM, Guenter Roeck wrote: On Mon, Jan 12, 2015 at 12:08:22PM -0800, Ben Greear wrote: Any idea what is wrong? -rc3 compiled ok, then I rebased just now, and get this: My auto-builders are all happy, with no build or qemu failures. Did you try make mrproper prior

kernel splat in clean 3.16, related to drm/i915

2014-08-13 Thread Ben Greear
] [] SyS_finit_module+0x75/0xc0 [4.855049] [] ? vm_mmap_pgoff+0x7b/0xa0 [4.855049] [] sysenter_do_call+0x12/0x12 [4.855049] ---[ end trace 9ef1310c3c12d97e ]--- Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send

kernel splat in clean 3.16, related to drm/i915

2014-08-13 Thread Ben Greear
] [c04cfb25] SyS_finit_module+0x75/0xc0 [4.855049] [c053bbfb] ? vm_mmap_pgoff+0x7b/0xa0 [4.855049] [c0a2964c] sysenter_do_call+0x12/0x12 [4.855049] ---[ end trace 9ef1310c3c12d97e ]--- Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http

Re: Crashes in 3.14.13+ related to anon_vma_clone.

2014-07-24 Thread Ben Greear
On 07/24/2014 04:08 PM, Ben Greear wrote: > A few of our systems are repeatedly crashing when upgraded from > the 3.14.6+ to 3.14.13+ kernels. Both kernels have a fair bit > of our out-of-tree patches, so could be our fault. Ahh, looks like a bad merge of a stable patch with a slightly

Crashes in 3.14.13+ related to anon_vma_clone.

2014-07-24 Thread Ben Greear
31 e4 4d 8b 7e 08 4c 89 e7 49 8b 37 e8 fa ec ff ff RIP [] anon_vma_clone+0x88/0xf5 RSP CR2: 003f9840b000 -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Crashes in 3.14.13+ related to anon_vma_clone.

2014-07-24 Thread Ben Greear
: 003f9840b000 -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Crashes in 3.14.13+ related to anon_vma_clone.

2014-07-24 Thread Ben Greear
On 07/24/2014 04:08 PM, Ben Greear wrote: A few of our systems are repeatedly crashing when upgraded from the 3.14.6+ to 3.14.13+ kernels. Both kernels have a fair bit of our out-of-tree patches, so could be our fault. Ahh, looks like a bad merge of a stable patch with a slightly different

Re: [PATCH] ath10k: fix rssi reporting.

2014-05-15 Thread Ben Greear
Sorry, ...this and previous patch should not have gone to LKML. Will send it over to ath10k list where it was supposed to go. Thanks, Ben On 05/15/2014 11:31 AM, gree...@candelatech.com wrote: > From: Ben Greear > > When the driver cannot provide proper rssi, mark

Re: [PATCH] ath10k: fix rssi reporting.

2014-05-15 Thread Ben Greear
Sorry, ...this and previous patch should not have gone to LKML. Will send it over to ath10k list where it was supposed to go. Thanks, Ben On 05/15/2014 11:31 AM, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com When the driver cannot provide proper rssi, mark status

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Ben Greear
o enable > that mode? You could just force pktgen to not support multi-skb on vlan interfaces? I thought we went through this a year or two ago and came up with something like a 'pktgen-challenged' network interface flag? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Ben Greear
' network interface flag? Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Build failure related to 'spinlokk_types.h'

2014-02-26 Thread Ben Greear
On 02/26/2014 11:50 AM, Ben Greear wrote: > This is from the ath10k tree, which was recently rebased on top of > 3.14.0-rc4. > > I'm getting the error below, but I cannot find any reference to 'spinlokk' > in the source tree. The build tree has two mentions, but these are &

Build failure related to 'spinlokk_types.h'

2014-02-26 Thread Ben Greear
]: *** [sub-make] Error 2 make: *** [all] Error 2 Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Build failure related to 'spinlokk_types.h'

2014-02-26 Thread Ben Greear
]: *** [sub-make] Error 2 make: *** [all] Error 2 Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: Build failure related to 'spinlokk_types.h'

2014-02-26 Thread Ben Greear
On 02/26/2014 11:50 AM, Ben Greear wrote: This is from the ath10k tree, which was recently rebased on top of 3.14.0-rc4. I'm getting the error below, but I cannot find any reference to 'spinlokk' in the source tree. The build tree has two mentions, but these are auto-generated from what

Re: [PATCH 4/11] use ether_addr_equal_64bits

2013-12-31 Thread Ben Greear
On 12/31/2013 08:09 AM, Julia Lawall wrote: On Tue, 31 Dec 2013, Ben Greear wrote: On 12/30/2013 10:32 PM, Julia Lawall wrote: I'm just thinking of a programmer, e.g. changing a struct like this: struct foo { u8 addr[ETH_ALEN]; - u16 dummy; }; I don't know of a way to catch

  1   2   3   4   5   >