Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

On Thu, Mar 07, 2019 at 05:37:50PM -0800, Lee Duncan wrote: > On 3/6/19 10:23 AM, Chris Leech wrote: > > On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote: > >> From: Lee Duncan > >> > >> If there is an error queueing an iscsi command in &g

Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task

On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote: > From: Lee Duncan > > If there is an error queueing an iscsi command in > iscsi_queuecommand(), for example if the transport fails > to take the command in sessuin->tt->xmit_task(), then > the error path can call iscsi_complete_task()

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

e_bounce_limit(sdev->request_queue, BLK_BOUNCE_ANY); > blk_queue_dma_alignment(sdev->request_queue, 0); > return 0; > -- Thanks for fixing this issue with data digests! Signed-off-by: Chris Leech <cle...@redhat.com>

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

BLK_BOUNCE_ANY); > blk_queue_dma_alignment(sdev->request_queue, 0); > return 0; > -- Thanks for fixing this issue with data digests! Signed-off-by: Chris Leech

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

correct? Just want to make sure that's still needed with the call to put_device. Other than that question, I this all looks good. Thanks. Signed-off-by: Chris Leech <cle...@redhat.com>

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

that's still needed with the call to put_device. Other than that question, I this all looks good. Thanks. Signed-off-by: Chris Leech

[PATCH 2/9] iscsi: associate endpoints with a host

Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created. Signed-off-by: Chris Leech <cle...@redhat.com> --- d

[PATCH 3/9] iscsi: sysfs filtering by network namespace

This makes the iscsi_host, iscsi_session, iscsi_connection, iscsi_iface, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. Signed-off-by: Chris Leech <

[PATCH 2/9] iscsi: associate endpoints with a host

Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created. Signed-off-by: Chris Leech --- drivers/infiniband/ulp/iser

[PATCH 3/9] iscsi: sysfs filtering by network namespace

This makes the iscsi_host, iscsi_session, iscsi_connection, iscsi_iface, and iscsi_endpoint transport class devices only visible in sysfs under a matching network namespace. The network namespace for all of these objects is tracked in the iscsi_cls_host structure. Signed-off-by: Chris Leech

[PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. Signed-off-by: Chris Leech <cle...@redhat.com> --- driver

[PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

Make use of the per-net netlink sockets. Responses are sent back on the same socket/namespace the request was received on. Async events are reported on the socket/namespace stored in the iscsi_cls_host associated with the event. Signed-off-by: Chris Leech --- drivers/scsi

[PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/iscsi_tcp.c

[PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. Signed-off-by: Chris Leech --- drivers/scsi/iscsi_tcp.c| 7 +++ drivers/scsi

[PATCH 7/9] iscsi: convert flashnode devices from bus to class

The flashnode session and connection devices should be filtered by net namespace along with the iscsi_host, but we can't do that with a bus device. As these don't use any of the bus matching functionality, they make more sense as a class device anyway. Signed-off-by: Chris Leech <

[PATCH 7/9] iscsi: convert flashnode devices from bus to class

The flashnode session and connection devices should be filtered by net namespace along with the iscsi_host, but we can't do that with a bus device. As these don't use any of the bus matching functionality, they make more sense as a class device anyway. Signed-off-by: Chris Leech --- drivers

[PATCH 6/9] iscsi: check net namespace for all iscsi lookups

All internal lookups of iSCSI transport objects need to be filtered by net namespace. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/infiniband/ulp/iser/iscsi_iser.c | 5 +- drivers/scsi/be2iscsi/be_iscsi.c | 4 +- drivers/scsi/bnx2i/bnx2i_iscsi.c

[PATCH 9/9] iscsi: filter flashnode sysfs by net namespace

Finished the net namespace support for flashnode sysfs devices Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/driver

[PATCH 9/9] iscsi: filter flashnode sysfs by net namespace

Finished the net namespace support for flashnode sysfs devices Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c

[PATCH 6/9] iscsi: check net namespace for all iscsi lookups

All internal lookups of iSCSI transport objects need to be filtered by net namespace. Signed-off-by: Chris Leech --- drivers/infiniband/ulp/iser/iscsi_iser.c | 5 +- drivers/scsi/be2iscsi/be_iscsi.c | 4 +- drivers/scsi/bnx2i/bnx2i_iscsi.c | 4 +- drivers/scsi/cxgbi

[PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets

Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/scsi_transport_iscsi.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscs

[PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets

Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Chris Leech --- drivers/scsi/scsi_transport_iscsi.c | 67 +++-- 1 file changed, 57 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi

[PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

cleanups after the bus to class conversion Signed-off-by: Chris Leech <cle...@redhat.com> --- drivers/scsi/qla4xxx/ql4_os.c | 52 +- drivers/scsi/scsi_transport_iscsi.c | 102 ++-- include/scsi/scsi_transport_iscsi.h

[PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

cleanups after the bus to class conversion Signed-off-by: Chris Leech --- drivers/scsi/qla4xxx/ql4_os.c | 52 +- drivers/scsi/scsi_transport_iscsi.c | 102 ++-- include/scsi/scsi_transport_iscsi.h | 48 + 3 files changed

Re: [PATCH] scsi: libiscsi: Convert timers to use timer_setup()

Reviewed-by: Chris Leech <cle...@redhat.com> - Original Message - > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > >

Re: [PATCH] scsi: libiscsi: Convert timers to use timer_setup()

Reviewed-by: Chris Leech - Original Message - > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Lee Duncan > Cc:

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

Thanks. Acked-by: Chris Leech <cle...@redhat.com> On Thu, Jul 13, 2017 at 09:11:22AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > iscsi_session_teardown was the only user of this function. Function > currently is just short for iscsi_remove_session + iscsi_free_session. >

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

Thanks. Acked-by: Chris Leech On Thu, Jul 13, 2017 at 09:11:22AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > iscsi_session_teardown was the only user of this function. Function > currently is just short for iscsi_remove_session + iscsi_free_session. > > Signed-off-by

Re: [Patch v2 1/2] libiscsi: Fix use-after-free race during iscsi_session_teardown

Looks good to me, fixes up the code given that the comment there about calling iscsi_remove_session wasn't being followed. Thanks Acked-by: Chris Leech <cle...@redhat.com> On Thu, Jul 13, 2017 at 09:11:21AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > Session attributes expose

Re: [Patch v2 1/2] libiscsi: Fix use-after-free race during iscsi_session_teardown

Looks good to me, fixes up the code given that the comment there about calling iscsi_remove_session wasn't being followed. Thanks Acked-by: Chris Leech On Thu, Jul 13, 2017 at 09:11:21AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > Session attributes exposed through sysfs were fr

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: > This patchset enables iSCSI offload drivers to have access to the iface > information provided by iscsid. This allows users to have more control > of how the driver connects to the iSCSI target. iSER is updated to use >

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: > This patchset enables iSCSI offload drivers to have access to the iface > information provided by iscsid. This allows users to have more control > of how the driver connects to the iSCSI target. iSER is updated to use >

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> situations. > > Signed-off-by: Elena Reshetova <elena.reshet...@intel.com> > Signed-off-by: Hans Liljestrand <ishkam...@gmail.com> > Signed-off-by: Kees Cook <keesc...@chromium.org> > Signed-off-by: David Windsor <dwind...@gmail.com> This loo

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

> situations. > > Signed-off-by: Elena Reshetova > Signed-off-by: Hans Liljestrand > Signed-off-by: Kees Cook > Signed-off-by: David Windsor This looks OK to me. Acked-by: Chris Leech > --- > drivers/scsi/libiscsi.c| 8 > drivers/scsi/qedi/qedi_is

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Fri, Dec 23, 2016 at 07:53:50AM +0800, Ming Lei wrote: > On Fri, Dec 23, 2016 at 2:50 AM, Chris Leech <cle...@redhat.com> wrote: > > I'm not reproducing any problems with xfstests running over iscsi_tcp > > right now. Two 10G luns exported from an LIO target, attached dire

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Fri, Dec 23, 2016 at 07:53:50AM +0800, Ming Lei wrote: > On Fri, Dec 23, 2016 at 2:50 AM, Chris Leech wrote: > > I'm not reproducing any problems with xfstests running over iscsi_tcp > > right now. Two 10G luns exported from an LIO target, attached directly > > to

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Thu, Dec 22, 2016 at 05:50:12PM +1100, Dave Chinner wrote: > On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: > > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > > > There may be deeper issues. I just started running scalability tests > > >

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Thu, Dec 22, 2016 at 05:50:12PM +1100, Dave Chinner wrote: > On Wed, Dec 21, 2016 at 09:46:37PM -0800, Linus Torvalds wrote: > > On Wed, Dec 21, 2016 at 9:13 PM, Dave Chinner wrote: > > > > > > There may be deeper issues. I just started running scalability tests > > > (e.g. 16-way fsmark

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > Hi, > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner <da...@fromorbit.com> wrote: > > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > >> Thanks Dave, > >> > >> I'm

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

On Wed, Dec 21, 2016 at 03:19:15PM -0800, Linus Torvalds wrote: > Hi, > > On Wed, Dec 21, 2016 at 2:16 PM, Dave Chinner wrote: > > On Fri, Dec 16, 2016 at 10:59:06AM -0800, Chris Leech wrote: > >> Thanks Dave, > >> > >> I'm hitting a bug at sca

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

Thanks Dave, I'm hitting a bug at scatterlist.h:140 before I even get any iSCSI modules loaded (virtio block) so there's something else going on in the current merge window. I'll keep an eye on it and make sure there's nothing iSCSI needs fixing for. Chris On Thu, Dec 15, 2016 at 09:29:53AM

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

Thanks Dave, I'm hitting a bug at scatterlist.h:140 before I even get any iSCSI modules loaded (virtio block) so there's something else going on in the current merge window. I'll keep an eye on it and make sure there's nothing iSCSI needs fixing for. Chris On Thu, Dec 15, 2016 at 09:29:53AM

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

his in user space, though, > than to limit the value range for the session ID here. > > Signed-off-by: Lee Duncan <ldun...@suse.com> Acked-by: Chris Leech <cle...@redhat.com>

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

his in user space, though, > than to limit the value range for the session ID here. > > Signed-off-by: Lee Duncan Acked-by: Chris Leech

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Tue, Feb 16, 2016 at 12:40:12PM -0600, Mike Christie wrote: > On 02/15/2016 12:26 PM, Chris Leech wrote: > > On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > >> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > >>> The scsi_trans

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Tue, Feb 16, 2016 at 12:40:12PM -0600, Mike Christie wrote: > On 02/15/2016 12:26 PM, Chris Leech wrote: > > On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > >> On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > >>> The scsi_trans

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > > The scsi_transport_iscsi module already uses the ida_simple > > routines for managing the target ID, if requested to do > > so. This change replaces an ever-increasing atomic

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Fri, Feb 12, 2016 at 09:54:51AM -0800, James Bottomley wrote: > On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > > The scsi_transport_iscsi module already uses the ida_simple > > routines for managing the target ID, if requested to do > > so. This change replaces an ever-increasing atomic

Re: [Open-FCoE] [PATCH] fcoe:Fix incorrect use of non wrapper version of skb_buff helper function in fcoe_percpu_recieve_thread

On Sun, Sep 20, 2015 at 06:22:39PM -0400, Nicholas Krause wrote: > This fixes the incorrect use of the non wrapper version of the > function skb_dequeue in fcoe_percpu_receive_thread to use the > wrapper version as we need to protect avoid other users from > concurrently access on the sk_buff_head

Re: [Open-FCoE] [PATCH] fcoe:Fix incorrect use of non wrapper version of skb_buff helper function in fcoe_percpu_recieve_thread

On Sun, Sep 20, 2015 at 06:22:39PM -0400, Nicholas Krause wrote: > This fixes the incorrect use of the non wrapper version of the > function skb_dequeue in fcoe_percpu_receive_thread to use the > wrapper version as we need to protect avoid other users from > concurrently access on the sk_buff_head

[PATCH] iscsi_ibft: filter null v4-mapped v6 addresses

core iSCSI driver as it's already in the wild in a large number of servers. Tested under qemu using an OVMF build of tianocore EDK2. Signed-off-by: Chris Leech --- drivers/firmware/iscsi_ibft.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-)

[PATCH] iscsi_ibft: filter null v4-mapped v6 addresses

driver as it's already in the wild in a large number of servers. Tested under qemu using an OVMF build of tianocore EDK2. Signed-off-by: Chris Leech cle...@redhat.com --- drivers/firmware/iscsi_ibft.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions

Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

Christoph Hellwig wrote: I just did a very quick glance over the tree. Some extremly highlevel comments to start with before actually starting the source review: Thanks for taking a look Christoph - why do you need your own libcrc? lib/crc32.c has a crc32_le We shouldn't, but we may

Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

Christoph Hellwig wrote: I just did a very quick glance over the tree. Some extremly highlevel comments to start with before actually starting the source review: Thanks for taking a look Christoph - why do you need your own libcrc? lib/crc32.c has a crc32_le We shouldn't, but we may

Re: [GIT PULL] I/OAT updates for 2.6.22

On Wed, 2007-05-02 at 15:44 -0700, David Miller wrote: > > Chrstopher, I really really would like you to post these patches early > and often to [EMAIL PROTECTED] especially because you are > touching the TCP code. You're right, I should have sent this to netdev as well. I'm Sorry. As for

[GIT PULL] I/OAT updates for 2.6.22

Chris Leech (6): ioatdma: Push pending transactions to hardware more frequently ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma ioatdma: Remove the use of writeq from the ioatdma driver I/OAT: Add documentation for the tcp_dma_copybreak sysctl I/OAT

[GIT PULL] I/OAT updates for 2.6.22

Chris Leech (6): ioatdma: Push pending transactions to hardware more frequently ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma ioatdma: Remove the use of writeq from the ioatdma driver I/OAT: Add documentation for the tcp_dma_copybreak sysctl I/OAT

Re: [GIT PULL] I/OAT updates for 2.6.22

On Wed, 2007-05-02 at 15:44 -0700, David Miller wrote: Chrstopher, I really really would like you to post these patches early and often to [EMAIL PROTECTED] especially because you are touching the TCP code. You're right, I should have sent this to netdev as well. I'm Sorry. As for early

Re: [PATCH 1/9] ioatdma: Push pending transactions to hardware more frequently

> This sounds like something that will always be wrong -- or in other > words, always be right for only the latest CPUs. Can this be made > dynamic, based on some timing factor? In fact I think this has been tweaked twice in the vanilla tree already. This is actually just the same tweak you

[PATCH 8/9] I/OAT: warning fix

net/ipv4/tcp.c: In function 'tcp_recvmsg': net/ipv4/tcp.c:: warning: unused variable 'available' Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- net/ipv4/tcp.c | 26 -- 1 files changed, 16 inser

[PATCH 1/9] ioatdma: Push pending transactions to hardware more frequently

Every 20 descriptors turns out to be to few append commands with newer/faster CPUs. Pushing every 4 still cuts down on MMIO writes to an acceptable level without letting the DMA engine run out of work. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c |4 +

[PATCH 2/9] drivers/dma: handle sysfs errors

From: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/dmaengine.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dmaengi

[PATCH 6/9] I/OAT: Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma

Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- MAINTAINERS | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1dfba85..2dd5d23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1156,6 +1156,12 @@ M: [EMAIL PROTECT

[PATCH 7/9] I/OAT: Only offload copies for TCP when there will be a context switch

The performance wins come with having the DMA copy engine doing the copies in parallel with the context switch. If there is enough data ready on the socket at recv time just use a regular copy. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- net/ipv4/tcp.c | 10 +++--- 1 files c

[PATCH 5/9] I/OAT: Add documentation for the tcp_dma_copybreak sysctl

Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- Documentation/networking/ip-sysctl.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index d3aae1f..9541691

[PATCH 0/9] I/OAT fixes

Andrew Morton (1): I/OAT: warning fix Chris Leech (6): ioatdma: Push pending transactions to hardware more frequently ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma ioatdma: Remove the use of writeq from the ioatdma driver I/OAT: Add documentation

[PATCH 9/9] I/OAT: fix I/OAT for kexec

AIL PROTECTED]> Signed-off-by: Chris Leech <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c index cbf93

[PATCH 3/9] ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma

Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c| 60 +++ drivers/dma/ioatdma_io.h | 118 -- 2 files changed, 28 insertions(+), 150 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drive

[PATCH 4/9] ioatdma: Remove the use of writeq from the ioatdma driver

There's only one now anyway, and it's not in a performance path, so make it behave the same on 32-bit and 64-bit CPUs. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/ioatdma.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/ioa

Re: [GIT PULL] I/OAT fixes

On 3/2/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Where is the patch for review? I'm sending them now. These have been posted before, and other than one objectionable change that I dropped the first time around they quietly went nowhere. - Chris - To unsubscribe from this list: send the

[GIT PULL] I/OAT fixes

Please pull from git://lost.foo-projects.org/~cleech/linux-2.6#master A few drivers/dma and related I/OAT fixes, and missing documentation. These have been posted for review and sitting in MM for a while now. - Chris Andrew Morton (1): I/OAT: warning fix Chris Leech (6): ioatdma

[GIT PULL] I/OAT fixes

Please pull from git://lost.foo-projects.org/~cleech/linux-2.6#master A few drivers/dma and related I/OAT fixes, and missing documentation. These have been posted for review and sitting in MM for a while now. - Chris Andrew Morton (1): I/OAT: warning fix Chris Leech (6): ioatdma

Re: [GIT PULL] I/OAT fixes

On 3/2/07, Jeff Garzik [EMAIL PROTECTED] wrote: Where is the patch for review? I'm sending them now. These have been posted before, and other than one objectionable change that I dropped the first time around they quietly went nowhere. - Chris - To unsubscribe from this list: send the line

[PATCH 4/9] ioatdma: Remove the use of writeq from the ioatdma driver

There's only one now anyway, and it's not in a performance path, so make it behave the same on 32-bit and 64-bit CPUs. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/ioatdma.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/dma/ioatdma.c b

[PATCH 3/9] ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma

Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/ioatdma.c| 60 +++ drivers/dma/ioatdma_io.h | 118 -- 2 files changed, 28 insertions(+), 150 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drivers/dma

[PATCH 9/9] I/OAT: fix I/OAT for kexec

PROTECTED] Signed-off-by: Chris Leech [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/dma/ioatdma.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/dma/ioatdma.c b/drivers/dma/ioatdma.c index cbf93ca..1d259e5 100644 --- a/drivers

[PATCH 0/9] I/OAT fixes

Andrew Morton (1): I/OAT: warning fix Chris Leech (6): ioatdma: Push pending transactions to hardware more frequently ioatdma: Remove the wrappers around read(bwl)/write(bwl) in ioatdma ioatdma: Remove the use of writeq from the ioatdma driver I/OAT: Add documentation

[PATCH 7/9] I/OAT: Only offload copies for TCP when there will be a context switch

The performance wins come with having the DMA copy engine doing the copies in parallel with the context switch. If there is enough data ready on the socket at recv time just use a regular copy. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- net/ipv4/tcp.c | 10 +++--- 1 files changed

[PATCH 5/9] I/OAT: Add documentation for the tcp_dma_copybreak sysctl

Signed-off-by: Chris Leech [EMAIL PROTECTED] --- Documentation/networking/ip-sysctl.txt |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index d3aae1f..9541691 100644 --- a/Documentation

[PATCH 6/9] I/OAT: Add entries to MAINTAINERS for the DMA memcpy subsystem and ioatdma

Signed-off-by: Chris Leech [EMAIL PROTECTED] --- MAINTAINERS | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1dfba85..2dd5d23 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1156,6 +1156,12 @@ M: [EMAIL PROTECTED] L

[PATCH 2/9] drivers/dma: handle sysfs errors

From: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/dmaengine.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dmaengine.c b/drivers/dma

[PATCH 1/9] ioatdma: Push pending transactions to hardware more frequently

Every 20 descriptors turns out to be to few append commands with newer/faster CPUs. Pushing every 4 still cuts down on MMIO writes to an acceptable level without letting the DMA engine run out of work. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/ioatdma.c |4 ++-- 1 files

[PATCH 8/9] I/OAT: warning fix

net/ipv4/tcp.c: In function 'tcp_recvmsg': net/ipv4/tcp.c:: warning: unused variable 'available' Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Chris Leech [EMAIL PROTECTED] --- net/ipv4/tcp.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions

Re: [PATCH 1/9] ioatdma: Push pending transactions to hardware more frequently

This sounds like something that will always be wrong -- or in other words, always be right for only the latest CPUs. Can this be made dynamic, based on some timing factor? In fact I think this has been tweaked twice in the vanilla tree already. This is actually just the same tweak you

Re: [BUG] Onboard Ethernet Pro 100 on a SMP box: a very strange errors

On Wed, 26 Jan 2005 07:37:49 +0500, Denis Zaitsev <[EMAIL PROTECTED]> wrote: > On Tue, Jan 25, 2005 at 11:19:11PM +0200, Denis Vlasenko wrote: > > > > Something corrupts packets. It can be sending NIC, switch in the middle, > > or receiving NIC. > > Changing the receiving card closes the

Re: [BUG] Onboard Ethernet Pro 100 on a SMP box: a very strange errors

On Wed, 26 Jan 2005 07:37:49 +0500, Denis Zaitsev [EMAIL PROTECTED] wrote: On Tue, Jan 25, 2005 at 11:19:11PM +0200, Denis Vlasenko wrote: Something corrupts packets. It can be sending NIC, switch in the middle, or receiving NIC. Changing the receiving card closes the question. Doesn't