Re: [PATCH v2 2/2] powerpc/legacy_serial: Use early_ioremap()

2021-04-20 Thread Chris Packham
ge is gone and I still get console output. Tested-by: Chris Packham > arch/powerpc/kernel/legacy_serial.c | 33 + > 1 file changed, 29 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/kernel/legacy_serial.c > b/arch/powerpc/kernel/

[PATCH v4 6/6] i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource()

2021-04-14 Thread Chris Packham
From: Andy Shevchenko devm_platform_ioremap_resource() prints a message in case of error. Drop custom one. Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v4 3/6] i2c: mpc: Use devm_clk_get_optional()

2021-04-14 Thread Chris Packham
From: Andy Shevchenko The peripheral clock is optional and we may get an -EPROBE_DEFER error code which would not be propagated correctly, fix this by using devm_clk_get_optional(). Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- drivers/i2c/busses

[PATCH v4 5/6] i2c: mpc: Use device_get_match_data() helper

2021-04-14 Thread Chris Packham
From: Andy Shevchenko Use the device_get_match_data() helper instead of open coding. Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git

[PATCH v4 1/6] i2c: mpc: Interrupt driven transfer

2021-04-14 Thread Chris Packham
will timeout if we take too long between bytes in a transfer. Signed-off-by: Chris Packham --- Notes: Changes in v4: - Split license/copyright change to separate patch - Remove MPC_I2C_ACTION_INVALID - make action_str const - Remove __func__ from dev_dbg output - Use Tx ACK/Rx ACK

[PATCH v4 4/6] i2c: mpc: Remove CONFIG_PM_SLEEP ifdeffery

2021-04-14 Thread Chris Packham
From: Andy Shevchenko Use __maybe_unused for the suspend()/resume() hooks and get rid of the CONFIG_PM_SLEEP ifdeffery to improve the code. Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham Signed-off-by: Chris Packham --- Notes: Changes in v4: - Fix compile error due

[PATCH v4 2/6] i2c: mpc: Update license and copyright

2021-04-14 Thread Chris Packham
Use SPDX-License-Identifier and add copyright for Allied Telesis because of the reasonably large rewrite in the preceding patch. Signed-off-by: Chris Packham --- Notes: Changes in v4: - New, split out from "i2c: mpc: Interrupt driven transfer" drivers/i2c/busses/i2c-

[PATCH v4 0/6] i2c: mpc: Refactor to improve responsiveness

2021-04-14 Thread Chris Packham
: Use device_get_match_data() helper i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource() Chris Packham (2): i2c: mpc: Interrupt driven transfer i2c: mpc: Update license and copyright drivers/i2c/busses/i2c-mpc.c | 492 +++ 1 file changed, 262

Re: [PATCH v1 2/4] i2c: mpc: Remove CONFIG_PM_SLEEP ifdeffery

2021-04-14 Thread Chris Packham
On 15/04/21 12:14 am, Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 11:43:25PM +0000, Chris Packham wrote: >> On 14/04/21 2:37 am, Andy Shevchenko wrote: >>> Use __maybe_unused for the suspend()/resume() hooks and get rid of >>> the CONFIG_PM_SLEEP ifdeffery to im

Re: [PATCH v1 4/4] i2c: mpc: Drop duplicate message from devm_platform_ioremap_resource()

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > devm_platform_ioremap_resource() prints a message in case of error. > Drop custom one. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham > --- > drivers/i2c/busses/i2c-mpc.c | 4 +--- > 1 file changed, 1 inse

Re: [PATCH v1 3/4] i2c: mpc: Use device_get_match_data() helper

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > Use the device_get_match_data() helper instead of open coding. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham > --- > drivers/i2c/busses/i2c-mpc.c | 12 > 1 file changed, 4 insertions(+), 8 deletions

Re: [PATCH v1 2/4] i2c: mpc: Remove CONFIG_PM_SLEEP ifdeffery

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > Use __maybe_unused for the suspend()/resume() hooks and get rid of > the CONFIG_PM_SLEEP ifdeffery to improve the code. > > Signed-off-by: Andy Shevchenko > --- > drivers/i2c/busses/i2c-mpc.c | 12 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH v1 1/4] i2c: mpc: Use devm_clk_get_optional()

2021-04-13 Thread Chris Packham
On 14/04/21 2:37 am, Andy Shevchenko wrote: > The peripheral clock is optional and we may get an -EPROBE_DEFER error code > which would not be propagated correctly, fix this by using > devm_clk_get_optional(). > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Packham None o

Re: [PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-13 Thread Chris Packham
On 14/04/21 10:28 am, Chris Packham wrote: > > On 14/04/21 1:52 am, Andy Shevchenko wrote: >> On Tue, Apr 13, 2021 at 8:10 AM Chris Packham >> wrote: >>> The fsl-i2c controller will generate an interrupt after every byte >>> transferred. Make use of this inte

Re: [PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-13 Thread Chris Packham
On 14/04/21 1:52 am, Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 8:10 AM Chris Packham > wrote: >> The fsl-i2c controller will generate an interrupt after every byte >> transferred. Make use of this interrupt to drive a state machine which >> allows the next part

Re: [PATCH v3 3/3] MAINTAINERS: Add Chris Packham as FREESCALE MPC I2C maintainer

2021-04-12 Thread Chris Packham
On 13/04/21 5:09 pm, Chris Packham wrote: > Add Chris Packham as FREESCALE MPC I2C maintainer. > > Signed-off-by: Chris Packham Sorry for the duplicate. I had existing output from an earlier invocation of git format-patch lying around. "[PATCH v3 4/4] MAINTAINERS: ..." is

[PATCH v3 4/4] MAINTAINERS: Add Chris Packham as FREESCALE MPC I2C maintainer

2021-04-12 Thread Chris Packham
Add Chris Packham as FREESCALE MPC I2C maintainer. Signed-off-by: Chris Packham --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 56e9e4d777d8..3bc77ba8cd05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7135,6 +7135,13 @@ S

[PATCH v3 1/4] i2c: mpc: use device managed APIs

2021-04-12 Thread Chris Packham
Use device managed functions an clean up error handling. Signed-off-by: Chris Packham Signed-off-by: Wolfram Sang --- Notes: Changes in v3: - Assuming 09aab7add7bf is reverted I've folded in the fix from Wei Yongjun[1] into the original patch. If Wei's patch is applied on top

[PATCH v3 3/4] i2c: mpc: Remove redundant NULL check

2021-04-12 Thread Chris Packham
is redundant so remove the check. Reported-by: Wolfram Sang Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index 9818f9f6a553..c30687483147 100644 --- a/drivers

[PATCH v3 0/4] i2c: mpc: Refactor to improve responsiveness

2021-04-12 Thread Chris Packham
've tested on T2081 and P2041 based systems with a number of i2c and smbus devices. Also this time I included a few iterations of module insert/remove which would have caught the earlier errors. Chris Packham (4): i2c: mpc: use device managed APIs i2c: mpc: Interrupt driven transfer i2c: m

[PATCH v3 2/4] i2c: mpc: Interrupt driven transfer

2021-04-12 Thread Chris Packham
will timeout if we take too long between bytes in a transfer. Signed-off-by: Chris Packham --- Notes: Changes in v3: - use WARN/WARN_ON instead of BUG/BUG_ON Changes in v2: - add static_assert for state debug strings - remove superfluous space drivers/i2c/busses/i2c-mpc.c | 434

[PATCH v3 3/3] MAINTAINERS: Add Chris Packham as FREESCALE MPC I2C maintainer

2021-04-12 Thread Chris Packham
Add Chris Packham as FREESCALE MPC I2C maintainer. Signed-off-by: Chris Packham --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 56e9e4d777d8..3bc77ba8cd05 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7135,6 +7135,13 @@ S

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

2021-04-12 Thread Chris Packham
On 13/04/21 11:21 am, Chris Packham wrote: > > On 13/04/21 10:52 am, Andy Shevchenko wrote: >> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham >> wrote: >>> Use device managed functions an clean up error handling. >> For the god sake how have you tested this? >&

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

2021-04-12 Thread Chris Packham
On 13/04/21 10:52 am, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham > wrote: >> Use device managed functions an clean up error handling. > For the god sake how have you tested this? > The patch is broken. I've clearly missed the remove path in my test

Re: [PATCH v2 4/6] i2c: mpc: make interrupt mandatory and remove polling code

2021-04-11 Thread Chris Packham
On 11/04/21 8:16 am, Wolfram Sang wrote: > On Mon, Mar 29, 2021 at 02:52:04PM +1300, Chris Packham wrote: >> All the in-tree dts files that use one of the compatible strings from >> i2c-mpc.c provide an interrupt property. By making this mandatory we >> can simplify the c

Re: [PATCH v2 6/6] i2c: mpc: Interrupt driven transfer

2021-04-11 Thread Chris Packham
On 11/04/21 8:13 am, Wolfram Sang wrote: > On Mon, Mar 29, 2021 at 02:52:06PM +1300, Chris Packham wrote: >> The fsl-i2c controller will generate an interrupt after every byte >> transferred. Make use of this interrupt to drive a state machine which >> allows the ne

Re: linux-next: build warning after merge of the hwmon-staging tree

2021-03-30 Thread Chris Packham
My bad. I'll send a patch shortly On 30/03/21 8:27 pm, Stephen Rothwell wrote: > Hi all, > > After merging the hwmon-staging tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/hwmon/bpa-rs600.rst: WARNING: document isn't included in any > toctree > > Introduced

Linux include/uapi/linux/libc-compat.h and Musl include/netinet/in.h incompatibility for __UAPI_DEF_IN6_ADDR_ALT

2021-03-29 Thread Chris Packham
Hi, I've come over from https://github.com/strace/strace/issues/177 there's a bit of context there. Crosstool-ng has hit a problem when building a recent enough version of strace in a configuration that uses musl libc. The error is [ALL ]In file included from

[PATCH v2 6/6] i2c: mpc: Interrupt driven transfer

2021-03-28 Thread Chris Packham
will timeout if we take too long between bytes in a transfer. Signed-off-by: Chris Packham --- Notes: Changes in v2: - add static_assert for state debug strings - remove superfluous space drivers/i2c/busses/i2c-mpc.c | 434 +++ 1 file changed, 241 insertions

[PATCH v2 3/6] i2c: mpc: Make use of i2c_recover_bus()

2021-03-28 Thread Chris Packham
Move the existing calls of mpc_i2c_fixup() to a recovery function registered via bus_recovery_info. This makes it more obvious that recovery is supported and allows for a future where recovery is triggered by the i2c core. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 18

[PATCH v2 0/6] i2c: mpc: Refactor to improve responsiveness

2021-03-28 Thread Chris Packham
ed systems with a number of i2c and smbus devices. Chris Packham (6): dt-bindings: i2c-mpc: Document interrupt property as required dt-bindings: i2c: convert i2c-mpc to json-schema i2c: mpc: Make use of i2c_recover_bus() i2c: mpc: make interrupt mandatory and remove polling code i2c: mpc:

[PATCH v2 4/6] i2c: mpc: make interrupt mandatory and remove polling code

2021-03-28 Thread Chris Packham
All the in-tree dts files that use one of the compatible strings from i2c-mpc.c provide an interrupt property. By making this mandatory we can simplify the code. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 51 ++-- 1 file changed, 19

[PATCH v2 5/6] i2c: mpc: use device managed APIs

2021-03-28 Thread Chris Packham
Use device managed functions an clean up error handling. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 46 ++-- 1 file changed, 18 insertions(+), 28 deletions(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index

[PATCH v2 1/6] dt-bindings: i2c-mpc: Document interrupt property as required

2021-03-28 Thread Chris Packham
All of the in-tree device-trees that use the one of the compatible strings from i2c-mpc.c supply an interrupts property. Make this property mandatory to aid refactoring the driver. Signed-off-by: Chris Packham --- Documentation/devicetree/bindings/i2c/i2c-mpc.txt | 6 +++--- 1 file changed, 3

[PATCH v2 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

2021-03-28 Thread Chris Packham
Convert i2c-mpc to YAML. Signed-off-by: Chris Packham --- Notes: Changes in v2: - Rework compatible validation - Remove irrelevant i2ccontrol from example .../devicetree/bindings/i2c/i2c-mpc.txt | 62 - .../devicetree/bindings/i2c/i2c-mpc.yaml | 91

Re: [PATCH 0/6] i2c: mpc: Refactor to improve responsiveness

2021-03-23 Thread Chris Packham
On 23/03/21 5:33 pm, Chris Packham wrote: > The "meat" of this series is in the last patch which is the change that > actually starts making use of the interrupts to drive a state machine. > The dt-bindings patches can probably go in at any time. The rest of the > series i

Re: [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

2021-03-23 Thread Chris Packham
On 24/03/21 10:59 am, Chris Packham wrote: > > On 24/03/21 10:15 am, Rob Herring wrote: >> On Tue, Mar 23, 2021 at 05:33:27PM +1300, Chris Packham wrote: >>> Convert i2c-mpc to YAML. >>> >>> Signed-off-by: Chris Packham >>> --- >>> ---

Re: [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

2021-03-23 Thread Chris Packham
On 24/03/21 10:15 am, Rob Herring wrote: > On Tue, Mar 23, 2021 at 05:33:27PM +1300, Chris Packham wrote: >> Convert i2c-mpc to YAML. >> >> Signed-off-by: Chris Packham >> --- >> .../devicetree/bindings/i2c/i2c-mpc.txt | 62 >> .

Re: [PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

2021-03-23 Thread Chris Packham
Hi Rob, On 24/03/21 9:16 am, Rob Herring wrote: > On Tue, 23 Mar 2021 17:33:27 +1300, Chris Packham wrote: >> Convert i2c-mpc to YAML. >> >> Signed-off-by: Chris Packham >> --- >> .../devicetree/bindings/i2c/i2c-mpc.txt | 62 >> .

[PATCH 5/6] i2c: mpc: use device managed APIs

2021-03-22 Thread Chris Packham
Use device managed functions an clean up error handling. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 46 ++-- 1 file changed, 18 insertions(+), 28 deletions(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index

[PATCH 6/6] i2c: mpc: Interrupt driven transfer

2021-03-22 Thread Chris Packham
will timeout if we take too long between bytes in a transfer. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 430 +++ 1 file changed, 237 insertions(+), 193 deletions(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index

[PATCH 3/6] i2c: mpc: Make use of i2c_recover_bus()

2021-03-22 Thread Chris Packham
Move the existing calls of mpc_i2c_fixup() to a recovery function registered via bus_recovery_info. This makes it more obvious that recovery is supported and allows for a future where recovery is triggered by the i2c core. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 18

[PATCH 0/6] i2c: mpc: Refactor to improve responsiveness

2021-03-22 Thread Chris Packham
sed system with a number of i2c and smbus devices. Its the end of my work day so I figured I'd get this out now but I'll do some more testing on a P2041 board and a few different i2c devices tomorrow. Chris Packham (6): dt-bindings: i2c-mpc: Document interrupt property as required dt-bindings: i2c: conve

[PATCH 2/6] dt-bindings: i2c: convert i2c-mpc to json-schema

2021-03-22 Thread Chris Packham
Convert i2c-mpc to YAML. Signed-off-by: Chris Packham --- .../devicetree/bindings/i2c/i2c-mpc.txt | 62 .../devicetree/bindings/i2c/i2c-mpc.yaml | 99 +++ 2 files changed, 99 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree

[PATCH 1/6] dt-bindings: i2c-mpc: Document interrupt property as required

2021-03-22 Thread Chris Packham
All of the in-tree device-trees that use the one of the compatible strings from i2c-mpc.c supply an interrupts property. Make this property mandatory to aid refactoring the driver. Signed-off-by: Chris Packham --- Documentation/devicetree/bindings/i2c/i2c-mpc.txt | 6 +++--- 1 file changed, 3

[PATCH 4/6] i2c: mpc: make interrupt mandatory and remove polling code

2021-03-22 Thread Chris Packham
All the in-tree dts files that use one of the compatible strings from i2c-mpc.c provide an interrupt property. By making this mandatory we can simplify the code. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 51 ++-- 1 file changed, 19

Re: Errant readings on LM81 with T2080 SoC

2021-03-17 Thread Chris Packham
On 12/03/21 10:34 am, Guenter Roeck wrote: > On 3/11/21 1:17 PM, Chris Packham wrote: >> On 11/03/21 9:18 pm, Wolfram Sang wrote: >>>> Bummer. What is really weird is that you see clock stretching under >>>> CPU load. Normally clock stretching is triggered by

[PATCH v3 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-16 Thread Chris Packham
The BPA-RS600 is a compact 600W AC to DC removable power supply module. Signed-off-by: Chris Packham --- Notes: Changes in v3: - Fix typo BPD -> BPA - Allow for NUL terminator in buf Changes in v2: - Whitespace and line length cleanup - Add comments about comma

[PATCH v3 1/3] dt-bindings: Add vendor prefix and trivial device for BluTek BPA-RS600

2021-03-16 Thread Chris Packham
Add vendor prefix "blutek" for BluTek Power. Add trivial device entry for BPA-RS600. Signed-off-by: Chris Packham --- Notes: Changes in v3: - None Changes in v2: - None Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ Documentation/devicetree/bindi

[PATCH v3 2/3] hwmon: (pmbus): Replace - with _ in device names before registration

2021-03-16 Thread Chris Packham
The hwmon sysfs ABI requires that the `name` property doesn't include any dashes. But when the pmbus code picks the name up from the device tree it quite often does. Replace '-' with '_' before registering the device. Signed-off-by: Chris Packham --- Notes: Changes in v3: - None

Re: [PATCH v2 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-16 Thread Chris Packham
On 17/03/21 9:30 am, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v2: > - Whitespace and line length cleanup > - Add comments abou

[PATCH v2 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-16 Thread Chris Packham
The BPA-RS600 is a compact 600W AC to DC removable power supply module. Signed-off-by: Chris Packham --- Notes: Changes in v2: - Whitespace and line length cleanup - Add comments about commands that return data but shouldn't be used Documentation/hwmon/bpa-rs600.rst | 74

[PATCH v2 2/3] hwmon: (pmbus): Replace - with _ in device names before registration

2021-03-16 Thread Chris Packham
The hwmon sysfs ABI requires that the `name` property doesn't include any dashes. But when the pmbus code picks the name up from the device tree it quite often does. Replace '-' with '_' before registering the device. Signed-off-by: Chris Packham --- Notes: Changes in v2: - New

[PATCH v2 1/3] dt-bindings: Add vendor prefix and trivial device for BluTek BPA-RS600

2021-03-16 Thread Chris Packham
Add vendor prefix "blutek" for BluTek Power. Add trivial device entry for BPA-RS600. Signed-off-by: Chris Packham --- Notes: Changes in v2: - None Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 +

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Chris Packham
On 16/03/21 4:43 pm, Guenter Roeck wrote: > On 3/15/21 7:35 PM, Chris Packham wrote: >> The BPA-RS600 is a compact 600W AC to DC removable power supply module. >> >> Signed-off-by: Chris Packham >> --- >> + >> +static int bpa_rs600_read_word_d

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Chris Packham
On 16/03/21 4:35 pm, Guenter Roeck wrote: > On 3/15/21 8:30 PM, Chris Packham wrote: >> On 16/03/21 3:35 pm, Chris Packham wrote: >>> The BPA-RS600 is a compact 600W AC to DC removable power supply module. >>> >>> Signed-off-by: Chris Packham >&

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Chris Packham
On 16/03/21 3:35 pm, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham > > +static const struct of_device_id __maybe_unused bpa_rs600_of_match[] = { > + { .compatible = "blutek,bpa-rs600&q

[PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Chris Packham
The BPA-RS600 is a compact 600W AC to DC removable power supply module. Signed-off-by: Chris Packham --- Documentation/hwmon/bpa-rs600.rst | 74 drivers/hwmon/pmbus/Kconfig | 10 ++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/bpa-rs600.c | 179

[PATCH 1/2] dt-bindings: Add vendor prefix and trivial device for BluTek BPA-RS600

2021-03-15 Thread Chris Packham
Add vendor prefix "blutek" for BluTek Power. Add trivial device entry for BPA-RS600. Signed-off-by: Chris Packham --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 2 files changed, 4 insertions(+)

Re: Errant readings on LM81 with T2080 SoC

2021-03-14 Thread Chris Packham
On 12/03/21 10:25 pm, David Laight wrote: > From: Linuxppc-dev Guenter Roeck >> Sent: 11 March 2021 21:35 >> >> On 3/11/21 1:17 PM, Chris Packham wrote: >>> On 11/03/21 9:18 pm, Wolfram Sang wrote: >>>>> Bummer. What is really weird is that you see cl

[PATCH] hwmon: (pmbus): Fix Documentation kernel-doc warning

2021-03-11 Thread Chris Packham
Fix Documentation/hwmon/ kernel-doc warning: Documentation/hwmon/ir36021.rst:34: WARNING: Malformed table. No bottom table border found. Fixes: 0be9fee30ff9 ("hwmon: (pmbus) Add driver for Infineon IR36021") Signed-off-by: Chris Packham --- Documentation/hwmon/ir36021.rst | 1 + 1 fi

Re: linux-next: build warning after merge of the hwmon-staging tree

2021-03-11 Thread Chris Packham
On 12/03/21 4:50 pm, Stephen Rothwell wrote: > Hi all, > > After merging the hwmon-staging tree, today's linux-next build (htmldocs) > produced this warning: > > Documentation/hwmon/ir36021.rst:34: WARNING: Malformed table. > No bottom table border found. > > ===

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Chris Packham
On 12/03/21 1:07 pm, Guenter Roeck wrote: > On 3/11/21 3:47 PM, Chris Packham wrote: >> On 12/03/21 10:34 am, Guenter Roeck wrote: >>> On 3/11/21 1:17 PM, Chris Packham wrote: >>>> On 11/03/21 9:18 pm, Wolfram Sang wrote: >>>>>> Bummer. What is rea

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Chris Packham
On 12/03/21 10:34 am, Guenter Roeck wrote: > On 3/11/21 1:17 PM, Chris Packham wrote: >> On 11/03/21 9:18 pm, Wolfram Sang wrote: >>>> Bummer. What is really weird is that you see clock stretching under >>>> CPU load. Normally clock stretching is triggered by

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Chris Packham
On 11/03/21 9:18 pm, Wolfram Sang wrote: >> Bummer. What is really weird is that you see clock stretching under >> CPU load. Normally clock stretching is triggered by the device, not >> by the host. > One example: Some hosts need an interrupt per byte to know if they > should send ACK or NACK.

Re: Errant readings on LM81 with T2080 SoC

2021-03-10 Thread Chris Packham
On 10/03/21 6:06 pm, Guenter Roeck wrote: > On 3/9/21 6:19 PM, Chris Packham wrote: >> On 9/03/21 9:27 am, Chris Packham wrote: >>> On 8/03/21 5:59 pm, Guenter Roeck wrote: >>>> Other than that, the only other real idea I have would be to monitor >>>&

[PATCH] hwmon: (adm9240): Don't re-read config/limits

2021-03-09 Thread Chris Packham
-off-by: Chris Packham --- This doesn't resolve my ongoing i2c issues[0] but avoiding unnecessary i2c reads will help a bit (it'll certainly avoid errors where the threshold spontaneously changes). [0] - https://lore.kernel.org/lkml/8e0a88ba-01e9-9bc1-c78b-20f26ce27...@alliedtelesis.co.nz

Re: Errant readings on LM81 with T2080 SoC

2021-03-09 Thread Chris Packham
On 9/03/21 9:27 am, Chris Packham wrote: > On 8/03/21 5:59 pm, Guenter Roeck wrote: >> Other than that, the only other real idea I have would be to monitor >> the i2c bus. > I am in the fortunate position of being able to go into the office and > even happen to hav

Re: Errant readings on LM81 with T2080 SoC

2021-03-09 Thread Chris Packham
On 8/03/21 1:31 pm, Guenter Roeck wrote: > On 3/7/21 2:52 PM, Chris Packham wrote: >> Fundamentally I think this is a problem with the fact that the LM81 is >> an SMBus device but the T2080 (and other Freescale SoCs) uses i2c and we >> emulate SMBus. I suspect the errant

Re: Errant readings on LM81 with T2080 SoC

2021-03-08 Thread Chris Packham
On 9/03/21 11:10 am, Chris Packham wrote: > > On 8/03/21 5:59 pm, Guenter Roeck wrote: >> On 3/7/21 8:37 PM, Chris Packham wrote: >> [ ... ] >>>> That's from -ENXIO which is used in only one place in i2c-mpc.c. I'll >>>> enable some debug and se

Re: Errant readings on LM81 with T2080 SoC

2021-03-08 Thread Chris Packham
On 8/03/21 5:59 pm, Guenter Roeck wrote: > On 3/7/21 8:37 PM, Chris Packham wrote: > [ ... ] >>> That's from -ENXIO which is used in only one place in i2c-mpc.c. I'll >>> enable some debug and see what we get. >> For the errant readings there was nothing a

Re: Errant readings on LM81 with T2080 SoC

2021-03-08 Thread Chris Packham
On 8/03/21 5:59 pm, Guenter Roeck wrote: > On 3/7/21 8:37 PM, Chris Packham wrote: > [ ... ] >>> That's from -ENXIO which is used in only one place in i2c-mpc.c. I'll >>> enable some debug and see what we get. >> For the errant readings there was nothing a

Re: Errant readings on LM81 with T2080 SoC

2021-03-07 Thread Chris Packham
On 8/03/21 3:27 pm, Chris Packham wrote: > > On 8/03/21 1:31 pm, Guenter Roeck wrote: >> On 3/7/21 2:52 PM, Chris Packham wrote: >>> Hi, >>> >>> I've got a system using a PowerPC T2080 SoC and among other things has >>> an LM81 hwmon chip. >>&

Re: Errant readings on LM81 with T2080 SoC

2021-03-07 Thread Chris Packham
On 8/03/21 1:31 pm, Guenter Roeck wrote: > On 3/7/21 2:52 PM, Chris Packham wrote: >> Hi, >> >> I've got a system using a PowerPC T2080 SoC and among other things has >> an LM81 hwmon chip. >> >> Under a high CPU load we see errant readings from the L

Errant readings on LM81 with T2080 SoC

2021-03-07 Thread Chris Packham
Hi, I've got a system using a PowerPC T2080 SoC and among other things has an LM81 hwmon chip. Under a high CPU load we see errant readings from the LM81 as well as actual failures. It's the errant readings that cause the most concern since we can easily ignore the read errors in our

[PATCH] i2c: mpc: Make use of i2c_recover_bus()

2021-03-02 Thread Chris Packham
Move the existing calls of mpc_i2c_fixup() to a recovery function registered via bus_recovery_info. This makes it more obvious that recovery is supported and allows for a future where recover is triggered by the i2c core. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 18

[PATCH v2 2/2] hwmon: (pmbus): Add driver for Infineon IR36021

2021-02-28 Thread Chris Packham
The IR36021 is a dual‐loop digital multi‐phase buck controller. Signed-off-by: Chris Packham --- Changes in v2: - update against latest kernel for pmbus API changes - avoid double negation Documentation/hwmon/index.rst | 1 + Documentation/hwmon/ir36021.rst | 62

[PATCH v2 1/2] dt-bindings: trivial-devices: Add infineon,ir36021

2021-02-28 Thread Chris Packham
Add infineon,ir36021 to trivial-devices.yaml. Signed-off-by: Chris Packham --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial

[PATCH v2 0/2] hwmon: (pmbus): Infineon IR36021 driver

2021-02-28 Thread Chris Packham
This adds a basic driver for the IR36021. This chip as both a PMBUS and I2C interface that is available simultaenously. This driver is just the PMBUS interface. Chris Packham (2): dt-bindings: trivial-devices: Add infineon,ir36021 hwmon: (pmbus): Add driver for Infineon IR36021

[PATCH 2/2] hwmon: (pmbus): Add driver for Infineon IR36021

2021-02-28 Thread Chris Packham
The IR36021 is a dual‐loop digital multi‐phase buck controller. Signed-off-by: Chris Packham --- Documentation/hwmon/index.rst | 1 + Documentation/hwmon/ir36021.rst | 62 + drivers/hwmon/pmbus/Kconfig | 9 drivers/hwmon/pmbus/Makefile| 1 + drivers

[PATCH 1/2] dt-bindings: trivial-devices: Add infineon,ir36021

2021-02-28 Thread Chris Packham
Add infineon,ir36021 to trivial-devices.yaml. Signed-off-by: Chris Packham --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial

[PATCH 0/2] hwmon: (pmbus): Infineon IR36021 driver

2021-02-28 Thread Chris Packham
This adds a basic driver for the IR36021. This chip as both a PMBUS and I2C interface that is available simultaenously. This driver is just the PMBUS interface. Chris Packham (2): dt-bindings: trivial-devices: Add infineon,ir36021 hwmon: (pmbus): Add driver for Infineon IR36021

Re: [PATCH v2] of/fdt: Remove redundant kbasename function call

2021-01-26 Thread Chris Packham
On 26/01/21 3:06 pm, Rob Herring wrote: > +LAKML given it's an Arm issue > > On Mon, Jan 25, 2021 at 6:47 PM Chris Packham > wrote: >> Hi All, >> >> On 29/05/20 1:25 am, Qi Zheng wrote: >>> For version 1 to 3 of the device tree, this is the node fu

[PATCH] of/fdt: Check against '/chosen' in early_init_dt_scan_chosen

2021-01-26 Thread Chris Packham
of_scan_flat_dt() passes the name of the visited node to the iterator. In the case of '/chosen' this includes the leading '/'. Update early_init_dt_scan_chosen() to expect this. Fixes: 7536c7e03e74 ("of/fdt: Remove redundant kbasename function call") Signed-off-by: Chris Packham --

Re: [PATCH v2] of/fdt: Remove redundant kbasename function call

2021-01-26 Thread Chris Packham
Hi All, On 29/05/20 1:25 am, Qi Zheng wrote: > For version 1 to 3 of the device tree, this is the node full > path as a zero terminated string, starting with "/". The > following equation will not hold, since the node name has > been processed in the fdt_get_name(). > > *pathp == '/' > >

Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

2021-01-26 Thread Chris Packham
Hi All, On 12/11/20 9:02 pm, Thomas Petazzoni wrote: > On Thu, 12 Nov 2020 16:21:49 +1300 > Chris Packham wrote: > >> make coccicheck complains: >> >>./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on >> line 1106 and execution via condi

Re: orion-nand: uncorrectable ECC error on v5.10-rc6

2020-12-02 Thread Chris Packham
Hi Miquel, On 2/12/20 9:31 pm, Miquel Raynal wrote: > Hi Chris, > > Chris Packham wrote on Wed, 2 Dec > 2020 08:23:13 +: > >> Hi Miquel, >> >> On 2/12/20 8:59 pm, Miquel Raynal wrote: >>> Hi Chris, >>> >>> Chris Packham

Re: orion-nand: uncorrectable ECC error on v5.10-rc6

2020-12-02 Thread Chris Packham
Hi Miquel, On 2/12/20 8:59 pm, Miquel Raynal wrote: > Hi Chris, > > Chris Packham wrote on Wed, 2 Dec > 2020 07:47:32 +: > >> Hi, >> >> I've just booted v5.10-rc6 on a kirkwood based board (which uses the >> orion-nand driver) and I get the followin

orion-nand: uncorrectable ECC error on v5.10-rc6

2020-12-01 Thread Chris Packham
Hi, I've just booted v5.10-rc6 on a kirkwood based board (which uses the orion-nand driver) and I get the following errors reported. I haven't started bisecting yet but v5.7.19 mounts the nand flash without any issue. ubi0: attaching mtd0 __nand_correct_data: uncorrectable ECC error ubi0

Re: [PATCH v2] ARM: dts: mvebu: Add device tree for ATL-x530 Board

2020-11-30 Thread Chris Packham
On 1/12/20 12:03 pm, Andrew Lunn wrote: > On Tue, Dec 01, 2020 at 11:35:07AM +1300, Aryan Srivastava wrote: >> Add device tree file for x530 board. This has an Armada 385 SoC. Has >> NAND-flash for user storage and SPI for booting. Covers majority of x530 >> and GS980MX variants. > Hi Aryan > >

[net-next PATCH] net: freescale: ucc_geth: remove unused SKB_ALLOC_TIMEOUT

2020-11-29 Thread Chris Packham
This was added in commit ce973b141dfa ("[PATCH] Freescale QE UCC gigabit ethernet driver") but doesn't appear to have been used. Remove it now. Signed-off-by: Chris Packham --- drivers/net/ethernet/freescale/ucc_geth.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ne

[net-next PATCH v5 2/4] net: dsa: mv88e6xxx: Support serdes ports on MV88E6097/6095/6185

2020-11-23 Thread Chris Packham
Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for the MV88E6097/6095/6185 so that ports 8 & 9 can be supported as serdes ports and directly connected to other network interfaces or to SFPs without a PHY. Signed-off-by: Chris Packham Reviewed-by: Andrew Lunn --- Cha

[net-next PATCH v5 1/4] net: dsa: mv88e6xxx: Don't force link when using in-band-status

2020-11-23 Thread Chris Packham
es because we're forcing the link. To address this introduce a new device specific op port_sync_link() and push the logic from mv88e6xxx_mac_link_up() into that. Provide an implementation for the 88E6185 like devices which doesn't force the link. Signed-off-by: Chris Packham --- Changes in v5

[net-next PATCH v5 4/4] net: dsa: mv88e6xxx: Handle error in serdes_get_regs

2020-11-23 Thread Chris Packham
-by: Chris Packham Reviewed-by: Andrew Lunn --- Changes in v5: - Add review from Andrew. Changes in v4: - new drivers/net/dsa/mv88e6xxx/serdes.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx

[net-next PATCH v5 3/4] net: dsa: mv88e6xxx: Add serdes interrupt support for MV88E6097

2020-11-23 Thread Chris Packham
interrupts for serdes events so unlike earlier commits the functions added here are specific to the MV88E6097. Signed-off-by: Chris Packham --- Changes in v5: - New drivers/net/dsa/mv88e6xxx/chip.c | 3 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 47 ++ drivers/net

[net-next PATCH v5 0/4] net: dsa: mv88e6xxx: serdes link without phy

2020-11-23 Thread Chris Packham
e specific op either this series will need updating to cover the mv88e6393x or the mv88e6393x series will need updating for the new op depenting on which lands first. Chris Packham (4): net: dsa: mv88e6xxx: Don't force link when using in-band-status net: dsa: mv88e6xxx: Support serdes ports on MV88E

Re: [PATCH] ARM: dts: mvebu: Add device tree for RD-AC3X-48G4X2XL board

2020-11-22 Thread Chris Packham
Hi Aryan, On 23/11/20 4:52 pm, Aryan Srivastava wrote: > Add device tree for RD-AC3X-48G4X2XL board. This has a Armada 382 SoC on > a interposer board connected to a baseboard with a Prestera AC3X ASIC > connected via PCI. > > Signed-off-by: Aryan Srivastava Reviewed-by

Re: [PATCH v5 2/2] spi: Add generic SPI multiplexer

2020-11-16 Thread Chris Packham
On 14/11/20 4:46 am, Nicolas Saenz Julienne wrote: > Upon registering spi-mux's devices through spi_add_device() the kernel gets > stuck waiting for the 'spi_add_lock' mutex to be released. The mutex happens > to > be held by spi-mux's parent SPI bus, which unluckily, is waiting for spi-mux's >

[PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

2020-11-11 Thread Chris Packham
() as the `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base` are the same thing. But this is confusing for anyone reading the code and one less complaint from coccicheck would be nice so lets fix it. Signed-off-by: Chris Packham --- I haven't included Fixes: fb52a6c4 ("bus: i

Re: [PATCH 2/2] hwmon: (adt7470) Convert to regmap

2020-10-28 Thread Chris Packham
On 24/10/20 10:40 am, Guenter Roeck wrote: > On Tue, Oct 20, 2020 at 11:34:23AM +1300, Chris Packham wrote: >> Convert the adt7470 to using regmap and add error handling. >> >> Signed-off-by: Chris Packham >> --- >> drivers/hwmon/adt7470.c | 388 ++

  1   2   3   4   5   6   7   8   9   10   >