num = rdev->chip_ctx.chip_num;
> chip_met_rev_num |= ((u32)rdev->chip_ctx.chip_rev & 0xFF) <<
> BNXT_RE_CHIP_ID0_CHIP_REV_SFT;
> --
> 2.20.1
>
Thanks that was missed!
Acked-By: Devesh Sharma
id *), (void *), NULL,
> -0);
> - return 0;
> + return bnxt_qplib_rcfw_send_message(rcfw, (void *), (void *),
> + NULL, 0);
> }
>
> int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
> --
> 2.17.1
>
Acked-By: Devesh Sharma
;
> I prefer to keep the deletion of questionable error messages separate
> from the refactoring for a bit of exception handling.
>
Okay fair enough
Series Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
>
>> The patches look good to me otherwise.
>
> Thanks for your con
onable error messages separate
> from the refactoring for a bit of exception handling.
>
Okay fair enough
Series Acked-By: Devesh Sharma
>
>> The patches look good to me otherwise.
>
> Thanks for your constructive feedback.
>
> Regards,
> Markus
> --
> To
.
You don't need 2 patches when changing same lines of code. Could
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks
Reviewed-By: Devesh Sharma <devesh.sha...@broadcom.com>
>
> Markus Elfring (2):
> Delete two error messa
you squash both and send your changes in a single patch.
The patches look good to me otherwise.
-Thanks
Reviewed-By: Devesh Sharma
>
> Markus Elfring (2):
> Delete two error messages for a failed memory allocation
> Use common error handling code
>
> drivers/infin
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Fri, Jan 5, 2018 at 2:34 AM, Jonathan Toppins <jtopp...@redhat.com> wrote:
> Reporting that a device doesn't support RoCE seems like a valuable piece
> of information to have when trying to determine why a driver is not bin
Acked-By: Devesh Sharma
On Fri, Jan 5, 2018 at 2:34 AM, Jonathan Toppins wrote:
> Reporting that a device doesn't support RoCE seems like a valuable piece
> of information to have when trying to determine why a driver is not binding
> to a device. Better to report this at info log leve
However delayed ack but still..thanks for supplying this fix.
Acked-by: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <j...@ziepe.ca> wrote:
> On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
>> The bnxt_qp
However delayed ack but still..thanks for supplying this fix.
Acked-by: Devesh Sharma
On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe wrote:
> On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
>> The bnxt_qplib_disable_nq() call is redundant as it occurs
>> a
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Sat, Apr 22, 2017 at 8:00 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Sat, 22 Apr 2017 11:33:25 +0200
>
> * Multiplications for th
Acked-By: Devesh Sharma
On Sat, Apr 22, 2017 at 8:00 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Sat, 22 Apr 2017 11:33:25 +0200
>
> * Multiplications for the size determination of memory allocations
> indicated that array data structures should be processed.
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 6:52 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 10:00:41 +0100
>
> Delete an assignment
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 6:52 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 10:00:41 +0100
>
> Delete an assignment for the local variable "status" in an if branch
> because the desired failure indication is alread
Acked-By:Devesh Sharma
On Wed, Mar 8, 2017 at 6:49 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 09:19:47 +0100
>
> * Multiplications for the size determination of memory
Acked-By:Devesh Sharma
On Wed, Mar 8, 2017 at 6:49 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 09:19:47 +0100
>
> * Multiplications for the size determination of memory allocations
> indicated that array data structures should be processed.
> Thus reuse the
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 7:04 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 12:50:14 +0100
> MIME-Version: 1.0
> Content-T
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 7:04 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 12:50:14 +0100
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The script “checkpatch.pl“ po
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 6:54 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 10:10:50 +0100
>
> Replace the specificati
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 6:54 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 10:10:50 +0100
>
> Replace the specification of a data type by a pointer dereference
> as the parameter for the operator "sizeof" to ma
Acked-By:Devesh Sharma
On Wed, Mar 8, 2017 at 6:56 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 10:48:24 +0100
>
> Return constant integer values without storing them in the
Acked-By:Devesh Sharma
On Wed, Mar 8, 2017 at 6:56 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 10:48:24 +0100
>
> Return constant integer values without storing them in the local
> variable "status".
>
> Signed-off-by: Markus Elfring
> ---
>
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 6:58 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 10:58:34 +0100
>
> 1. Return zero in on
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 6:58 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 10:58:34 +0100
>
> 1. Return zero in one case directly.
>
> 2. Return the value from a call of the function "_ocrdma_dealloc_pd"
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 7:00 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 11:11:35 +0100
>
> This issue was detected by
Acked-By: Devesh sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 6:43 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Tue, 7 Mar 2017 22:23:17 +0100
>
> Omit an extra message f
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 7:00 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 11:11:35 +0100
>
> This issue was detected by using the Coccinelle software.
>
> 1. Return directly if a call of the function "_ocrdma_alloc_pd
Acked-By: Devesh sharma
On Wed, Mar 8, 2017 at 6:43 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Tue, 7 Mar 2017 22:23:17 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> Link:
> http://events.linuxfoundation.org/site
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 6:45 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Tue, 7 Mar 2017 22:34:33 +0100
>
> The script "checkpat
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 6:45 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Tue, 7 Mar 2017 22:34:33 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> Comparison to NULL could be written &q
On Wed, Mar 8, 2017 at 6:34 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Tue, 7 Mar 2017 21:12:56 +0100
>
> Do not use curly brackets at some source code places
> where a single statement should be sufficient.
>
>
On Wed, Mar 8, 2017 at 6:34 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Tue, 7 Mar 2017 21:12:56 +0100
>
> Do not use curly brackets at some source code places
> where a single statement should be sufficient.
>
> Signed-off-by: Markus Elfring
> ---
>
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 6:50 PM, SF Markus Elfring
<elfr...@users.sourceforge.net> wrote:
> From: Markus Elfring <elfr...@users.sourceforge.net>
> Date: Wed, 8 Mar 2017 09:54:42 +0100
>
> Replace the specificati
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 6:50 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 09:54:42 +0100
>
> Replace the specification of a data type by a pointer dereference
> as the parameter for the operator "sizeof" to ma
On Wed, Mar 8, 2017 at 6:47 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 08:45:31 +0100
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure
On Wed, Mar 8, 2017 at 6:47 PM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Wed, 8 Mar 2017 08:45:31 +0100
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function
Acked-By: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 7:24 PM, Yuval Shaia <yuval.sh...@oracle.com> wrote:
> On Wed, Mar 08, 2017 at 01:45:43PM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <elfr...@users.sourceforge.net>
>> Dat
Acked-By: Devesh Sharma
On Wed, Mar 8, 2017 at 7:24 PM, Yuval Shaia wrote:
> On Wed, Mar 08, 2017 at 01:45:43PM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring
>> Date: Tue, 7 Mar 2017 19:09:20 +0100
>>
>> Replace the specification of data structures
Acked-by: Devesh Sharma <devesh.sha...@broadcom.com>
On Wed, Mar 8, 2017 at 7:52 PM, Yuval Shaia <yuval.sh...@oracle.com> wrote:
> On Wed, Mar 08, 2017 at 02:02:46PM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <elfr...@users.sourceforge.net>
>> Dat
Acked-by: Devesh Sharma
On Wed, Mar 8, 2017 at 7:52 PM, Yuval Shaia wrote:
> On Wed, Mar 08, 2017 at 02:02:46PM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring
>> Date: Tue, 7 Mar 2017 20:33:29 +0100
>>
>> Replace the specification of a data structu
We missed to ack this patch. Thanks Dough and Johannes.
acked-by: Devesh Sharma
On Thu, Jul 9, 2015 at 3:13 AM, Doug Ledford wrote:
> On 07/08/2015 11:23 AM, Johannes Thumshirn wrote:
>> Destroy ocrdma_dev_id IDR on module exit, reclaiming the allocated memory.
>>
>
We missed to ack this patch. Thanks Dough and Johannes.
acked-by: Devesh Sharma devesh.sha...@avagotech.com
On Thu, Jul 9, 2015 at 3:13 AM, Doug Ledford dledf...@redhat.com wrote:
On 07/08/2015 11:23 AM, Johannes Thumshirn wrote:
Destroy ocrdma_dev_id IDR on module exit, reclaiming
Acked-By: Devesh Sharma
On Fri, Jun 5, 2015 at 8:17 PM, Colin King wrote:
> From: Colin Ian King
>
> A reorganisation of the PD allocation and deallocation in commit
> 9ba1377daa ("RDMA/ocrdma: Move PD resource management to driver.")
> introduced a double free on
Acked-By: Devesh Sharma devesh.sha...@avagotech.com
On Fri, Jun 5, 2015 at 8:17 PM, Colin King colin.k...@canonical.com wrote:
From: Colin Ian King colin.k...@canonical.com
A reorganisation of the PD allocation and deallocation in commit
9ba1377daa (RDMA/ocrdma: Move PD resource management
Thanks Laurent,
My earlier mail bounced back from Linux-kernel mailing list, thus
resending.
CC'ing Doug.
Acked-By: Devesh Sharma
> -Original Message-
> From: Laurent Navet [mailto:laurent.na...@gmail.com]
> Sent: Wednesday, May 27, 2015 12:46 AM
> To: a...@linux-foundat
Although already applied, Thanks Laurent and Doug.
Acked-By: Devesh Sharma
> -Original Message-
> From: Doug Ledford [mailto:dledf...@redhat.com]
> Sent: Tuesday, May 26, 2015 6:15 PM
> To: Laurent Navet
> Cc: selvin.xav...@emulex.com; devesh.sha...@emulex.com;
> mites
Thanks Laurent,
My earlier mail bounced back from Linux-kernel mailing list, thus
resending.
CC'ing Doug.
Acked-By: Devesh Sharma devesh.sha...@avagotech.com
-Original Message-
From: Laurent Navet [mailto:laurent.na...@gmail.com]
Sent: Wednesday, May 27, 2015 12:46 AM
Although already applied, Thanks Laurent and Doug.
Acked-By: Devesh Sharma devesh.sha...@avagotech.com
-Original Message-
From: Doug Ledford [mailto:dledf...@redhat.com]
Sent: Tuesday, May 26, 2015 6:15 PM
To: Laurent Navet
Cc: selvin.xav...@emulex.com; devesh.sha...@emulex.com
Reviewed-by: Devesh Sharma
On Tue, May 5, 2015 at 8:10 PM, Michael Wang wrote:
>
>
> On 05/05/2015 04:16 PM, Or Gerlitz wrote:
>> On 5/5/2015 3:50 PM, Michael Wang wrote:
>>> Since v7:
>>>* Thanks to Doug, Ira, Devesh for the testing:-)
>>>*
Reviewed-by: Devesh Sharma devesh.sha...@avagotech.com
On Tue, May 5, 2015 at 8:10 PM, Michael Wang yun.w...@profitbricks.com wrote:
On 05/05/2015 04:16 PM, Or Gerlitz wrote:
On 5/5/2015 3:50 PM, Michael Wang wrote:
Since v7:
* Thanks to Doug, Ira, Devesh for the testing:-)
* Thanks
Tested-By: Devesh Sharma
I am still in process of reviewing the series. Will respond soon.
-Regards
Devesh
> -Original Message-
> From: Michael Wang [mailto:yun.w...@profitbricks.com]
> Sent: Friday, April 24, 2015 6:43 PM
> To: Roland Dreier; Sean Hefty; Hal Rosenst
Tested-By: Devesh Sharma devesh.sha...@emulex.com
I am still in process of reviewing the series. Will respond soon.
-Regards
Devesh
-Original Message-
From: Michael Wang [mailto:yun.w...@profitbricks.com]
Sent: Friday, April 24, 2015 6:43 PM
To: Roland Dreier; Sean Hefty; Hal
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of Doug Ledford
> Sent: Wednesday, April 22, 2015 8:33 PM
> To: Michael Wang
> Cc: Roland Dreier; Sean Hefty; linux-r...@vger.kernel.org; linux-
> ker...@vger.kernel.org;
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Doug Ledford
Sent: Wednesday, April 22, 2015 8:33 PM
To: Michael Wang
Cc: Roland Dreier; Sean Hefty; linux-r...@vger.kernel.org; linux-
ker...@vger.kernel.org;
> Sent: Tuesday, April 21, 2015 1:17 PM
> To: Devesh Sharma; Roland Dreier; Sean Hefty; Hal Rosenstock; linux-
> r...@vger.kernel.org; linux-kernel@vger.kernel.org; h...@dev.mellanox.co.il
> Cc: Tom Tucker; Steve Wise; Hoang-Nam Nguyen; Christoph Raisch; Mike
> Marciniszyn; Eli Cohe
Looks good, I would like to test with ocrdma before confirming.
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of Michael Wang
> Sent: Monday, April 20, 2015 2:08 PM
> To: Roland Dreier; Sean Hefty;
Looks good, I would like to test with ocrdma before confirming.
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Michael Wang
Sent: Monday, April 20, 2015 2:08 PM
To: Roland Dreier; Sean Hefty;
, April 21, 2015 1:17 PM
To: Devesh Sharma; Roland Dreier; Sean Hefty; Hal Rosenstock; linux-
r...@vger.kernel.org; linux-kernel@vger.kernel.org; h...@dev.mellanox.co.il
Cc: Tom Tucker; Steve Wise; Hoang-Nam Nguyen; Christoph Raisch; Mike
Marciniszyn; Eli Cohen; Faisal Latif; Jack Morgenstein
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of Michael Wang
> Sent: Monday, April 20, 2015 2:08 PM
> To: Roland Dreier; Sean Hefty; linux-r...@vger.kernel.org; linux-
> ker...@vger.kernel.org; h...@dev.mellanox.co.il
Hi Michael,
is there a specific git branch available to pull out all the patches?
-Regards
Devesh
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
> ow...@vger.kernel.org] On Behalf Of Michael Wang
> Sent: Monday, April 20, 2015 1:59 PM
> To: Roland
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Michael Wang
Sent: Monday, April 20, 2015 2:08 PM
To: Roland Dreier; Sean Hefty; linux-r...@vger.kernel.org; linux-
ker...@vger.kernel.org; h...@dev.mellanox.co.il
Cc:
Hi Michael,
is there a specific git branch available to pull out all the patches?
-Regards
Devesh
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Michael Wang
Sent: Monday, April 20, 2015 1:59 PM
To: Roland Dreier;
Thanks Roland,
My response is inline below.
-Regards
Devesh
-Original Message-
From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of
Roland Dreier
Sent: Saturday, March 08, 2014 1:02 AM
To: Devesh Sharma
Cc: Nicholas A. Bellinger; Or Gerlitz; Hefty Sean; linux-rdma
Thanks Roland,
My response is inline below.
-Regards
Devesh
-Original Message-
From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of
Roland Dreier
Sent: Saturday, March 08, 2014 1:02 AM
To: Devesh Sharma
Cc: Nicholas A. Bellinger; Or Gerlitz; Hefty Sean; linux-rdma
Hi Roland,
Is it okay to send next series of patches even if previous series is not
accepted yet in your tree? Off-course I will cut patches on top of previous
series of patches.
-Regards
Devesh
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
Hi Roland,
Is it okay to send next series of patches even if previous series is not
accepted yet in your tree? Off-course I will cut patches on top of previous
series of patches.
-Regards
Devesh
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
Hello all,
I am facing some difficulty to implement compat_ioctl entry point in
my driver code, please help me out to sort out the things.
The ioctl is READ WRITE type,
It takes one header structure as argument the structure is as follows,
typedef struct
{
unsigned int Header;
Hello all,
I am facing some difficulty to implement compat_ioctl entry point in
my driver code, please help me out to sort out the things.
The ioctl is READ WRITE type,
It takes one header structure as argument the structure is as follows,
typedef struct
{
unsigned int Header;
68 matches
Mail list logo