Re: [PATCH v3] PCI/AER: Enable reporting for ports enumerated after AER driver registration

2018-10-12 Thread Dongdong Liu
在 2018/10/11 23:57, Keith Busch 写道: On Thu, Oct 11, 2018 at 08:26:18AM -0700, Bjorn Helgaas wrote: From: Bjorn Helgaas Previously we enabled AER error reporting only for Switch Ports that were enumerated prior to registering the AER service driver. Switch Ports enumerated after AER driver

Re: [PATCH v3] PCI/AER: Enable reporting for ports enumerated after AER driver registration

2018-10-12 Thread Dongdong Liu
在 2018/10/11 23:57, Keith Busch 写道: On Thu, Oct 11, 2018 at 08:26:18AM -0700, Bjorn Helgaas wrote: From: Bjorn Helgaas Previously we enabled AER error reporting only for Switch Ports that were enumerated prior to registering the AER service driver. Switch Ports enumerated after AER driver

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-11 Thread Dongdong Liu
Hi Bjorn commit 15a6711649915ca3e9d1086dc88ff4b616b99aac Author: Bjorn Helgaas Date: Tue Oct 9 17:25:25 2018 -0500 PCI/AER: Enable reporting for ports enumerated after AER driver registration Previously we enabled AER error reporting only for Switch Ports that were enumerated

Re: [PATCH] PCI/portdrv: Enable error reporting on managed ports

2018-10-11 Thread Dongdong Liu
Hi Bjorn commit 15a6711649915ca3e9d1086dc88ff4b616b99aac Author: Bjorn Helgaas Date: Tue Oct 9 17:25:25 2018 -0500 PCI/AER: Enable reporting for ports enumerated after AER driver registration Previously we enabled AER error reporting only for Switch Ports that were enumerated

Re: [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity

2017-11-13 Thread Dongdong Liu
在 2017/11/9 3:13, Tyler Baicar 写道: Currently the GHES code only calls into the AER driver for recoverable type errors. This is incorrect because errors of other severities do not get logged by the AER driver and do not get exposed to user space via the AER trace event. So, call into the AER

Re: [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity

2017-11-13 Thread Dongdong Liu
在 2017/11/9 3:13, Tyler Baicar 写道: Currently the GHES code only calls into the AER driver for recoverable type errors. This is incorrect because errors of other severities do not get logged by the AER driver and do not get exposed to user space via the AER trace event. So, call into the AER

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-26 Thread Dongdong Liu
在 2017/4/27 1:24, Jingoo Han 写道: On Wednesday, April 26, 2017 6:54 AM, Dongdong Liu wrote; Tested-by: Dongdong Liu <liudongdo...@huawei.com> I tested the patchset on HiSilicon ARM64 D05 board.It works ok with 82599 netcard. Thank you for testing these patches. HiSilicon PCIe m

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-26 Thread Dongdong Liu
在 2017/4/27 1:24, Jingoo Han 写道: On Wednesday, April 26, 2017 6:54 AM, Dongdong Liu wrote; Tested-by: Dongdong Liu I tested the patchset on HiSilicon ARM64 D05 board.It works ok with 82599 netcard. Thank you for testing these patches. HiSilicon PCIe may use Designware-based PCIe

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-26 Thread Dongdong Liu
Tested-by: Dongdong Liu <liudongdo...@huawei.com> I tested the patchset on HiSilicon ARM64 D05 board.It works ok with 82599 netcard. Thanks, Dongdong 在 2017/4/25 14:40, Jon Masters 写道: On 04/19/2017 12:48 PM, Lorenzo Pieralisi wrote: On some platforms (ie ARM/ARM64) ioremap fails to

Re: [PATCH v4 00/21] PCI: fix config space memory mappings

2017-04-26 Thread Dongdong Liu
Tested-by: Dongdong Liu I tested the patchset on HiSilicon ARM64 D05 board.It works ok with 82599 netcard. Thanks, Dongdong 在 2017/4/25 14:40, Jon Masters 写道: On 04/19/2017 12:48 PM, Lorenzo Pieralisi wrote: On some platforms (ie ARM/ARM64) ioremap fails to comply with the PCI

Re: [PATCH V6 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-12-22 Thread Dongdong Liu
Hi Ming The latest patchset is [PATCH v11 00/15] PCI: ARM64 ECAM quirks You can get them from https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git (pci/ecam) Thanks Dongdong 在 2016/12/22 16:31, Ming Lei 写道: Hi Dongdong, On Tue, Nov 22, 2016 at 8:08 PM, Dongdong Liu <liudon

Re: [PATCH V6 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-12-22 Thread Dongdong Liu
Hi Ming The latest patchset is [PATCH v11 00/15] PCI: ARM64 ECAM quirks You can get them from https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git (pci/ecam) Thanks Dongdong 在 2016/12/22 16:31, Ming Lei 写道: Hi Dongdong, On Tue, Nov 22, 2016 at 8:08 PM, Dongdong Liu wrote

Re: [PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-22 Thread Dongdong Liu
Hi Tomasz 在 2016/11/23 9:44, Dongdong Liu 写道: Hi Tomasz 在 2016/11/22 20:32, Tomasz Nowicki 写道: Hi Dongdong, On 22.11.2016 13:08, Dongdong Liu wrote: The acpi_get_rc_resources() is used to get the RC register address that can not be described in MCFG. It takes the _HID to look

Re: [PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-22 Thread Dongdong Liu
Hi Tomasz 在 2016/11/23 9:44, Dongdong Liu 写道: Hi Tomasz 在 2016/11/22 20:32, Tomasz Nowicki 写道: Hi Dongdong, On 22.11.2016 13:08, Dongdong Liu wrote: The acpi_get_rc_resources() is used to get the RC register address that can not be described in MCFG. It takes the _HID to look

Re: [PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-22 Thread Dongdong Liu
Hi Tomasz 在 2016/11/22 20:32, Tomasz Nowicki 写道: Hi Dongdong, On 22.11.2016 13:08, Dongdong Liu wrote: The acpi_get_rc_resources() is used to get the RC register address that can not be described in MCFG. It takes the _HID to look for and returns the RC address resource. Use PNP0C02 devices

Re: [PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-22 Thread Dongdong Liu
Hi Tomasz 在 2016/11/22 20:32, Tomasz Nowicki 写道: Hi Dongdong, On 22.11.2016 13:08, Dongdong Liu wrote: The acpi_get_rc_resources() is used to get the RC register address that can not be described in MCFG. It takes the _HID to look for and returns the RC address resource. Use PNP0C02 devices

[PATCH V6 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-22 Thread Dongdong Liu
rc base addresses from PNP0C02 at the root of the ACPI namespace (under \_SB). 2. New entry in common quirk array. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> --- MAINTAINERS | 1 +

[PATCH V6 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-22 Thread Dongdong Liu
e of PNP0A03 instead of hardcode the addresses. - modify hisi_pcie_acpi_rd_conf/hisi_pcie_acpi_wr_conf() according to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers. Dongdong Liu (2): PC

[PATCH V6 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-22 Thread Dongdong Liu
rc base addresses from PNP0C02 at the root of the ACPI namespace (under \_SB). 2. New entry in common quirk array. Signed-off-by: Dongdong Liu Signed-off-by: Gabriele Paoloni --- MAINTAINERS | 1 + drivers/acpi/pci_mcfg.c | 13 + drivers/pci/host/Kconfig

[PATCH V6 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-22 Thread Dongdong Liu
e of PNP0A03 instead of hardcode the addresses. - modify hisi_pcie_acpi_rd_conf/hisi_pcie_acpi_wr_conf() according to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers. Dongdong Liu (2): PC

[PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-22 Thread Dongdong Liu
belong to. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Signed-off-by: Tomasz Nowicki <t...@semihalf.com> --- drivers/pci/pci-acpi.c | 69 ++ drivers/pci/pci.h | 4 +++ 2 files changed, 73 insertions(+) diff --git a/dri

[PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-22 Thread Dongdong Liu
belong to. Signed-off-by: Dongdong Liu Signed-off-by: Tomasz Nowicki --- drivers/pci/pci-acpi.c | 69 ++ drivers/pci/pci.h | 4 +++ 2 files changed, 73 insertions(+) diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c index d966d47

Re: [PATCH V5 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-21 Thread Dongdong Liu
Hi Rafael Many Thanks for your review. 在 2016/11/19 6:00, Rafael J. Wysocki 写道: On Fri, Nov 18, 2016 at 10:22 AM, Dongdong Liu <liudongdo...@huawei.com> wrote: The acpi_get_rc_resources() is used to get the RC register address that can not be described in MCFG. It takes the _HID t

Re: [PATCH V5 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-21 Thread Dongdong Liu
Hi Rafael Many Thanks for your review. 在 2016/11/19 6:00, Rafael J. Wysocki 写道: On Fri, Nov 18, 2016 at 10:22 AM, Dongdong Liu wrote: The acpi_get_rc_resources() is used to get the RC register address that can not be described in MCFG. It takes the _HID to look for and outputs the RC address

[PATCH V5 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-18 Thread Dongdong Liu
rc base addresses from PNP0C02 at the root of the ACPI namespace (under \_SB). 2. New entry in common quirk array. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> --- MAINTAINERS | 1 +

[PATCH V5 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-18 Thread Dongdong Liu
to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers. Dongdong Liu (2): PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

[PATCH V5 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-18 Thread Dongdong Liu
to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers. Dongdong Liu (2): PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

[PATCH V5 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-18 Thread Dongdong Liu
rc base addresses from PNP0C02 at the root of the ACPI namespace (under \_SB). 2. New entry in common quirk array. Signed-off-by: Dongdong Liu Signed-off-by: Gabriele Paoloni --- MAINTAINERS | 1 + drivers/acpi/pci_mcfg.c | 13 drivers/pci/host/Kconfig

[PATCH V5 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-18 Thread Dongdong Liu
belong to. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Signed-off-by: Tomasz Nowicki <t...@semihalf.com> --- drivers/pci/pci-acpi.c | 71 ++ drivers/pci/pci.h | 4 +++ 2 files changed, 75 insertions(+) diff --git a/dri

[PATCH V5 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform

2016-11-18 Thread Dongdong Liu
belong to. Signed-off-by: Dongdong Liu Signed-off-by: Tomasz Nowicki --- drivers/pci/pci-acpi.c | 71 ++ drivers/pci/pci.h | 4 +++ 2 files changed, 75 insertions(+) diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c index d966d47

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-17 Thread Dongdong Liu
uot;can't get rc base address"); return ret; } reg_base = devm_ioremap(>dev, res->start, resource_size(res)); if (!reg_base) return -ENOMEM; cfg->priv = reg_base; return 0; } On 17.11.2016 04:02, Dongdong Liu wrote: Hi Bjorn 在 2016/11/17 7:00, Bjorn

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-17 Thread Dongdong Liu
uot;can't get rc base address"); return ret; } reg_base = devm_ioremap(>dev, res->start, resource_size(res)); if (!reg_base) return -ENOMEM; cfg->priv = reg_base; return 0; } On 17.11.2016 04:02, Dongdong Liu wrote: Hi Bjorn 在 2016/11/17 7:00, Bjorn

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn 在 2016/11/17 7:00, Bjorn Helgaas 写道: On Mon, Nov 14, 2016 at 05:33:20PM -0600, Bjorn Helgaas wrote: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn 在 2016/11/17 7:00, Bjorn Helgaas 写道: On Mon, Nov 14, 2016 at 05:33:20PM -0600, Bjorn Helgaas wrote: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn 在 2016/11/17 3:31, Bjorn Helgaas 写道: On Wed, Nov 16, 2016 at 07:59:38PM +0800, Dongdong Liu wrote: Hi Bjorn Many Thanks for your review 在 2016/11/15 7:33, Bjorn Helgaas 写道: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn 在 2016/11/17 3:31, Bjorn Helgaas 写道: On Wed, Nov 16, 2016 at 07:59:38PM +0800, Dongdong Liu wrote: Hi Bjorn Many Thanks for your review 在 2016/11/15 7:33, Bjorn Helgaas 写道: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn Many Thanks for your review 在 2016/11/15 7:33, Bjorn Helgaas 写道: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we

Re: [PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-16 Thread Dongdong Liu
Hi Bjorn Many Thanks for your review 在 2016/11/15 7:33, Bjorn Helgaas 写道: On Wed, Nov 09, 2016 at 05:14:57PM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we

[PATCH V4 1/2] PCI: hisi: Add ECAM support for devices that are not RC

2016-11-09 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> Signed-off-by: Dongdo

[PATCH V4 1/2] PCI: hisi: Add ECAM support for devices that are not RC

2016-11-09 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni Signed-off-by: Dongdong Liu --- .../devicetree/bindings

[PATCH V4 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-09 Thread Dongdong Liu
resses from PNP0C02 as subdevice of PNP0A03 instead of hardcode the addresses. - modify hisi_pcie_acpi_rd_conf/hisi_pcie_acpi_wr_conf() according to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers Dongdo

[PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-09 Thread Dongdong Liu
rc base addresses from PNP0C02 as subdevice of PNP0A03. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> --- MAINTAINERS | 1 + drivers/acpi/pci_mcfg.c

[PATCH V4 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-09 Thread Dongdong Liu
resses from PNP0C02 as subdevice of PNP0A03 instead of hardcode the addresses. - modify hisi_pcie_acpi_rd_conf/hisi_pcie_acpi_wr_conf() according to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers Dongdo

[PATCH V4 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-09 Thread Dongdong Liu
rc base addresses from PNP0C02 as subdevice of PNP0A03. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu Signed-off-by: Gabriele Paoloni --- MAINTAINERS | 1 + drivers/acpi/pci_mcfg.c | 13 drivers/pci/host/Kconfig | 8

Re: [PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-02 Thread Dongdong Liu
Hi Bjorn Thanks for your review. 在 2016/11/3 7:40, Bjorn Helgaas 写道: On Thu, Oct 20, 2016 at 11:10:34AM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we

Re: [PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-11-02 Thread Dongdong Liu
Hi Bjorn Thanks for your review. 在 2016/11/3 7:40, Bjorn Helgaas 写道: On Thu, Oct 20, 2016 at 11:10:34AM +0800, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we

Re: [PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-24 Thread Dongdong Liu
Hi Lorenzo Many thanks for your review. 在 2016/10/22 0:08, Lorenzo Pieralisi 写道: On Fri, Oct 21, 2016 at 02:12:44PM +0800, Dongdong Liu wrote: [...] +static int hisi_pcie_init(struct pci_config_window *cfg) +{ + int ret; + struct acpi_device *adev = to_acpi_device(cfg->par

Re: [PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-24 Thread Dongdong Liu
Hi Lorenzo Many thanks for your review. 在 2016/10/22 0:08, Lorenzo Pieralisi 写道: On Fri, Oct 21, 2016 at 02:12:44PM +0800, Dongdong Liu wrote: [...] +static int hisi_pcie_init(struct pci_config_window *cfg) +{ + int ret; + struct acpi_device *adev = to_acpi_device(cfg->par

Re: [PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-21 Thread Dongdong Liu
Hi Rafael Thanks for your review. 在 2016/10/20 20:27, Rafael J. Wysocki 写道: On Thu, Oct 20, 2016 at 5:10 AM, Dongdong Liu <liudongdo...@huawei.com> wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any oth

Re: [PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-21 Thread Dongdong Liu
Hi Rafael Thanks for your review. 在 2016/10/20 20:27, Rafael J. Wysocki 写道: On Thu, Oct 20, 2016 at 5:10 AM, Dongdong Liu wrote: PCIe controller in Hip05/HIP06/HIP07 SoCs is not ECAM compliant. It is non ECAM only for the RC bus config space;for any other bus underneath the root bus we

[PATCH V3 1/2] PCI: hisi: Add ECAM support for devices that are not RC

2016-10-19 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> Signed-off-by: Dongdo

[PATCH V3 1/2] PCI: hisi: Add ECAM support for devices that are not RC

2016-10-19 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni Signed-off-by: Dongdong Liu --- .../devicetree/bindings

[PATCH V3 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-19 Thread Dongdong Liu
A03 instead of hardcode the addresses. - modify hisi_pcie_acpi_rd_conf/hisi_pcie_acpi_wr_conf() according to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers Dongdong Liu (2): PCI: hisi: Add ECAM s

[PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-19 Thread Dongdong Liu
rc base addresses from PNP0C02 as subdevice of PNP0A03. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> --- MAINTAINERS | 1 + drivers/acpi/pci_mcfg.c

[PATCH V3 0/2] Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-19 Thread Dongdong Liu
A03 instead of hardcode the addresses. - modify hisi_pcie_acpi_rd_conf/hisi_pcie_acpi_wr_conf() according to Arnd comments. v1 -> v2: - rebase against Tomasz RFC V5 quirk mechanism - add ACPI support for the HiSilicon Hip07 SoC PCIe controllers Dongdong Liu (2): PCI: hisi: Add ECAM s

[PATCH V3 2/2] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-10-19 Thread Dongdong Liu
rc base addresses from PNP0C02 as subdevice of PNP0A03. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu Signed-off-by: Gabriele Paoloni --- MAINTAINERS | 1 + drivers/acpi/pci_mcfg.c | 15 drivers/pci/host/Kconfig | 8

Re: [PATCH V6 2/5] PCI/ACPI: Check platform specific ECAM quirks

2016-09-13 Thread Dongdong Liu
Hi Tomasz 在 2016/9/13 14:32, Tomasz Nowicki 写道: Hi Liu, On 13.09.2016 04:36, Dongdong Liu wrote: Hi Tomasz 在 2016/9/10 3:24, Tomasz Nowicki 写道: Some platforms may not be fully compliant with generic set of PCI config accessors. For these cases we implement the way to overwrite CFG accessors

Re: [PATCH V6 2/5] PCI/ACPI: Check platform specific ECAM quirks

2016-09-13 Thread Dongdong Liu
Hi Tomasz 在 2016/9/13 14:32, Tomasz Nowicki 写道: Hi Liu, On 13.09.2016 04:36, Dongdong Liu wrote: Hi Tomasz 在 2016/9/10 3:24, Tomasz Nowicki 写道: Some platforms may not be fully compliant with generic set of PCI config accessors. For these cases we implement the way to overwrite CFG accessors

Re: [PATCH V6 2/5] PCI/ACPI: Check platform specific ECAM quirks

2016-09-12 Thread Dongdong Liu
et CFG resource from quirk entry w/o having it in MCFG. { "OEM_ID", "OEM_TABLE_ID", , , , _ops, DEFINE_RES_MEM(START, SIZE) }, pci_generic_ecam_ops and MCFG entries will be used for platforms free from quirks. Signed-off-by: Tomasz Nowicki <t...@semihalf.com> Signed-o

Re: [PATCH V6 2/5] PCI/ACPI: Check platform specific ECAM quirks

2016-09-12 Thread Dongdong Liu
ot;OEM_ID", "OEM_TABLE_ID", , , , _ops, DEFINE_RES_MEM(START, SIZE) }, pci_generic_ecam_ops and MCFG entries will be used for platforms free from quirks. Signed-off-by: Tomasz Nowicki Signed-off-by: Dongdong Liu Signed-off-by: Christopher Covin

Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-09-01 Thread Dongdong Liu
Hi Rafael 在 2016/9/2 7:38, Rafael J. Wysocki 写道: On Thursday, September 01, 2016 11:23:42 AM Dongdong Liu wrote: 在 2016/9/1 6:56, Rafael J. Wysocki 写道: On Wednesday, August 31, 2016 07:48:14 PM Dongdong Liu wrote: Add specific quirks for PCI config space accessors.This involves: 1. New

Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-09-01 Thread Dongdong Liu
Hi Rafael 在 2016/9/2 7:38, Rafael J. Wysocki 写道: On Thursday, September 01, 2016 11:23:42 AM Dongdong Liu wrote: 在 2016/9/1 6:56, Rafael J. Wysocki 写道: On Wednesday, August 31, 2016 07:48:14 PM Dongdong Liu wrote: Add specific quirks for PCI config space accessors.This involves: 1. New

Re: [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-09-01 Thread Dongdong Liu
Hi Arnd 在 2016/9/1 22:02, Arnd Bergmann 写道: 2. We need to backward compatible with the old dt way config access as below code, so we have to call hisi_pcie_common_cfg_read() when accessing the RC config space. For this, we have to call hisi_pcie_common_cfg_read().

Re: [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-09-01 Thread Dongdong Liu
Hi Arnd 在 2016/9/1 22:02, Arnd Bergmann 写道: 2. We need to backward compatible with the old dt way config access as below code, so we have to call hisi_pcie_common_cfg_read() when accessing the RC config space. For this, we have to call hisi_pcie_common_cfg_read().

Re: [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-09-01 Thread Dongdong Liu
Hi Arnd 在 2016/9/1 15:41, Arnd Bergmann 写道: On Thursday, September 1, 2016 10:05:29 AM CEST Dongdong Liu wrote: 在 2016/8/31 19:45, Arnd Bergmann 写道: On Wednesday, August 31, 2016 7:48:12 PM CEST Dongdong Liu wrote: + +/* HipXX PCIe host only supports 32-bit config access */ +int

Re: [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-09-01 Thread Dongdong Liu
Hi Arnd 在 2016/9/1 15:41, Arnd Bergmann 写道: On Thursday, September 1, 2016 10:05:29 AM CEST Dongdong Liu wrote: 在 2016/8/31 19:45, Arnd Bergmann 写道: On Wednesday, August 31, 2016 7:48:12 PM CEST Dongdong Liu wrote: + +/* HipXX PCIe host only supports 32-bit config access */ +int

Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-08-31 Thread Dongdong Liu
在 2016/9/1 6:56, Rafael J. Wysocki 写道: On Wednesday, August 31, 2016 07:48:14 PM Dongdong Liu wrote: Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_acpi_init() to get RC config resource with hardcoded range address and setup ecam mapping

Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-08-31 Thread Dongdong Liu
在 2016/9/1 6:56, Rafael J. Wysocki 写道: On Wednesday, August 31, 2016 07:48:14 PM Dongdong Liu wrote: Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_acpi_init() to get RC config resource with hardcoded range address and setup ecam mapping

Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-08-31 Thread Dongdong Liu
在 2016/8/31 19:48, Arnd Bergmann 写道: On Wednesday, August 31, 2016 7:48:14 PM CEST Dongdong Liu wrote: +static struct hisi_rc_res rc_res[] = { + { + HIP05, + { + DEFINE_RES_MEM(0xb007, SZ_4K), + DEFINE_RES_MEM

Re: [RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-08-31 Thread Dongdong Liu
在 2016/8/31 19:48, Arnd Bergmann 写道: On Wednesday, August 31, 2016 7:48:14 PM CEST Dongdong Liu wrote: +static struct hisi_rc_res rc_res[] = { + { + HIP05, + { + DEFINE_RES_MEM(0xb007, SZ_4K), + DEFINE_RES_MEM

Re: [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-08-31 Thread Dongdong Liu
在 2016/8/31 19:45, Arnd Bergmann 写道: On Wednesday, August 31, 2016 7:48:12 PM CEST Dongdong Liu wrote: + +/* HipXX PCIe host only supports 32-bit config access */ +int hisi_pcie_common_cfg_read(void __iomem *reg_base, int where, int size, + u32 *val) +{ + u32

Re: [RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-08-31 Thread Dongdong Liu
在 2016/8/31 19:45, Arnd Bergmann 写道: On Wednesday, August 31, 2016 7:48:12 PM CEST Dongdong Liu wrote: + +/* HipXX PCIe host only supports 32-bit config access */ +int hisi_pcie_common_cfg_read(void __iomem *reg_base, int where, int size, + u32 *val) +{ + u32

[RFC PATCH V2 2/3] PCI: hisi: Add ECAM support for devices that are not RC

2016-08-31 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> Signed-off-by: Dongdo

[RFC PATCH V2 2/3] PCI: hisi: Add ECAM support for devices that are not RC

2016-08-31 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni Signed-off-by: Dongdong Liu --- .../devicetree/bindings

[RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-08-31 Thread Dongdong Liu
re-architect the Hip05/Hip06 host controllers driver to prepare for the ACPI based driver. The common functions used also by the ACPI driver have been grouped into a new "common" file. Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> Signed-off-by: Dongdon

[RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-08-31 Thread Dongdong Liu
Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_acpi_init() to get RC config resource with hardcoded range address and setup ecam mapping. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Sign

[RFC PATCH V2 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-08-31 Thread Dongdong Liu
re-architect the Hip05/Hip06 host controllers driver to prepare for the ACPI based driver. The common functions used also by the ACPI driver have been grouped into a new "common" file. Signed-off-by: Gabriele Paoloni Signed-off-by: Dongdong Liu --- MAINTAINERS

[RFC PATCH V2 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-08-31 Thread Dongdong Liu
Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_acpi_init() to get RC config resource with hardcoded range address and setup ecam mapping. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu Signed-off-by: Gabriele Paoloni

[RFC PATCH V2 0/3] Add ACPI support for Hisilicon PCIe Host Controller

2016-08-31 Thread Dongdong Liu
ers Dongdong Liu (3): PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI PCI: hisi: Add ECAM support for devices that are not RC PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers .../devicetree/bindings/pci/hisilicon-pcie.txt | 15 +- MAINTAIN

[RFC PATCH V2 0/3] Add ACPI support for Hisilicon PCIe Host Controller

2016-08-31 Thread Dongdong Liu
ers Dongdong Liu (3): PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI PCI: hisi: Add ECAM support for devices that are not RC PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers .../devicetree/bindings/pci/hisilicon-pcie.txt | 15 +- MAINTAIN

Re: [RFC PATCH V5 0/5] ECAM quirks handling for ARM64 platforms

2016-08-09 Thread Dongdong Liu
252 insertions(+), 57 deletions(-) create mode 100644 drivers/pci/host/mcfg-quirks.c create mode 100644 drivers/pci/host/mcfg-quirks.h Based on the patchset, tested on HiSilicon D03 board with intel 82599 net card. It worked OK. Tested-by: Dongdong Liu <liudongdo...@huawei.com> Thanks Dongdong

Re: [RFC PATCH V5 0/5] ECAM quirks handling for ARM64 platforms

2016-08-09 Thread Dongdong Liu
252 insertions(+), 57 deletions(-) create mode 100644 drivers/pci/host/mcfg-quirks.c create mode 100644 drivers/pci/host/mcfg-quirks.h Based on the patchset, tested on HiSilicon D03 board with intel 82599 net card. It worked OK. Tested-by: Dongdong Liu Thanks Dongdong

[RFC PATCH 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-07-11 Thread Dongdong Liu
re-architect the Hip05/Hip06 host controllers driver to prepare for the ACPI based driver. The common functions used also by the ACPI driver have been grouped into a new "common" file. Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> Signed-off-by: Dongdon

[RFC PATCH 2/3] PCI: hisi: Add ECAM support for devices that are not RC

2016-07-11 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni <gabriele.paol...@huawei.com> Signed-off-by: Dongdo

[RFC PATCH 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-07-11 Thread Dongdong Liu
Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_acpi_init() to get RC config resource with hardcoded range address and setup ecam mapping. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu <liudongdo...@huawei.com> Sign

[RFC PATCH 1/3] PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI

2016-07-11 Thread Dongdong Liu
re-architect the Hip05/Hip06 host controllers driver to prepare for the ACPI based driver. The common functions used also by the ACPI driver have been grouped into a new "common" file. Signed-off-by: Gabriele Paoloni Signed-off-by: Dongdong Liu --- MAINTAINERS

[RFC PATCH 2/3] PCI: hisi: Add ECAM support for devices that are not RC

2016-07-11 Thread Dongdong Liu
in preparation for the ACPI based driver to allow both DT and ACPI drivers to use the same BIOS (that configure the Designware iATUs). This commit doesn't break backward compatibility with previous non-ECAM platforms. Signed-off-by: Gabriele Paoloni Signed-off-by: Dongdong Liu --- .../devicetree/bindings

[RFC PATCH 3/3] PCI/ACPI: hisi: Add ACPI support for HiSilicon SoCs Host Controllers

2016-07-11 Thread Dongdong Liu
Add specific quirks for PCI config space accessors.This involves: 1. New initialization call hisi_pcie_acpi_init() to get RC config resource with hardcoded range address and setup ecam mapping. 2. New entry in common quirk array. Signed-off-by: Dongdong Liu Signed-off-by: Gabriele Paoloni

[RFC PATCH 0/3] Add ACPI support for Hisilicon PCIe Host Controller

2016-07-11 Thread Dongdong Liu
platforms(not RC). - adds the HiSilicon ACPI specific quirks. This patchset is base on Tomasz RFC V4 quirk mechanism: https://lkml.org/lkml/2016/6/28/165 Dongdong Liu (3): PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI PCI: hisi: Add ECAM support

[RFC PATCH 0/3] Add ACPI support for Hisilicon PCIe Host Controller

2016-07-11 Thread Dongdong Liu
platforms(not RC). - adds the HiSilicon ACPI specific quirks. This patchset is base on Tomasz RFC V4 quirk mechanism: https://lkml.org/lkml/2016/6/28/165 Dongdong Liu (3): PCI: hisi: re-architect Hip05/Hip06 controllers driver to preapare for ACPI PCI: hisi: Add ECAM support

Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk

2016-07-06 Thread Dongdong Liu
board may be as below comments: -Original Message- From: Dongdong Liu [mailto:liudongdo...@huawei.com] Sent: Monday, July 04, 2016 4:44 PM To: Po Liu; linux-...@vger.kernel.org; linux-arm- ker...@lists.infradead.org; linux-kernel@vger.kernel.org; devicet...@vger.kernel.org Cc

Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk

2016-07-06 Thread Dongdong Liu
board may be as below comments: -Original Message- From: Dongdong Liu [mailto:liudongdo...@huawei.com] Sent: Monday, July 04, 2016 4:44 PM To: Po Liu; linux-...@vger.kernel.org; linux-arm- ker...@lists.infradead.org; linux-kernel@vger.kernel.org; devicet...@vger.kernel.org Cc

Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk

2016-07-04 Thread Dongdong Liu
Hi Po I found a problem with the similar patch. as the below log. [4.287060] pci :80:00.0: quirk_aer_interrupt dev->irq 416 [4.293778] pcieport :80:00.0: pci_device_probe in [4.299605] pcieport :80:00.0: of_irq_parse_pci() failed with rc=-22 [4.307209] pcieport

Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk

2016-07-04 Thread Dongdong Liu
Hi Po I found a problem with the similar patch. as the below log. [4.287060] pci :80:00.0: quirk_aer_interrupt dev->irq 416 [4.293778] pcieport :80:00.0: pci_device_probe in [4.299605] pcieport :80:00.0: of_irq_parse_pci() failed with rc=-22 [4.307209] pcieport

Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk

2016-06-22 Thread Dongdong Liu
在 2016/6/14 16:24, Po Liu 写道: On some platforms, root port doesn't support MSI/MSI-X/INTx in RC mode. When chip support the aer interrupt with none MSI/MSI-X/INTx mode, maybe there is interrupt line for aer pme etc. Search the interrupt number in the fdt file. Then fixup the dev->irq with it.

Re: [PATCH v3 2/2] pci/aer: interrupt fixup in the quirk

2016-06-22 Thread Dongdong Liu
在 2016/6/14 16:24, Po Liu 写道: On some platforms, root port doesn't support MSI/MSI-X/INTx in RC mode. When chip support the aer interrupt with none MSI/MSI-X/INTx mode, maybe there is interrupt line for aer pme etc. Search the interrupt number in the fdt file. Then fixup the dev->irq with it.

Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks

2016-06-14 Thread Dongdong Liu
Hi Duc 在 2016/6/14 17:00, Duc Dang 写道: On Mon, Jun 13, 2016 at 10:51 PM, Dongdong Liu <liudongdo...@huawei.com> wrote: Hi Duc 在 2016/6/14 4:57, Duc Dang 写道: On Mon, Jun 13, 2016 at 8:47 AM, Christopher Covington <c...@codeaurora.org> wrote: Hi Dongdong, On 06/13/2016 09:02

Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks

2016-06-14 Thread Dongdong Liu
Hi Duc 在 2016/6/14 17:00, Duc Dang 写道: On Mon, Jun 13, 2016 at 10:51 PM, Dongdong Liu wrote: Hi Duc 在 2016/6/14 4:57, Duc Dang 写道: On Mon, Jun 13, 2016 at 8:47 AM, Christopher Covington wrote: Hi Dongdong, On 06/13/2016 09:02 AM, Dongdong Liu wrote: diff --git a/drivers/acpi

Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks

2016-06-13 Thread Dongdong Liu
Hi Duc 在 2016/6/14 4:57, Duc Dang 写道: On Mon, Jun 13, 2016 at 8:47 AM, Christopher Covington <c...@codeaurora.org> wrote: Hi Dongdong, On 06/13/2016 09:02 AM, Dongdong Liu wrote: diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c index d3c3e85..49612b3 100644 --- a/driver

Re: [RFC PATCH V2 1/2] ACPI/PCI: Match PCI config space accessors against platfrom specific ECAM quirks

2016-06-13 Thread Dongdong Liu
Hi Duc 在 2016/6/14 4:57, Duc Dang 写道: On Mon, Jun 13, 2016 at 8:47 AM, Christopher Covington wrote: Hi Dongdong, On 06/13/2016 09:02 AM, Dongdong Liu wrote: diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c index d3c3e85..49612b3 100644 --- a/drivers/acpi/pci_mcfg.c +++ b

  1   2   >