On Tue, Apr 20, 2021 at 12:45:04AM +0530, Deepak R Varma wrote:
> Reformat code comment blocks according to the coding style guidelines.
> This resolves different checkpatch script WARNINGs around block comments.
>
> Signed-off-by: Deepak R Varma
> ---
> .../media/atomisp/i2c/atomisp-gc2235.c
Hi,
On Tue, Apr 20, 2021 at 12:45:57AM +0530, Deepak R Varma wrote:
> Mixed case variable names are discouraged and they result in checkpatch
> script "Avoid CamelCase" warnings. Replace such CamelCase variable names
> by lower case strings according to the coding style guidelines.
>
>
Hi Deepak,
On Tue, Apr 20, 2021 at 12:46:40AM +0530, Deepak R Varma wrote:
> printk() without KERN_ facility is flagged by checkpatch as a
> warning. It is better to use pr_info() which comes with an
> inbuilt KERN_INFO level.
>
> Signed-off-by: Deepak R Varma
> ---
>
On Sun, Apr 18, 2021 at 08:13:23PM +0530, Saurav Girepunje wrote:
> Fix the following coccicheck warning:
>
> drivers/staging/media/atomisp/pci/sh_css_mipi.c:39:5-8:
> Unneeded variable: "err". Return "0" on line 44
>
> Signed-off-by: Saurav Girepunje
> ---
>
Hi,
'staging:' in mail subject is missing...
On Fri, Apr 16, 2021 at 05:20:41PM +0300, Andy Shevchenko wrote:
> The custom ->reset() repeats the generic one, replace it.
>
> Note, in newer kernels the context of the function is a sleeping one,
> it's fine to switch over to the sleeping
10 +-
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 +-
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 7 +-
> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
> drivers/staging/sm750fb/sm750_accel.c | 4 +-
> drivers/staging/vt6655/upc.h
remove unused DBG_871X_LEVEL macro declarations.
DBG_871X_LEVEL macro wraps a raw printk call which is not
recommended in a device driver context, prefer using
netdev_*() log functions.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_debug.h | 14 --
1 file
remove #ifdef block left empty after DBG_871X_LEVEL
deletion.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index
fix the following post-commit hook checkpatch issue.
WARNING: line length of 103 exceeds 100 columns
30: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:711:
+
receive_disconnect(padapter, pmlmeinfo->network.MacAddress, 0);
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/c
L(_drv_warning_, args);
+ netdev_warn(dvobj->if1->pnetdev, args);
|
- DBG_871X_LEVEL(_drv_err_, args);
+ netdev_err(dvobj->if1->pnetdev, args);
|
- DBG_871X_LEVEL(_drv_emerg_, args);
+ netdev_emerg(dvobj->if1->pnetdev, args);
)
...>
}
@@
@@
- DBG_8
fix following post-commit hook checkpatch issues:
WARNING: suspect code indent for conditional statements (32, 48)
323: FILE: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:708:
if (!ret) {
+
netdev_dbg(padapter->pnetdev,
Signed-off-by: Fabio Ai
tabs where possible
888: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:1146:
+^I^I __func__);$
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
, args);
)
...>
}
@@
@@
- DBG_871X_LEVEL(...);
Some code cleaning done as well.
Fabio Aiuto (6):
staging: rtl8723bs: replace DBG_871X_LEVEL logs with netdev_*()
staging: rtl8723bs: fix code indent issue
staging: rtl8723bs: fix indentation in if block
staging: rtl8723bs:
: warning: variable ‘ret’
> set but not used [-Wunused-but-set-variable]
>
> Cc: Greg Kroah-Hartman
> Cc: Fabio Aiuto
> Cc: Stanley@BB.SD3
> Cc: linux-stag...@lists.linux.dev
> Signed-off-by: Lee Jones
> ---
> drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++
>
On Thu, Apr 15, 2021 at 09:31:34AM +0100, Lee Jones wrote:
> On Thu, 15 Apr 2021, Fabio Aiuto wrote:
>
> > On Wed, Apr 14, 2021 at 07:10:47PM +0100, Lee Jones wrote:
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > from drivers/s
On Wed, Apr 14, 2021 at 07:10:47PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> from drivers/staging/rtl8188eu/core/rtw_security.c:10:
> drivers/staging/rtl8188eu/core/rtw_security.c:478: warning: Function
> parameter or member 'p1k' not described in 'phase1'
On Wed, Apr 14, 2021 at 06:26:14PM +0200, Fabio M. De Francesco wrote:
> Removed useless led_blink_hdl() prototype and definition. In wlancmds[]
> the slot #60 is now set to NULL using the macro GEN_MLME_EXT_HANDLER. This
> change has not unwanted side effects because the code in rtw_cmd.c checks
removed unused 'void *sel' argument in rtw_odm_dbg_comp_msg()
function, after DBG_871X_SEL_NL replacement.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_odm.h| 2 +-
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
s already accepted in v1
- Added by hand a newline after coccinelle script
application
- Dropped the patch applying newline separately
Fabio Aiuto (3):
staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()
staging: rtl8723bs: remove DBG_871X_SEL_NL macro de
ine issue
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 16 +++
drivers/staging/rtl8723bs/core/rtw_odm.c | 50 +++---
drivers/staging/rtl8723bs/hal/hal_com.c| 31 ++
3 files changed, 47 insertions(+), 50 deletions(-)
diff --git
remove DBG_871X_SEL_NL obsolete macro declaration.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_debug.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h
b/drivers/staging/rtl8723bs/include/rtw_debug.h
index
On Wed, Apr 14, 2021 at 01:52:43PM +0200, Fabio M. De Francesco wrote:
> Removed the led_blink_hdl() function (declaration and definition).
> Declared dummy_function() in include/rtw_mlme_ext.h and defined it in
> core/rtw_cmd.c. Changed the second parameter of GEN_MLME_EXT_HANDLER
> macro to make
On Wed, Apr 14, 2021 at 10:26:01AM +0200, Greg KH wrote:
> > - DBG_871X_SEL_NL(sel, "%10s %16s %8s %10s %11s %14s\n",
> > - "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base",
> > - "ForceEDCCA", "AdapEn_RSSI", "IGI_LowerBound");
> > - DBG_871X_SEL_NL(sel, "0x%-8x
fix indentation of last line in if condition.
Fixes: af6afdb63f17 (staging: rtl8723bs: split long lines)
Reported-by: Dan Carpenter
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
On Wed, Apr 14, 2021 at 08:21:50AM +0300, Dan Carpenter wrote:
> On Tue, Apr 13, 2021 at 10:08:32PM +0200, Fabio M. De Francesco wrote:
> > On Tuesday, April 13, 2021 9:48:44 PM CEST Matthew Wilcox wrote:
> > > On Tue, Apr 13, 2021 at 09:45:03PM +0200, Fabio M. De Francesco wrote:
> > > > 1) The
removed unused 'void *sel' argument in rtw_odm_dbg_comp_msg()
function, after DBG_871X_SEL_NL replacement.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_odm.h| 2 +-
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
remove dump_drv_version() and dump_log_level() function
definitions and prototypes. Those functions are unused,
and add unnecessary wrap level to log calls.
They wrap DBG_871X_SEL_NL which will be replaced by
netdev_dbg() with coccinelle script application.
Signed-off-by: Fabio Aiuto
occinelle script output coding style issue.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c
b/drivers/staging/rtl8723bs/core/rtw_odm.c
index 084
remove DBG_871X_SEL_NL obsolete macro declaration.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_debug.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h
b/drivers/staging/rtl8723bs/include/rtw_debug.h
index
remove unnecessary dump_drv_version() usage.
This prepares dump_drv_version() for removal, before
coccinelle script application.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep
coccinelle script:
@@
expression sel;
expression list args;
identifier padapter;
identifier func;
@@
func(..., struct adapter *padapter, ...) {
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(padapter->pnetdev, args);
...>
}
Signed-off-by: Fabio Aiuto
---
driver
1X_SEL_NL macro declaration.
Seventh patch removes an unused function argument after
macro replacement.
Fabio Aiuto (7):
staging: rtl8723bs: replace dump_drv_version() usage with netdev_dbg()
staging: rtl8723bs: remove unnecessary dump_drv_version() usage
staging: rtl8723bs: remove two unused
macro
replacement by coccinelle, as the semantic patch that will be
used just replaces, doesn't remove.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
On Tue, Apr 13, 2021 at 04:10:35PM +0200, Fabio Aiuto wrote:
> This patchset replaces DGB_871X_SEL_NL macro with the driver
> recommended log function netdev_dbg().
>
> Macro DBG_871X_SEL_NL indeed executes a raw printk call as
> default behaviour. The other behaviour is doi
removed unused 'void *sel' argument in rtw_odm_dbg_comp_msg()
function, after DBG_871X_SEL_NL replacement.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_odm.h| 2 +-
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
remove DBG_871X_SEL_NL obsolete macro declaration.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/rtw_debug.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h
b/drivers/staging/rtl8723bs/include/rtw_debug.h
index
occinelle script output coding style issue.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_odm.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c
b/drivers/staging/rtl8723bs/core/rtw_odm.c
index 084
remove unnecessary dump_drv_version() usage.
This prepares dump_drv_version() for removal and
further DBG_871X_SEL_NL removal.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep
is no more used and dump_log_level() which was never used.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_debug.c| 10 --
drivers/staging/rtl8723bs/include/rtw_debug.h | 3 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c
func(struct dvobj_priv *dvobj)
{
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(dvobj->if1->pnetdev, args);
...>
}
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_debug.c | 16 +++
drivers/staging/rtl8723bs/core/rtw_odm.c | 49 +++---
drive
dev_dbg(dvobj->if1->pnetdev, args);
...>
}
Fifth patch fixes a post commit checkpatch issue left
by coccinelle output.
Sixth patch removes DBG_871X_SEL_NL macro declaration.
Seventh patch removes an unused function argument after
macro replacement.
Fabio Aiuto (7):
staging:
replace dump_drv_version() usage with netdev_dbg().
The string printed is the same contained in DBG_871X_SEL_NL macro
called inside dump_drv_version().
This is just preparation before bulk DBG_871X_SEL_NL macro
replacement by coccinelle.
Signed-off-by: Fabio Aiuto
---
drivers/staging
On Tue, Apr 13, 2021 at 11:56:20AM +0200, Julia Lawall wrote:
>
>
> On Tue, 13 Apr 2021, Fabio Aiuto wrote:
>
> > Hi,
> >
> > I would like to improve the following coccinelle script:
> >
> > @@
> > expression a, fmt;
> > expression list
On Tue, Apr 13, 2021 at 11:11:38AM +0200, Greg KH wrote:
> On Tue, Apr 13, 2021 at 11:04:01AM +0200, Fabio Aiuto wrote:
> > Hi,
> >
> > I would like to improve the following coccinelle script:
> >
> > @@
> > expression a, fmt;
> > expression list var
Hi,
I would like to improve the following coccinelle script:
@@
expression a, fmt;
expression list var_args;
@@
- DBG_871X_LEVEL(a, fmt, var_args);
+ printk(fmt, var_args);
I would replace the DBG_871X_LEVEL macro with printk, but
I can't find a way to add KERN_* constant prefix
On Mon, Apr 12, 2021 at 11:38:48AM +0200, Greg KH wrote:
> On Sun, Apr 11, 2021 at 02:57:35PM +0200, Fabio Aiuto wrote:
> > fix following compiler warning issue:
> >
> >drivers/staging/rtl8723bs/hal/sdio_halinit.c:
> > In function 'CardDisableRTL8723BSdio':
>
;
|^
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 552afbaff081..28bb4aaedc5b 100644
--- a/drivers/staging
of 119 exceeds 100 columns
41: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:912:
+ HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK,
PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow);
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 --
1
_FAIL;
| ^~~
Reported-by: kernel test robot
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 209838
://lore.kernel.org/linux-staging/202104110133.bi35nins-...@intel.com/
2. Fixes two long lines checkpatch issues
3. Removes unused variable
Fabio Aiuto (3):
staging: rtl8723bs: remove unused variable ret in hal/sdio_halinit.c
staging rtl8723bs: split long lines
staging: rtl8723bs: remove unused
remove more empty if-blocks after DBG_8192C deletion.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index
remove more unnecessary parentheses after
DBG_8192C deletion.
Signed-off-by: Fabio Aiuto
---
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 21 ---
.../staging/rtl8723bs/hal/rtl8723bs_recv.c| 4 ++--
2 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers
fix following post-commit hook checkpatch issue:
CHECK: Using comparison to true is error prone
136: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:
2497:
+ if (psta->dot8021xalg != 1 ||
psta->bpairwise_key_installed == true) {
Signed-off-by: Fabio
remove empty else-block
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 39d0a0d24d2b..9c98820952e4
fix following post-commit hook checkpatch issue:
CHECK: Comparison to NULL could be written "psta"
72: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:854:
+ if (psta != NULL) {
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg8
ev->wiphy)
{
cfg80211_scan_done(pwdev_priv->scan_request, );
}
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/r
remove if and else blocks after DBG_8192C removal
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 1 -
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 -
drivers/staging/rtl8723bs/hal/sdio_ops.c | 1 -
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c
fix following post-commit hook checpatch issues:
WARNING: Comparisons should place the constant on the right side of the test
287: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:738:
+ if (_SUCCESS != ret)
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c
fix following post-commit hook checkpatch issue:
WARNING: line length of 103 exceeds 100 columns
168: FILE: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:1086:
+ if (efuse_OneByteRead(padapter, efuse_addr,
_data, bPseudoTest) == false)
Signed-off-by: Fabio Aiuto
ed around that '|' (ctx:VxV)
392: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2485:
+ if (check_fwstate(pmlmepriv, (_FW_LINKED|WIFI_AP_STATE)) != true)
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 6 +++---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80
Comparison to NULL could be written "!padapter"
481: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:240:
+ if (padapter == NULL)
CHECK: Comparison to NULL could be written "!padapter"
492: FILE: drivers/staging/rtl8723bs/os_dep/sdio_intf.c:256:
+ if (padapter == NULL)
Si
remove unnecessary bracks in if-else blocks
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-
drivers/staging/rtl8723bs/hal/hal_com.c | 3 +-
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 9 +--
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 63
remove commented out DEBUG_CFG80211 symbol definition.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/autoconf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/autoconf.h
b/drivers/staging/rtl8723bs/include/autoconf.h
index 074fee2052c9
remove empty ifdef blocks conditioned to DEBUG_CFG80211
definition.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs
remove code block guarded by SDIO_DEBUG_IO symbol.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index
remove commented out SDIO_DEBUG_IO symbol definition.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 24e45f734bdd
remove code block guarded by DBG_CCX symbol, left empty
after DBG_8192C removal.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
b/drivers/staging/rtl8723bs
remove code blocks guarded by DEBUG symbol
remove undefinition of DEBUG
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 5
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 25 ---
drivers/staging/rtl8723bs/include/autoconf.h | 5
3
remove unused code blocks guarded by never set DEBUG_RTL871X
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_debug.c| 35 ---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 20 ---
2 files changed, 55 deletions(-)
diff --git a/drivers/staging
preferred around that '-' (ctx:VxV)
89: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2431:
+ rtw_get_wps_ie(pbuf+_FIXED_IE_LENGTH_, len-_FIXED_IE_LENGTH_,
^
NULL, _ielen);
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs
remove commented out DEBUG_RTL871X definition
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include/autoconf.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/include/autoconf.h
b/drivers/staging/rtl8723bs/include/autoconf.h
index 996198750814
remove all empty if blocks left empty by coccinelle
script for DBG_8192C macro removal.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal/sdio_ops.c| 17 -
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 15 +--
2 files changed, 1 insertion
remove all DBG_8192C macro definitions.
Macro DBG_8192C belongs to a family of verbose
private tracing macros.
The default behaviour is _do nothing_, to activate
it one should define DEBUG symbol by hand.
So just remove it
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/include
remove all commented out DBG_8192C logs.
Macro DBG_8192C belongs to a family of verbose
private tracing macros.
The default behaviour is _do nothing_, to activate
it one should define DEBUG symbol by hand.
So just remove it
Signed-off-by: Fabio Aiuto
---
.../staging/rtl8723bs/core
);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i, j);
|
- DBG_8192C(a, b, c, d, e, f, g, h, i, j, k);
)
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 -
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 7 -
drivers
subsequent patches do some code cleaning in all places
left empty by deleted macro, such as empty #ifdef blocks,
conditional code blocks guarded by never defined symbols
if-else blocks, for cycles, commented debug symbol definitions,
unnecessary parentheses and some other checkpatch issues.
Fabio Aiuto (25
remove obsolete MSG_8192C macro definitions.
MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.
So just remove it.
Signed-off-by: Fabio Aiuto
---
drivers/staging
remove commented out MSG_8192C log.
MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.
So just remove it.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal
remove all MSG_8192C logs.
MSG_8192C is a private trace mechanism macro and is deactivated.
(i.e. the default behaviour is _do nothing_)
The only way to activate it is to manually define a debug
symbol.
So just remove it.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/hal
This patchset removes the tracing private macro MSG_8192C.
This macro belongs to a redundant driver specific tracing
macro family.
Moreover the default behaviour is _do nothing_ as to
activate it, it's necessary to hardcode a DEBUG symbol
definition.
Fabio Aiuto (3):
staging: rtl8723bs
On Fri, Apr 09, 2021 at 01:12:53PM +0300, Dan Carpenter wrote:
> On Mon, Apr 05, 2021 at 06:49:49PM +0200, Fabio Aiuto wrote:
> > diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> > b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
> > index 9b16265b543d
[] = {
| ^
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 6f52b8fb0d6e..e5f0cdc9711e 100644
-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 0ff6fbbb4e4f..6f52b8fb0d6e 100644
--- a/drivers/staging/rtl8723bs/os_dep
lmepriv);
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index 2f215e5e28b0..0ff6fbbb4e4f 100644
--- a/drivers/staging/rt
fix following kernel test robot warning:
At top level:
drivers/staging/rtl8723bs/include/rtw_security.h:336:28:
warning: 'K' defined but not used [-Wunused-const-variable=]
336 | static const unsigned long K[64] = {
|^
Signed-off-by: Fabio Aiuto
priv->cur_network);
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index ae74623bf1a1..2f215e5e28b0 100644
--- a/drivers/
remove unused variable. W=1 compiler issue:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:
In function ‘rtw_dbg_port’:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2448:19:
warning: unused variable ‘pstapriv’ [-Wunused-variable]
struct sta_priv *pstapriv = >stapriv;
Signed-off-by: Fa
;
^~~~
Remove also the function call that sets this variable.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
remove unused code block which does nothing.
A list is parsed but no value is written outside
the scope of the function rtw_dbg_port.
Signed-off-by: Fabio Aiuto
---
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 20 ---
1 file changed, 20 deletions(-)
diff --git a/drivers
*preorder_ctrl;
^
remove also unnecessary conditional code block.
Reported-by: kernel test robot
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging
for cycle left unused and counter variable.
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
d long cmd_start_time;
|^~
Reported-by: kernel test robot
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c
b/drivers/staging/rtl8723bs/core/rtw
el test robot output
and other local 'make W=1' compiler warnings.
Unnecessary code blocks are removed as well.
Fabio Aiuto (11):
staging: rtl8723bs: remove unused variable in core/rtw_cmd.c
staging: rtl8723bs: remove unused variable and empty for cycles left
unused in os_dep/ioctl_linux.
On Thu, Apr 08, 2021 at 11:46:15AM +0200, Greg KH wrote:
> On Thu, Apr 08, 2021 at 11:27:02AM +0200, Fabio Aiuto wrote:
> > remove declared and assigned unused variables
>
> You need to be a lot more specific here.
Shall I describe that some of these became unused
after D
remove declared and assigned unused variables
Reported-by: kernel test robot
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 3 ---
.../staging/rtl8723bs/include/rtw_security.h | 18 -
.../staging/rtl8723bs/os_dep/ioctl_linux.c| 26
On Wed, Apr 07, 2021 at 05:14:28PM +0200, Greg KH wrote:
> On Wed, Apr 07, 2021 at 03:49:24PM +0200, Fabio Aiuto wrote:
> > This patchset removes all DBG_871X usages and definitions.
> >
> > The whole private tracing system is not tied to a configuration
> > symbo
On Wed, Apr 07, 2021 at 05:30:34PM +0200, Greg KH wrote:
> On Wed, Apr 07, 2021 at 05:25:34PM +0200, Fabio Aiuto wrote:
> > On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote:
> > > On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote:
> > > > fix followi
On Wed, Apr 07, 2021 at 05:14:00PM +0200, Greg KH wrote:
> On Wed, Apr 07, 2021 at 03:49:31PM +0200, Fabio Aiuto wrote:
> > fix following post-commit hook checkpatch warnings:
> >
> > CHECK: Comparison to NULL could be written "!psta"
> > 97: FILE: drivers
lgrthm
== dot11AuthAlgrthm_8021X) &&
+ !(padapter->securitypriv.binstallGrpkey))
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
b/drivers/
f (pairwise_cipher != cur_network->BcnInfo.pairwise_cipher ||
group_cipher != cur_network->BcnInfo.group_cipher)
--
WARNING: line length of 113 exceeds 100 columns
1712: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2651:
Signed-off-by: Fabio Aiuto
---
drivers/staging/rtl8723bs/core/rtw_mlm
1 - 100 of 517 matches
Mail list logo
