[PATCH v4 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2018-02-21 Thread Florian Vaussard
nstead - Some other cosmetic fixes v1 -> v2: - Adapted the DT binding (led-max-microamp for each LED node) - Removed underscores from node names in the example - Use brightness_set_blocking to avoid workqueue - Introduced LED_to_CMD macro to avoid switch statement - Various other fixes Florian Va

[PATCH v4 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2018-02-21 Thread Florian Vaussard
nstead - Some other cosmetic fixes v1 -> v2: - Adapted the DT binding (led-max-microamp for each LED node) - Removed underscores from node names in the example - Use brightness_set_blocking to avoid workqueue - Introduced LED_to_CMD macro to avoid switch statement - Various other fixes Florian Va

[PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-21 Thread Florian Vaussard
the current on the Iref pin, hence the onnn,led-iref-microamp property. It is usually set using an external bias resistor, following Iref = Vref/Rbias with Vref=0.6V. Signed-off-by: Florian Vaussard <florian.vauss...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/b

[PATCH v4 1/2] leds: ncp5623: Add device tree binding documentation

2018-02-21 Thread Florian Vaussard
the current on the Iref pin, hence the onnn,led-iref-microamp property. It is usually set using an external bias resistor, following Iref = Vref/Rbias with Vref=0.6V. Signed-off-by: Florian Vaussard Acked-by: Rob Herring --- .../devicetree/bindings/leds/leds-ncp5623.txt | 60

[PATCH v4 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2018-02-21 Thread Florian Vaussard
) and a dedicated register (ILED), following the relationship: I = 2400*Iref/(31-ILED) with Iref = Vref/Rbias, and Vref = 0.6V. Signed-off-by: Florian Vaussard <florian.vauss...@gmail.com> --- drivers/leds/Kconfig| 11 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-ncp

[PATCH v4 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2018-02-21 Thread Florian Vaussard
) and a dedicated register (ILED), following the relationship: I = 2400*Iref/(31-ILED) with Iref = Vref/Rbias, and Vref = 0.6V. Signed-off-by: Florian Vaussard --- drivers/leds/Kconfig| 11 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-ncp5623.c | 228

[PATCH 2/2] ARM: dts: socfpga: Add support for PMU

2017-02-28 Thread Florian Vaussard
The dual Cortex-A9 MPCore inside socfpga has a standard PMU unit for each core mapped in the DAP memory space. Add support for it! Tested with perf on a Cyclone 5 SoC DK. Reported-by: Alberto Dassatti <alberto.dassa...@heig-vd.ch> Signed-off-by: Florian Vaussard <florian.vauss...@h

[PATCH 2/2] ARM: dts: socfpga: Add support for PMU

2017-02-28 Thread Florian Vaussard
The dual Cortex-A9 MPCore inside socfpga has a standard PMU unit for each core mapped in the DAP memory space. Add support for it! Tested with perf on a Cyclone 5 SoC DK. Reported-by: Alberto Dassatti Signed-off-by: Florian Vaussard Tested-by: Alberto Dassatti --- arch/arm/boot/dts

[PATCH 0/2] ARM: dts: socfpga: Add support for PMU on Arria5/Cyclone5

2017-02-28 Thread Florian Vaussard
Hi, These patches add suport for ARM Performance Monitor Units on Arria5 and Cyclone5 SoCFPGA. This was tested on a Cyclone 5 SoC DK board. Side note: the same change can be probably applied to Arria10 as well, but we do not have the hardware here to test. Regards, Florian Florian Vaussard (2

[PATCH 0/2] ARM: dts: socfpga: Add support for PMU on Arria5/Cyclone5

2017-02-28 Thread Florian Vaussard
Hi, These patches add suport for ARM Performance Monitor Units on Arria5 and Cyclone5 SoCFPGA. This was tested on a Cyclone 5 SoC DK board. Side note: the same change can be probably applied to Arria10 as well, but we do not have the hardware here to test. Regards, Florian Florian Vaussard (2

[PATCH 1/2] ARM: dts: socfpga: Add labels for CPU nodes

2017-02-28 Thread Florian Vaussard
This makes it easier to reference the CPU nodes afterwards. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/boot/dts/socfpga.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpg

[PATCH 1/2] ARM: dts: socfpga: Add labels for CPU nodes

2017-02-28 Thread Florian Vaussard
This makes it easier to reference the CPU nodes afterwards. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi index 2c43c4d..478047e 100644

Re: [PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings

2017-02-28 Thread Florian Vaussard
On 02/27/2017 05:45 PM, Dinh Nguyen wrote: > > > On 02/24/2017 11:54 PM, Florian Vaussard wrote: >> We get a bunch of warnings when compiling the SoCFPGA device trees with W=1. >> This warnings happens because some nodes have a unit name but no 'reg' >> property, &g

Re: [PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings

2017-02-28 Thread Florian Vaussard
On 02/27/2017 05:45 PM, Dinh Nguyen wrote: > > > On 02/24/2017 11:54 PM, Florian Vaussard wrote: >> We get a bunch of warnings when compiling the SoCFPGA device trees with W=1. >> This warnings happens because some nodes have a unit name but no 'reg' >> property, &g

[PATCH 2/6] ARM: dts: socfpga: Add unit name to memory nodes

2017-02-24 Thread Florian Vaussard
Memory nodes in Arria5, Cyclone5 and Arria10 do not have a unit name. This will trigger several warnings like this one (when compiled with W=1): Node /memory has a reg or ranges property, but no unit name Add the corresponding unit name to each node. Signed-off-by: Florian Vaussard

[PATCH 6/6] ARM: dts: socfpga: Do not include skeleton.dtsi

2017-02-24 Thread Florian Vaussard
leton.dtsi is useless and will produce the following warning when compiled with W=1: Node /memory has a reg or ranges property, but no unit name Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/boot/dts/socfpga.dtsi | 1 - arch/arm/boot/dts/socfpga_arria

[PATCH 1/6] ARM: dts: socfpga: Add unit name to clock nodes

2017-02-24 Thread Florian Vaussard
name to each node. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/boot/dts/socfpga.dtsi | 38 ++-- arch/arm/boot/dts/socfpga_arria10.dtsi | 46 +- 2 files changed, 42 insertions(+), 42 deletions(-) diff

[PATCH 2/6] ARM: dts: socfpga: Add unit name to memory nodes

2017-02-24 Thread Florian Vaussard
Memory nodes in Arria5, Cyclone5 and Arria10 do not have a unit name. This will trigger several warnings like this one (when compiled with W=1): Node /memory has a reg or ranges property, but no unit name Add the corresponding unit name to each node. Signed-off-by: Florian Vaussard --- arch

[PATCH 6/6] ARM: dts: socfpga: Do not include skeleton.dtsi

2017-02-24 Thread Florian Vaussard
leton.dtsi is useless and will produce the following warning when compiled with W=1: Node /memory has a reg or ranges property, but no unit name Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga.dtsi | 1 - arch/arm/boot/dts/socfpga_arria10.dtsi | 1 - 2 files changed, 2

[PATCH 1/6] ARM: dts: socfpga: Add unit name to clock nodes

2017-02-24 Thread Florian Vaussard
name to each node. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga.dtsi | 38 ++-- arch/arm/boot/dts/socfpga_arria10.dtsi | 46 +- 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 3/6] ARM: dts: socfpga: Remove unneeded unit names

2017-02-24 Thread Florian Vaussard
/usbphy@0 has a unit name, but no reg property Remove the superfluous unit names. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/boot/dts/socfpga.dtsi | 4 ++-- arch/arm/boot/dts/socfpga_arria10.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 del

[PATCH 5/6] ARM: dts: socfpga: Remove unit name for LEDs in EBV SOCrates

2017-02-24 Thread Florian Vaussard
not derive from the node name and will stay the same after this patch. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/bo

[PATCH 3/6] ARM: dts: socfpga: Remove unneeded unit names

2017-02-24 Thread Florian Vaussard
/usbphy@0 has a unit name, but no reg property Remove the superfluous unit names. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga.dtsi | 4 ++-- arch/arm/boot/dts/socfpga_arria10.dtsi | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 5/6] ARM: dts: socfpga: Remove unit name for LEDs in EBV SOCrates

2017-02-24 Thread Florian Vaussard
not derive from the node name and will stay the same after this patch. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts

[PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings

2017-02-24 Thread Florian Vaussard
tested on a Cyclone5 SoC DK, thus covering some of the changes dones by patches 1 -> 3 + 6. Regards, Florian Florian Vaussard (6): ARM: dts: socfpga: Add unit name to clock nodes ARM: dts: socfpga: Add unit name to memory nodes ARM: dts: socfpga: Remove unneeded unit names ARM:

[PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings

2017-02-24 Thread Florian Vaussard
tested on a Cyclone5 SoC DK, thus covering some of the changes dones by patches 1 -> 3 + 6. Regards, Florian Florian Vaussard (6): ARM: dts: socfpga: Add unit name to clock nodes ARM: dts: socfpga: Add unit name to memory nodes ARM: dts: socfpga: Remove unneeded unit names ARM:

[PATCH 4/6] ARM: dts: socfpga: Remove unneeded reg from stmpe_touchscreen

2017-02-24 Thread Florian Vaussard
/stmpe811@41/stmpe_touchscreen has a reg or ranges property, but no unit name Remove the superfluous reg property. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/bo

[PATCH 4/6] ARM: dts: socfpga: Remove unneeded reg from stmpe_touchscreen

2017-02-24 Thread Florian Vaussard
/stmpe811@41/stmpe_touchscreen has a reg or ranges property, but no unit name Remove the superfluous reg property. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/socfpga_cyclone5_mcvevk.dts b/arch

[PATCH] ARM: dts: socfpga: Use preprocessor defines for IRQs

2017-02-24 Thread Florian Vaussard
Using defines makes it easier to read interrupt descriptors. Apply to both regular and GIC interrupts. This patch was tested by comparing all the original and the new SocFPGA DTBs. They are binary identical. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- arch/arm/bo

[PATCH] ARM: dts: socfpga: Use preprocessor defines for IRQs

2017-02-24 Thread Florian Vaussard
Using defines makes it easier to read interrupt descriptors. Apply to both regular and GIC interrupts. This patch was tested by comparing all the original and the new SocFPGA DTBs. They are binary identical. Signed-off-by: Florian Vaussard --- arch/arm/boot/dts/socfpga.dtsi

Re: [PATCH v4 0/13] arm64: allwinner: a64: Enable MMC support

2017-01-27 Thread Florian Vaussard
Hi Maxime, On 01/26/2017 10:05 AM, Maxime Ripard wrote: > Hi, > > Here is a new attempt at getting the MMC controllers running, following the > work done by Andre. > > This has been tested on a board with one SDIO device (a Marvell WiFi chip) > and a Kingston eMMC with 1.8V IOs. > > For SDIO,

Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency

2017-01-27 Thread Florian Vaussard
Hi Maxime, On 01/26/2017 10:06 AM, Maxime Ripard wrote: > The eMMC controller seem to have a maximum frequency of 200MHz, while the > regular MMC controllers are capped at 150MHz. > > Since older SoCs cannot go that high, we cannot change the default maximum > frequency, but fortunately for us

Re: [PATCH v4 0/13] arm64: allwinner: a64: Enable MMC support

2017-01-27 Thread Florian Vaussard
Hi Maxime, On 01/26/2017 10:05 AM, Maxime Ripard wrote: > Hi, > > Here is a new attempt at getting the MMC controllers running, following the > work done by Andre. > > This has been tested on a board with one SDIO device (a Marvell WiFi chip) > and a Kingston eMMC with 1.8V IOs. > > For SDIO,

Re: [PATCH v4 10/13] arm64: allwinner: a64: Increase the MMC max frequency

2017-01-27 Thread Florian Vaussard
Hi Maxime, On 01/26/2017 10:06 AM, Maxime Ripard wrote: > The eMMC controller seem to have a maximum frequency of 200MHz, while the > regular MMC controllers are capped at 150MHz. > > Since older SoCs cannot go that high, we cannot change the default maximum > frequency, but fortunately for us

Re: [PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
Hello Dan, Le 29. 11. 16 à 18:10, Dan Murphy a écrit : > Florian > > On 11/29/2016 10:59 AM, Florian Vaussard wrote: >> Hello, >> >> This series fixes similar misues of the regmap_update_bits() API found >> inside the drv2665.c and drv2667.c drivers. More detai

Re: [PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
Hello Dan, Le 29. 11. 16 à 18:10, Dan Murphy a écrit : > Florian > > On 11/29/2016 10:59 AM, Florian Vaussard wrote: >> Hello, >> >> This series fixes similar misues of the regmap_update_bits() API found >> inside the drv2665.c and drv2667.c drivers. More detai

[PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
d, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- sound/soc/codecs/cs42l56.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56

[PATCH] ASoC: cs42l56: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
d, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard --- sound/soc/codecs/cs42l56.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 3e2c046..cb6ca85 100644 --- a

[PATCH] pwm: pca9685: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/pwm/pwm-pca9685.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 117fccf..6b9ff6c 100644

[PATCH] pwm: pca9685: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard --- drivers/pwm/pwm-pca9685.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 117fccf..6b9ff6c 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b

[PATCH 1/2] Input: drv2665: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
his change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/input/misc/drv2665.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/drv2665.c b/dr

[PATCH 2/2] Input: drv2667: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
ime. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/input/misc/drv2667.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/drv2667.

[PATCH 1/2] Input: drv2665: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
his change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard --- drivers/input/misc/drv2665.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c index ef9bc1

[PATCH 2/2] Input: drv2667: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
ime. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard --- drivers/input/misc/drv2667.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/drv2667.c b/drivers/input/misc/drv2667.c index

[PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
() are clearly wrong in the current code and the fix seems obvious. Any tests are warmly welcome. Best regards, Florian Florian Vaussard (2): Input: drv2665: Fix misuse of regmap_update_bits Input: drv2667: Fix misuse of regmap_update_bits drivers/input/misc/drv2665.c | 5 +++-- drivers/input/misc

[PATCH 0/2] Input: drv266x: Fix misuse of regmap_update_bits

2016-11-29 Thread Florian Vaussard
() are clearly wrong in the current code and the fix seems obvious. Any tests are warmly welcome. Best regards, Florian Florian Vaussard (2): Input: drv2665: Fix misuse of regmap_update_bits Input: drv2667: Fix misuse of regmap_update_bits drivers/input/misc/drv2665.c | 5 +++-- drivers/input/misc

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Replying to my self after thinking twice... Le 29. 09. 16 à 18:18, Florian Vaussard a écrit : > Hi Jacek, > > Thank you for your comments! > > Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : >> Hi Florian, >> >> Thanks for the updated patch set. I have few co

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Replying to my self after thinking twice... Le 29. 09. 16 à 18:18, Florian Vaussard a écrit : > Hi Jacek, > > Thank you for your comments! > > Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : >> Hi Florian, >> >> Thanks for the updated patch set. I have few co

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Hi Jacek, Thank you for your comments! Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : > Hi Florian, > > Thanks for the updated patch set. I have few comments below. > > On 09/16/2016 01:34 PM, Florian Vaussard wrote: >> The NCP5623 is a 3-channel LED driver from On Sem

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-29 Thread Florian Vaussard
Hi Jacek, Thank you for your comments! Le 18. 09. 16 à 20:20, Jacek Anaszewski a écrit : > Hi Florian, > > Thanks for the updated patch set. I have few comments below. > > On 09/16/2016 01:34 PM, Florian Vaussard wrote: >> The NCP5623 is a 3-channel LED driver from On Sem

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Florian Vaussard
Hello Jacek, Le 24. 09. 16 à 21:06, Jacek Anaszewski a écrit : > On 09/24/2016 01:58 PM, Pavel Machek wrote: >> Hi! >> >>> +Example >>> +=== >>> + >>> +led1: ncp5623@38 { >>> +#address-cells = <1>; >>> +#size-cells = <0>; >>> +compatible = "onnn,ncp5623"; >>> +reg = <0x38>;

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Florian Vaussard
Hello Jacek, Le 24. 09. 16 à 21:06, Jacek Anaszewski a écrit : > On 09/24/2016 01:58 PM, Pavel Machek wrote: >> Hi! >> >>> +Example >>> +=== >>> + >>> +led1: ncp5623@38 { >>> +#address-cells = <1>; >>> +#size-cells = <0>; >>> +compatible = "onnn,ncp5623"; >>> +reg = <0x38>;

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Florian Vaussard
Hi Pavel, Le 24. 09. 16 à 13:58, Pavel Machek a écrit : > Hi! > >> +Example >> +=== >> + >> +led1: ncp5623@38 { >> +#address-cells = <1>; >> +#size-cells = <0>; >> +compatible = "onnn,ncp5623"; >> +reg = <0x38>; >> +onnn,led-iref-microamp = <10>; >> + >> +led1r@0 { >>

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-28 Thread Florian Vaussard
Hi Pavel, Le 24. 09. 16 à 13:58, Pavel Machek a écrit : > Hi! > >> +Example >> +=== >> + >> +led1: ncp5623@38 { >> +#address-cells = <1>; >> +#size-cells = <0>; >> +compatible = "onnn,ncp5623"; >> +reg = <0x38>; >> +onnn,led-iref-microamp = <10>; >> + >> +led1r@0 { >>

[PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-16 Thread Florian Vaussard
the current on the Iref pin, hence the onnn,led-iref-microamp property. It is usually set using an external bias resistor, following Iref = Vref/Rbias with Vref=0.6V. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- .../devicetree/bindings/leds/leds-ncp5623.txt

[PATCH v3 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-16 Thread Florian Vaussard
v1 -> v2: - Adapted the DT binding (led-max-microamp for each LED node) - Removed underscores from node names in the example - Use brightness_set_blocking to avoid workqueue - Introduced LED_to_CMD macro to avoid switch statement - Various other fixes Florian Vaussard (2): leds: ncp5623: Add

[PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-16 Thread Florian Vaussard
the current on the Iref pin, hence the onnn,led-iref-microamp property. It is usually set using an external bias resistor, following Iref = Vref/Rbias with Vref=0.6V. Signed-off-by: Florian Vaussard --- .../devicetree/bindings/leds/leds-ncp5623.txt | 60 ++ 1 file changed

[PATCH v3 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-16 Thread Florian Vaussard
v1 -> v2: - Adapted the DT binding (led-max-microamp for each LED node) - Removed underscores from node names in the example - Use brightness_set_blocking to avoid workqueue - Introduced LED_to_CMD macro to avoid switch statement - Various other fixes Florian Vaussard (2): leds: ncp5623: Add

[PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-16 Thread Florian Vaussard
) and a dedicated register (ILED), following the relationship: I = 2400*Iref/(31-ILED) with Iref = Vref/Rbias, and Vref = 0.6V. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/leds/Kconfig| 11 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-ncp

[PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-16 Thread Florian Vaussard
) and a dedicated register (ILED), following the relationship: I = 2400*Iref/(31-ILED) with Iref = Vref/Rbias, and Vref = 0.6V. Signed-off-by: Florian Vaussard --- drivers/leds/Kconfig| 11 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-ncp5623.c | 234

Re: [PATCH v3 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-07-04 Thread Florian Vaussard
On 07/03/2016 12:56 PM, Jonathan Cameron wrote: > On 30/06/16 09:09, Florian Vaussard wrote: >> >> >> Le 30. 06. 16 à 09:46, Peter Rosin a écrit : >>> >>> >>> On June 30, 2016 9:34:50 AM GMT+02:00, Florian Vaussard >>> <florian.v

Re: [PATCH v3 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-07-04 Thread Florian Vaussard
On 07/03/2016 12:56 PM, Jonathan Cameron wrote: > On 30/06/16 09:09, Florian Vaussard wrote: >> >> >> Le 30. 06. 16 à 09:46, Peter Rosin a écrit : >>> >>> >>> On June 30, 2016 9:34:50 AM GMT+02:00, Florian Vaussard >>> wrote: >>&

Re: [PATCH v3 1/2] iio: adc: max1363: Add device tree binding documentation

2016-07-04 Thread Florian Vaussard
Hi Jonathan, On 07/03/2016 12:41 PM, Jonathan Cameron wrote: > On 30/06/16 08:43, Florian Vaussard wrote: >> Add the device tree documentation for all the supported parts. Mandatory >> binding is the compatible string and the slave I2C address. >> >> Optional proper

Re: [PATCH v3 1/2] iio: adc: max1363: Add device tree binding documentation

2016-07-04 Thread Florian Vaussard
Hi Jonathan, On 07/03/2016 12:41 PM, Jonathan Cameron wrote: > On 30/06/16 08:43, Florian Vaussard wrote: >> Add the device tree documentation for all the supported parts. Mandatory >> binding is the compatible string and the slave I2C address. >> >> Optional proper

Re: [PATCH v3 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-06-30 Thread Florian Vaussard
Le 30. 06. 16 à 09:46, Peter Rosin a écrit : > > > On June 30, 2016 9:34:50 AM GMT+02:00, Florian Vaussard > <florian.vauss...@gmail.com> wrote: >> This patch adds the necessary device tree binding to allow DT probing >> of >> currently supported parts. &

Re: [PATCH v3 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-06-30 Thread Florian Vaussard
Le 30. 06. 16 à 09:46, Peter Rosin a écrit : > > > On June 30, 2016 9:34:50 AM GMT+02:00, Florian Vaussard > wrote: >> This patch adds the necessary device tree binding to allow DT probing >> of >> currently supported parts. >> >> Signed-off-by: Fl

[PATCH v3 1/2] iio: adc: max1363: Add device tree binding documentation

2016-06-30 Thread Florian Vaussard
ed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- .../devicetree/bindings/iio/adc/max1363.txt| 63 ++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/max1363.txt diff --git a/Documentation/devicetree/bind

[PATCH v3 0/2] iio: adc: max1363: Add device tree support

2016-06-30 Thread Florian Vaussard
by Jonathan - Added DT maintainer's Ack - Fixed handling of data pointer in struct of_device_id Florian Vaussard (2): iio: adc: max1363: Add device tree binding documentation iio: adc: max1363: Add device tree binding .../devicetree/bindings/iio/adc/max1363.txt| 63

[PATCH v3 2/2] iio: adc: max1363: Add device tree binding

2016-06-30 Thread Florian Vaussard
This patch adds the necessary device tree binding to allow DT probing of currently supported parts. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/iio/adc/max1363.c | 61 ++- 1 file changed, 60 insertions(+), 1 de

[PATCH v3 1/2] iio: adc: max1363: Add device tree binding documentation

2016-06-30 Thread Florian Vaussard
Add the device tree documentation for all the supported parts. Mandatory binding is the compatible string and the slave I2C address. Optional properties can be used to specify the Vcc / Vref regulators, as well as the IRQ line if available. Acked-by: Rob Herring Signed-off-by: Florian Vaussard

[PATCH v3 0/2] iio: adc: max1363: Add device tree support

2016-06-30 Thread Florian Vaussard
by Jonathan - Added DT maintainer's Ack - Fixed handling of data pointer in struct of_device_id Florian Vaussard (2): iio: adc: max1363: Add device tree binding documentation iio: adc: max1363: Add device tree binding .../devicetree/bindings/iio/adc/max1363.txt| 63

[PATCH v3 2/2] iio: adc: max1363: Add device tree binding

2016-06-30 Thread Florian Vaussard
This patch adds the necessary device tree binding to allow DT probing of currently supported parts. Signed-off-by: Florian Vaussard --- drivers/iio/adc/max1363.c | 61 ++- 1 file changed, 60 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc

[PATCH v3 2/4] iio: potentiometer: mcp4531: Add device tree binding documentation

2016-06-30 Thread Florian Vaussard
Add the device tree documentation for all the supported parts. Apart the compatible string and standard I2C binding, no other binding is currently needed. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- .../devicetree/bindings/i2c/trivial-devices.txt

[PATCH v3 2/4] iio: potentiometer: mcp4531: Add device tree binding documentation

2016-06-30 Thread Florian Vaussard
Add the device tree documentation for all the supported parts. Apart the compatible string and standard I2C binding, no other binding is currently needed. Signed-off-by: Florian Vaussard --- .../devicetree/bindings/i2c/trivial-devices.txt| 64 ++ 1 file changed, 64

[PATCH v3 0/4] iio: potentiometer: mcp4531: New parts, DT and typo

2016-06-30 Thread Florian Vaussard
to mcp4531_of_match - New patch to fix typo in Kconfig Florian Vaussard (4): iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x iio: potentiometer: mcp4531: Add device tree binding documentation iio: potentiometer: mcp4531: Add device tree binding iio

[PATCH v3 1/4] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x

2016-06-30 Thread Florian Vaussard
memory is used to set the wiper. Acked-by: Peter Rosin <p...@axentia.se> Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/iio/potentiometer/Kconfig | 6 ++-- drivers/iio/potentiometer/mcp4531.c | 72 + 2 files changed, 7

[PATCH v3 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-06-30 Thread Florian Vaussard
This patch adds the necessary device tree binding to allow DT probing of currently supported parts. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/iio/potentiometer/mcp4531.c | 87 - 1 file changed, 86 insertions(+), 1 de

[PATCH v3 4/4] iio: potentiometer: Fix typo in Kconfig

2016-06-30 Thread Florian Vaussard
Fix s/potentiomenter/potentiometer/. Suggested-by: Peter Meerwald-Stadler <pme...@pmeerw.net> Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/iio/potentiometer/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/p

[PATCH v3 0/4] iio: potentiometer: mcp4531: New parts, DT and typo

2016-06-30 Thread Florian Vaussard
to mcp4531_of_match - New patch to fix typo in Kconfig Florian Vaussard (4): iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x iio: potentiometer: mcp4531: Add device tree binding documentation iio: potentiometer: mcp4531: Add device tree binding iio

[PATCH v3 1/4] iio: potentiometer: mcp4531: Add support for MCP454x, MCP456x, MCP464x and MCP466x

2016-06-30 Thread Florian Vaussard
memory is used to set the wiper. Acked-by: Peter Rosin Signed-off-by: Florian Vaussard --- drivers/iio/potentiometer/Kconfig | 6 ++-- drivers/iio/potentiometer/mcp4531.c | 72 + 2 files changed, 76 insertions(+), 2 deletions(-) diff --git a/drivers/iio

[PATCH v3 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-06-30 Thread Florian Vaussard
This patch adds the necessary device tree binding to allow DT probing of currently supported parts. Signed-off-by: Florian Vaussard --- drivers/iio/potentiometer/mcp4531.c | 87 - 1 file changed, 86 insertions(+), 1 deletion(-) diff --git a/drivers/iio

[PATCH v3 4/4] iio: potentiometer: Fix typo in Kconfig

2016-06-30 Thread Florian Vaussard
Fix s/potentiomenter/potentiometer/. Suggested-by: Peter Meerwald-Stadler Signed-off-by: Florian Vaussard --- drivers/iio/potentiometer/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/potentiometer/Kconfig b/drivers/iio/potentiometer/Kconfig index

Re: [PATCH v2 1/2] leds: ncp5623: Add device tree binding documentation

2016-06-27 Thread Florian Vaussard
Le 27. 06. 16 à 10:33, Jacek Anaszewski a écrit : > On 06/27/2016 10:30 AM, Florian Vaussard wrote: >> Hi Jacek, >> >> Le 27. 06. 16 à 10:11, Jacek Anaszewski a écrit : >>> Hi Florian, >>> >>> On 06/27/2016 09:03 AM, Florian Vaussard w

Re: [PATCH v2 1/2] leds: ncp5623: Add device tree binding documentation

2016-06-27 Thread Florian Vaussard
Le 27. 06. 16 à 10:33, Jacek Anaszewski a écrit : > On 06/27/2016 10:30 AM, Florian Vaussard wrote: >> Hi Jacek, >> >> Le 27. 06. 16 à 10:11, Jacek Anaszewski a écrit : >>> Hi Florian, >>> >>> On 06/27/2016 09:03 AM, Florian Vaussard w

Re: [PATCH v2 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-27 Thread Florian Vaussard
Hi Jacek, Le 27. 06. 16 à 10:14, Jacek Anaszewski a écrit : > Hi Florian, > > Thanks for the update. I have few comments below. > > On 06/27/2016 09:03 AM, Florian Vaussard wrote: >> The NCP5623 is a 3-channel LED driver from On Semiconductor controlled >> through I

Re: [PATCH v2 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-27 Thread Florian Vaussard
Hi Jacek, Le 27. 06. 16 à 10:14, Jacek Anaszewski a écrit : > Hi Florian, > > Thanks for the update. I have few comments below. > > On 06/27/2016 09:03 AM, Florian Vaussard wrote: >> The NCP5623 is a 3-channel LED driver from On Semiconductor controlled >> through I

Re: [PATCH v2 1/2] leds: ncp5623: Add device tree binding documentation

2016-06-27 Thread Florian Vaussard
Hi Jacek, Le 27. 06. 16 à 10:11, Jacek Anaszewski a écrit : > Hi Florian, > > On 06/27/2016 09:03 AM, Florian Vaussard wrote: >> Add device tree binding documentation for On Semiconductor NCP5623 I2C >> LED driver. The driver can independently control the PWM of the 3 >&

Re: [PATCH v2 1/2] leds: ncp5623: Add device tree binding documentation

2016-06-27 Thread Florian Vaussard
Hi Jacek, Le 27. 06. 16 à 10:11, Jacek Anaszewski a écrit : > Hi Florian, > > On 06/27/2016 09:03 AM, Florian Vaussard wrote: >> Add device tree binding documentation for On Semiconductor NCP5623 I2C >> LED driver. The driver can independently control the PWM of the 3 >&

[PATCH v2 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-27 Thread Florian Vaussard
) and a dedicated register (ILED), following the relationship: I = 2400*Iref/(31-ILED) with Iref = Vref/Rbias, and Vref = 0.6V. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- drivers/leds/Kconfig| 11 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-ncp

[PATCH v2 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-27 Thread Florian Vaussard
) and a dedicated register (ILED), following the relationship: I = 2400*Iref/(31-ILED) with Iref = Vref/Rbias, and Vref = 0.6V. Signed-off-by: Florian Vaussard --- drivers/leds/Kconfig| 11 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-ncp5623.c | 269

[PATCH v2 1/2] leds: ncp5623: Add device tree binding documentation

2016-06-27 Thread Florian Vaussard
the current on the Iref pin, hence the onnn,led-iref-microamp property. It is usually set using an external bias resistor, following Iref = Vref/Rbias with Vref=0.6V. Signed-off-by: Florian Vaussard <florian.vauss...@heig-vd.ch> --- .../devicetree/bindings/leds/leds-ncp5623.txt

[PATCH v2 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-27 Thread Florian Vaussard
- Use brightness_set_blocking to avoid workqueue - Introduced LED_to_CMD macro to avoid switch statement - Various other fixes Florian Vaussard (2): leds: ncp5623: Add device tree binding documentation leds: Add driver for NCP5623 3-channel I2C LED driver .../devicetree/bindings/leds/leds-ncp5623

[PATCH v2 1/2] leds: ncp5623: Add device tree binding documentation

2016-06-27 Thread Florian Vaussard
the current on the Iref pin, hence the onnn,led-iref-microamp property. It is usually set using an external bias resistor, following Iref = Vref/Rbias with Vref=0.6V. Signed-off-by: Florian Vaussard --- .../devicetree/bindings/leds/leds-ncp5623.txt | 60 ++ 1 file changed

[PATCH v2 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-27 Thread Florian Vaussard
- Use brightness_set_blocking to avoid workqueue - Introduced LED_to_CMD macro to avoid switch statement - Various other fixes Florian Vaussard (2): leds: ncp5623: Add device tree binding documentation leds: Add driver for NCP5623 3-channel I2C LED driver .../devicetree/bindings/leds/leds-ncp5623

Re: [PATCH v2 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-06-26 Thread Florian Vaussard
Hi Peter, Le 27. 06. 16 à 00:12, Peter Rosin a écrit : > Hi Florian, > > On 2016-06-26 22:22, Florian Vaussard wrote: >> This patch adds the necessary device tree binding to allow DT probing of >> currently supported parts. >> >> Signed-off-by: Florian Vaus

Re: [PATCH v2 3/4] iio: potentiometer: mcp4531: Add device tree binding

2016-06-26 Thread Florian Vaussard
Hi Peter, Le 27. 06. 16 à 00:12, Peter Rosin a écrit : > Hi Florian, > > On 2016-06-26 22:22, Florian Vaussard wrote: >> This patch adds the necessary device tree binding to allow DT probing of >> currently supported parts. >> >> Signed-off-by: Florian

Re: [PATCH v2 2/4] iio: potentiometer: mcp4531: Add device tree binding documentation

2016-06-26 Thread Florian Vaussard
Hello Peter, Le 26. 06. 16 à 23:38, Peter Rosin a écrit : > On 2016-06-26 22:22, Florian Vaussard wrote: >> Add the device tree documentation for all the supported parts. Apart the >> compatible string and standard I2C binding, no other binding is currently >> needed. >>

Re: [PATCH 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-26 Thread Florian Vaussard
Hi Pavel, Le 26. 06. 16 à 23:49, Pavel Machek a écrit : > Hi! > >>> +struct ncp5623_led { >>> + bool active; >>> + unsigned int led_no; >>> + struct led_classdev ldev; >>> + struct work_struct work; >>> + struct ncp5623_priv *priv; >>> +}; >>> + >>> +struct ncp5623_priv { >>> +

Re: [PATCH v2 2/4] iio: potentiometer: mcp4531: Add device tree binding documentation

2016-06-26 Thread Florian Vaussard
Hello Peter, Le 26. 06. 16 à 23:38, Peter Rosin a écrit : > On 2016-06-26 22:22, Florian Vaussard wrote: >> Add the device tree documentation for all the supported parts. Apart the >> compatible string and standard I2C binding, no other binding is currently >> needed. >>

Re: [PATCH 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-06-26 Thread Florian Vaussard
Hi Pavel, Le 26. 06. 16 à 23:49, Pavel Machek a écrit : > Hi! > >>> +struct ncp5623_led { >>> + bool active; >>> + unsigned int led_no; >>> + struct led_classdev ldev; >>> + struct work_struct work; >>> + struct ncp5623_priv *priv; >>> +}; >>> + >>> +struct ncp5623_priv { >>> +

  1   2   3   4   >