Re: [PATCH] crypto: crc32-generic - Use SPDX-License-Identifier

2021-04-16 Thread Herbert Xu
T > --- > crypto/crc32_generic.c | 24 +--- > 1 file changed, 1 insertion(+), 23 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

2021-04-16 Thread Herbert Xu
hisilicon/hpre/hpre_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm/curve25519 - Move '.fpu' after '.arch'

2021-04-16 Thread Herbert Xu
n") > Link: https://github.com/ClangBuiltLinux/continuous-integration2/issues/118 > Reported-by: Arnd Bergmann > Suggested-by: Arnd Bergmann > Suggested-by: Jessica Clarke > Signed-off-by: Nathan Chancellor > --- > arch/arm/crypto/curve25519-core.S | 2 +- > 1

Re: [PATCH 0/3] crypto: hisilicon/hpre - add debug log

2021-04-16 Thread Herbert Xu
silicon/hpre - add debug log > > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11 +-- > drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- > 2 files changed, 11 insertions(+), 4 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.

Re: [PATCH v3 0/5] bug fix and clear coding style

2021-04-16 Thread Herbert Xu
le changed, 31 insertions(+), 6 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: correct the use of print format

2021-04-16 Thread Herbert Xu
3 files changed, 6 insertions(+), 6 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next 1/7] crypto: sun4i-ss - Fix PM reference leak when pm_runtime_get_sync() fails

2021-04-16 Thread Herbert Xu
.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next 0/5] Remove redundant dev_err call

2021-04-16 Thread Herbert Xu
re.c | 1 - > 7 files changed, 3 insertions(+), 15 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/trng - add version to adapt new algorithm

2021-04-16 Thread Herbert Xu
off-by: Weili Qian > --- > drivers/crypto/hisilicon/trng/trng.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/qm - add stop queue by hardware

2021-04-16 Thread Herbert Xu
+- > 1 file changed, 28 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: ixp4xx -: use DEFINE_SPINLOCK() for spinlock

2021-04-16 Thread Herbert Xu
t; --- > drivers/crypto/ixp4xx_crypto.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: geode -: use DEFINE_SPINLOCK() for spinlock

2021-04-16 Thread Herbert Xu
> drivers/crypto/geode-aes.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] ecc: delete a useless function declaration

2021-04-16 Thread Herbert Xu
Modify the 'Fixes tag' from '14bb76768275' to '4e6602916bc6 '. > > --- > crypto/ecc.h | 8 > 1 file changed, 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/hpre - fix unmapping invalid dma address

2021-04-16 Thread Herbert Xu
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 18 ++ > 1 file changed, 18 insertions(+) This triggers new sparse warnings. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/8] ccp: KVM: SVM: Use stack for SEV command buffers

2021-04-15 Thread Herbert Xu
I don't mind at all. Paolo you can take this through your tree. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat: Fix a double free in adf_create_ring

2021-04-09 Thread Herbert Xu
on/adf_transport.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: hisilicon/qm - delete redundant code

2021-04-09 Thread Herbert Xu
gt; v2: > Re-edit the description. > > drivers/crypto/hisilicon/qm.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto:hisilicon/sec - fixup checking the 3DES weak key

2021-04-09 Thread Herbert Xu
ons(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][V2] crypto: sa2ul: Fix memory leak of rxd

2021-04-09 Thread Herbert Xu
o: sa2ul - Fix DMA mapping API usage") > Signed-off-by: Colin Ian King > --- > > V2: Fix typo in $SUBJECT > > --- > drivers/crypto/sa2ul.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://

Re: [PATCH][next] crypto: sun8i-ss: Fix memory leak of pad

2021-04-09 Thread Herbert Xu
: sun8i-ss - support hash algorithms") > Signed-off-by: Colin Ian King > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~

Re: [PATCH] crypto: rockchip/rk3288_crypto_ahash - delete unneeded variable initialization

2021-04-09 Thread Herbert Xu
On Thu, Apr 01, 2021 at 11:01:39AM +0800, Kai Ye wrote: > Delete unneeded variable initialization > > Signed-off-by: Kai Ye > --- > drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Her

Re: [PATCH -next] crypto: ccp - Use DEFINE_SPINLOCK() for spinlock

2021-04-09 Thread Herbert Xu
o-main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: hisilicon/hpre - fix a typo in hpre_crypto.c

2021-04-09 Thread Herbert Xu
letion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccp -A value assigned to a variable is never used.

2021-04-09 Thread Herbert Xu
d-off-by: Jiapeng Chong > --- > drivers/crypto/ccp/ccp-ops.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: hisilicon/sec - Fix a module parameter error

2021-04-09 Thread Herbert Xu
need to register the kernel mode algorithms. > > Signed-off-by: Longfang Liu > --- > > Changes in V2: > - Add algorithms unregistration processing > > drivers/crypto/hisilicon/sec2/sec_main.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) Pa

Re: crypto: possible NULL reference

2021-04-09 Thread Herbert Xu
-- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: allwinner: add missing CRYPTO_ prefix

2021-04-09 Thread Herbert Xu
ms") > Signed-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/Kconfig | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 5/5] crypto: hisilicon/sgl - fix the sg buf unmap

2021-04-09 Thread Herbert Xu
[i].page_ctrl = NULL; > + hw_sge[i].buf = 0; > + hw_sge[i].len = 0; > + } > +} This causes a new sparse warning: CHECK ../drivers/crypto/hisilicon/sgl.c ../drivers/crypto/hisilicon/sgl.c:200:31: warning: restricted __le16 degrades to integer Please

Re: [PATCH] crypto: chelsio: fix incorrect kernel-doc comment syntax in file

2021-04-09 Thread Herbert Xu
r_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This patch doesn't apply against cryptodev. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log

2021-04-09 Thread Herbert Xu
fact changing behaviour. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: cbc - fix coding style

2021-04-09 Thread Herbert Xu
r to improve the code. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: api - fix coding style

2021-04-09 Thread Herbert Xu
--- > crypto/api.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) Please don't mix unrelated changes in a single patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: deflate - Remove useless call "zlib_inflateEnd"

2021-04-09 Thread Herbert Xu
ong > --- > crypto/deflate.c | 1 - > 1 file changed, 1 deletion(-) The function might not do anything today but the documentation clearly indicates that it could free any dynamically allocated data so it should stay. Cheers, -- Email: Herbert Xu Home Page: http://

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread Herbert Xu
h for now. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/sec - Fixes AES algorithm mode parameter problem

2021-04-02 Thread Herbert Xu
y: Longfang Liu > --- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 37 > ++ > 1 file changed, 32 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/hpre - Add processing of src_data in 'CURVE25519'

2021-04-02 Thread Herbert Xu
; So we get its modulus to p, and then deal it with HPRE. > > Signed-off-by: Meng Yu > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http:

Re: [PATCH] crypto: hisilicon - delete redundant '\n'

2021-04-02 Thread Herbert Xu
d, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon/hpre - fix a typo and delete redundant blank line

2021-04-02 Thread Herbert Xu
On Sat, Mar 27, 2021 at 04:32:08PM +0800, Hui Tang wrote: > s/shoul/should/ > > Signed-off-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert X

Re: [PATCH] crypto: hisilicon/hpre - fix PASID setting on kunpeng 920

2021-04-02 Thread Herbert Xu
ions(+), 25 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: poly1305: fix poly1305_core_setkey() declaration

2021-04-02 Thread Herbert Xu
gt; lib/crypto/poly1305-donna64.c | 3 ++- > lib/crypto/poly1305.c | 3 ++- > 9 files changed, 18 insertions(+), 12 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930

2021-04-02 Thread Herbert Xu
06 > +- > 2 files changed, 438 insertions(+), 314 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH RESEND] random: remove dead code left over from blocking pool

2021-04-02 Thread Herbert Xu
t; Reviewed-by: Andy Lutomirski > Acked-by: Ard Biesheuvel > Signed-off-by: Eric Biggers > --- > drivers/char/random.c | 17 ++- > include/trace/events/random.h | 83 --- > 2 files changed, 3 insertions(+), 97 deletions(-) Patc

Re: [PATCH RESEND] random: initialize ChaCha20 constants with correct endianness

2021-04-02 Thread Herbert Xu
haCha20 anymore. Fix it to always use the standard constants. > > Cc: linux-cry...@vger.kernel.org > Cc: Andy Lutomirski > Cc: Jann Horn > Cc: Theodore Ts'o > Acked-by: Herbert Xu > Acked-by: Ard Biesheuvel > Signed-off-by: Eric Biggers > --- > drivers/char

Re: [PATCH] crypto: hisilicon/hpre - delete redundant log

2021-04-02 Thread Herbert Xu
quot;acpi_evaluate_dsm err.\n"); > - > + hpre_cfg_by_dsm(qm); > disable_flr_of_bme(qm); > } If the return value is non-zero you've just changed what this code does from returning non-zero to returning zero. Are you sure about this? Thanks, -- Email: Herbert

Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread Herbert Xu
bug? Wouldn't the soft fallback setkey catch this anyhow? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] crypto: replace memset by memzero_explicit

2021-04-02 Thread Herbert Xu
On Fri, Mar 26, 2021 at 09:20:45AM +0800, Kai Ye wrote: > use memzero_explicit instead of memset to clear sensitive data, > such as buffer or key. Does this fix a real issue? If not then it's just unnecessary churn. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~h

Re: [PATCH] crypto: hisilicon/qm - delete redundant code

2021-04-02 Thread Herbert Xu
l data. But your patch description is poorly written and needs to be rephrased to describe more clearly why it is safe to remove the memset. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-03-31 Thread Herbert Xu
t's why a boot option > > AND a warning would be the best compromise. > > It's not UAPI if there is no way for userspace to tell if it changed. Exactly. UAPI is only an issue if something *breaks*. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: ht

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-03-31 Thread Herbert Xu
s taken from RFC8017. Where is the cover letter for this series? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] Documentation: crypto: add info about "fips=" boot option

2021-03-29 Thread Herbert Xu
On Mon, Mar 29, 2021 at 10:00:45PM -0700, Randy Dunlap wrote: > On 3/29/21 9:37 PM, Herbert Xu wrote: > > On Mon, Mar 29, 2021 at 09:00:01PM -0700, Randy Dunlap wrote: > >> > >> + If fips_enabled = 1, some crypto tests are skipped. > > > &

Re: [PATCH] Documentation: crypto: add info about "fips=" boot option

2021-03-29 Thread Herbert Xu
On Mon, Mar 29, 2021 at 09:00:01PM -0700, Randy Dunlap wrote: > > + If fips_enabled = 1, some crypto tests are skipped. I don't think any tests are skipped. It does however disable many algorithms by essentially failing them at the testing stage. Cheers, -- Email: H

Re: [PATCH] crypto: vmx: fix incorrect kernel-doc comment syntax in files

2021-03-26 Thread Herbert Xu
crypto/vmx/aes_ctr.c | 2 +- > drivers/crypto/vmx/aes_xts.c | 2 +- > drivers/crypto/vmx/ghash.c | 2 +- > drivers/crypto/vmx/vmx.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx: fix incorrect kernel-doc comment syntax in files

2021-03-26 Thread Herbert Xu
drivers/crypto/nx/nx-sha512.c | 2 +- > drivers/crypto/nx/nx.c | 2 +- > drivers/crypto/nx/nx_debugfs.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ux500: fix incorrect kernel-doc comment syntax

2021-03-26 Thread Herbert Xu
/cryp_irq.c | 2 +- > drivers/crypto/ux500/cryp/cryp_irq.h | 4 ++-- > drivers/crypto/ux500/cryp/cryp_irqp.h | 4 ++-- > drivers/crypto/ux500/cryp/cryp_p.h| 14 +++--- > 7 files changed, 15 insertions(+), 15 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH] crypto: amcc: fix incorrect kernel-doc comment syntax in files

2021-03-26 Thread Herbert Xu
rypto/amcc/crypto4xx_trng.h | 2 +- > 6 files changed, 31 insertions(+), 31 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] crypto: hisilicon/qm - support doorbell isolation and queue number configuration

2021-03-26 Thread Herbert Xu
> drivers/crypto/hisilicon/sec2/sec.h | 1 - > drivers/crypto/hisilicon/sec2/sec_main.c | 65 +- > drivers/crypto/hisilicon/zip/zip_main.c | 65 +- > include/uapi/misc/uacce/hisi_qm.h | 1 + > 8 files changed, 272 insertions(+), 274 deletion

Re: [PATCH] crypto: hisilicon/hpre - fix Kconfig

2021-03-26 Thread Herbert Xu
On Fri, Mar 19, 2021 at 06:45:39PM +0800, Hui Tang wrote: > hpre select 'CRYPTO_ECDH' and 'CRYPTO_CURVE25519'. > > Signed-off-by: Hui Tang > --- > drivers/crypto/hisilicon/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Her

Re: [PATCH] crypto: hisilicon/hpre - fix "hpre_ctx_init" resource leak

2021-03-26 Thread Herbert Xu
d, 12 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hisilicon - fix the check on dma address

2021-03-26 Thread Herbert Xu
gned-off-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 12 > drivers/crypto/hisilicon/qm.c | 2 +- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 6 -- > 3 files changed, 1 insertion(+), 19 deletions(-) Patch applied. Than

Re: [PATCH 0/2] crypto: hisilicon/hpre - remove 'CONFIG_CRYPTO_DH'

2021-03-26 Thread Herbert Xu
h > > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 30 > ++--- > 1 file changed, 10 insertions(+), 20 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: Correct an error in the comments

2021-03-26 Thread Herbert Xu
On Fri, Mar 19, 2021 at 05:13:34PM +0800, Meng Yu wrote: > Remove repeated word 'bit' in comments. > > Signed-off-by: Meng Yu > --- > crypto/ecc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://g

Re: [PATCH v3 00/10] Rid W=1 warnings in Crypto

2021-03-26 Thread Herbert Xu
ush Sawal > Cc: Benjamin Herrenschmidt > Cc: Berne Hebark > Cc: "Breno Leitão" > Cc: Daniele Alessandrelli > Cc: "David S. Miller" > Cc: Declan Murphy > Cc: Harsh Jain > Cc: Henrique Cerri > Cc: Herbert Xu > Cc: "Horia Geantă&

Re: [PATCH v5 0/2] crypto: qat - fix couple crashes duing error handling

2021-03-26 Thread Herbert Xu
4 files changed, 19 insertions(+), 10 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: inside-secure: Minor typo fix in the file safexcel.c

2021-03-26 Thread Herbert Xu
On Wed, Mar 17, 2021 at 02:44:45PM +0530, Bhaskar Chowdhury wrote: > > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/crypto/inside-secure/safexcel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email:

Re: [PATCH v12 00/10] Add support for x509 certs with NIST P384/256/192 keys

2021-03-26 Thread Herbert Xu
+ > include/crypto/ecdh.h | 1 + > include/keys/asymmetric-type.h| 6 + > include/linux/oid_registry.h | 10 +- > lib/oid_registry.c| 24 ++ > security/integrity/digsig_asymmetric.c| 30 +- > 20 files changed, 1240 insertions(+), 107 deletions(-) > create mode 100644 crypto/ecdsa.c > create mode 100644 crypto/ecdsasignature.asn1 Patches 1-9 applied to branch ecc. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 0/2] PSP TEE driver update and bug fixes

2021-03-26 Thread Herbert Xu
status polling interval from 5ms to > 1ms > crypto: ccp - fix command queuing to TEE ring buffer > > drivers/crypto/ccp/tee-dev.c | 57 > drivers/crypto/ccp/tee-dev.h | 20 +++-- > 2 files changed, 57 insertions(+), 20 delet

Re: [PATCH 4/4] crypto: hisilicon/zip - support new 'sqe' type in Kunpeng930

2021-03-26 Thread Herbert Xu
eclared. Should it be static? ../drivers/crypto/hisilicon/zip/zip_crypto.c:540:31: warning: symbol 'hisi_zip_ops_v2' was not declared. Should it be static? Please fix. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC 1/1] crypto: dcp - add power management support

2021-03-26 Thread Herbert Xu
#include > +#endif Please find a way to rework this patch so that it's not full of these ifdefs. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] include/linux: Fix typo issue

2021-03-26 Thread Herbert Xu
On Tue, Mar 16, 2021 at 11:42:13AM +0800, zuoqil...@163.com wrote: > From: zuoqilin > > Change 'bufer' to 'buffer'. > > Signed-off-by: zuoqilin > --- > include/linux/mpi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please resend to linux-crypto. Thank

Re: [GIT PULL] ext4 fixes for v5.12

2021-03-22 Thread Herbert Xu
Theodore Ts'o wrote: > > From: 曹子德(Theodore Y Ts'o) "Yue" doesn't seem to match your second character which is usually romanised as "Tze" in Cantonese, could it be 曹予德 Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH net-next 2/2] net: socket: change MSG_CMSG_COMPAT to BIT(21)

2021-03-21 Thread Herbert Xu
> fixups */ > -#else > -#define MSG_CMSG_COMPAT 0 /* We never have 32 bit fixups > */ > -#endif Shouldn't you add some comment here to stop people from trying to use BIT(31) in the future? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] char: hw_random: delete redundant printing of return value

2021-03-19 Thread Herbert Xu
> 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 0/3] crypto:hisilicon/sec - fixes some coding style

2021-03-19 Thread Herbert Xu
vers/crypto/hisilicon/sec2/sec.h| 5 +- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 77 + > drivers/crypto/hisilicon/sec2/sec_crypto.h | 2 - > drivers/crypto/hisilicon/sec2/sec_main.c | 131 > + > 4 files changed, 116 inser

Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch

2021-03-16 Thread Herbert Xu
think it's doing. The first assignment to a is not in effect when the shell is expanding $a so what you're actually running is a="!" [ = .size ] Which is why it bombs out. To get the desired result you need a semicolon: $ a="!"; [ $a = ".size" ] $ Cheers,

Re: [kbuild-all] Re: [PATCH] gcov: fail build on gcov_info size mismatch

2021-03-15 Thread Herbert Xu
either add something to ensure that "!" cannot occur, e.g., [ "X$a" = "X$b" -a ... ] or you break it down into a simpler expression that is guaranteed by POSIX: [ "$a" = "$b" ] && [ ... ] Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v6 0/3] hwrng: bcm2835: add reset support

2021-03-12 Thread Herbert Xu
dt-bindings: rng: bcm2835: document reset support > hwrng: bcm2835: add reset support > > .../devicetree/bindings/rng/brcm,bcm2835.yaml | 21 +++ > drivers/char/hw_random/bcm2835-rng.c | 10 + > 2 files changed, 31 insertions(+) All

Re: [PATCH v2 0/2] crypto: qat - fixes related to 'dma_map_single'

2021-03-12 Thread Herbert Xu
1.fix build warning reported by kernel test rebot > 2.add patch #1 > > drivers/crypto/qat/qat_common/qat_algs.c | 32 > > 1 file changed, 20 insertions(+), 12 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http:

Re: [PATCH v10 0/7] add ECDH and CURVE25519 algorithms support for Kunpeng 930

2021-03-12 Thread Herbert Xu
crypto.c | 4 +- > include/crypto/ecc_curve.h | 60 ++ > include/crypto/ecdh.h | 2 - > net/bluetooth/ecdh_helper.c | 2 - > net/bluetooth/selftest.c| 2 +- > net/bluetooth/smp.c | 6 +- > 24 files changed, 1086 insertions(+), 141 deletions(-) > create mode 100644 include/crypto/ecc_curve.h All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: allwinner: sun8i-ce: fix error return code in sun8i_ce_prng_generate()

2021-03-12 Thread Herbert Xu
off-by: Jia-Ju Bai > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccp - Don't initialize SEV support without the SEV feature

2021-03-12 Thread Herbert Xu
on X86_64, adding > the check won't cause any build problems. > > Cc: John Allen > Cc: Brijesh Singh > Signed-off-by: Tom Lendacky > --- > drivers/crypto/ccp/sev-dev.c | 6 ++ > 1 file changed, 6 insertions(+) Patch applied. Thanks. -- Email: Herbert Xu Home Pa

Re: [PATCH] crypto: sun8i-ss: Fix memory leak of object d when dma_iv fails to map

2021-03-12 Thread Herbert Xu
, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] include/linux: Fix typo issue

2021-03-12 Thread Herbert Xu
vger.kernel.org. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/7] Add support for AEAD algorithms in Qualcomm Crypto Engine driver

2021-03-12 Thread Herbert Xu
On Thu, Mar 04, 2021 at 01:41:15PM -0500, Thara Gopinath wrote: > > Yes it did. The last patch adds fallback for unsupported cases and > this will make it pass the fuzz tests. Please include this information in the next round. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apa

Re: [PATCH 4/7] crypto: qce: Add support for AEAD algorithms

2021-03-12 Thread Herbert Xu
ctx->iv = req->iv; > + rctx->ivsize = crypto_aead_ivsize(tfm); > + } > + if (IS_CCM_RFC4309(rctx->flags)) > + rctx->assoclen = req->assoclen - 8; > + else > + rctx->assoclen = req->assoclen; > + > +

Re: [PATCH v3 1/2] crypto: hisilicon/sec - fixes some log printing style

2021-03-12 Thread Herbert Xu
qp_ctx->res[req_id].pbuf, copy_size); > if (unlikely(pbuf_length != copy_size)) > - dev_err(dev, "copy pbuf data to dst error!\n"); > + dev_err(ctx->dev, "copy pbuf data to dst error!\n"); > } This triggers an unused war

Re: [PATCH] crypto: sun8i-ss: fix result memory leak on error path

2021-03-12 Thread Herbert Xu
crypto: sun8i-ss - fix result memory leak on error path Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: aegis128 - Move simd prototypes into aegis.h

2021-03-07 Thread Herbert Xu
>> 'crypto_aegis128_have_simd' [-Wmissing-prototypes] > 17 | bool crypto_aegis128_have_simd(void) > | ^ ---8<--- This patch fixes missing prototype warnings in crypto/aegis128-neon.c. Fixes: a4397635afea ("crypto: aegis128 - provide a SIMD...") Reported-by: kern

Re: [PATCH v9 6/9] crypto: Add NIST P384 curve parameters

2021-03-04 Thread Herbert Xu
ther patches to, such as > Nayna's? Yes I can do a topic branch. Please let me know which patches I should take when you resubmit. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto/nx: add missing call to of_node_put()

2021-03-03 Thread Herbert Xu
anged, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: testmgr - delete some redundant code

2021-03-03 Thread Herbert Xu
t; 1 file changed, 3 insertions(+), 8 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFT PATCH] crypto: s5p-sss - initialize APB clock after the AXI bus clock for SlimSSS

2021-03-03 Thread Herbert Xu
enable > first main/high speed bus clock - "aclk". Also this was the intention > of the actual code. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Not tested, please kindly test on Exynos5433 hardware. > --- > drivers/crypto/s5p-sss.c | 2 +- > 1 file ch

Re: [PATCH] crypto: sun8i-ss: fix result memory leak on error path

2021-03-03 Thread Herbert Xu
igned-off-by: Corentin Labbe > --- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v7 00/11] Regression fixes/clean ups in the Qualcomm crypto engine driver

2021-03-03 Thread Herbert Xu
nine patches are fixes for various regressions found during testing. The > last two patches are minor clean ups of unused variable and parameters. > > v6->v7: > - Fixed sparse warning in patch 4 as pointed out by Herbert Xu. > This means the checking if any two keys are

Re: [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe()

2021-03-03 Thread Herbert Xu
o/amlogic/amlogic-gxl-core.c | 3 --- > 1 file changed, 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: sha: remove unneeded semicolon

2021-03-03 Thread Herbert Xu
+- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/3] crypto: hisilicon/sec - fixes shash test error

2021-03-03 Thread Herbert Xu
On Sat, Feb 20, 2021 at 05:51:22PM +0800, liulongfang wrote: . > Since patch3 is an unnecessary patch, > can you just remove it and merge patch1 and patch2? Please repost. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~h

Re: [PATCH 0/7] Add support for AEAD algorithms in Qualcomm Crypto Engine driver

2021-03-03 Thread Herbert Xu
ttps://lkml.org/lkml/2021/2/11/1052. Did this patch series pass the fuzz tests? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v9 6/9] crypto: Add NIST P384 curve parameters

2021-03-03 Thread Herbert Xu
Stefan Berger > --- > crypto/ecc_curve_defs.h | 32 > include/crypto/ecdh.h | 1 + > 2 files changed, 33 insertions(+) Can you reorder the patches so that the crypto patches come first and then I can apply them? Thanks, -- Email: Herbert Xu Home Page: ht

Re: [PATCH 02/20] crypto: Manual replacement of the deprecated strlcpy() with return values

2021-03-03 Thread Herbert Xu
len < 2 || len >= sizeof(ecb_name)) > + len = strscpy(ecb_name, cipher_name + 4, sizeof(ecb_name)); > + if (len == -E2BIG || len < 2) len == -E2BIG is superfluous as len < 2 will catch it anyway. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: mediatek - remove obsolete documentation

2021-03-03 Thread Herbert Xu
s/crypto/mediatek-crypto.txt Shouldn't this go through Matthias Brugger ? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  1   2   3   4   5   6   7   8   9   10   >