Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

On Thu, 2017-02-23 at 09:40 +0530, Jassi Brar wrote: > On Wed, Feb 22, 2017 at 8:42 AM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: > > On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: > >> On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao <hs.l...@mediat

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

On Thu, 2017-02-23 at 09:40 +0530, Jassi Brar wrote: > On Wed, Feb 22, 2017 at 8:42 AM, Horng-Shyang Liao > wrote: > > On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: > >> On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao > >> wrote: > >> >

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: > On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: > > Hi Jassi, > > > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: > >> On Thu, Jan 26, 2017 at 2:07 PM,

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

On Thu, 2017-02-16 at 21:02 +0530, Jassi Brar wrote: > On Mon, Feb 6, 2017 at 11:07 AM, Horng-Shyang Liao > wrote: > > Hi Jassi, > > > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: > >> On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang L

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

On Mon, 2017-02-06 at 13:37 +0800, Horng-Shyang Liao wrote: > Hi Jassi, > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: > > On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao <hs.l...@mediatek.com> > > wrote: > > > Hi Jassi, > > > > &

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

On Mon, 2017-02-06 at 13:37 +0800, Horng-Shyang Liao wrote: > Hi Jassi, > > On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: > > On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao > > wrote: > > > Hi Jassi, > > > > > > On Thu, 2017-01-26 at 1

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

Hi Jassi, On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: > On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: > > Hi Jassi, > > > > On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: > >> On Wed, Jan 4, 2017 at 8:36 A

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

Hi Jassi, On Wed, 2017-02-01 at 10:52 +0530, Jassi Brar wrote: > On Thu, Jan 26, 2017 at 2:07 PM, Horng-Shyang Liao > wrote: > > Hi Jassi, > > > > On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: > >> On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: > &g

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

Hi Jassi, On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: > On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > > b/drivers/mailbox/mtk-cmdq-mailbox.c > > new file mode 100644 > > index 000..747bcd3 > > ---

Re: [PATCH v20 2/4] mailbox: mediatek: Add Mediatek CMDQ driver

Hi Jassi, On Thu, 2017-01-26 at 10:08 +0530, Jassi Brar wrote: > On Wed, Jan 4, 2017 at 8:36 AM, HS Liao wrote: > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > > b/drivers/mailbox/mtk-cmdq-mailbox.c > > new file mode 100644 > > index 000..747bcd3 > > --- /dev/null > > +++

Re: [PATCH v20 0/4] Mediatek MT8173 CMDQ support

On Fri, 2017-01-13 at 09:27 +0800, Horng-Shyang Liao wrote: > On Wed, 2017-01-04 at 11:06 +0800, HS Liao wrote: > > Hi, > > > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > > to help write registers with critical time limitation, s

Re: [PATCH v20 0/4] Mediatek MT8173 CMDQ support

On Fri, 2017-01-13 at 09:27 +0800, Horng-Shyang Liao wrote: > On Wed, 2017-01-04 at 11:06 +0800, HS Liao wrote: > > Hi, > > > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > > to help write registers with critical time limitation, s

Re: [PATCH v20 0/4] Mediatek MT8173 CMDQ support

On Wed, 2017-01-04 at 11:06 +0800, HS Liao wrote: > Hi, > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > to help write registers with critical time limitation, such as > updating display configuration during the vblank. It controls Global > Command Engine (GCE) hardware

Re: [PATCH v20 0/4] Mediatek MT8173 CMDQ support

On Wed, 2017-01-04 at 11:06 +0800, HS Liao wrote: > Hi, > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > to help write registers with critical time limitation, such as > updating display configuration during the vblank. It controls Global > Command Engine (GCE) hardware

Re: [PATCH v16 0/5] Mediatek MT8173 CMDQ support

On Fri, 2016-11-11 at 11:15 +0530, Jassi Brar wrote: > On Thu, Nov 10, 2016 at 4:45 PM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: > > On Tue, 2016-11-01 at 19:28 +0800, HS Liao wrote: > >> Hi, > >> > >> This is Mediatek MT8173 Command Queu

Re: [PATCH v16 0/5] Mediatek MT8173 CMDQ support

On Fri, 2016-11-11 at 11:15 +0530, Jassi Brar wrote: > On Thu, Nov 10, 2016 at 4:45 PM, Horng-Shyang Liao > wrote: > > On Tue, 2016-11-01 at 19:28 +0800, HS Liao wrote: > >> Hi, > >> > >> This is Mediatek MT8173 Command Queue(CMDQ) driver. The CM

Re: [PATCH v16 0/5] Mediatek MT8173 CMDQ support

On Tue, 2016-11-01 at 19:28 +0800, HS Liao wrote: > Hi, > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > to help write registers with critical time limitation, such as > updating display configuration during the vblank. It controls Global > Command Engine (GCE) hardware

Re: [PATCH v16 0/5] Mediatek MT8173 CMDQ support

On Tue, 2016-11-01 at 19:28 +0800, HS Liao wrote: > Hi, > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > to help write registers with critical time limitation, such as > updating display configuration during the vblank. It controls Global > Command Engine (GCE) hardware

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Thu, 2016-10-06 at 18:40 +0530, Jassi Brar wrote: > On 6 October 2016 at 18:31, Horng-Shyang Liao <hs.l...@mediatek.com> wrote: > > > Back to our original statement, we need to flush all tasks to queue > > in GCE HW; i.e. we need to use mbox_client_txdone after > &

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Thu, 2016-10-06 at 18:40 +0530, Jassi Brar wrote: > On 6 October 2016 at 18:31, Horng-Shyang Liao wrote: > > > Back to our original statement, we need to flush all tasks to queue > > in GCE HW; i.e. we need to use mbox_client_txdone after > > mbox_send_message, or s

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Wed, 2016-10-05 at 20:13 +0530, Jassi Brar wrote: > On 5 October 2016 at 18:01, Horng-Shyang Liao <hs.l...@mediatek.com> wrote: > > On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: > >> On 5 October 2016 at 08:24, Horng-Shyang Liao <hs.l...@mediatek.com> wr

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Wed, 2016-10-05 at 20:13 +0530, Jassi Brar wrote: > On 5 October 2016 at 18:01, Horng-Shyang Liao wrote: > > On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: > >> On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: > >> > On Fri, 2016-09-30 at 17:47

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: > On 5 October 2016 at 08:24, Horng-Shyang Liao <hs.l...@mediatek.com> wrote: > > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > >> On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > > > >

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Wed, 2016-10-05 at 09:07 +0530, Jassi Brar wrote: > On 5 October 2016 at 08:24, Horng-Shyang Liao wrote: > > On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > >> On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > > > > After I trace mailbox d

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > Hi, HS: > > > > One comment inline > > > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > > Hi CK, > > > > >

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Fri, 2016-09-30 at 17:47 +0800, Horng-Shyang Liao wrote: > On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > > Hi, HS: > > > > One comment inline > > > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > > Hi CK, > > > > >

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > Hi, HS: > > One comment inline > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Please see my inline reply. > > > > On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote:

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Fri, 2016-09-30 at 17:11 +0800, CK Hu wrote: > Hi, HS: > > One comment inline > > On Fri, 2016-09-30 at 16:56 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Please see my inline reply. > > > > On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote:

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

Hi CK, Please see my inline reply. On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers with critical time limitation,

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

Hi CK, Please see my inline reply. On Fri, 2016-09-30 at 11:06 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers with critical time limitation,

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote: > Hi Jassi, > > Please see my inline reply. > > On Thu, 2016-09-22 at 13:47 +0530, Jassi Brar wrote: > > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.l...@mediatek.com> wrote: > [...] > > > +struct

Re: [PATCH v14 4/4] CMDQ: save more energy in idle

On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote: > On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote: > > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao <hs.l...@mediatek.com> wrote: > > > Use clk_disable_unprepare instead of clk_disable to save more energy

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote: > Hi Jassi, > > Please see my inline reply. > > On Thu, 2016-09-22 at 13:47 +0530, Jassi Brar wrote: > > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: > [...] > > > +struct cmdq_base *cmdq_r

Re: [PATCH v14 4/4] CMDQ: save more energy in idle

On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote: > On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote: > > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: > > > Use clk_disable_unprepare instead of clk_disable to save more energy > > > when CMDQ is idle. &g

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

Hi Jassi, Please see my inline reply. On Thu, 2016-09-22 at 13:47 +0530, Jassi Brar wrote: > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: [...] > > +struct cmdq_base *cmdq_register_device(struct device *dev) > > +{ > > + struct cmdq_base *cmdq_base; > > +

Re: [PATCH v14 4/4] CMDQ: save more energy in idle

On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote: > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: > > Use clk_disable_unprepare instead of clk_disable to save more energy > > when CMDQ is idle. > > > > Signed-off-by: HS Liao > > --- > >

Re: [PATCH v14 2/4] CMDQ: Mediatek CMDQ driver

Hi Jassi, Please see my inline reply. On Thu, 2016-09-22 at 13:47 +0530, Jassi Brar wrote: > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: [...] > > +struct cmdq_base *cmdq_register_device(struct device *dev) > > +{ > > + struct cmdq_base *cmdq_base; > > + struct resource res; > >

Re: [PATCH v14 4/4] CMDQ: save more energy in idle

On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote: > On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: > > Use clk_disable_unprepare instead of clk_disable to save more energy > > when CMDQ is idle. > > > > Signed-off-by: HS Liao > > --- > > drivers/mailbox/mtk-cmdq.c | 54 > >

Re: [PATCH v14 0/4] Mediatek MT8173 CMDQ support

On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > Hi, > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > to help write registers with critical time limitation, such as > updating display configuration during the vblank. It controls Global > Command Engine (GCE) hardware

Re: [PATCH v14 0/4] Mediatek MT8173 CMDQ support

On Mon, 2016-09-05 at 09:44 +0800, HS Liao wrote: > Hi, > > This is Mediatek MT8173 Command Queue(CMDQ) driver. The CMDQ is used > to help write registers with critical time limitation, such as > updating display configuration during the vblank. It controls Global > Command Engine (GCE) hardware

Re: [PATCH v13 0/4] Mediatek MT8173 CMDQ support

Hi Jassi, On Wed, 2016-08-31 at 14:15 +0530, Jassi Brar wrote: > On Wed, Aug 31, 2016 at 1:43 PM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: [...] > >> Platforms that need shared access to a channel, implement a 'server' > >> driver that serialise (whi

Re: [PATCH v13 0/4] Mediatek MT8173 CMDQ support

Hi Jassi, On Wed, 2016-08-31 at 14:15 +0530, Jassi Brar wrote: > On Wed, Aug 31, 2016 at 1:43 PM, Horng-Shyang Liao > wrote: [...] > >> Platforms that need shared access to a channel, implement a 'server' > >> driver that serialise (which is needed still) the acces

Re: [PATCH v13 0/4] Mediatek MT8173 CMDQ support

Hi Jassi, On Thu, 2016-08-25 at 19:12 +0530, Jassi Brar wrote: > On Thu, Aug 25, 2016 at 7:07 PM, Horng-Shyang Liao <hs.l...@mediatek.com> > wrote: > > Hi Matthias, > > > > On Wed, 2016-08-24 at 13:00 +0200, Matthias Brugger wrote: > >> On 24/08/16 05:27,

Re: [PATCH v13 0/4] Mediatek MT8173 CMDQ support

Hi Jassi, On Thu, 2016-08-25 at 19:12 +0530, Jassi Brar wrote: > On Thu, Aug 25, 2016 at 7:07 PM, Horng-Shyang Liao > wrote: > > Hi Matthias, > > > > On Wed, 2016-08-24 at 13:00 +0200, Matthias Brugger wrote: > >> On 24/08/16 05:27, HS Liao wrote: [...] > &g

Re: [PATCH v13 0/4] Mediatek MT8173 CMDQ support

Hi Matthias, On Wed, 2016-08-24 at 13:00 +0200, Matthias Brugger wrote: > On 24/08/16 05:27, HS Liao wrote: [...] > > Changes since v12: > > - remove mediatek,gce from device tree > > Why? The binding got accepted by Rob. We can get cmdq dev from mailbox controller, so we don't need

Re: [PATCH v13 0/4] Mediatek MT8173 CMDQ support

Hi Matthias, On Wed, 2016-08-24 at 13:00 +0200, Matthias Brugger wrote: > On 24/08/16 05:27, HS Liao wrote: [...] > > Changes since v12: > > - remove mediatek,gce from device tree > > Why? The binding got accepted by Rob. We can get cmdq dev from mailbox controller, so we don't need

Re: [PATCH v12 2/4] CMDQ: Mediatek CMDQ driver

Hi Matthias, Sorry to disturb you. Do you have any further comment on CMDQ v12? Thanks. HS On Mon, 2016-08-08 at 16:31 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help write registers with critical time limitation, > such as

Re: [PATCH v12 2/4] CMDQ: Mediatek CMDQ driver

Hi Matthias, Sorry to disturb you. Do you have any further comment on CMDQ v12? Thanks. HS On Mon, 2016-08-08 at 16:31 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help write registers with critical time limitation, > such as

Re: [PATCH v10 2/4] CMDQ: Mediatek CMDQ driver

Hi Paul, On Thu, 2016-07-14 at 19:38 -0400, Paul Gortmaker wrote: > On Thu, Jul 14, 2016 at 7:28 AM, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers with critical time limitation, > > such

Re: [PATCH v10 2/4] CMDQ: Mediatek CMDQ driver

Hi Paul, On Thu, 2016-07-14 at 19:38 -0400, Paul Gortmaker wrote: > On Thu, Jul 14, 2016 at 7:28 AM, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help write registers with critical time limitation, > > such as updating display

Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

Hi Jan, On Fri, 2016-07-08 at 12:17 +0200, Jan Lübbe wrote: > On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote: > [...] > > +Required properties: > > +- compatible: Must be "mediatek,mt8173-gce" > > +- reg: Address range of the GCE unit > > +- interrupts: The interrupt signal from the GCE block >

Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit

Hi Jan, On Fri, 2016-07-08 at 12:17 +0200, Jan Lübbe wrote: > On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote: > [...] > > +Required properties: > > +- compatible: Must be "mediatek,mt8173-gce" > > +- reg: Address range of the GCE unit > > +- interrupts: The interrupt signal from the GCE block >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:46 +0800, Horng-Shyang Liao wrote: > On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > > [Snip...] > > &g

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:46 +0800, Horng-Shyang Liao wrote: > On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > > [Snip...] > > &g

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, On Thu, 2016-06-23 at 14:03 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > [...] > > > + > > +/* events for CMDQ and display */ > > +enum cmdq_event { > > + /* Display start of frame(SOF) events */ > > + CMDQ_EVENT_DISP_OVL0_SOF = 11, > > +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, On Thu, 2016-06-23 at 14:03 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > [...] > > > + > > +/* events for CMDQ and display */ > > +enum cmdq_event { > > + /* Display start of frame(SOF) events */ > > + CMDQ_EVENT_DISP_OVL0_SOF = 11, > > +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:41 +0200, Matthias Brugger wrote: > > On 21/06/16 07:52, Horng-Shyang Liao wrote: > > On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > >> > >> On 17/06/16 10:28, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >&

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:41 +0200, Matthias Brugger wrote: > > On 21/06/16 07:52, Horng-Shyang Liao wrote: > > On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > >> > >> On 17/06/16 10:28, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >&

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > One comment inline. > > > > > > On Mon, 2016-0

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > One comment inline. > > > > > > On Mon, 2016-0

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > > On 17/06/16 10:28, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > >> Hi Matthias, > >> > >> On Tue, 2016-06-14 at 12:

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > > On 17/06/16 10:28, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > >> Hi Matthias, > >> > >> On Tue, 2016-06-14 at 12:

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > Hi, HS: > > One comment inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > Hi, HS: > > One comment inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > Hi Matthias, > > On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > > Hi Matthias, > > > > > > On Wed, 2

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > Hi Matthias, > > On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > > Hi Matthias, > > > > > > On Wed, 2

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 14:25, Horng-Shyang Liao wr

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 14:25, Horng-Shyang Liao wr

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > > On 08/06/16 14:25, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 07:40, Horng-Shyang Liao wr

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > > On 08/06/16 14:25, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 07:40, Horng-Shyang Liao wr

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > > On 08/06/16 07:40, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > >> > >>

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > > On 08/06/16 07:40, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > >> > >>

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > > On 03/06/16 15:11, Matthias Brugger wrote: > > > > > [...] > > >> + > >> +smp_mb(); /* modify jump before enable thread */ > >> +} > >> + > >> +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > > On 03/06/16 15:11, Matthias Brugger wrote: > > > > > [...] > > >> + > >> +smp_mb(); /* modify jump before enable thread */ > >> +} > >> + > >> +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 19:04 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > > such as updating display

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 19:04 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > > such as updating display

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger <matthias@gmail.com> > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>> I keep thinking

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, Jassi, On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger <matthias@gmail.com> > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrot

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, Jassi, On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>>

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Fri, 2016-06-03 at 13:18 +0200, Matthias Brugger wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > >> &g

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Fri, 2016-06-03 at 13:18 +0200, Matthias Brugger wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > >> &g

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > On 01/06/16 11:57, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugge

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > On 01/06/16 11:57, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugge

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: > > On 31/05/16 10:36, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugge

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: > > On 31/05/16 10:36, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugge

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, Reply inline. On Mon, 2016-05-30 at 14:49 +0800, CK Hu wrote: > Hi, HS: > > Some comments inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: ... > > +static void cmdq_thread_irq_handler(struct cmdq *cmdq, int tid) > > +{ > > + struct cmdq_thread *thread = >thread[tid]; > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, Reply inline. On Mon, 2016-05-30 at 14:49 +0800, CK Hu wrote: > Hi, HS: > > Some comments inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: ... > > +static void cmdq_thread_irq_handler(struct cmdq *cmdq, int tid) > > +{ > > + struct cmdq_thread *thread = >thread[tid]; > >

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

Hi CK, Reply in line. On Thu, 2016-05-26 at 15:28 +0800, CK Hu wrote: > Hi, HS: > > Replay inline. > > On Tue, 2016-05-24 at 20:27 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Reply in line. > > > > On Tue, 2016-05-24 at 11:05 +0800,

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

Hi CK, Reply in line. On Thu, 2016-05-26 at 15:28 +0800, CK Hu wrote: > Hi, HS: > > Replay inline. > > On Tue, 2016-05-24 at 20:27 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Reply in line. > > > > On Tue, 2016-05-24 at 11:05 +0800,

Re: [PATCH v7 4/4] CMDQ: suspend/resume protection

Hi CK, On Tue, 2016-05-24 at 17:16 +0800, CK Hu wrote: > On Mon, 2016-05-23 at 20:23 +0800, HS Liao wrote: ... > > +static int cmdq_suspend(struct device *dev) > > +{ > > + struct cmdq *cmdq = dev_get_drvdata(dev); > > + u32 exec_threads; > > + int ref_count; > > + unsigned long flags;

Re: [PATCH v7 4/4] CMDQ: suspend/resume protection

Hi CK, On Tue, 2016-05-24 at 17:16 +0800, CK Hu wrote: > On Mon, 2016-05-23 at 20:23 +0800, HS Liao wrote: ... > > +static int cmdq_suspend(struct device *dev) > > +{ > > + struct cmdq *cmdq = dev_get_drvdata(dev); > > + u32 exec_threads; > > + int ref_count; > > + unsigned long flags;

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

Hi CK, Reply in line. On Tue, 2016-05-24 at 11:05 +0800, CK Hu wrote: > Hi, HS: > > Some comments below. > > On Mon, 2016-05-23 at 20:23 +0800, HS Liao wrote: ... > > +struct cmdq_task { > > + struct cmdq *cmdq; > > + struct list_headlist_entry; > > + enum

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

Hi CK, Reply in line. On Tue, 2016-05-24 at 11:05 +0800, CK Hu wrote: > Hi, HS: > > Some comments below. > > On Mon, 2016-05-23 at 20:23 +0800, HS Liao wrote: ... > > +struct cmdq_task { > > + struct cmdq *cmdq; > > + struct list_headlist_entry; > > + enum

Re: [RFC v3 1/3] dt-bindings: soc: Add documentation for the MediaTek GCE unit

On Sat, 2016-03-19 at 19:58 -0500, Rob Herring wrote: > On Fri, Mar 18, 2016 at 07:27:12PM +0800, HS Liao wrote: > > This adds documentation for the MediaTek Global Command Engine (GCE) unit > > found in MT8173 SoCs. > > > > Signed-off-by: HS Liao > > --- > >

Re: [RFC v3 1/3] dt-bindings: soc: Add documentation for the MediaTek GCE unit

On Sat, 2016-03-19 at 19:58 -0500, Rob Herring wrote: > On Fri, Mar 18, 2016 at 07:27:12PM +0800, HS Liao wrote: > > This adds documentation for the MediaTek Global Command Engine (GCE) unit > > found in MT8173 SoCs. > > > > Signed-off-by: HS Liao > > --- > >

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > Hi Dan, > > > > Thanks for your comment. > > This solution looks good to me. > > I will change it as your suggestion. > > > > But, I have a question about 'mask out the provided *device virtual* > > address'. > > Are lower 16-bits (or

Re: [RFC 3/3] CMDQ: Mediatek CMDQ driver

On Wed, 2016-02-03 at 14:40 +0800, Daniel Kurtz wrote: > > Hi Dan, > > > > Thanks for your comment. > > This solution looks good to me. > > I will change it as your suggestion. > > > > But, I have a question about 'mask out the provided *device virtual* > > address'. > > Are lower 16-bits (or

  1   2   >