Re: [PATCH] phy: samsung: Fix build break in USB2 PHY driver for Exynos5420 SoCs

t;phy: samsung: Add support for the Exynos5420 variant of > the USB2 PHY") > Signed-off-by: Marek Szyprowski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > Vinod: this a fix to the patch merged yesterday. If you want me to resend > a fixed initi

Re: [PATCH] arm64: dts: exynos: Use fixed index for the MMC devices

roduced aliases for mmcblk devices from commit fa2d0aa96941 > ("mmc: core: Allow setting slot index via device tree alias"). > > Suggested-by: Markus Reichl > Signed-off-by: Marek Szyprowski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arc

Re: [PATCH] ARM: dts: exynos: Use fixed index for the MMC devices

roduced aliases for mmcblk devices from commit fa2d0aa96941 > ("mmc: core: Allow setting slot index via device tree alias"). > > Suggested-by: Markus Reichl > Signed-off-by: Marek Szyprowski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arch/arm/b

Re: [PATCH] mmc: dw_mmc: replace spin_lock_irqsave by spin_lock in hard IRQ

egards, Jaehoon Chung > > Signed-off-by: Tian Tao > --- > drivers/mmc/host/dw_mmc.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 43c5795..a524443 100644 > --- a/

Re: [PATCH v2 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant

Dear Jingoo, On 10/24/20 12:12 PM, Jingoo Han wrote: > On 10/23/20, 3:58 AM, Marek Szyprowski wrote: >> >> From: Jaehoon Chung >> >> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM: >> dts: exynos: Remove Exynos5440"). Rework

Re: [PATCH 04/15] mmc: host: sdhci-s3c: Provide documentation for missing struct properties

ing: Function parameter or member > 'no_divider' not described in 'sdhci_s3c_drv_data' > > Cc: Adrian Hunter > Cc: Ben Dooks > Cc: Jaehoon Chung > Signed-off-by: Lee Jones Reviewed-by: Jaehoon Chung > --- > drivers/mmc/host/sdhci-s3c.c | 4 > 1 file changed, 4 in

Re: [PATCH 08/15] mmc: host: dw_mmc-exynos: Add kerneldoc descriptions of for 'dev' args

or member > 'dev' not described in 'dw_mci_exynos_suspend_noirq' > drivers/mmc/host/dw_mmc-exynos.c:200: warning: Function parameter or member > 'dev' not described in 'dw_mci_exynos_resume_noirq' > > Cc: Jaehoon Chung > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski &g

Re: [PATCH] usb: dwc2: hcd: call dwc2_is_controller_alive under spinlock

Hi Minas, On 2/14/19 8:43 PM, Minas Harutyunyan wrote: > Hi Jaehoon Chung, > > On 2/14/2019 2:04 PM, Jaehoon Chung wrote: >> This patch is referred to Robert's patch >> commit cf54772b913b ("usb: dwc2: call dwc2_is_controller_alive() under >> spinlock") &

[PATCH] usb: dwc2: hcd: call dwc2_is_controller_alive under spinlock

er the usb interrupt. Signed-off-by: Jaehoon Chung --- drivers/usb/dwc2/hcd_intr.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c index 88b5dcf..8d3b155 100644 --- a/drivers/usb/dwc2/hcd_intr.c +++ b/drivers/usb/dwc2/

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

Hi, On 05/02/2018 03:19 AM, Liming Sun wrote: > This commit adds extension to the dw_mmc driver for Mellanox BlueField > SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on > this SoC. Could you heck Shawn's comments? And add the minor comment. > > Cc: sta...@kernel.org >

Re: [PATCH v5 1/3] mmc: dw_mmc-bluefield: Add driver extension

Hi, On 05/02/2018 03:19 AM, Liming Sun wrote: > This commit adds extension to the dw_mmc driver for Mellanox BlueField > SoC. It updates the UHS_REG_EXT register to bring up the eMMC card on > this SoC. Could you heck Shawn's comments? And add the minor comment. > > Cc: sta...@kernel.org >

Re: [RFC 0/2] dw_mmc: add multislot support

n each slot structure instead of common field in >host structure. > * Add locks to serialize access to registers. Sorry for late. :( Well, I will read the other comments..and reply soon. Best Regards, Jaehoon Chung > > NOTE: this patch is based off of v4.17-rc1 > > N

Re: [RFC 0/2] dw_mmc: add multislot support

n each slot structure instead of common field in >host structure. > * Add locks to serialize access to registers. Sorry for late. :( Well, I will read the other comments..and reply soon. Best Regards, Jaehoon Chung > > NOTE: this patch is based off of v4.17-rc1 > > N

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

On 03/15/2018 07:22 PM, Ulf Hansson wrote: > On 23 February 2018 at 07:41, Jaehoon Chung <jh80.ch...@samsung.com> wrote: >> 'clock-freq-min-max' property had already deprecated. >> Remove the 'clock-freq-min-max' property that is kept to maintain >> the compatibility. &

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

On 03/15/2018 07:22 PM, Ulf Hansson wrote: > On 23 February 2018 at 07:41, Jaehoon Chung wrote: >> 'clock-freq-min-max' property had already deprecated. >> Remove the 'clock-freq-min-max' property that is kept to maintain >> the compatibility. >> >> Signed-o

Re: [RFC 1/2] pci: dwc: pci-exynos: modify the Kconfig dependency

Dear Lorenzo, On 03/13/2018 08:12 PM, Lorenzo Pieralisi wrote: > Hi Jaehoon, > > On Thu, Dec 21, 2017 at 09:14:06PM +0900, Jaehoon Chung wrote: >> PCI_EXYNOS has the dependency with SOC_EXYNOS5440. >> It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other

Re: [RFC 1/2] pci: dwc: pci-exynos: modify the Kconfig dependency

Dear Lorenzo, On 03/13/2018 08:12 PM, Lorenzo Pieralisi wrote: > Hi Jaehoon, > > On Thu, Dec 21, 2017 at 09:14:06PM +0900, Jaehoon Chung wrote: >> PCI_EXYNOS has the dependency with SOC_EXYNOS5440. >> It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

gwoo. https://patchwork.kernel.org/patch/9344477/ Best Regards, Jaehoon Chung > > Signed-off-by: Jinbum Park <jinb.p...@samsung.com> > --- > arch/arm/Kconfig | 1 + > arch/arm/boot/compressed/Makefile | 1 + > arch/arm/vdso/Makefile|

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

gwoo. https://patchwork.kernel.org/patch/9344477/ Best Regards, Jaehoon Chung > > Signed-off-by: Jinbum Park > --- > arch/arm/Kconfig | 1 + > arch/arm/boot/compressed/Makefile | 1 + > arch/arm/vdso/Makefile| 1 + > 3 files changed, 3 inserti

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

On 03/13/2018 01:53 PM, Jinbum Park wrote: > To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected. > > Basic test has passed on Raspberry Pi2, Raspbian jessi lite with > CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL. > > Signed-off-by: Jinbum Park >

Re: [PATCH] arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL

On 03/13/2018 01:53 PM, Jinbum Park wrote: > To enable UBSAN on arm, ARCH_HAS_UBSAN_SANITIZE_ALL is needed to be selected. > > Basic test has passed on Raspberry Pi2, Raspbian jessi lite with > CONFIG_UBSAN_SANITIZE_ALL, CONFIG_UBSAN_NULL. > > Signed-off-by: Jinbum Park > --- >

Re: [PATCH v4] mmc: dw_mmc: Fix the DTO/CTO timeout overflow calculation for 32-bit systems

bgcc and so >> code gets compiled on all 32-bit platforms as opposed to usage >> of DIV_ROUND_UP when we may only compile stuff on a very few arches. >> >> Lets cast this multiply to u64 type which prevents overflow. > > Reviewed-by: Jisheng Zhang <jisheng.zh...@sy

Re: [PATCH v4] mmc: dw_mmc: Fix the DTO/CTO timeout overflow calculation for 32-bit systems

bgcc and so >> code gets compiled on all 32-bit platforms as opposed to usage >> of DIV_ROUND_UP when we may only compile stuff on a very few arches. >> >> Lets cast this multiply to u64 type which prevents overflow. > > Reviewed-by: Jisheng Zhang Acked-by: Jaeho

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

On 02/27/2018 08:36 PM, Jaehoon Chung wrote: > On 02/27/2018 08:28 PM, Ulf Hansson wrote: >> On 23 February 2018 at 07:30, Jaehoon Chung <jh80.ch...@samsung.com> wrote: >>> On 02/23/2018 10:40 AM, Shawn Lin wrote: >>>> Hi Alexey, >>>> >>>&g

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

On 02/27/2018 08:36 PM, Jaehoon Chung wrote: > On 02/27/2018 08:28 PM, Ulf Hansson wrote: >> On 23 February 2018 at 07:30, Jaehoon Chung wrote: >>> On 02/23/2018 10:40 AM, Shawn Lin wrote: >>>> Hi Alexey, >>>> >>>> On 2018/2/23 3:45, Alexey

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

On 02/27/2018 08:28 PM, Ulf Hansson wrote: > On 23 February 2018 at 07:30, Jaehoon Chung <jh80.ch...@samsung.com> wrote: >> On 02/23/2018 10:40 AM, Shawn Lin wrote: >>> Hi Alexey, >>> >>> On 2018/2/23 3:45, Alexey Roslyakov wrote: >>>> cur_

Re: [PATCH] mmc: dw_mmc: update kernel-doc comments for dw_mci

On 02/27/2018 08:28 PM, Ulf Hansson wrote: > On 23 February 2018 at 07:30, Jaehoon Chung wrote: >> On 02/23/2018 10:40 AM, Shawn Lin wrote: >>> Hi Alexey, >>> >>> On 2018/2/23 3:45, Alexey Roslyakov wrote: >>>> cur_slot and num_slots has

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

On 02/24/2018 01:16 AM, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 4:19 PM, Shawn Lin <shawn@rock-chips.com> wrote: >> On 2018/2/23 21:27, Andy Shevchenko wrote: >>> On Fri, Feb 23, 2018 at 8:41 AM, Jaehoon Chung <jh80.ch...@samsung.com> >>> wrote:

Re: [PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

On 02/24/2018 01:16 AM, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 4:19 PM, Shawn Lin wrote: >> On 2018/2/23 21:27, Andy Shevchenko wrote: >>> On Fri, Feb 23, 2018 at 8:41 AM, Jaehoon Chung >>> wrote: >>>> >>>> 'clock-freq-min-max' prop

[PATCH 4/6] arm64: dts: stratix10: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/

[PATCH 4/6] arm64: dts: stratix10: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung --- arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot

[PATCH 3/6] ARM: dts: socfpga: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dts | 1 - arch/arm/boot/dts/socfpga_arria5.dtsi | 1 - arch/arm/boot/dts/socfpga_cyclone

[PATCH 6/6] arm64: dts: hi3660: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm6

[PATCH 5/6] ARM: dts: lpc18xx: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/lpc18xx.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi

[PATCH 6/6] arm64: dts: hi3660: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660

[PATCH 5/6] ARM: dts: lpc18xx: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung --- arch/arm/boot/dts/lpc18xx.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi index 7cae9c5e27db..10b8249b8ab6

[PATCH 3/6] ARM: dts: socfpga: remove 'num-slots' property for dwmmc

Since 'num-slots' had already deprecated, remove the property in device-tree file. Signed-off-by: Jaehoon Chung --- arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dts | 1 - arch/arm/boot/dts/socfpga_arria5.dtsi | 1 - arch/arm/boot/dts/socfpga_cyclone5.dtsi | 1 - arch/arm

[PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

'clock-freq-min-max' property had already deprecated. Remove the 'clock-freq-min-max' property that is kept to maintain the compatibility. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 4 drivers/mmc/host/dw

[PATCH 1/6] mmc: dw_mmc: remove the deprecated "clock-freq-min-max" property

'clock-freq-min-max' property had already deprecated. Remove the 'clock-freq-min-max' property that is kept to maintain the compatibility. Signed-off-by: Jaehoon Chung --- .../devicetree/bindings/mmc/synopsys-dw-mshc.txt | 4 drivers/mmc/host/dw_mmc.c

[PATCH 2/6] mmc: dw_mmc: remove the deprecated "num-slots"

'num-slots' property had already deprecated. Remove the 'nom-slots' property that is kept to maintain the compatibility. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 5 - drivers/mmc/host/dw_mmc

[PATCH 2/6] mmc: dw_mmc: remove the deprecated "num-slots"

'num-slots' property had already deprecated. Remove the 'nom-slots' property that is kept to maintain the compatibility. Signed-off-by: Jaehoon Chung --- Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 5 - drivers/mmc/host/dw_mmc-pci.c | 1

Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

i3660") Could you resend the patch with changing commit-msg? Then i will pick yours. Best Regards, Jaehoon Chung > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org >

Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias

> >> Fix this by adding a range check. >> >> Fixes: 7d92895208a008a2 ("mmc: dw_mmc-k3: Fix out-of-bounds access through >> DT alias") > > Oops > > Fixes: 361c7fe9b02eee7e ("mmc: dw_mmc-k3: add sd support for hi3660") Could you resen

Re: [PATCH] PCI: exynos: remove the deprecated phy codes

On 01/03/2018 01:34 AM, Lorenzo Pieralisi wrote: > On Wed, Dec 27, 2017 at 06:43:27PM +0900, Jaehoon Chung wrote: >> pci-exynos had updated to use the PHY framework. >> (drivers/phy/samsung/phy-exynos-pcie.c) >> Removed the depreccated codes relevant to phy in pci-exynos.c. &g

Re: [PATCH] PCI: exynos: remove the deprecated phy codes

On 01/03/2018 01:34 AM, Lorenzo Pieralisi wrote: > On Wed, Dec 27, 2017 at 06:43:27PM +0900, Jaehoon Chung wrote: >> pci-exynos had updated to use the PHY framework. >> (drivers/phy/samsung/phy-exynos-pcie.c) >> Removed the depreccated codes relevant to phy in pci-exynos.c. &g

[PATCH] PCI: exynos: remove the deprecated phy codes

pci-exynos had updated to use the PHY framework. (drivers/phy/samsung/phy-exynos-pcie.c) Removed the depreccated codes relevant to phy in pci-exynos.c. Instead, use the phy-exynos-pcie.c file. Modified the binding documentation. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.

[PATCH] PCI: exynos: remove the deprecated phy codes

pci-exynos had updated to use the PHY framework. (drivers/phy/samsung/phy-exynos-pcie.c) Removed the depreccated codes relevant to phy in pci-exynos.c. Instead, use the phy-exynos-pcie.c file. Modified the binding documentation. Signed-off-by: Jaehoon Chung --- .../bindings/pci/samsung

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

On 12/27/2017 06:11 AM, Rob Herring wrote: > On Thu, Dec 21, 2017 at 09:14:07PM +0900, Jaehoon Chung wrote: >> Exynos5433 has the PCIe for WiFi. >> Added the codes relevant to PCIe for supporting the exynos5433. >> Also changed the binding documentation name to >&g

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

On 12/27/2017 06:11 AM, Rob Herring wrote: > On Thu, Dec 21, 2017 at 09:14:07PM +0900, Jaehoon Chung wrote: >> Exynos5433 has the PCIe for WiFi. >> Added the codes relevant to PCIe for supporting the exynos5433. >> Also changed the binding documentation name to >&g

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

Hi Jingoo, On 12/22/2017 01:12 AM, Jingoo Han wrote: > On Thursday, December 21, 2017 7:14 AM, Jaehoon Chung wrote: >> >> Exynos5433 has the PCIe for WiFi. >> Added the codes relevant to PCIe for supporting the exynos5433. >> Also changed the binding documentation

Re: [RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

Hi Jingoo, On 12/22/2017 01:12 AM, Jingoo Han wrote: > On Thursday, December 21, 2017 7:14 AM, Jaehoon Chung wrote: >> >> Exynos5433 has the PCIe for WiFi. >> Added the codes relevant to PCIe for supporting the exynos5433. >> Also changed the binding documentation

[RFC 2/2] pci: dwc: pci-exynos: add the coedes to support the exynos5433

Exynos5433 has the PCIe for WiFi. Add the codes relevant to PCIe for supporting the exynos5433. Also changed the binding documentation name to 'samsung,exynos-pcie.txt'. (It's not only exynos5440 anymore.) Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- ...exynos5440-pc

[RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

Exynos5433 has the PCIe for WiFi. Added the codes relevant to PCIe for supporting the exynos5433. Also changed the binding documentation name to 'samsung,exynos-pcie.txt'. (It's not only exynos5440 anymore.) Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- ...exynos5440-pc

[RFC 2/2] pci: dwc: pci-exynos: add the coedes to support the exynos5433

Exynos5433 has the PCIe for WiFi. Add the codes relevant to PCIe for supporting the exynos5433. Also changed the binding documentation name to 'samsung,exynos-pcie.txt'. (It's not only exynos5440 anymore.) Signed-off-by: Jaehoon Chung --- ...exynos5440-pcie.txt => samsung,exynos-pcie.txt} |

[RFC 2/2] pci: dwc: pci-exynos: add the codes to support the exynos5433

Exynos5433 has the PCIe for WiFi. Added the codes relevant to PCIe for supporting the exynos5433. Also changed the binding documentation name to 'samsung,exynos-pcie.txt'. (It's not only exynos5440 anymore.) Signed-off-by: Jaehoon Chung --- ...exynos5440-pcie.txt => samsung,exynos-pcie.

[RFC 1/2] pci: dwc: pci-exynos: modify the Kconfig dependency

PCI_EXYNOS has the dependency with SOC_EXYNOS5440. It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other SoCs needs to use this driver. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/pci/dwc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RFC 1/2] pci: dwc: pci-exynos: modify the Kconfig dependency

PCI_EXYNOS has the dependency with SOC_EXYNOS5440. It's modified to ARCH_EXYNOS from SOC_EXYNOS5440, because other SoCs needs to use this driver. Signed-off-by: Jaehoon Chung --- drivers/pci/dwc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/dwc/Kconfig

Re: [PATCH v2 3/5] mmc: dw_mmc: Add locking to the CTO timer

. I'm happy to re-post with > collected tags or anything else you'd like. It would be nice to get > the regression fixed sooner rather than later... Sorry. I didn't find this email in my mail-box. so i lost this. Current i'm reading the comment history..Sorry for late. Best Regards, Jaehoon Chung > > Thanks! :) > > -Doug > > >

Re: [PATCH v2 3/5] mmc: dw_mmc: Add locking to the CTO timer

with > collected tags or anything else you'd like. It would be nice to get > the regression fixed sooner rather than later... Sorry. I didn't find this email in my mail-box. so i lost this. Current i'm reading the comment history..Sorry for late. Best Regards, Jaehoon Chung > > Thanks! :) > > -Doug > > >

Re: [PATCH 0/9] Enable dw-mmc multi-card support

t->num_slots will be > set to 1. So the logic of setting default num_slots seems already there. But > correct me if I am wrong. > > Thanks, > Liming > > -Original Message- > From: Shawn Lin [mailto:shawn@rock-chips.com] > Sent: Monday, Octob

Re: [PATCH 0/9] Enable dw-mmc multi-card support

t->num_slots will be > set to 1. So the logic of setting default num_slots seems already there. But > correct me if I am wrong. > > Thanks, > Liming > > -Original Message- > From: Shawn Lin [mailto:shawn@rock-chips.com] > Sent: Monday, October 16, 201

Re: [PATCH v5] mmc: dw_mmc-k3: add sd support for hi3660

nts. > > Major changes in v3: > - solve review comments from Heiner Kallweit. >*use the GENMASK and FIELD_PREP macros replace the bit shift operation. >*use usleep_range() replace udelay() and mdelay(). > > Major changes in v4: > - solve review comments from J

Re: [PATCH v5] mmc: dw_mmc-k3: add sd support for hi3660

nts. > > Major changes in v3: > - solve review comments from Heiner Kallweit. >*use the GENMASK and FIELD_PREP macros replace the bit shift operation. >*use usleep_range() replace udelay() and mdelay(). > > Major changes in v4: > - solve review comments from J

Re: [PATCH v3] mmc: dw_mmc-k3: add sd support for hi3660

Hi, On 06/12/2017 11:27 PM, Jaehoon Chung wrote: > Hi Li, > > On 2017년 06월 12일 16:46, liwei wrote: >> Add sd card support for hi3660 soc >> >> Major changes in v3: >> - solve review comments from Heiner Kallweit. >>*use the GENMASK and FIELD_PREP

Re: [PATCH v3] mmc: dw_mmc-k3: add sd support for hi3660

Hi, On 06/12/2017 11:27 PM, Jaehoon Chung wrote: > Hi Li, > > On 2017년 06월 12일 16:46, liwei wrote: >> Add sd card support for hi3660 soc >> >> Major changes in v3: >> - solve review comments from Heiner Kallweit. >>*use the GENMASK and FIELD_PREP

[PATCH v2] ARM: dts: rv1108: change to "max-frequency" from "clock-freq-min-max"

"clock-freq-min-max" was deprecated. There is only using in rv1108.dtsi. Use the "max-frequency" for removiing "clock-freq-min-max" in future. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- Changelog on V2: - Rebased on Heiko's git repository (v4.13-

[PATCH v2] ARM: dts: rv1108: change to "max-frequency" from "clock-freq-min-max"

"clock-freq-min-max" was deprecated. There is only using in rv1108.dtsi. Use the "max-frequency" for removiing "clock-freq-min-max" in future. Signed-off-by: Jaehoon Chung --- Changelog on V2: - Rebased on Heiko's git repository (v4.13-armsoc/dts32 branch) arc

Re: [PATCH] ARM: dts: rk1108: change to "max-frequency" from "clock-freq-min-max"

Hi, On 06/06/2017 10:15 AM, Andy Yan wrote: > Hi Jaehoon: > > > 2017-06-01 12:43 GMT+08:00 Jaehoon Chung <jh80.ch...@samsung.com>: > >> "clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi. >> Use the "max-frequency" for r

Re: [PATCH] ARM: dts: rk1108: change to "max-frequency" from "clock-freq-min-max"

Hi, On 06/06/2017 10:15 AM, Andy Yan wrote: > Hi Jaehoon: > > > 2017-06-01 12:43 GMT+08:00 Jaehoon Chung : > >> "clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi. >> Use the "max-frequency" for removiing "clock-freq-mi

[PATCH] ARM: dts: rk1108: change to "max-frequency" from "clock-freq-min-max"

"clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi. Use the "max-frequency" for removiing "clock-freq-min-max" in future. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- arch/arm/boot/dts/rk1108.dtsi | 6 +++--- 1 file changed, 3

[PATCH] ARM: dts: rk1108: change to "max-frequency" from "clock-freq-min-max"

"clock-freq-min-max" was deprecated. There is only using in rk1108.dtsi. Use the "max-frequency" for removiing "clock-freq-min-max" in future. Signed-off-by: Jaehoon Chung --- arch/arm/boot/dts/rk1108.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

Re: [PATCH v3 1/2] mmc: dw_mmc: Use device_property_read instead of of_property_read

@mellanox.com> > Cc: sta...@vger.linux.org Acked-by: Jaehoon Chung <jh80.ch...@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/host/dw_mmc.c | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/mmc/host/d

Re: [PATCH v3 1/2] mmc: dw_mmc: Use device_property_read instead of of_property_read

On 05/27/2017 06:53 AM, David Woods wrote: > Using the device_property interfaces allows the dw_mmc driver to work > on platforms which run on either device tree or ACPI. > > Signed-off-by: David Woods > Reviewed-by: Chris Metcalf > Cc: sta...@vger.linux.org Acked-by: Ja

Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

hat previously used to > print the message. I think you are not using the latest kernel. which version do you use? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9 Could you check this? Best Regards, Jaehoon Chung > > Fixes

Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

hat previously used to > print the message. I think you are not using the latest kernel. which version do you use? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9 Could you check this? Best Regards, Jaehoon Chung > > Fixes

Re: [PATCH] mmc: dw_mmc: Don't allow Runtime PM for SDIO cards

t to fully runtime > suspend in this case though--at least not with the current > dw_mci_runtime_resume() which basically fully resets the controller at > resume time. > > Fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback") > Cc: <sta...@vger.kernel.org>

Re: [PATCH] mmc: dw_mmc: Don't allow Runtime PM for SDIO cards

t to fully runtime > suspend in this case though--at least not with the current > dw_mci_runtime_resume() which basically fully resets the controller at > resume time. > > Fixes: e9ed8835e990 ("mmc: dw_mmc: add runtime PM callback") > Cc: > Reported-by: Brian Norris &g

Re: [PATCH] mmc: core: add mmc-card hardware reset enable support

EXT_CSD_RST_N_FUNCTION, EXT_CSD_RST_N_ENABLED, > + card->ext_csd.generic_cmd6_time); > + if (err && err != -EBADMSG) > + pr_warn("%s: Enabling RST_N feature failed\n", > + mmc_hostname(card->host)); > + } If enabled hw-reset, it doesn't need to re-enable this bit. i didn't check the mmc-util.. If mmc-util provides the changing this, the using mmc-util is better than this. Best Regards, Jaehoon Chung > + > if (!oldcard) > host->card = card; > >

Re: [PATCH] mmc: core: add mmc-card hardware reset enable support

card->ext_csd.generic_cmd6_time); > + if (err && err != -EBADMSG) > + pr_warn("%s: Enabling RST_N feature failed\n", > + mmc_hostname(card->host)); > + } If enabled hw-reset, it doesn't need to re-enable this bit. i didn't check the mmc-util.. If mmc-util provides the changing this, the using mmc-util is better than this. Best Regards, Jaehoon Chung > + > if (!oldcard) > host->card = card; > >

Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs

ext_csd.rev); I'm not sure but if someone want to know ext_csd revision information, attribute name might be more clearly. e,g) ext_csd_rev? It's my preference. :) Best Regards, Jaehoon Chung > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DE

Re: [PATCH 1/1] mmc: core: export emmc revision via sysfs

ext_csd revision information, attribute name might be more clearly. e,g) ext_csd_rev? It's my preference. :) Best Regards, Jaehoon Chung > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n&qu

[PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

There are same conditions for checking whether supporting clkscaling or not. When ufshcd is supporting clkscaling, active_reqs should be decreased by two. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/scsi/ufs/ufshcd.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

There are same conditions for checking whether supporting clkscaling or not. When ufshcd is supporting clkscaling, active_reqs should be decreased by two. Signed-off-by: Jaehoon Chung --- drivers/scsi/ufs/ufshcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

gt;> In dw_mmc.c file there are also unconditional calls to >>> reset_control_assert, with disabled RESET_CONTROLLER it will cause >>> unexpected WARNs. >>> Anyway if you change reset API as above I think you should remove all >>> warns from reset stubs, because

Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

e also unconditional calls to >>> reset_control_assert, with disabled RESET_CONTROLLER it will cause >>> unexpected WARNs. >>> Anyway if you change reset API as above I think you should remove all >>> warns from reset stubs, because NULL reset is valid, but these warns are >>> there for reason - contradiction. >> >> You are right, I have to let go of those, too. > > > Until fixed, I have dropped the three changes from my next branch > related to this. Please re-post when fixed. I missed this patch. If resend the patch, i will check. Best Regards, Jaehoon Chung > > Kind regards > Uffe > >> >> regards >> Philipp >> > > >

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

lectrons.com> > Cc: Chen-Yu Tsai <w...@csie.org> > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Cc: Krzysztof Kozlowski <k...@kernel.org> > Cc: Jaehoon Chung <jh80.ch...@samsung.com> > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-arm-...@vger.kerne

Re: [RESEND PATCH v3 2/2] phy: Group vendor specific phy drivers

hen-Yu Tsai > Cc: Sylwester Nawrocki > Cc: Krzysztof Kozlowski > Cc: Jaehoon Chung > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-arm-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-o...@vger.kernel.org > Cc: linux-renesas-...@vger.kernel.org > Cc

Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

Hi Vivek, On 03/12/2017 06:18 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: >> Hi, >> >> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >>> Make the "sams

Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

Hi Vivek, On 03/12/2017 06:18 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Thu, Mar 9, 2017 at 5:26 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >>> Make the "samsung&qu

Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

Hi All, On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote: > On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I <kis...@ti.com> wrote: >> Hi, >> >> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >>> Make the "samsung"

Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

Hi All, On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote: > On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote: >>> Make the "samsung" directory and move the Samsung spe

[RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

Make the "samsung" directory and move the Samsung specific files to there for maintaining the files relevant to Samsung. Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/phy/Kconfig | 96 +-- driv

[RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

Make the "samsung" directory and move the Samsung specific files to there for maintaining the files relevant to Samsung. Signed-off-by: Jaehoon Chung --- drivers/phy/Kconfig | 96 +-- drivers/phy/Makefile

[PATCH] phy: phy-exynos-pcie: fix the wrong error return

When it doesn't get the blk_base's resource, it was returned the error about phy_base, not blk_base. This patch is for fixing the wrong error return about blk_base. Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY") Signed-off-by: Jaehoon Chung <jh80.ch..

[PATCH] phy: phy-exynos-pcie: fix the wrong error return

When it doesn't get the blk_base's resource, it was returned the error about phy_base, not blk_base. This patch is for fixing the wrong error return about blk_base. Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY") Signed-off-by: Jaehoon Chung --- drive

[PATCH] PCI: exynos: fix the NULL pointer dereference about elbi_base

Even though using phy framework, it has to get the elbi_base. Before this patch, elbi_base should be NULL pointer. Fixes: e7cd7ef58e1f ("PCI: exynos: Support the PHY generic framework") Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> --- drivers/pci/dwc/pci-exynos.c | 8

[PATCH] PCI: exynos: fix the NULL pointer dereference about elbi_base

Even though using phy framework, it has to get the elbi_base. Before this patch, elbi_base should be NULL pointer. Fixes: e7cd7ef58e1f ("PCI: exynos: Support the PHY generic framework") Signed-off-by: Jaehoon Chung --- drivers/pci/dwc/pci-exynos.c | 8 1 file changed, 4

Re: [PATCH v4 2/2] mmc: host: s3cmci: allow probing from device tree

On 03/03/2017 08:38 PM, Sergio Prado wrote: > On Fri, Mar 03, 2017 at 11:14:29AM +0900, Jaehoon Chung wrote: >> On 03/02/2017 10:18 AM, Sergio Prado wrote: >>> Allows configuring Samsung S3C24XX MMC/SD/SDIO controller using a device >>> tree. >>> >>>

Re: [PATCH v4 2/2] mmc: host: s3cmci: allow probing from device tree

On 03/03/2017 08:38 PM, Sergio Prado wrote: > On Fri, Mar 03, 2017 at 11:14:29AM +0900, Jaehoon Chung wrote: >> On 03/02/2017 10:18 AM, Sergio Prado wrote: >>> Allows configuring Samsung S3C24XX MMC/SD/SDIO controller using a device >>> tree. >>

Re: [PATCH v4 1/2] dt-bindings: mmc: add DT binding for S3C24XX MMC/SD/SDIO controller

-gpios: gpio for card detection (see mmc.txt) > +- wp-gpios: gpio for write protection (see mmc.txt) I think these properties don't need to describe at here. It's common properties. Best Regards, Jaehoon Chung > + > +Example: > + > + mmc0: mmc@5a00 { > +

  1   2   3   4   5   6   7   8   9   10   >