Re: [PATCH net-next v2 0/4] bonding: initial support for hardware crypto offload

On Wed, Jun 10, 2020 at 1:18 PM Jarod Wilson wrote: > > This is an initial functional implementation for doing pass-through of > hardware encryption from bonding device to capable slaves, in active-backup > bond setups. This was developed and tested using ixgbe-driven Intel x520 > interfaces with

Re: linux-next: manual merge of the net-next tree with the net tree

nux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your > tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any > particularly > compl

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > > On Fri, 2019-08-23 at 19:14 +, Forrest Fleming wrote: > > > suggested by checkpatch > > > > > > Signed-off-by: Forrest Fleming > >

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

On Tue, 2019-08-27 at 12:45 -0700, Forrest Fleming wrote: > On Tue, Aug 27, 2019 at 12:07 PM Joe Perches wrote: > > On Tue, 2019-08-27 at 12:02 -0700, Jeff Kirsher wrote: > > > On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > > > > On Mon, 2019-08-26 at 0

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > > On Fri, 2019-08-23 at 19:14 +, Forrest Fleming wrote: > > > suggested by checkpatch > > > > > > Signed-off-by: Forrest Fleming > >

Re: [PATCH] net: intel: Cleanup e1000 - add space between }}

On Fri, 2019-08-23 at 19:14 +, Forrest Fleming wrote: > suggested by checkpatch > > Signed-off-by: Forrest Fleming > --- > .../net/ethernet/intel/e1000/e1000_param.c| 28 +-- > 1 file changed, 14 insertions(+), 14 deletions(-) While I do not see an issue with this

Re: drivers/net/ethernet/intel/i40e/i40e_main.c:7089:35-37: ERROR: invalid reference to the index variable of the iterator on line 7056 (fwd)

the iterator on line 7056 > > CC: kbuild-...@01.org > CC: linux-kernel@vger.kernel.org > TO: Harshitha Ramamurthy > CC: Jeff Kirsher > > tree: > https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: ecb095bff5d4b8711a81968

Re: [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag_t

ion of macro > '__KERNEL_DIV_ROUND_UP' > #define __KERNEL_DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) > ^ > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4138:12: note: in > expansion of macro 'TXD_USE_COUNT' >count += TXD_USE_COUN

Re: [PATCH -next v2] net/ixgbevf: fix a compilation error of skb_frag_t

On Wed, 2019-07-24 at 14:41 -0700, David Miller wrote: > From: Jeff Kirsher > Date: Wed, 24 Jul 2019 09:39:26 -0700 > > > Dave I will pick this up and add it to my queue. > > How soon will you get that to me? The sooner this build fix is cured > the > better.

Re: [PATCH -next v2] net/ixgbevf: fix a compilation error of skb_frag_t

On Wed, 2019-07-24 at 12:17 -0400, Qian Cai wrote: > The linux-next commit "net: Rename skb_frag_t size to bv_len" [1] > introduced a compilation error on powerpc as it forgot to deal with > the > renaming from "size" to "bv_len" for ixgbevf. > > [1] >

Re: [PATCH net-next] intel: Mark expected switch fall-throughs

On Wed, 2019-01-23 at 11:11 -0600, Gustavo A. R. Silva wrote: > Hi Jeffrey, > > On 1/23/19 11:04 AM, Jeff Kirsher wrote: > > On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > c

Re: [PATCH net-next] intel: Mark expected switch fall-throughs

On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/ethernet/intel/igb/e1000_82575.c:636:6: warning: this >

Re: [Intel-wired-lan] [PATCH 1/3] treewide: Lift switch variables out of switches

arnings like this: > > fs/fcntl.c: In function ‘send_sigio_to_task’: > fs/fcntl.c:738:13: warning: statement will never be executed [- > Wswitch-unreachable] >siginfo_t si; > ^~ > > Signed-off-by: Kees Cook Acked-by: Jeff Kirsher For the e1000 changes.

Re: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:908

On Fri, 2019-01-18 at 18:31 +0900, Tetsuo Handa wrote: > This is not a MM bug. ;-) > And this change is made by below commit. > > commit 59361316afcb08569af21e1af83e89c7051c055a > Author: Jeff Kirsher > Date: Thu Aug 2 10:13:10 2018 -0700 > > igb: reduce CP

Re: [Intel-wired-lan] [BUG] igb: reconnecting of cable not always detected

On Fri, May 18, 2018 at 12:36 AM Holger Schurig wrote: > > Alexander Duyck writes: > > Thanks for the data. It is actually useful. There are a few things > > that I see that seem to point to an obvious issue. > > Any news on this? > > A collegue of mine states (I have not checked this) that a

Re: [PATCH 3/8] i40e: increase indentation

On Thu, 2019-01-03 at 16:37 -0800, David Miller wrote: > From: Jeff Kirsher > Date: Thu, 03 Jan 2019 15:58:10 -0800 > > > On Sun, 2018-12-30 at 16:53 +0100, Julia Lawall wrote: > > > Convert spaces to tabs to get correct alignment. > > > > &

Re: [PATCH 3/8] i40e: increase indentation

1 insertion(+), 1 deletion(-) Acked-by: Jeff Kirsher Dave, since this is apart of a series, please feel free to commit this patch with the series. signature.asc Description: This is a digitally signed message part

Re: [PATCH] net: 80003es2lan: fix a missing check of read failure

On Thu, 2018-12-20 at 15:23 -0600, Kangjie Lu wrote: > When e1000_read_kmrn_reg_80003es2lan() fails, "kum_reg_data" is > uninitialized and may contain random value. However, it is further > used in the following execution, which will lead to undefined > behaviors. > The fix checks the failure of

Re: [PATCH net-next] ixgbe: fix XFRM_ALGO dependency

On Tue, 2018-10-16 at 09:35 -0700, Shannon Nelson wrote: > On 10/16/2018 3:03 AM, Arnd Bergmann wrote: > > When XFRM_ALGO is not enabled, the new igxge ipsec code produces a > > link error: > > s/igxge/ixgbe/ > > > > > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.o: In function > >

Re: [PATCH net-next] ixgbe: fix XFRM_ALGO dependency

On Tue, 2018-10-16 at 09:35 -0700, Shannon Nelson wrote: > On 10/16/2018 3:03 AM, Arnd Bergmann wrote: > > When XFRM_ALGO is not enabled, the new igxge ipsec code produces a > > link error: > > s/igxge/ixgbe/ > > > > > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.o: In function > >

Re: [PATCH v1 1/4] igb: Remove unnecessary include of

On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The igb driver doesn't need anything provided by pci-aspm.h, so > remove > the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher I am fine with you p

Re: [PATCH v1 1/4] igb: Remove unnecessary include of

On Wed, 2018-07-25 at 14:52 -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The igb driver doesn't need anything provided by pci-aspm.h, so > remove > the unnecessary include of it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher I am fine with you p

Re: [PATCH v6 4/5] ixgbe: Report PCIe link properties with pcie_print_link_status()

nt slot, but pcie_print_link_status() uses dev_info() because > if the > platform has no faster slot available, the user can't do anything > about the > warning and may not want to be bothered with it. > > Signed-off-by: Bjorn Helgaas <bhelg...@google.com> Acked-by: Jeff Ki

Re: [PATCH v6 4/5] ixgbe: Report PCIe link properties with pcie_print_link_status()

_status() uses dev_info() because > if the > platform has no faster slot available, the user can't do anything > about the > warning and may not want to be bothered with it. > > Signed-off-by: Bjorn Helgaas Acked-by: Jeff Kirsher Since this is apart of a series, I am not p

Re: [PATCH v6 5/5] PCI: Remove unused pcie_get_minimum_link()

On Thu, 2018-05-10 at 11:33 -0500, Bjorn Helgaas wrote: > On Thu, May 03, 2018 at 03:00:43PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > In some cases pcie_get_minimum_link() returned misleading > > information > > because it found the slowest link and the

Re: [PATCH v6 5/5] PCI: Remove unused pcie_get_minimum_link()

On Thu, 2018-05-10 at 11:33 -0500, Bjorn Helgaas wrote: > On Thu, May 03, 2018 at 03:00:43PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > In some cases pcie_get_minimum_link() returned misleading > > information > > because it found the slowest link and the narrowest link without

Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()

On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote: > Remove ixgbevf_write_tail() in favor of moving writel() close to > wmb(). > > Signed-off-by: Sinan Kaya > Reviewed-by: Alexander Duyck > --- > drivers/net/ethernet/intel/ixgbevf/ixgbevf.h

Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()

On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote: > Remove ixgbevf_write_tail() in favor of moving writel() close to > wmb(). > > Signed-off-by: Sinan Kaya > Reviewed-by: Alexander Duyck > --- > drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 - >

Re: [PATCH] e1000e: Fix link status in case of error.

On Wed, 2018-02-28 at 14:20 +0900, Benjamin Poirier wrote: > Before commit 19110cfbb34d ("e1000e: Separate signaling for link > check/link > up"), errors which happen after "get_link_status = false" in the > copper > check_for_link callbacks would be ignored and the link considered up. > After >

Re: [PATCH] e1000e: Fix link status in case of error.

On Wed, 2018-02-28 at 14:20 +0900, Benjamin Poirier wrote: > Before commit 19110cfbb34d ("e1000e: Separate signaling for link > check/link > up"), errors which happen after "get_link_status = false" in the > copper > check_for_link callbacks would be ignored and the link considered up. > After >

Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower

> > Addresses-Coverity-ID: 1465282 ("Copy-paste error") > > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > > Thanks for the patch! > > Acked-by:Harshitha

Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower

> > Addresses-Coverity-ID: 1465282 ("Copy-paste error") > > Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters") > > Signed-off-by: Gustavo A. R. Silva > > Thanks for the patch! > > Acked-by:Harshitha Ramamurthy Acked-by: Jeff Kirshe

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

On Tue, 2018-02-06 at 13:01 -0800, Alexander Duyck wrote: > On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe > wrote: > > Update documentation on how to enable ixgb and ixgb DCB. > > Simply remove NETDEV_1 and replace it with the new used kconfig > > names. > > Minor typo

Re: [Intel-wired-lan] [PATCH] Documentation: networking: Update ixgb kconfig select documentation

On Tue, 2018-02-06 at 13:01 -0800, Alexander Duyck wrote: > On Tue, Feb 6, 2018 at 12:42 PM, Corentin Labbe > wrote: > > Update documentation on how to enable ixgb and ixgb DCB. > > Simply remove NETDEV_1 and replace it with the new used kconfig > > names. > > Minor typo in the patch

Re: [PATCH][next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR

On Fri, 2018-01-12 at 17:13 +, Colin King wrote: > From: Colin Ian King > > The incorrect operator && is being used and will always return false > as offset can never be two different values at the same time. Fix > this > by using the || operator instead. > >

Re: [PATCH][next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR

On Fri, 2018-01-12 at 17:13 +, Colin King wrote: > From: Colin Ian King > > The incorrect operator && is being used and will always return false > as offset can never be two different values at the same time. Fix > this > by using the || operator instead. > > Detected by CoverityScan,

[PATCH v2] Enable SR-IOV instantiation through /sys file

From: Liang-Min Wang When a SR-IOV capable device is bound with vfio-pci, the device loses capability of creating SR-IOV instances through /sy/bus/ pci/devices/.../sriov_numvfs. This patch re-activates this capability for a PCIe device that is SR-IOV capable and is

[PATCH v2] Enable SR-IOV instantiation through /sys file

From: Liang-Min Wang When a SR-IOV capable device is bound with vfio-pci, the device loses capability of creating SR-IOV instances through /sy/bus/ pci/devices/.../sriov_numvfs. This patch re-activates this capability for a PCIe device that is SR-IOV capable and is bound with vfio-pci.ko. This

Re: [Intel-wired-lan] [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

t; Cc: linux-r...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Cc: kvm...@lists.cs.columbia.edu Acked-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> For the changes to the Intel drivers. > --- > arch/microblaze/kernel/timer.c | 20 ++-- > driv

Re: [Intel-wired-lan] [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

radead.org > Cc: net...@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org > Cc: linux-r...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Cc: kvm...@lists.cs.columbia.edu Acked-by: Jeff Kirsher For the changes to the Intel drivers. > --- > arch/microblaze/ker

[PATCH] sched/deadline: fix one-bit signed bitfields to be unsigned

C bitfields for the state flags", 2017-10-10) Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> Cc: luca abeni <luca.ab...@santannapisa.it> Tested-by: Andrew Bowers <andrewx.bow...@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> --- include/li

[PATCH] sched/deadline: fix one-bit signed bitfields to be unsigned

quot;, 2017-10-10) Signed-off-by: Jacob Keller Cc: luca abeni Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- include/linux/sched.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index a5dc7c98b0a2..21991d668

[PATCH] Enable SR-IOV instantiation through /sys file

From: Liang-Min Wang When a SR-IOV supported device is bound with vfio-pci, the driver could not create SR-IOV instance through /sys/bus/pci/devices/... /sriov_numvfs. This patch re-activates this capability for a PCIe device that supports SR-IOV and is bound with

[PATCH] Enable SR-IOV instantiation through /sys file

From: Liang-Min Wang When a SR-IOV supported device is bound with vfio-pci, the driver could not create SR-IOV instance through /sys/bus/pci/devices/... /sriov_numvfs. This patch re-activates this capability for a PCIe device that supports SR-IOV and is bound with vfio-pci.ko. Signed-off-by:

Re: [PATCH, net-next] i40e: avoid 64-bit division where possible

On Tue, 2017-10-17 at 12:23 +0200, Arnd Bergmann wrote: > The new bandwidth calculation causes a link error on 32-bit > architectures, like > > ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/intel/i40e/i40e.ko] > undefined! > > The problem is the max_tx_rate calculation that uses 64-bit

Re: [PATCH, net-next] i40e: avoid 64-bit division where possible

On Tue, 2017-10-17 at 12:23 +0200, Arnd Bergmann wrote: > The new bandwidth calculation causes a link error on 32-bit > architectures, like > > ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/intel/i40e/i40e.ko] > undefined! > > The problem is the max_tx_rate calculation that uses 64-bit

Re: [PATCH] i40e/i40evf: actually use u32 for feature flags

On Wed, 2017-10-11 at 16:02 +0200, Arnd Bergmann wrote: > A previous cleanup intended to change the flags variable to 32 > bit instead of 64, but accidentally left out the important > part of that change, leading to a build error: > > drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function >

Re: [PATCH] i40e/i40evf: actually use u32 for feature flags

On Wed, 2017-10-11 at 16:02 +0200, Arnd Bergmann wrote: > A previous cleanup intended to change the flags variable to 32 > bit instead of 64, but accidentally left out the important > part of that change, leading to a build error: > > drivers/net/ethernet/intel/i40e/i40e_ethtool.o: In function >

[net 3/5] Revert commit 1a8b6d76dc5b ("net:add one common config...")

ixgbe drivers just like the commit 1a8b6d76dc5b ("net:add one common config...") did, so revert this commit. Signed-off-by: Ding Tianhong <dingtianh...@huawei.com> Tested-by: Andrew Bowers <andrewx.bow...@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirs.

[net 3/5] Revert commit 1a8b6d76dc5b ("net:add one common config...")

1a8b6d76dc5b ("net:add one common config...") did, so revert this commit. Signed-off-by: Ding Tianhong Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- arch/Kconfig| 3 --- arch/sparc/Kconfig | 1 - drivers/ne

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

> Cc: Doug Ledford <dledf...@redhat.com> > Cc: Sean Hefty <sean.he...@intel.com> > Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > Cc: Dmitry Torokhov <dmitry.torok...@gmail.com> > Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > Cc: linux...@vger

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

: Pavel Machek > Cc: Len Brown > Cc: Greg Kroah-Hartman > Cc: Mike Marciniszyn > Cc: Dennis Dalessandro > Cc: Doug Ledford > Cc: Sean Hefty > Cc: Hal Rosenstock > Cc: Dmitry Torokhov > Cc: Jeff Kirsher > Cc: linux...@vger.kernel.org > Cc: linux-r...@vge

Re: [PATCH] e1000: changed some expensive calls of udelay to usleep_range

On Tue, 2017-08-22 at 16:02 -0500, nxf23276 wrote: > Calls to udelay are not preemtable by userspace so userspace > applications experience a large (~200us) latency when running on > core > 0. Instead usleep_range can be used to be more friendly to > userspace > since it is

Re: [PATCH] e1000: changed some expensive calls of udelay to usleep_range

On Tue, 2017-08-22 at 16:02 -0500, nxf23276 wrote: > Calls to udelay are not preemtable by userspace so userspace > applications experience a large (~200us) latency when running on > core > 0. Instead usleep_range can be used to be more friendly to > userspace > since it is

Re: [PATCH v2] i40e/i40evf: use cpumask_copy() for assigning cpumask

On Wed, 2017-08-16 at 19:52 +0200, Juergen Gross wrote: > Using direct assignment for a cpumask is wrong, cpumask_copy() should > be used instead. > > Otherwise crashes like the following might happen: > > [62792.326374] BUG: unable to handle kernel paging request at > 8800049ff000 >

Re: [PATCH v2] i40e/i40evf: use cpumask_copy() for assigning cpumask

On Wed, 2017-08-16 at 19:52 +0200, Juergen Gross wrote: > Using direct assignment for a cpumask is wrong, cpumask_copy() should > be used instead. > > Otherwise crashes like the following might happen: > > [62792.326374] BUG: unable to handle kernel paging request at > 8800049ff000 >

Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

d outside of > > the #ifdef", but is used only a single time within the #ifdef in > > igb_resume(). Fix it by moving igb_deliver_wake_packet() next to > > igb_resume() inside the #ifdef. > > > > The diff ends up looking a bit funky here. It *looks* like > &g

Re: [PATCH] igb: fix unused igb_deliver_wake_packet() warning when CONFIG_PM=n

hin the #ifdef in > > igb_resume(). Fix it by moving igb_deliver_wake_packet() next to > > igb_resume() inside the #ifdef. > > > > The diff ends up looking a bit funky here. It *looks* like > > igb_suspend() is getting moved, but that's an artifact of how &

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

; > > >  ... > > > > > > The unwind failures stems from commit 2800209994f8 ("e1000e: > > > > > > Refactor PM > > > > > > flows"), but it may be a later patch that introduced the non- > > > > > > recoverable >

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote: > On 20 June 2017 at 18:49, Daniel Vetter wrote: > > On Wed, Jun 07, 2017 at 01:07:33AM +, Brown, Aaron F wrote: > > > > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] > > > >

Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote: > From: Andreas Werner > > Signed-off-by: Andreas Werner > --- >  drivers/net/ethernet/intel/igb/igb_main.c | 4 >  1 file changed, 4 insertions(+) NACK Why? Your lack of patch

Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver

On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote: > From: Andreas Werner > > Signed-off-by: Andreas Werner > --- >  drivers/net/ethernet/intel/igb/igb_main.c | 4 >  1 file changed, 4 insertions(+) NACK Why? Your lack of patch description does not provide a reasoning on why we need

Re: [net-intel-i40e] question about assignment overwrite

On Wed, 2017-06-07 at 16:55 -0300, Mauro Rodrigues wrote: > On Wed, May 17, 2017 at 10:49:11PM -0700, Jeff Kirsher wrote: > > On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > > > While looking into Coverity ID 1408956 I ran into the following > > > piece

Re: [net-intel-i40e] question about assignment overwrite

On Wed, 2017-06-07 at 16:55 -0300, Mauro Rodrigues wrote: > On Wed, May 17, 2017 at 10:49:11PM -0700, Jeff Kirsher wrote: > > On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > > > While looking into Coverity ID 1408956 I ran into the following > > > piece

Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

: 2800209994f8 ("e1000e: Refactor PM flows") > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 > > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > > Cc: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > > Cc: Dave Ertman <davidx.m.ert...@in

Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

... > > The unwind failures stems from commit 2800209994f8 ("e1000e: > > Refactor PM > > flows"), but it may be a later patch that introduced the non- > > recoverable > > behaviour. > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") &g

Re: [net-intel-i40e] question about assignment overwrite

On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > While looking into Coverity ID 1408956 I ran into the following > piece   > of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: > > 8807    if (pf->hw.mac.type == I40E_MAC_X722) { > 8808    pf->flags |=

Re: [net-intel-i40e] question about assignment overwrite

On Wed, 2017-05-17 at 15:48 -0500, Gustavo A. R. Silva wrote: > While looking into Coverity ID 1408956 I ran into the following > piece   > of code at drivers/net/ethernet/intel/i40e/i40e_main.c:8807: > > 8807    if (pf->hw.mac.type == I40E_MAC_X722) { > 8808    pf->flags |=

Re: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

On Tue, 2017-04-25 at 14:39 -0500, Bjorn Helgaas wrote: > On Mon, Apr 24, 2017 at 04:35:07PM +0200, Christoph Hellwig wrote: > > On Mon, Apr 24, 2017 at 02:16:31PM +, Byczkowski, Jakub wrote: > > > Tested-by: Jakub Byczkowski > > > > Are you (and Doug) ok with

Re: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

On Tue, 2017-04-25 at 14:39 -0500, Bjorn Helgaas wrote: > On Mon, Apr 24, 2017 at 04:35:07PM +0200, Christoph Hellwig wrote: > > On Mon, Apr 24, 2017 at 02:16:31PM +, Byczkowski, Jakub wrote: > > > Tested-by: Jakub Byczkowski > > > > Are you (and Doug) ok with queueing this up in the PCI

Re: [PATCH 4/7] ixgbe: use pcie_flr instead of duplicating it

On Thu, 2017-04-13 at 16:53 +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++-- >  1 file changed, 2 insertions(+), 14 deletions(-) Acked-by: Jeff Kirsher <jeffrey.t.kirs

Re: [PATCH 4/7] ixgbe: use pcie_flr instead of duplicating it

On Thu, 2017-04-13 at 16:53 +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++-- >  1 file changed, 2 insertions(+), 14 deletions(-) Acked-by: Jeff Kirsher Sorry for the late ACK. s

Re: [Intel-wired-lan] [BUG] 4.11.0-rc1 panic on shutdown X61s

On Wed, Mar 22, 2017 at 12:00 PM, Borislav Petkov <b...@alien8.de> wrote: > (Readding Jeff Kirsher who got dropped from the CC-list at some point.) > > On Tue, Mar 21, 2017 at 07:13:43PM -0700, l...@pengaru.com wrote: >> > This is still broken as of 4.11.0-rc3 FY

Re: [Intel-wired-lan] [BUG] 4.11.0-rc1 panic on shutdown X61s

On Wed, Mar 22, 2017 at 12:00 PM, Borislav Petkov wrote: > (Readding Jeff Kirsher who got dropped from the CC-list at some point.) > > On Tue, Mar 21, 2017 at 07:13:43PM -0700, l...@pengaru.com wrote: >> > This is still broken as of 4.11.0-rc3 FYI. >> > >>

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

na Tschudin <peter.se...@collabora.com> > Tested-by: Peter Senna Tschudin <peter.se...@collabora.com> > --- >  drivers/net/ethernet/intel/e100.c | 12 ++-- >  1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> My o

Re: [PATCH v5 04/19] net: e100: Replace PCI pool old API

ter Senna Tschudin > --- >  drivers/net/ethernet/intel/e100.c | 12 ++-- >  1 file changed, 6 insertions(+), 6 deletions(-) Acked-by: Jeff Kirsher My only concern is: - what hardware did this get tested with? Since this affects all e100 parts, it would be hard to believe that all the

Re: [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote: > Signed-off-by: Zhouyi Zhou > Reviewed-by: Cong Wang > Reviewed-by: Yuval Shaia   > Reviewed-by: Eric Dumazet > --- >  

Re: [PATCH 1/1] ixgbe: fcoe: return value of skb_linearize should be handled

On Wed, 2016-12-07 at 15:43 +0800, Zhouyi Zhou wrote: > Signed-off-by: Zhouyi Zhou > Reviewed-by: Cong Wang > Reviewed-by: Yuval Shaia   > Reviewed-by: Eric Dumazet > --- >  drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +- >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-- >  2

Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

On Fri, 2016-10-21 at 13:27 -0700, Jeff Kirsher wrote: > When users run checkpatch.pl with --no-tree option, $root is not > defined, which causes an ugly warning that it is not initialized at > line 764.  The test for whether or not a file is maintained should > only be run when a

Re: [PATCH] checkpatch: Fix warnings when --no-tree is used

On Fri, 2016-10-21 at 13:27 -0700, Jeff Kirsher wrote: > When users run checkpatch.pl with --no-tree option, $root is not > defined, which causes an ugly warning that it is not initialized at > line 764.  The test for whether or not a file is maintained should > only be run when a

Re: [PATCH] add one parameter wro_enable to enable relaxed ordering for IXGBE

On Sat, 2016-10-29 at 15:08 +0800, Mao Wenan wrote: > This patch provides a way to enable relaxed ordering, where it helps with > performance in some architecture. > The default value of wro_enable is 0, if you want to enable relaxed > ordering, please set wro_enable=1. > > Mao Wenan (1): >   add

Re: [PATCH] add one parameter wro_enable to enable relaxed ordering for IXGBE

On Sat, 2016-10-29 at 15:08 +0800, Mao Wenan wrote: > This patch provides a way to enable relaxed ordering, where it helps with > performance in some architecture. > The default value of wro_enable is 0, if you want to enable relaxed > ordering, please set wro_enable=1. > > Mao Wenan (1): >   add

Re: [Intel-wired-lan] [net-next PATCH 27/27] igb: Revert "igb: Revert support for build_skb in igb"

ort > full jumbo frames when using build_skb.  Instead we can only support up > to > 2K minus the skb overhead and padding offset. > > Signed-off-by: Alexander Duyck <alexander.h.du...@intel.com> Acked-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> signature.asc Description: This is a digitally signed message part

Re: [Intel-wired-lan] [net-next PATCH 27/27] igb: Revert "igb: Revert support for build_skb in igb"

ort > full jumbo frames when using build_skb.  Instead we can only support up > to > 2K minus the skb overhead and padding offset. > > Signed-off-by: Alexander Duyck Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

Re: [Intel-wired-lan] [net-next PATCH 25/27] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC

ates cache lines we were prefetching and then > invalidating the first 128 bytes of the packet.  To avoid that I have > moved > the sync up to before we perform the prefetch and allocate the skbuff so > that we can actually make use of it. > > Signed-off-by: Alexander Duyck <alexander.h.du

Re: [Intel-wired-lan] [net-next PATCH 25/27] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC

ates cache lines we were prefetching and then > invalidating the first 128 bytes of the packet.  To avoid that I have > moved > the sync up to before we perform the prefetch and allocate the skbuff so > that we can actually make use of it. > > Signed-off-by: Alexander Duyck >  Acked-by: Jeff

Re: [Intel-wired-lan] [net-next PATCH 26/27] igb: Update code to better handle incrementing page count

c operations and > this in turn should give us a slight improvement in cycles per packet.  > In > addition if we eventually move this over to using build_skb the gains > will > be more noticeable. > > Signed-off-by: Alexander Duyck <alexander.h.du...@intel.com> Acked-by: Je

Re: [Intel-wired-lan] [net-next PATCH 26/27] igb: Update code to better handle incrementing page count

c operations and > this in turn should give us a slight improvement in cycles per packet.  > In > addition if we eventually move this over to using build_skb the gains > will > be more noticeable. > > Signed-off-by: Alexander Duyck Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

[PATCH] checkpatch: Fix warnings when --no-tree is used

-off-by: Jeff Kirsher <jeffrey.t.kirs...@intel.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a8368d1..7a54978 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2352,7 +

[PATCH] checkpatch: Fix warnings when --no-tree is used

-off-by: Jeff Kirsher --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a8368d1..7a54978 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2352,7 +2352,7 @@ sub process

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [PATCH] ixgbe: mark symbols static where possible

On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no > previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] >

Re: [PATCH] ixgbe: mark symbols static where possible

On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no > previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes] >

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

On Sun, 2016-09-18 at 16:50 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static

On Sun, 2016-09-18 at 16:50 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous > prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes] > > In fact, this function is only used in

Re: [PATCH V2] git-send-email: Add ability to cc: any "bylines" in the commit message

be suppressed with --suppress-cc=bylines. > > Signed-off-by: Joe Perches <j...@perches.com> > --- >  Documentation/git-send-email.txt | 11 +++ >  git-send-email.perl  | 16 +++- >  2 files changed, 18 insertions(+), 9 deletions(-) Ac

Re: [PATCH V2] git-send-email: Add ability to cc: any "bylines" in the commit message

be suppressed with --suppress-cc=bylines. > > Signed-off-by: Joe Perches > --- >  Documentation/git-send-email.txt | 11 +++ >  git-send-email.perl  | 16 +++- >  2 files changed, 18 insertions(+), 9 deletions(-) Acked-by: Jeff Kirsher signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/1 v2] net: i10e: use matching format indentifiers

On Tue, 2016-08-02 at 20:15 +0200, Heinrich Schuchardt wrote: > i is defined as int but output as %u several times. > Adjust the format identifiers. > > v2: > Keep definition of i as int. > David indicated that this is the preferable way to define > loop variables. > >

Re: [PATCH 1/1 v2] net: i10e: use matching format indentifiers

On Tue, 2016-08-02 at 20:15 +0200, Heinrich Schuchardt wrote: > i is defined as int but output as %u several times. > Adjust the format identifiers. > > v2: > Keep definition of i as int. > David indicated that this is the preferable way to define > loop variables. > >

  1   2   3   4   5   6   7   >