--
Jeff Mahoney
SUSE Labs
On 3/23/19 11:56 AM, Eric W. Biederman wrote:
> Jeff Mahoney writes:
>
>> On 4/24/18 10:14 AM, Eric W. Biederman wrote:
>>> je...@suse.com writes:
>>>
>>>> From: Jeff Mahoney
>>>>
>>>> Hi all -
>>>>
>>>>
On 4/24/18 10:14 AM, Eric W. Biederman wrote:
> je...@suse.com writes:
>
>> From: Jeff Mahoney
>>
>> Hi all -
>>
>> I recently encountered a customer issue where, on a machine with many TiB
>> of memory and a few hundred cores, after a task with a few
ck
> -# pointer out of the available stack space, corrupting kernel space,
> -# and causing a panic. Since this behavior only affects ppc32, this ifeq
> -# will work around it. If any other architecture displays this behavior,
> -# add it here.
> -ccflags-$(CONFIG_PPC32) := $(call cc-ifve
ck
> -# pointer out of the available stack space, corrupting kernel space,
> -# and causing a panic. Since this behavior only affects ppc32, this ifeq
> -# will work around it. If any other architecture displays this behavior,
> -# add it here.
> -ccflags-$(CONFIG_PPC32) := $(call cc-ifve
ilinglist, so I guess it probably has to go through either Al Viro's
>>> or akpm's tree? Looks like akpm signed off on the last commits in
>>> reiserfs...
>>
>> I think Andrew's tree makes the most sense for this,
>
> Yeah, Andrew has already merged it. :)
> http:
n't happen anymore.
>
> Credit for making me clean this code up a bit goes to Al Viro, who pointed
> out that the ->actor calling convention is suboptimal and should be
> changed.
>
> Fixes: 48b32a3553a5 ("reiserfs: use generic xattr handlers")
> Cc: sta...@vger.
ilinglist, so I guess it probably has to go through either Al Viro's
>>> or akpm's tree? Looks like akpm signed off on the last commits in
>>> reiserfs...
>>
>> I think Andrew's tree makes the most sense for this,
>
> Yeah, Andrew has already merged it. :)
> http:
n't happen anymore.
>
> Credit for making me clean this code up a bit goes to Al Viro, who pointed
> out that the ->actor calling convention is suboptimal and should be
> changed.
>
> Fixes: 48b32a3553a5 ("reiserfs: use generic xattr handlers")
> Cc: sta...@vger.
ds
of superblocks to do what a single lock does now and for what benefit?
>> It's far more efficient then to pull those fields we need for a
>> subvolume namespace into their own structure.
>
> I'm not convinced yet - it still feels like it's the wrong layer to
> be solving the multiple namespace per superblock problem
It needs to be between the inode and the superblock. If there are
multiple user-visible namespaces, each will still get the same
underlying file system namespace.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
ds
of superblocks to do what a single lock does now and for what benefit?
>> It's far more efficient then to pull those fields we need for a
>> subvolume namespace into their own structure.
>
> I'm not convinced yet - it still feels like it's the wrong layer to
> be solving the multiple namespace per superblock problem
It needs to be between the inode and the superblock. If there are
multiple user-visible namespaces, each will still get the same
underlying file system namespace.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
On 4/24/18 10:14 AM, Eric W. Biederman wrote:
> je...@suse.com writes:
>
>> From: Jeff Mahoney <je...@suse.com>
>>
>> Hi all -
>>
>> I recently encountered a customer issue where, on a machine with many TiB
>> of memory and a few hundred
On 4/24/18 10:14 AM, Eric W. Biederman wrote:
> je...@suse.com writes:
>
>> From: Jeff Mahoney
>>
>> Hi all -
>>
>> I recently encountered a customer issue where, on a machine with many TiB
>> of memory and a few hundred cores, after a task with a few
id_files_revalidate only needs to check if the tasks share files
since it won't be called if it's not a symlink.
Thanks for the review,
-Jeff
--
Jeff Mahoney
SUSE Labs
id_files_revalidate only needs to check if the tasks share files
since it won't be called if it's not a symlink.
Thanks for the review,
-Jeff
--
Jeff Mahoney
SUSE Labs
t(ap, dummy);
> for (i = 0; i < 5; ++i) {
> vprintf("%d\n", ap);
> printf("%d\n", va_arg(ap, int));
> }
> va_end(ap);
> }
>
> int main(int argc, char *argv[])
> {
> f("bla", 1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
> return 0;
> }
>
> Compiling for native (x86-64), this produces $(seq 10). But with -m32,
> one gets 1,1,2,2,3,3,4,4,5,5.
>
> Assuming reiserfs (at least its debugging infrastructure) isn't broken
> on a bunch of architectures, I'm obviously missing something
> fundamental. Please enlighten me.
>
> Rasmus
>
--
Jeff Mahoney
SUSE Labs
vprintf("%d\n", ap);
> printf("%d\n", va_arg(ap, int));
> }
> va_end(ap);
> }
>
> int main(int argc, char *argv[])
> {
> f("bla", 1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
> return 0;
> }
>
> Compiling for native (x86-64), this produces $(seq 10). But with -m32,
> one gets 1,1,2,2,3,3,4,4,5,5.
>
> Assuming reiserfs (at least its debugging infrastructure) isn't broken
> on a bunch of architectures, I'm obviously missing something
> fundamental. Please enlighten me.
>
> Rasmus
>
--
Jeff Mahoney
SUSE Labs
rnal device name as
>> "%/file0".)
>>
>
> Well, that is a valid filename and we should support it...
>
> Isn't the bug in journal_init_dev()?
Yep. That's exactly it.
Acked-by: Jeff Mahoney <je...@suse.com>
Thanks,
-Jeff
> --- a/fs/reiserfs/journal.c~a
>
> Well, that is a valid filename and we should support it...
>
> Isn't the bug in journal_init_dev()?
Yep. That's exactly it.
Acked-by: Jeff Mahoney
Thanks,
-Jeff
> --- a/fs/reiserfs/journal.c~a
> +++ a/fs/reiserfs/journal.c
> @@ -2643,7 +2643,7 @@ static int jour
. It needs
and this fix works because Luis added it to the HAVE_GDBM_H stanza.
3) AC_PACKAGE_WANT_NDBM used to check for but it was a check
for IRIX and the caller was removed ages ago. It wouldn't matter if it
were called anyway since libndbm is an IRIX library. Linux, IIRC, has
never shipped a lib
s because Luis added it to the HAVE_GDBM_H stanza.
3) AC_PACKAGE_WANT_NDBM used to check for but it was a check
for IRIX and the caller was removed ages ago. It wouldn't matter if it
were called anyway since libndbm is an IRIX library. Linux, IIRC, has
never shipped a libndbm.
I'll post a few patc
just work.
We do. We did then too. But what doesn't work is a user doing stat()
and then using the dev_t to call ustat().
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
just work.
We do. We did then too. But what doesn't work is a user doing stat()
and then using the dev_t to call ustat().
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
ptr = btrfs_item_ptr_offset(l, slot);
> @@ -204,6 +196,9 @@ int btrfs_update_root(struct btrfs_trans_handle *trans,
> struct btrfs_root
> out:
> btrfs_free_path(path);
> return ret;
> +abort_transaction:
> + btrfs_abort_transaction(trans, ret);
> + goto out;
> }
>
> int btrfs_insert_root(struct btrfs_trans_handle *trans, struct btrfs_root
> *root,
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
root(struct btrfs_trans_handle *trans,
> struct btrfs_root
> out:
> btrfs_free_path(path);
> return ret;
> +abort_transaction:
> + btrfs_abort_transaction(trans, ret);
> + goto out;
> }
>
> int btrfs_insert_root(struct btrfs_trans_handle *trans, struct btrfs_root
> *root,
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
o free_path;
> +
> ret = fs_path_add(new_path, ref->name, ref->name_len);
> if (ret < 0) {
> +free_path:
> fs_path_free(new_path);
> return ret;
> }
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
->name_len);
> if (ret < 0) {
> +free_path:
> fs_path_free(new_path);
> return ret;
> }
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
if (ret)
> + goto abort_transaction;
>
> ret = update_block_group(trans, info, bytenr, num_bytes, 0);
> - if (ret) {
> - btrfs_abort_transaction(trans, ret);
> - goto out;
> - }
> + if (ret)
> + goto abort_transaction;
> }
> btrfs_release_path(path);
>
> out:
> btrfs_free_path(path);
> return ret;
> +abort_transaction:
> + btrfs_abort_transaction(trans, ret);
> + goto out;
> }
>
> /*
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
> ret = add_to_free_space_tree(trans, info, bytenr, num_bytes);
> - if (ret) {
> - btrfs_abort_transaction(trans, ret);
> - goto out;
> - }
> + if (ret)
> + goto abort_transaction;
>
>
uffer_dirty(leaf);
>
> ret = btrfs_del_items(trans, root, path, del_slot, del_nr);
> - if (ret < 0) {
> - btrfs_abort_transaction(trans, ret);
> - goto out;
> - }
> + if (ret < 0)
> + goto abort_transaction;
> }
> out:
> btrfs_free_path(path);
> return 0;
> +e_inval:
> + ret = -EINVAL;
> +abort_transaction:
> + btrfs_abort_transaction(trans, ret);
> + goto out;
> }
>
> /*
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
, path, del_slot, del_nr);
> - if (ret < 0) {
> - btrfs_abort_transaction(trans, ret);
> - goto out;
> - }
> + if (ret < 0)
> + goto abort_transaction;
> }
> out:
> btrfs_free_path(path);
> return 0;
> +e_inval:
> + ret = -EINVAL;
> +abort_transaction:
> + btrfs_abort_transaction(trans, ret);
> + goto out;
> }
>
> /*
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
it. It's that this part of allocation seems to be a
collection of bugs that approximate a correct result, and we're
addressing them individually. This patch by itself is correct but
uncovered a couple of underlying issues.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
it. It's that this part of allocation seems to be a
collection of bugs that approximate a correct result, and we're
addressing them individually. This patch by itself is correct but
uncovered a couple of underlying issues.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
reiserfs_write_lock(s);
> if (!journal_begin(, s, 1))
> if (!journal_end_sync())
> reiserfs_flush_old_commits(s);
> reiserfs_write_unlock(s);
> +
> + if ( got_lock )
> + up_read(>s_umount);
> +
> return 0;
> }
Please follow the surrounding style. Spaces within the conditional are
not part of the accepted style[1].
-Jeff
[1]
https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
rect. There may be other threads executing with s->s_umount held as
writers
and this patch means that this would execute concurrently, which is incorrect.
> dquot_writeback_dquots(s, -1);
> reiserfs_write_lock(s);
> if (!journal_begin(, s, 1))
> if (!journal_
ect_add
until we can use GFP_KERNEL.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
ect_add
until we can use GFP_KERNEL.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
"in progress";
> default:
> - return NULL;
> + return 0;
> }
> }
>
>
Hi Dmitry -
Just remove the whole routine. It's not called from anywhere and is
replicated in the userspace headers for btrfsprogs.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
uot;in progress";
> default:
> - return NULL;
> + return 0;
> }
> }
>
>
Hi Dmitry -
Just remove the whole routine. It's not called from anywhere and is
replicated in the userspace headers for btrfsprogs.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
e how it could happen.
I got a minute to look at this today. It doesn't fallback to the normal
ioctl handler. Since we have ->unlocked_ioctl defined, it checks the
hard-coded compat tables and then fails with -ENOTTY.
Fortunately, the fix is simple. The default stanza of that switch
statement in btrfs_compat_ioctl needs to be removed. Then it just
works. I'll post a fix momentarily.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
d happen.
I got a minute to look at this today. It doesn't fallback to the normal
ioctl handler. Since we have ->unlocked_ioctl defined, it checks the
hard-coded compat tables and then fails with -ENOTTY.
Fortunately, the fix is simple. The default stanza of that switch
statement in btrfs_compat_ioctl needs to be removed. Then it just
works. I'll post a fix momentarily.
-Jeff
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
failures for docs:
make[2]: *** No rule to make target 'Documentation/DocBook/80211.xml', needed
by 'Documentation/DocBook/80211.9'. Stop.
This patch re-removes the 80211 rule.
Fixes: 726d661fea3 (Merge remote-tracking branch 'sound/topic/restize-docs'
into sound)
Signed-off-by: Jeff Mahoney <
failures for docs:
make[2]: *** No rule to make target 'Documentation/DocBook/80211.xml', needed
by 'Documentation/DocBook/80211.9'. Stop.
This patch re-removes the 80211 rule.
Fixes: 726d661fea3 (Merge remote-tracking branch 'sound/topic/restize-docs'
into sound)
Signed-off-by: Jeff Mahoney
; struct btrfs_root *root = BTRFS_I(dir)->root;
> struct btrfs_inode_ref *iref;
> @@ -241,6 +241,7 @@ static int btrfs_get_name(struct dentry *parent, char
> *name,
> if (!S_ISDIR(dir->i_mode))
> return -EINVAL;
>
> + fs_info = btrfs_sb(ino
struct btrfs_inode_ref *iref;
> @@ -241,6 +241,7 @@ static int btrfs_get_name(struct dentry *parent, char
> *name,
> if (!S_ISDIR(dir->i_mode))
> return -EINVAL;
>
> + fs_info = btrfs_sb(inode->i_sb);
> ino = btrfs_ino(inode);
>
> path = btrfs_alloc_path();
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
Whoops, the [PATCH] line should've specified more clearly: This only
applies to linux-stable, 3.12.y.
Sorry for any confusion.
-Jeff
On 12/2/16 10:21 PM, Jeff Mahoney wrote:
> This reverts commit 644d10716875b24388680925d6c7502420987bfe.
>
> The original patch for mainline, 6f8960541
Whoops, the [PATCH] line should've specified more clearly: This only
applies to linux-stable, 3.12.y.
Sorry for any confusion.
-Jeff
On 12/2/16 10:21 PM, Jeff Mahoney wrote:
> This reverts commit 644d10716875b24388680925d6c7502420987bfe.
>
> The original patch for mainline, 6f8960541
, when it is not.
Signed-off-by: Jeff Mahoney <je...@suse.com>
---
fs/btrfs/delayed-inode.c | 8
1 file changed, 8 deletions(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 34f33e1..269ac79 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-i
, when it is not.
Signed-off-by: Jeff Mahoney
---
fs/btrfs/delayed-inode.c | 8
1 file changed, 8 deletions(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 34f33e1..269ac79 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -1805,14 +1805,6
> sa = memdup_user(arg, sizeof(*sa));
> - if (IS_ERR(sa)) {
> - ret = PTR_ERR(sa);
> - sa = NULL;
> - goto out;
> - }
> + if (IS_ERR(sa))
> + return PTR_ERR(sa);
>
> ret = _btrfs_ioctl_set_received_subvol(file, sa);
>
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
a)) {
> - ret = PTR_ERR(sa);
> - sa = NULL;
> - goto out;
> - }
> + if (IS_ERR(sa))
> + return PTR_ERR(sa);
>
> ret = _btrfs_ioctl_set_received_subvol(file, sa);
>
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
On 9/10/16 11:58 AM, Sean Fu wrote:
> On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote:
>> On 9/8/16 11:08 PM, Sean Fu wrote:
>>> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote:
>>>> On 9/6/16 5:58 AM, David Sterba wrote:
>>>>
On 9/10/16 11:58 AM, Sean Fu wrote:
> On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote:
>> On 9/8/16 11:08 PM, Sean Fu wrote:
>>> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote:
>>>> On 9/6/16 5:58 AM, David Sterba wrote:
>>>>
On 9/8/16 11:08 PM, Sean Fu wrote:
> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote:
>> On 9/6/16 5:58 AM, David Sterba wrote:
>>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote:
>>>>>> Since root is only used to get fs_i
On 9/8/16 11:08 PM, Sean Fu wrote:
> On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote:
>> On 9/6/16 5:58 AM, David Sterba wrote:
>>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote:
>>>>>> Since root is only used to get fs_i
On 9/6/16 5:58 AM, David Sterba wrote:
> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote:
>>>> Since root is only used to get fs_info->chunk_root, why not use fs_info
>>>> directly?
>>>
>>> Weird. Exactly this was a part of my
On 9/6/16 5:58 AM, David Sterba wrote:
> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote:
>>>> Since root is only used to get fs_info->chunk_root, why not use fs_info
>>>> directly?
>>>
>>> Weird. Exactly this was a part of my
On 9/5/16 11:05 PM, Jeff Mahoney wrote:
> On 9/5/16 3:56 AM, Qu Wenruo wrote:
>>
>>
>> At 09/05/2016 09:19 AM, Zhao Lei wrote:
>>> Hi, Sean Fu
>>>
>>>> From: Sean Fu [mailto:fxinr...@gmail.com]
>>>> Sent: Sunday, September 04, 2016
On 9/5/16 11:05 PM, Jeff Mahoney wrote:
> On 9/5/16 3:56 AM, Qu Wenruo wrote:
>>
>>
>> At 09/05/2016 09:19 AM, Zhao Lei wrote:
>>> Hi, Sean Fu
>>>
>>>> From: Sean Fu [mailto:fxinr...@gmail.com]
>>>> Sent: Sunday, September 04, 2016
->fs_info->chunk_root;
>>> -
>>> path = btrfs_alloc_path();
>>> if (!path)
>>> return -ENOMEM;
>>> --
>>> 2.6.2
>>>
>>
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
path = btrfs_alloc_path();
>>> if (!path)
>>> return -ENOMEM;
>>> --
>>> 2.6.2
>>>
>>
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Jeff Mahoney
SUSE Labs
signature.asc
Description: OpenPGP digital signature
oing the lloop
> driver anyways. Just need to find the cycles.
I guess my memory was flakey and I was recalling the first comments in
LU-4000. The updated version should be ok.
-Jeff
>> --
>> Jeff Mahoney
>> (apologies for the top post -- from my mobile)
>>
&g
oing the lloop
> driver anyways. Just need to find the cycles.
I guess my memory was flakey and I was recalling the first comments in
LU-4000. The updated version should be ok.
-Jeff
>> --
>> Jeff Mahoney
>> (apologies for the top post -- from my mobile)
>>
&g
This patch was shown not to work. I just haven't removed it from opensuse yet.
-Jeff
--
Jeff Mahoney
(apologies for the top post -- from my mobile)
> On Apr 10, 2016, at 9:13 AM, James Simmons <jsimm...@infradead.org> wrote:
>
> From: Jeff Mahoney <je...@suse.com>
>
&
This patch was shown not to work. I just haven't removed it from opensuse yet.
-Jeff
--
Jeff Mahoney
(apologies for the top post -- from my mobile)
> On Apr 10, 2016, at 9:13 AM, James Simmons wrote:
>
> From: Jeff Mahoney
>
> On ppc64 with 64k pages, we get a build f
On 3/3/16 6:40 AM, Kieran Bingham wrote:
> Facilitate linked-list items by providing a generator to return
> the dereferenced, and type-cast objects from a kernel linked list
>
> CC: Jeff Mahoney <je...@suse.com>
>
> Signed-off-by: Kieran Bingham <kieran.bing...@linaro
On 3/3/16 6:40 AM, Kieran Bingham wrote:
> Facilitate linked-list items by providing a generator to return
> the dereferenced, and type-cast objects from a kernel linked list
>
> CC: Jeff Mahoney
>
> Signed-off-by: Kieran Bingham
> ---
> Changes since v1:
>
On Oct 25, 2015, at 3:50 PM, Alexandru Moise <00moses.alexande...@gmail.com>
wrote:
>>> This allows us to trim out half of btrfs_init_delayed_node() which
>>> is now reduntant.
>>
>> It's redundant if kmem_cache_zalloc is used, but you haven't
>> documented that doing so is now required. For
+126,7 @@ again: if (node) return node;
>
> - node = kmem_cache_alloc(delayed_node_cache, GFP_NOFS); +node =
> kmem_cache_zalloc(delayed_node_cache, GFP_NOFS); if (!node) return
> ERR_PTR(-ENOMEM); btrfs_init_delayed_node(node, root, ino);
>
- --
Jeff Mahoney
SUSE Labs
-BEGIN
On Oct 25, 2015, at 3:50 PM, Alexandru Moise <00moses.alexande...@gmail.com>
wrote:
>>> This allows us to trim out half of btrfs_init_delayed_node() which
>>> is now reduntant.
>>
>> It's redundant if kmem_cache_zalloc is used, but you haven't
>> documented that doing so is now required. For
+126,7 @@ again: if (node) return node;
>
> - node = kmem_cache_alloc(delayed_node_cache, GFP_NOFS); +node =
> kmem_cache_zalloc(delayed_node_cache, GFP_NOFS); if (!node) return
> ERR_PTR(-ENOMEM); btrfs_init_delayed_node(node, root, ino);
>
- --
Jeff Mahoney
SUSE Labs
-BEGIN
e ago. But I'm satisfied; we do use
> CONFIG_EXT4_USE_FOR_EXT23 in RHEL7, and we wouldn't do that if it
> might change disk format behind our users' backs.
As a "me too" datapoint, we do the same thing with SLE12.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-BEGIN PGP SIGNA
tink about
> that quite a while ago. But I'm satisfied; we do use
> CONFIG_EXT4_USE_FOR_EXT23 in RHEL7, and we wouldn't do that if it
> might change disk format behind our users' backs.
As a "me too" datapoint, we do the same thing with SLE12.
- -Jeff
- --
Jeff
;reiserfs: rework
> reiserfs_panic") removed a "reiserfs[%i]" prefix.
>
> This bug is only triggered when using CONFIG_REISERFS_CHECK,
> otherwise __RASSERT is never used.
>
> Signed-off-by: Nicolas Iooss
Acked-by: Jeff Mahoney
> Fixes: c3a9c2109f84 ("reiserfs: rew
) removed a reiserfs[%i] prefix.
This bug is only triggered when using CONFIG_REISERFS_CHECK,
otherwise __RASSERT is never used.
Signed-off-by: Nicolas Iooss nicolas.iooss_li...@m4x.org
Acked-by: Jeff Mahoney je...@suse.com
Fixes: c3a9c2109f84 (reiserfs: rework reiserfs_panic) ---
fs
rfs_error. Unfortunately, it also enables some
heavy checks that make the file system very slow.
Thanks for looking into this. It looks like it's been broken for a
while. I suppose the only saving grace is that it would crash in a
path that crashes on purpose a f
that crashes on purpose a few lines later.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)
iQIcBAEBAgAGBQJVBtUEAAoJEB57S2MheeWysH4P/RBggjHOwREYHiq2RaY8H+sf
rSRaqf14xePP7vcWOvcQRkzjB2f6wnvD40i7j0vLqP5A6mjp+tdrSgl7P1KqGGBV
the old
> interface. Update them.
>
> This bug was initially found by adding __printf(4, 5) attribute to
> __reiserfs_warning and using "gcc -Wformat=2" when building the
> kernel.
>
> Fixes: 45b03d5e8e67 ("reiserfs: rework reiserfs_warning")
> Signed-of
them.
This bug was initially found by adding __printf(4, 5) attribute to
__reiserfs_warning and using gcc -Wformat=2 when building the
kernel.
Fixes: 45b03d5e8e67 (reiserfs: rework reiserfs_warning)
Signed-off-by: Nicolas Iooss nicolas.iooss_li...@m4x.org
Acked-by: Jeff Mahoney je
this by default, so it's failing the kernel build entirely.
Switching the declaration from uint64_t to time_t does the right thing
and handles the x32 case automatically.
Signed-off-by: Jeff Mahoney
---
Documentation/vDSO/vdso_standalone_test_x86.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
this by default, so it's failing the kernel build entirely.
Switching the declaration from uint64_t to time_t does the right thing
and handles the x32 case automatically.
Signed-off-by: Jeff Mahoney je...@suse.com
---
Documentation/vDSO/vdso_standalone_test_x86.c |2 +-
1 file changed, 1 insertion
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/9/14, 12:13 PM, Ming Lei wrote:
> On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei
> wrote:
>> On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney
>> wrote:
>>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1
>>>
>&
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/9/14, 9:53 AM, Jeff Moyer wrote:
> Jeff Mahoney writes:
>
>> Commit 05f1dd53152173 (block: add queue flag for disabling SG
>> merging) uses bi_vcnt to assign bio->bi_phys_segments if sg
>> merging is disabled. When
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/9/14, 9:53 AM, Jeff Moyer wrote:
Jeff Mahoney je...@suse.com writes:
Commit 05f1dd53152173 (block: add queue flag for disabling SG
merging) uses bi_vcnt to assign bio-bi_phys_segments if sg
merging is disabled. When using device mapper
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 10/9/14, 12:13 PM, Ming Lei wrote:
On Thu, Oct 9, 2014 at 11:25 PM, Ming Lei ming@canonical.com
wrote:
On Thu, Oct 9, 2014 at 10:26 PM, Jeff Mahoney je...@suse.com
wrote:
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1
On 10/9/14, 9:53 AM
t http://bugzilla.opensuse.org/show_bug.cgi?id=888259
Reported-by: Stephen Kulow
Signed-off-by: Jeff Mahoney
---
block/bio.c |1 +
1 file changed, 1 insertion(+)
--- a/block/bio.c
+++ b/block/bio.c
@@ -564,6 +564,7 @@ void __bio_clone_fast(struct bio *bio, s
bio->bi_rw = bio_s
://bugzilla.opensuse.org/show_bug.cgi?id=888259
Reported-by: Stephen Kulow co...@suse.com
Signed-off-by: Jeff Mahoney je...@suse.com
---
block/bio.c |1 +
1 file changed, 1 insertion(+)
--- a/block/bio.c
+++ b/block/bio.c
@@ -564,6 +564,7 @@ void __bio_clone_fast(struct bio *bio, s
bio-bi_rw
;>>>>>
>>>>>>> please consider adding the following 2 patches to
>>>>>>> 3.16.2:
>>>>>>>
>>>>>>> Jan Kara (1): reiserfs: Fix use after free in journal
>>>>>>> teardown
>&
in journal
teardown
Jeff Mahoney (1): reiserfs: fix corruption introduced
by balance_leaf refactor
Reason/Related:
https://bugzilla.kernel.org/show_bug.cgi?id=83121
https://bugzilla.kernel.org/show_bug.cgi?id=83321
http://forums.gentoo.org/viewtopic-t-998538-postdays-0-postorder-asc
On Fri Aug 22 19:34:12 2014, Randy Dunlap wrote:
> On 08/22/14 10:04, Jeff Mahoney wrote:
>> On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote:
>>> We should not select SPI bus when sub-driver auto-select is
>>> selected. That option is meant for auto-selecting all pos
ncies itself.
>
> I2C and I2C_MUX are still selected here for a reason described on
> commit 347f7a3763601d7b466898d1f10080b7083ac4a3
>
> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a
>
> Reported-by: Jeff Mahoney
> Signed-off-by: Antti Palosaari
> ---
> driver
On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote:
> Moikka!
>
> On 08/22/2014 06:00 PM, Jeff Mahoney wrote:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> Hi Antti -
>>
>> Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus
?
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)
iQIcBAEBAgAGBQJT91smAAoJEB57S2MheeWytcQP/jVJNWUWQ414XaltxVyAF8XT
kyCCEXl/MslN8W36p6oMC6TX7KaXjQQSFVUltyt/UgcezuqhkU8nBUETEgLVou1n
1uF120zBu3gy3Hr+dG/3Awsdqb1UbrUrNM2LRL6sU5GIqYSdTxErL8inzXjj6
On Fri Aug 22 19:34:12 2014, Randy Dunlap wrote:
On 08/22/14 10:04, Jeff Mahoney wrote:
On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote:
We should not select SPI bus when sub-driver auto-select is
selected. That option is meant for auto-selecting all possible
ancillary drivers used
?
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)
iQIcBAEBAgAGBQJT91smAAoJEB57S2MheeWytcQP/jVJNWUWQ414XaltxVyAF8XT
kyCCEXl/MslN8W36p6oMC6TX7KaXjQQSFVUltyt/UgcezuqhkU8nBUETEgLVou1n
1uF120zBu3gy3Hr+dG/3Awsdqb1UbrUrNM2LRL6sU5GIqYSdTxErL8inzXjj6
On Fri Aug 22 11:17:22 2014, Antti Palosaari wrote:
Moikka!
On 08/22/2014 06:00 PM, Jeff Mahoney wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Antti -
Commit e4462ffc160 ([media] Kconfig: sub-driver auto-select SPI bus)
enables CONFIG_SPI globally for a driver that won't even
and I2C_MUX are still selected here for a reason described on
commit 347f7a3763601d7b466898d1f10080b7083ac4a3
Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a
Reported-by: Jeff Mahoney je...@suse.com
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/media/Kconfig | 1 -
1 file
The rtsx_usb driver contains the table for the devices it supports but
doesn't export it. As a result, no alias is generated and it doesn't
get loaded automatically.
Via https://bugzilla.novell.com/show_bug.cgi?id=890096
Reported-by: Marcel Witte
Signed-off-by: Jeff Mahoney
---
drivers/mfd
, rtsx_usb_usb_ids);
static struct usb_driver rtsx_usb_driver = {
.name = rtsx_usb,
--
Jeff Mahoney
SUSE Labs
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
fer w/o a lock. I
must've forgotten a 'quilt add' when adding that chunk to the newer
patch. I'll review what else, if anything, might've changed but for
now, that should be be s/format_bh(tb->S_new[i])/tb->S_new[i]/.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-BEGIN PGP SIGNATURE-
V
1 - 100 of 301 matches
Mail list logo
