Re: [PATCH v10 1/3] gpio: dwapb: remove name from dwapb_port_property

在 4/29/2016 5:22 PM, Linus Walleij 写道: > On Thu, Apr 28, 2016 at 11:32 AM, Jiang Qiu <qiuji...@huawei.com> wrote: > >> This patch removed the name property from dwapb_port_property. >> The name property is redundant, since we can get this info >> from dwapb_gpio dev

Re: [PATCH v10 1/3] gpio: dwapb: remove name from dwapb_port_property

在 4/29/2016 5:22 PM, Linus Walleij 写道: > On Thu, Apr 28, 2016 at 11:32 AM, Jiang Qiu wrote: > >> This patch removed the name property from dwapb_port_property. >> The name property is redundant, since we can get this info >> from dwapb_gpio dev node. >> >> Rev

[PATCH v10 3/3] gpio: dwapb: add gpio-signaled acpi event support

PullUp, , " \\_SB.GPI0") {8} }) Method (_E08, 0x0, NotSerialized) { Notify (\_SB.PWRB, 0x80) } } Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <q

[PATCH v10 3/3] gpio: dwapb: add gpio-signaled acpi event support

PullUp, , " \\_SB.GPI0") {8} }) Method (_E08, 0x0, NotSerialized) { Notify (\_SB.PWRB, 0x80) } } Acked-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c | 17 + 1 file changed, 17 insertions(+)

[PATCH v10 2/3] gpio: dwapb: convert device node to fwnode

This patch converts device node to fwnode for dwapb driver, so as to provide a unified fwnode for DT and ACPI bindings. Tested-by: Alan Tull <delicious.qui...@gmail.com> Acked-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> ---

[PATCH v10 2/3] gpio: dwapb: convert device node to fwnode

This patch converts device node to fwnode for dwapb driver, so as to provide a unified fwnode for DT and ACPI bindings. Tested-by: Alan Tull Acked-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c| 36 +++- drivers/mfd

[PATCH v10 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

n Changes v2 -> v3: - fixed the build error reported by Kbuild test robot Changes v1 -> v2: - rebase to branch "devel" of Linus Walleij's repository - split in two patch as suggested by Andy S - add Mika's ACKs Jiang Qiu (3): gpio: dwapb: remove name from dwapb_p

[PATCH v10 1/3] gpio: dwapb: remove name from dwapb_port_property

This patch removed the name property from dwapb_port_property. The name property is redundant, since we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> --- drivers/gpio/

[PATCH v10 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

n Changes v2 -> v3: - fixed the build error reported by Kbuild test robot Changes v1 -> v2: - rebase to branch "devel" of Linus Walleij's repository - split in two patch as suggested by Andy S - add Mika's ACKs Jiang Qiu (3): gpio: dwapb: remove name from dwapb_p

[PATCH v10 1/3] gpio: dwapb: remove name from dwapb_port_property

This patch removed the name property from dwapb_port_property. The name property is redundant, since we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c| 24 +++- drivers/mfd

Re: [PATCH v9 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

在 2016/4/21 0:10, Alan Tull 写道: > On Wed, Apr 20, 2016 at 8:06 AM, Andy Shevchenko > <andy.shevche...@gmail.com> wrote: >> On Wed, Apr 20, 2016 at 10:13 AM, Jiang Qiu <qiuji...@huawei.com> wrote: >>> This patchset adds gpio-signaled acpi events support for power

Re: [PATCH v9 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

在 2016/4/21 0:10, Alan Tull 写道: > On Wed, Apr 20, 2016 at 8:06 AM, Andy Shevchenko > wrote: >> On Wed, Apr 20, 2016 at 10:13 AM, Jiang Qiu wrote: >>> This patchset adds gpio-signaled acpi events support for power button on >>> hisilicon >>> D02 board.

Re: [PATCH v9 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

在 2016/4/20 21:06, Andy Shevchenko 写道: > On Wed, Apr 20, 2016 at 10:13 AM, Jiang Qiu <qiuji...@huawei.com> wrote: >> This patchset adds gpio-signaled acpi events support for power button on >> hisilicon >> D02 board. >> >> The three patches resp

Re: [PATCH v9 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

在 2016/4/20 21:06, Andy Shevchenko 写道: > On Wed, Apr 20, 2016 at 10:13 AM, Jiang Qiu wrote: >> This patchset adds gpio-signaled acpi events support for power button on >> hisilicon >> D02 board. >> >> The three patches respectively: >>

Re: [PATCH v9 2/3] gpio: dwapb: convert device node to fwnode

在 2016/4/20 21:04, Andy Shevchenko 写道: > On Wed, Apr 20, 2016 at 10:13 AM, Jiang Qiu <qiuji...@huawei.com> wrote: >> This patch converts device node to fwnode for dwapb driver, so >> as to provide a unified fwnode for DT and ACPI bindings. >> >> Tested-by: Alan

Re: [PATCH v9 2/3] gpio: dwapb: convert device node to fwnode

在 2016/4/20 21:04, Andy Shevchenko 写道: > On Wed, Apr 20, 2016 at 10:13 AM, Jiang Qiu wrote: >> This patch converts device node to fwnode for dwapb driver, so >> as to provide a unified fwnode for DT and ACPI bindings. >> >> Tested-by: Alan Tull >> Acked-b

[PATCH v9 3/3] gpio: dwapb: add gpio-signaled acpi event support

PullUp, , " \\_SB.GPI0") {8} }) Method (_E08, 0x0, NotSerialized) { Notify (\_SB.PWRB, 0x80) } } Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <q

[PATCH v9 2/3] gpio: dwapb: convert device node to fwnode

This patch converts device node to fwnode for dwapb driver, so as to provide a unified fwnode for DT and ACPI bindings. Tested-by: Alan Tull <delicious.qui...@gmail.com> Acked-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> ---

[PATCH v9 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

d error reported by Kbuild test robot Changes v1 -> v2: - rebase to branch "devel" of Linus Walleij's repository - split in two patch as suggested by Andy S - add Mika's ACKs Jiang Qiu (3): gpio: dwapb: remove name from dwapb_port_property gpio: dwapb: convert device nod

[PATCH v9 3/3] gpio: dwapb: add gpio-signaled acpi event support

PullUp, , " \\_SB.GPI0") {8} }) Method (_E08, 0x0, NotSerialized) { Notify (\_SB.PWRB, 0x80) } } Acked-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c | 17 + 1 file changed, 17 insertions(+)

[PATCH v9 2/3] gpio: dwapb: convert device node to fwnode

This patch converts device node to fwnode for dwapb driver, so as to provide a unified fwnode for DT and ACPI bindings. Tested-by: Alan Tull Acked-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c| 37 drivers/mfd

[PATCH v9 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

d error reported by Kbuild test robot Changes v1 -> v2: - rebase to branch "devel" of Linus Walleij's repository - split in two patch as suggested by Andy S - add Mika's ACKs Jiang Qiu (3): gpio: dwapb: remove name from dwapb_port_property gpio: dwapb: convert device nod

[PATCH v9 1/3] gpio: dwapb: remove name from dwapb_port_property

This patch removed the name property from dwapb_port_property. The name property is redundant, since we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> --- drivers/gpio/

[PATCH v9 1/3] gpio: dwapb: remove name from dwapb_port_property

This patch removed the name property from dwapb_port_property. The name property is redundant, since we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c| 24 +++- drivers/mfd

[PATCH v8 2/3] gpio: dwapb: convert device node to fwnode

This patch converts device node to fwnode for dwapb driver, so as to provide a unified fwnode for DT and ACPI bindings. Tested-by: Alan Tull <delicious.qui...@gmail.com> Acked-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> ---

[PATCH v8 2/3] gpio: dwapb: convert device node to fwnode

This patch converts device node to fwnode for dwapb driver, so as to provide a unified fwnode for DT and ACPI bindings. Tested-by: Alan Tull Acked-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c| 37 drivers/mfd

[PATCH v8 3/3] gpio: dwapb: add gpio-signaled acpi event support

d) { Notify (\_SB.PWRB, 0x80) } } Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com> Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> --- drivers/gpio/gpio-dwapb.c | 17 + 1 file changed

[PATCH v8 3/3] gpio: dwapb: add gpio-signaled acpi event support

d) { Notify (\_SB.PWRB, 0x80) } } Acked-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 72

[PATCH v8 1/3] gpio: dwapb: remove name from dwapb_port_property

This patch removed the name property from dwapb_port_property. The name property is redundant, because we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko <andy.shevche...@gmail.com> Signed-off-by: Jiang Qiu <qiuji...@huawei.com> --- drivers/gpio/

[PATCH v8 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

: - rebase to branch "devel" of Linus Walleij's repository - split in two patch as suggested by Andy S - add Mika's ACKs Jiang Qiu (3): gpio: dwapb: remove name from dwapb_port_property gpio: dwapb: convert device node to fwnode gpio: dwapb: add gpio-signaled acpi

[PATCH v8 1/3] gpio: dwapb: remove name from dwapb_port_property

This patch removed the name property from dwapb_port_property. The name property is redundant, because we can get this info from dwapb_gpio dev node. Reviewed-by: Andy Shevchenko Signed-off-by: Jiang Qiu --- drivers/gpio/gpio-dwapb.c| 24 +++- drivers/mfd

[PATCH v8 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button

: - rebase to branch "devel" of Linus Walleij's repository - split in two patch as suggested by Andy S - add Mika's ACKs Jiang Qiu (3): gpio: dwapb: remove name from dwapb_port_property gpio: dwapb: convert device node to fwnode gpio: dwapb: add gpio-signaled acpi

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/15 15:40, Linus Walleij 写道: > On Tue, Apr 12, 2016 at 8:46 AM, Mika Westerberg > <mika.westerb...@linux.intel.com> wrote: >> On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: >>>> Currently it just complains if something goes wrong. The GPIO driver &

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/15 15:40, Linus Walleij 写道: > On Tue, Apr 12, 2016 at 8:46 AM, Mika Westerberg > wrote: >> On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: >>>> Currently it just complains if something goes wrong. The GPIO driver >>>> itself can still

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/12 14:46, Mika Westerberg 写道: > On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: >>> Currently it just complains if something goes wrong. The GPIO driver >>> itself can still work just fine (including interrupts). >>> >>> I'm fine to chan

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/12 14:46, Mika Westerberg 写道: > On Mon, Apr 11, 2016 at 08:43:22PM +0800, Jiang Qiu wrote: >>> Currently it just complains if something goes wrong. The GPIO driver >>> itself can still work just fine (including interrupts). >>> >>> I'm fine to chan

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/8 16:38, Mika Westerberg 写道: > On Fri, Apr 08, 2016 at 10:26:28AM +0200, Linus Walleij wrote: >> On Wed, Apr 6, 2016 at 9:08 AM, qiujiang wrote: >> >>> This patch adds gpio-signaled acpi event support. It is used for >>> power button on hisilicon D02 board, an arm64

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/8 16:38, Mika Westerberg 写道: > On Fri, Apr 08, 2016 at 10:26:28AM +0200, Linus Walleij wrote: >> On Wed, Apr 6, 2016 at 9:08 AM, qiujiang wrote: >> >>> This patch adds gpio-signaled acpi event support. It is used for >>> power button on hisilicon D02 board, an arm64 platform. >>> >>> The

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/8 16:26, Linus Walleij 写道: > On Wed, Apr 6, 2016 at 9:08 AM, qiujiang wrote: > >> This patch adds gpio-signaled acpi event support. It is used for >> power button on hisilicon D02 board, an arm64 platform. >> >> The corresponding DSDT file is defined as follows: >>

Re: [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support

在 2016/4/8 16:26, Linus Walleij 写道: > On Wed, Apr 6, 2016 at 9:08 AM, qiujiang wrote: > >> This patch adds gpio-signaled acpi event support. It is used for >> power button on hisilicon D02 board, an arm64 platform. >> >> The corresponding DSDT file is defined as follows: >> Device(GPI0) { >>

Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property

Hi Andy, Thanks for your reply. See my comments inline. Thanks Jiang 在 2016/4/6 20:57, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: >> This patch removed the name property from dwapb_port_property. >> The name property is redundant because we can

Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property

Hi Andy, Thanks for your reply. See my comments inline. Thanks Jiang 在 2016/4/6 20:57, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: >> This patch removed the name property from dwapb_port_property. >> The name property is redundant because we can get those info >>

Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode

在 2016/4/6 21:01, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: >> This patch converts device node to fwnode for dwapb driver, so >> as to provide a unified fwnode for DT and ACPI bindings. >> >> Acked-by: Andy Shevchenko

Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode

在 2016/4/6 21:01, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: >> This patch converts device node to fwnode for dwapb driver, so >> as to provide a unified fwnode for DT and ACPI bindings. >> >> Acked-by: Andy Shevchenko >> Signed-off-by: qiujiang > >> static

Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support

在 2016/3/30 19:41, Andy Shevchenko 写道: > On Sat, Mar 26, 2016 at 4:31 AM, qiujiang wrote: >> This patch adds gpio-signaled acpi event support. It is used for >> power button on hisilicon D02 board, an arm64 platform. > > Yes, looks good, my tag stays. > >> @@ -502,10

Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support

在 2016/3/30 19:41, Andy Shevchenko 写道: > On Sat, Mar 26, 2016 at 4:31 AM, qiujiang wrote: >> This patch adds gpio-signaled acpi event support. It is used for >> power button on hisilicon D02 board, an arm64 platform. > > Yes, looks good, my tag stays. > >> @@ -502,10 +509,17 @@

Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode

在 2016/3/30 19:38, Andy Shevchenko 写道: > On Tue, Mar 29, 2016 at 7:30 PM, Alan Tull wrote: >> On Fri, Mar 25, 2016 at 9:31 PM, qiujiang wrote: >> >>> - if (pp->idx == 0 && >>> - of_property_read_bool(port_np,

Re: [PATCH v6 1/2] gpio: dwapb: convert device node to fwnode

在 2016/3/30 19:38, Andy Shevchenko 写道: > On Tue, Mar 29, 2016 at 7:30 PM, Alan Tull wrote: >> On Fri, Mar 25, 2016 at 9:31 PM, qiujiang wrote: >> >>> - if (pp->idx == 0 && >>> - of_property_read_bool(port_np, "interrupt-controller")) >>> { >>> -

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/24 0:20, Alan Tull 写道: > On Wed, Mar 23, 2016 at 6:41 AM, Jiang Qiu <qiuji...@huawei.com> wrote: >> 在 2016/3/11 4:27, Andy Shevchenko 写道: >>> On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull <delicious.qui...@gmail.com> >>> wrote: >>>&

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/24 0:20, Alan Tull 写道: > On Wed, Mar 23, 2016 at 6:41 AM, Jiang Qiu wrote: >> 在 2016/3/11 4:27, Andy Shevchenko 写道: >>> On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull >>> wrote: >>>> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 4:27, Andy Shevchenko 写道: > On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull wrote: >> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>> This patch converts device node to fwnode in >>> dwapb_port_property for designware gpio driver, >>>

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 4:27, Andy Shevchenko 写道: > On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull wrote: >> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>> This patch converts device node to fwnode in >>> dwapb_port_property for designware gpio driver, >>> so as to provide a unified data structure for DT

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 4:27, Andy Shevchenko 写道: > On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull wrote: >> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>> This patch converts device node to fwnode in >>> dwapb_port_property for designware gpio driver, >>>

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 4:27, Andy Shevchenko 写道: > On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull wrote: >> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>> This patch converts device node to fwnode in >>> dwapb_port_property for designware gpio driver, >>> so as to provide a unified data structure for DT

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 4:27, Andy Shevchenko 写道: > On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull wrote: >> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>> This patch converts device node to fwnode in >>> dwapb_port_property for designware gpio driver, >>>

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 4:27, Andy Shevchenko 写道: > On Thu, Mar 10, 2016 at 9:09 PM, Alan Tull wrote: >> On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >>> This patch converts device node to fwnode in >>> dwapb_port_property for designware gpio driver, >>> so as to provide a unified data structure for DT

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 3:09, Alan Tull 写道: > On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >> This patch converts device node to fwnode in >> dwapb_port_property for designware gpio driver, >> so as to provide a unified data structure for DT >> and ACPI bindings. >> >> Acked-by: Andy

Re: [PATCH v5 1/3] gpio: designware: convert device node to fwnode

在 2016/3/11 3:09, Alan Tull 写道: > On Fri, Mar 4, 2016 at 1:44 AM, qiujiang wrote: >> This patch converts device node to fwnode in >> dwapb_port_property for designware gpio driver, >> so as to provide a unified data structure for DT >> and ACPI bindings. >> >> Acked-by: Andy Shevchenko >>

Re: [PATCH v4 1/2] gpio: designware: switch device node to fwnode and add acpi binding

在 2016/2/29 21:51, Andy Shevchenko 写道: > On Mon, Feb 29, 2016 at 3:13 PM, qiujiang wrote: >> This patch switches device node to fwnode and adds acpi >> binding. As a result, DT and acpi bingdings are compatible >> for this driver. > > I'm not sure it makes sense to add ACPI

Re: [PATCH v4 1/2] gpio: designware: switch device node to fwnode and add acpi binding

在 2016/2/29 21:51, Andy Shevchenko 写道: > On Mon, Feb 29, 2016 at 3:13 PM, qiujiang wrote: >> This patch switches device node to fwnode and adds acpi >> binding. As a result, DT and acpi bingdings are compatible >> for this driver. > > I'm not sure it makes sense to add ACPI binding here. It more

Re: [PATCH v4 1/2] gpio: designware: switch device node to fwnode and add acpi binding

在 2016/2/29 21:51, Andy Shevchenko 写道: > On Mon, Feb 29, 2016 at 3:13 PM, qiujiang wrote: >> This patch switches device node to fwnode and adds acpi >> binding. As a result, DT and acpi bingdings are compatible >> for this driver. > > I'm not sure it makes sense to add ACPI

Re: [PATCH v4 1/2] gpio: designware: switch device node to fwnode and add acpi binding

在 2016/2/29 21:51, Andy Shevchenko 写道: > On Mon, Feb 29, 2016 at 3:13 PM, qiujiang wrote: >> This patch switches device node to fwnode and adds acpi >> binding. As a result, DT and acpi bingdings are compatible >> for this driver. > > I'm not sure it makes sense to add ACPI binding here. It more

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

在 2016/2/25 21:43, Andy Shevchenko 写道: > On Thu, Feb 25, 2016 at 1:58 PM, Jiang Qiu <qiuji...@huawei.com> wrote: >> 在 2016/2/24 21:46, Andy Shevchenko 写道: >>> On Wed, Feb 24, 2016 at 2:33 PM, qiujiang <qiuji...@huawei.com> wrote: > >>> - why do you

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

在 2016/2/25 21:43, Andy Shevchenko 写道: > On Thu, Feb 25, 2016 at 1:58 PM, Jiang Qiu wrote: >> 在 2016/2/24 21:46, Andy Shevchenko 写道: >>> On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: > >>> - why do you use fwnode_*() instead of device_property_*() calls

Re: [PATCH v3 2/2] gpio: designware: add gpio-signaled acpi events support for power button

在 2016/2/24 21:49, Andy Shevchenko 写道: > On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: >> This patch modifies the designware gpio controller driver to >> support the gpio-signaled acpi events. This is used for power >> button on hisilicon D02 board(an arm64 platform). >

Re: [PATCH v3 2/2] gpio: designware: add gpio-signaled acpi events support for power button

在 2016/2/24 21:49, Andy Shevchenko 写道: > On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: >> This patch modifies the designware gpio controller driver to >> support the gpio-signaled acpi events. This is used for power >> button on hisilicon D02 board(an arm64 platform). > >> @@ -434,6 +436,10

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

在 2016/2/24 21:46, Andy Shevchenko 写道: > On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: >> This patch switch device node to fwnode in dwapb_port_property, >> so as to apply a unified data structure for DT and ACPI. >> >> This change also needs to be done in

Re: [PATCH v3 1/2] gpio: designware: switch device node to fwnode

在 2016/2/24 21:46, Andy Shevchenko 写道: > On Wed, Feb 24, 2016 at 2:33 PM, qiujiang wrote: >> This patch switch device node to fwnode in dwapb_port_property, >> so as to apply a unified data structure for DT and ACPI. >> >> This change also needs to be done in intel_quark_i2c_gpio driver, >> since

Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

在 2016/2/16 17:24, Mika Westerberg 写道: > On Fri, Feb 05, 2016 at 02:25:42PM +0800, qiujiang wrote: >> This patch modifies the DesignWare GPIO controller driver to >> support the GPIO-signaled ACPI Events. This is used for power >> button function on ARM server. >> >> To make it work, the _AEI and

Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

在 2016/2/16 17:24, Mika Westerberg 写道: > On Fri, Feb 05, 2016 at 02:25:42PM +0800, qiujiang wrote: >> This patch modifies the DesignWare GPIO controller driver to >> support the GPIO-signaled ACPI Events. This is used for power >> button function on ARM server. >> >> To make it work, the _AEI and

Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

在 2016/2/16 2:25, Linus Walleij 写道: > Mika can you help out looking at this patch. Tell me if you need a copy > of the whole patch, I'm not smart with ACPI. > > On Fri, Feb 5, 2016 at 7:25 AM, qiujiang wrote: > >> This patch modifies the DesignWare GPIO controller driver to

Re: [RFC PATCH] GPIO/ACPI: DesignWare: Add GPIO-signaled ACPI events support for power button

在 2016/2/16 2:25, Linus Walleij 写道: > Mika can you help out looking at this patch. Tell me if you need a copy > of the whole patch, I'm not smart with ACPI. > > On Fri, Feb 5, 2016 at 7:25 AM, qiujiang wrote: > >> This patch modifies the DesignWare GPIO controller driver to >> support the

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

Hi Andy, Sorry for late relpy because Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 23:55, Andy Shevchenko 写道: On Fri, Feb 5, 2016 at 9:11 AM, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio driver. It was based the corresponding DT

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

Hi Mark, Many thanks for your review, I'm so sorry for late reply because The Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 19:09, Mark Brown 写道: On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

Hi Mark, Many thanks for your review, I'm so sorry for late reply because The Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 19:09, Mark Brown 写道: On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio

Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

Hi Andy, Sorry for late relpy because Chinese new year holiday. See my replies below. Best Regards Jiang 在 2016/2/5 23:55, Andy Shevchenko 写道: On Fri, Feb 5, 2016 at 9:11 AM, qiujiang wrote: This patch added ACPI support for DesignWare SPI mmio driver. It was based the