Re: [GIT PULL] NTB bug fixes for v5.11

On Mon, Jan 4, 2021 at 3:31 AM Dan Carpenter wrote: > > On Sun, Dec 27, 2020 at 09:38:23AM -0800, Linus Torvalds wrote: > > On Sun, Dec 27, 2020 at 6:16 AM Jon Mason wrote: > > > > > > Wang Qing (1): > > > ntb: idt: fix error check in ntb_hw_idt.c >

[GIT PULL] NTB bug fixes for v5.11

Hello Linus, Here are a few NTB bug fixes for v5.11. Please consider pulling them. Thanks, Jon The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://github.com/jonmason/ntb

Re: [PATCH] ntb: idt: fix error check in ntb_hw_idt.c

On Tue, Nov 10, 2020 at 09:33:40PM +0300, Serge Semin wrote: > Hello Wang > > On Fri, Nov 06, 2020 at 05:43:31PM +0800, Wang Qing wrote: > > idt_create_dev never return NULL and fix smatch warning. > > Thanks for submitting this. For the both changes > Acked-by: Serge Semin Applied to the ntb

[GIT PULL] NTB bug fixes for v5.10

Hello Linus, Here are a few NTB bug fixes for v5.10. Please consider pulling them. Thanks, Jon The following changes since commit d012a7190fc1fd72ed48911e77ca97ba4521bccd: Linux 5.9-rc2 (2020-08-23 14:08:43 -0700) are available in the Git repository at: git://github.com/jonmason/ntb

Re: [PATCH][next] NTB: Use struct_size() helper in devm_kzalloc()

On Fri, Jun 19, 2020 at 01:10:55PM -0600, Logan Gunthorpe wrote: > > > On 2020-06-19 11:25 a.m., Gustavo A. R. Silva wrote: > > Make use of the struct_size() helper instead of an open-coded version > > in order to avoid any potential type mistakes. Also, remove unnecessary > > variable

Re: [RESEND] NTB: hw: amd: fix an issue about leak system resources

On Tue, Aug 11, 2020 at 09:59:57AM +0800, Kaige Li wrote: > The related system resources were not released when pci_set_dma_mask(), > pci_set_consistent_dma_mask(), or pci_iomap() return error in the > amd_ntb_init_pci() function. Add pci_release_regions() to fix it. > > Signed-off-by: Kaige Li

Re: [PATCH] ntb: intel: Fix memleak in intel_ntb_pci_probe

On Mon, Aug 24, 2020 at 07:37:56AM -0700, Dave Jiang wrote: > > > On 8/22/2020 11:55 PM, Dinghao Liu wrote: > > The default error branch of a series of pdev_is_gen calls > > should free ndev just like what we've done in these calls. > > > > Signed-off-by: Dinghao Liu > > Thanks Dinghao >

[GIT PULL] NTB patches for v5.8

Hello Linus, Here are a lot of NTB bug fixes and Intel Icelake for v5.8. Please consider pulling them. Thanks, Jon The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the Git repository at:

Re: [PATCH] NTB: correct ntb_peer_spad_addr and ntb_peer_spad_read comment typos

On Tue, May 26, 2020 at 03:59:43PM +0800, Wesley Sheng wrote: > The comment for ntb_peer_spad_addr and ntb_peer_spad_read > incorrectly referred to peer doorbell register and local > scratchpad register. > > Signed-off-by: Wesley Sheng Pulled into the ntb branch Thanks, Jon > --- >

Re: [PATCH v3 0/5] ntb perf, ntb tool and ntb-hw improvements

On Tue, May 05, 2020 at 11:21:47PM -0500, Sanjay R Mehta wrote: > v3: > - Increased ntb_perf command re-try sleep time > - avoid false dma unmap of dst address. > > v2: Incorporated improvements suggested by Logan Gunthorpe Pulled into the ntb branch. Thanks, Jon > > Links of the review

[GIT PULL] NTB changes for v5.4

Hello Linus, Here are a few NTB bug fixes and a new AMD device support for v5.4. Please consider pulling them. Thanks, Jon The following changes since commit 4d856f72c10ecb060868ed10ff1b1453943fc6c8: Linux 5.3 (2019-09-15 14:19:32 -0700) are available in the Git repository at:

Re: [PATCH] NTB: fix IDT Kconfig typos/spellos

On Wed, Sep 18, 2019 at 1:58 PM Randy Dunlap wrote: > > From: Randy Dunlap > > Fix typos in drivers/ntb/hw/idt/Kconfig. > Use consistent spelling and capitalization. > > Fixes: bf2a952d31d2 ("NTB: Add IDT 89HPESxNTx PCIe-switches support") > Signed-off-by: R

Re: [PATCH 2/2] ntb_hw_amd: Add memory window support for new AMD hardware

On Sun, Sep 15, 2019 at 10:08 AM Mehta, Sanju wrote: > > From: Sanjay R Mehta > > The AMD new hardware uses BAR23 and BAR45 as memory windows > as compared to previos where BAR1, BAR23 and BAR45 is used > for memory windows. > > This patch add support for both AMD hardwares. I pulled both of

Re: [PATCH] NTB: ntb_transport: remove redundant assignment to rc

On Sun, Aug 18, 2019 at 7:53 PM Colin King wrote: > > From: Colin Ian King > > Variable rc is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can be > removed. Applied to ntb-next, thanks > Addresses-Coverity: ("Unused value") >

Re: [PATCH] point to right memory window index

On Wed, Apr 10, 2019 at 11:24 AM Mehta, Sanju wrote: > > Hi All, > > Any comments on below patch? I wasn't cc'ed, so this one missed my inbox. Applied to ntb-next, thanks. > > Thanks & Regards, > Sanjay Mehta > > -Original Message- > From: Mehta, Sanju > Sent: Friday, March 29, 2019

[GIT PULL] NTB bug fixes for v5.3

Hello Linus, Here is a trivial NTB bug fix for v5.3. Please consider pulling it. Thanks, Jon The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d: Linux 5.3-rc3 (2019-08-04 18:40:12 -0700) are available in the Git repository at: git://github.com/jonmason/ntb

[GIT PULL] NTB changes for v5.3

Hello Linus, Here are the NTB changes for v5.3. The big change is adding the virtual MSI interface for NTB (reviewed and acked by Bjorn). Also, there are some bug fixes. Please consider pulling them. Thanks, Jon The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:

Re: [PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec

On Thu, Jun 06, 2019 at 03:09:41PM +0800, Kelvin Cao wrote: > Hi, Everyone, > > This patch series remove redundant steps and fix one bug of the > ntb_hw_switchtec module. > > When a re-initialization is caused by a link event, the driver will > re-setup the shared memory windows. But at that

Re: [PATCH] NTB: correct ntb_dev_ops and ntb_dev comment typos

On Tue, Apr 30, 2019 at 06:04:29PM +0800, Wesley Sheng wrote: > The comment for ntb_dev_ops and ntb_dev incorrectly referred to > ntb_ctx_ops and ntb_device. > > Signed-off-by: Wesley Sheng > Reviewed-by: Logan Gunthorpe Sorry for the delay. The series is now in the ntb branch. We've missed

Re: [PATCH v5 00/10] Support using MSI interrupts in ntb_transport

On Thu, May 23, 2019 at 04:30:50PM -0600, Logan Gunthorpe wrote: > This is another resend as there has been no feedback since v4. > Seems Jon has been MIA this past cycle so hopefully he appears on the > list soon. > > I've addressed the feedback so far and rebased on the latest kernel > and

Re: [PATCH v2] drivers: ntb: Kconfig: pedantic cleanups

On Wed, Mar 20, 2019 at 9:15 PM Bjorn Helgaas wrote: > > [+cc Jon, Dave, Allen] > > On Wed, Mar 06, 2019 at 11:02:54PM +0100, Enrico Weigelt, metux IT consult > wrote: > > Formatting of Kconfig files doesn't look so pretty, so just > > take damp cloth and clean it up. > > Oops, I didn't notice

Re: linux-next: Fixes tag needs some work in the ntb tree

On Thu, Mar 21, 2019 at 4:28 PM Stephen Rothwell wrote: > > Hi Jon, > > On Thu, 21 Mar 2019 15:53:47 -0400 Jon Mason wrote: > > > > Is there an existing set of tools/scripts I should run to prevent > > things like this from happening? > > I have attached t

Re: linux-next: Fixes tag needs some work in the ntb tree

On Wed, Mar 20, 2019 at 5:00 PM Logan Gunthorpe wrote: > > > > On 2019-03-20 2:58 p.m., Stephen Rothwell wrote: > > Hi all, > > > > In commit > > > > f4d0dd1064b8 ("NTB: ntb_transport: Ensure qp->tx_mw_dma_addr is > > initaliazed") > > > > Fixes tag > > > > Fixes: c27ccb899219 ("NTB:

Re: [PATCH 1/4] NTB: ntb_perf: Increased the number of message retries to 1000

On Fri, Feb 15, 2019 at 09:20:07AM +, Mehta, Sanju wrote: > From: Sanjay R Mehta > > while waiting for the peer ntb_perf to initialize scratchpad > registers, local side ntb_perf might have already exhausted the > maximum number of retries which is currently set to 500. To avoid > this and

Re: [PATCH -next] ntb: intel: Make intel_ntb3_peer_db_addr static

On Wed, Mar 20, 2019 at 10:08:12PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/ntb/hw/intel/ntb_hw_gen3.c:535:5: warning: > symbol 'intel_ntb3_peer_db_addr' was not declared. Should it be static? > > Signed-off-by: YueHaibing Looks good to me. Added to

[GIT PULL] NTB bug fixes for v5.1

Hello Linus, Here are a few NTB fixes for v5.1. While the tag is new, the patches have been in my tree (and thus linux-next) for weeks now. Please consider pulling them. Thanks, Jon The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06

Re: [PATCH] NTB: ntb_transport: Free MWs in ntb_transport_link_cleanup()

On Mon, Jan 07, 2019 at 06:16:02PM -0700, Logan Gunthorpe wrote: > > > On 06/01/19 08:12 PM, Joey Zhang wrote: > > If NTB peer host crashes or reboots, the NTB transport link will be > > down and the MWs of NTB transport will be invalid. But the > > ntb_transport_link_cleanup() does not free

Re: [PATCH] NTB: ntb_transport: Ensure the destination buffer is mapped for TX DMA

the entire MW region for each QP after we assign > > the DMA channel. This prevents needing an extra DMA map in the fast > > path. > > > > Link: > > https://lore.kernel.org/linux-pci/499934e7-3734-1aee-37dd-b42a5d2a2...@intel.com/ > > Signed-off-by: Logan Gunth

Re: [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset

On Wed, Jan 09, 2019 at 12:22:25PM -0700, Logan Gunthorpe wrote: > Hey, > > I'm resending this because I've recently found out that the change we > made to use the NTB struct device in DMA allocations is wrong and > needs to be reverted. Turns out that, when running with an IOMMU, >

Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

On Wed, Dec 12, 2018 at 7:01 PM Logan Gunthorpe wrote: > > > > On 2018-12-12 4:57 p.m., Jon Mason wrote: > > On Wed, Dec 12, 2018 at 6:42 PM Logan Gunthorpe wrote: > >> > >> > >> > >> On 2018-12-12 4:00 p.m., Jon Mason wrote: &

Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

On Wed, Dec 12, 2018 at 6:42 PM Logan Gunthorpe wrote: > > > > On 2018-12-12 4:00 p.m., Jon Mason wrote: > > So, you based your patches on a series of patches not in the > > ntb/ntb-next branch? Please don't do this. I see nothing in these > > patches which req

Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows

On Thu, Dec 6, 2018 at 1:47 AM Wesley Sheng wrote: > > Hi, Everyone, > > This patch series adds support of >=4G memory windows. > > Current Switchtec's BAR setup registers are limited to 32bits, > corresponding to the maximum MW (memory window) size is <4G. > Increase the MW sizes with the

Re: [PATCH 2/3] ntb_hw_switchtec: Added support of >=4G memory windows

On Wed, Nov 21, 2018 at 9:19 PM Wesley Sheng wrote: > > From: Paul Selles > > Current Switchtec's BAR setup registers are limited to 32bits, > corresponding to the maximum MW (memory window) size is <4G. > > Increase the MW sizes with the addition of the BAR Setup Extension > Register for the

Re: [PATCH 2/3] ntb_hw_switchtec: Added support of >=4G memory windows

On Wed, Nov 21, 2018 at 9:19 PM Wesley Sheng wrote: > > From: Paul Selles > > Current Switchtec's BAR setup registers are limited to 32bits, > corresponding to the maximum MW (memory window) size is <4G. > > Increase the MW sizes with the addition of the BAR Setup Extension > Register for the

[GIT PULL] NTB patches for v4.20

: intel: fix return value for ndev_vec_mask() Gustavo A. R. Silva (2): NTB: ntb_hw_idt: replace IS_ERR_OR_NULL with regular NULL checks ntb: ntb_transport: Mark expected switch fall-throughs Jon Mason (1): ntb_netdev: fix sleep time mismatch Serge Semin (5): ntb: idt: Set

[GIT PULL] NTB patches for v4.20

: intel: fix return value for ndev_vec_mask() Gustavo A. R. Silva (2): NTB: ntb_hw_idt: replace IS_ERR_OR_NULL with regular NULL checks ntb: ntb_transport: Mark expected switch fall-throughs Jon Mason (1): ntb_netdev: fix sleep time mismatch Serge Semin (5): ntb: idt: Set

Re: [PATCH v2 0/4] ntb: idt: Add hwmon temperature sensor interface

On Tue, Jul 17, 2018 at 12:24:33PM +0300, Serge Semin wrote: > IDT PCIe-switches are equipped with an embedded temperature sensor. It > works within the range [0; 127.5]C with a resolution of 0.5C. It can > be used to monitor the chip core temperature so to have prevent it from > possible

Re: [PATCH v2 0/4] ntb: idt: Add hwmon temperature sensor interface

On Tue, Jul 17, 2018 at 12:24:33PM +0300, Serge Semin wrote: > IDT PCIe-switches are equipped with an embedded temperature sensor. It > works within the range [0; 127.5]C with a resolution of 0.5C. It can > be used to monitor the chip core temperature so to have prevent it from > possible

Re: [PATCH 0/4] ntb: idt: Add hwmon temperature sensor interface

On Sat, Jul 14, 2018 at 02:58:30PM +0300, Serge Semin wrote: > IDT PCIe-switches are equipped with an embedded temperature sensor. It > works within the range [0; 127.5]C with a resolution of 0.5C. It can > be used to monitor the chip core temperature so to have prevent it from > possible

Re: [PATCH 0/4] ntb: idt: Add hwmon temperature sensor interface

On Sat, Jul 14, 2018 at 02:58:30PM +0300, Serge Semin wrote: > IDT PCIe-switches are equipped with an embedded temperature sensor. It > works within the range [0; 127.5]C with a resolution of 0.5C. It can > be used to monitor the chip core temperature so to have prevent it from > possible

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

On Fri, Oct 05, 2018 at 01:03:01PM -0400, Allen Hubbe wrote: > On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva > wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Addresses-Coverity-ID: 1373888 ("Missing break in

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

On Fri, Oct 05, 2018 at 01:03:01PM -0400, Allen Hubbe wrote: > On Fri, Oct 5, 2018 at 3:12 AM Gustavo A. R. Silva > wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Addresses-Coverity-ID: 1373888 ("Missing break in

Re: [PATCH] NTB: ntb_hw_idt: replace IS_ERR_OR_NULL with regular NULL checks

On Mon, Aug 27, 2018 at 05:13:06PM -0500, Gustavo A. R. Silva wrote: > Both devm_kcalloc() and devm_kzalloc() return NULL on error. They > never return error pointers. > > The use of IS_ERR_OR_NULL is currently applied to the wrong > context. > > Fix this by replacing IS_ERR_OR_NULL with regular

Re: [PATCH] NTB: ntb_hw_idt: replace IS_ERR_OR_NULL with regular NULL checks

On Mon, Aug 27, 2018 at 05:13:06PM -0500, Gustavo A. R. Silva wrote: > Both devm_kcalloc() and devm_kzalloc() return NULL on error. They > never return error pointers. > > The use of IS_ERR_OR_NULL is currently applied to the wrong > context. > > Fix this by replacing IS_ERR_OR_NULL with regular

[PATCH] MAINTAINERS: Remove self from Broadcom SoCs

I'm leaving Broadcom, and will no longer have access to hardware and documentation necessary to be effective in a maintainership role. Signed-off-by: Jon Mason --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ece30f15777..d063c605074e 100644

[PATCH] MAINTAINERS: Remove self from Broadcom SoCs

I'm leaving Broadcom, and will no longer have access to hardware and documentation necessary to be effective in a maintainership role. Signed-off-by: Jon Mason --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ece30f15777..d063c605074e 100644

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later

Re: [PATCH 3/8] NTB: Fix the default port and peer numbers for legacy drivers

On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > When the commit adding ntb_default_port_number() and > ntb_default_peer_port_number() entered the kernel there was no > users of it so it was impossible to tell what the API needed. > > When a user finally landed a year later

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the

[GIT PULL] NTB changes for v4.18

Hello Linus, Here are a few NTB changes for v4.18. They were tested earlier today by Dave Jiang, and have been in linux-next for some time. Please consider pulling them. Thanks, Jon The following changes since commit 29dcea88779c856c7dc92040a0c01233263101d4: Linux 4.17 (2018-06-03

[GIT PULL] NTB changes for v4.18

Hello Linus, Here are a few NTB changes for v4.18. They were tested earlier today by Dave Jiang, and have been in linux-next for some time. Please consider pulling them. Thanks, Jon The following changes since commit 29dcea88779c856c7dc92040a0c01233263101d4: Linux 4.17 (2018-06-03

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav > --- >

Re: [PATCH] ntb_transport: use put_device() instead of kfree()

On Fri, Mar 09, 2018 at 04:03:24PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav > --- > drivers/ntb/ntb_transport.c | 2 +- >

Re: [PATCH 6/9] NTB: ntb_hw_idt: fix typo 'can by' to 'can be'

On Fri, May 11, 2018 at 04:12:36PM +0300, Serge Semin wrote: > On Sun, May 06, 2018 at 01:23:50PM +0200, Wolfram Sang > wrote: > > Signed-off-by: Wolfram Sang > > --- > > drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +- > > 1 file

Re: [PATCH 2/2] ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue

On Tue, Apr 10, 2018 at 09:17:54PM +0800, Jia-Ju Bai wrote: > ntb_transport_create_queue() is never called in atomic context. > > ntb_transport_create_queue() is only called by ntb_netdev_probe(), > which is set as ".probe" in struct ntb_transport_client. > > Despite never getting called from

Re: [PATCH 2/2] ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_create_queue

On Tue, Apr 10, 2018 at 09:17:54PM +0800, Jia-Ju Bai wrote: > ntb_transport_create_queue() is never called in atomic context. > > ntb_transport_create_queue() is only called by ntb_netdev_probe(), > which is set as ".probe" in struct ntb_transport_client. > > Despite never getting called from

Re: [PATCH 6/9] NTB: ntb_hw_idt: fix typo 'can by' to 'can be'

On Fri, May 11, 2018 at 04:12:36PM +0300, Serge Semin wrote: > On Sun, May 06, 2018 at 01:23:50PM +0200, Wolfram Sang > wrote: > > Signed-off-by: Wolfram Sang > > --- > > drivers/ntb/hw/idt/ntb_hw_idt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR

Fix this again back to 512MB. > > Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR > board") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Jon Mason <jon.ma...@broadcom.com> > --- > arch/arm/boot/dts/bcm958625hr.d

Re: [PATCH] ARM: dts: NSP: Fix amount of RAM on BCM958625HR

> > Fixes: c53beb47f621 ("ARM: dts: NSP: Correct RAM amount for BCM958625HR > board") > Signed-off-by: Florian Fainelli Acked-by: Jon Mason > --- > arch/arm/boot/dts/bcm958625hr.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/a

[GIT PULL] NTB bug fixes for v4.16

unneeded DRIVER_LICENSE #defines Jon Mason (1): NTB: switchtec_ntb: Add new line on appropriate printks Kelvin Cao (1): ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups Logan Gunthorpe (9): ntb_hw_switchtec: Keep track of the number of LUT wind

[GIT PULL] NTB bug fixes for v4.16

unneeded DRIVER_LICENSE #defines Jon Mason (1): NTB: switchtec_ntb: Add new line on appropriate printks Kelvin Cao (1): ntb_hw_switchtec: Allow using Switchtec NTB in multi-partition setups Logan Gunthorpe (9): ntb_hw_switchtec: Keep track of the number of LUT wind

Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted __le32

On Wed, Jan 24, 2018 at 09:07:26AM +0100, Arnd Bergmann wrote: > On Wed, Jan 24, 2018 at 8:48 AM, Serge Semin wrote: > > Sparse is whining about the u32 and __le32 mixed usage in the driver > > > > drivers/ntb/test/ntb_perf.c:288:21: warning: cast to restricted __le32 > >

Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted __le32

On Wed, Jan 24, 2018 at 09:07:26AM +0100, Arnd Bergmann wrote: > On Wed, Jan 24, 2018 at 8:48 AM, Serge Semin wrote: > > Sparse is whining about the u32 and __le32 mixed usage in the driver > > > > drivers/ntb/test/ntb_perf.c:288:21: warning: cast to restricted __le32 > >

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

On Fri, Jan 19, 2018 at 10:26:37PM +0100, Arnd Bergmann wrote: > On Fri, Jan 19, 2018 at 10:03 PM, Serge Semin wrote: > > > > Actually the provided patch is the best solution I could come up with. > > The thing is, that the methods can't be changed. Those functions are >

Re: [PATCH] NTB: ntb_perf: fix cast to restricted __le32

On Fri, Jan 19, 2018 at 10:26:37PM +0100, Arnd Bergmann wrote: > On Fri, Jan 19, 2018 at 10:03 PM, Serge Semin wrote: > > > > Actually the provided patch is the best solution I could come up with. > > The thing is, that the methods can't be changed. Those functions are > > the part of the NTB API

Re: [PATCH][next] NTB: ntb_tool: fix memory leak on 'buf' on error exit path

On Mon, Jan 22, 2018 at 01:02:39PM +0300, Serge Semin wrote: > On Mon, Jan 22, 2018 at 09:38:57AM +, Colin King > wrote: > > From: Colin Ian King > > > > Currently there is a memory leak on buf when the call to ntb_mw_get_align > > fails.

Re: [PATCH][next] NTB: ntb_tool: fix memory leak on 'buf' on error exit path

On Mon, Jan 22, 2018 at 01:02:39PM +0300, Serge Semin wrote: > On Mon, Jan 22, 2018 at 09:38:57AM +, Colin King > wrote: > > From: Colin Ian King > > > > Currently there is a memory leak on buf when the call to ntb_mw_get_align > > fails. Add an exit err label and jump to this so that

Re: [PATCH] NTB: ntb_perf: fix printing of resource_size_t

On Fri, Jan 19, 2018 at 03:55:28PM +0100, Arnd Bergmann wrote: > On 32-bit architectures, resource_size_t is usually 'unsigned int' or > 'unsigned long' but not 'unsigned long long', so we get a warning > about printing the wrong data: > > drivers/ntb/test/ntb_perf.c: In function

Re: [PATCH] NTB: ntb_perf: fix printing of resource_size_t

On Fri, Jan 19, 2018 at 03:55:28PM +0100, Arnd Bergmann wrote: > On 32-bit architectures, resource_size_t is usually 'unsigned int' or > 'unsigned long' but not 'unsigned long long', so we get a warning > about printing the wrong data: > > drivers/ntb/test/ntb_perf.c: In function

Re: [PATCH] [RESEND] ntb_hw_switchtec: fix logic error

On Tue, Jan 16, 2018 at 02:50:51PM +0100, Arnd Bergmann wrote: > Newer gcc (version 7 and 8 presumably) warn about a statement mixing > the << operator with logical and: > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function > 'switchtec_ntb_init_sndev': >

Re: [PATCH] [RESEND] ntb_hw_switchtec: fix logic error

On Tue, Jan 16, 2018 at 02:50:51PM +0100, Arnd Bergmann wrote: > Newer gcc (version 7 and 8 presumably) warn about a statement mixing > the << operator with logical and: > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function > 'switchtec_ntb_init_sndev': >

Re: [PATCH v2 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

Jon > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Jon Mason <jdma...@kudzu.us> > --- > > v2: Use IS_ALIGNED macro as suggested by Allen > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 13 + > 1 file changed, 13 insertions(+) > > di

Re: [PATCH v2 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

Jon > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason > --- > > v2: Use IS_ALIGNED macro as suggested by Allen > > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switch

Re: [PATCH v2 1/2] ntb_transport: Fix bug with max_mw_size parameter

fixed by applying the same limit to tx_size in > ntb_transport_init_queue(). Applied to ntb-next. Thanks, Jon > > Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Acked-by: Allen Hubb

Re: [PATCH v2 1/2] ntb_transport: Fix bug with max_mw_size parameter

fixed by applying the same limit to tx_size in > ntb_transport_init_queue(). Applied to ntb-next. Thanks, Jon > > Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") > Signed-off-by: Logan Gunthorpe > Acked-by: Allen Hubbe > Cc: Jon Mason > C

Re: [PATCH] MAINTAINERS: NTB: Update contact info

> @@ -9712,7 +9712,7 @@ F: drivers/ntb/hw/amd/ > NTB DRIVER CORE > M: Jon Mason <jdma...@kudzu.us> > M: Dave Jiang <dave.ji...@intel.com> > -M: Allen Hubbe <allen.hu...@emc.com> > +M: Allen Hubbe <alle...@gmail.com> > L: linux-...@googlegroups.com > S: Supported > W: https://github.com/jonmason/ntb/wiki > -- > 2.14.1 >

Re: [PATCH] MAINTAINERS: NTB: Update contact info

d-off-by: Allen Hubbe > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 82ad0eabce4f..cb7344e37fc5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9712,7 +9712,7 @@ F: drivers/ntb/hw

Re: [PATCH v4 00/15] NTB: Add full multi-port API support to the test drivers

On Wed, Dec 06, 2017 at 05:31:51PM +0300, Serge Semin wrote: > The multi-port NTB API was introduced in kernel 4.13 as well as the > first driver for the true multi-port devices of IDT PCIe-switches > series. But the test drivers still were left almost unchanged. Yes, > they didn't fail being used

Re: [PATCH v4 00/15] NTB: Add full multi-port API support to the test drivers

On Wed, Dec 06, 2017 at 05:31:51PM +0300, Serge Semin wrote: > The multi-port NTB API was introduced in kernel 4.13 as well as the > first driver for the true multi-port devices of IDT PCIe-switches > series. But the test drivers still were left almost unchanged. Yes, > they didn't fail being used

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

On Tue, Dec 5, 2017 at 2:40 PM, Logan Gunthorpe <log...@deltatee.com> wrote: > > > On 05/12/17 12:12 PM, Jon Mason wrote: >> >> It sucks that we don't already have a struct for PCI config space we >> can reuse here. If you find the time, it would be good

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

On Tue, Dec 5, 2017 at 2:40 PM, Logan Gunthorpe wrote: > > > On 05/12/17 12:12 PM, Jon Mason wrote: >> >> It sucks that we don't already have a struct for PCI config space we >> can reuse here. If you find the time, it would be good to add in the >> fut

Re: [PATCH 0/7] Switchtec NTB Crosslink Support

On Wed, Nov 29, 2017 at 12:58 PM, Logan Gunthorpe wrote: > Also, I forgot to mention, this patch set is based on today's ntb-next. All of these look sane to me. Assuming they apply cleanly, adding to ntb-next. Thanks, Jon > > Logan > > > On 29/11/17 10:55 AM, Logan

Re: [PATCH 0/7] Switchtec NTB Crosslink Support

On Wed, Nov 29, 2017 at 12:58 PM, Logan Gunthorpe wrote: > Also, I forgot to mention, this patch set is based on today's ntb-next. All of these look sane to me. Assuming they apply cleanly, adding to ntb-next. Thanks, Jon > > Logan > > > On 29/11/17 10:55 AM, Logan Gunthorpe wrote: >> >> Hi,

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

On Wed, Nov 29, 2017 at 12:55 PM, Logan Gunthorpe wrote: > The PFF CSR registers actual mirrors the PCI configuration space > for all the ports in the switch. Previously, this was not needed by > the driver but will be used by the crosslink code to enumerate the > bus in an

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

On Wed, Nov 29, 2017 at 12:55 PM, Logan Gunthorpe wrote: > The PFF CSR registers actual mirrors the PCI configuration space > for all the ports in the switch. Previously, this was not needed by > the driver but will be used by the crosslink code to enumerate the > bus in an host-less centre

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > DB interface of ntb_tool driver hasn't been changed much, but > db_valid_mask DebugFS file has still been added to new ntb_tool > driver. In this case it's much better to test all valid DB bits > instead of using the

Re: [PATCH v2 10/15] NTB: ntb_test: Update ntb_tool DB tests

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > DB interface of ntb_tool driver hasn't been changed much, but > db_valid_mask DebugFS file has still been added to new ntb_tool > driver. In this case it's much better to test all valid DB bits > instead of using the predefined mask, which may

Re: [PATCH v2 09/15] NTB: ntb_test: Update ntb_tool link tests

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > Link Up and Down methods are used to change NTB link settings on > local side only for multi-port devices. Link is considered up > only if both sides local and peer set it up. Intel/AMD hardware > acts a bit different

Re: [PATCH v2 09/15] NTB: ntb_test: Update ntb_tool link tests

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > Link Up and Down methods are used to change NTB link settings on > local side only for multi-port devices. Link is considered up > only if both sides local and peer set it up. Intel/AMD hardware > acts a bit different by assigning the Primary

Re: [PATCH v2 07/15] NTB: ntb_test: Safely use paths with whitespace

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got > whitespaces, the script may fail with syntax error. > > Signed-off-by: Serge Semin > Acked-by: Logan Gunthorpe

Re: [PATCH v2 07/15] NTB: ntb_test: Safely use paths with whitespace

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > If some of the variables like LOC/REM or LOCAL_*/REMOTE_* got > whitespaces, the script may fail with syntax error. > > Signed-off-by: Serge Semin > Acked-by: Logan Gunthorpe > Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB

Re: [PATCH v2 06/15] NTB: ntb_perf: Add full multi-port NTB API support

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and

Re: [PATCH v2 06/15] NTB: ntb_perf: Add full multi-port NTB API support

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

On Tue, Dec 5, 2017 at 12:56 PM, Serge Semin <fancer.lan...@gmail.com> wrote: > On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason <jdma...@kudzu.us> wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin <fancer.lan...@gmail.com> wrote: >> > Simple (1 <<

Re: [PATCH v2 03/15] NTB: Fix UB/bug in ntb_mw_get_align()

On Tue, Dec 5, 2017 at 12:56 PM, Serge Semin wrote: > On Tue, Dec 05, 2017 at 11:52:32AM -0500, Jon Mason wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: >> > Simple (1 << pidx) operation causes undefined behaviour when >> > pidx >= 32. It must

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin <fancer.lan...@gmail.com> wrote: > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason <jdma...@kudzu.us> wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin <fancer.lan...@gmail.com> wrote: >> > There is a common

Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods

On Tue, Dec 5, 2017 at 12:31 PM, Serge Semin wrote: > On Tue, Dec 05, 2017 at 11:49:10AM -0500, Jon Mason wrote: >> On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: >> > There is a common methods signature form used over all the NTB API >> > like functions nam

Re: [PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and

Re: [PATCH v2 05/15] NTB: ntb_tool: Add full multi-port NTB API support

On Sun, Dec 3, 2017 at 2:17 PM, Serge Semin wrote: > NTB API has been updated to support multi-port devices like IDT > 89HPESx series or Microsemi Switchtec. Message registers > functionality has also been added to new API. In order to keep > the new hardware and corresponding capabilities well

  1   2   3   4   5   6   7   8   9   10   >