Re: [PATCH v2] tracing: Inform kmemleak of saved_cmdlines allocation

2024-02-14 Thread Kalle Valo
6_64_start_reservations+0x18/0x30 > [] x86_64_start_kernel+0x7b/0x80 > [] secondary_startup_64_no_verify+0x15e/0x16b > > Link: https://lore.kernel.org/linux-trace-kernel/87r0hfnr9r@kernel.org/ > > Fixes: 44dc5c41b5b1 ("tracing: Fix wasted memory in saved_cmdline

Re: [regression] tracing: kmemleak warning in allocate_cmdlines_buffer()

2024-02-14 Thread Kalle Valo
Steven Rostedt writes: > On Wed, 14 Feb 2024 14:50:56 +0200 > Kalle Valo wrote: > >> Hi Steven, >> >> I upgraded our ath11k test setup to v6.8-rc4 and noticed a new kmemleak >> warning in the log: > > Thanks for the report. > >> >&

[regression] tracing: kmemleak warning in allocate_cmdlines_buffer()

2024-02-14 Thread Kalle Valo
Hi Steven, I upgraded our ath11k test setup to v6.8-rc4 and noticed a new kmemleak warning in the log: unreferenced object 0x8881010c8000 (size 32760): comm "swapper", pid 0, jiffies 4294667296 hex dump (first 32 bytes): ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

Re: 回复:general protection fault in ath9k_wmi_event_tasklet

2024-01-25 Thread Kalle Valo
Toke Høiland-Jørgensen writes: > "Ubisectech Sirius" writes: > >>>Hmm, so from eyeballing the code in question, this looks like it is >>>another initialisation race along the lines of the one fixed in commit: >>>8b3046abc99e ("ath9k_htc: fix NULL pointer dereference at >>>

Re: [PATCH] wifi: ath11k: Defer on rproc_get failure

2023-11-13 Thread Kalle Valo
qcom/qcm6490/fairphone5/wpss.mdt, size 7188 > > So, defer the probe if we hit that so we can retry later once the wpss > remoteproc is available. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-01264-QCAMSLSWPLZ-1.37886.3 > > Fixes: d5c65159f289 ("ath11k: driver for Qualc

Re: [PATCH] wifi: ath11k: Defer on rproc_get failure

2023-11-13 Thread Kalle Valo
"Luca Weiss" writes: > On Fri Oct 27, 2023 at 10:25 AM CEST, Kalle Valo wrote: > >> Luca Weiss writes: >> >> > If we already have gotten the rproc_handle (meaning the "qcom,rproc" >> > property is defined in the devicetree), it's a valid

Re: [PATCH 9/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi

2023-11-13 Thread Kalle Valo
"Luca Weiss" writes: >> >> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> >> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts >> >> > > @@ -713,3 +713,7 @@ { >> >> > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn"; >> >> > > status = "okay"; >> >> > >

Re: [PATCH 9/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi

2023-11-13 Thread Kalle Valo
(adding ath11k list) Dmitry Baryshkov writes: > [Added Kalle to the CC list] > > On Tue, 31 Oct 2023 at 12:31, Luca Weiss wrote: >> >> On Mon Oct 30, 2023 at 8:26 PM CET, Konrad Dybcio wrote: >> > On 27.10.2023 16:20, Luca Weiss wrote: >> > > Now that the WPSS remoteproc is enabled, enable

Re: [PATCH] wifi: ath11k: Defer on rproc_get failure

2023-10-27 Thread Kalle Valo
Luca Weiss writes: > If we already have gotten the rproc_handle (meaning the "qcom,rproc" > property is defined in the devicetree), it's a valid state that the > remoteproc module hasn't probed yet so we should defer probing instead > of just failing to probe. > > This resolves a race condition

Re: [PATCH 09/10] wireless: hostap: remove unused ioctl function

2023-10-10 Thread Kalle Valo
over "wireless:" but that's nitpicking. I assume this goes via a net tree so: Acked-by: Kalle Valo Let me know if I should take this to wireless-next instead. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH 08/10] wireless: atmel: remove unused ioctl function

2023-10-10 Thread Kalle Valo
refer "wifi:" over "wireless:" but that's nitpicking. I assume this goes via a net tree so: Acked-by: Kalle Valo Let me know if I should take this to wireless-next instead. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wl1251: Fix possible buffer overflow in wl1251_cmd_scan

2021-04-18 Thread Kalle Valo
Lee Gibson writes: > Function wl1251_cmd_scan calls memcpy without checking the length. > A user could control that length and trigger a buffer overflow. > Fix by checking the length is within the maximum allowed size. > > Signed-off-by: Lee Gibson Please fix the commit log, the user cannot

Re: [PATCH] bcma: remove unused function

2021-04-18 Thread Kalle Valo
Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/bcma/driver_mips.c:55:20: warning: unused function > 'mips_write32' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Patch applied to wireless-drivers-next.git, thanks. fa84df705260 bcma:

Re: [PATCH] wil6210: wmi: Remove useless code

2021-04-18 Thread Kalle Valo
Jiapeng Chong wrote: > Fix the following whitescan warning: > > An unsigned value can never be less than 0. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Patch applied to wireless-drivers-next.git, thanks. 5e6087559e85 wil6210: wmi: Remove useless code --

Re: [PATCH] carl9170: remove get_tid_h

2021-04-18 Thread Kalle Valo
Christophe JAILLET wrote: > 'get_tid_h()' is the same as 'ieee80211_get_tid()'. > So this function can be removed to save a few lines of code. > > Signed-off-by: Christophe JAILLET > Acked-by: Christian Lamparter Patch applied to wireless-drivers-next.git, thanks. cf366b154704 carl9170:

Re: mwl8k: Fix a double Free in mwl8k_probe_hw

2021-04-18 Thread Kalle Valo
Lv Yunlong wrote: > In mwl8k_probe_hw, hw->priv->txq is freed at the first time by > dma_free_coherent() in the call chain: > if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i). > > Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed > at the second time by

Re: [1/4] brcmfmac: Remove duplicate struct declaration

2021-04-18 Thread Kalle Valo
Wan Jiabing wrote: > struct brcmf_bus is declared twice. One has been declared > at 37th line. Remove the duplicate. > > Signed-off-by: Wan Jiabing 2 patches applied to wireless-drivers-next.git, thanks. d663bc3317c9 brcmfmac: Remove duplicate struct declaration 444a9af68b5c wilc1000: Remove

Re: [2/2] wl3501: fix typo of 'Networks' in comment

2021-04-18 Thread Kalle Valo
Eric Lin wrote: > Signed-off-by: Eric Lin > Reported-by: Gustavo A. R. Silva Patch applied to wireless-drivers-next.git, thanks. 7f50ddc5d4fe wl3501: fix typo of 'Networks' in comment -- https://patchwork.kernel.org/project/linux-wireless/patch/20210331010418.1632816-2-dslin1...@gmail.com/

Re: libertas: struct lbs_private is declared duplicately

2021-04-18 Thread Kalle Valo
Wan Jiabing wrote: > struct lbs_private has been declared at 22nd line. > Remove the duplicate. > > Signed-off-by: Wan Jiabing Patch applied to wireless-drivers-next.git, thanks. d3240418a662 libertas: struct lbs_private is declared duplicately --

Re: [PATCH] brcmfmac: A typo fix

2021-04-18 Thread Kalle Valo
Bhaskar Chowdhury wrote: > s/revsion/revision/ > > Signed-off-by: Bhaskar Chowdhury Patch applied to wireless-drivers-next.git, thanks. 705b5cfab183 brcmfmac: A typo fix -- https://patchwork.kernel.org/project/linux-wireless/patch/20210323043657.1466296-1-unixbhas...@gmail.com/

Re: [PATCH v2] rsi: fix comment syntax in file headers

2021-04-18 Thread Kalle Valo
Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are some files in drivers/net/wireless/rsi which follow this syntax > in their file headers, i.e. start with '/**' like comments, which causes > unexpected warnings

Re: [PATCH] hostap: Fix memleak in prism2_config

2021-04-18 Thread Kalle Valo
Dinghao Liu wrote: > When prism2_hw_config() fails, we just return an error code > without any resource release, which may lead to memleak. > > Signed-off-by: Dinghao Liu Nobody reviewed this, so dropping the patch. Patch set to Changes Requested. --

Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

2021-04-18 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the

Re: [PATCH] rtl8xxxu: Fix device info for RTL8192EU devices

2021-04-17 Thread Kalle Valo
Pascal Terjan wrote: > Based on 2001:3319 and 2357:0109 which I used to test the fix and > 0bda:818b and 2357:0108 for which I found efuse dumps online. > > == 2357:0109 == > === Before === > Vendor: Realtek > Product: \x03802.11n NI > Serial: > === After === > Vendor: Realtek > Product:

Re: [PATCH] rsi: fix error return code of rsi_load_9116_firmware()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When kmemdup() returns NULL to ta_firmware, no error return code of > rsi_load_9116_firmware() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to

Re: [PATCH] ti: wlcore: fix error return code of wl1271_cmd_build_ps_poll()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When ieee80211_pspoll_get() returns NULL to skb, no error return code of > wl1271_cmd_build_ps_poll() is assigned. > To fix this bug, ret is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch

Re: [PATCH] ti: wlcore: fix error return code of wl1271_suspend()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When wl is NULL, no error return code of wl1271_suspend() is assigned. > To fix this bug, ret is assigned with -EINVAL in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes Requested. --

Re: [PATCH] marvell: libertas_tf: fix error return code of if_usb_prog_firmware()

2021-04-17 Thread Kalle Valo
Jia-Ju Bai wrote: > When check_fwfile_format() fails, no error return code of > if_usb_prog_firmware() is assigned. > To fix this bug, ret is assigned with -EINVAL as error return code. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to

Re: [PATCH net-next] airo: work around stack usage warning

2021-04-17 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 with KASAN on 32-bit arm produces a warning about a function > that needs a lot of stack space: > > drivers/net/wireless/cisco/airo.c: In function 'setup_card.constprop': > drivers/net/wireless/cisco/airo.c:3960:1: error: the frame size of

Re: [PATCH net-next] wlcore: fix overlapping snprintf arguments in debugfs

2021-04-17 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc complains about undefined behavior in calling snprintf() > with the same buffer as input and output: > > drivers/net/wireless/ti/wl18xx/debugfs.c: In function > 'diversity_num_of_packets_per_ant_read': >

Re: [PATCH net-next 4/5] libertas: avoid -Wempty-body warning

2021-04-17 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > Building without mesh supports shows a couple of warnings with > 'make W=1': > > drivers/net/wireless/marvell/libertas/main.c: In function 'lbs_start_card': > drivers/net/wireless/marvell/libertas/main.c:1068:37: error: suggest braces > around

Re: [PATCH] rtl8xxxu: Simplify locking of a skb list accesses

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail() > and __skb_dequeue() calls. > Use the lock provided in the skb itself and call skb_queue_tail() and > skb_dequeue(). These functions already include the correct locking. > > Signed-off-by:

Re: [PATCH] mwifiex: Remove unneeded variable: "ret"

2021-04-17 Thread Kalle Valo
zuoqil...@163.com wrote: > From: zuoqilin > > Remove unneeded variable: "ret" > > Signed-off-by: zuoqilin Patch applied to wireless-drivers-next.git, thanks. c81852a48e13 mwifiex: Remove unneeded variable: "ret" --

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-04-17 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix > multiple warnings by replacing /* fall through */ comments with > the new pseudo-keyword macro fallthrough; instead of letting the > code fall through to the next case. > > Notice that Clang doesn't

Re: [PATCH] mwifiex: don't print SSID to logs

2021-04-17 Thread Kalle Valo
Brian Norris wrote: > There are a few reasons not to dump SSIDs as-is in kernel logs: > > 1) they're not guaranteed to be any particular text encoding (UTF-8, >ASCII, ...) in general > 2) it's somewhat redundant; the BSSID should be enough to uniquely >identify the AP/STA to which we're

Re: [PATCH net-next] rtlwifi: rtl8192de: Use DEFINE_SPINLOCK() for spinlock

2021-04-17 Thread Kalle Valo
Huang Guobin wrote: > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang Patch applied to wireless-drivers-next.git, thanks. e9642be26a37

Re: [PATCH v2] qtnfmac: remove meaningless goto statement and labels

2021-04-17 Thread Kalle Valo
samirweng1979 wrote: > From: wengjianfeng > > some function's label meaningless, the label statement follows > the goto statement, no other statements, so just remove it. > > Reported-by: kernel test robot > Signed-off-by: wengjianfeng Patch applied to wireless-drivers-next.git, thanks.

Re: [PATCH] rtlwifi: Simplify locking of a skb list accesses

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail() > and __skb_dequeue() calls. > Use the lock provided in the skb itself and call skb_queue_tail() and > skb_dequeue(). These functions already include the correct locking. > > Signed-off-by:

Re: [PATCH] rtlwifi: remove rtl_get_tid_h

2021-04-17 Thread Kalle Valo
Christophe JAILLET wrote: > 'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'. > So this function can be removed to save a line of code. > > Signed-off-by: Christophe JAILLET Patch applied to wireless-drivers-next.git, thanks. 987e9bcdd0b7 rtlwifi: remove rtl_get_tid_h --

Re: [PATCH] rtlwifi: rtl8188ee: remove redundant assignment of variable rtlpriv->btcoexist.reg_bt_sco

2021-04-17 Thread Kalle Valo
Yang Li wrote: > Assigning value "3" to "rtlpriv->btcoexist.reg_bt_sco" here, but that > stored value is overwritten before it can be used. > > Coverity reports this problem as > CWE563: A value assigned to a variable is never used. > drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c: >

Re: [PATCH] rtlwifi: remove redundant assignment to variable err

2021-04-17 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Variable err is assigned -ENODEV followed by an error return path > via label error_out that does not access the variable and returns > with the -ENODEV error return code. The assignment to err is > redundant and can be removed. > >

Re: [PATCH] rtlwifi: Few mundane typo fixes

2021-04-17 Thread Kalle Valo
Bhaskar Chowdhury wrote: > s/resovle/resolve/ > s/broadcase/broadcast/ > s/sytem/system/ > > Signed-off-by: Bhaskar Chowdhury > Acked-by: Randy Dunlap Patch applied to wireless-drivers-next.git, thanks. 2377b1c49d48 rtlwifi: Few mundane typo fixes --

Re: [PATCH] qtnfmac: remove meaningless labels

2021-04-17 Thread Kalle Valo
samirweng1979 wrote: > From: wengjianfeng > > some function's label meaningless, the return statement follows > the goto statement, so just remove it. > > Signed-off-by: wengjianfeng > Reviewed-by: Sergey Matyukevich Patch applied to wireless-drivers-next.git, thanks. a221d0afbf39

Re: [PATCH] cw1200: Remove unused function pointer typedef wsm_*

2021-04-17 Thread Kalle Valo
Chen Lin wrote: > From: Chen Lin > > Remove the 'wsm_*' typedef as it is not used. > > Signed-off-by: Chen Lin Patch applied to wireless-drivers-next.git, thanks. 9dc5fdc8c4f8 cw1200: Remove unused function pointer typedef wsm_* --

Re: [PATCH] cw1200: Remove unused function pointer typedef cw1200_wsm_handler

2021-04-17 Thread Kalle Valo
Chen Lin wrote: > From: Chen Lin > > Remove the 'cw1200_wsm_handler' typedef as it is not used. > > Signed-off-by: Chen Lin Patch applied to wireless-drivers-next.git, thanks. 1c22233a745e cw1200: Remove unused function pointer typedef cw1200_wsm_handler --

Re: [PATCH] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth

2021-04-17 Thread Kalle Valo
Lee Gibson wrote: > Function qtnf_event_handle_external_auth calls memcpy without > checking the length. > A user could control that length and trigger a buffer overflow. > Fix by checking the length is within the maximum allowed size. > > Signed-off-by: Lee Gibson Please use clamp_val()

Re: [PATCH] mac80211_hwsim: indicate support for 60GHz channels

2021-04-14 Thread Kalle Valo
Ramon Fontes writes: > Advertise 60GHz channels to mac80211. SoB missing: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing -- https://patchwork.kernel.org/project/linux-wireless/list/

Re: [PATCH v2 0/2][next] wl3501_cs: Fix out-of-bounds warnings

2021-04-14 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > Friendly ping: could somebody give us some feedback or take > this series, please? First patch 2 comment needs to be resolved. -- https://patchwork.kernel.org/project/linux-wireless/list/

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-12 Thread Kalle Valo
Shawn Guo writes: > On Sun, Apr 11, 2021 at 10:57:54AM +0300, Kalle Valo wrote: >> Shawn Guo writes: >> >> > Add optional brcm,ccode-map property to support translation from ISO3166 >> > country code to brcmfmac firmware country code and revision. &

Re: [PATCH net-next 3/5] iwlegacy: avoid -Wempty-body warning

2021-04-11 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > There are a couple of warnings in this driver when building with W=1: > > drivers/net/wireless/intel/iwlegacy/common.c: In function 'il_power_set_mode': > drivers/net/wireless/intel/iwlegacy/common.c:1195:60: error: suggest braces > around empty

Re: [PATCH] mt7601u: fix always true expression

2021-04-11 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > Currently the expression ~nic_conf1 is always true because nic_conf1 > is a u16 and according to 6.5.3.3 of the C standard the ~ operator > promotes the u16 to an integer before flipping all the bits. Thus > the top 16 bits of the integer result are

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-11 Thread Kalle Valo
Shawn Guo writes: > Add optional brcm,ccode-map property to support translation from ISO3166 > country code to brcmfmac firmware country code and revision. > > Signed-off-by: Shawn Guo > --- > .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 7 +++ > 1 file changed, 7

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-04-07 Thread Kalle Valo
Ulf Hansson writes: >> If I follow what has been done in other drivers I would write something >> like: >> >> static int wfx_sdio_suspend(struct device *dev) >> { >> struct sdio_func *func = dev_to_sdio_func(dev); >> struct wfx_sdio_priv *bus = sdio_get_drvdata(func); >>

Re: [PATCH] hostap: Fix memleak in prism2_config

2021-04-07 Thread Kalle Valo
Dinghao Liu writes: > When prism2_hw_config() fails, we just return an error code > without any resource release, which may lead to memleak. > > Signed-off-by: Dinghao Liu > --- > drivers/net/wireless/intersil/hostap/hostap_cs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH] drivers: net: wireless: struct lbs_private is declared duplicately

2021-04-07 Thread Kalle Valo
Wan Jiabing writes: > struct lbs_private has been declared at 22nd line. > Remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > drivers/net/wireless/marvell/libertas/decl.h | 1 - > 1 file changed, 1 deletion(-) The prefix should be "libertas:", I can fix that during commit. --

Re: [PATCH net-next] wlcore: fix overlapping snprintf arguments in debugfs

2021-04-07 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > gcc complains about undefined behavior in calling snprintf() > with the same buffer as input and output: > > drivers/net/wireless/ti/wl18xx/debugfs.c: In function > 'diversity_num_of_packets_per_ant_read': >

Re: [PATCH] brcmsmac: fix shift on 4 bit masked value

2021-04-07 Thread Kalle Valo
Colin King writes: > From: Colin Ian King > > The calculation of offtune_val seems incorrect, the u16 value in > pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then > shifted 8 places right so that always ends up as a zero result. I > believe the intended shift was 4 bits to the

Re: [PATCH net-next] mt76: mt7921: remove unneeded semicolon

2021-04-06 Thread Kalle Valo
Qiheng Lin writes: > Eliminate the following coccicheck warning: > drivers/net/wireless/mediatek/mt76/mt7921/mac.c:1402:2-3: Unneeded semicolon > > Signed-off-by: Qiheng Lin mt76 patches go to the mt76 tree maintained by Felix, not to net-next. --

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-06 Thread Kalle Valo
"Maciej S. Szmigiero" writes: > On 29.03.2021 00:54, Maciej S. Szmigiero wrote: >> Hi, >> >> It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS, >> since the driver does not update its beacon to account for TIM changes, >> so a station that is sleeping will never learn that

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-23 Thread Kalle Valo
Jiri Kosina wrote: > From: Jiri Kosina > > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs > disabled (e.g. from LED core). We can't enable BHs in such a situation. > > Turn the unconditional BH-enable/BH-disable code into > hardirq-disable/conditional-enable. > >

Re: [PATCH 00/10] rsi: fix comment syntax in file headers

2021-03-15 Thread Kalle Valo
Lukas Bulwahn writes: > On Sun, Mar 14, 2021 at 9:18 PM Aditya Srivastava > wrote: >> >> The opening comment mark '/**' is used for highlighting the beginning of >> kernel-doc comments. >> There are files in drivers/net/wireless/rsi which follow this syntax in >> their file headers, i.e. start

Re: wilc1000: write value to WILC_INTR2_ENABLE register

2021-03-15 Thread Kalle Valo
Marcus Folkesson wrote: > Write the value instead of reading it twice. > > Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver") > Signed-off-by: Marcus Folkesson Patch applied to wireless-drivers-next.git, thanks. e21b6e5a5462 wilc1000: write value to WILC_INTR2_ENABLE

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-13 Thread Kalle Valo
Luca Coelho writes: > On Sat, 2021-03-13 at 16:43 +0100, Jiri Kosina wrote: >> On Sat, 13 Mar 2021, Kalle Valo wrote: >> >> > > > > From: Jiri Kosina >> > > > > >> > > > > It's possible for iwl_pcie_enqueue_hcmd() to be

Re: [PATCH] iwlwifi: Fix softirq/hardirq disabling in iwl_pcie_enqueue_hcmd()

2021-03-12 Thread Kalle Valo
Jiri Kosina writes: > On Mon, 8 Mar 2021, Jiri Kosina wrote: > >> > From: Jiri Kosina >> > >> > It's possible for iwl_pcie_enqueue_hcmd() to be called with hard IRQs >> > disabled (e.g. from LED core). We can't enable BHs in such a situation. >> > >> > Turn the unconditional

Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized

2021-03-12 Thread Kalle Valo
Jarod Wilson writes: > Build currently fails with -Werror=maybe-uninitialized set: > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used > uninitialized in this function [-Werror=maybe-uninitialized] Really, build

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-03-10 Thread Kalle Valo
Kees Cook writes: > On Fri, Mar 05, 2021 at 03:40:33PM +0200, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >> >> > In preparation to enable -Wimplicit-fallthrough for Clang, fix >> > multiple warnings by replacing /* fall through */ comm

Re: [PATCH v3] ath10k: skip the wait for completion to recovery in shutdown path

2021-03-09 Thread Kalle Valo
: Youghandhar Chintala > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 018e3fa8e7ff ath10k: skip the wait for completion to recovery in shutdown path -- https://patchwork.kernel.org/project/linux-wireless/patch/20210223142908.23374-1-yough...@codeaurora.or

Re: [patch 10/14] ath9k: Use tasklet_disable_in_atomic()

2021-03-09 Thread Kalle Valo
ndrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: ath9k-de...@qca.qualcomm.com > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: linux-wirel...@vger.kernel.org > Cc: net...@vger.kernel.org > --- > drivers/net/wireless/ath/ath9k/beaco

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-03-05 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > In preparation to enable -Wimplicit-fallthrough for Clang, fix > multiple warnings by replacing /* fall through */ comments with > the new pseudo-keyword macro fallthrough; instead of letting the > code fall through to the next case. > > Notice that Clang doesn't

Re: [PATCH v2] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle())

2021-03-03 Thread Kalle Valo
Jiri Kosina writes: > On Wed, 3 Mar 2021, Kalle Valo wrote: > >> Patch applied to wireless-drivers.git, thanks. > > Thanks, but ... > >> 295d4cd82b01 iwlwifi: don't call netif_napi_add() with rxq->lock >> held (was Re: Lockdep warning in iwl_pcie_rx_handle()

Re: [PATCH v2] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle())

2021-03-03 Thread Kalle Valo
Jiri Kosina wrote: > From: Jiri Kosina > > We can't call netif_napi_add() with rxq-lock held, as there is a potential > for deadlock as spotted by lockdep (see below). rxq->lock is not > protecting anything over the netif_napi_add() codepath anyway, so let's > drop it just before calling into

Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings

2021-03-03 Thread Kalle Valo
Pierre-Louis Bossart wrote: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart > Acked-by: Luca Coelho Patch applied to wireless-drivers.git, thanks.

Re: [PATCH v2] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle())

2021-03-02 Thread Kalle Valo
"Coelho, Luciano" writes: > On Tue, 2021-03-02 at 11:34 +0100, Jiri Kosina wrote: >> From: Jiri Kosina >> >> We can't call netif_napi_add() with rxq-lock held, as there is a potential >> for deadlock as spotted by lockdep (see below). rxq->lock is not >> protecting anything over the

Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings

2021-03-02 Thread Kalle Valo
"Coelho, Luciano" writes: > On Tue, 2021-03-02 at 07:58 +0200, Kalle Valo wrote: >> Pierre-Louis Bossart writes: >> >> > An unsigned long variable should rely on '%lu' format strings, not '%zd' >> > >> > Fixes: a1a6a4cf49ece ("iwlwifi:

Re: [PATCH] iwlwifi: fix ARCH=i386 compilation warnings

2021-03-02 Thread Kalle Valo
Pierre-Louis Bossart writes: > An unsigned long variable should rely on '%lu' format strings, not '%zd' > > Fixes: a1a6a4cf49ece ("iwlwifi: pnvm: implement reading PNVM from UEFI") > Signed-off-by: Pierre-Louis Bossart > --- > warnings found with v5.12-rc1 and next-20210301 Luca, can I take

Re: [PATCH v2] bus: mhi: core: Add unique qrtr node id support

2021-03-01 Thread Kalle Valo
Bhaumik Bhatt writes: > On 2021-03-01 03:14 AM, Kalle Valo wrote: >> + ath11k list >> >> Manivannan Sadhasivam writes: >> >>> On Fri, Feb 26, 2021 at 04:12:49PM +0530, Gokul Sriram Palanisamy >>> wrote: >>>> On platforms with two

Re: [PATCH v2] bus: mhi: core: Add unique qrtr node id support

2021-03-01 Thread Kalle Valo
+ ath11k list Manivannan Sadhasivam writes: > On Fri, Feb 26, 2021 at 04:12:49PM +0530, Gokul Sriram Palanisamy wrote: >> On platforms with two or more identical mhi >> devices, qmi service will run with identical >> qrtr-node-id. Because of this identical ID, >> host qrtr-lookup cannot

Re: [PATCH v3 0/3] Add lockdep_assert_not_held()

2021-03-01 Thread Kalle Valo
Peter Zijlstra writes: > On Mon, Mar 01, 2021 at 10:45:32AM +0200, Kalle Valo wrote: >> Peter Zijlstra writes: >> >> > On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote: >> >> Shuah Khan (3): >> >> lockdep: add lockdep_assert_no

Re: [PATCH v3 0/3] Add lockdep_assert_not_held()

2021-03-01 Thread Kalle Valo
Peter Zijlstra writes: > On Fri, Feb 26, 2021 at 05:06:57PM -0700, Shuah Khan wrote: >> Shuah Khan (3): >> lockdep: add lockdep_assert_not_held() >> lockdep: add lockdep lock state defines >> ath10k: detect conf_mutex held ath10k_drain_tx() calls > > Thanks! Via which tree should these

Re: [PATCH] [v2] mt76: mt7915: fix unused 'mode' variable

2021-02-26 Thread Kalle Valo
+ linux-wireless Arnd Bergmann writes: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable > 'mode' is used uninitialized

Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

2021-02-26 Thread Kalle Valo
Heiner Kallweit writes: > On 26.02.2021 13:18, Kai-Heng Feng wrote: >> On Fri, Feb 26, 2021 at 8:10 PM Heiner Kallweit wrote: >>> >>> On 26.02.2021 08:12, Kalle Valo wrote: >>>> Kai-Heng Feng writes: >>>> >>>>> Now we have a

Re: [PATCH 1/2] mt76: mt7915: fix unused 'mode' variable

2021-02-26 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable > 'mode' is used uninitialized whenever switch

Re: [PATCH 2/2] mt76: mt7921: remove incorrect error handling

2021-02-26 Thread Kalle Valo
Arnd Bergmann wrote: > From: Arnd Bergmann > > Clang points out a mistake in the error handling in > mt7921_mcu_tx_rate_report(), which tries to dereference a pointer that > cannot be initialized because of the error that is being handled: > >

Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

2021-02-25 Thread Kalle Valo
es changed, 6 insertions(+), 2 deletions(-) It would have been nice to CC linux-wireless also on patches 1-2. I only saw patch 3 and had to search the rest of patches from lkml. I assume this goes via the PCI tree so: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/lin

Re: [PATCH] iwlwifi: fix link error without CONFIG_IWLMVM

2021-02-25 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > A runtime check that was introduced recently failed to > check for the matching Kconfig symbol: > > ld.lld: error: undefined symbol: iwl_so_trans_cfg referenced by drv.c net/wireless/intel/iwlwifi/pcie/drv.o:(iwl_pci_probe)

Re: [PATCH 1/2] mt76: mt7915: fix unused 'mode' variable

2021-02-25 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable > 'mode' is used uninitialized whenever switch

Re: [PATCH] qtnfmac: remove meaningless goto statement and labels

2021-02-25 Thread Kalle Valo
kernel test robot writes: > Hi samirweng1979, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on wireless-drivers-next/master] > [also build test ERROR on wireless-drivers/master sparc-next/master v5.11 > next-20210225] > [If your patch is applied to the wrong

Re: linux-next: Tree for Feb 23 [drivers/net/wireless/intel/iwlwifi/iwlwifi.ko]

2021-02-25 Thread Kalle Valo
Randy Dunlap writes: > On 2/22/21 10:35 PM, Stephen Rothwell wrote: >> Hi all, >> >> Please do not add any changes destined for v5.13 to your linux-next >> included branches until after v5.12-rc1 has been released. >> >> Changes since 20210222: >> > > Still seeing this build error on x86_64:

Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

2021-02-24 Thread Kalle Valo
writes: > On 24/02/21 10:13 pm, Kalle Valo wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> Marcus Folkesson writes: >> >>> Write the value instead of reading it twice. >>> >&g

Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

2021-02-24 Thread Kalle Valo
Marcus Folkesson writes: > Write the value instead of reading it twice. > > Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in > wilc_sdio.c file") > > Signed-off-by: Marcus Folkesson > --- > drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +- > 1 file changed, 1

Re: [PATCH] ath11k: qmi: use %pad to format dma_addr_t

2021-02-23 Thread Kalle Valo
Geert Uytterhoeven wrote: > If CONFIG_ARCH_DMA_ADDR_T_64BIT=n: > > drivers/net/wireless/ath/ath11k/qmi.c: In function > ‘ath11k_qmi_respond_fw_mem_request’: > drivers/net/wireless/ath/ath11k/qmi.c:1690:8: warning: format ‘%llx’ > expects argument of type ‘long long unsigned int’, but

Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-23 Thread Kalle Valo
Pkshih writes: > On Tue, 2021-02-23 at 09:08 +0200, Kalle Valo wrote: >> Pkshih writes: >> >> >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c >> >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c >> >> >

Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-22 Thread Kalle Valo
Pkshih writes: >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c >> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver = { >> >   .id_table = rtw_8822ce_id_table, >> >   .probe = rtw_pci_probe, >> >   .remove =

Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-22 Thread Kalle Valo
Hao Chen writes: > The laptop's wifi disconnect after the laptop HONOR MagicBook 14 > sleep to S3/S4 and wake up. > > The dmesg of kernel report: > "[ 99.990168] pcieport :00:01.2: can't change power state from D3hot > to D0 (config space inaccessible) > [ 99.990176] ACPI: EC: interrupt

Re: [PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-21 Thread Kalle Valo
buffer() potential null ptr > dereference") > Signed-off-by: Shuah Khan > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 14ebaeeff8d0 Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference" -- https://patchwork.kernel.org/pr

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-21 Thread Kalle Valo
陈浩 writes: > By git blame command, I know that the assignment of .driver.pm = > RTW_PM_OPS > > was in commit 44bc17f7f5b3b("rtw88: support wowlan feature for > 8822c"), > > and another commit 7dc7c41607d19("avoid unused function warnings") > > pointed out rtw_pci_resume() and rtw_pci_suspend()

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-20 Thread Kalle Valo
Hao Chen writes: > When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't > resume. > The dmesg of kernel report: > "[ 99.990168] pcieport :00:01.2: can't change power state > from D3hot to D0 (config space inaccessible) > [ 99.993334] rtw_pci :01:00.0: can't change

Re: linux-next: build warnings after merge of the net-next tree

2021-02-19 Thread Kalle Valo
Stephen Rothwell writes: > Hi all, > > On Fri, 19 Feb 2021 07:52:56 +1100 Stephen Rothwell > wrote: >> >> After merging the net-next tree, today's linux-next build (htmldocs) >> produced these warnings: >> >> Documentation/networking/filter.rst:1053: WARNING: Inline emphasis >> start-string

Re: undefined reference to `led_classdev_unregister'

2021-02-18 Thread Kalle Valo
kernel test robot writes: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f40ddce88593482919761f74910f42f4b84c004b > commit: 72cdab808714b1ec24b0c7bdebed163ce791f01f ath9k: Do not select > MAC80211_LEDS by default > date: 6 months ago > config:

Re: [PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-17 Thread Kalle Valo
buffer() potential null ptr > dereference") > Signed-off-by: Shuah Khan > Signed-off-by: Kalle Valo Thanks. I added the commit id and Fixes tag to the commit log, see the new version above. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210217211801.22540-1-sk...@linuxfoundation.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  1   2   3   4   5   6   7   8   9   10   >