add them in this patch.
thanks,
Kinglong Mee
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index b29b5a18
On Fri, Dec 22, 2017 at 8:35 AM, Colin King wrote:
> From: Colin Ian King
>
> The goto statement requires one more level of indentation, add it.
Those "break" in this switch need one more level too,
it's nice to add them in this patch.
thanks,
Kinglong Mee
>
> Sign
|| type == NODE))
- blk_finish_plug(current->plug);
-
if (type != DATA && type != NODE)
goto submit_io;
+ if (f2fs_sb_mounted_blkzoned(sbi->sb) && current->plug)
+ blk_finish_plug(current->plug);
_finish_plug(current->plug);
-
if (type != DATA && type != NODE)
goto submit_io;
+ if (f2fs_sb_mounted_blkzoned(sbi->sb) && current->plug)
+ blk_finish_plug(current->plug);
+
st
On 3/13/2017 20:10, Chao Yu wrote:
> free_nid_bitmap and free_nid_count in update_free_nid_bitmap should be
> updated atomically, use free_list_lock cover them to avoid race in
nid_list_lock?
Reviewed-by: Kinglong Mee <kinglong...@gmail.com>
> concurrent scenario.
>
> S
On 3/13/2017 20:10, Chao Yu wrote:
> free_nid_bitmap and free_nid_count in update_free_nid_bitmap should be
> updated atomically, use free_list_lock cover them to avoid race in
nid_list_lock?
Reviewed-by: Kinglong Mee
> concurrent scenario.
>
> Signed-off-by: Chao Yu
> ---
On 3/11/2017 01:53, Jaegeuk Kim wrote:
> This patch fixes missing le16 conversion, reported by kbuild test robot.
>
> Fixes: 5f35a2cd5 ("f2fs: Don't update the xattr data that same as the exist")
> Signed-off-by: Jaegeuk Kim <jaeg...@kernel.org>
Reviewed-by: Kinglon
On 3/11/2017 01:53, Jaegeuk Kim wrote:
> This patch fixes missing le16 conversion, reported by kbuild test robot.
>
> Fixes: 5f35a2cd5 ("f2fs: Don't update the xattr data that same as the exist")
> Signed-off-by: Jaegeuk Kim
Reviewed-by: Kinglong Mee
> ---
> f
e nid count of NAT block */
> + spinlock_t free_nid_lock; /* protect updating of nid count */
>
Sorry for my reply so late.
Is the free_nid_lock needed here?
The free_nid_count should be protected as free_nid_bitmap,
but there isn't any lock for free_nid_bitmap.
How about atomic?
The free node
inlock_t free_nid_lock; /* protect updating of nid count */
>
Sorry for my reply so late.
Is the free_nid_lock needed here?
The free_nid_count should be protected as free_nid_bitmap,
but there isn't any lock for free_nid_bitmap.
How about atomic?
The free node ids management seems
nto encrypted directory is permitted
right now.
I have a encrypted directory "ncry", "new" is unencrypted file.
[root@nfstestnic f2fs]# renameat2 -x encry/hello new
Operation not permitted
[root@nfstestnic f2fs]# renameat2 -x encry/hello new
Operation not permitted
How
nto encrypted directory is permitted
right now.
I have a encrypted directory "ncry", "new" is unencrypted file.
[root@nfstestnic f2fs]# renameat2 -x encry/hello new
Operation not permitted
[root@nfstestnic f2fs]# renameat2 -x encry/hello new
Operation not permitted
How do you
On 3/2/2017 09:35, Chao Yu wrote:
> On 2017/3/1 21:09, Kinglong Mee wrote:
>> On 3/1/2017 17:10, Chao Yu wrote:
>>> Both nat_bits cache and free_nid_bitmap cache provide same functionality
>>> as a intermediate cache between free nid cache and disk, but with
>>>
On 3/2/2017 09:35, Chao Yu wrote:
> On 2017/3/1 21:09, Kinglong Mee wrote:
>> On 3/1/2017 17:10, Chao Yu wrote:
>>> Both nat_bits cache and free_nid_bitmap cache provide same functionality
>>> as a intermediate cache between free nid cache and disk, but with
>>>
ree_nid_bitmap before load NAT blocks
Why not scan the full_nat_bits/empty_nat_bits before load NAT blocks here?
If after an objects shrinker, the cached free nid will be empty quickly.
thanks,
Kinglong Mee
> - update: update free_nid_bitmap in real-time
> - persistence: udpate and persist na
ree_nid_bitmap before load NAT blocks
Why not scan the full_nat_bits/empty_nat_bits before load NAT blocks here?
If after an objects shrinker, the cached free nid will be empty quickly.
thanks,
Kinglong Mee
> - update: update free_nid_bitmap in real-time
> - persistence: udpate and persist na
On 1/4/2017 09:23, Jaegeuk Kim wrote:
> Hi Kinglong,
>
> On 01/02, Kinglong Mee wrote:
>> A test program gets the SEEK_DATA with two values between
>> a new created file and the exist file on f2fs filesystem.
>>
>> F2FS filesystem, (the first "test1"
On 1/4/2017 09:23, Jaegeuk Kim wrote:
> Hi Kinglong,
>
> On 01/02, Kinglong Mee wrote:
>> A test program gets the SEEK_DATA with two values between
>> a new created file and the exist file on f2fs filesystem.
>>
>> F2FS filesystem, (the first "test1"
st", 5);
/* Get the alloc size by seek data equal zero*/
if (lseek(fd, 0, SEEK_DATA)) {
printf("SEEK_DATA size != 0 (offset = %d)\n", offset);
break;
}
}
close(fd);
return 0;
}
Sig
st", 5);
/* Get the alloc size by seek data equal zero*/
if (lseek(fd, 0, SEEK_DATA)) {
printf("SEEK_DATA size != 0 (offset = %d)\n", offset);
break;
}
}
close(fd);
return 0;
}
Signed-
Sorry for my fault.
Please drop the old version and use the new version 3.
thanks,
Kinglong Mee
On 7/21/2015 07:57, Stephen Rothwell wrote:
> Hi,
>
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/nfsd/nfs4st
Sorry for my fault.
Please drop the old version and use the new version 3.
thanks,
Kinglong Mee
On 7/21/2015 07:57, Stephen Rothwell wrote:
Hi,
After merging the nfsd tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/nfsd/nfs4state.c: In function
clude
> +#include
> +#include
> +#include "fs_event.h"
> +
> +static const struct genl_multicast_group fs_event_mcgroups[] = {
> + { .name = FS_EVENTS_MCAST_GRP_NAME, },
> +};
> +
> +static struct genl_family fs_event_family = {
> + .id = GENL_ID_GENERA
;
+
+ if (event_id != FS_EVENT_NONE)
+ size += nla_total_size(sizeof(u32));
+ size += nla_total_size(sizeof(u64));
What is this for ?
thanks
Kinglong Mee
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
c->total_sectors, c->sector_size);
> c->total_sectors = wanted_total_sectors;
>
> }
> @@ -504,7 +500,7 @@ int f2fs_get_device_info(struct f2fs_configuration *c)
> MSG(0, "Info: total sectors = %"
be modified as above too.
thanks,
Kinglong Mee
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
a_group_mask;
> + unsigned inta_other_mask;
> + unsigned short a_count;
> + unsigned short a_flags;
> + struct richace a_entries[0];
> +};
> +
> +#define richacl_for_each_entry(_ace, _acl) \
> + for (_ace = _acl->a_entries; \
> +
defined by rich-acl */
+#define ACL4_MASKED 0x80
For rich-acl, should not using ACL4_*** or ACE4_***.
thanks,
Kinglong Mee
+
+#define ACL4_VALID_FLAGS ( \
+ ACL4_MASKED)
+
+/* e_type values */
+#define ACE4_ACCESS_ALLOWED_ACE_TYPE 0x
28 matches
Mail list logo
